Re: building from git using custom koji install

2008-07-24 Thread Enrico Scholz
Jesus M. Rodriguez [EMAIL PROTECTED] writes: git://git.fedorahosted.org/git?spacewalk.git#HEAD But it complains about not having a spec file. Which makes sense as there is no spec file at the top of the tree. We solved a similar issue (building multiple branches from same sources) by passing

[MOCK/PATCH] Make logging line-buffered

2008-05-11 Thread Enrico Scholz
into a buffer which is given to logging after a newline. Signed-off-by: Enrico Scholz [EMAIL PROTECTED] --- py/mock/util.py | 46 +++--- 1 files changed, 35 insertions(+), 11 deletions(-) diff --git a/py/mock/util.py b/py/mock/util.py index 9f0eb3a..6e3d88e

[PATCH koji] Added support for building from git repositories

2007-09-15 Thread Enrico Scholz
is 'root). Hence, a '%(/sbin/killall5)' in the spec file can bring down the box. Signed-off-by: Enrico Scholz [EMAIL PROTECTED] --- builder/kojid | 130 +++- cli/koji |9 ++- koji.spec |2 - koji

[PATCH koji] added koji-helper setuid program

2007-09-15 Thread Enrico Scholz
not cross filesystem borders Methods above are implemented to replace the python 'safe_rmtree()' method which was never safe, nor will work when 'kojid' is running as non-root. Signed-off-by: Enrico Scholz [EMAIL PROTECTED] --- Makefile | 15 ++- builder/kojid | 53

Re: koji initialization, docs

2007-09-11 Thread Enrico Scholz
rob myers [EMAIL PROTECTED] writes: from what i remember, the first step is to import rpms for the distribution you are building against. Can be avoided by applying https://www.redhat.com/archives/fedora-buildsys-list/2007-May/msg00023.html and using an external repository. Enrico --

Re: koji initialization, docs

2007-09-11 Thread Enrico Scholz
Dennis Gilmore [EMAIL PROTECTED] writes: https://www.redhat.com/archives/fedora-buildsys-list/2007-May/msg00023.html Which breaks many things in koji. many? I am only aware of reproducability and did 735 builds/10968 tasks with this patch. such as reproducability. koji keeps track of and

[PATCH koji] Set proper permissions (0666) when creating files

2007-05-11 Thread Enrico Scholz
Currently, os.open() is used without specifying the third argument. Hence, all files will be created with 0777 perms (minus umask). Because only datafiles will be uploaded, the exec-bit should be removed. Signed-off-by: Enrico Scholz [EMAIL PROTECTED] --- builder/kojid |2 +- hub

[PATCH koji] Made 'mockpath' configurable for kojid

2007-05-07 Thread Enrico Scholz
Trying to set 'mockpath' in the configuration file results into an | unknown config option: mockpath error. Signed-off-by: Enrico Scholz [EMAIL PROTECTED] --- builder/kojid |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/builder/kojid b/builder/kojid index 7a66bfc

Re: [PATCH mock] Enhancements of the config_opts['macros'] handling

2007-05-07 Thread Enrico Scholz
Michael E Brown [EMAIL PROTECTED] writes: +def _expand_macro_string(self, macros): +res = [] +if isinstance(macros, dict): +for (key,v) in macros.items(): +res.append('%s\t%s' % (key,v)) +elif isinstance(macros, basestring): +

Re: [PATCH mock] Allow installation when /dev is mounted read-only

2007-05-07 Thread Enrico Scholz
Michael E Brown [EMAIL PROTECTED] writes: This patch bind-mounts a custom /etc/rpm directory to set the %_netsharedpath macro before doing the 'yum install' operation. Else, installation of filesystem package will fail due to a cpio error. This one is required IFF previous /dev patch is

Re: [PATCH mock] bind-mount the /var/lib/rpm from the chroot into the root directory

2007-05-07 Thread Enrico Scholz
Michael E Brown [EMAIL PROTECTED] writes: -rpmmacros.close() You just removed the close() on the macros file. This was probably not intended. No; it was intended. As a C++ developer I trust into (C)Python's reference counting + stack unwinding. Most python developers are doing

[PATCH mock] Enhancements of the config_opts['macros'] handling

2007-05-05 Thread Enrico Scholz
'%dist' and '%packager' ones. For backward compatibility strings are still supported; to retain a certain order of macros, they can be specified as tuples or lists too. Signed-off-by: Enrico Scholz [EMAIL PROTECTED] --- mock.py | 21 +++-- 1 files changed, 19 insertions(+), 2

[PATCH mock] bind-mount the /var/lib/rpm from the chroot into the root directory

2007-05-05 Thread Enrico Scholz
. Signed-off-by: Enrico Scholz [EMAIL PROTECTED] --- mock.py | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/mock.py b/mock.py index 6061907..df05920 100644 --- a/mock.py +++ b/mock.py @@ -502,6 +502,9 @@ class Root: self._mount('none --bind -o ro

Re: more mounts in mock

2006-05-26 Thread Enrico Scholz
[EMAIL PROTECTED] (Mike McLean) writes: Attached are a couple of patches that expand the mounts created in the chroot by mock. These are mounts that we've used for builds within Red Hat for years and some packages need them to compile properly. 1. 'mock' should be run in an own namespace;

Re: [PATCH] autocache patche -- resend, updated

2006-05-26 Thread Enrico Scholz
[EMAIL PROTECTED] (Michael E Brown) writes: Here is a resend/consolidation of the autocache patches from last week. I have combined the patches sent last week. It now defaults to gzip format. I have also made the following fixes: + check_dir_allowed (rootsdir, argv[2]); When you do