Re: Question about dist-cvs make targets

2010-01-08 Thread Till Maas
On Thu, Jan 07, 2010 at 09:28:26AM -0800, Jesse Keating wrote: As I proceed to port our make system over into fedpkg, I've ran across a couple targets that are giving me pause. Is anybody out there making use of the following targets? patch I use this quite often to generate patches, but

Re: Question about dist-cvs make targets

2010-01-08 Thread Till Maas
On Thu, Jan 07, 2010 at 07:47:10PM +0100, Enrico Scholz wrote: Jonathan Underwood jonathan.underw...@gmail.com writes: I have used make patch quite a bit when developing patches. I guess it's just a wrapper around gendiff though, so it maybe redundant i.e. in my use case I could have been

Re: Question about dist-cvs make targets

2010-01-08 Thread Andreas Schwab
Till Maas opensou...@till.name writes: Would you please provide more instructions about how to implement it and how to use it? quilt has builtin support for spec files. You only need to run quilt setup foo.spec. Andreas. -- Andreas Schwab, sch...@redhat.com GPG Key fingerprint = D4E8 DBE3

Re: Question about dist-cvs make targets

2010-01-08 Thread Jan Kratochvil
On Thu, 07 Jan 2010 18:28:26 +0100, Jesse Keating wrote: Is anybody out there making use of the following targets? I wanted to use this one: unused-fedora-patches but it does not work, it works only for kernel; fix has been ignored:

Question about dist-cvs make targets

2010-01-07 Thread Jesse Keating
As I proceed to port our make system over into fedpkg, I've ran across a couple targets that are giving me pause. Is anybody out there making use of the following targets? check export patch unused-patches unused-fedora-patches If so, please reply to which one, and in what scenario you use

Re: Question about dist-cvs make targets

2010-01-07 Thread David Cantrell
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thu, 7 Jan 2010, Jesse Keating wrote: As I proceed to port our make system over into fedpkg, I've ran across a couple targets that are giving me pause. Is anybody out there making use of the following targets? check export patch unused-patches

Re: Question about dist-cvs make targets

2010-01-07 Thread Jonathan Underwood
2010/1/7 Jesse Keating jkeat...@redhat.com: As I proceed to port our make system over into fedpkg, I've ran across a couple targets that are giving me pause. Is anybody out there making use of the following targets? check export patch unused-patches unused-fedora-patches If so, please

Re: Question about dist-cvs make targets

2010-01-07 Thread Dan Horák
Jesse Keating píše v Čt 07. 01. 2010 v 09:28 -0800: As I proceed to port our make system over into fedpkg, I've ran across a couple targets that are giving me pause. Is anybody out there making use of the following targets? unused-patches I tried to use this one when putting some

Re: Question about dist-cvs make targets

2010-01-07 Thread Daniel P. Berrange
On Thu, Jan 07, 2010 at 09:28:26AM -0800, Jesse Keating wrote: As I proceed to port our make system over into fedpkg, I've ran across a couple targets that are giving me pause. Is anybody out there making use of the following targets? check export patch unused-patches

Re: Question about dist-cvs make targets

2010-01-07 Thread Colin Walters
On Thu, Jan 7, 2010 at 5:28 PM, Jesse Keating jkeat...@redhat.com wrote: unused-patches I use this one, but it's probably something that should just happen as part of a build sanity check, or even better make it harder to cause (the new dist-git setup might do this right?) --

Re: Question about dist-cvs make targets

2010-01-07 Thread Adam Jackson
On Thu, 2010-01-07 at 07:51 -1000, David Cantrell wrote: I was using 'unused-patches' until the packaging guidelines had us change Patch lines to use %{name} if that applied. The unused-patches target would be helpful if it could expand RPM macros. That's a guideline worth ignoring. If I'm

Re: Question about dist-cvs make targets

2010-01-07 Thread Enrico Scholz
Jonathan Underwood jonathan.underw...@gmail.com writes: I have used make patch quite a bit when developing patches. I guess it's just a wrapper around gendiff though, so it maybe redundant i.e. in my use case I could have been using gendiff. fwiw, 'gendiff' does not retain comments in patches

Re: Question about dist-cvs make targets

2010-01-07 Thread Jesse Keating
On Thu, 2010-01-07 at 19:47 +0100, Enrico Scholz wrote: Jonathan Underwood jonathan.underw...@gmail.com writes: I have used make patch quite a bit when developing patches. I guess it's just a wrapper around gendiff though, so it maybe redundant i.e. in my use case I could have been using

Re: Question about dist-cvs make targets

2010-01-07 Thread Jason L Tibbitts III
DC == David Cantrell dcantr...@redhat.com writes: DC I was using 'unused-patches' until the packaging guidelines had us DC change Patch lines to use %{name} if that applied. Please quote chapter and verse there. I don't recall any guidelines requiring such a thing. - J -- fedora-devel-list

Re: Question about dist-cvs make targets

2010-01-07 Thread Panu Matilainen
On Thu, 7 Jan 2010, Jesse Keating wrote: As I proceed to port our make system over into fedpkg, I've ran across a couple targets that are giving me pause. Is anybody out there making use of the following targets? unused-patches I use this fairly often, typically to clean up leftovers after