Re: Rationale behind _cmake_skip_rpath choice in /etc/rpm/macros.cmake

2009-10-21 Thread Rex Dieter
Kevin Kofler wrote: > Rex Dieter wrote: >> I'm convinced to revert, I'll run the change by my fellow cmake >> maintainers (I think we have buy-in from everyone though). > > Please test that we really don't end up with standard paths like /usr/lib > or /usr/lib64 in the rpath of installed executab

Re: Rationale behind _cmake_skip_rpath choice in /etc/rpm/macros.cmake

2009-10-21 Thread Kevin Kofler
Theodore Papadopoulo wrote: > According to http://www.itk.org/Wiki/CMake_RPATH_handling this is now > corrected since almost two years (december 2007). We tried it in a 2.6.x, which is more recent than that, and it didn't work. (We ended up with things like /usr/lib or /usr/lib64 being set as an

Re: Rationale behind _cmake_skip_rpath choice in /etc/rpm/macros.cmake

2009-10-20 Thread Kevin Kofler
Rex Dieter wrote: > I'm convinced to revert, I'll run the change by my fellow cmake > maintainers (I think we have buy-in from everyone though). Please test that we really don't end up with standard paths like /usr/lib or /usr/lib64 in the rpath of installed executables when doing that! Last time

Re: Rationale behind _cmake_skip_rpath choice in /etc/rpm/macros.cmake

2009-10-20 Thread Rex Dieter
Theodore Papadopoulo wrote: > There might be some other very good reason for keeping those lines, but > I do not see it (Rex ? since you added the lines, > maybe you remember what was the motivation ?). I'm convinced to revert, I'll run the change by my fellow cmake maintainers (I think we have

Re: Rationale behind _cmake_skip_rpath choice in /etc/rpm/macros.cmake

2009-10-20 Thread Theodore Papadopoulo
Kevin Kofler wrote: Theodore Papadopoulo wrote: I would like to understand why the file macros.cmake as distributed in fedora-10 defines: %_cmake_skip_rpath -DCMAKE_SKIP_RPATH:BOOL=ON Because otherwise installed binaries would end up with rpaths, even for standard library paths. (Prob

Re: Rationale behind _cmake_skip_rpath choice in /etc/rpm/macros.cmake

2009-10-15 Thread Kevin Kofler
Theodore Papadopoulo wrote: > I would like to understand why the file macros.cmake as distributed in > fedora-10 defines: > %_cmake_skip_rpath -DCMAKE_SKIP_RPATH:BOOL=ON Because otherwise installed binaries would end up with rpaths, even for standard library paths. (Probably a bug, I wonder if th

Re: Rationale behind _cmake_skip_rpath choice in /etc/rpm/macros.cmake

2009-10-14 Thread Rex Dieter
Theodore Papadopoulo wrote: > I would like to understand why the file macros.cmake as distributed in > fedora-10 defines: > %_cmake_skip_rpath -DCMAKE_SKIP_RPATH:BOOL=ON or just %define _cmake_skip_rpath %{nil} to disable (why it was made a macro, so it's easy to change or override). It's probab

Rationale behind _cmake_skip_rpath choice in /etc/rpm/macros.cmake

2009-10-14 Thread Theodore Papadopoulo
I would like to understand why the file macros.cmake as distributed in fedora-10 defines: %_cmake_skip_rpath -DCMAKE_SKIP_RPATH:BOOL=ON I use cmake to build an rpm for a software that builds several libraries and binaries (based on those libraries). In the spec file of my rpm I decided to add