On Wed, 2009-03-11 at 11:55 -0400, Kyle McMartin wrote:
> On Wed, Mar 11, 2009 at 11:33:25AM -0400, Josh Boyer wrote:
> > >+#if __OS_HAS_AGP
> >
> > Not that this is your fault, but shouldn't this be something
> > like __ARCH_HAS_AGP?
> >
>
> Keep in mind the DRM for better or for worse supposed
On Wed, Mar 11, 2009 at 11:55:53AM -0400, Kyle McMartin wrote:
>On Wed, Mar 11, 2009 at 11:33:25AM -0400, Josh Boyer wrote:
>> >+#if __OS_HAS_AGP
>>
>> Not that this is your fault, but shouldn't this be something
>> like __ARCH_HAS_AGP?
>>
>
>Keep in mind the DRM for better or for worse supposedl
On 03/11/2009 11:33 AM, Josh Boyer wrote:
>> +#if __OS_HAS_AGP
>
> Not that this is your fault, but shouldn't this be something
> like __ARCH_HAS_AGP?
Maybe, but I'm not about to redefine existing kernel defines for the
purposes of logic. ;)
~spot
___
On Wed, Mar 11, 2009 at 11:33:25AM -0400, Josh Boyer wrote:
> >+#if __OS_HAS_AGP
>
> Not that this is your fault, but shouldn't this be something
> like __ARCH_HAS_AGP?
>
Keep in mind the DRM for better or for worse supposedly supports more
OSes than just Linux.
I suspect the 'ideal' fix for up
On Wed, Mar 11, 2009 at 10:27:51AM -0400, Tom spot Callaway wrote:
>The radeon_buffer.c addition that gets pulled into the DRM driver as
>part of Kernel Mode Setting (even if you disable KMS for the Radeon
>driver) was assuming that it was safe to use symbols from the AGP code,
>but that isn't safe
The radeon_buffer.c addition that gets pulled into the DRM driver as
part of Kernel Mode Setting (even if you disable KMS for the Radeon
driver) was assuming that it was safe to use symbols from the AGP code,
but that isn't safe on platforms where __OS_HAS_AGP is 0. Such as
sparc64. :)
This patch
Dave Jones wrote:
On Wed, Mar 11, 2009 at 09:52:44AM +0100, Oliver Falk wrote:
> Oliver Falk wrote:
> > Hi!
> >
> > Changed the subject, as happens that I oversee the mails :-(
> > And this subject is more descriptive, isn't it?
> >
> > Kyle McMartin wrote:
> > [ ... ]
> >> This all
On Wed, Mar 11, 2009 at 09:52:44AM +0100, Oliver Falk wrote:
> Oliver Falk wrote:
> > Hi!
> >
> > Changed the subject, as happens that I oversee the mails :-(
> > And this subject is more descriptive, isn't it?
> >
> > Kyle McMartin wrote:
> > [ ... ]
> >> This all looks fine to me.
> >
Oliver Falk wrote:
Hi!
Changed the subject, as happens that I oversee the mails :-(
And this subject is more descriptive, isn't it?
Kyle McMartin wrote:
[ ... ]
This all looks fine to me.
May I interpret this as a *GO*? :-)
> Sorry to have been so blunt, but I'm fairly
new to Fedora, so I
