[Bug 173388] Review Request: mod_evasive - Denial of Service evasion module for Apache

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mod_evasive - Denial of Service evasion module for 
Apache


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173388


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 02:23 EST ---
done

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 233142] Review Request: asc - Advanced Strategic Command

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: asc - Advanced Strategic Command


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233142


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 02:31 EST ---
done

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226232] Merge Review: passwd

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: passwd


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226232


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 234858] Review Request: perl-User-Identity - Maintains info about a physical person

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-User-Identity - Maintains info about a physical 
person
Alias: perl-User-Identity

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234858


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 02:35 EST ---
done

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225293] Merge Review: authconfig

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: authconfig


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225293


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226224] Merge Review: pam_ccreds

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: pam_ccreds


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226224


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 187621] Review Request: blam

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: blam


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187621


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 02:42 EST ---
done

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 200249] Review Request: cvs2svn

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cvs2svn


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200249


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 02:48 EST ---
done

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226130] Merge Review: man-pages

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: man-pages


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226130


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|MODIFIED|ASSIGNED
 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
   Flag|fedora-review?  |fedora-review+




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226118] Merge Review: mailx

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: mailx


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226118


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 02:55 EST ---
APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 234436] Review Request: glchess - GlChess, a 3d Chess game using OpenGL

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: glchess - GlChess, a 3d Chess game using OpenGL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234436





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 03:11 EST ---
(In reply to comment #2)
 Created an attachment (id=151678)
 -- 
(https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=151678action=view) 
[edit]
 mock build log of glchess-1.0.4-1 on FC-devel i386
 
 Well, for 1.0.4-1:
 
 * BuildRequires
   - mockbuild failed. At least desktop-file-utils is missing
 for BuildRequires.
 
Fixed

 * Executable permissions/shebang
 
 # make rpmlint happy
 chmod +x $RPM_BUILD_ROOT%{python_sitelib}/%{name}/scene/opengl/png.py \
   $RPM_BUILD_ROOT%{python_sitelib}/%{name}/gtkui/__init__.py
 
   - IMO the resolution should be opposite.
 

Fixed for one of the 2 files, the other can be executed stand alone

 * GConf files
 
 %config(noreplace) %{_sysconfdir}/gconf/schemas/glchess.schemas
 
   - Well, while I cannot find any wiki packages, however I am
 sure that GConf schemas files under /etc/gconf/schemas is
 generally _not_ regarded as config file and should not
 marked as %config (even if rpmlint complains about it).
 

Fixed

 * Some python related dependency
   - Well, would you check the following import sentence?
 * import Image (from opengl/texture.py: Perhaps python-imaging
   It seems that Packages link from http://glchess.sourceforge.net/
   requires it)

python-imaging is not required, it will fallback to an alternative png loading
routine if python-imageging is not installed, and all the included textures are
png, so that will work fine:
try:
self.__loadPIL(fileName)
except ImportError:
self.__loadPNG(fileName)


New version here:
Spec URL: http://people.atrpms.net/~hdegoede/glchess.spec
SRPM URL: http://people.atrpms.net/~hdegoede/glchess-1.0.4-2.fc7.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226320] Merge Review: psacct

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: psacct


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226320


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
   Flag||fedora-review+




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 234031] Review Request: eclipse-pydev - an Eclipse plugin for working with Python.

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eclipse-pydev - an Eclipse plugin for working with 
Python.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234031





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 03:52 EST ---
(In reply to comment #18)

 Tim, you may be right that JDT is required. What was the error you were 
 getting
 without it?
I dont get any visible errors, it is just not working, there is no PyDev entry
in Windows - Preferences.
In The About - Plugin details i only see 2 org.python.pydev plugins (ast 
online help) the other org.python.pydev is missing.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 235471] Review Request: perl-PDF-API2 - Perl module for creation and modification of PDF files

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-PDF-API2 - Perl module for creation and 
modification of PDF files


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235471





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 04:10 EST ---
Spec URL: http://symetrix.com/~bjohnson/projects/fedora/perl-PDF-API2.spec
SRPM URL:
http://symetrix.com/~bjohnson/projects/fedora/perl-PDF-API2-0.59.002-2.src.rpm

* Fri Apr 06 2007 Bernard Johnson [EMAIL PROTECTED] - 0.59.002-2
- moving resource to docs was a mistake, fix it

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226113] Merge Review: lynx

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: lynx


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226113





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 04:38 EST ---
Thanks

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 233848] Review Request: perl-SVG-Graph - Visualize your data in Scalable Vector Graphics (SVG) format

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SVG-Graph - Visualize your data in Scalable 
Vector Graphics (SVG) format
Alias: perl-SVG-Graph

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233848





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 04:44 EST ---
Can you please do an initial review pending updating of tarball because this is
currently blocking the build of bug #234573.  Upstream is taking a while to do
the update, but we *do* know that it is under the Artistic license.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 233848] Review Request: perl-SVG-Graph - Visualize your data in Scalable Vector Graphics (SVG) format

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SVG-Graph - Visualize your data in Scalable 
Vector Graphics (SVG) format
Alias: perl-SVG-Graph

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233848


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|234573  |
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 234573] Review Request: perl-bioperl - A package of Perl tools for computational molecular biology

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-bioperl - A package of Perl tools for 
computational molecular biology
Alias: perl-bioperl

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234573


[EMAIL PROTECTED] changed:

   What|Removed |Added

  BugsThisDependsOn|233848  |




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 233848] Review Request: perl-SVG-Graph - Visualize your data in Scalable Vector Graphics (SVG) format

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SVG-Graph - Visualize your data in Scalable 
Vector Graphics (SVG) format
Alias: perl-SVG-Graph

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233848


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||234573
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 234573] Review Request: perl-bioperl - A package of Perl tools for computational molecular biology

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-bioperl - A package of Perl tools for 
computational molecular biology
Alias: perl-bioperl

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234573


[EMAIL PROTECTED] changed:

   What|Removed |Added

  BugsThisDependsOn||233848




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 233142] Review Request: asc - Advanced Strategic Command

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: asc - Advanced Strategic Command


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233142


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 04:48 EST ---
Thanks for the review!

Imported and build, closing.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 233139] Review Request: SDLmm - C++ interface for the popular SDL library

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: SDLmm - C++ interface for the popular SDL library
Alias: SDLmm

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233139


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 234835] Review Request: fgfs-Atlas - Flightgear map tools

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fgfs-Atlas - Flightgear map tools


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234835





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 04:52 EST ---
Jochen, 

Will you also review FlightGear itself? Also you still haven't answered my
question yet, can (and will) you sponsor Fabrice, or shall I?

Fabrice do you want to import these 2 now, or do you want to wait till
FlightGear itself is also reviewed?




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225066] Review Request: gedit-plugins - Collections of plugins for gedit

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gedit-plugins - Collections of plugins for gedit


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225066





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 05:02 EST ---
Traceback (most recent call last):
  File /usr/lib/gedit-2/plugins/sessionsaver/dialogs.py, line 35, in
on_session_added
self.row_inserted(self.on_get_path(piter), piter)
TypeError: iter should be a GtkTreeIter

** (gedit:12835): CRITICAL **: gedit_commands_load_uris: assertion `(uris !=
NULL)  (uris-data != NULL)' failed

Manage saved sessions... still opens very damaged windows here, and
hence I still think the plugin ought to be excluded.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 234750] Review Request: avr-binutils - Cross Compiling GNU binutils targeted at avr

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: avr-binutils - Cross Compiling GNU binutils targeted 
at avr


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234750





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 05:02 EST ---
(In reply to comment #18)
 In my specs I do all these steps this way:
 %prep
 %setup -q -c -T -n %{name}-%{version}
 %setup -q -D -T -n %{name}-%{version} -a0
 

Erm why not just:
%prep
%setup -q -c

That has exactly the same effect.

 Finally: As you already know, I dislike a toolchains using an architecture 
 (avr)
 as their target

I know, but as long as almost the whole world does it like this I'm not planning
on changing this.

All other Must's and Should's fixed, new version here:
Spec URL: http://people.atrpms.net/~hdegoede/avr-binutils.spec
SRPM URL: http://people.atrpms.net/~hdegoede/avr-binutils-2.17-2.fc7.src.rpm



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 234750] Review Request: avr-binutils - Cross Compiling GNU binutils targeted at avr

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: avr-binutils - Cross Compiling GNU binutils targeted 
at avr


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234750





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 05:23 EST ---
(In reply to comment #19)
 (In reply to comment #18)
  Finally: As you already know, I dislike a toolchains using an architecture 
  (avr)
  as their target
 
 I know, but as long as almost the whole world does it like this I'm not 
 planning
 on changing this.

Even though I in principle agree with Ralf, I think it is to much trouble to try
to convince the rest of the world. As everybody else uses only avr as target, I
 think it justifies the exception.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226671] Merge Review: zlib

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: zlib


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226671


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|ASSIGNED
   Flag|needinfo?   |




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 05:46 EST ---
Patrice,
could you please look at the last version zlib-1.2.3-10.fc7 and approved this
review request or if you see any reason why you don't want to aproved it here. 

But at first I want to reply to your comments:
* adding autotools is the most clear solution and there is no problem with it
* zutil.h is removed
* timestamps are kept
* the description is easy to get/find/grab it is not a part of zlib package and
upstream don't want to add it so I think it is not necessary to add it too

Thanks for your comments. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226671] Merge Review: zlib

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: zlib


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226671





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 07:47 EST ---
Created an attachment (id=151869)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=151869action=view)
spec file that incorporates all my comments

I removed the autotools patch in this spec. I think that such change
is for upstream, not in a fedora package. Moreover this is not 
similar with upstream since the tests are removed.

I cleaned the build such that the package is built in the build section
and also used more rpm macros.

and I added the manual, in my opinion this is a must

- don't use the autotools, instead revert to the previous build procedure
- ship the manual to have a description of the API
- build the libraries in the %%build section

rpmlint output is explained in comments in the spec
E: zlib configure-without-libdir-spec
W: zlib make-check-outside-check-section make check
E: zlib configure-without-libdir-spec
W: zlib make-check-outside-check-section make check

Feel free to modify it again (for example if you like the build
but not the manual).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226671] Merge Review: zlib

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: zlib


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226671





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 07:55 EST ---
Created an attachment (id=151870)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=151870action=view)
keep header and man page timestamps


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225861] Merge Review: grub

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: grub


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225861


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 07:59 EST ---
Just noticed:

$ LC_ALL=C rpm -qf /boot/grub/*
file /boot/grub/device.map is not owned by any package
file /boot/grub/e2fs_stage1_5 is not owned by any package
file /boot/grub/fat_stage1_5 is not owned by any package
file /boot/grub/ffs_stage1_5 is not owned by any package
file /boot/grub/grub.conf is not owned by any package
file /boot/grub/iso9660_stage1_5 is not owned by any package
file /boot/grub/jfs_stage1_5 is not owned by any package
file /boot/grub/menu.lst is not owned by any package
file /boot/grub/minix_stage1_5 is not owned by any package
file /boot/grub/reiserfs_stage1_5 is not owned by any package
fedora-logos-6.0.97-2.fc7
file /boot/grub/stage1 is not owned by any package
file /boot/grub/stage2 is not owned by any package
file /boot/grub/ufs2_stage1_5 is not owned by any package
file /boot/grub/vstafs_stage1_5 is not owned by any package
file /boot/grub/xfs_stage1_5 is not owned by any package

I'd say all those unowned files should be ghost-owned by grub.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 235501] New: Review Request: jsdoc - Produces javadoc-style documentation from JavaScript sourcefiles

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235501

   Summary: Review Request: jsdoc - Produces javadoc-style
documentation from JavaScript sourcefiles
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://www.ceplovi.cz/matej/progs/rpms/jsdoc.spec
SRPM URL: http://www.ceplovi.cz/matej/progs/rpms/jsdoc-1.10.2-1.src.rpm
Description:
A script that produces javadoc-style documentation from
well-formed JavaScript sourcefiles. At the moment, this means it
supports sourcefiles where all functions are mapped to a class
using prototype-based inheritance.  Anonymous function
definitions (e.g. Circle.prototype.getRadius = function(){ ...} )
are supported.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 233848] Review Request: perl-SVG-Graph - Visualize your data in Scalable Vector Graphics (SVG) format

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SVG-Graph - Visualize your data in Scalable 
Vector Graphics (SVG) format
Alias: perl-SVG-Graph

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233848





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 08:12 EST ---
* Fri Apr 06 2007 Alex Lancaster [EMAIL PROTECTED] 0.01-2
- Updated license.
- Add BR: perl(ExtUtils::MakeMaker)

Spec URL: http://allele5.biol.berkeley.edu/~alex/fedora/perl-SVG-Graph.spec
SRPM URL: 
http://allele5.biol.berkeley.edu/~alex/fedora/perl-SVG-Graph-0.01-2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 234835] Review Request: fgfs-Atlas - Flightgear map tools

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fgfs-Atlas - Flightgear map tools


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234835





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 08:16 EST ---
Hans,

Yes, I can import fgfs-base and fgfs-Atlas now, and build them.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194279] Review Request: kdeartwork: Extra KDE artwork (themes, sound themes, ...) for KDE

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kdeartwork: Extra KDE artwork (themes, sound themes, 
...) for KDE


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194279


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 08:36 EST ---
marked approved, per comment #24.

please update in cvs (I don't have access yet, poo), and then you can close 
this.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 227241] Review Request: kde-settings - Config files for kde

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kde-settings -  Config files for kde


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227241


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium

[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163776  |
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 08:37 EST ---
Chitlesh, ping?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225960] Merge Review: kdbg

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: kdbg


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225960


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 200236] Review Request: kdeaddons: K Desktop Environment - Plugins

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kdeaddons: K Desktop Environment - Plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200236


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Keywords|Reopened|
 Resolution||RAWHIDE




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194374] Review Request: kdegames: K Desktop Environment - Games

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kdegames: K Desktop Environment - Games


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194374


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194278] Review Request: kdeadmin: Administrative tools for KDE

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kdeadmin: Administrative tools for KDE


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194278


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Keywords|Reopened|
 Resolution||RAWHIDE




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 08:39 EST ---
closing per comment #7 (no need to wait for merge)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225961] Merge Review: kdebase

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: kdebase


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225961


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194280] Review Request: kdebindings: KDE/DCOP bindings to non-C++ languages

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kdebindings: KDE/DCOP bindings to non-C++ languages


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194280


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 08:40 EST ---
than, can you update cvs?  then you can close this ticket.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194373] Review Request: kdeedu: Educational/Edutainment applications

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kdeedu: Educational/Edutainment applications


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194373


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194374] Review Request: kdegames: K Desktop Environment - Games

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kdegames: K Desktop Environment - Games


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194374


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE
 CC||[EMAIL PROTECTED]
OtherBugsDependingO|163779  |
  nThis||
   Flag||fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 08:42 EST ---
approved per comment #19, closing-rawhide per comment #21

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 195485] Review Request: kdegraphics: K Desktop Environment - Graphics Applications

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kdegraphics: K Desktop Environment - Graphics 
Applications


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195485


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 08:42 EST ---
than, please update cvs, and then you can close this.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 200236] Review Request: kdeaddons: K Desktop Environment - Plugins

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kdeaddons: K Desktop Environment - Plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200236


Bug 200236 depends on bug 194374, which changed state.

Bug 194374 Summary: Review Request: kdegames: K Desktop Environment - Games
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194374

   What|Old Value   |New Value

 Resolution||RAWHIDE
 Status|ASSIGNED|CLOSED



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225963] Merge Review: kdelibs

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: kdelibs


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225963


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Keywords|Reopened|
 Resolution||RAWHIDE




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225964] Merge Review: kdemultimedia

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: kdemultimedia


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225964


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 195486] Review Request: kdenetwork: K Desktop Environment - Network Applications

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kdenetwork: K Desktop Environment - Network 
Applications


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195486


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 08:43 EST ---
than, please update cvs, then you can close this.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225965] Merge Review: kdepim

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: kdepim


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225965


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 235501] Review Request: jsdoc - Produces javadoc-style documentation from JavaScript sourcefiles

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jsdoc - Produces javadoc-style documentation from 
JavaScript sourcefiles


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235501





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 08:51 EST ---
Currently there is a known problem with this package -- missing license. I am
trying to get upstream to make some changes in that.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 234721] Review Request: sakura - A terminal emulator based on GTK+ and VTE

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sakura - A terminal emulator based on GTK+ and VTE


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234721


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226671] Merge Review: zlib

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: zlib


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226671





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 09:43 EST ---
I think that the spec I proposed in Comment #10 is right,
but if you really want to use the autotools and think my 
proposal is not right, I could also accept an autotool based
package -- although I think it is not right.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 234721] Review Request: sakura - A terminal emulator based on GTK+ and VTE

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sakura - A terminal emulator based on GTK+ and VTE


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234721





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 10:48 EST ---
Well,

You should add flags INSTALL=install -p to your make install to keep timestamp
on files, such as doc files, *.png files (which is included including in this
package).

--
.desktop file
--

** category: Application and X-fedora is deprecated and SHOULD be remove.

  can be fix by adding -remove-category= option

** .desktop file : no correct permission - 0664

[EMAIL PROTECTED] ~]$ ll rpmbuild/SOURCES/sakura.desktop 
-rw-rw-r-- 1 SmootherFrOg lxtnow 271 Apr 6 09:47 rpmbuild/SOURCES/sakura.desktop

  can be fix by adding -mode 0644 option from desktop-file-install.

** scriptlets:

%post
update-desktop-database  /dev/null ||:

%postun
update-desktop-database  /dev/null ||:

The use of above is only require when the desktop entry have a mime type key.
and isn't the case.
This scriptlet can be remove.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 235376] Review Request: ocsinventory-ipdiscover - Open Computer and Software Inventory Next Generation client

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocsinventory-ipdiscover - Open Computer and Software 
Inventory Next Generation client


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235376





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 11:32 EST ---
Spec URL: http://remi.collet.free.fr/rpms/extras/ocsinventory-ipdiscover.spec
SRPM URL:
http://remi.collet.free.fr/rpms/extras/ocsinventory-ipdiscover-1.01-2.fc7.src.rpm

* Fri Apr 06 2007 Remi Collet [EMAIL PROTECTED] 1.01-2
- change source URL
- add ocsinventory-ipdiscover.patch


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 234436] Review Request: glchess - GlChess, a 3d Chess game using OpenGL

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: glchess - GlChess, a 3d Chess game using OpenGL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234436


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 11:33 EST ---
Okay.

-
  This package (glchess) is APPROVED by me.
-

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203520] Review Request: evolution-brutus

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: evolution-brutus
Alias: evolution-brutus

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203520





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 11:37 EST ---
I haven't had a chance to look at your updated spec Jules, but my experience
with other packages is that using a generic spec file from the tarball usually
doesn't work in the long run.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 222087] Review Request: pcmanx-gtk2 - Telnet client designed for BBS browsing

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pcmanx-gtk2 - Telnet client designed for BBS browsing


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222087





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 11:40 EST ---
Well, this is svn version, right?
I suppose svn version does not have configure, etc...

So please 
* write in the spec file how you created this tarball as a comment
  like

# The svn version tarball is created by the following command
# $ svn .
# $ tar .

  so that I can reproduce the tarball which you used.

* write from autoreconf,  in %prep stage and add appropriate
  BuildRequires.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 208034] Review Request: HippoDraw - Interactive and Python scriptable data analysis application

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: HippoDraw - Interactive and Python scriptable data 
analysis application


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208034





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 11:46 EST ---
Well, I still think that
* having config.h installed in -devel package
* #ifdef judgment for HAVE_NUMPY HAVE_NUMARRAY etc... being
  included in header files
are wrong as said in comment 40.

IMO you should remove unnecessary header files and
remove confusing ifdef judgment.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203520] Review Request: evolution-brutus

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: evolution-brutus
Alias: evolution-brutus

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203520





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 11:50 EST ---
Well, then should I wait until you upload a new spec/srpm,
Brian?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226406] Merge Review: selinux-policy

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: selinux-policy


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226406


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 12:04 EST ---
selinux-policy-targeted outputs a bunch of stuff to the console during an
upgrade, this is an example output:
/sbin/restorecon reset /etc/cron.daily/000-delay.cron context
system_u:object_r:etc_t:s0-system_u:object_r:bin_t:s0

If this is important it should be sent to syslog with the logger command,
otherwise it should be surpressed.

I don't know if there is a guideline to prevent spurious output to the console
during upgrades, but there should be.

There is nothing more annoying than a package outputting a ton of stuff to your
console.  One really bad side effect is that you can no longer scroll back to
see which config files were backed up, and you have to run updatedb just to find
the .rpmnew/.rpmsave files again because some package spewed out a bunch of text
preventing you from just simply scrolling up to find out.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203520] Review Request: evolution-brutus

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: evolution-brutus
Alias: evolution-brutus

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203520





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 12:09 EST ---
(In reply to comment #78)
 Well, then should I wait until you upload a new spec/srpm,
 Brian?

Probably. after a quick look at Jules spec there's a few things that should
probably be changed (Unnecessary requires, use %doc, etc).  Of course, I've got
to get some new web-space to upload to, since I shutdown my webserver over the
holidays. ;)



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 234721] Review Request: sakura - A terminal emulator based on GTK+ and VTE

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sakura - A terminal emulator based on GTK+ and VTE


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234721


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 12:19 EST ---
Some notes:
* Timestamps
  - Well, while the method 'INSTALL=%{__install} -p' normally
works for makefile.in generated by GNU autotools, 
for the types of makefiles which were created by developer 
by his own way (like this package), it is very rare that
this method still works (and actually for this package
it does not work).
For the latter case, the packager has to check what are actually
done on install stage and fix some files appropriately.
Normally the package has to change the command like cp or
install appropriately (see the lines 119-148 of mobs.mk).

* Cflags
  - And for makefiles generated by GNU autotools, fedora specific
compilation flags are normally passed correctly by %configure
macro (please check what %configure actually does),
however, again for the types of makefiles created by the developer's
own way, passing cflags has to be done with a special care
Actually
--
%build
./0 --prefix=/usr
make %{?_smp_mflags}
--
does not use fedora specific compilation flags (%optflags or
$RPM_BUILD_FLAGS). You have to use this flags _somehow_

* Desktop file
  - Be careful on the each item on desktop file (e.g. is the
path for icon used correct? in the first place, does the
path have to be specified by full path?)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 222087] Review Request: pcmanx-gtk2 - Telnet client designed for BBS browsing

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pcmanx-gtk2 - Telnet client designed for BBS browsing


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222087





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 12:28 EST ---
Done!

SRPM:
http://www.srcf.ucam.org/~sl392/fedora/SRPMs/pcmanx-gtk2-0.3.5-7.20070406svn.leof6.src.rpm
SPEC: http://www.srcf.ucam.org/~sl392/fedora/SRPMs/pcmanx-gtk2.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 234721] Review Request: sakura - A terminal emulator based on GTK+ and VTE

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sakura - A terminal emulator based on GTK+ and VTE


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234721





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 12:28 EST ---
(In reply to comment #4)
 $RPM_BUILD_FLAGS). 

$RPM_OPT_FLAGS, sorry


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 223943] Review Request: Nemiver - A C/C++ Debugger for GNOME - point, click, debug!

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Nemiver - A C/C++ Debugger for GNOME - point, click, 
debug!
Alias: nemiver

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223943





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 12:56 EST ---
ping.

I am going to approve this as soon as you can provide some info about my remarks

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 223943] Review Request: Nemiver - A C/C++ Debugger for GNOME - point, click, debug!

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Nemiver - A C/C++ Debugger for GNOME - point, click, 
debug!
Alias: nemiver

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223943





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 13:24 EST ---
Pong :) 

Hi, Gianluca and Thanks for the review!

(In reply to comment #33)
 Just a couple questions: 
 is the touch trick for forcing the icon cache update the
 usual/preferred/best way to do that?

It is, according to the Packaging/ScriptletSnippets page on the wiki.

 are you going to remove COPYING from the -devel subpackage as suggested in
 comment #2?
No. I'm of the opinon that such license texts should be included in development
subpackages to make the license explicitly clear (and not have to backreference
that of the original SRPM's main package). I know of no guideline for or against
thish, though; and it seems more sensible to me tokeep it in there.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203520] Review Request: evolution-brutus

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: evolution-brutus
Alias: evolution-brutus

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203520





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 13:34 EST ---
Created an attachment (id=151889)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=151889action=view)
Updated spec file

Here's an updated spec file.  No major change, though I did remove the license
that was in the header, since it's not really necessary IMO. Jules, if you have
a problem with that please tell me, and I can put it back in.   Once I score
some webspace, I'll post the srpm.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203520] Review Request: evolution-brutus

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: evolution-brutus
Alias: evolution-brutus

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203520


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Attachment #151889|0   |1
is obsolete||




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 13:37 EST ---
(From update of attachment 151889)
Argh! wrong spec file.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203520] Review Request: evolution-brutus

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: evolution-brutus
Alias: evolution-brutus

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203520





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 13:40 EST ---
Created an attachment (id=151890)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=151890action=view)
Update spec file.

Here's an updated spec file.  No major change, though I did remove the license
that was in the header, since it's not really necessary IMO. Jules, if you have

a problem with that please tell me, and I can put it back in.   Once I score
some webspace, I'll post the srpm.

Note: This is targeted for the devel branch.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 222087] Review Request: pcmanx-gtk2 - Telnet client designed for BBS browsing

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pcmanx-gtk2 - Telnet client designed for BBS browsing


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222087





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 13:51 EST ---
Well, actually on rawhide automake is 1.10 and
some other fixes are needed for rawhide.

For me, the following works

%prep
%setup -q -n %{name}

for f in `ls -d %{_datadir}/automake-1.* | sort  -g -k 2 -t .` ; do
   automakever=`echo $f | sed -e 's|%{_datadir}/automake-||'`
done

eval %{__sed} -i.orig -e \'s\|-1\\\.9\|-$automakever\|\' autogen.sh
%{__sed} -i -e 's|set -x|set -e -x|' autogen.sh

touch config.rpath
./autogen.sh
#autoreconf -fi


Please check if the above also works for you.

And.. I have not checked other things yet...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 174289] LibHdate is a small C, C++ library for Hebrew calendar and dates, holidays, and reading sequence.

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: LibHdate is a small C,C++ library for Hebrew calendar and dates, 
holidays, and reading sequence.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174289


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 14:06 EST ---
Well, again ping?

Normally, when no response is received from packager for
one month, the bug is closed as WONTFIX or so

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 199905] Review Request: gotmail

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gotmail


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199905


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 14:07 EST ---
Again what is the status of this bug?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 232815] Review Request: libnetfilter_queue - Netfilter queue userspace library

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libnetfilter_queue - Netfilter queue userspace library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232815


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 235456] Review Request: php-pear-HTML-QuickForm-advmultiselect - Element for HTML_QuickForm that emulate a multi-select

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-HTML-QuickForm-advmultiselect - Element for 
HTML_QuickForm that emulate a multi-select


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235456


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 14:27 EST ---
Hi, if this is your first package you should block FE-NEEDSPONSER as shown to be
important and hilighted here: 
http://fedoraproject.org/wiki/PackageMaintainers/Join#head-a7a95bc9083826b65ccdd4d0f201ea6e59426590

I can sponser you, but I prefer to sponser people who can log onto the
#fedora-devel channel on IRC for easier communication.

A good way to start is to review some packages, for example:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222575

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 235526] New: Review Request: python-xattr - Extended attributes library wrapper for Python

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235526

   Summary: Review Request: python-xattr - Extended attributes
library wrapper for Python
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://timeoff.wsisiz.edu.pl/rpms/python-xattr/python-xattr.spec
SRPM URL: 
http://timeoff.wsisiz.edu.pl/rpms/python-xattr/python-xattr-0.2.1-1.src.rpm
Description: Python extension module wrapper for libattr. It allows to query, 
list, add and remove extended attributes from files and directories.

It's a recommended runtime dependency for rdiff-backup (already in Fedora 
Extras).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 235527] New: Review Request: python-libacl - POSIX.1e ACLs library wrapper for python

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235527

   Summary: Review Request: python-libacl - POSIX.1e ACLs library
wrapper for python
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://timeoff.wsisiz.edu.pl/rpms/python-libacl/python-libacl.spec
SRPM URL: 
http://timeoff.wsisiz.edu.pl/rpms/python-libacl/python-libacl-0.2.1-2.src.rpm
Description: Python extension module for POSIX ACLs. It allows to query, list,
add and remove ACLs from files and directories.

It's a recommended runtime dependency for rdiff-backup (already in Fedora 
Extras).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 235370] Review Request: php-pear-MDB2-Driver-pgsql - PostgreSQL driver for MDB2

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2-Driver-pgsql - PostgreSQL driver for MDB2


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235370


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 14:32 EST ---
I can sponser you, however I prefer users who can log into #fedora-devel on IRC
for easier communication.  You can start by reviewing some packages, for 
example:

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232165

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 235527] Review Request: python-libacl - POSIX.1e ACLs library wrapper for python

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-libacl - POSIX.1e ACLs library wrapper for 
python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235527


[EMAIL PROTECTED] changed:

   What|Removed |Added

  BugsThisDependsOn||163776




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 14:37 EST ---
Added FE-NEW dependency.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 235526] Review Request: python-xattr - Extended attributes library wrapper for Python

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-xattr - Extended attributes library wrapper for 
Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235526


[EMAIL PROTECTED] changed:

   What|Removed |Added

  BugsThisDependsOn||163776




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 14:36 EST ---
Added FE-NEW dependency.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 232816] Review Request: libnetfilter_log - Netfilter logging userspace library

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libnetfilter_log - Netfilter logging userspace library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232816


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 14:50 EST ---
Jochen, can you say something here so I'd push this further? Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 234436] Review Request: glchess - GlChess, a 3d Chess game using OpenGL

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: glchess - GlChess, a 3d Chess game using OpenGL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234436


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 15:01 EST ---
New Package CVS Request
===
Package Name:  glchess
Short Description: 3d Chess game using OpenGL
Owners:[EMAIL PROTECTED]
Branches:  FC-6
InitialCC: empty

Notice this package is intended for FC-6 only in devel this has been integrated
into gnome-games, still I would like to release this for FC-6 as there have been
several specific packaging requests for this package.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 231911] Review Request: jomolhari-fonts - Jomolhari a Bhutanese style font for Tibetan and Dzongkha

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jomolhari-fonts - Jomolhari a Bhutanese style font for 
Tibetan and Dzongkha


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231911





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 15:33 EST ---
Spec URL: http://manta.univ.gda.pl/~mgarski/fe/jomolhari-fonts.spec
SRPM URL: http://manta.univ.gda.pl/~mgarski/fe/jomolhari-fonts-0.003-3.src.rpm

- Update to 0.003c
- Change license from GPL to OFL

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 235456] Review Request: php-pear-HTML-QuickForm-advmultiselect - Element for HTML_QuickForm that emulate a multi-select

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-HTML-QuickForm-advmultiselect - Element for 
HTML_QuickForm that emulate a multi-select


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235456


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||177841
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 234031] Review Request: eclipse-pydev - an Eclipse plugin for working with Python.

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eclipse-pydev - an Eclipse plugin for working with 
Python.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234031





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 15:47 EST ---
(In reply to comment #19)
 I dont get any visible errors, it is just not working, there is no PyDev entry
 in Windows - Preferences.
 In The About - Plugin details i only see 2 org.python.pydev plugins (ast 
 online help) the other org.python.pydev is missing.

Thanks, I'll include a requires for JDT in the next revision.



(In reply to comment #16)
 
 - plugins/org.python.pydev.jython_1.3.1/Lib.  Where does the content of this
 directory come from?  Is it necessary?If so, can we symlink it?
 
 - plugins/org.python.pydev_1.3.1/PySrc.  What is the content of this 
 directory?
  If we want to ship it or if it's necessary, I think it should either have a
 clear source and license trail or be a separate package.

This is some auxiliary scripts that are used for running tests I believe. Some
of the files here come from outside python packages, see full reply bellow.

 - plugins/org.python.pydev.jython_1.3.1/jysrc.Same questions as above.

This is pydev's files, and they are jython scripts used to control pydev.

 
 - plugins/org.python.pydev.debug_1.3.1/pysrc.  Same.
These seem to be pydev's own scripts. 

Here's Fabio's reply about the origin of these files:
http://sourceforge.net/mailarchive/message.php?msg_name=cfb578b20704060345n677f8a26u5e87bbc3a4a20c8%40mail.gmail.com

What do you think is the appropriate thing to do with these?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 235527] Review Request: python-libacl - POSIX.1e ACLs library wrapper for python

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-libacl - POSIX.1e ACLs library wrapper for 
python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235527





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 16:09 EST ---
A path to the source package should be:
http://heanet.dl.sourceforge.net/sourceforge/pylibacl-%{version}.tar.bz2

I don't want to bump release number only because of that, so I will fix it
together with other changes suggested in a review.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 234488] Review Request: yum-presto - Yum plugin to download deltarpms rather than full rpms

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: yum-presto - Yum plugin to download deltarpms rather 
than full rpms


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234488


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||CURRENTRELEASE
   Fixed In Version||0.3.8-1




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 229098] Review Request: openjpeg - JPEG 2000 codec library

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229098





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 16:49 EST ---
I finally managed to catch upstream's attention. :) The license is in svn now
and a new release should be coming soonish, with the license and some of the
optimizations me and others have been working on...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 235417] Review Request: zzuf - Transparent application input fuzzer

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: zzuf - Transparent application input fuzzer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235417


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 235417] Review Request: zzuf - Transparent application input fuzzer

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: zzuf - Transparent application input fuzzer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235417


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 17:22 EST ---
Package Review
==

Key:
 - = N/A
 x = check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
 [x] Rpmlint output:
 Agreed, rpmlint is wrong.
   W: zzuf invalid-license WTFPL
   W: zzuf invalid-license WTFPL
   W: zzuf-debuginfo invalid-license WTFPL
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must matches the base package %{name}, in the format
%{name}.spec.
 [x] Package meets the  Packaging Guidelines.
 [x] Package is licensed with an open-source compatible license and meet other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is written in American English.
 [x] Spec file for the package is legible.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
 MD5SUM this package: 1970dcf4f77251bea843b0f6ae19231c
 MD5SUM upstream package: 1970dcf4f77251bea843b0f6ae19231c
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
 Tested on: FC-6/i386
 [x] Package is not known to require ExcludeArch, OR:
 Arches excluded:
 Why:
 [x] All build dependencies are listed in BuildRequires, except for any that are
listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 Not required since this is a LD_PRELOAD package
 [x] Package is not relocatable.
 [x] Package must own all directories that it creates.
 [-] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
 Tested on: FC-6/i386
 [x] Package should compile and build into binary rpms on all supported
architectures.
 Tested on: FC-6/i386
 [x] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files are correct.
 [-] File based requires are sane.
 [x] Latest version is packaged.

=== Issues ===
1.

=== Final Notes ===
1.



*** APPROVED ***


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 221906] Review Request: gmediaserver - UPnP compatible media server for the GNU system

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gmediaserver - UPnP compatible media server for the 
GNU system
Alias: gmediaserver

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221906





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 17:29 EST ---
(In reply to comment #15)
 In the absence of option 3 (static UID/GID), I think option 2 (not removing 
 the
 user/group) is much better. It may be messy in terms of leaving accounts on
 systems but IMHO this is not as messy as leaving unowned files on those
 systems (which would happen if the user/group were deleted).

 There is actually a pseudo-static UID/GID mechanism available in Fedora
 (http://fedoraproject.org/wiki/PackageUserCreation) but use of it is 
 contentious

I agree with Paul here.  This is messy, but ATM there is not a good way to
handle this except with fedora-usermgmt as noted above.  However, I would not
recommend fedora-usermgmt (although I use it on my packages) until the
controversy regarding it's use is ironed out.

So for now, let's go with the persistent user/group.

(In reply to comment #14)
 Well...IMO there are some ways resolve this problem:
 1. Do not change it, the owner of /srv/gmediaserver will be changing all time
 when the package user will be having other uid/gid and the files are often 
 644,
 so the program can read it. I think it is safe, because if the directory will
 not be deleted unless it is empty.

But there will be potentially unowned files depending on how the media server is
used.  You're lucky in the regard that the media server doesn't actually have to
manage the files, only read them - otherwise it would be more sticky.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 232548] Review Request: gnome-yum - Graphical program for easier use the YUM install program

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-yum - Graphical program for easier use the YUM 
install program


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232548


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium

[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
   Flag||fedora-review?




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 17:41 EST ---
Looks like you are sponsored now, so I'll provide a review.  Let's get this
fixed first:


checking pkg-config is at least version 0.9.0... yes
checking for GNOME... no
+ make
make: *** No targets specified and no makefile found.  Stop.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 223943] Review Request: Nemiver - A C/C++ Debugger for GNOME - point, click, debug!

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Nemiver - A C/C++ Debugger for GNOME - point, click, 
debug!
Alias: nemiver

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223943


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 17:57 EST ---
(In reply to comment #35)
 (In reply to comment #33)
  Just a couple questions: 
  is the touch trick for forcing the icon cache update the
  usual/preferred/best way to do that?
 
 It is, according to the Packaging/ScriptletSnippets page on the wiki.

Ok. seems I missed it until now...

 
  are you going to remove COPYING from the -devel subpackage as suggested in
  comment #2?
 No. I'm of the opinon that such license texts should be included in 
 development
 subpackages to make the license explicitly clear (and not have to 
 backreference
 that of the original SRPM's main package). I know of no guideline for or 
 against
 thish, though; and it seems more sensible to me tokeep it in there.
 

I have no strong opinion against this either (though I did not notice other
packages doing the same).

In the lack of an official guideline about this and given there was more than
enough time for further comments the package is APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 233802] Review Request: python-xlib - Fully functional X client library for Python programs

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-xlib - Fully functional X client library for 
Python programs


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233802


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 18:11 EST ---
Updated for the summary text change suggestion
http://jspaleta.thecodergeek.com/Fedora%20SRPMS/python-xlib/python-xlib-0.13-2.fc7.src.rpm
http://jspaleta.thecodergeek.com/Fedora%20SRPMS/python-xlib/python-xlib.spec

So uhm, Rex, anytime you want to start that official review that would be great.

-jef

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 235417] Review Request: zzuf - Transparent application input fuzzer

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: zzuf - Transparent application input fuzzer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235417


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 18:11 EST ---
Thanks!

New Package CVS Request
===
Package Name: zzuf
Short Description: Transparent application input fuzzer
Owners: [EMAIL PROTECTED]
Branches: FC-6
InitialCC: 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 233848] Review Request: perl-SVG-Graph - Visualize your data in Scalable Vector Graphics (SVG) format

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SVG-Graph - Visualize your data in Scalable 
Vector Graphics (SVG) format
Alias: perl-SVG-Graph

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233848





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 18:59 EST ---
* Fri Apr 06 2007 Alex Lancaster [EMAIL PROTECTED] 0.01-3
- Added e-mail confirmation for license in package.

Spec URL: http://allele5.biol.berkeley.edu/~alex/fedora/perl-SVG-Graph.spec
SRPM URL: 
http://allele5.biol.berkeley.edu/~alex/fedora/perl-SVG-Graph-0.01-3.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 235376] Review Request: ocsinventory-ipdiscover - Open Computer and Software Inventory Next Generation client

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocsinventory-ipdiscover - Open Computer and Software 
Inventory Next Generation client


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235376


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
   Flag||fedora-review?




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 19:05 EST ---
GOOD
- rpmlint checks do not return anything
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL ) OK, matches source; upstream did not include the full license,
but the only existing doc (a README) mentions that the license is GPL and points
to the URL
- spec file legible, in am. english
- source matches upstream, sha1sum 
06acb6c071040d2ae6d3c26109e526afba660835 OCSNG_LINUX_AGENT_1.01.tar.gz
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all files and directories that it creates; does not take ownership of
foreign files and directories
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- not a GUI, so no need for .desktop file 
- no static content. no libtool / pkgconfig files


SHOULD
- compiles and builds in mock/devel/x86_64
- there are no translations available, but %description is also in French
- no scriptlets
- the program does start and seems to run without problems. I cannot do full
tests because I do not have the other needed programs (the agents). If someone
else could test this, please give us a hand.

Unless someone steps in pointing to problems that I have not spotted, Wednesday
I will approve this package (I think it's a good idea to wait till after
Easter). Meanwhile, Remi, please think of a method to preserve the timestamp of
the README file. Using perl to remove the CR/LF line endings affects it. Maybe
using touch -r before and after modifying the file ?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 219025] Review Request: ntop - A network traffic probe similar to the UNIX top command

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ntop - A network traffic probe similar to the UNIX top 
command
Alias: ntop

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219025


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 21:33 EST ---
(In reply to comment #97)
 * when I do
 export CFLAGS=%{optflags} -DDEBUG
 just before %configure in %build, there is a compile error
 in util.c, so I cannot test a build with -DDEBUG.

This is now fixed in the upstream, and I've included the -DDEBUG in the src.rpm
for now until we get this worked out.
 
 * the libraries aren't linked against any libraries, 
 so there are a lot of undefined non weak symbols with 
 rpmlint run on the installed rpm. I'll attach a patch.
 
 After applying the patch I get
 W: ntop unused-direct-shlib-dependency /usr/lib/libntop-3.3.so

 ...
 
 I checked some of those symbols, they were in admin.c,
 or main.c and admin.c and main.c are only in ntop. This 
 should really be reported upstream, this is weird

Upstream claims to have fixed this.

My rpmlint does now show any problems, but it never did on the other builds
either.  Can you check and see if this clears it up for you?


* Fri Apr 06 2007 Bernard Johnson [EMAIL PROTECTED] - 3.3-0.12.20070407cvs
- update to 20070407cvs
- compile with -DDEBUG for now to check for problems
- rework ntop-am.patch with recent changes
- patch to remove gdVersionGuessValue from plugin
- repatch with shrext patch

Spec URL: http://symetrix.com/~bjohnson/projects/fedora/ntop.spec
SRPM URL:
http://symetrix.com/~bjohnson/projects/fedora/ntop-3.3-0.12.20070407cvs.fc6.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 223943] Review Request: Nemiver - A C/C++ Debugger for GNOME - point, click, debug!

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Nemiver - A C/C++ Debugger for GNOME - point, click, 
debug!
Alias: nemiver

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223943


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 22:35 EST ---
Great; thanks for your review  comments!

New Package CVS Request
===
Package Name: nemiver
Short Description: A C/C++ Debugger for GNOME - point, click, debug!
Owners: [EMAIL PROTECTED]
Branches: FC-6 devel


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 233602] Review Request: pykdeextentions - A collection of python packages to support KDE applications

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pykdeextentions - A collection of python packages to 
support KDE applications


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233602


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium




--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 22:48 EST ---
Spec URL: http://apt.kde-redhat.org/apt/kde-redhat/SPECS/pykdeextensions.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 234750] Review Request: avr-binutils - Cross Compiling GNU binutils targeted at avr

2007-04-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: avr-binutils - Cross Compiling GNU binutils targeted 
at avr


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234750





--- Additional Comments From [EMAIL PROTECTED]  2007-04-06 23:37 EST ---
(In reply to comment #19)
 (In reply to comment #18)
  In my specs I do all these steps this way:
  %prep
  %setup -q -c -T -n %{name}-%{version}
  %setup -q -D -T -n %{name}-%{version} -a0
  
 
 Erm why not just:
 %prep
 %setup -q -c
 
 That has exactly the same effect.
Yes, but only if a package has exactly one source-tarball.

When a package has several source-tarballs (like my gcc-specs), my construct is
more flexible (I generate the specs)

  Finally: As you already know, I dislike a toolchains using an architecture 
  (avr)
  as their target
 
 I know, but as long as almost the whole world does it like this I'm 
 not planning on changing this.
Well, ... who is this whole world you are referring to?

Any GNU toolchain developer will tell you that using an architecture as target
is not a clever decision.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


  1   2   >