[Bug 173459] Review Request: initng

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: initng


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173459





--- Additional Comments From [EMAIL PROTECTED]  2006-06-04 08:45 EST ---
actually since theres a release scheduled on monday i did some tests with
yesterdays svn of inting and ifiles.

initng svn:
builds without warnings on x86_64 but has rpath problems:
http://rafb.net/paste/results/MdPv0942.html

initng-files:
doesent boot with freshly generated runlevel configs fails to mount virtual
filesystem for me.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 191589] Review Request: qsa: Qt Script for Applications

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qsa: Qt Script for Applications


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191589





--- Additional Comments From [EMAIL PROTECTED]  2006-06-04 08:47 EST ---
so the next version is ready for review.
here the URL:
http://prdownloads.sourceforge.net/qsmartcard/qsa-1.2.1-4FC4.src.rpm?download
Changelog:
- enable qt3support
- Prevent for compiling using Qt =4.2 witch will need another version of QSA.
- add missing .h files

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 177512] Review Request: mysql-connector-net

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mysql-connector-net


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177512





--- Additional Comments From [EMAIL PROTECTED]  2006-06-04 08:52 EST ---
Spec Name or Url:
http://www.knox.net.nz/~nodoid/mysql-connector-net.spec
SRPM Name or Url:
http://www.knox.net.nz/~nodoid/mysql-connector-net-1.0.7-5.src.rpm

Change of URL

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 178901] Review Request: gtksourceview-sharp

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtksourceview-sharp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178901





--- Additional Comments From [EMAIL PROTECTED]  2006-06-04 09:29 EST ---
Spec Name or Url: http://www.knox.net.nz/~nodoid/gtksourceview-sharp.spec
SRPM Name or Url:
http://www.knox.net.nz/~nodoid/gtksourceview-sharp-2.0-9.src.rpm

Change of URL

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 178904] Review Request: Monodevelop

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Monodevelop


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178904





--- Additional Comments From [EMAIL PROTECTED]  2006-06-04 09:30 EST ---
Spec Name or Url: http://www.knox.net.nz/~nodoid/monodevelop.spec
SRPM Name or Url: http://www.knox.net.nz/~nodoid/monodevelop-0.11-6.src.rpm

Fixed #42
Change of URL

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 182320] Review Request: gnome-build

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-build


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182320





--- Additional Comments From [EMAIL PROTECTED]  2006-06-04 09:32 EST ---
Spec Name or Url: http://www.knox.net.nz/~nodoid/gnome-build.spec
SRPM Name or Url: http://www.knox.net.nz/~nodoid/gnome-build-0.1.2-2.src.rpm

Change of URL

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189092] Review Request: boo

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: boo


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189092





--- Additional Comments From [EMAIL PROTECTED]  2006-06-04 09:33 EST ---
Spec URL: http://www.knox.net.nz/~nodoid/boo.spec
SRPM URL: http://www.knox.net.nz/~nodoid/boo-0.7.5.2013-7.src.rpm

Change of URL

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189093] Review Request: mono-debugger

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mono-debugger


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189093





--- Additional Comments From [EMAIL PROTECTED]  2006-06-04 09:34 EST ---
Spec URL: http://www.knox.net.nz/~nodoid/mono-debugger.spec
SRPM URL: http://www.knox.net.nz/~nodoid/mono-debugger-0.12-3.src.rpm

Change of URL

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189150] Review Request: mod_mono

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mod_mono


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189150





--- Additional Comments From [EMAIL PROTECTED]  2006-06-04 09:37 EST ---
Spec URL: http://www.knox.net.nz/~nodoid/mod_mono.spec
SRPM URL: http://www.knox.net.nz/~nodoid/mod_mono-1.1.14-3.src.rpm

Change of URL
A couple of tweaks. I'll address #6 today

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193957] Review Request: nant

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nant


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193957





--- Additional Comments From [EMAIL PROTECTED]  2006-06-04 09:38 EST ---
Spec URL: http://www.knox.net.nz/~nodoid/nant.spec
SRPM URL: http://www.knox.net.nz/~nodoid/nant-0.85-2.src.rpm

Change of URL

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 173459] Review Request: initng

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: initng


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173459





--- Additional Comments From [EMAIL PROTECTED]  2006-06-04 10:07 EST ---
additionally in case selinux is turned off it still tries to switch selinux 
contexts

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 167364] Review Request: Fuse emulator utilities

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Fuse emulator utilities


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167364





--- Additional Comments From [EMAIL PROTECTED]  2006-06-04 11:25 EST ---
http://www.all-the-johnsons.co.uk/emulation/downloads/fuse-utils-0.7.0-4.src.rpm

404 Not Found
The requested URL /emulation/downloads/fuse-utils-0.7.0-4.src.rpm was not found
on this server.

I hope the spec file inside the SRPM is called fuse-emulator-utils.spec but I
suspect it won't be given the SRPM name. Please fix this before posting the next
URL.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 192043] Review Request: ucblogo - An interpreter for the Logo programming language

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ucblogo - An interpreter for the Logo programming 
language


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192043


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-06-04 11:29 EST ---
Built on FC4, FC5 and FC6. Added entry to owners.list.
Thanks for the review.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194011] New: Review Request: curry - Münster Curry compiler

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194011

   Summary: Review Request: curry -  Münster Curry compiler
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://math.ifi.unizh.ch/fedora/spec/curry.spec
SRPM URL: 
http://math.ifi.unizh.ch/fedora/5/i386/SRPMS.gemi/curry-0.9.10-1.src.rpm 
Description:
The Münster Curry compiler is a native code compiler for the
declarative multi-paradigm language Curry.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 167364] Review Request: Fuse emulator utilities

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Fuse emulator utilities


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167364





--- Additional Comments From [EMAIL PROTECTED]  2006-06-04 11:43 EST ---
Spec Name or Url: http://www.knox.net.nz/~nodoid/fuse-emulator-utils-0.7.0.spec
SRPM Name or Url: 
http://www.knox.net.nz/~nodoid/fuse-emulator-utils-0.7.0-4.src.rpm

D'oh!

The spec file has been fixed as you've suggested.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 182415] Review Request: man-pages-uk - Ukrainian man pages from Linux Documentation Project

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: man-pages-uk - Ukrainian man pages from Linux 
Documentation Project


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182415





--- Additional Comments From [EMAIL PROTECTED]  2006-06-04 11:55 EST ---
 and find nothing non-utf mans.
Oops, sorry. I was confused a little because of mc uses nroff to show man pages,
and nroff converts utf8 to my ancient locale... :)

 I've catched the package version from a VERSION Makefile's variable.
OK, surely it is correct.

Next days I'll finish the review.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 187613] Review Request: sm_tool

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sm_tool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187613


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193929] Review Request: knetstats

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: knetstats


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193929





--- Additional Comments From [EMAIL PROTECTED]  2006-06-04 13:01 EST ---
issue 1 : it automatically adds itself in Kmenu-Internet

issue 2 : rpmbuilding through QA_RPATHS=$[ 0x0001|0x0010 ] rpmbuild -ba
knetstats.spec

Updated:
Spec URL: http://beta.glwb.info/knetstats/knetstats.spec
SRPM URL: http://beta.glwb.info/knetstats/knetstats-1.5-2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194012] New: Review Request: xaos - A fast, portable real-time interactive fractal zoomer

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194012

   Summary: Review Request: xaos - A fast, portable real-time
interactive fractal zoomer
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://math.ifi.unizh.ch/fedora/spec/xaos.spec
SRPM URL: http://math.ifi.unizh.ch/fedora/5/i386/SRPMS.gemi/xaos-3.2.1-1.src.rpm
Description:
XaoS is a fast, portable real-time interactive fractal zoomer. It
displays the Mandelbrot set (among other escape time fractals) and
allows you zoom smoothly into the fractal. Various coloring modes are
provided for both the points inside and outside the selected set. XaoS
supports switching between Julia and Mandelbrot fractal types and
on-the-fly plane switching.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193929] Review Request: knetstats

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: knetstats


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193929





--- Additional Comments From [EMAIL PROTECTED]  2006-06-04 14:54 EST ---
Not a formal review, but here's a few things I've noticed.

1. You should probably patch the SConstruct file to remove rpath from the
environment. See 'env.KDEuse(environ rpath)' in the file.

2. Add -q to the %setup macro

3. Since you're using %{version} in the source tag, consider using the %{name}
macro too.

4. Drop gcc-c++ from the buildrequires, see
http://fedoraproject.org/wiki/Packaging/Guidelines?highlight=%28CategoryExtras%29
 

5. Perhaps a matter of preference, but consider using the scons supplied with
the source, ie drop the scons BR and use ./scons in the build section.

6. Use the %{?_smp_mflags} on the scons build line, to allow parallel building

7. The install process attempts to create files outside the buildroot:

mkdir: cannot create directory `/usr/share/doc/HTML/en/knetstats': Permission
denied

  This must be fixed.

8. The last changelog entry is missing its release number (im assuming it should
have been -1)

9. To fix the desktop file, one solultion might be to delete the .desktop from
the buildroot after scons install 'rm -f
$RPM_BUILD_ROOT%{_datadir}/applnk/Internet/knetstats.desktop', then use
desktop-file-install to install it yourself. Remember to add desktop-file-utils
as a BR



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189093] Review Request: mono-debugger

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mono-debugger


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189093





--- Additional Comments From [EMAIL PROTECTED]  2006-06-04 15:13 EST ---
Those globs in %files are playing evil with directories ownership.

[EMAIL PROTECTED] ~]$ rpm -qf /usr/lib/mono/1.0
mono-core-1.1.13.7-1.fc5.1
mono-debugger-0.12-3

[EMAIL PROTECTED] ~]$ rpm -qf /usr/lib/mono/gac
gtk-sharp2-2.8.2-1
gtk-sharp-1.0.10-5
mono-core-1.1.13.7-1.fc5.1
gtksourceview-sharp-2.0-7
monodoc-1.1.13-6
mono-debugger-0.12-3

Both /usr/lib/mono/1.0 and /usr/lib/mono/gac should be owned by mono-core.

A quick fix up for mono-debugger.spec:

%files
%defattr(-, root, root)
%doc AUTHORS COPYING ChangeLog README README.FreeBSD README.build TODO NEWS
RELEASE-NOTES*
%{_bindir}/mdb
%{_libdir}/*.so*
%{_libdir}/mono/1.0/*.exe
%{_libdir}/mono/1.0/gac/Mono.Debugger/*
%{_libdir}/mono/1.0/gac/Mono.Debugger.Cecil/*
%{_libdir}/pkgconfig/mono-debugger.pc


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189092] Review Request: boo

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: boo


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189092





--- Additional Comments From [EMAIL PROTECTED]  2006-06-04 15:21 EST ---
Spec URL: http://www.knox.net.nz/~nodoid/boo.spec
SRPM URL: http://www.knox.net.nz/~nodoid/boo-0.7.6.2234-1.src.rpm

Changelog

Bump to newer version (2237 has build issues)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 187282] Review Request: sax2

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sax2


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187282


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-06-04 16:13 EST ---
Not building, same error. Add readline-devel to BuildRequires.

/usr/share/locale is forbidden, use %find_lang

Use python macros from fedora-rpmdevtools package to avoid hardcoding
site-packages dir.

Require the libX* package instead of the xorg implementation.

Drop the PreReq, not needed. Probably most of Requires too, most of it is
covered from library requirements brought in by BuildRequires.

Why %define __perl_requires %{nil} ? This could use a comment.

Need to use a lot more macros. Ideally, at least in my opinion, there are no
/usr references anywhere in the spec.

There are readability issues with the SuSE specific parts.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 192119] Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192119





--- Additional Comments From [EMAIL PROTECTED]  2006-06-04 16:25 EST ---
Now that I've tried building on devel with the new plib, I found a few missing
BuildRequires:
libGL-devel libXi-devel libXext-devel libXmu-devel


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189093] Review Request: mono-debugger

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mono-debugger


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189093





--- Additional Comments From [EMAIL PROTECTED]  2006-06-04 17:16 EST ---
Spec URL: http://www.knox.net.nz/~nodoid/mono-debugger.spec
SRPM URL: http://www.knox.net.nz/~nodoid/mono-debugger-0.12-4.src.rpm

Addresses problems seen in #5


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189892] Review Request: dssi - Disposable Soft Synth Interface

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dssi - Disposable Soft Synth Interface


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189892


[EMAIL PROTECTED] changed:

   What|Removed |Added

  BugsThisDependsOn|191590  |
OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-06-04 19:10 EST ---
MUST items:

- rpmlint: Ok

$ rpmlint dssi-examples-0.9.1-6.fc5.i386.rpm
W: dssi-examples no-documentation

Ignorable.

W: dssi-examples dangling-relative-symlink /usr/bin/less_trivial_synth
jack-dssi-host
W: dssi-examples dangling-relative-symlink /usr/bin/trivial_sampler 
jack-dssi-host
W: dssi-examples dangling-relative-symlink /usr/bin/trivial_synth jack-dssi-host

Intentional. Main package supplies jack-dssi-host.

- Package name: Ok
- Spec name: Ok
- Meets packaging guidelines: Ok
- License: Ok
- Spec in American English: Ok
- Spec legible: Ok
- Sources match upstream: Ok
- Builds: Ok
- BuildRequires: Ok
- Locales: Ok
- ldconfig: Ok
- Relocation: Ok
- Directory ownership: Ok
- %files: Ok
- %clean: Ok
- Macros: Ok
- Code vs. Content: Ok
- Documentation: Ok
- devel package: Ok
- .desktop file: Ok

SHOULD:

- Includes license text: Ok
- Mock build: Ok
- Builds on all archs: Built on i386, x86_64
- Package functional: Tested on i386, x86_64
- Scriptlets: Ok
- Subpackages: Ok

NEEDSWORK:

Source0: needs to be [...]sf.net/sourceforge/dssi/[...] or else I get a 404.
(Did SF rearrange their URLs recently?)

Fix the URL before import, and this is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 191590] Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191590


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|189892  |
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193884] Review Request: tolua++ - A tool to integrate C/C++ code with Lua

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tolua++ - A tool to integrate C/C++ code with Lua


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193884


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cegui - Free library providing windowing and widgets 
for graphics APIs / engines


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342


Bug 193342 depends on bug 193884, which changed state.

Bug 193884 Summary: Review Request: tolua++ - A tool to integrate C/C++ code 
with Lua
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193884

   What|Old Value   |New Value

 Resolution||NEXTRELEASE
 Status|ASSIGNED|CLOSED



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193210] Review Request: htmldoc - Convert HTML source files into HTML, PostScript, or PDF

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: htmldoc - Convert HTML source files into HTML, 
PostScript, or PDF


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193210


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189892] Review Request: dssi - Disposable Soft Synth Interface

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dssi - Disposable Soft Synth Interface


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189892


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-06-04 21:29 EST ---
Thanks!

AG


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189322] Review Request: rosegarden4

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rosegarden4


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189322


Bug 189322 depends on bug 189892, which changed state.

Bug 189892 Summary: Review Request: dssi - Disposable Soft Synth Interface
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189892

   What|Old Value   |New Value

 Resolution||NEXTRELEASE
 Status|NEW |CLOSED



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194015] yumex 1.0.0 TB4426d5a1 ConfigParser.py:490:_read:ParsingError: File contains parsing errors:

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: yumex 1.0.0 TB4426d5a1 ConfigParser.py:490:_read:ParsingError: File 
contains parsing errors:


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194015


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Component|Package Review  |yumex
 CC||[EMAIL PROTECTED]
OtherBugsDependingO|163776  |
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-06-04 21:58 EST ---
I'm not sure why this was filed under Package Review; unblocking FE-NEW, setting
the component to yumex and CC'ing the package owner.

Ronnie, I'm curious: did you submit this bug via the Fedora Extras Package
Review Request form?  Is there some document or URL that led you to that form as
the proper method for submitting a bug?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 191017] Review Request: eclipse-subclipse

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eclipse-subclipse


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191017





--- Additional Comments From [EMAIL PROTECTED]  2006-06-04 23:33 EST ---
I just filed bug #194026 for the javahl problem. I'll investigate as soon as I
get time.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 194027] New: Review Request: metisse - Experimental X desktop with OpenGL

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194027

   Summary: Review Request: metisse - Experimental X desktop with
OpenGL
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://tkmame.retrogames.com/fedora-extras/metisse.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/metisse-0.4.0-1.src.rpm

Description:
Metisse is an experimental X desktop with some OpenGL capacity.  It
consists of a virtual X server called Xwnc, a special version of FVWM,
and a FVWM module FvwmAmetista.

NOTE: This should obsolete bug #177080

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review