[Bug 196591] New: Review Request: bitlbee
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196591 Summary: Review Request: bitlbee Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: fedora-package-review@redhat.com Spec URL: http://labs.linuxnetz.de/bugzilla/bitlbee.spec SRPM URL: http://labs.linuxnetz.de/bugzilla/bitlbee-1.0.3-2.src.rpm Description: Bitlbee is an IRC to other chat networks gateway. Bitlbee can be used as an IRC server which forwards everything you say to people on other chat networks like MSN/ICQ/Jabber. IMHO the rpmlint output at x86_32 can be ignored as the error can't be avoided: E: bitlbee non-standard-dir-perm /var/lib/bitlbee 0700 Since packaging bitlbee myself, I didn't find any way to replace %makeinstall by make DESTDIR=$RPM_BUILD_ROOT install as the Guidelines recommend. Comments regarding this would be really nice... ;-) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 189884] Review Request: LASH Audio Session Handler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: LASH Audio Session Handler https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189884 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-06-25 14:11 EST --- Looks good now, Approved! One last note though in the %post(un) scripts you should add || : at the end of the touch and gtk-update-icon-cache lines as documented here: http://fedoraproject.org/wiki/ScriptletSnippets#head-fc74f078205565f961f6d836b77c3428619c689d This is so that if for whatever reason they fail that doesn't make the script have a non zero return value and does the whole rpm (un)install transaction fail. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 189884] Review Request: LASH Audio Session Handler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: LASH Audio Session Handler https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189884 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-06-25 14:24 EST --- (In reply to comment #8) Looks good now, Approved! Thanks. I've made your last suggested change as well. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 189783] Review Request: e17: The enlightenment DR17 window manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: e17: The enlightenment DR17 window manager https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189783 --- Additional Comments From [EMAIL PROTECTED] 2006-06-25 18:09 EST --- Review for release 1: * RPM name is OK * Source enlightenment-0.16.999.026.tar.gz is the same as upstream * This is nolonger the latest version (.028) Needs work: * BuildRequires: gettext is missing (required to build the translations) * Build failed in mock due to missing gettext Minor: * Duplicate BuildRequires: libidn-devel (by curl-devel) Notes: No feed back from submitter since 2006-04-25, two months now. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 195942] Review Request: Veusz - a scientific plotting package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Veusz - a scientific plotting package https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195942 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163776, 177841 |163778 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-06-25 18:39 EST --- Commented, nice! .pyo files should be %ghosted. http://fedoraproject.org/wiki/Packaging/Python * Desktop file: the Categories tag should contain X-Fedora (wiki: Packaging/Guidelines#desktop) * Missing dependancy on update-desktop-database for %post (package desktop-file-utils) * Missing dependancy on update-desktop-database for %postun (package desktop-file-utils) rpmlint clean as mentioned previously. Fix these up and apply for cvsextras and I'll sponsor you and approve package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 195942] Review Request: Veusz - a scientific plotting package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Veusz - a scientific plotting package https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195942 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 171289] Review Request: dirmngr: Client for Managing/Downloading CRLs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dirmngr: Client for Managing/Downloading CRLs https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=171289 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-06-25 18:42 EST --- Builds in mock; rpmlint has this to day: E: dirmngr zero-length /etc/dirmngr/ldapservers.conf Is is possible to add a comment or something to this file indicating what its purpose is? W: dirmngr file-not-utf8 /usr/share/info/dirmngr.info.gz Just a few non-ascii charaters; a run through iconv should fix it up. W: dirmngr log-files-without-logrotate /var/log/dirmngr.log You'll want to make sure these get rotated properly. W: dirmngr non-standard-dir-in-usr libexec This seems OK given the currently accepted uses of /usr/libexec. Did you ever decide what do to about running this as a daemon? You don't seem to package the COPYING file. Note that 0.9.4 is out. Care to make an update that fixes the above issues? Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. X license is open source-compatible. License text included in tarball but not in package. * source files match upstream: 54df92f0548918af89c8c7dcca2d1911 dirmngr-0.9.3.tar.bz2 X latest version is not being packaged (0.9.4 is out) * BuildRequires are proper. * package builds in mock (x86_64, development). X rpmlint has valid complaints * final provides and requires are sane: config(dirmngr) = 0.9.3-1.fc6 dirmngr = 0.9.3-1.fc6 = /bin/sh /sbin/install-info config(dirmngr) = 0.9.3-1.fc6 libgcrypt.so.11()(64bit) libgcrypt.so.11(GCRYPT_1.2)(64bit) libgpg-error.so.0()(64bit) libksba.so.8()(64bit) libksba.so.8(KSBA_0.9)(64bit) liblber-2.3.so.0()(64bit) libldap-2.3.so.0()(64bit) libpth.so.20()(64bit) * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check not present; no test suite upstream. There are some tests, but they don't seem to be anything that runs in an automatic fashoin. * scriptlets present and OK (install-info) * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 182320] Review Request: gnome-build
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-build https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182320 --- Additional Comments From [EMAIL PROTECTED] 2006-06-25 19:57 EST --- The BuildRequires mentioned in comment 5 still need to be changed. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196617] New: Review Request: perl-File-chdir - Perl module for local chdir()
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196617 Summary: Review Request: perl-File-chdir - Perl module for local chdir() Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: fedora-package-review@redhat.com Spec URL: http://znark.com/fedora/perl-File-chdir.spec SRPM URL: http://znark.com/fedora/perl-File-chdir-0.06-1.src.rpm Description: a more sensible way to change directories It is required by the perl-SVN-Mirror which is required by perl-SVK. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196624] New: Review Request: perl-PerlIO-via-symlink - PerlIO layers for creating symlinks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196624 Summary: Review Request: perl-PerlIO-via-symlink - PerlIO layers for creating symlinks Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: fedora-package-review@redhat.com Spec URL: http://znark.com/fedora/perl-PerlIO-via-symlink.spec SRPM URL: http://znark.com/fedora/perl-PerlIO-via-symlink-0.05-2.src.rpm Description: The PerlIO layer symlink allows you to create a symbolic link by writing to the file handle. It is required by perl-SVK. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196627] Review Request: perl-SVN-Mirror - Mirror remote repository to local Subversion repository
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-SVN-Mirror - Mirror remote repository to local Subversion repository https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196627 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn||196617, 196625 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196617] Review Request: perl-File-chdir - Perl module for local chdir()
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-File-chdir - Perl module for local chdir() https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196617 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||196627 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196629] New: Review Request: perl-SVK - A Distributed Version Control System
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196629 Summary: Review Request: perl-SVK - A Distributed Version Control System Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: fedora-package-review@redhat.com Spec URL: http://znark.com/fedora/perl-SVK.spec SRPM URL: http://znark.com/fedora/perl-SVK-1.07-4.src.rpm Description: SVK is a decentralized version control system written in Perl. It uses the Subversion filesystem but provides additional features. It requires new packages perl-Algorithm-Annotate, perl-Data-Hierarchy, perl-IO-Digest, perl-PerlIO-eol, perl-PerlIO-via-dynamic, perl-PerlIO-via-symlink, and perl-SVN-Mirror. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196629] Review Request: perl-SVK - A Distributed Version Control System
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-SVK - A Distributed Version Control System https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196629 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn||196619, 196620, 196621, ||196622, 196623, 196624, ||196627 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196619] Review Request: perl-Data-Hierarchy - Handle data in a hierarchical structure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Data-Hierarchy - Handle data in a hierarchical structure https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196619 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||196629 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196624] Review Request: perl-PerlIO-via-symlink - PerlIO layers for creating symlinks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-PerlIO-via-symlink - PerlIO layers for creating symlinks https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196624 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||196629 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196622] Review Request: perl-PerlIO-via - PerlIO layer for normalizing line endings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-PerlIO-via - PerlIO layer for normalizing line endings https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196622 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||196629 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196620] Review Request: perl-Algorithm-Annotate - represent a series of changes in annotate form
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Algorithm-Annotate - represent a series of changes in annotate form https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196620 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||196629 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196627] Review Request: perl-SVN-Mirror - Mirror remote repository to local Subversion repository
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-SVN-Mirror - Mirror remote repository to local Subversion repository https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196627 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||196629 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 189195] Review Request: horde - php application framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: horde - php application framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189195 --- Additional Comments From [EMAIL PROTECTED] 2006-06-25 22:13 EST --- I wish... I'm just in a (seemingly permanenet) holding pattern waiting for somebody to give this a new review since my comment #2 submission. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 189195] Review Request: horde - php application framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: horde - php application framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189195 --- Additional Comments From [EMAIL PROTECTED] 2006-06-25 22:27 EST --- How about starting by responding to comments #3 and #4 and then I'll try to take a look. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196601] Review Request: vobject - A python library for manipulating vCard and vCalendar files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: vobject - A python library for manipulating vCard and
vCalendar files
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196601
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2006-06-25 23:18 EST ---
Not an official review as I'm not yet sponsored
Mock build for development i386 is suceesfull with some warnings
+ /usr/bin/python setup.py build
/usr/lib/python2.4/distutils/dist.py:236: UserWarning: Unknown distribution
option: 'zip_safe'
warnings.warn(msg)
/usr/lib/python2.4/distutils/dist.py:236: UserWarning: Unknown distribution
option: 'install_requires'
warnings.warn(msg)
MUST Items:
- MUST: rpmlint shows no error on i386
- MUST: dist tag is present
- MUST: The package is named according to the Package Naming Guidelines.
- MUST: The spec file name matching the base package vobject, in the
format vobject.spec
- MUST: This package meets the Packaging Guidelines.
- MUST: The package is licensed with an open-source compatible license
Apache Software License.
- MUST: The License field in the package vobject.spec file did not match
any file in tarball.
- MUST: The sources used to build the package matches the upstream source,
as provided in the spec URL. md5sum is correct.
- MUST: This package owns all directories that it creates.
- MUST: This package did not contain any duplicate files in the %files
listing.
- MUST: This package have a %clean section, which contains rm -rf
$RPM_BUILD_ROOT.
- MUST: This package used macros.
- MUST: Document files are included like README.txt
* Source URL is present and working.
* BuildRoot is correct BuildRoot:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* BuildRequires is correct
What you Need:-
* You dont need to have
Requires: python-abi = %(%{__python} -c import sys ; print
sys.version[:3])
as this is only for rpms targetting for FC3 or prior.
* Add License file in tarball if you can alter the tarball contents.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191015] Review Request: javasvn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: javasvn https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191015 --- Additional Comments From [EMAIL PROTECTED] 2006-06-25 23:22 EST --- Updated: http://www.marcanoonline.com/downloads/fedora/package_submissions/subclipse/javasvn.spec http://www.marcanoonline.com/downloads/fedora/package_submissions/subclipse/javasvn-1.0.4-4.src.rpm * Sun Jun 25 2006 Robert Marcano [EMAIL PROTECTED] 1.0.4-4 - created javadoc subpackage - dependency changed from ganymed to ganymed-ssh2 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191017] Review Request: eclipse-subclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: eclipse-subclipse https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191017 --- Additional Comments From [EMAIL PROTECTED] 2006-06-25 23:23 EST --- Updated: http://www.marcanoonline.com/downloads/fedora/package_submissions/subclipse/eclipse-subclipse.spec http://www.marcanoonline.com/downloads/fedora/package_submissions/subclipse/eclipse-subclipse-1.0.3-1.src.rpm * Sun Jun 25 2006 Robert Marcano [EMAIL PROTECTED] 1.0.3-1 - Update to 1.0.3 - Dependency name changed to ganymed-ssh2 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196529] Review Request: gtkdatabox
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gtkdatabox
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196529
--- Additional Comments From [EMAIL PROTECTED] 2006-06-25 23:37 EST ---
Not an official review as I'm not yet sponsored
Mock build for development i386 is sucessfull
MUST Items:
- MUST: rpmlint shows no error
- MUST: dist tag is present
- MUST: The package is named according to the Package Naming Guidelines.
- MUST: The spec file name matching the base package gtkdatabox, in the
format gtkdatabox.spec
- MUST: This package meets the Packaging Guidelines.
- MUST: The package is licensed with an open-source compatible license
LGPL.
- MUST: The sources used to build the package matches the upstream source,
as provided in the spec URL. md5sum is correct.
- MUST: This package owns all directories that it creates.
- MUST: This package did not contain any duplicate files in the %files
listing.
- MUST: This package have a %clean section, which contains rm -rf
$RPM_BUILD_ROOT.
- MUST: This package used macros.
- MUST: Document files are included like INSTALL README.
- MUST: Package did NOT contained any .la libtool archives.
- MUST: Header files are going in a -devel package.
- MUST: Files used by pkgconfig (.pc files) are in a -devel package.
- MUST: Library files that end in .so (without suffix) are in a -devel
package.
- MUST: This package contains shared library files located in the dynamic
linker's default paths, and therefore this package is calling ldconfig in %post
and %postun. But Devel package is NOT calling a %post/%postun section that calls
/sbin/ldconfig.
* Source URL is present and working.
* BuildRoot is correct BuildRoot:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* BuildRequires is correct
* devel package contains the base package using a fully versioned
dependency: Requires: %{name} = %{version}-%{release}
What you Need to do:-
* add %post %postun for devel package also to call ldconfig
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196620] Review Request: perl-Algorithm-Annotate - represent a series of changes in annotate form
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Algorithm-Annotate - represent a series of changes in annotate form https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196620 --- Additional Comments From [EMAIL PROTECTED] 2006-06-25 23:41 EST --- Several mirror issues: # rpmlint perl-Algorithm-Annotate-0.10-1.fc5.noarch.rpm W: perl-Algorithm-Annotate summary-not-capitalized represent a series of changes in annotate form W: perl-Algorithm-Annotate spelling-error-in-description simliar similar W: perl-Algorithm-Annotate invalid-license CHECK(GPL or Artistic) * Empty %doc. * Superfluous requires: Requires: perl(Algorithm::Diff) = 1.15 Seems as if you missed to manually edit a generated spec file ;) Please fix. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196529] Review Request: gtkdatabox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtkdatabox https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196529 --- Additional Comments From [EMAIL PROTECTED] 2006-06-25 23:48 EST --- I guess it sort of makes sense to add the %pre/%post to the devel packages but the guidelines you pasted in say: MUST: This package contains shared library files located in the dynamic linker's default paths, and therefore this package is calling ldconfig in %post and %postun. But Devel package is NOT calling a %post/%postun section that calls /sbin/ldconfig. The last two packages that were approved did not have these, but maybe I should have added them. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193493] Review Request: iksemel - An XML parser library designed for Jabber applications
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: iksemel - An XML parser library designed for Jabber
applications
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193493
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
OtherBugsDependingO|163776 |163778
nThis||
--- Additional Comments From [EMAIL PROTECTED] 2006-06-26 00:33 EST ---
I noticed the following build failure:
+ aclocal
aclocal:configure.ac:14: warning: macro `AM_PROG_LIBTOOL' not found in library
which is solved by adding BuildRequires: libtool. However, I'm not sure why you
think you need to rerun the autotools. You can disable rpath just by using
make LIBTOOL=/usr/bin/libtool %{?_smp_mflags}
and then deleting the extra .a file that shows up.
Other than that, the package looks good and rpmlint is completely silent. There
is, however, a test suite that you should call (with make check) in a %check
section.
Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible. License text included in package.
* source files match upstream:
82e7c8fdb6211839246b788c040a796b iksemel-1.2.tar.gz
* latest version is being packaged.
X BuildRequires are proper (libtool, as above)
* package builds in mock (development, x86_64) (after fixing libtool)
* rpmlint is silent.
* final provides and requires are sane:
iksemel-1.2-2.fc6.x86_64.rpm
libiksemel.so.3()(64bit)
iksemel = 1.2-2.fc6
=
/sbin/ldconfig
libiksemel.so.3()(64bit)
iksemel-devel-1.2-2.fc6.x86_64.rpm
iksemel-devel = 1.2-2.fc6
=
/bin/sh
/sbin/install-info
gnutls-devel
iksemel = 1.2-2.fc6
libiksemel.so.3()(64bit)
pkgconfig
iksemel-utils-1.2-2.fc6.x86_64.rpm
iksemel-utils = 1.2-2.fc6
=
iksemel = 1.2-2.fc6
libiksemel.so.3()(64bit)
* shared libraries are present; ldconfig is called properly and the unversioned
.so is in the -devel subpackage.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
X %check is not present but there is a test suite.
* scriptlets present and OK (ldconfig, install-info)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* headers present, in -devel package.
* pkgconfig files present, in -devel package and pkgconfig is required.
* no libtool .la droppings.
* not a GUI app.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196621] Review Request: perl-IO-Digest - Perl module to calculate digests while reading or writing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-IO-Digest - Perl module to calculate digests while reading or writing https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196621 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn||196623 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196623] Review Request: perl-PerlIO-via-dynamic - dynamic PerlIO layers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-PerlIO-via-dynamic - dynamic PerlIO layers https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196623 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||196621 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196622] Review Request: perl-PerlIO-eol - PerlIO layer for normalizing line endings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-PerlIO-eol - PerlIO layer for normalizing line endings https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196622 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Review Request: perl-PerlIO-|Review Request: perl-PerlIO- |via - PerlIO layer for |eol - PerlIO layer for |normalizing line endings|normalizing line endings --- Additional Comments From [EMAIL PROTECTED] 2006-06-26 00:46 EST --- Minor issue: # rpmlint perl-PerlIO-eol-0.13-2.i386.rpm W: perl-PerlIO-eol incoherent-version-in-changelog 0.13-1 0.13-2 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196570] Review Request: mirage
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: mirage
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196570
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2006-06-26 01:00 EST ---
Not an official review as I'm not yet sponsored
Mock build for development i386 is failed
Add BuildRequires: desktop-file-utils
MUST Items:
- MUST: rpmlint shows no error
- MUST: dist tag is present
- MUST: The package is named according to the Package Naming Guidelines.
- MUST: The spec file name matching the base package mirage, in the
format mirage.spec
- MUST: This package meets the Packaging Guidelines.
- MUST: The package is licensed with an open-source compatible license
GPL.
- MUST: The License field in the package mirage.spec file matches the
actual license file COPYING in tarball.
- MUST: The sources used to build the package matches the upstream source,
as provided in the spec URL. md5sum is correct.
- MUST: This package have a %clean section, which contains rm -rf
%{buildroot}.
- MUST: This package used macros.
- MUST: Document files are included like README.
- MUST: Library files that end in .so (without suffix) are NOT in a -devel
package.
- MUST: This package contains shared library files located in the dynamic
linker's default paths, and But this package did NOT calling ldconfig in %post
and %postun.
* Source URL is present and working.
* BuildRoot is correct BuildRoot:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* BuildRequires is NOT correct
What you Need to Do:-
* As your package uses .so files. You can add subpackage -devel.
* BuildRequires needed desktop-file-utils to be added.
* add %post %postun sections with call to ldconfig as
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
* update-desktop-database dependancy missing for %post (package
desktop-file-utils) as well as for %postun (package desktop-file-utils)
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196635] New: Review Request: knetworkmanager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196635 Summary: Review Request: knetworkmanager Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: fedora-package-review@redhat.com Spec URL: http://ausil.us/packages/knetworkmanager.spec SRPM URL: http://ausil.us/packages/knetworkmanager-0.1-1svn20060625.fc5.src.rpm Description: knetworkmanager is a kde frontend for NetworkManager that integrates with KDE -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
