[Bug 201502] Review Request: php-pear-PhpDocumentor

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-PhpDocumentor
Alias: phpDocumentor

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201502





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 02:09 EST ---
The release tag is off by a little bit, the %{?dist} tag should always be at
the end of the tag unless it's a sub-release bump.

0.2%{?dist}.%{rcrel} - 0.2.%{rcrel}%{?dist}

According to Packaging/PHP, the package should also Requires: php.

The latest version is 1.3.0 GA, but RC6 is being packaged.  To be fair, GA was
released the day after I assigned the review to myself, but... :)  Please
update the package to 1.3.0.

For the rpmlint warnings, the second is spurious and can be ignored.  The
first, however, could be fixed, but it appears part of the pear install
process is to check the md5sums of each file.  If the line ending can be fixed
w/o too much pain and mucking around with the pear-based install process, I'd
like to see it addressed.

You have php.ini both listed as source1, and created in %prep.  One or the
other works nicely, but both is redundant.  (Especially given nothing is ever
done with %{SOURCE0}...)

Also, while using php.ini to override the default memory and execution limits
works during the rpm build, the install fails on %post with the defaults on
the system:

 [EMAIL PROTECTED] mock]# rpm -ivh 
php-pear-PhpDocumentor-1.3.0-0.2.fc5.RC6.noarch.rpm
 Preparing...### [100%]
   1:php-pear-PhpDocumentor ### [100%]
   PHP Fatal error:  Allowed memory size of 8388608 bytes exhausted (tried to
   allocate 229 bytes) in /usr/share/pear/PEAR/Installer.php on line 283
   Allowed memory size of 8388608 bytes exhausted (tried to allocate 72 bytes)

Installing the created php.ini as an additional .ini file in /etc/php.d
enables the install to suceed, e.g. in %install:

 mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/php.d
 cp -p php.ini $RPM_BUILD_ROOT%{_sysconfdir}/php.d/phpDocumentor.ini

I don't get a good feeling from overriding core php.ini values in a package's
own modular ini file, but there doesn't seem to be another clean way to do
this.  (ideas/comments from those reading are solicited :) )  Perhaps it would
be a good idea to open a bug asking for the core memory limits be updated?
The response at least from the php maintainer would be valuable.

There's nearly a meg of tutorials and examples, which is great, but that's a
bit large to not be put in a -docs subpackage.

SO, to recap:
 * release tag
 * check on fixing rpmlint warning
 * update version
 * decide how php.ini is going to be included in srpm
 * deal with memory limits (a la a /etc/php.d/foo.ini file), open bug
 * split %_docdir/Documentation and %_docdir/tutorials off into a -docs
   package

X package meets naming and packaging guidelines. (release tag)
+ specfile is properly named, is cleanly written and uses macros consistently.
X dist tag is present (but in the wrong place)
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible (LGPL). License text included in package.
+ source files match upstream:
 e6f31c313b0b06c09acaf7047e6a5b23  PhpDocumentor-1.3.0RC6.tgz
 e6f31c313b0b06c09acaf7047e6a5b23  PhpDocumentor-1.3.0RC6.tgz.srpm
X latest version is being packaged.
+ BuildRequires are proper.
X package has required requires/provides statements.
+ package builds in mock (devel/x86_64).
O rpmlint is silent. (see below)
O final provides and requires are sane (except as noted above):
 ** phpdoc-1.3.0-0.2.fc5.RC6.noarch.rpm
 == rpmlint
 == provides
 phpdoc = 1.3.0-0.2.fc5.RC6
 == requires
 /usr/bin/php
 php-cli = 5
 php-pear(PhpDocumentor) = 1.3.0
 ** php-pear-PhpDocumentor-1.3.0-0.2.fc5.RC6.noarch.rpm
 == rpmlint
 W: php-pear-PhpDocumentor wrong-file-end-of-line-encoding
 
/usr/share/doc/php-pear-PhpDocumentor-1.3.0/Documentation/Release-old/Release-0.3.0
 W: php-pear-PhpDocumentor dangerous-command-in-%post install
 == provides
 php-pear(PhpDocumentor) = 1.3.0
 php-pear-PhpDocumentor = 1.3.0-0.2.fc5.RC6
 == requires
 /bin/sh
 /usr/bin/pear
 php-pear(PEAR) = 1.4.9
+ no shared libraries are present.
+ package is not relocatable.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ %clean is present.
O %check is not present; no automated test suite
+ sane scriptlets present.
+ code, not content.
X documentation is large (~876k), so -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact 

[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 02:12 EST ---
Package is APPROVED.

When you are ready please follow the instructions carefully
to import into extras cvs.

Thanks for contributing gcin to Fedora Extras.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203274] Review Request: lesstif - OSF/Motif(R) library clone

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lesstif - OSF/Motif(R) library clone


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203274





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 03:58 EST ---
(In reply to comment #23)
 
 Well, it should be just a warning to them that something will happen here if
 they do not act upon. I will try to get some more info and let you know

For those interested, discussion going on here:

http://www.motifzone.net/forum/viewtopic.php?p=3883


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 197565] Review Request: buildbot

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: buildbot


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197565





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 04:01 EST ---
0.7.4 is out

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 191492] Review Request: unuran-0.7.2

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: unuran-0.7.2


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191492





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 05:19 EST ---
Erm, never mind I spoke too soon, I'll start a review on kdiff soonish (I just
started a new job) and then I'll hear 2 others which you would like to get
reviewed for the sponsor process from you.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203864] Review Request: tripwire - IDS

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tripwire - IDS


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203864


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 06:23 EST ---
Only 1 rpmline error:

$ rpmlint tripwire-2.4.0.1-1.fc6.2.i386.rpm
E: tripwire executable-marked-as-config-file /etc/cron.daily/tripwire-check






-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 197442] Review Request: fatsort - sort fat of FAT32/FAT16 on cheap mp3 players

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fatsort - sort fat of FAT32/FAT16 on cheap mp3 players


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197442


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 06:39 EST ---
Built successfully for devel.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203825] yum install gdl failes due to dependency on ImageMagic

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: yum install gdl failes due to dependency on ImageMagic


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203825


[EMAIL PROTECTED] changed:

   What|Removed |Added

Product|Fedora Core |Fedora Extras
  Component|Package Review  |Package Review




--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 07:13 EST ---
This works for me:

# yum install gdl
Loading installonlyn plugin
Setting up Install Process
Setting up repositories
updates  [1/3]
core [2/3]
extras   [3/3]
Reading repository metadata in from local files
Parsing package install arguments
Resolving Dependencies
-- Populating transaction set with selected packages. Please wait.
--- Package gdl.i386 0:0.8.11-4.fc5 set to be updated
-- Running transaction check
-- Processing Dependency: libplplotcxxd.so.9 for package: gdl
-- Processing Dependency: libMagick++.so.9 for package: gdl
-- Processing Dependency: libplplotd.so.9 for package: gdl
-- Processing Dependency: libgslcblas.so.0 for package: gdl
-- Processing Dependency: libfftw3.so.3 for package: gdl
-- Processing Dependency: libgsl.so.0 for package: gdl
-- Processing Dependency: libhdf5.so.0 for package: gdl
-- Processing Dependency: libfftw3f.so.3 for package: gdl
-- Restarting Dependency Resolution with new changes.
-- Populating transaction set with selected packages. Please wait.
--- Package ImageMagick-c++.i386 0:6.2.5.4-4.2.1.fc5.4 set to be updated
--- Package fftw.i386 0:3.1.1-1.fc5 set to be updated
--- Package gsl.i386 0:1.7-1.2.1 set to be updated
--- Package hdf5.i386 0:1.6.5-5.fc5 set to be updated
--- Package plplot.i386 0:5.6.1-2.fc5 set to be updated
-- Running transaction check
-- Processing Dependency: libqhull.so.5 for package: plplot
-- Processing Dependency: libWand.so.9 for package: ImageMagick-c++
-- Processing Dependency: libgfortran.so.1 for package: plplot
-- Processing Dependency: libMagick.so.9 for package: ImageMagick-c++
-- Processing Dependency: ImageMagick = 6.2.5.4-4.2.1.fc5.4 for package:
ImageMagick-c++
-- Processing Dependency: libLASi.so.0 for package: plplot
-- Restarting Dependency Resolution with new changes.
-- Populating transaction set with selected packages. Please wait.
--- Package qhull.i386 0:2003.1-5.fc5 set to be updated
--- Package libgfortran.i386 0:4.1.1-1.fc5 set to be updated
--- Package ImageMagick.i386 0:6.2.5.4-4.2.1.fc5.4 set to be updated
--- Package lasi.i386 0:1.0.5-2.fc5 set to be updated
-- Running transaction check
-- Processing Dependency: libwmflite-0.2.so.7 for package: ImageMagick
-- Restarting Dependency Resolution with new changes.
-- Populating transaction set with selected packages. Please wait.
--- Package libwmf.i386 0:0.2.8.4-5.2 set to be updated
-- Running transaction check

Dependencies Resolved

=
 Package Arch   Version  RepositorySize
=
Installing:
 gdl i386   0.8.11-4.fc5 extras2.0 M
Installing for dependencies:
 ImageMagick i386   6.2.5.4-4.2.1.fc5.4  updates   3.1 M
 ImageMagick-c++ i386   6.2.5.4-4.2.1.fc5.4  updates   143 k
 fftwi386   3.1.1-1.fc5  extras890 k
 gsl i386   1.7-1.2.1core  742 k
 hdf5i386   1.6.5-5.fc5  extras2.6 M
 lasii386   1.0.5-2.fc5  extras 36 k
 libgfortran i386   4.1.1-1.fc5  updates   194 k
 libwmf  i386   0.2.8.4-5.2  updates   821 k
 plplot  i386   5.6.1-2.fc5  extras2.9 M
 qhull   i386   2003.1-5.fc5 extras382 k

Transaction Summary
=
Install 11 Package(s)
Update   0 Package(s)
Remove   0 Package(s)
Total download size: 14 M
Is this ok [y/N]: n
Exiting on user Command
Complete!

If you are still having problems, please provide the output of yum install gdl

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list

[Bug 203825] yum install gdl failes due to dependency on ImageMagic

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: yum install gdl failes due to dependency on ImageMagic


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203825


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Component|Package Review  |gdl
 CC|[EMAIL PROTECTED], fedora- |
   |[EMAIL PROTECTED]   |




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203520] Review Request: evolution-brutus

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: evolution-brutus
Alias: evolution-brutus

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203520


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Alias||evolution-brutus




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 173249] Review Request: Music Player Daemon

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Music Player Daemon


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173249


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC|fedora-extras-  |
   |[EMAIL PROTECTED] |
 CC||fedora-package-
   ||[EMAIL PROTECTED]
 CC|fedora-package- |
   |[EMAIL PROTECTED]   |
 CC||fedora-extras-
   ||[EMAIL PROTECTED]

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 199681] Review Request: slab

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: slab


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199681





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 11:12 EST ---
Created an attachment (id=134825)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=134825action=view)
poor font rendering example


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 199681] Review Request: slab

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: slab


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199681





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 11:14 EST ---
I'm getting poor font rendering in slab. See previous attachment. Under FC5.
It's not the standard font but Maiandra GD. I don't see the poor font rendering
anywhere else on my desktop.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 199681] Review Request: slab

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: slab


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199681





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 11:18 EST ---
Sorry to spam but I guess it could be just bad looking bolding? Or non standard
bolding? I just tried bolding some text in an html email in evolution with the
same font and it looked fine even at different sizes.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 198830] Review Request: libmodelfile - library for accessing WorldForge model files

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libmodelfile - library for accessing WorldForge model 
files
Alias: libmodelfile

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198830


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 11:19 EST ---
Sorry about the clash. This is the first and only package I have distributed
which is not under the GPL, so I screwed up. The wording was intended to be GPL
compatable, but still allow essentially unrestricted commercial use. I will
re-word the copyright statement in the code, and release a new version without
any reference to the GPL.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 200976] Review Request: cyphesis - WorldForge game server

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cyphesis - WorldForge game server


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200976





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 11:25 EST ---
IPv6 should be supported via skstream which I also maintain. I tested using IPv6
with cyphesis at the time I did the development work on skstream. I have not had
much chance to test since, but as I work at a site with native IPv6 on the whole
network, it is likely my test machines use IPv6 by default.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 198830] Review Request: libmodelfile - library for accessing WorldForge model files

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libmodelfile - library for accessing WorldForge model 
files
Alias: libmodelfile

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198830





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 11:53 EST ---
After re-reading the thread, I am no longer exactly clear what is wrong with
clause 2. Can someone suggest a minimal wording for requiring that source
changes are marked as such, while keeping compatable with the wordier
requirements in the GPL?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203217] Review Request: csound - music synthesis system

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: csound - music synthesis system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203217





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 12:53 EST ---
Couple of quick items:

1. Source should be full URL.
2. Package fails to build in Mock.  I'll attach the build log for it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203217] Review Request: csound - music synthesis system

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: csound - music synthesis system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203217





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 12:53 EST ---
Created an attachment (id=134832)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=134832action=view)
Mock Build Log


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 169704] Review Request: mosml - Moscow ML

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mosml - Moscow ML


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169704





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 13:05 EST ---
Created an attachment (id=134834)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=134834action=view)
mail from upstream

Here is the answer from Peter Sestoft. Since I don't have
access to x86_64, could you look at the points raised?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203217] Review Request: csound - music synthesis system

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: csound - music synthesis system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203217





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 13:09 EST ---
Looking at the .spec alone reveals several orphaned/unincluded
directories:

%{_libdir}/%{name}/
%{_libdir}/%{name}/plugins/
%{_datadir}/%{name}/

# -devel
%{_includedir}/%{name}/

# -tk
%{_libdir}/%{name}/tcl/

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 192436] Review Request: xorg-x11-server-Xgl

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xorg-x11-server-Xgl


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192436


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 13:14 EST ---
Hi
I would like to ask about progress of work with this package, I have a hope 
that it'll be ready to include it into FC6 to extras repository

additionally I want to report a bug in XGL
I have problem with XGL in KDE with compiz installed with this tutorial:
http://illawarra.org/linux/index.php?id=howto
The problem is Polish letters- shortcuts for XGL are
- Left Shif
- Left Ctrl
- Left Alt,
but right alt is locked too, so I can't write polish characters.
my Xorg.conf is
[EMAIL PROTECTED] ~]$ pastebin /etc/X11/xorg.conf
http://en.pastebin.ca/147785

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203217] Review Request: csound - music synthesis system

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: csound - music synthesis system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203217


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203019] Review Request: pyxdg

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pyxdg


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203019


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||WONTFIX




--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 13:23 EST ---
This is not going to go into Core, alacarte no longer uses it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203022] Review Request: alacarte

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: alacarte


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203022


Bug 203022 depends on bug 203019, which changed state.

Bug 203019 Summary: Review Request: pyxdg
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203019

   What|Old Value   |New Value

 Resolution||WONTFIX
 Status|ASSIGNED|CLOSED



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201913] Review Request: compat-gcc-34 - GCC 3.4.6-RH compatibility compiler and libraries

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: compat-gcc-34 - GCC 3.4.6-RH compatibility compiler 
and libraries


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201913


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 13:45 EST ---
This is closed for now.  They've gone into core, but a new bug could be opened
to ask for their move to Extras.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203774] Review Request: xcircuit - Electronic circuit schematic drawing program

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xcircuit - Electronic circuit schematic drawing program


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203774





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 14:24 EST ---
(In reply to comment #1)
 Well, as far as I check this rpm very quickly,
 the packaging issue is almost okay.
 
 # rpmlint is clean.
 # mock build okay.
 
 * Source:http://xcircuit.ece.jhu.edu/...
   They say that http://xcircuit.ece.jhu.edu/ is obsolete, and I can
   find this source on:
   http://opencircuitdesign.com/xcircuit/archive/xcircuit-3.4.26.tgz .
 
 * %patch0 -p0 -b .
   For kindness, please add some suffix.
 
 * %post
   if [ -x %{_bindir}/gtk-update-icon-cache ]; then
   Require %{_bindir}/gtk-update-icon-cache on post and postun.

Corrected.

 * The included file /usr/lib/xcircuit-3.4/man/xcircuit.1 is
   necessary?

Manual :)

 * I don't know well how to use this, however, when I launch this
   by just typing xcircuit , then I see the following error
   message:
 
 loading history file ... 1 events added
 error in slave eval:
 image type xpm doesn't exist
 Main console display active (Tcl8.4.13 / Tk8.4.13)
 
   Is this okay?
 

Actually, I was unable to recreate this on my FC5. Check again with the updated
srpm.

Updated:
Spec URL: http://chitlesh.funpic.de/rpm/xcircuit.spec
SRPM URL: http://chitlesh.funpic.de/rpm/xcircuit-3.4.26-2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203217] Review Request: csound - music synthesis system

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: csound - music synthesis system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203217





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 14:35 EST ---
Created an attachment (id=134843)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=134843action=view)
Updated spec file

We're trying to base our audio packages off othe PlanetCCRMA packages, but
PlanetCCRMA's Csound is a fair bit older than this one.

I'm attaching an updated spec file, but it still isn't perfect.  It adds
support for java, jack, OSC, DSSI and the Csound GUI.  Please include
incorporate these changes.

I think we should also have a -tutorial subpackage, and solve the missing
manual problem.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203964] New: Review Request: libburn - Library for reading, mastering and writing optical discs

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203964

   Summary: Review Request: libburn - Library for reading, mastering
and writing optical discs
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://people.redhat.com/jkeating/extras/libburn/libburn.spec
SRPM URL: 
http://people.redhat.com/jkeating/extras/libburn/libburn-0.2-1.20060823svn.src.rpm
Description: 

Libburn is an open-source library for reading, mastering and writing
optical discs. For now this means only CD-R and CD-RW.

The project comprises of several more or less interdependent parts which
together strive to be a usable foundation for application development.
These are libraries, language bindings, and middleware binaries which emulate
classical (and valuable) Linux tools.

rpmlint warns about no docs and mixed use of spaces and tabs.  Those could be 
ignored IMHO.

rpmlint also errors about shellbang stuff in the debuginfo package and I think 
thats because the upstream files have execute permissions on them or some such. 
 I think I can fix that in my svn checkout, and will need to make sure that the 
upstream released tarballs have correct perms.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 169704] Review Request: mosml - Moscow ML

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mosml - Moscow ML


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169704





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 14:52 EST ---
I managed to build in mock on fedora-development-i386-core
flawlessly without the problem you had. So this seems
very much related to x86_64.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203217] Review Request: csound - music synthesis system

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: csound - music synthesis system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203217





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 15:05 EST ---
(In reply to comment #4)
 Created an attachment (id=134843)
 -- 
(https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=134843action=view) 
[edit]
 Updated spec file
 
 We're trying to base our audio packages off othe PlanetCCRMA packages, but
 PlanetCCRMA's Csound is a fair bit older than this one.
 
 I'm attaching an updated spec file, but it still isn't perfect.  It adds
 support for java, jack, OSC, DSSI and the Csound GUI.  Please include
 incorporate these changes.
 
 I think we should also have a -tutorial subpackage, and solve the missing
 manual problem.
 

I'll incorporate your patch.  BTW, do you know if enabling Jack makes it
required at runtime, or is csound smart enough to not use it?  I don't think
OLPC won't have Jack and we don't want to fork...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203217] Review Request: csound - music synthesis system

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: csound - music synthesis system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203217





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 17:23 EST ---
8---
 In %files...
 
 The %{_bindir} entries can be globbed to make things easier to read (or better
 still, a simple for loop on the package names.

Can that be done even if some stuff from %{_bindir} is owned by a sub-package?
---8

I know I've done it in other packages - but only where the main package has
owned the root directory. Remember, you can always use %dir

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203964] Review Request: libburn - Library for reading, mastering and writing optical discs

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libburn - Library for reading, mastering and writing 
optical discs


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203964





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 15:50 EST ---
Herm, proper url:

http://people.redhat.com/jkeating/extras/libburn/libburn-0.2-1.20060823svn.fc6.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 196120] Review Request: gresistor

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gresistor


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196120





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 16:43 EST ---
http://chitlesh.funpic.de/rpm/gresistor.spec
http://chitlesh.funpic.de/rpm/gresistor-0.0.1-3.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203217] Review Request: csound - music synthesis system

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: csound - music synthesis system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203217





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 17:20 EST ---
(In reply to comment #7)
 I'm a tad concerned that it's redefining printf for some reason in a HELL of a
 lot of files. It seems to be coming from h/csoundCore.h line 119

I asked about that, upstream is now aware that we dislike it :)  It was added to
make sure that all plugins use the Csound logging facilities.  I think it may go
away in the near future, and we can likely remove it if we wish.

 
 rpmlint warnings.
 
 src.rpm is clean
 
 csound-5.03.0-2 : W: csound no-soname %{_libdir}/lib_csnd.so (should this not 
 be
 in the -devel package?

No, it's the python module code, and it should be in
/usr/lib/python2.4/site-packages/.  I'll move it.

 csound-devel : W: csound-devel no-docs (can be ignored)
 
 csound-python: W: dangling-symlink %{_libdir}/python2.4/site-packages/_csnd.so
 %{_libdir}/lib_csnd.so
 csound-python: W: symlink-should-be-relative
 %{_libdir}/python2.4/site-packages/_csnd.so %{_libdir}/lib_csnd.so

Will be fixed when that lib moves to python's site-packages.
 
 csound-java: W: no-soname %{_libdir}/lib_jsound.so
  W: no-docs
  W: symlink-should-be-relative %{_datadir}/java/csnd.jar
 %{_libdir}/csound/java/csnd.jar

This one shouldn't be a symlink either, should probably move csnd.jar to
%{_datadir} too.

 csound-tk: E: only-non-binary-in-usr-lib
W: no docs
 
 csound-debuginfo: clean
 
 For the missing .so files, these really should be in the csound-devel package
 (and java-devel package). The tk Error must be attended to.

Except that most aren't devel libs; they are the java and python module
libraries and should live in those packages, not in the main csound packages.

 
 Your specfile is also missing Requires(post and postun): /sbin/ldconfig

Will add.

 Does the package not come with other vocabulary languages? If this is for the
 OLPC programme, then it makes sense for translations to be in there!

I don't think so...  I couldn't see a switch for it at build-time, but I'll ask.

 In %files...
 
 The %{_bindir} entries can be globbed to make things easier to read (or better
 still, a simple for loop on the package names.

Can that be done even if some stuff from %{_bindir} is owned by a sub-package?

 In %files devel
 %{_includedir}/%{name}/* Need to be changed to %{includedir}/%{name}/ to take
 ownership of the directory and files

Will do.

 In %files tk
 
 I'm not sure about the .tk files in %{_libdir}. Is this the correct place for
them?

Yeah, that's odd.  I'm not sure.

 csound is currently building in mock - I'll report back when it's done.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203274] Review Request: lesstif - OSF/Motif(R) library clone

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lesstif - OSF/Motif(R) library clone


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203274


[EMAIL PROTECTED] changed:

   What|Removed |Added

  BugsThisDependsOn||203993




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 192417] Review Request: Wcl - Widget Creation Library

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Wcl - Widget Creation Library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192417





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 17:37 EST ---
I am not convinced that this package is interesting 
enough. I have posted a spec file anyway:

http://www.environnement.ens.fr/perso/dumas/fc-srpms/Wcl.spec

Are you really interested in that package being in
extras? Xbae depends on it, but only to build an example,
so maybe it should better be closed.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 191590] Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191590





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 16:00 EST ---
The specfile uses make instead of make %{?_smp_mflags}

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 191590] Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191590


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 15:56 EST ---
I guess to avoid rpmlint symlink errors/warnings you can change
ln -s %{_bindir}/jack-dssi-host $RPM_BUILD_ROOT%{_bindir}/fluidsynth-dssi
to
cd %{_bindir}
ln -s jack-dssi-host fluidsynth-dssi
cd -
because there is no need to make the symlinks across the filesystem if source
and target are in the same directory. This concerns also your other dssi 
plugin(s).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193784] Review Request: linuxdcpp - A port of DC++ to Linux

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: linuxdcpp - A port of DC++ to Linux


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193784


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 16:15 EST ---
%lang(ru) %doc README.lang.ru should not work as expected, see:
https://www.redhat.com/archives/fedora-extras-list/2006-August/msg00071.html





-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 196120] Review Request: gresistor

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gresistor


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196120


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 16:19 EST ---
Cannot access specfile:

$ curl -I http://beta.glwb.info/gresistor/gresistor.spec
curl: (7) couldn't connect to host

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203217] Review Request: csound - music synthesis system

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: csound - music synthesis system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203217





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 16:20 EST ---
(In reply to comment #5)
 I'll incorporate your patch.  BTW, do you know if enabling Jack makes it
 required at runtime, or is csound smart enough to not use it?  I don't think
 OLPC won't have Jack and we don't want to fork...

Try packaging %{_libdir}/csound/plugins/librtjack.so into a subpackage.
The same may work for the libdssi4cs.so and libosc.so if you want to make it
really modular.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 192417] Review Request: Wcl - Widget Creation Library

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Wcl - Widget Creation Library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192417


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 17:02 EST ---
The URL to the spec file is missing.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 190346] Review Request: vdr-subtitles - DVB subtitles plugin for VDR

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vdr-subtitles - DVB subtitles plugin for VDR


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190346


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 16:59 EST ---
The URL to the spec file is missing.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203217] Review Request: csound - music synthesis system

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: csound - music synthesis system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203217





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 16:40 EST ---
I'm a tad concerned that it's redefining printf for some reason in a HELL of a
lot of files. It seems to be coming from h/csoundCore.h line 119

rpmlint warnings.

src.rpm is clean

csound-5.03.0-2 : W: csound no-soname %{_libdir}/lib_csnd.so (should this not be
in the -devel package?

csound-devel : W: csound-devel no-docs (can be ignored)

csound-python: W: dangling-symlink %{_libdir}/python2.4/site-packages/_csnd.so
%{_libdir}/lib_csnd.so
csound-python: W: symlink-should-be-relative
%{_libdir}/python2.4/site-packages/_csnd.so %{_libdir}/lib_csnd.so

csound-java: W: no-soname %{_libdir}/lib_jsound.so
 W: no-docs
 W: symlink-should-be-relative %{_datadir}/java/csnd.jar
%{_libdir}/csound/java/csnd.jar

csound-tk: E: only-non-binary-in-usr-lib
   W: no docs

csound-debuginfo: clean

For the missing .so files, these really should be in the csound-devel package
(and java-devel package). The tk Error must be attended to.

Your specfile is also missing Requires(post and postun): /sbin/ldconfig

Does the package not come with other vocabulary languages? If this is for the
OLPC programme, then it makes sense for translations to be in there!

In %files...

The %{_bindir} entries can be globbed to make things easier to read (or better
still, a simple for loop on the package names.

In %files devel
%{_includedir}/%{name}/* Need to be changed to %{includedir}/%{name}/ to take
ownership of the directory and files

In %files tk

I'm not sure about the .tk files in %{_libdir}. Is this the correct place for 
them?

csound is currently building in mock - I'll report back when it's done.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 190344] Review Request: vdr-osdteletext - OSD teletext plugin for VDR

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vdr-osdteletext - OSD teletext plugin for VDR


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190344


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 16:55 EST ---
The URL to the spec file is missing.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203217] Review Request: csound - music synthesis system

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: csound - music synthesis system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203217





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 17:41 EST ---
(In reply to comment #7)
 csound-java: W: no-soname %{_libdir}/lib_jsound.so

I think this is ignoreable, as lib_jcsound.so is only ever ldopened (btw, what
happened to the 'c' in lib_jcsound.so? cut-n-paste error?)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203964] Review Request: libburn - Library for reading, mastering and writing optical discs

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libburn - Library for reading, mastering and writing 
optical discs


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203964


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203217] Review Request: csound - music synthesis system

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: csound - music synthesis system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203217





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 17:21 EST ---
mock fails - you need to add BR libpng-devel (failed building the GUI)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203217] Review Request: csound - music synthesis system

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: csound - music synthesis system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203217





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 17:46 EST ---
(In reply to comment #8)
 (In reply to comment #7)
   W: symlink-should-be-relative %{_datadir}/java/csnd.jar
  %{_libdir}/csound/java/csnd.jar
 
 This one shouldn't be a symlink either, should probably move csnd.jar to
 %{_datadir} too.

I think we should keep this as a symlink (although I suppose it can be
relative).  Upstream wants it in %{_libdir}/csound/java, but our fedora standard
is to place .jar files in %{_javadir} (== %{_datadir}/java).  We should leave it
in both places to satisfy both our requirement and any upstream packages that
expect to find it in csound's %{_libdir}/csound/java directory.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203217] Review Request: csound - music synthesis system

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: csound - music synthesis system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203217


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Attachment #134843|0   |1
is obsolete||




--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 17:50 EST ---
Created an attachment (id=134864)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=134864action=view)
Specfile v3

Splits out the jack, dssi, and osc bits.  We want this _really_ modular so OLPC
can use it.  Also incorporates cleanup suggestions from above.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 190343] Review Request: VDR - Video Disk Recorder

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: VDR - Video Disk Recorder


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190343





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 17:53 EST ---
http://cachalot.mine.nu/5/SRPMS/vdr-1.4.1-11.src.rpm

* Mon Aug 21 2006 Ville Skyttä ville.skytta at iki.fi - 1.4.1-11
- Set device permissions in both console.perms and udev (#202132).
- Sync restart and DVB module reload functionality with upstream runvdr.

* Fri Aug 18 2006 Ville Skyttä ville.skytta at iki.fi - 1.4.1-10
- Fix build with recent kernel headers where _syscallX are no longer visible.
- Drop ia64 patch (superseded by the above) and the thread poison patch.

* Fri Aug 11 2006 Ville Skyttä ville.skytta at iki.fi - 1.4.1-9
- Set device permissions using console.perms instead of udev rules
  to work around new pam trumping udev config (#202132).


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 190346] Review Request: vdr-subtitles - DVB subtitles plugin for VDR

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vdr-subtitles - DVB subtitles plugin for VDR


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190346





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 17:56 EST ---
See bug 190344 comment 2.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 192417] Review Request: Wcl - Widget Creation Library

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Wcl - Widget Creation Library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192417





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 18:11 EST ---
I just looked into old review requests to push them forward, so go ahead and
close it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 178922] Review Request: asterisk - The Open Source PBX

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: asterisk - The Open Source PBX


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178922





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 18:20 EST ---
A couple of vulnerabilities reported against 1.2.10:

http://nvd.nist.gov/nvd.cfm?cvename=CVE-2006-4345
http://nvd.nist.gov/nvd.cfm?cvename=CVE-2006-4346

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 190344] Review Request: vdr-osdteletext - OSD teletext plugin for VDR

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vdr-osdteletext - OSD teletext plugin for VDR


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190344





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 18:24 EST ---
I do not know about other reviewers but I like to take a look into the spec file
before I decide whether or not to spend more time with a review request. When
the URL is provided it only takes the browser to look into it which is a lot
less work than to download the srpm, extract it and look into the spec file.
Besides I am yet very unexperienced and this way I can easily decide whether or
not the spec file is too complicated for me now.  As well the first impression
of the spec file helps me to anticipate how much work the review will be and how
long a mock test build will take. For this reasons maybe you get someone to
review your package faster if you provide a separate spec file but it won't be a
blocker for me. If I find some time I will look into your srpm and review it as
soon as I am in fedorabugs and I feel capable of it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203217] Review Request: csound - music synthesis system

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: csound - music synthesis system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203217





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 19:33 EST ---
Created an attachment (id=134870)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=134870action=view)
Update spec file (v3++)

This version adds -javadoc and -tutorial subpackages.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193110] Review Request: python-sexy

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-sexy


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193110





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 19:44 EST ---
I've talked to Raphael Slinckx on IRC and he agrees that python-sexy should be
under LGPL. I've mailed Christian Hammond in order to update the license file on
svn.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203864] Review Request: tripwire - IDS

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tripwire - IDS


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203864





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 20:13 EST ---
BYI, this also builds fine on x86_64.  The compiler warnings are almost
exclusively warning: 'class blah' has virtual functions but non-virtual
destructor.  I don't see anything about incompatible sizes or the like.  No
%check, though, and I'm not sure how I'd go about doing a quick test.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193110] Review Request: python-sexy

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-sexy


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193110


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 21:15 EST ---
Excellent. Thats the last blocker I saw, so this package is APPROVED. 

Remember to close this bug with NEXTRELEASE once it's imported and built. 



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203217] Review Request: csound - music synthesis system

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: csound - music synthesis system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203217


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Attachment #134864|0   |1
is obsolete||
 Attachment #134870|0   |1
is obsolete||




--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 22:05 EST ---
Created an attachment (id=134885)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=134885action=view)
spec v4

Incorporate v3++ changes and revert change that moved the jarfile.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 191017] Review Request: eclipse-subclipse

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eclipse-subclipse


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191017


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-08-25 00:50 EST ---
I had to chase dependencies a bit to make sure that %libdir/gjc is properly
owned, but I'm pretty sure it is.  I wish there was a handy recursive dependency
chaser.

* source files match upstream.
   (No checksums possible; see above.  Comparison using diff shows the source to
be identical.)
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate (as far as I can tell for Java)
* %clean is present.
* package builds in mock (development, x86_64).
* debuginfo package looks complete (no source, but there are debug symbols).
* rpmlint complaints are acceptable.
* final provides and requires are sane:
  eclipse-subclipse-1.1.5-1.fc6.x86_64.rpm
   org.tigris.subversion.subclipse.ui_1.1.5.jar.so()(64bit)
   subclipse-core.jar.so()(64bit)
   svnClientAdapter.jar.so()(64bit)
   eclipse-subclipse = 1.1.5-1.fc6
  =
   /usr/bin/rebuild-gcj-db
   eclipse-platform
   ganymed-ssh2 = 209
   java-gcj-compat = 1.0.33
   javasvn = 1.1.0
   libgcj_bc.so.1()(64bit)
   librt.so.1()(64bit)
   libz.so.1()(64bit)
   subversion-javahl = 1.3.1

  eclipse-subclipse-book-1.1.5-1.fc6.x86_64.rpm
   eclipse-subclipse-book = 1.1.5-1.fc6
  =
   eclipse-subclipse = 1.1.5-1.fc6

* %check is not present; no test suite upstream.
* no shared libraries are added to the regular linker search paths.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets present (rebuild-gcj-db) are OK.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.  The subversion
book is provided as an eclipse plugin in a separate package.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203774] Review Request: xcircuit - Electronic circuit schematic drawing program

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xcircuit - Electronic circuit schematic drawing program


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203774


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-08-25 01:17 EST ---
Assigning to me.

* manual file issue
 * The included file /usr/lib/xcircuit-3.4/man/xcircuit.1 is
   necessary?

 Manual :)

Well, I should have explained why I asked for this manual.
My build log by using mock says:

..
/usr/bin/install -c -m 644 lib/xcircuit.1
/var/tmp/xcircuit-3.4.26-2.fc6-root-mockbuild/usr/lib/xcircuit-3.4/man/xcircuit.1
..
/usr/bin/install -c -m 644 './lib/xcircuit.1'
'/var/tmp/xcircuit-3.4.26-2.fc6-root-mockbuild/usr/share/man/man1/xcircuit.1'
..

So, actually the file /usr/lib/xcircuit-3.4/man/xcircuit.1 and
/usr/share/man/man1/xcircuit.1.gz are the same. So I mentioned that
/usr/lib/xcircuit-3.4/man/xcircuit.1 may be unnecessary.

* desktop-file-install --vendor fedora \
 -add-category Engineering \
This requires 
update-desktop-database /usr/share/applications on
%post and %postun stage and adding %{_bindir}/update-desktop-database
to Requires(post), Requires(postun) .

Now /usr/share/applications/fedora-xcircuit.desktop says:
-
[Desktop Entry]
Encoding=UTF-8
Name=XCircuit
Exec=xcircuit
Icon=xcircuit
Type=Application
Terminal=false
GenericName=xcircuit
Categories=Qt;KDE;Education;Science;X-Fedora;Engineering;
X-Desktop-File-Install-Version=0.10
-
Does Qt or KDE required? I still gain the following error message:
-
loading history file ... 1 events added
error in slave eval:
image type xpm doesn't exist
Main console display active (Tcl8.4.13 / Tk8.4.13)
(xcircuit) 2 % 
-
Is this message related to Qt or KDE? Please check why I get
this message or tell me what other information you want to
diagnose this.
 


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203774] Review Request: xcircuit - Electronic circuit schematic drawing program

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xcircuit - Electronic circuit schematic drawing program


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203774


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review