[Bug 206693] Review Request: KTechlab - Development and simulation of microcontrollers and electronic circuits

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: KTechlab - Development and simulation of 
microcontrollers and electronic circuits


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206693


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206492] Review Request: ssss - Shamir's secret sharing scheme

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request:  - Shamir's secret sharing scheme


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206492


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||DUPLICATE




--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 02:24 EST ---


*** This bug has been marked as a duplicate of 206494 ***

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206494] Review Request: ssss - Shamir's secret sharing scheme

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request:  - Shamir's secret sharing scheme


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206494





--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 02:24 EST ---
*** Bug 206492 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206494] Review Request: ssss - Shamir's secret sharing scheme

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request:  - Shamir's secret sharing scheme


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206494





--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 02:26 EST ---
Thanks. It was already fixed in 0.5.0-2. Unfortunately, upon my first
submission, bugzilla timed out and I submitted again. Turned out both bugs made
it, and my comments were in the other one.

Thanks for the review and approval

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206494] Review Request: ssss - Shamir's secret sharing scheme

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request:  - Shamir's secret sharing scheme


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206494


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206693] Review Request: KTechlab - Development and simulation of microcontrollers and electronic circuits

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: KTechlab - Development and simulation of 
microcontrollers and electronic circuits


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206693





--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 02:51 EST ---
Ralf, thank you for adding some remarks:

Well, I will review this package.

1. From http://fedoraproject.org/wiki/Packaging/Guidelines :

* Requires
  - Explain why this package requires gputils, gpsim.

* BuildRequires
  - libtool, autoconf is not necessary, perhaps.

* Scriptlets requirements
  - According to http://fedoraproject.org/wiki/Packaging/ScriptletSnippets ,
Requires(post):   desktop-file-utils
Requires(postun): desktop-file-utils
should be removed.

* File and Directory Ownership
  - The following directries are not owned.
/usr/share/config.kcfg/

2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines :
  = Nothing.

3. Other things I have noticed:
   ? Well, I would appreciate it when someone would check if
 this package can be build on x86_64 as this uses qt-devel.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206693] Review Request: KTechlab - Development and simulation of microcontrollers and electronic circuits

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: KTechlab - Development and simulation of 
microcontrollers and electronic circuits


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206693





--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 02:54 EST ---
Also, check if gettext is requires as BuildRequires.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206693] Review Request: KTechlab - Development and simulation of microcontrollers and electronic circuits

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: KTechlab - Development and simulation of 
microcontrollers and electronic circuits


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206693





--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 03:58 EST ---
Ah, also ldconfig on %post, %postun is not required.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 196101] Review Request: mimedefang

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mimedefang


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196101


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Component|Package Review  |915resolution




--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 06:32 EST ---
Well, I think removing the versionified requirement to perl(Digest::SHA1) would 
be the best as the first official perl-Digest-SHA1 package ever build for a Red 
Hat Linux system was 2.00 and it was build in 2002 when 2.00 appeared in 1998.

Same applies to my own versionified requirement to perl(MIME::Tools), which is 
originally taken from the README file, but I absolutely can't see any problem 
when running it using perl(MIME::Tools) 5.410 which seems to be required as the 
minimum requirement by the code, too.

Removing these two added-by-hand requirements fits to me, is this acceptable?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206761] New: Review Request: kadu-theme - themes for Kadu

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206761

   Summary: Review Request: kadu-theme - themes for Kadu
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://ecik.zspswidwin.pl/kadu/kadu-theme.spec
SRPM URL: http://ecik.zspswidwin.pl/kadu/kadu-theme-0.5.0-1.src.rpm
Description: Set of themes for Kadu. Previously, these themes was included into
main Kadu spec, but I decided to split them out.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 204416] Review Request: libtelepathy - library to ease writing of telepathy clients

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libtelepathy - library to ease writing of telepathy 
clients


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204416


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 204416] Review Request: libtelepathy - library to ease writing of telepathy clients

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libtelepathy - library to ease writing of telepathy 
clients


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204416





--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 06:43 EST ---
I will review this later.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 205912] Review Request: Thunar - Thunar File Manager

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Thunar - Thunar File Manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205912


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-09-15 21:12 EST ---
ok, new version: 

* Fri Sep 15 2006 Kevin Fenzi [EMAIL PROTECTED] - 0.4.0-0.4.rc1
- Added Requires: exo-devel = 0.3.1.10 to devel. 
- exclude docs moved from datadir to docs
- Fixed datdir including files twice

Spec: http://www.scrye.com/~kevin/extras/Thunar/Thunar.spec
Srpm: http://www.scrye.com/~kevin/extras/Thunar/Thunar-0.4.0-0.4.rc1.fc6.src.rpm

--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 06:58 EST ---
There is still an issue, in %files
%{_datadir}/Thunar/sendto/thunar-sendto-email.desktop
is listed twice...

Otherwise
* rpmlint is silent
* free software licence, included
* named according to guidelines
* follow packaging guidelines
* specfile legible
* sane provides
Provides: config(Thunar) = 0.4.0-0.4.rc1 libthunar-vfs-1.so.2 libthunarx-1.so.2
thunar-apr.so thunar-sbr.so thunar-uca.so
* source match upstream
b07ae97a69964112e0af84ba2f63585d  Thunar-0.4.0rc1.tar.bz2
* libs packaged correctly
* docs not used at runtime
* desktop files present and following guidelines
* build and work in devel
* own all directories
* no file included twice
* %files right except for a typo

APPROVED
if you fix the file included twice.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 204416] Review Request: libtelepathy - library to ease writing of telepathy clients

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libtelepathy - library to ease writing of telepathy 
clients


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204416





--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 07:08 EST ---
Before checking 0.0.37-1 :

I cannot rebuild this on FC5.

DEBUG: Executing /usr/sbin/mock-helper chroot
/var/lib/mock/fedora-5-i386-core/root /sbin/runuser - root -c /sbin/runuser -c
'rpmbuild -bs --target i386 --nodeps /builddir/build/SPECS/libtelepathy.spec'
mockbuild
warning: Could not canonicalize hostname: halo.mtk.ioa.s.u-tokyo.ac.jp
Building target platforms: i386
Building for target i386
Wrote: /builddir/build/SRPMS/libtelepathy-0.0.37-1.fc5.src.rpm
DEBUG: ensuring dir /var/lib/mock/fedora-5-i386-core/root/proc
DEBUG: mounting proc in /var/lib/mock/fedora-5-i386-core/root/proc
DEBUG: Executing /usr/sbin/mock-helper mount -t proc proc
/var/lib/mock/fedora-5-i386-core/root/proc
mount: proc already mounted or /var/lib/mock/fedora-5-i386-core/root/proc busy
mount: according to mtab, proc is mounted on /proc
DEBUG: ensuring dir /var/lib/mock/fedora-5-i386-core/root/dev/pts
DEBUG: mounting devpts in /var/lib/mock/fedora-5-i386-core/root/dev/pts
DEBUG: Executing /usr/sbin/mock-helper mount -t devpts devpts
/var/lib/mock/fedora-5-i386-core/root/dev/pts
mount: devpts already mounted or /var/lib/mock/fedora-5-i386-core/root/dev/pts 
busy
mount: according to mtab, devpts is mounted on /dev/pts
DEBUG: yum: command /usr/sbin/mock-helper yum --installroot
/var/lib/mock/fedora-5-i386-core/root resolvedep  'dbus-devel' 'dbus-glib-devel'
DEBUG: Executing /usr/sbin/mock-helper yum --installroot
/var/lib/mock/fedora-5-i386-core/root resolvedep  'dbus-devel' 'dbus-glib-devel'
No Package Found for dbus-glib-devel
0:dbus-devel-0.61-3.fc5.1.i386
Cannot find build req  dbus-glib-devel. Exiting.
ending
DEBUG: Executing /usr/sbin/mock-helper umount
/var/lib/mock/fedora-5-i386-core/root/proc
DEBUG: Executing /usr/sbin/mock-helper umount
/var/lib/mock/fedora-5-i386-core/root/dev/pts
done

See the argument on bug 206576 (this bug is marked as DEFERRED)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 204416] Review Request: libtelepathy - library to ease writing of telepathy clients

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libtelepathy - library to ease writing of telepathy 
clients


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204416





--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 08:59 EST ---
Build this under FC6.  The spec isn't set-up for FC5, which will require
dbus-glib-devel to be changed to dbus-glib.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 204416] Review Request: libtelepathy - library to ease writing of telepathy clients

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libtelepathy - library to ease writing of telepathy 
clients


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204416





--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 09:08 EST ---
(In reply to comment #6)
 Build this under FC6.  The spec isn't set-up for FC5, which will require
 dbus-glib-devel to be changed to dbus-glib.

I mean that this spec file requires a switch to be built under
both FC6-devel and FC5.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 204416] Review Request: libtelepathy - library to ease writing of telepathy clients

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libtelepathy - library to ease writing of telepathy 
clients


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204416





--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 09:21 EST ---
I'm not really planning on targetting FC5 at the moment, and if so will modify
the FC5 branch, and not use a switch.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 196101] Review Request: mimedefang

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mimedefang


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196101


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Component|915resolution   |Package Review
OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 09:46 EST ---
Sure, that's the simplest thing to do.  Since that's the only issue and the fix
is trivial, I'll go ahead and approve and you can just take them out before you
check in.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206494] Review Request: ssss - Shamir's secret sharing scheme

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request:  - Shamir's secret sharing scheme


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206494





--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 10:03 EST ---
Oh, I apologize for not seeing that other ticket.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 204416] Review Request: libtelepathy - library to ease writing of telepathy clients

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libtelepathy - library to ease writing of telepathy 
clients


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204416


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 10:13 EST ---
1. From http://fedoraproject.org/wiki/Packaging/Guidelines :

* Use rpmlint
  - rpmlint is not silent.

W: libtelepathy mixed-use-of-spaces-and-tabs
   Well, unify space/tab. For this case, don't use tabs in
   spec file. 
   sed -i -e 's|\t|  |g' foo.spec is the most simple way
   to remove tabs.

W: libtelepathy-devel no-documentation
   (I think this can be ignored.)

2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
   = Nothing.

3. Other things I have noticed:
   = Nothing.

Fix space/tab issue on spec file.
However, I cannot find any problem aside this.

---
   This package (libtelepathy) is APPROVED by me.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 202901] Review Request: pgFouine - PostgreSQL log analyzer

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pgFouine -  PostgreSQL log analyzer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202901





--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 11:16 EST ---
MD5Sums
096978d9e953fb9a12487d75455d  pgfouine-0.7-4.src.rpm
ad2b56340581758fbda051abdc340d71  pgfouine.spec
c6b09d495fd11e0b8e9b4b86e4252449  pgfouine-0.7-include_path.patch
4ad02f17d9da3789e548bac77fd2f2a5  pgfouine-0.7.tar.gz

Blockers:
* Macros are used everywhere except in the patch file.

  As long as the patch defines /usr/share/... explicitly, the sed line in
  the spec file won't accomplish anything.  If the patch instead defines it as
  @INCLUDEPATH@ then the sed substitution will change @INCLUDEPATH@ into
  whatever the datadir is.  Eventually, the upstream build script can do the
  substitution itself based on what the value of an ENVIRNMENT VARIABLE or
  define passed to make.

Fixed:
* Source matches upstream tarball now.  One thing to remember is that you
  should be slightly paranoid as a packager.  The software that you package is
  going to be installed on a lot of end-user machines.  If someone says they
  are upstream and sends you a tarball you should still check it against the
  tarball on the upstream site, compare to upstream gpg signatures or MD5Sums,
  check against tarballs in packages from other distributions, or etc.  You
  only have a reviewer checking MD5Sums while the package is being submitted.
  Once it is in the repository it is up to you to ensure that the package
  continues to contain the source from upstream.
* INSTALL has been removed and ChangeLog added.
* Tests have been removed from the binary package.
* buildroot check was removed.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 202901] Review Request: pgFouine - PostgreSQL log analyzer

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pgFouine -  PostgreSQL log analyzer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202901





--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 11:49 EST ---
Toshio,

 * Macros are used everywhere except in the patch file.

It was fixed in upstream. I think the problem occured when Devrim rebuilt the
package (it was OK in the src.rpm I have here).
The current patch in CVS contains @INCLUDEPATH@ so that the sed replacement 
works.

He's on vacation at the moment. I'll ask him to build a new RPM as soon as he's
back home.

Thanks for the review.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 185845] Review Request: rpld - RPL/RIPL remote boot daemon

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rpld - RPL/RIPL remote boot daemon


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185845





--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 11:57 EST ---
Sorry for taking so long to get back to this.

The compiler is still not being called properly; I'm just seeing:

gcc -O -c -o protocol.o protocol.c

I was able to get this to work by changing the makefile patch to the one I'll
attach, and duplicating the call to make in %build.  For some reason the package
wants make to be called twice; the second invocation actually builds the
software.  Before, everything was being built in %install.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 185845] Review Request: rpld - RPL/RIPL remote boot daemon

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rpld - RPL/RIPL remote boot daemon


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185845





--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 11:57 EST ---
Created an attachment (id=136435)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=136435action=view)
Replacement patch which doesn't override OPT.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 185845] Review Request: rpld - RPL/RIPL remote boot daemon

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rpld - RPL/RIPL remote boot daemon


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185845


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 12:57 EST ---
You should use macros here (%{_sbindir} and %{_mandir}):
mkdir -p $RPM_BUILD_ROOT/usr/{sbin,share/man/man{8,5}}


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 205537] Review Request: perl-Test-Object - Thoroughly testing objects via registered handlers

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Test-Object -  Thoroughly testing objects via 
registered handlers


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205537





--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 13:10 EST ---
Still no news from upstream.

I have just requested the FC-5 branch creation as it built correctly in devel
(with a Nakefile.PL patch) and the PPI update also passed all its tests. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 196101] Review Request: mimedefang

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mimedefang


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196101


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 14:16 EST ---
17722 (mimedefang): Build on target fedora-development-extras succeeded.
17723 (mimedefang): Build on target fedora-5-extras succeeded.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 205537] Review Request: perl-Test-Object - Thoroughly testing objects via registered handlers

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Test-Object -  Thoroughly testing objects via 
registered handlers


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205537


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 14:20 EST ---
Built for FC-5 and devel (perl-PPI-1.117-1 also built correctly for FC-5 and 
devel).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206761] Review Request: kadu-theme - themes for Kadu

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kadu-theme - themes for Kadu


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206761


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 14:28 EST ---
I'll take this review.
Where does the version number come from?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206761] Review Request: kadu-theme - themes for Kadu

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kadu-theme - themes for Kadu


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206761





--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 15:05 EST ---
1. package meets naming and packaging guidelines, but the origin of the
version number isn't clear, please explain.
2. specfile is properly named, is cleanly written but doesn't use macros
consistently:
%define _themesdir  /usr/share/kadu/themes

You should use %{_datadir} here. And since you never seem to use %{_themesdir}
without /icons, why not
%define _kaduiconsdir %{_datadir}/kadu/themes/icons ?
3. dist tag is present.
4. build root is correct.
  %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
5. can't verify if license field matches the actual license.
* Crystal theme is - according to README - based on Crystal SVG icons from
everaldo.com, but I can't find any license info there except:
http://www.everaldo.com/legal.html , which is definitely NOT open-source
compatible. It's used in KDE though, so I imagine this is open-source licensed,
but still requires an explanation (maybe README.Fedora?)
* Glass theme has NO license information inside the tarballs
* Nuvola theme is LGPL according to Copyright, but full license text is NOT
included (and at least that Copyright file should be in %files)
6. source files match upstream:
023085edabaf6a1b844fe6b5fc9315f9  kadu-theme-crystal-16.tar.bz2
57852ff3d3fd0063a642fcc173f7fa29  kadu-theme-crystal-22.tar.bz2
c3beb753222b96dad46f3adf230eb3e1  kadu-theme-glass_16.tar.gz
9ee70ca873fd0f22b2b83be133964d89  kadu-theme-glass_22.tar.gz
586cc6ff9ba62f0fdd7c7c1adf229efb  kadu-theme-nuvola-16.tar.gz
7a17b4881141b346c6268ef25c284613  kadu-theme-nuvola-22.tar.gz
7. latest version is being packaged.
8. BuildRequires are proper.
9. didn't check if package builds in mock.
10. rpmlint is more or less silent:
W: kadu-theme-crystal16 no-documentation
W: kadu-theme-crystal22 no-documentation
W: kadu-theme-glass16 no-documentation
W: kadu-theme-glass22 no-documentation
W: kadu-theme-nuvola16 no-documentation
W: kadu-theme-nuvola22 no-documentation
11. final provides and requires are sane:
kadu-theme-crystal16 = 0.5.0-1
=
kadu
kadu-theme-crystal22 = 0.5.0-1
=
kadu
kadu-theme-glass16 = 0.5.0-1
=
kadu
kadu-theme-glass22 = 0.5.0-1
=
kadu
kadu-theme-nuvola16 = 0.5.0-1
=
kadu
kadu-theme-nuvola22 = 0.5.0-1
=
kadu
12. no shared libraries are present.
13. package is not relocatable.
14. owns the directories it creates.
15. doesn't own any directories it shouldn't.
16. no duplicates in %files.
17. file permissions are appropriate.
18. %clean is present.
19. %check is absent and no test suite.
20. no scriptlets present.
21. permitted content.
22. documentation is small, so no -docs subpackage is necessary.
23. %docs are not necessary for the proper functioning of the package.
24. no headers.
25. no pkgconfig files.
26. no libtool .la droppings.
27. not a GUI app in itself, so doesn't require a .desktop entry
28. not a web app.

1. and 2. are easily fixable, so I'm mostly concerned with 5. Please contact
upstream about this. If this is split from an already accepted package, I wonder
why this wasn't caught before...


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 188400] Review Request: ssmtp

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ssmtp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188400


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 16:25 EST ---
Sorry. Due to my stepping out for a while, I am unable to complete this review. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189188] Review Request: sqlgrey - postfix grey-listing policy service

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sqlgrey - postfix grey-listing policy service


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189188


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 16:27 EST ---
Sorry. Due to my stepping out for a while, I am unable to complete this review. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 195486] Review Request: kdenetwork: K Desktop Environment - Network Applications

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kdenetwork: K Desktop Environment - Network 
Applications


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195486


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 16:28 EST ---
Sorry. Due to my stepping out for a while, I am unable to complete this review. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 196434] Review Request: ren

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ren


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196434


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 16:29 EST ---
Sorry. Due to my stepping out for a while, I am unable to complete this review. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 197765] Review Request: libical - A library for parsing iCal component

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libical - A library for parsing iCal component


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197765


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 16:30 EST ---
Sorry. Due to my stepping out for a while, I am unable to complete this review. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 200665] Review Request: ltris

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ltris


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200665


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||NOTABUG




--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 16:32 EST ---
Sorry. Due to my stepping out for a while, I am unable to complete this 
submission.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 200665] Review Request: ltris

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ltris


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200665


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163776  |
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 196570] Review Request: mirage

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mirage


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196570


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||NOTABUG
OtherBugsDependingO|163776  |
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 16:35 EST ---
Sorry. Due to my stepping out for a while, I am unable to complete this 
submission.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 197198] Review Request: ntop

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ntop


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197198


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NOTABUG
OtherBugsDependingO|163778  |
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 16:37 EST ---
Sorry. Due to my stepping out for a while, I am unable to complete this 
submission. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 191590] Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191590





--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 16:41 EST ---
(In reply to comment #4)
 The .desktop file should be in a separate file and not inside the spec.

I decided to delete the .desktop file, as well as the fluidsynth-dssi binary, 
since it is redundant.  FE already has many other ways to run fluidsynth
(qsynth, etC).

 make install DESTDIR=$RPM_BUILD_ROOT
 instead of %makeinstall should work, so you must not use %makeinstall

Fixed.

 You do not package COPYING with contains the license.

Fixed.
 
 The license seems to be GPL but you wrote LGPL in the spec.

Fixed.

Updated bits here:

Spec URL: http://people.redhat.com/green/FE/FC5/fluidsynth-dssi.spec
SRPM URL: http://people.redhat.com/green/FE/FC5/fluidsynth-dssi-0.9.1-4.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 191590] Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191590


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|189886, 189891  |
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189886] Review Request: FluidSynth - Real-time software synthesizer

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: FluidSynth - Real-time software synthesizer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189886


[EMAIL PROTECTED] changed:

   What|Removed |Added

  BugsThisDependsOn|191590  |




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189891] Review Request: liblo - Open Sound Control library

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: liblo - Open Sound Control library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189891


[EMAIL PROTECTED] changed:

   What|Removed |Added

  BugsThisDependsOn|191590  |




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206761] Review Request: kadu-theme - themes for Kadu

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kadu-theme - themes for Kadu


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206761





--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 16:48 EST ---
(In reply to comment #2)
 1. package meets naming and packaging guidelines, but the origin of the
 version number isn't clear, please explain.

Previously, themes was included into main package and they have to get bigger
version release (for example, in repo is available 
kadu-theme-crystal22-0.5.0-20060808svn)

 2. specfile is properly named, is cleanly written but doesn't use macros
 consistently:
 %define _themesdir  /usr/share/kadu/themes
 You should use %{_datadir} here. And since you never seem to use %{_themesdir}
 without /icons, why not
 %define _kaduiconsdir %{_datadir}/kadu/themes/icons ?

%{_datadir} issue is fixed. I don't use kaduiconsdir macro, because I assume
that there will be another themes than only icons, in future.

 5. can't verify if license field matches the actual license.
 * Crystal theme is - according to README - based on Crystal SVG icons from
 everaldo.com, but I can't find any license info there except:
 http://www.everaldo.com/legal.html , which is definitely NOT open-source
 compatible. It's used in KDE though, so I imagine this is open-source 
licensed,

I have noticed legal section on www.evaraldo.com is not open-source compatible,
but the actual icons license I found here:
http://commons.wikimedia.org/wiki/Image:Crystal_Clear_action_1downarrow.png

 * Glass theme has NO license information inside the tarballs

Glass license is written down here: 
http://www.kadu.net/forum/viewtopic.php?t=6815highlight=glass

 * Nuvola theme is LGPL according to Copyright, but full license text is NOT
 included (and at least that Copyright file should be in %files)

I have included all licenses in %doc.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206761] Review Request: kadu-theme - themes for Kadu

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kadu-theme - themes for Kadu


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206761





--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 16:49 EST ---
SPEC file: http://ecik.zspswidwin.pl/kadu/kadu-theme.spec
SRPM file: http://ecik.zspswidwin.pl/kadu/kadu-theme-0.5.0-2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 190029] Review Request: whysynth-dssi - DSSI software synthesizer plugin

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: whysynth-dssi - DSSI software synthesizer plugin


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190029





--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 17:00 EST ---
(In reply to comment #9)
 You should not convert the icon in your spec file. 

Ok, fixed:

Spec URL: http://people.redhat.com/green/FE/FC5/whysynth-dssi.spec
SRPM URL: http://people.redhat.com/green/FE/FC5/whysynth-dssi-20060122-6.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206761] Review Request: kadu-theme - themes for Kadu

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kadu-theme - themes for Kadu


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206761





--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 17:59 EST ---
This is a more authoritative information source for Crystal's LGPL-ness, I'd
say: http://www.kde-look.org/content/show.php?content=8341

Please contact upstream about missing license files!

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206761] Review Request: kadu-theme - themes for Kadu

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kadu-theme - themes for Kadu


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206761


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206814] New: Review Request: hugin - Frontend for Panorama Tools, similar to PTAssembler, PTGui or Open for Windows

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206814

   Summary: Review Request: hugin - Frontend for Panorama Tools,
similar to PTAssembler, PTGui or Open for Windows
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://bugbear.blackfish.org.uk/~bruno/apt/SPECS/hugin.spec
SRPM URL: 
http://bugbear.blackfish.org.uk/~bruno/apt/fedora/linux/5/x86_64/SRPMS.panorama/hugin-0.6.1-2.fc5.src.rpm
Description:

hugin can be used to stitch multiple images together. The resulting image can
span 360 degrees. Another common use is the creation of very high resolution
pictures by combining multiple images. It uses the Panorama Tools as backend to 
create high quality images

Note that this spec file doesn't use the %find_lang macro.  I just can't get it 
to work, so there must be something I'm not doing right.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 191590] Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191590


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 18:49 EST ---
BuildRequires: alsa-lib-devel liblo-devel ladspa-devel is not needed since 
dssi-devel already depends on them and is in BuildRequires

rpmlint: ok 
naming: ok
packaging guidelines: ok
license: ok
sources: ok
06bce40ec6c86545d0587e9364bba116  fluidsynth-dssi-0.9.1.tar.gz
06bce40ec6c86545d0587e9364bba116  fluidsynth-dssi-0.9.1.tar.gz.1

files and directories: ok
mock build: ok

Change the buildrequires and the package is

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 191590] Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191590


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206816] New: Review Request: freedoom-freedm - Deathmatch levels for freedoom

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206816

   Summary: Review Request: freedoom-freedm - Deathmatch levels for
freedoom
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://www.kobold.org/~wart/fedora/freedoom-freedm.spec
SRPM URL: http://www.kobold.org/~wart/fedora/freedoom-freedm-0.5-1.src.rpm
Description: 
Multiplayer deathmatch levels for freedoom

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203662] Review Request: dx - Open source version of IBM's Visualization Data Explorer

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dx - Open source version of IBM's Visualization Data 
Explorer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203662





--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 19:05 EST ---
Review:

builds fine in mock, rpmlint doesn't like the packages but on this occasion, the
errors can be ignored
Software installs and works

Good
consistent use of macros
in US-English, UTF-8
License valid
upstream and source tarballs have same md5
correct use of dist
uses smp_mflags
contains docs
contains clean
no ownership problems
devel package doesn't need pkgconfig
no dupes in the rpms

Needs work
%configure \
--disable-static \
--enable-shared \
--with-jni-path=%{java_home}/include \
--without-javadx \
--disable-dependency-tracking \
--enable-smp-linux \
--enable-new-keylayout \
--with-rsh=%{_bindir}/ssh \

Trailing \ on the end should not be there.

If you remove this, I'm happy to approve the package as is.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206818] New: Review Request: perl-MARC-Record - Object-oriented abstraction of MARC record handling

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206818

   Summary: Review Request: perl-MARC-Record - Object-oriented
abstraction of MARC record handling
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL:
ftp://perl.di.uminho.pt/pub/fedora/perl-MARC-Record.spec
SRPM URL:
ftp://perl.di.uminho.pt/pub/fedora/perl-MARC-Record-1.38-1.src.rpm

Description:
The MARC::* series of modules create a simple object-oriented
abstraction of MARC record handling.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206819] New: Review Request: perl-String-Format - Sprintf-like string formatting capabilities with arbitrary format definitions

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206819

   Summary: Review Request: perl-String-Format - Sprintf-like string
formatting capabilities with arbitrary format
definitions
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL:
ftp://perl.di.uminho.pt/pub/fedora/perl-String-Format.spec
SRPM URL:
ftp://perl.di.uminho.pt/pub/fedora/perl-String-Format-1.14-1.src.rpm

Description:
String::Format lets you define arbitrary printf-like format sequences
to be expanded. This module would be most useful in configuration
files and reporting tools, where the results of a query need to be
formatted in a particular way.

Note:
This is a requirement of Perl::Critic.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203662] Review Request: dx - Open source version of IBM's Visualization Data Explorer

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dx - Open source version of IBM's Visualization Data 
Explorer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203662





--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 19:16 EST ---
Removed:

http://rpm.greysector.net/extras/dx.spec

You're really picky.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203662] Review Request: dx - Open source version of IBM's Visualization Data Explorer

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dx - Open source version of IBM's Visualization Data 
Explorer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203662


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 19:18 EST ---
I know, but you love me really :-)

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206820] New: Review Request: perl-Term-ProgressBar - Provide a progress meter on a standard terminal

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206820

   Summary: Review Request: perl-Term-ProgressBar - Provide a
progress meter on a standard terminal
   Product: Fedora Extras
   Version: devel
  Platform: All
   URL: http://search.cpan.org/dist/Term-ProgressBar/
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


SRPM URL: 
http://home.comcast.net/~ckweyl/perl-Term-ProgressBar-2.09-1.fc5.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-Term-ProgressBar.spec

Description:
Term::ProgressBar provides a simple progress bar on the terminal, to let
the user know that something is happening, roughly how much stuff has been
done, and maybe an estimate at how long remains.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206820] Review Request: perl-Term-ProgressBar - Provide a progress meter on a standard terminal

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Term-ProgressBar - Provide a progress meter on a 
standard terminal


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206820


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||163776
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203662] Review Request: dx - Open source version of IBM's Visualization Data Explorer

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dx - Open source version of IBM's Visualization Data 
Explorer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203662





--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 19:20 EST ---
Likewise, thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 187317] Review Request: mindi

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mindi


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187317


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|ASSIGNED
   Flag|needinfo?([EMAIL PROTECTED]|
   |m)  |




--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 19:22 EST ---
Thanks for looking at the package.

the %post section is to avoid what happens frequently is a dual installation of
tar.gz mindi and .rpm mindi with different versions. Depending on PATH it
creates issues. That message is just here to prevent people doing that
unintentionaly.
In what way is it a problem ? (it doesn't break unattended installation as I've
seen earlier).

Concerning statically built binaries, it is provided upstream like that. It's a
busybox version recompiled for mindi. Of course the .config file is provided so
information on how to rebuild is there. 
mindi doesn't support other arch than x86, x86_64 and ia64, for which there is
another busybox binary. That binary is just used during restore to create a
mini-Unix environement. It would imply an upstream change to modify that, which
is not planned yet.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 191590] Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191590


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 19:25 EST ---
(In reply to comment #6)
 Change the buildrequires and the package is
 
 APPROVED

Done, thanks!



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206821] New: Review Request: perl-Devel-Size - Perl extension for finding the memory usage of Perl variables

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206821

   Summary: Review Request: perl-Devel-Size - Perl extension for
finding the memory usage of Perl variables
   Product: Fedora Extras
   Version: devel
  Platform: All
   URL: http://search.cpan.org/dist/Devel-Size/
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


SRPM URL: http://home.comcast.net/~ckweyl/perl-Devel-Size-0.64-1.fc5.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-Devel-Size.spec

Description:
This module figures out the real sizes of Perl variables in bytes. Call
functions with a reference to the variable you want the size of. If the
variable is a plain scalar it returns the size of the scalar. If the
variable is a hash or an array, use a reference when calling.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206821] Review Request: perl-Devel-Size - Perl extension for finding the memory usage of Perl variables

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Devel-Size - Perl extension for finding the 
memory usage of Perl variables


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206821


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||163776
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206821] Review Request: perl-Devel-Size - Perl extension for finding the memory usage of Perl variables

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Devel-Size - Perl extension for finding the 
memory usage of Perl variables


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206821


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||206824
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 205300] Review Request: gtk-sharp - a set of mono bindings for gtk1.2

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtk-sharp - a set of mono bindings for gtk1.2


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205300





--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 20:33 EST ---
(In reply to comment #9)
 3. Still doesn't seem to build for me in mock/devel:
 
 Patch #0 (gtksharp-libdir.patch):
 + patch -p1 -b --suffix .libdir -s
 + autoreconf
 configure.in:50: error: possibly undefined macro: PKG_PATH
   If this token and others are legitimate, please use m4_pattern_allow.
   See the Autoconf documentation.
 autoreconf: /usr/bin/autoconf failed with exit status: 1
 error: Bad exit status from /var/tmp/rpm-tmp.14789 (%prep)
 
 Are you sure you have the most recent spec up (-7?)

That's because the patch and autoreconf call are invoked only on fc5:
%if %{?fedora}  5
%patch0 -p1 -b .libdir
autoreconf
%endif

FYI: builds fine outside mock on FC5/x86_64

Another nitpick: use %setup -q 



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203662] Review Request: dx - Open source version of IBM's Visualization Data Explorer

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dx - Open source version of IBM's Visualization Data 
Explorer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203662





--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 22:11 EST ---
Imported (wow, that took a while) and built (with a small fix) for devel, FC-5
branch requested.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 187317] Review Request: mindi

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mindi


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187317





--- Additional Comments From [EMAIL PROTECTED]  2006-09-17 00:37 EST ---
Our supported arches are x86, x86_64, and ppc.
from 
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines?action=showredirect=PackageReviewGuidelines
- MUST: If the package does not successfully compile, build or work on an 
architecture, then those architectures should be listed in the spec in 
ExcludeArch. Each architecture listed in ExcludeArch needs to have a bug filed 
in bugzilla, describing the reason that the package does not 
compile/build/work on that architecture. The bug number should then be placed 
in a comment, next to the corresponding ExcludeArch line. New packages will 
not have bugzilla entries during the review process, so they should put this 
description in the comment until the package is approved, then file the 
bugzilla entry, and replace the long explanation with the bug number. (Extras 
Only) The bug should be marked as blocking one (or more) of the following bugs 
to simplify tracking such issues: [WWW] FE-ExcludeArch-x86, [WWW] 
FE-ExcludeArch-x64, [WWW] FE-ExcludeArch-ppc 

prebuilt binaries are not allowed.  you must build them in your package  or  
use the system busybox in this case.
http://fedoraproject.org/wiki/Packaging/Guidelines#head-adf31c383612aac313719f7b4f8167b7dcf245d2

Upstream really should not provide them.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206818] Review Request: perl-MARC-Record - Object-oriented abstraction of MARC record handling

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-MARC-Record - Object-oriented abstraction of MARC 
record handling


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206818


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-09-17 01:17 EST ---
As usual, ... nothing to complain about ;)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206836] New: Review Request: TurboJson - Python template plugin that supports json

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206836

   Summary: Review Request: TurboJson - Python template plugin that
supports json
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://people.redhat.com/lmacken/SPECS/TurboJson.spec
SRPM URL: http://people.redhat.com/lmacken/RPMS/TurboJson-0.9.9-1.src.rpm
Description:
This package provides a template engine plugin, allowing you
to easily use Json with TurboGears, Buffet or other systems
that support python.templating.engines.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206837] New: Review Request: TurboCheetah - TurboGears plugin to support use of Cheetah templates

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206837

   Summary: Review Request: TurboCheetah - TurboGears plugin to
support use of Cheetah templates
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://people.redhat.com/lmacken/SPECS/TurboCheetah.spec
SRPM URL: http://people.redhat.com/lmacken/RPMS/TurboCheetah-0.9.5-1.src.rpm
Description:
This package provides a template engine plugin, allowing you
to easily use Cheetah with TurboGears, Buffet and other tools that
support the python.templating.engines entry point.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206838] New: Review Request: TGFastData - Automatic user interface generation for TurboGears

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206838

   Summary: Review Request: TGFastData - Automatic user interface
generation for TurboGears
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://people.redhat.com/lmacken/SPECS/TGFastData.spec
SRPM URL: http://people.redhat.com/lmacken/RPMS/TGFastData-0.9a6-1.src.rpm
Description:
FastData is an extension to TurboGears which can provide automatic user
interface generation based upon an application's model objects.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206839] New: Review Request: TurboKid - Python template plugin that supports Kid templates

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206839

   Summary: Review Request: TurboKid - Python template plugin that
supports Kid templates
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://people.redhat.com/lmacken/SPECS/TurboKid.spec
SRPM URL: http://people.redhat.com/lmacken/RPMS/TurboKid-0.9.8-2.src.rpm
Description:
This package provides a template engine plugin, allowing you
to easily use Kid with TurboGears, Buffet or other systems
that support python.templating.engines.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206836] Review Request: TurboJson - Python template plugin that supports json

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: TurboJson - Python template plugin that supports json


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206836


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||189338
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 206838] Review Request: TGFastData - Automatic user interface generation for TurboGears

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: TGFastData - Automatic user interface generation for 
TurboGears


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206838


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||189338
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review