[Bug 428973] Review Request: vodovod - a pipe connecting game

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vodovod - a pipe connecting game


https://bugzilla.redhat.com/show_bug.cgi?id=428973





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 03:15 EST ---
Created an attachment (id=293826)
 -- (https://bugzilla.redhat.com/attachment.cgi?id=293826action=view)
Patch to compile against g++43

(In reply to comment #2)
 [OK] package must meet Packaging Guidelines

Well, I know many reviewers uses check-list style
like you. I don't object to it, however I always wonder
what this package must meet Packaging Guidelines means
on this check list. Actually
http://fedoraproject.org/wiki/Packaging/Guidelines
contains 40 items...

Anyway:
* This package does not build on dist-f9.
http://koji.fedoraproject.org/koji/taskinfo?taskID=392156
  A proposed patch is attached.
* On build fedora specific compilation flags are not correctly
  honored (Compiler flags of
  http://fedoraproject.org/wiki/Packaging/Guidelines )
  Using

make %{?_smp_mflags} \
CC=%{__cxx} %{optflags}

  is good for this package.
- Desktop icon must be updated (GTK+ icon cache of
  http://fedoraproject.org/wiki/Packaging/ScriptletSnippets )
- And actually the description of this package
  Vodovod - is redundant.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431310] Review Request: color-filesystem - Color filesystem layout

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: color-filesystem - Color filesystem layout


https://bugzilla.redhat.com/show_bug.cgi?id=431310


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 05:38 EST ---
I guess that there are many directories in the filesystem package that
are not in the FHS and, even if not, it is not an issue to add a set of
common directories in -- if they really fit in.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431323] Review Request: gnome-applet-ontv - OnTV is a GNOME applet to monitor TV programs

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-applet-ontv - OnTV is a GNOME applet to monitor 
TV programs


https://bugzilla.redhat.com/show_bug.cgi?id=431323





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 05:43 EST ---
I'm not using mock. Maybe it's wrong but I never used it.

About building, I had no vte-devel and package was built successfully...

Log of scratch build:

http://koji.fedoraproject.org/koji/getfile?taskID=391994name=build.log

PS: There's an issue with Fedora People - http:404 for all.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has 
been idle


https://bugzilla.redhat.com/show_bug.cgi?id=430441





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 05:34 EST ---
I get a 404 not found

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 187243] Review Request: lazarus : IDE and RAD tool for the free pascal compiler (fpc)

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lazarus : IDE and RAD tool for the free pascal 
compiler (fpc)


https://bugzilla.redhat.com/show_bug.cgi?id=187243





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 06:06 EST ---
(In reply to comment #40)
 The OS X-only script should probably be '%exclude'd from the final file 
 listing ?

I'm a little bit reluctant to do so. Lazarus is an IDE for multiple platforms,
an has several tools for each platform to run on properly. I woudn't be
surprised if there are more files than this one which are in fact for another
operating system.  Maybe for example also some readme's and such. 

Should I now search the complete tree for all those files and exclude them? And
do that for every release?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431323] Review Request: gnome-applet-ontv - OnTV is a GNOME applet to monitor TV programs

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-applet-ontv - OnTV is a GNOME applet to monitor 
TV programs


https://bugzilla.redhat.com/show_bug.cgi?id=431323





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 06:08 EST ---
Yay, success: http://koji.fedoraproject.org/koji/taskinfo?taskID=392428.

Now we must wait for Fedora People...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 429221] Review Request: dzcomm - Dzcomm a RS-232 API/lib

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dzcomm - Dzcomm a RS-232 API/lib


https://bugzilla.redhat.com/show_bug.cgi?id=429221





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 06:11 EST ---
First where is your new spec/srpm? (please change the release number
every time you modify your spec file to avoid confusion)

(In reply to comment #4)
 (In reply to comment #2)
  * Please make it sure that fedora specific compilation flags are
honored correctly (Compiler flags of
http://fedoraproject.org/wiki/Packaging/Guidelines )
  * Compilation flag -O3 is not allowed for Fedora because this
makes debugging difficult.
  * Also -fomit-frame-pointer is forbidden
  * And please consider to remove -ffast-math as this relaxes
calculation precision and may cause debugging difficult.
 make %{?_smp_mflags} changed to make %{optflags} %{?_smp_mflags}
I guess make %optflags %{?_smp_mflags} won't work.

 Does this cover the -O3 flag? Was that being used as the default? (I am not 
 sure
 how -O3 was making it in there).
No. Fedora specific compilation flags can be checked by
rpm --eval %optflags. On rawhide i386 system, this returns:

[EMAIL PROTECTED] ~]# rpm --eval %optflags
-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables


 Removal of -ffast-math? should the %{optflags} take care of this also?
 Just looked at the configure script... Should I just remove the CFLAGS= line
 then gcc would default to whatever the environment is set to (wich should be
 %{optflags})? If so I can patch the configure file.
It seems that some patch is needed against configure.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431320] Review Request: pam_usb - Hardware authentication using ordinary USB Flash Drives

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pam_usb - Hardware authentication using ordinary USB 
Flash Drives


https://bugzilla.redhat.com/show_bug.cgi?id=431320





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 07:03 EST ---
Spec URL: http://web.tiscali.it/guidonet/pam_usb/pam_usb.spec
SRPM URL: http://web.tiscali.it/guidonet/pam_usb/pam_usb-0.4.2-1.fc8.src.rpm

I didn't know that it was already in the repository.
Basically there's no big differences between the old 
pam_usb-0.4.0-1.fc7.src.rpm and my package, however now I merged my changes 
into the old package in the repository and I updated it.
The binaries and the libraries are replaced, and the configuration 
file /etc/pamusb.conf is backward compatible with pam_usb-0.4.0, so there 
shouldn't be problem during the upgrade.
In any case I'll make some tests with Fedora7 in the next few day, then I'll 
let you know if the upgrade works fine.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226428] Merge Review: speex

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: speex


https://bugzilla.redhat.com/show_bug.cgi?id=226428


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|ASSIGNED
   Flag|needinfo?([EMAIL PROTECTED]|
   |net)|




--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 08:19 EST ---
Continuing review :
 * There is still a mess mix of spaces and tabs in the spec file (minor)
 * Passing --with-ogg-libraries=%{_libdir} is not needed
 * The chmod a-x README makes more sense in %prep than in %install
 * Why --enable-static as the static libs are excluded in %files?
 * Why are libspeexdsp.so and libspeexdsp.a in the main package? (major!)
 * The rm -f $RPM_BUILD_ROOT%{_docdir}/speex-*/manual.pdf line is wrong,
   should be rm -f $RPM_BUILD_ROOT%{_docdir}/speex/manual.pdf
 * The %{_defaultdocdir}/speex/manual.pdf line in %files should be removed
   to avoid including the PDF manual twice (after fixing the above rm).

And what about my suggestion of splitting out the two binaries into their own
sub-package, like many other codec library packages do?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426149] Review Request: sshmenu - Application to organize SSH connection information in a menu

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sshmenu - Application to organize SSH connection 
information in a menu


https://bugzilla.redhat.com/show_bug.cgi?id=426149


[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|Review Request: sshmenu -   |Review Request: sshmenu -
   |GNOME panel applet to   |Application to organize SSH
   |organize SSH connection |connection information in a
   |information in a menu   |menu
   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 08:23 EST ---
New Package CVS Request
===
Package Name: sshmenu
Short Description: Application to organize SSH connection information in a menu
Owners: thias
Branches: F-7 F-8 EL-5
InitialCC:
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 249614] Review Request: x11iraf - X utilities for IRAF (Image Reduction Analysis Facility)

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: x11iraf - X utilities for IRAF (Image Reduction 
Analysis Facility)


https://bugzilla.redhat.com/show_bug.cgi?id=249614


[EMAIL PROTECTED] changed:

   What|Removed |Added

Version|devel   |rawhide




--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 08:38 EST ---
No response at all :((

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431356] New: Review Request: dvipng - Converts DVI files to PNG/GIF format

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=431356

   Summary: Review Request: dvipng - Converts DVI files to PNG/GIF
format
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://jgu.fedorapeople.org/dvipng.spec
SRPM URL: http://jgu.fedorapeople.org/dvipng-1.9-1.fc9.src.rpm
Description: 
This program makes PNG and/or GIF graphics from DVI files as obtained
from TeX and its relatives.

It is intended to produce anti-aliased screen-resolution images as
fast as is possible. The target audience is people who need to generate
and regenerate many images again and again. 

Commentary:
Patrice Dumas recently made a call for packages to split out components of 
texlive for which texlive is not upstream. This is one such package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431356] Review Request: dvipng - Converts DVI files to PNG/GIF format

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dvipng - Converts DVI files to PNG/GIF format


https://bugzilla.redhat.com/show_bug.cgi?id=431356





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 09:34 EST ---
Spec URL: http://jgu.fedorapeople.org/dvipng.spec
SRPM URL: http://jgu.fedorapeople.org/dvipng-1.9-2.fc9.src.rpm

* Sun Feb  3 2007 Jonathan G. Underwood [EMAIL PROTECTED] - 1.9-2
- Install dvigif info file
- Add Provides for dvigif


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431323] Review Request: gnome-applet-ontv - OnTV is a GNOME applet to monitor TV programs

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-applet-ontv - OnTV is a GNOME applet to monitor 
TV programs


https://bugzilla.redhat.com/show_bug.cgi?id=431323





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 09:34 EST ---
Spec: http://liviopl.fedorapeople.org/ontv/gnome-applet-ontv.spec
SRPM: http://liviopl.fedorapeople.org/ontv/gnome-applet-ontv-2.8.0-2.fc8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 245919] Review Request: openvpn-auth-ldap - OpenVPN plugin for LDAP authentication

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openvpn-auth-ldap - OpenVPN plugin for LDAP 
authentication


https://bugzilla.redhat.com/show_bug.cgi?id=245919





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 09:28 EST ---
The fix was much easier than I thought. The package only needs a single header
file from the OpenVPN sources : openvpn-plugin.h.
Since the plugin doesn't link against OpenVPN, I've included that header file as
a source of the rpm. It's not the cleanest solution, but I'm not sure it's worth
creating an openvpn-devel package just for this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431250] Review Request: librep - An embeddable LISP environment

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: librep -  An embeddable LISP environment


https://bugzilla.redhat.com/show_bug.cgi?id=431250





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 10:35 EST ---
Updates posted based on feedback from Jason and Michal

http://people.redhat.com/rkhadgar/personal/fedora/librep.spec
http://people.redhat.com/rkhadgar/personal/fedora/librep-0.17-3.20071102svn.fc8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226333] Merge Review: pygtk2 (stalled)

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: pygtk2 (stalled)


https://bugzilla.redhat.com/show_bug.cgi?id=226333


[EMAIL PROTECTED] changed:

   What|Removed |Added

Version|f7  |7

[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|Merge Review: pygtk2|Merge Review: pygtk2
   ||(stalled)




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225684] Merge Review: devhelp (stalled)

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: devhelp (stalled)


https://bugzilla.redhat.com/show_bug.cgi?id=225684


[EMAIL PROTECTED] changed:

   What|Removed |Added

Version|f7  |7

[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|Merge Review: devhelp   |Merge Review: devhelp
   ||(stalled)




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431044] Review Request: perl-ccom - Perl module for context-sensitive phonetic string replacement

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-ccom - Perl module for context-sensitive phonetic 
string replacement


https://bugzilla.redhat.com/show_bug.cgi?id=431044


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 12:04 EST ---
Jason, I'll have a look to that before importing it to CVS.

New Package CVS Request
===
Package Name: perl-ccom
Short Description: Perl module for context-sensitive phonetic string 
replacement
Owners: robert
Branches: F-7 F-8 EL-4 EL-5
InitialCC: 
Cvsextras Commits: no

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226329] Merge Review: pycairo

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: pycairo


https://bugzilla.redhat.com/show_bug.cgi?id=226329


[EMAIL PROTECTED] changed:

   What|Removed |Added

Version|f7  |7

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Priority|low |high




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225816] Merge Review: gnome-doc-utils

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gnome-doc-utils


https://bugzilla.redhat.com/show_bug.cgi?id=225816


[EMAIL PROTECTED] changed:

   What|Removed |Added

Version|devel   |rawhide

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Priority|low |high




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225872] Merge Review: gtkhtml3 (stalled)

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gtkhtml3 (stalled)


https://bugzilla.redhat.com/show_bug.cgi?id=225872


[EMAIL PROTECTED] changed:

   What|Removed |Added

Version|f7  |7

[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|Merge Review: gtkhtml3  |Merge Review: gtkhtml3
   ||(stalled)




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225834] Merge Review: gnome-python2 (stalled)

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gnome-python2 (stalled)


https://bugzilla.redhat.com/show_bug.cgi?id=225834


[EMAIL PROTECTED] changed:

   What|Removed |Added

Version|f7  |7

[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|Merge Review: gnome-python2 |Merge Review: gnome-python2
   ||(stalled)




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225833] Merge Review: gnome-python2-extras (stalled)

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gnome-python2-extras (stalled)


https://bugzilla.redhat.com/show_bug.cgi?id=225833


[EMAIL PROTECTED] changed:

   What|Removed |Added

Version|f7  |7

[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|Merge Review: gnome-python2-|Merge Review: gnome-python2-
   |extras  |extras (stalled)




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225832] Merge Review: gnome-python2-desktop (stalled)

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gnome-python2-desktop (stalled)


https://bugzilla.redhat.com/show_bug.cgi?id=225832


[EMAIL PROTECTED] changed:

   What|Removed |Added

Version|f7  |7

[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|Merge Review: gnome-python2-|Merge Review: gnome-python2-
   |desktop |desktop (stalled)




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431368] New: Review Request: inconsoleata-fonts - A monospace font, designed for code listings and the like, in print

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=431368

   Summary: Review Request: inconsoleata-fonts - A monospace font,
designed for code listings and the like, in print
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: 
http://www.scrye.com/~kevin/fedora/inconsoleata-fonts/inconsolata-fonts.spec
SRPM URL: 
http://www.scrye.com/~kevin/fedora/inconsoleata-fonts/inconsolata-fonts-1.009-1.fc9.src.rpm
Description: 

A monospace font, designed for code listings and the like, in print

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has 
been idle


https://bugzilla.redhat.com/show_bug.cgi?id=430441


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 13:29 EST ---
Is this correct:
Group:  Applications/Internet


I would changed %files lines to:
%doc Changelog License Readme Todo
%{_bindir}/%{name}
%{_mandir}/man1/%{name}.1*

but that's me.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431371] New: Review Request: gyachi - A Yahoo! chat client with Webcam and voice support

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=431371

   Summary: Review Request: gyachi - A Yahoo! chat client with
Webcam and voice support
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://sundaram.fedorapeople.org/packages/gyachi.spec
SRPM URL: http://sundaram.fedorapeople.org/packages/gyachi-1.1.0-3.fc8.src.rpm
Description: 
GYachI is a Linux client for Yahoo! Messenger protocol, written using GTK+ GUI 
toolkit. This package includes both the external voice chat program, GYVoice, 
and the external webcam program, GyachI-Webcam. 

In addition, this package includes GyachI-Broadcaster for sending webcam 
streams.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 187243] Review Request: lazarus : IDE and RAD tool for the free pascal compiler (fpc)

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lazarus : IDE and RAD tool for the free pascal 
compiler (fpc)


https://bugzilla.redhat.com/show_bug.cgi?id=187243





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 13:34 EST ---
(In reply to comment #41)
 (In reply to comment #40)
  The OS X-only script should probably be '%exclude'd from the final file
listing ?
 
 I'm a little bit reluctant to do so. Lazarus is an IDE for multiple platforms,
 an has several tools for each platform to run on properly. I woudn't be
 surprised if there are more files than this one which are in fact for another
 operating system.  Maybe for example also some readme's and such. 
 
 Should I now search the complete tree for all those files and exclude them? 
 And
 do that for every release?

Good point. If there are multiple files like that, then if only for consistency,
it's better to just include them all. The users could be trusted to figure out
which script applies to their environment.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 246525] Review Request: libMini - A high-performance terrain rendering library

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libMini - A high-performance terrain rendering library
Alias: mini

https://bugzilla.redhat.com/show_bug.cgi?id=246525





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 13:38 EST ---
Yes. I'll try and post another spec in the next week or two. I don't think that
we'll need to modify the source since the DXT code isn't in libmini. The
patented code is in libsquish which libmini links against (which is now 
optional).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428973] Review Request: vodovod - a pipe connecting game

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vodovod - a pipe connecting game


https://bugzilla.redhat.com/show_bug.cgi?id=428973


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-review?




--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 13:59 EST ---
 Well, I know many reviewers uses check-list style
 like you. I don't object to it, however I always wonder
 what this package must meet Packaging Guidelines means
 on this check list. Actually
 http://fedoraproject.org/wiki/Packaging/Guidelines
 contains 40 items...

I shall keep that in mind. ;)

Other than that I'll wait for an updated package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226488] Merge Review: texinfo

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: texinfo


https://bugzilla.redhat.com/show_bug.cgi?id=226488





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 14:05 EST ---
Please rebuild texinfo as soon as possible, currently the texinfo tex
files are in the void.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has 
been idle


https://bugzilla.redhat.com/show_bug.cgi?id=430441





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 14:15 EST ---
(In reply to comment #14)
 I get a 404 not found
fedorapeople.org was down for some reason today, i read it on the mailing list.
should work now.

(In reply to comment #15)
 Is this correct:
 Group:  Applications/Internet
no. fixing.

* Sun Feb 03 2008 Ian Weller [EMAIL PROTECTED] 2.2-4
- Fixed dates in changelog (2007 - 2008)
- Fixed grouping
- Tightened up files list

spec: http://ianweller.fedorapeople.org/SRPMS/xautolock/2.2-4/xautolock.spec
srpm:
http://ianweller.fedorapeople.org/SRPMS/xautolock/2.2-4/xautolock-2.2-4.fc8.src.rpm

koji builds: all passed
dist-fc7: http://koji.fedoraproject.org/koji/taskinfo?taskID=393437
dist-f8:  http://koji.fedoraproject.org/koji/taskinfo?taskID=393430
dist-f9:  http://koji.fedoraproject.org/koji/taskinfo?taskID=393442

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 231809] Review Request: xmlrpc-epi - An implementation of the xmlrpc protocol in C

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xmlrpc-epi - An implementation of the xmlrpc protocol 
in C
Alias: xmlrpc-epi

https://bugzilla.redhat.com/show_bug.cgi?id=231809


[EMAIL PROTECTED] changed:

   What|Removed |Added

Version|devel   |rawhide

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 14:24 EST ---
i tried looking up the license and it only shows up on one page in google at
http://www.thepromisedlan.org/flatnuke/sections/Download/Freedom/LICENSE-libraries-linux.txt
under xmlrpc-epi license. i'm not sure if this is can be packaged in fedora
based on the license, and if it can, what do we call it?

(the license also shows up at
http://xmlrpc-epi.sourceforge.net/main.php?t=license )

i'm assuming the reason it was considered BSD before was because that is what
it is considered on the sf.net project home page.

i'm not sure where to make an upstream inquiry, their devel list on sf.net has
turned into a spam list.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 430360] Review Request: ggz-gtk-client - Gtk+ client libraries for GGZ gaming zone

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ggz-gtk-client - Gtk+ client libraries for GGZ gaming 
zone


https://bugzilla.redhat.com/show_bug.cgi?id=430360


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 14:24 EST ---
I recently became aware of a fix for the unused-direct-shlib-dependency
complaints; you can put this after the %configure call:

# hack to omit unused-direct-shlib-dependencies
sed -i -e 's! -shared ! -Wl,--as-needed\0!g' libtool

and the problematic dependencies go away.  It's not a huge issue but it's easy
to fix, so do what you think is best.

With that fix, the only other rpmlint complaint is:
  ggz-gtk-client-devel.x86_64: W: no-documentation
which is not a problem.

* source files match upstream:
   790f7db17e252e02c07f68cbdda3de071945e284582edd1c5b21891e568c6cff  
   ggz-gtk-client-0.0.14.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summaries are OK.
* descriptions are OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
  ggz-gtk-client-0.0.14-2.fc9.x86_64.rpm
   libggz-gtk.so.1()(64bit)
   ggz-gtk-client = 0.0.14-2.fc9
  =
   /sbin/ldconfig
   libgdk-x11-2.0.so.0()(64bit)
   libgdk_pixbuf-2.0.so.0()(64bit)
   libggz-gtk.so.1()(64bit)
   libggz.so.2()(64bit)
   libggzcore.so.9()(64bit)
   libglib-2.0.so.0()(64bit)
   libgobject-2.0.so.0()(64bit)
   libgtk-x11-2.0.so.0()(64bit)
   libpango-1.0.so.0()(64bit)

  ggz-gtk-client-devel-0.0.14-2.fc9.x86_64.rpm
   ggz-gtk-client-devel = 0.0.14-2.fc9
  =
   ggz-client-libs-devel
   ggz-gtk-client = 0.0.14-2.fc9
   gtk2-devel
   libggz-devel
   libggz-gtk.so.1()(64bit)

* %check is not; no test suite upstream.
* shared libraries installed; ldconfig is called properly.
* unversioned .so files are in the -devel package.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (ldconfig)
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* headers are in the -devel package.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431320] Review Request: pam_usb - Hardware authentication using ordinary USB Flash Drives

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pam_usb - Hardware authentication using ordinary USB 
Flash Drives


https://bugzilla.redhat.com/show_bug.cgi?id=431320





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 14:43 EST ---
I've found that in Fedora7 is available only pam_usb-0.3.3 and this is not 
good.
The problem is that in the 0.4.x series certificates have been replaced by One 
Time Pads, so upgrading from pam_usb-0.3.3 to pam_usb-0.4.2 is impossible 
without loosing the old settings.

pam_usb-0.3.3 is really old and obsolete, the security model of pam_usb-0.4.2 
is more powerfull and a lot of bugs was fixed, so I think that the users who 
are still using pam_usb-0.3.3 should upgrade to the new version and recreate 
from scratch their settings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431373] New: Review Request: incollector - Information collector

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=431373

   Summary: Review Request: incollector - Information collector
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://kurzawa.nonlogic.org/rpm/incollector/incollector.spec
SRPM URL: 
http://kurzawa.nonlogic.org/rpm/incollector/incollector-1.0-1.fc8.src.rpm
Description: Incollector is an application to collect various kinds of 
information 
(like notes, conversation logs, quotes, serial numbers, source code, 
web addresses, words). All the entries can be tagged, so you can find 
them very easily. There are also search folders which allows you to 
search for entries by specified criteria. You can also export 
(and import, of course) entries to an external file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 430417] Review Request: PersonalCopy-Lite-soundfont - Lite version of the PersonalCopy General Midi soundfont

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: PersonalCopy-Lite-soundfont - Lite version of the 
PersonalCopy General Midi soundfont


https://bugzilla.redhat.com/show_bug.cgi?id=430417


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 14:53 EST ---
Adding Jindrich to the CC because we co-maintain timidity++

(In reply to comment #11)
 Well, okay. I will recheck this later.
 
 A question:
 Do you have any idea to deal with %_sysconfdir/timidity.cfg?
 What I am thinking now is
 - Each rpms providing timidity++ has its own patch config file
   under %_sysconfdir/timidity-patches/, with the name having some
   prefix indicating priority, for example
   %_sysconfdir/timidity-patches/00-soundfont.cfg
 
 - And when a rpm providing timidity patches is installed, it calls
   a script in timidity++-base (for example) to update
   %_sysconfdir/timidity.cfg (marked as %verify(not size md5 mtime) )
 
 - Sysadmin can edit timidity.cfg by adding his/her own configuration
   file under %_sysconfdir/timidity-patches/ and calling registration
   script.
 

I like the idea of having a directory with per soundfont timidity.cfg for the
patch config files. But I'm not sure this is the best way forward ...

First of all its important to understand that there are 2 users of
/etc/timidity.cfg :
1) timidity(++) itself a full midi synth meant for musicians mostly 
2) timidity deratives, consisting of atleast: SDL_mixer, allegro, libtimidity,
   wildmidi. Which are all midi playing libs mean't for embedding in another
   application and typically have less sound quality and matching much less CPU
   usage.

One of the problems is the timidity deratives only support a subset of
/etc/timidity.cfg syntax. Most noteworthy timidity++ supports a new soundfont
statement, which allows it to directly use .sf2 soundfonts / patches, which
means the whole conversion to GUS patch format can be skipped, and importantly,
since .sf2 is a much newer format it also includes some additional details
making timidity++ sound significantly better when directly using the .sf2 file.

Also the priority ranking you propose is impossible IMHO. With soundfont's there
always is a tradeoff between size and quality. Which not only involves diskspace
usage, but also involves memory usage when playing back a midi file.

Clearly the best tradeoff between memory usage and quality lies differently
between the standalone timidity++ and the versions meant for embedding in other
programs and the tradeoff also is dependent on the hardware capabilities of the
used system.

Well that about concludes describing the problem.

---

Now to a solution. The solution I would like to propose is to make the 2
different usage groups mentioned above (stand alone player versus embedded  into
other applications) use 2 different config files.

I propose to use /etc/timidity.cfg for the embedded case, as that is what all 4
embedded variants currently default too. Also by having an /etc/timidity.cfg
which does not use any of the later timidity.cfg extensions added by timidity++
there will always be an /etc/timidity.cfg present which is compatible with
whatever is looking for it, even manually installed applications.

timidity++ will then be patches to first search for /etc/timidity++.cfg and only
if that is not present fallback to /etc/timidity.cfg. So that a different cfg
file can be made and used for the standalone player case.

The idea is to have /etc/timidity++.cfg only contain a single soundfont 
.sf2 line, as the standalone player performs best with a .sf2 file.

The default versions of both .cfg files will get some comment lines at the top
explaining the difference, for /etc/timidity.cfg this will be:
# Warning do not modify this file if you want to change the setting for
# timidity++, the standalone midi player. This file contains a timidity
# compatible patch configuration for applications / libraries which want GUS /
# timidty format patches, like for example SDL_mixer, allegro and libtimidity.
#
# If you want to change the configuration for timidity++, edit 
/etc/timidity++.cfg
# instead. Only change this file if you want to change the configuration for
# other GUS / timidity format patch using applications

---

With this mechanism (2 config files) in place I don't think there is a need to
have a dir with patch config files. For /etc/timidity.cfg one best breed
compromise between size and quality can be choosen (keeping in mind the embedded
nature of its users). Given that I've currently only found 2 soundfonts which
can be freely redistributed, this and plain PersonalCopy, the choose is easy.
This one, as plain PersonalCopy 

[Bug 231809] Review Request: xmlrpc-epi - An implementation of the xmlrpc protocol in C

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xmlrpc-epi - An implementation of the xmlrpc protocol 
in C
Alias: xmlrpc-epi

https://bugzilla.redhat.com/show_bug.cgi?id=231809





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 15:02 EST ---
(In reply to comment #13)
 i tried looking up the license and it only shows up on one page in google at

http://www.thepromisedlan.org/flatnuke/sections/Download/Freedom/LICENSE-libraries-linux.txt
 under xmlrpc-epi license. i'm not sure if this is can be packaged in fedora
 based on the license, and if it can, what do we call it?
 

The license listed here:
http://xmlrpc-epi.sourceforge.net/main.php?t=license

Is perfectly fine, what makes you unsure about this? Its just a variant of the
MIT license, and as such we will call it MIT, more specific see:
http://fedoraproject.org/wiki/Licensing/MIT

And then do a word for word comparision between the xmlrpc-epi and the Modern
Style with sublicense MIT variant. Notice how they are almost 100% the same?


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431356] Review Request: dvipng - Converts DVI files to PNG/GIF format

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dvipng - Converts DVI files to PNG/GIF format


https://bugzilla.redhat.com/show_bug.cgi?id=431356





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 15:02 EST ---
The release should be at least 16+1 since 16 is the current dvipng 
from texlive release.

there is no dvigif info manual.

I don't think the Provides for dvigif is useful.

The kpathsea requires is also certainly unneeded since it should 
be automatically detected.

I suggest using 
make install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p'
to keep the man page timestamp.

To keep the changelogs timestamp, you can use
iconv -f ISO-8859-1 -t UTF8 $i  $i.utf8  touch -r $i $i.utf8  mv 
$i.utf8 $i

I suggest removing the .gz from the file names in the install-info
scriptlets, install-info does it automatically.

I also suggest using globs for man pages and info files, like
%{_infodir}/dvipng.info*
%{_mandir}/man1/dvigif.1*
%{_mandir}/man1/dvipng.1*

The license of the doc seems to be the OFSFDL.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426149] Review Request: sshmenu - Application to organize SSH connection information in a menu

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sshmenu - Application to organize SSH connection 
information in a menu


https://bugzilla.redhat.com/show_bug.cgi?id=426149


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 15:16 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431044] Review Request: perl-ccom - Perl module for context-sensitive phonetic string replacement

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-ccom - Perl module for context-sensitive phonetic 
string replacement


https://bugzilla.redhat.com/show_bug.cgi?id=431044


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 15:21 EST ---
cvs done.

I might have asked before, but will again: Any reason for the cvsextras commits
no? This does mean that other maintainers can't help with this package if you
are away or unavailable. 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 399301] Review Request: glusterfs - Cluster File System

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: glusterfs - Cluster File System


https://bugzilla.redhat.com/show_bug.cgi?id=399301


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 15:20 EST ---
I've rebuilt glusterfs on all requested branches. The tricky ones were :
 * Both EL, for which I added the --without client rebuild option.
 * EL-4 in which python is too old, so I added the --without python option.

Maybe I'll poke upstream about the fact that it would have been much easier for
me if the features just got disabled if the requirements aren't met, as it's
currently required to explicitly pass configure options to disable the features
when such is the case.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431044] Review Request: perl-ccom - Perl module for context-sensitive phonetic string replacement

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-ccom - Perl module for context-sensitive phonetic 
string replacement


https://bugzilla.redhat.com/show_bug.cgi?id=431044





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 15:28 EST ---
I know, what this means. This package has nearly no upstream activity and I 
made the worse experience, that packagers are more likely to break somebody's 
package rather helping - sorry (add feature A, but A is know to break B or 
similar cases).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 231809] Review Request: xmlrpc-epi - An implementation of the xmlrpc protocol in C

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xmlrpc-epi - An implementation of the xmlrpc protocol 
in C
Alias: xmlrpc-epi

https://bugzilla.redhat.com/show_bug.cgi?id=231809





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 15:30 EST ---
two other thoughts -- 
1. should all of the subpackages have the same documentation files, or are we
   going to consider that redundant? rpmlint complains about there being no
   documentation in the subpackages.
2. *-examples installs the examples in %{_bindir}, and the examples have
   relatively generic names. this seems like it could potentially cause 
conflicts
   with other packages. shouldn't they be store within %doc, inside an EXAMPLES
   directory or the like?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 409511] Review Request: libmlx4 - Mellanox ConnectX InfiniBand HCA Userspace Driver

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libmlx4 - Mellanox ConnectX InfiniBand HCA Userspace 
Driver


https://bugzilla.redhat.com/show_bug.cgi?id=409511


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 15:48 EST ---
Successfully built.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 429416] Review Request: event-compat-sysv - sysVinit compatibility for upstart

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: event-compat-sysv - sysVinit compatibility for upstart


https://bugzilla.redhat.com/show_bug.cgi?id=429416





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 16:36 EST ---
Scott says the example scripts are under GPLv2 just like upstart itself.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431356] Review Request: dvipng - Converts DVI files to PNG/GIF format

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dvipng - Converts DVI files to PNG/GIF format


https://bugzilla.redhat.com/show_bug.cgi?id=431356





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 16:54 EST ---
Spec URL: http://jgu.fedorapeople.org/dvipng.spec
SRPM URL: http://jgu.fedorapeople.org/dvipng-1.9-50.fc9.src.rpm

* Sun Feb  3 2007 Jonathan G. Underwood [EMAIL PROTECTED] - 1.9-50
- Remove kpathsea Requires
- Add OFSFDL license tag
- Make INSTALL use install -p
- Preserve time stamp of ChangeLog and ChangeLog.0 files
- Use globbing in filelist
- Remove .gz from the end of filenames in install-info commands
- Bump release to 50 to fix up upgrade path from current dvipng package from 
texlive


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431250] Review Request: librep - An embeddable LISP environment

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: librep -  An embeddable LISP environment


https://bugzilla.redhat.com/show_bug.cgi?id=431250





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 17:08 EST ---
Thanks for corrections in comment #3.  I just looked at some
historical packages and not on wiki. :-)

BTW, after

find . -name .svn | xargs rm -rf
find . -name .cvsignore | xargs rm
rm -rf autom4te.cache

in librep-0.17 directory a size of the original source archive drops
down by roughly 2/3rd without, of course, affecting a compilation in
any way and size differences in a resulting src.rpm are of a similar
order.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431044] Review Request: perl-ccom - Perl module for context-sensitive phonetic string replacement

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-ccom - Perl module for context-sensitive phonetic 
string replacement


https://bugzilla.redhat.com/show_bug.cgi?id=431044


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 17:19 EST ---
38201 (perl-ccom): Build on target fedora-4-epel succeeded.
38199 (perl-ccom): Build on target fedora-5-epel succeeded.

Package: perl-ccom-1.4.1-1.fc7 Tag: dist-fc7-updates-candidate Status: complete
Package: perl-ccom-1.4.1-1.fc8 Tag: dist-f8-updates-candidate Status: complete
Package: perl-ccom-1.4.1-1.fc9 Tag: dist-f9 Status: complete

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431044] Review Request: perl-ccom - Perl module for context-sensitive phonetic string replacement

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-ccom - Perl module for context-sensitive phonetic 
string replacement


https://bugzilla.redhat.com/show_bug.cgi?id=431044





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 17:27 EST ---
perl-ccom-1.4.1-1.fc8 has been submitted as an update for Fedora 8

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431251] Review Request: rep-gtk - GTK+ binding for librep Lisp environment

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rep-gtk - GTK+ binding for librep Lisp environment


https://bugzilla.redhat.com/show_bug.cgi?id=431251





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 17:28 EST ---
Similar size considerations apply in this case as in
https://bugzilla.redhat.com/show_bug.cgi?id=431250#c5
Additionally there is also ChangeLog~ which happens to be
identical to ChangeLog.

After unpacking src.rpm package 'file rep-gtk-0.18.svn20060131.tar.gz'
prints:  bzip2 compressed data, block size = 900k.  Ahem ...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431044] Review Request: perl-ccom - Perl module for context-sensitive phonetic string replacement

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-ccom - Perl module for context-sensitive phonetic 
string replacement


https://bugzilla.redhat.com/show_bug.cgi?id=431044





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 17:29 EST ---
perl-ccom-1.4.1-1.fc7 has been submitted as an update for Fedora 7

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has 
been idle


https://bugzilla.redhat.com/show_bug.cgi?id=430441


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 17:51 EST ---
* rpmlint is silent
* free software
* follow guidelines
* match upstream:
9526347a202694ad235d731d9d3de91f  xautolock-2.2.tgz
* %files section right

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has 
been idle


https://bugzilla.redhat.com/show_bug.cgi?id=430441


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 18:03 EST ---
New Package CVS Request
===
Package Name: xautolock
Short Description: Launches a program when your X session has been idle
Owners: ianweller
Branches: F-7 F-8
InitialCC: ianweller
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431356] Review Request: dvipng - Converts DVI files to PNG/GIF format

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dvipng - Converts DVI files to PNG/GIF format


https://bugzilla.redhat.com/show_bug.cgi?id=431356


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 18:08 EST ---
* rpmlint is silent
* follow packaging guidelines
* free software
* works as intended
* match upstream:
9107065e4da9a18dfff2c1a76fbbf919  dvipng-1.9.tar.gz
* %files section right

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431381] New: Review Request: unicap - Library to access different kinds of (video) capture devices

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=431381

   Summary: Review Request: unicap - Library to access different
kinds of (video) capture devices
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: low
  Priority: low
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://labs.linuxnetz.de/bugzilla/unicap.spec
SRPM URL: http://labs.linuxnetz.de/bugzilla/unicap-0.2.19-1.src.rpm
Unicap provides a uniform interface to video capture devices. It allows
applications to use any supported video capture device via a single API.
The included ucil library provides easy to use functions to render text
and graphic overlays onto video images.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431356] Review Request: dvipng - Converts DVI files to PNG/GIF format

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dvipng - Converts DVI files to PNG/GIF format


https://bugzilla.redhat.com/show_bug.cgi?id=431356





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 18:17 EST ---
Splendid, cheers Patrice. Can I put you as a co-maintainer?

Jindrich - same question to you - are you willing to be a co-maintainer?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431356] Review Request: dvipng - Converts DVI files to PNG/GIF format

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dvipng - Converts DVI files to PNG/GIF format


https://bugzilla.redhat.com/show_bug.cgi?id=431356





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 18:30 EST ---
Yes, you can.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431320] Review Request: pam_usb - Hardware authentication using ordinary USB Flash Drives

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pam_usb - Hardware authentication using ordinary USB 
Flash Drives


https://bugzilla.redhat.com/show_bug.cgi?id=431320





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 19:00 EST ---
Please do not do that.  You can introduce such incompatibilities in a major
Fedora release, but it is not at all proper to just break the system of someone
who does the prudent thing and lets their system update automatically.  This
goes doubly for a system that they might need to use to actually log into the
system.

Honestly I wouldn't even try to introduce this package into Fedora 8, because a
user who hasd pam_usb installed and upgraded from F7 to F8 still has 0.3.3
installed.  I would put the new package into rawhide and make sure that the
release notes indicate the procedure which pam_usb users will need to go through
to update things properly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 427481] Review Request: documentation-devil - Documentation tool chain

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: documentation-devil - Documentation tool chain


https://bugzilla.redhat.com/show_bug.cgi?id=427481





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 19:05 EST ---
Sounds fine to me.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431249] Review Request: sawfish - An extensible window manager for the X Window System.

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sawfish - An extensible window manager for the X 
Window System.


https://bugzilla.redhat.com/show_bug.cgi?id=431249


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 20:14 EST ---
Once again 'autom4te.cache' is at least superfluous in a source
archive.  I am not sure if wrong definitions can be picked up from
there but there is at least a potential.

On http://sawfish.wikia.com/wiki/Patches there are some
patches which apply to 1.3.2.  It appears that at least
Titlebar_updates
Utf_8_names_fix
Pango_draw()_ignores_font
would be a good idea to add to the current sources if not
other as well.

Whomever will eventually own that should subscribe to
a mailing list at http://mail.gnome.org/mailman/listinfo/sawfish-list



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431356] Review Request: dvipng - Converts DVI files to PNG/GIF format

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dvipng - Converts DVI files to PNG/GIF format


https://bugzilla.redhat.com/show_bug.cgi?id=431356





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 20:43 EST ---
Jindrich - have added you as a co-maintainer, but if you'd rather not be, it's
trivial to change it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431386] New: Review Request: rkhunter - A host-based tool to scan for rootkits, backdoors and local exploits

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=431386

   Summary: Review Request: rkhunter - A host-based tool to scan for
rootkits, backdoors and local exploits
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://www.scrye.com/~kevin/fedora/rkhunter/rkhunter.spec
SRPM URL: 
http://www.scrye.com/~kevin/fedora/rkhunter/rkhunter-1.3.0-1.fc9.src.rpm
Description: 

Rootkit Hunter (RKH) is an easy-to-use tool which checks
computers running UNIX (clones) for the presence of rootkits
and other unwanted tools.

This is a re-review of this package, as it's been orphaned for quite some time, 
and I wish to revive it. I have simplified the old spec a great deal and 
updated it to the latest version. 

This version does not ship the perl scripts for sha1/md5 summing, instead using 
installed executables, or nothing if they are not installed. Happy to take 
input on how better to handle this. 

There is also a (rather large) diff against the last spec in cvs at: 
http://www.scrye.com/~kevin/fedora/rkhunter/old-spec.diff

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431356] Review Request: dvipng - Converts DVI files to PNG/GIF format

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dvipng - Converts DVI files to PNG/GIF format


https://bugzilla.redhat.com/show_bug.cgi?id=431356


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 20:42 EST ---
New Package CVS Request
===
Package Name: dvipng
Short Description: Converts DVI files to PNG/GIF format
Owners: jgu,pertusus,jnovy
Branches: 
InitialCC: 
Cvsextras Commits: Yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 430339] Review Request: libgringotts - The libgringotts provides a backend for managing the data files on the disk

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgringotts - The libgringotts provides a backend for 
managing the data files on the disk


https://bugzilla.redhat.com/show_bug.cgi?id=430339


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review?




--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 21:35 EST ---
Builds OK; rpmlint says:
  libgringotts.x86_64: E: summary-too-long The libgringotts provides a backend
for managing encrypted data files on the disk
which indeed is too long.  How about changing The libgringotts provides a to
just A.  There's no reason to mention the name of the package in the summary,
and this change would shorten it and make the English sound a bit better.  You
might as well change the disk to disk since that's how we tend to say it.

In addition, as Bill mentioned in comment 3, you might as well use the nice
description provided in the README file:


libGringotts is a small, easy-to-use, thread-safe C library originally
developed for Gringotts; its purpose is to encapsulate data (generic: ASCII,
but also binary data) in an encrypted and compressed structure, to be written
in a file or used elseway. It makes use of strong encryption algorithms, to
ensure the data are as safe as possible, and allow the user to have the complete
control over all the algorithms used in the process.


which is much more useful than what you have currently in %description.

I note version 1.2.9 was released around the time you submitted this; any reason
for not submitting that version?

The -devel package installs a .pc file but does not depend on pkgconfig.

* source files match upstream:
   a75e6f757b975d3da662fe7ea2d985f358f31ad2dede1a222bb4aa403d0dbfd1  
   libgringotts-1.2.1.tar.bz2
* package meets naming and versioning guidelines.
 specfile is properly named, is cleanly written and uses macros consistently.
X summary needs a tweak
X you should probably the nuice description upstream provides.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
X latest version is not being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* debuginfo package looks complete.
X rpmlint has a valid complaint.
X final provides and requires:
  libgringotts-1.2.1-2.fc9.x86_64.rpm
   libgringotts.so.2()(64bit)
   libgringotts = 1.2.1-2.fc9
  =
   /sbin/ldconfig
   libbz2.so.1()(64bit)
   libgringotts.so.2()(64bit)
   libmcrypt.so.4()(64bit)
   libmhash.so.2()(64bit)
   libz.so.1()(64bit)

  libgringotts-devel-1.2.1-2.fc9.x86_64.rpm
   libgringotts-devel = 1.2.1-2.fc9
  =
   libgringotts = 1.2.1-2.fc9
   libgringotts.so.2()(64bit)
   (no dependency on pkgconfig)

* %check is not present; no test suite upstream.
* shared libraries installed; ldconfig called properly.
* unversioned .so files are in the -devel package.
X directory ownership issue in -devel package due to the lack of a pkgconfig 
   dependency.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (ldconfig)
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* headers are in the -devel package.
X pkgconfig files present and in the -devel package, but no pkgconfig 
   dependnecy.
* no static libraries.
* no libtool .la files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431373] Review Request: incollector - Information collector

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: incollector - Information collector


https://bugzilla.redhat.com/show_bug.cgi?id=431373


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431373] Review Request: incollector - Information collector

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: incollector - Information collector


https://bugzilla.redhat.com/show_bug.cgi?id=431373





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 22:45 EST ---
build.log gave me
+ /usr/lib/rpm/find-lang.sh /var/tmp/incollector-1.0-1.fc9-root-mockbuild
incollector
No translations found for incollector in
/var/tmp/incollector-1.0-1.fc9-root-mockbuild
=== missing BR: gettext desktop-file-utils

any reason to exclude 
%exclude %{_datadir}/locale/be-latin/LC_MESSAGES/incollector.mo



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431047] Review Request: latencytop - System latency monitor

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: latencytop - System latency monitor


https://bugzilla.redhat.com/show_bug.cgi?id=431047


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 23:41 EST ---
Review:
+ package builds in mock (rawhide).
+ rpmlint on for SRPM and RPM.
latencytop.i386: W: no-documentation
+ source files match upstream.
3ed2878fb7772e2a500ec71aa01abbb2  latencytop-0.3.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in source code.
- %doc files NOT present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Compiler flags used correctly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

SHHOULD:
  1)Better recreate latencytop-standard-cflags.patch that will remove
unnecessary space caught in last few lines of patch.
  2)Try to ask upstream to include some README where it should be written what
this tool does and what are its limitations like this works on kernel = 2.6.24
  3) Hope to see upstream will include license file in next upstream release.

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431381] Review Request: unicap - Library to access different kinds of (video) capture devices

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: unicap - Library to access different kinds of (video) 
capture devices


https://bugzilla.redhat.com/show_bug.cgi?id=431381





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 23:21 EST ---
oops clicked submit button
3) can you also include APIs and examples to -devel package?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431381] Review Request: unicap - Library to access different kinds of (video) capture devices

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: unicap - Library to access different kinds of (video) 
capture devices


https://bugzilla.redhat.com/show_bug.cgi?id=431381


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review?




--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 23:13 EST ---
mock build is ok. 
1) missing Requires: pkgconfig in -devel, drop pkgconfig as BR from main 
package.

2) rpmlint gave me
unicap-devel.i386: W: dangling-relative-symlink
/usr/lib/unicap2/cpi/libvid21394.so libvid21394.so.0.0.0
The relative symbolic link points nowhere.

unicap-devel.i386: W: dangling-relative-symlink /usr/lib/unicap2/cpi/libdcam.so
libdcam.so.0.0.0
The relative symbolic link points nowhere.

unicap-devel.i386: W: dangling-relative-symlink /usr/lib/unicap2/cpi/libv4l2.so
libv4l2.so.0.0.0
The relative symbolic link points nowhere.

unicap-devel.i386: W: dangling-relative-symlink /usr/lib/unicap2/cpi/libv4l.so
libv4l.so.0.0.0
The relative symbolic link points nowhere.

unicap-devel.i386: E: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.

3)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431373] Review Request: incollector - Information collector

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: incollector - Information collector


https://bugzilla.redhat.com/show_bug.cgi?id=431373





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 22:58 EST ---
Source URL should be
http://www.incollector.devnull.pl/download/sources/%{name}-%{version}.tar.gz

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431047] Review Request: latencytop - System latency monitor

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: latencytop - System latency monitor


https://bugzilla.redhat.com/show_bug.cgi?id=431047





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 23:29 EST ---
(In reply to comment #5)
 I updated the package:
 http://michich.fedorapeople.org/latencytop/latencytop.spec
 http://michich.fedorapeople.org/latencytop/latencytop-0.3-2.fc9.src.rpm
 
 ad 1) latencytop-standard-cflags.patch now removes the extra whitespace.
  Can't see this fixed in new SRPM.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431047] Review Request: latencytop - System latency monitor

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: latencytop - System latency monitor


https://bugzilla.redhat.com/show_bug.cgi?id=431047





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 23:44 EST ---
Can you tell me how can I test this on rawhide?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428925] Review Request: bongo - An easy-to-use mail and calendar system

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bongo - An easy-to-use mail and calendar system


https://bugzilla.redhat.com/show_bug.cgi?id=428925





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 00:11 EST ---
Peter did you forget about this.. also do you have a review you want to swap for
this one?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431175] Review Request: xhotkeys - Hotkeys for the X-Window

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xhotkeys - Hotkeys for the X-Window


https://bugzilla.redhat.com/show_bug.cgi?id=431175





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 00:06 EST ---
When installed its not working because first time we try to use it try to find
.xhotkeys under your $HOME. I think you better remove SOURCE1 and provide
upstream desktop only.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431175] Review Request: xhotkeys - Hotkeys for the X-Window

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xhotkeys - Hotkeys for the X-Window


https://bugzilla.redhat.com/show_bug.cgi?id=431175





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 00:14 EST ---
I think modifying SOURCE1 desktop file to include --config is enough

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 430339] Review Request: libgringotts - The libgringotts provides a backend for managing the data files on the disk

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgringotts - The libgringotts provides a backend for 
managing the data files on the disk


https://bugzilla.redhat.com/show_bug.cgi?id=430339





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 01:17 EST ---
X summary needs a tweak
Fixed

X you should probably the nuice description upstream provides.
Fixed

X directory ownership issue in -devel package due to the lack of a pkgconfig 
   dependency.
fixed

X pkgconfig files present and in the -devel package, but no pkgconfig 
   dependnecy.
fixed

I'm on the way to the school. I'll give new SPEC and SRPM when I'll be back.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428925] Review Request: bongo - An easy-to-use mail and calendar system

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bongo - An easy-to-use mail and calendar system


https://bugzilla.redhat.com/show_bug.cgi?id=428925


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 01:13 EST ---
Aack, sorry about that. I spent most of the weekend out with friends/family and
forgot about this entirely. Rest assured it will be my first priority after
class  tomorrow.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431371] Review Request: gyachi - A Yahoo! chat client with Webcam and voice support

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gyachi - A Yahoo! chat client with Webcam and voice 
support


https://bugzilla.redhat.com/show_bug.cgi?id=431371


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 00:59 EST ---
I think good to have all plugins requires main package as
Requires: %{name} = %{version}-%{release}  

Good to add following files to %doc
ChangeLog doc/KNOWN_PROBLEMS-gyvoice.txt doc/KNOWN_PROBLEMS.txt doc/txt/COPYING
 doc/html/gyachi-help.html 

Source URL should be =
  http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431368] Review Request: inconsoleata-fonts - A monospace font, designed for code listings and the like, in print

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: inconsoleata-fonts - A monospace font, designed for 
code listings and the like, in print


https://bugzilla.redhat.com/show_bug.cgi?id=431368


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 01:55 EST ---
Review:
+ package builds in mock.
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
378f8830bc66804d5fe2e7338598e654  Inconsolata.sfd
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
  strings  Inconsolata.sfd | grep OFL
Copyright: Created by Raph Levien using his own tools and FontForge. Copyright
2006 Raph Levien. Released under the SIL Open Font License,
http://scripts.sil.org/OFL.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ followed fonts packaging guidelines.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431368] Review Request: inconsoleata-fonts - A monospace font, designed for code listings and the like, in print

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: inconsoleata-fonts - A monospace font, designed for 
code listings and the like, in print


https://bugzilla.redhat.com/show_bug.cgi?id=431368


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
Summary|Review Request: |Review Request:
   |inconsoleata-fonts - A  |inconsoleata-fonts - A
   |monospace font, designed for|monospace font, designed for
   |code listings and the like, |code listings and the like,
   |in print|in print
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431371] Review Request: gyachi - A Yahoo! chat client with Webcam and voice support

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gyachi - A Yahoo! chat client with Webcam and voice 
support


https://bugzilla.redhat.com/show_bug.cgi?id=431371





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 02:34 EST ---
I hope someone else would review this ticket, however:
- does not build
  http://koji.fedoraproject.org/koji/taskinfo?taskID=394014
  http://koji.fedoraproject.org/koji/taskinfo?taskID=394020
  You can check this by koji scratch build.
- Please check directory ownership issue.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 427718] Review Request: Megazeux - Text-character driven game creation system

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Megazeux - Text-character driven game creation system


https://bugzilla.redhat.com/show_bug.cgi?id=427718


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |NEEDINFO
   Flag||needinfo?([EMAIL PROTECTED]
   ||m)




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 02:30 EST ---
ping?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431371] Review Request: gyachi - A Yahoo! chat client with Webcam and voice support

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gyachi - A Yahoo! chat client with Webcam and voice 
support


https://bugzilla.redhat.com/show_bug.cgi?id=431371





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 02:05 EST ---

new revision:

http://sundaram.fedorapeople.org/packages/gyachi.spec
http://sundaram.fedorapeople.org/packages/gyachi-1.1.0-4.fc8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431381] Review Request: unicap - Library to access different kinds of (video) capture devices

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: unicap - Library to access different kinds of (video) 
capture devices


https://bugzilla.redhat.com/show_bug.cgi?id=431381





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 02:39 EST ---
to 2): The relative symlinks are pointing to files of the base package or did
I misread something? And the error seems to result from the warnings. Because 
where to put the *.so files/links when not in /usr/lib?

to 3): APIs? doc/apis seems to be nearly (?) the same like the gtk-doc stuff or 
was my look to that too fast? Adding examples is no problem.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review