[Bug 426149] Review Request: sshmenu - Application to organize SSH connection information in a menu

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sshmenu - Application to organize SSH connection 
information in a menu


https://bugzilla.redhat.com/show_bug.cgi?id=426149


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 03:10 EST ---
Thanks to Marek, Xavier and Mamoru for the review, and Kevin for the CVS 
request!
I've imported and built it on all branches.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431373] Review Request: incollector - Information collector

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: incollector - Information collector


https://bugzilla.redhat.com/show_bug.cgi?id=431373





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 03:09 EST ---
Fixed
Spec URL: http://kurzawa.nonlogic.org/rpm/incollector/incollector.spec
SRPM URL: 
http://kurzawa.nonlogic.org/rpm/incollector/incollector-1.0-2.fc8.src.rpm

I exclude %exclude %{_datadir}/locale/be-latin/LC_MESSAGES/incollector.mo
because rpmlint warns:

incollector.i386: E: incorrect-locale-subdir
/usr/share/locale/be-latin/LC_MESSAGES/incollector.mo

Thanks for review!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431371] Review Request: gyachi - A Yahoo! chat client with Webcam and voice support

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gyachi - A Yahoo! chat client with Webcam and voice 
support


https://bugzilla.redhat.com/show_bug.cgi?id=431371





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 03:49 EST ---
(In reply to comment #4)
 Rahul,
Considering above koji build failed, you can try to add 
 ExcludeArch: ppc ppc64 x86_64

That is never the right answer.  ever.  please fix it on all arches  not
excluding most

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431371] Review Request: gyachi - A Yahoo! chat client with Webcam and voice support

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gyachi - A Yahoo! chat client with Webcam and voice 
support


https://bugzilla.redhat.com/show_bug.cgi?id=431371





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 03:37 EST ---
Rahul,
   Considering above koji build failed, you can try to add 
ExcludeArch: ppc ppc64 x86_64

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431371] Review Request: gyachi - A Yahoo! chat client with Webcam and voice support

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gyachi - A Yahoo! chat client with Webcam and voice 
support


https://bugzilla.redhat.com/show_bug.cgi?id=431371





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 03:55 EST ---
(In reply to comment #5)
 (In reply to comment #4)
  Rahul,
 Considering above koji build failed, you can try to add 
  ExcludeArch: ppc ppc64 x86_64
 
 That is never the right answer.  ever.  please fix it on all arches  not
 excluding most

  Sorry. I saw some packages with ExcludeArch in Fedora, so I thought we can do
same here also. Thanks for your quick reply here.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431381] Review Request: unicap - Library to access different kinds of (video) capture devices

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: unicap - Library to access different kinds of (video) 
capture devices


https://bugzilla.redhat.com/show_bug.cgi?id=431381





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 04:29 EST ---
(In reply to comment #3)
 to 2): The relative symlinks are pointing to files of the base package or did
 I misread something? And the error seems to result from the warnings. Because 
 where to put the *.so files/links when not in /usr/lib?
 
 I installed this and looks ok.

 to 3): APIs? doc/apis seems to be nearly (?) the same like the gtk-doc stuff 
 or 
 was my look to that too fast? Adding examples is no problem.
 yes. APIs are already there. Only examples now you need to add.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431371] Review Request: gyachi - A Yahoo! chat client with Webcam and voice support

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gyachi - A Yahoo! chat client with Webcam and voice 
support


https://bugzilla.redhat.com/show_bug.cgi?id=431371





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 04:01 EST ---
Dennis Gilmore, This package simply doesn't build on these architectures. I have
cc'ed the upstream maintainer who should be aware of this. 

Added ExcludeArch's for now if that helps move the review forward. 

http://sundaram.fedorapeople.org/packages/gyachi.spec
http://sundaram.fedorapeople.org/packages/gyachi-1.1.0-5.fc8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431373] Review Request: incollector - Information collector

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: incollector - Information collector


https://bugzilla.redhat.com/show_bug.cgi?id=431373





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 04:17 EST ---
I think you can try to use sed to replace be-latin.* to [EMAIL PROTECTED] in 
build
directory and also you need to have following %prep

pushd po
mv be-latin.po [EMAIL PROTECTED]
mv be-latin.gmo [EMAIL PROTECTED]
popd


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431373] Review Request: incollector - Information collector

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: incollector - Information collector


https://bugzilla.redhat.com/show_bug.cgi?id=431373





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 04:23 EST ---
you just need to use following in %prep
sed -i 's|be-latin|[EMAIL PROTECTED]|' configure
pushd po
mv be-latin.po [EMAIL PROTECTED]
mv be-latin.gmo [EMAIL PROTECTED]
popd

and this will solve your problem of rpmlint error.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 427162] Review Request: sagator - antivir/antispam gateway for smtp server

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sagator - antivir/antispam gateway for smtp server


https://bugzilla.redhat.com/show_bug.cgi?id=427162


[EMAIL PROTECTED] changed:

   What|Removed |Added

  BugsThisDependsOn||430295




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431371] Review Request: gyachi - A Yahoo! chat client with Webcam and voice support

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gyachi - A Yahoo! chat client with Webcam and voice 
support


https://bugzilla.redhat.com/show_bug.cgi?id=431371





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 04:32 EST ---
Koji scratch build

http://koji.fedoraproject.org/koji/taskinfo?taskID=394110

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431381] Review Request: unicap - Library to access different kinds of (video) capture devices

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: unicap - Library to access different kinds of (video) 
capture devices


https://bugzilla.redhat.com/show_bug.cgi?id=431381





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 04:30 EST ---
and please take care of point 1)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431373] Review Request: incollector - Information collector

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: incollector - Information collector


https://bugzilla.redhat.com/show_bug.cgi?id=431373





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 04:37 EST ---
Fixed
Spec URL: http://kurzawa.nonlogic.org/rpm/incollector/incollector.spec
SRPM URL: 
http://kurzawa.nonlogic.org/rpm/incollector/incollector-1.0-3.fc8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 430295] Review Request: sagator-libclamav - ClamAV module for python, created for SAGATOR project

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sagator-libclamav - ClamAV module for python, created 
for SAGATOR project


https://bugzilla.redhat.com/show_bug.cgi?id=430295


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||427162
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 250970] Review Request: ivtv-firmware - Firmware for the PVR 250/350/150/500 model series

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ivtv-firmware - Firmware for the PVR 250/350/150/500 
model series


https://bugzilla.redhat.com/show_bug.cgi?id=250970





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 05:26 EST ---
Axel, I see no improvement about the compat location field with this version.

I've learn that when ivtv was in work to be merged within the kernel, they was a
problem because it was using it owns firmware loader, instead of the one within
the kernel. Actually the compat needs may not be related to using hotplug or
else, but using the firmware loader of an older ivtv version when it wasn't
merged in yet.

I don't knwow the status of userland app (mythtv), that can use the kernel
version or the external version.

Am I right ? or the compat location is only related to have the same package for
all dist ?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431373] Review Request: incollector - Information collector

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: incollector - Information collector


https://bugzilla.redhat.com/show_bug.cgi?id=431373





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 05:23 EST ---
koji build failed
http://koji.fedoraproject.org/koji/taskinfo?taskID=394153

SHOULD:
   Not use macro for install command %{__install} -p. Just use install -p
   Because you have not used macros for commands rm , make in spec.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 430295] Review Request: sagator-libclamav - ClamAV module for python, created for SAGATOR project

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sagator-libclamav - ClamAV module for python, created 
for SAGATOR project


https://bugzilla.redhat.com/show_bug.cgi?id=430295


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
   Flag||fedora-review?




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 05:04 EST ---
I'll take it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431175] Review Request: xhotkeys - Hotkeys for the X-Window

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xhotkeys - Hotkeys for the X-Window


https://bugzilla.redhat.com/show_bug.cgi?id=431175





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 05:44 EST ---
Sorry, but could you repeat what have I to do?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431373] Review Request: incollector - Information collector

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: incollector - Information collector


https://bugzilla.redhat.com/show_bug.cgi?id=431373





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 05:34 EST ---
This worked for me 
ExclusiveArch: %ix86 x86_64 ppc 


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431373] Review Request: incollector - Information collector

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: incollector - Information collector


https://bugzilla.redhat.com/show_bug.cgi?id=431373





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 05:45 EST ---
Actually it should be
ExclusiveArch: %ix86 x86_64 ppc ia64 armv4l sparc alpha
from gtk-sharp2.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431373] Review Request: incollector - Information collector

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: incollector - Information collector


https://bugzilla.redhat.com/show_bug.cgi?id=431373





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 06:07 EST ---
Whooops I wrote bad link do SRPMS:

SRPM URL: 
http://kurzawa.nonlogic.org/rpm/incollector/incollector-1.0-3.fc8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431414] New: Review Request: planets - A celestial simulator

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=431414

   Summary: Review Request: planets - A celestial simulator
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: low
  Priority: low
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://zanoni.jcomserv.net/fedora/planets/planets.spec
SRPM URL: http://zanoni.jcomserv.net/fedora/planets/planets-0.1.13-1.fc8.src.rpm
Description: Planets is a simple interactive program for playing with 
simulations
of planetary systems

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428925] Review Request: bongo - An easy-to-use mail and calendar system

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bongo - An easy-to-use mail and calendar system


https://bugzilla.redhat.com/show_bug.cgi?id=428925





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 06:10 EST ---
SRPM: http://dnielsen.fedorapeople.org/bongo-0.3.1-1.fc8.src.rpm
SPEC: http://dnielsen.fedorapeople.org/bongo.spec

Bumpity bump bump bump to 0.3.1 as it was just released.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431373] Review Request: incollector - Information collector

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: incollector - Information collector


https://bugzilla.redhat.com/show_bug.cgi?id=431373





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 06:07 EST ---
Here is correct link:

SRPM URL: 
http://kurzawa.nonlogic.org/rpm/incollector/incollector-1.0-4.fc8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226428] Merge Review: speex

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: speex


https://bugzilla.redhat.com/show_bug.cgi?id=226428





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 05:57 EST ---
The splitting packages is ok for me. I don't know in which group should be
speex-tools have been. Do you?

I've also problem with removing %makeinstall macro. Maybe it can't be removed
because of strange autotolls.

And the last problem with moving .so files into -devel made these messages:
rpmlint i686/speex-devel-1.2-0.4.beta3.i686.rpm
speex-devel.i686: W: no-documentation
speex-devel.i686: E: library-without-ldconfig-postin 
/usr/lib/libspeexdsp.so.1.4.0
speex-devel.i686: E: library-without-ldconfig-postun 
/usr/lib/libspeexdsp.so.1.4.0


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431373] Review Request: incollector - Information collector

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: incollector - Information collector


https://bugzilla.redhat.com/show_bug.cgi?id=431373





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 06:06 EST ---
Fixed
Spec URL: http://kurzawa.nonlogic.org/rpm/incollector/incollector.spec
SRPM URL: 
http://kurzawa.nonlogic.org/rpm/incollector/incollector-1.0-3.fc8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431373] Review Request: incollector - Information collector

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: incollector - Information collector


https://bugzilla.redhat.com/show_bug.cgi?id=431373





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 07:19 EST ---
oops you add from gtk-sharp2.spec
remove this text

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431414] Review Request: planets - A celestial simulator

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: planets - A celestial simulator


https://bugzilla.redhat.com/show_bug.cgi?id=431414





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 07:16 EST ---
koji build failed for ppc64 because of
No Package Found for ocaml-camlp4-devel
No Package Found for ocaml-labltk-devel
on ppc64

koji build =http://koji.fedoraproject.org/koji/taskinfo?taskID=394314

You want to follow guidelines given at
http://fedoraproject.org/wiki/Packaging/OCaml#head-d6d0bc21de370e51e9ca9bf5bc543224e2c668d4

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431414] Review Request: planets - A celestial simulator

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: planets - A celestial simulator


https://bugzilla.redhat.com/show_bug.cgi?id=431414





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 07:08 EST ---
Drop unnecessary documentation files = BUGS INSTALL_w32.txt FILES BINFILES
INSTALL INSTALL.txt README.txt 

use rpmmacros in %files for man file
/usr/share/man/man1/planets.1.gz
to
%{_mandir}/man1/planets.1.gz

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431373] Review Request: incollector - Information collector

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: incollector - Information collector


https://bugzilla.redhat.com/show_bug.cgi?id=431373


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 07:51 EST ---
New Package CVS Request
===
Package Name: incollector
Short Description: Information collector
Owners: kurzawa
Branches: F-7 F-8
InitialCC:
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431373] Review Request: incollector - Information collector

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: incollector - Information collector


https://bugzilla.redhat.com/show_bug.cgi?id=431373


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 07:45 EST ---
Review:
+ package builds in mock (rawhide i386).
koji build=http://koji.fedoraproject.org/koji/taskinfo?taskID=394396
+ rpmlint is silent for SRPM
- rpmlint complains for RPM as
incollector.i386: E: no-binary
incollector.i386: E: only-non-binary-in-usr-lib
But these can be ignored for mono packages.
+ source files match upstream.
da510a279ebb5e8ebf9dbdcb2fc1cf18  incollector-1.0.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags are honoured correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Desktop file handled correctly.
+ GUI app.

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431175] Review Request: xhotkeys - Hotkeys for the X-Window

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xhotkeys - Hotkeys for the X-Window


https://bugzilla.redhat.com/show_bug.cgi?id=431175





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 07:47 EST ---
New Package CVS Request
===
Package Name: xhotkeys
Short Description: Hotkeys for the X-Window
Owners: kurzawa
Branches: F-7 F-8
InitialCC:
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431175] Review Request: xhotkeys - Hotkeys for the X-Window

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xhotkeys - Hotkeys for the X-Window


https://bugzilla.redhat.com/show_bug.cgi?id=431175


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431175] Review Request: xhotkeys - Hotkeys for the X-Window

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xhotkeys - Hotkeys for the X-Window


https://bugzilla.redhat.com/show_bug.cgi?id=431175


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 07:40 EST ---
Review:
+ package builds in mock (rawhide i386).
koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=394380
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
6544b487e23ab1290078cff0f2e96a6f  xhotkeys_0.9.8.3.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags are honoured correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ gtk-update-icon-cache scriptlets are used.
+ Desktop file installed correctly
+ GUI app.

APPROVED.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431320] Review Request: pam_usb - Hardware authentication using ordinary USB Flash Drives

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pam_usb - Hardware authentication using ordinary USB 
Flash Drives


https://bugzilla.redhat.com/show_bug.cgi?id=431320





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 09:34 EST ---
I've investigated deeply and I've found an interesting thing: pam_usb-0.3.3 and
pam_usb-0.4.2 store their settings in different places, so upgrading from 0.3.3
to 0.4.2 will not remove the old settings.

I've installed and configured pam_usb-0.3.3 in Fedora7 and then I upgraded it to
pam_usb-0.4.2; then I downgraded to pam_usb-0.3.3 again and the old settings was
still there and it works normally like before.

So I think we could insert the new pam_usb-0.4.2 in RawHide and then in Fedora9,
and inform the users that after the upgrade their old settings will be ignored
but won't be erased.
So the users can choose between upgrade to the new pam_usb-0.4.2 and create the
new settings from scratch or not to upgrade and still use pam_usb-0.3.3.
If they install pam_usb-0.4.2 by mistake they can downgrade to pam_usb-0.3.3 and
it will works again.

In my opinion that upgrade to pam_usb-0.4.2 in Fedora9 is the right thing,
because it's more secure and reliable, a lot of bugs was fixed, new
functionality was added, and it's more easy to configure with the new tool
pamusb-conf.
pam_usb-0.3.3 instead is more difficult to configure and is less reliable
because it's sufficient to copy the private key in the usb device to grant the
access to the account of the user.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 430360] Review Request: ggz-gtk-client - Gtk+ client libraries for GGZ gaming zone

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ggz-gtk-client - Gtk+ client libraries for GGZ gaming 
zone


https://bugzilla.redhat.com/show_bug.cgi?id=430360


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 09:36 EST ---
New Package CVS Request
===
Package Name: ggz-gtk-client
Short Description: Gtk+ client libraries for GGZ gaming zone
Owners: bpepple
Branches: 
Cvsextras Commits: Yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226428] Merge Review: speex

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: speex


https://bugzilla.redhat.com/show_bug.cgi?id=226428





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 11:21 EST ---
I updated the files on the:
http://mmaslano.fedorapeople.org/speex/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428973] Review Request: vodovod - a pipe connecting game

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vodovod - a pipe connecting game


https://bugzilla.redhat.com/show_bug.cgi?id=428973





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 08:28 EST ---
(In reply to comment #2)
 [XX] spec file name matches base package %{name}, in the format %{name}.spec
  - vodovod.spec.0.10 was odd, not sure if that was just for your hosting or
what

this is only a primitive VCS to be sure that the linked file does not change 
and so two people are not referring different state of things - as you noted 
in comment #3, I do not use the suffix for packaging


(In reply to comment #6)
 line 4, summary: probably shouldn't contain
 the package name.

ops, I've copied this and forgot about the rule

 also, should the comment in the .desktop file have a period at the end?

probably not, removing

(In reply to comment #7)
 * This package does not build on dist-f9.
 http://koji.fedoraproject.org/koji/taskinfo?taskID=392156
   A proposed patch is attached.

thanks, included

 * On build fedora specific compilation flags are not correctly
   honored (Compiler flags of
   http://fedoraproject.org/wiki/Packaging/Guidelines )
   Using
 
 make %{?_smp_mflags} \
 CC=%{__cxx} %{optflags}
 
   is good for this package.

well, the guidelines could be more verbose about this ... thanks, added

 - Desktop icon must be updated (GTK+ icon cache of
   http://fedoraproject.org/wiki/Packaging/ScriptletSnippets )

thanks, included - once more, it could be mentioned within the guidelines (I'm 
KDE user, so ...)

new version:
http://www.hajnet.cz/soubory/vodovod/vodovod.spec.1.10-2
http://www.hajnet.cz/soubory/vodovod/vodovod-1.10-2.fc8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 429416] Review Request: event-compat-sysv - sysVinit compatibility for upstart

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: event-compat-sysv - sysVinit compatibility for upstart


https://bugzilla.redhat.com/show_bug.cgi?id=429416





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 12:56 EST ---
I can drop a copy of upstart's COPYING in the package for now, or do we have to
wait for upstream to add one?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426492] Review Request: jabbin - Instant messaging and VoIP Jabber client

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jabbin - Instant messaging and VoIP Jabber client


https://bugzilla.redhat.com/show_bug.cgi?id=426492





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 12:01 EST ---
dist-f8-updates-candidate build with the patch in comment 16
applied is here:
http://koji.fedoraproject.org/koji/taskinfo?taskID=394937

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 192867] Review Request: ctorrent - BitTorrent Client written in C

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ctorrent - BitTorrent Client written in C


https://bugzilla.redhat.com/show_bug.cgi?id=192867


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 14:20 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 418681] Review Request: rubygem-gem2rpm - Generate rpm specfiles from gems

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rubygem-gem2rpm - Generate rpm specfiles from gems


https://bugzilla.redhat.com/show_bug.cgi?id=418681


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431277] Review Request: ocfs2-tools - programs for managing Ocfs2 file systems

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocfs2-tools - programs for managing Ocfs2 file systems


https://bugzilla.redhat.com/show_bug.cgi?id=431277





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 14:21 EST ---
branching to EPEL is only useful if there is a RHEL5 ocfs2 module out there
somewhere... are there plans for that?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 418681] Review Request: rubygem-gem2rpm - Generate rpm specfiles from gems

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rubygem-gem2rpm - Generate rpm specfiles from gems


https://bugzilla.redhat.com/show_bug.cgi?id=418681


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
   Flag|fedora-review?  |




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 14:16 EST ---
Sorry for slowing this down, I do not have the time currently.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225240] Merge Review: alchemist

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: alchemist


https://bugzilla.redhat.com/show_bug.cgi?id=225240


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium
   Priority|normal  |medium
Product|Fedora Extras   |Fedora
Version|devel   |rawhide

[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review?




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 14:11 EST ---
rpmlint on SRPM:

alchemist.src: E: non-utf8-spec-file
/tmp/alchemist-1.0.37-2.fc8.src.rpm.5684/alchemist.spec
The character encoding of the spec file is not UTF-8.  Convert it for
example using iconv(1).

alchemist.src:10: W: prereq-use /sbin/ldconfig
The use of PreReq is deprecated. In the majority of cases, a plain Requires
is enough and the right thing to do. Sometimes Requires(pre), Requires(post),
Requires(preun) and/or Requires(postun) can also be used instead of PreReq.

alchemist.src:13: W: buildprereq-use libxml2 = 2.3.8, libxslt = 0.9.0,
libxslt-devel = 0.9.0
The use of BuildPreReq is deprecated, build dependencies are always required
before a package can be built.  Use plain BuildRequires instead.

alchemist.src:14: W: buildprereq-use doxygen = 1.2.7, python-devel, zlib-devel
The use of BuildPreReq is deprecated, build dependencies are always required
before a package can be built.  Use plain BuildRequires instead.

alchemist.src: W: summary-ended-with-dot A multi-sourced configuration back-end.
Summary ends with a dot.

alchemist.src: E: tag-not-utf8 %changelog
The character encoding of the value of this tag is not UTF-8.

alchemist.src: W: no-url-tag
The URL tag is missing.

All need fixing.

rpmlint on RPMS:

alchemist-devel.i386: W: dangling-relative-symlink
/usr/lib/alchemist/blackbox/libforgeblackbox.so libforgeblackbox.so.0.0.0
The relative symbolic link points nowhere.

Should be OK.


In addition, the Source0 tag should include a URL, which should match what I'd
find on the site in the URL.

Static libs need to be in a -static package or dropped entirely.  .la should be
removed unless critically needed.

Otherwise, looks good, no other blockers.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 429416] Review Request: event-compat-sysv - sysVinit compatibility for upstart

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: event-compat-sysv - sysVinit compatibility for upstart


https://bugzilla.redhat.com/show_bug.cgi?id=429416





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 12:29 EST ---
OK, then it would be nice to have a COPYING file in the tarball, at least.
 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 427530] Review Request: awesome - Extremely fast, small, dynamic and awesome tiling window manager

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: awesome - Extremely fast, small, dynamic and awesome 
tiling window manager


https://bugzilla.redhat.com/show_bug.cgi?id=427530


Bug 427530 depends on bug 427529, which changed state.

Bug 427529 Summary: Please update to upstream version 2.6
https://bugzilla.redhat.com/show_bug.cgi?id=427529

   What|Old Value   |New Value

 Status|NEW |CLOSED
 Resolution||RAWHIDE



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has 
been idle


https://bugzilla.redhat.com/show_bug.cgi?id=430441


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 14:32 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431368] Review Request: inconsoleata-fonts - A monospace font, designed for code listings and the like, in print

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: inconsoleata-fonts - A monospace font, designed for 
code listings and the like, in print


https://bugzilla.redhat.com/show_bug.cgi?id=431368


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 14:31 EST ---
Thanks for the speedy review!

New Package CVS Request
===
Package Name: inconsolata-fonts
Short Description: A monospace font, designed for code listings and the like, in
print
Owners: kevin
Branches: F-8
InitialCC: 
Cvsextras Commits: yes




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226428] Merge Review: speex

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: speex


https://bugzilla.redhat.com/show_bug.cgi?id=226428





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 10:31 EST ---
 * The group could be Applications/Multimedia.
 * The tools' man pages should also be moved to the tools sub-directory.
 * Instead of removing and excluding the *.a files, use --disable-static
 * You can remove the *.la in %install or %exclude them in the devel package
 * You need to have :
   * %{_libdir}/libspeex*.so.* in the main package
   * %{_libdir}/libspeex*.so in the devel package

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 192867] Review Request: ctorrent - BitTorrent Client written in C

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ctorrent - BitTorrent Client written in C


https://bugzilla.redhat.com/show_bug.cgi?id=192867


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium
   Priority|normal  |medium
Product|Fedora Extras   |Fedora
Version|devel   |rawhide

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 09:59 EST ---
Package Change Request
==
Package Name: ctorrent
New Branches: EL-5


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431175] Review Request: xhotkeys - Hotkeys for the X-Window

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xhotkeys - Hotkeys for the X-Window


https://bugzilla.redhat.com/show_bug.cgi?id=431175





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 07:10 EST ---
Fixed
Spec URL: http://kurzawa.nonlogic.org/rpm/xhotkeys/xhotkeys.spec
SRPM URL: 
http://kurzawa.nonlogic.org/rpm/xhotkeys/xhotkeys-0.9.8.3-5.fc8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226428] Merge Review: speex

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: speex


https://bugzilla.redhat.com/show_bug.cgi?id=226428





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 06:52 EST ---
in the meantime are the packages here:
http://mmaslano.fedorapeople.org/speex/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431373] Review Request: incollector - Information collector

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: incollector - Information collector


https://bugzilla.redhat.com/show_bug.cgi?id=431373


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 14:43 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426492] Review Request: jabbin - Instant messaging and VoIP Jabber client

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jabbin - Instant messaging and VoIP Jabber client


https://bugzilla.redhat.com/show_bug.cgi?id=426492





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 11:59 EST ---
Created an attachment (id=293909)
 -- (https://bugzilla.redhat.com/attachment.cgi?id=293909action=view)
Patch to use external qca (qca-devel needed)

Well, the attached patch should work to use external
qca (qca-devel needed). However
- Currently Fedora specific compilation flags are not
  honored
- This package fails to build on dist-f9 (rawhide). Rawhide
  now uses g++43 and jabbin compilation fails with g++43
  on many points... 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 411881] Package review: sim

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Package review: sim


https://bugzilla.redhat.com/show_bug.cgi?id=411881





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 11:58 EST ---
Do you know how fix this? I'm looking on this issue ages :(

make[1]: Leaving directory `/usr/src/redhat/BUILD/sim-0.9.4.3'
+ desktop-file-install --vendor fedora --dir
/var/tmp/sim-0.9.4.3-1.fc8-root-root/usr/share/applications/kde/sim.desktop
Must specify one or more desktop files to install



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431175] Review Request: xhotkeys - Hotkeys for the X-Window

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xhotkeys - Hotkeys for the X-Window


https://bugzilla.redhat.com/show_bug.cgi?id=431175





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 06:59 EST ---
your SOURCE1 file should look like this
[Desktop Entry]
Encoding=UTF-8
Name=Xhotkeys
GenericName=Xhotkeys
Comment=Hotkeys for the X-Window
Exec=xhotkeys --config
Icon=xhotkeys
Terminal=false
Type=Application
Categories=Utility;
GenericName[pl_PL]=Xhotkeys


Note:- I suggest adding --config in Exec line

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431414] Review Request: planets - A celestial simulator

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: planets - A celestial simulator


https://bugzilla.redhat.com/show_bug.cgi?id=431414


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431047] Review Request: latencytop - System latency monitor

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: latencytop - System latency monitor


https://bugzilla.redhat.com/show_bug.cgi?id=431047





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 07:29 EST ---
(In reply to comment #10)
 re 1) We must have a misunderstanding about what whitespace you meant. I 
 thought
 you referred to the extra line. Maybe you wanted me to drop the second hunk of
 the patch completely?

Yes. I mean following lines from patch to be removed
=
 #
 # The w in -lncursesw is not a typo; it is the wide-character version
@@ -10,8 +10,7 @@ LDF = -Wl,--as-needed `pkg-config --libs
 # libncursesw5-dev package.
 #
 latencytop: latencytop.o display.o latencytop.h translate.o Makefile
-   gcc $(CFLAGS) latencytop.o display.o translate.o $(LDF)-o latencytop
-
+   gcc $(CFLAGS) latencytop.o display.o translate.o $(LDF) -o latencytop

 clean:
rm -f *~ latencytop DEADJOE *.o
=  
 
 
 re 2 and 3) I agree it would be nice if upstream provided a README. I already
 asked for one when I was asking for the COPYING file. We'll see if a new
 upstream version adds them.
  Thanks.

 
 
 I can see Rawhide has kernel-2.6.24-9 currently. This kernel does not have
 LATENCYTOP support yet. The patch was merged upstream after the release of
 2.6.24 in git commit 9745512ce... sched: latencytop support.
 So you'd need to compile the kernel from the current git tree. Make sure you
 have CONFIG_LATENCYTOP enabled. After boot, start the measurement with:
 echo 1  /proc/sys/kernel/latencytop
 Then you can run latencytop and see the output similar to the screenshot at
 http://www.latencytop.org/ .

 Hope to see our kernels will get compiled with CONFIG_LATENCYTOP enabled.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431414] Review Request: planets - A celestial simulator

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: planets - A celestial simulator


https://bugzilla.redhat.com/show_bug.cgi?id=431414





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 07:29 EST ---
Hmm, looks like ExcludeArch: ppc64 might be in order.  Concur?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431047] Review Request: latencytop - System latency monitor

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: latencytop - System latency monitor


https://bugzilla.redhat.com/show_bug.cgi?id=431047





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 07:19 EST ---
re 1) We must have a misunderstanding about what whitespace you meant. I thought
you referred to the extra line. Maybe you wanted me to drop the second hunk of
the patch completely?

re 2 and 3) I agree it would be nice if upstream provided a README. I already
asked for one when I was asking for the COPYING file. We'll see if a new
upstream version adds them.


I can see Rawhide has kernel-2.6.24-9 currently. This kernel does not have
LATENCYTOP support yet. The patch was merged upstream after the release of
2.6.24 in git commit 9745512ce... sched: latencytop support.
So you'd need to compile the kernel from the current git tree. Make sure you
have CONFIG_LATENCYTOP enabled. After boot, start the measurement with:
echo 1  /proc/sys/kernel/latencytop
Then you can run latencytop and see the output similar to the screenshot at
http://www.latencytop.org/ .

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431373] Review Request: incollector - Information collector

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: incollector - Information collector


https://bugzilla.redhat.com/show_bug.cgi?id=431373





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 07:36 EST ---
Fixed
Spec URL: http://kurzawa.nonlogic.org/rpm/incollector/incollector.spec
SRPM URL: 
http://kurzawa.nonlogic.org/rpm/incollector/incollector-1.0-5.fc8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431175] Review Request: xhotkeys - Hotkeys for the X-Window

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xhotkeys - Hotkeys for the X-Window


https://bugzilla.redhat.com/show_bug.cgi?id=431175


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 14:39 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431356] Review Request: dvipng - Converts DVI files to PNG/GIF format

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dvipng - Converts DVI files to PNG/GIF format


https://bugzilla.redhat.com/show_bug.cgi?id=431356


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 14:41 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431047] Review Request: latencytop - System latency monitor

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: latencytop - System latency monitor


https://bugzilla.redhat.com/show_bug.cgi?id=431047


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 14:35 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 430339] Review Request: libgringotts - The libgringotts provides a backend for managing the data files on the disk

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgringotts - The libgringotts provides a backend for 
managing the data files on the disk


https://bugzilla.redhat.com/show_bug.cgi?id=430339





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 10:00 EST ---
1.2.9? It's Gringotts, not libGringotts, which is packaged by me.

SRPM: http://liviopl.fedorapeople.org/libgringotts/libgringotts-lastest.src.rpm
SPEC: http://liviopl.fedorapeople.org/libgringotts/libgringotts.spec

PS: SRPM will stay constant - it will be link.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431368] Review Request: inconsoleata-fonts - A monospace font, designed for code listings and the like, in print

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: inconsoleata-fonts - A monospace font, designed for 
code listings and the like, in print


https://bugzilla.redhat.com/show_bug.cgi?id=431368


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 14:51 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428925] Review Request: bongo - An easy-to-use mail and calendar system

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bongo - An easy-to-use mail and calendar system


https://bugzilla.redhat.com/show_bug.cgi?id=428925


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431047] Review Request: latencytop - System latency monitor

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: latencytop - System latency monitor


https://bugzilla.redhat.com/show_bug.cgi?id=431047


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 11:29 EST ---
Alright, I removed the second part of the patch. Now it's just a one-liner
changing the CFLAGS.

Updated package:
http://michich.fedorapeople.org/latencytop/latencytop-0.3-3.fc9.src.rpm
http://michich.fedorapeople.org/latencytop/latencytop.spec

Rawhide kernels usually do have many debugging options enabled. I expect
LATENCYTOP will be enabled too.

Thank you for the review.

New Package CVS Request
===
Package Name: latencytop
Short Description: System latency monitor
Owners: michich
Branches: F-8
InitialCC:
Cvsextras Commits: yes


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431277] Review Request: ocfs2-tools - programs for managing Ocfs2 file systems

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocfs2-tools - programs for managing Ocfs2 file systems


https://bugzilla.redhat.com/show_bug.cgi?id=431277





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 12:30 EST ---
(In reply to comment #6)
 (In reply to comment #3)
  As for the init script, it would seem to be logical that it just be added 
  to the
  list of types in netfs, or similar.
 
 Looking at gfs2-utils, they seem to do the same thing as Ocfs2 (no mention of
 Gfs2 in /etc/init.d/netfs either).
 
 From /etc/init.d/gfs2:
   start)
 if [ -n $GFS2FSTAB ] 
 then
 action $Mounting GFS2 filesystems:  mount -a -t gfs2
 fi
 touch /var/lock/subsys/gfs2
 ;;
 
 
 Can we do it this way until netfs is fixed up to understand Ocfs2?
 

Yes, it would just be nice to have a better infrastructure to do this rather
than a pile of init scripts. Something for the future...


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 430939] Review Request: desktop-data-model - Engine for communicating with Online Desktop Data Model

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: desktop-data-model - Engine for communicating with 
Online Desktop Data Model


https://bugzilla.redhat.com/show_bug.cgi?id=430939





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 12:36 EST ---
Missing a BR, fixed now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 429416] Review Request: event-compat-sysv - sysVinit compatibility for upstart

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: event-compat-sysv - sysVinit compatibility for upstart


https://bugzilla.redhat.com/show_bug.cgi?id=429416





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 13:07 EST ---
Drop upstart's in as Source2: (or whatever), maybe with a copy of the note from
Scott until there's a new upstream tarball.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225245] Merge Review: am-utils

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: am-utils


https://bugzilla.redhat.com/show_bug.cgi?id=225245


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium
   Priority|normal  |medium
Product|Fedora Extras   |Fedora
Version|devel   |rawhide

[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review?




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 15:35 EST ---
rpmlint on SRPM:

am-utils.src:39: W: unversioned-explicit-obsoletes amd
The specfile contains an unversioned Obsoletes: token, which will match all
older, equal and newer versions of the obsoleted thing.  This may cause update
problems, restrict future package/provides naming, and may match something it
was originally not inteded to match -- make the Obsoletes versioned if
possible.

am-utils.src:86: E: use-of-RPM_SOURCE_DIR
You use $RPM_SOURCE_DIR or %{_sourcedir} in your spec file. If you have to
use a directory for building, use $RPM_BUILD_ROOT instead.

am-utils.src:237: W: macro-in-%changelog pre
Macros are expanded in %changelog too, which can in unfortunate cases lead
to the package not building at all, or other subtle unexpected conditions that
affect the build.  Even when that doesn't happen, the expansion results in
possibly rewriting history on subsequent package revisions and generally
odd entries eg. in source rpms, which is rarely wanted.  Avoid use of macros
in %changelog altogether, or use two '%'s to escape them, like '%%foo'.

am-utils.src:408: W: macro-in-%changelog pre
Macros are expanded in %changelog too, which can in unfortunate cases lead
to the package not building at all, or other subtle unexpected conditions that
affect the build.  Even when that doesn't happen, the expansion results in
possibly rewriting history on subsequent package revisions and generally
odd entries eg. in source rpms, which is rarely wanted.  Avoid use of macros
in %changelog altogether, or use two '%'s to escape them, like '%%foo'.

am-utils.src: W: mixed-use-of-spaces-and-tabs (spaces: line 33, tab: line 77)
The specfile mixes use of spaces and tabs for indentation, which is a
cosmetic annoyance.  Use either spaces or tabs for indentation, not both.

am-utils.src: W: summary-ended-with-dot Automount utilities including an updated
version of Amd.
Summary ends with a dot.

am-utils.src: W: strange-permission am-utils.init 0755
A file that you listed to include in your package has strange
permissions. Usually, a file should have 0644 permissions.


Should all be fixed, except the last one.

rpmlint on RPMS:

am-utils.i386: E: executable-marked-as-config-file /etc/rc.d/init.d/amd
Executables must not be marked as config files because that may
prevent upgrades from working correctly. If you need to be able to
customize an executable, make it for example read a config file in
/etc/sysconfig.

Should this be marked config?

am-utils.i386: W: hidden-file-or-dir /.automount
The file or directory is hidden. You should see if this is normal,
and delete it from the package if not.

am-utils.i386: W: hidden-file-or-dir /.automount
The file or directory is hidden. You should see if this is normal,
and delete it from the package if not.

am-utils.i386: E: non-readable /etc/amd.conf 0600
The file can't be read by everybody. If this is expected (for security
reasons), contact your rpmlint distributor to get it added to the list of
exceptions for your distro (or add it to your local configuration if you
installed rpmlint from the source tarball).

am-utils.i386: E: non-readable /etc/amd.net 0640
The file can't be read by everybody. If this is expected (for security
reasons), contact your rpmlint distributor to get it added to the list of
exceptions for your distro (or add it to your local configuration if you
installed rpmlint from the source tarball).

These are OK.

am-utils.i386: W: devel-file-in-non-devel-package /usr/lib/libamu.so
A development file (usually source code) is located in a non-devel
package. If you want to include source code in your package, be sure to
create a development package.

Why is there not a -devel package?  I see that the spec removes other .so files,
why not put them in -devel or delete this one?

am-utils.i386: W: summary-ended-with-dot Automount utilities including an
updated version of Amd.
Summary ends with a dot.

am-utils.i386: W: incoherent-version-in-changelog 6.1.5-7 

[Bug 430360] Review Request: ggz-gtk-client - Gtk+ client libraries for GGZ gaming zone

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ggz-gtk-client - Gtk+ client libraries for GGZ gaming 
zone


https://bugzilla.redhat.com/show_bug.cgi?id=430360


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 14:21 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225950] Merge Review: jpackage-utils

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: jpackage-utils


https://bugzilla.redhat.com/show_bug.cgi?id=225950


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]  |[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review?




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 13:04 EST ---
rpmlint:

Change Group tag to Applications/System, Utilities is not valid.

Change license, JPackage License is invalid. I think BSD is closest.

jpackage-utils.noarch: W: conffile-without-noreplace-flag 
/etc/java/jpackage-release
A configuration file is stored in your package without the noreplace flag.
A way to resolve this is to put the following in your SPEC file:

%config(noreplace) /etc/your_config_file_here


I can't find the tarball on the upstream site, so I can't tell you what the
Source0 tag should be changed to, but it must include a URL.

The %description is a little on the large side, and sort of blind-sided me when
I rpm -qi jpackage-utils.  Not a blocker, just a suggestion.

Otherwise, looks great.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428113] Review Request: perl-Net-eBay - Perl Interface to XML based eBay API

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-eBay - Perl Interface to XML based eBay API


https://bugzilla.redhat.com/show_bug.cgi?id=428113





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 15:16 EST ---
New upstream version, with fixed documentation. I re-enabled BR: on
perl(Test::Pod::Coverage)

Spec URL: http://washington.kelkoo.net/fedora/SPECS/perl-Net-eBay.spec
SRPM URL: 
http://washington.kelkoo.net/fedora/SRPMS/perl-Net-eBay-0.46-1.fc8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431277] Review Request: ocfs2-tools - programs for managing Ocfs2 file systems

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocfs2-tools - programs for managing Ocfs2 file systems


https://bugzilla.redhat.com/show_bug.cgi?id=431277





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 15:03 EST ---
Ah yes, EPEL follows the same guidelines as Fedora and doesn't have external
kernel modules so forget I ever said that. 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 316141] Review Request: gridengine - Grid Engine - Distributed Computing Management software

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gridengine - Grid Engine - Distributed Computing 
Management software


https://bugzilla.redhat.com/show_bug.cgi?id=316141





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 17:33 EST ---
Your example works if the build directory is already expanded when rpmbuild is
run, but not if it doesn't (as with mock).  However, I was able to get around by
using wildcards in the %files section.

* Mon Feb  4 2008 - Orion Poplawski [EMAIL PROTECTED] - 6.1u3-4
- Drop arch from source
- Fix Requires() for main package
- Move man3 to -devel

http://www.cora.nwra.com/~orion/fedora/gridengine-6.1u3-4.fc8.src.rpm
http://www.cora.nwra.com/~orion/fedora/gridengine.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 430360] Review Request: ggz-gtk-client - Gtk+ client libraries for GGZ gaming zone

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ggz-gtk-client - Gtk+ client libraries for GGZ gaming 
zone


https://bugzilla.redhat.com/show_bug.cgi?id=430360


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 15:18 EST ---
built.  thanks for the review, Tibbs.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 316141] Review Request: gridengine - Grid Engine - Distributed Computing Management software

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gridengine - Grid Engine - Distributed Computing 
Management software


https://bugzilla.redhat.com/show_bug.cgi?id=316141





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 17:20 EST ---
(In reply to comment #25)
 Well, for 6.1u3-3:
 
 * uid
   - On my system the number 43 is already used by
 xfs (xorg-x11-xfs).
   - BTW do you have any reason to prefer fedora-usermgmt?

fedora-usermgmt creates IDs starting at a configurable base ID.  Because certain
files for gridengine really should be shared via NFS I want to try to have a
common ID across a site.

 * Requires(post) etc
   - Please update Requires(post) etc on gridengine main
 package.

Fixed.

 * Overwriting source
   - As I said above, this can be avoided.

See below.
 
 * mandir
   - Usually section 3 man files explain functions or so and
 they should be in -devel package.

Fixed.

 * License
   - I will propose the tag later after checking linkage
 again.

Thanks!

(In reply to comment #24)
 Created an attachment (id=293788)
 -- (https://bugzilla.redhat.com/attachment.cgi?id=293788action=view) [edit]
 A example spec file using %define afterwards
 
 You can use %define afterwards. A example is attached.

Doesn't work for me.  Log snippet from mock:

+ rm -rf /var/tmp/foo-0-1.fc9-root-mockbuild
+ mkdir -p /var/tmp/foo-0-1.fc9-root-mockbuild/usr/lib/foo/

note that it doesn't make /var/tmp/foo-0-1.fc9-root-mockbuild/usr/lib/foo/i686



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431277] Review Request: ocfs2-tools - programs for managing Ocfs2 file systems

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocfs2-tools - programs for managing Ocfs2 file systems


https://bugzilla.redhat.com/show_bug.cgi?id=431277





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 18:09 EST ---
Created an attachment (id=293957)
 -- (https://bugzilla.redhat.com/attachment.cgi?id=293957action=view)
Latest ocfs2-tools spec file.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 411881] Package review: sim

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Package review: sim


https://bugzilla.redhat.com/show_bug.cgi?id=411881





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 18:44 EST ---
The command in the spec file looks good. What command did you
use in Comment #14?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431381] Review Request: unicap - Library to access different kinds of (video) capture devices

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: unicap - Library to access different kinds of (video) 
capture devices


https://bugzilla.redhat.com/show_bug.cgi?id=431381





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 16:52 EST ---
Yes, done:

Spec URL: http://labs.linuxnetz.de/bugzilla/unicap.spec
SRPM URL: http://labs.linuxnetz.de/bugzilla/unicap-0.2.19-2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431277] Review Request: ocfs2-tools - programs for managing Ocfs2 file systems

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocfs2-tools - programs for managing Ocfs2 file systems


https://bugzilla.redhat.com/show_bug.cgi?id=431277





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 18:07 EST ---
(In reply to comment #7)
 I can't sponsor you but a quick review nevertheless:

Thank you for the review - it has been very helpful and I've implemented the
vast majority of what you've pointed out:

I dropped the Exclusiveos tag and added a disttag. Also, I'm now using
%{_datadir}, %{_initrddir} and %{python_sitearch} whenever possible.

BuildRoot is now
%{_tmppath}/%{name}-%{PACKAGE_VERSION}-%{PACKAGE_RELEASE}-root which is one of
the approved alternates which you mentioned.

The requires line for ocfs2-tools-devel has been fixed - thanks for noticing 
that.


A new spec file / srpm has been uploaded and I'll attach the spec to this bug.
Since so much has changed, I bumped the release number:


Spec URL: http://oss.oracle.com/~mfasheh/fedora/ocfs2-tools.spec
SRPM URL:
http://oss.oracle.com/~mfasheh/fedora/ocfs2-tools-1.3.9-5.20080131git.fc8.src.rpm


The rest of my comments follow:

 You must drop all BuildRequires that are part of the default build root such 
 as
 bash.

I think we're already clean with respect to buildrequires. There's certainly no
bash line in there - maybe you were looking at the requires instead?


 Why is there a Provides: ocfs2-tools-static = %{version}-%{release}? Can't you
 dynamically link libraries? If not, you should provide a justification for
 statically linking any libraries. 
 
 Refer 
 

http://fedoraproject.org/wiki/Packaging/Guidelines#head-2302ec1e1f44202c9cc4bcce24cb711266557ad7

The page you reference states:

When a package only provides static libraries you can place all the files in
the *-devel subpackage. When doing this you also have to have a virtual Provide
for the static package:

Ocfs2-tools is one such package, and I've followed the guidelines set out there.


 Use make %{?_smp_mflags} if possible. 

Unfortunately, ocfs2-tools doesn't support parallel builds at this time.

Thanks again!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 210007] Review Request: libtune - standard API to access the kernel tunables

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libtune - standard API to access the kernel tunables


https://bugzilla.redhat.com/show_bug.cgi?id=210007


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 18:10 EST ---
ok MUST items with explanations:

 - rpmlint: ok
$rpmlint -v libtune-0.14-5.fc8.i386.rpm
libtune.i386: I: checking
$rpmlint -v libtune-devel-0.14-5.fc8.i386.rpm
libtune-devel.i386: I: checking
libtune-devel.i386: W: service-default-enabled /etc/rc.d/init.d/chtunedb
libtune-devel.i386: W: service-default-enabled /etc/rc.d/init.d/chtunedb
libtune-devel.i386: W: incoherent-init-script-name chtunedb
$rpmlint -v tunables-base-data-2.6.23-0.14-5.fc8.i386.rpm
tunables-base-data-2.6.23.i386: I: checking
$rpmlint -v tunables-distro-data-0.14-5.fc8.i386.rpm
tunables-distro-data.i386: I: checking

The warnings for libtune-devel can be ignored. The 'chtunedb' script is
the mechanism for the devel package to harvest kernel parameters (so
if a new kernel is added they are automaticly regenerated).

ok MUST items:
 - package name: ok.
 - spec file name match base package: ok.
 - package meet packaging guidelines: ok
 - package must contin approved license: ok
 - license field equal the actual license: ok
 - spec file written in American English: ok
 - spec file legible: ok
 - source files in rpmbuild match upstream: ok
 - package compile and build binary RPM: ok (built on f-7, f-8, f-9 under
scratch koji build)
 - build dependencies listed in BuildRequires: ok
 - binary RPM which stores shared library must call ldconfig in %post and
%postun: ok
 - a package must own all the directories it creates: ok
 - a package must not contain duplicates in %files: ok
 - permissions must be properly: ok
 - must have %clean section: ok
 - must use consistently use macros: ok
 - package must contain code or permissiable content: ok
 - if a package includes %doc it must not reflect the runtime of the 
application: ok
 - header files must be in -devel package: ok
 - if package contains library files with a suffix, then one ending with .so
must be in -devel: ok
 - fully versioned depedency: ok
 - not have any .la archives :ok
 - package must not own files or directories already owned by other packages: ok
 - At the beginning of %install, the rm -Rf .. : ok
 - all filenames in the package must be valid UTF-8: ok

N/A MUST items:
 - spec file handle locales using %find_lang: There are no translation usages on
this package, hence N/A.
 - if package is relocatable : Package is not relocatable, hence N/A.
 - large doc should go in -doc subpackage .. : no big doc, hence N/A.
 - static libraries must be in .. : not using static libraries, hence N/A.
 - packages containing pkgconfig(..), not using pkgconfig, hence N/A.
 - package containing GUI .. : no GUI, hence N/A.


ok SHOULD items with explanations.
 - usually subpackages other than devel should require the base package using a
fully versioned  dependency. This package 'libtune' requires the
'tunabled-base-distro-%{version}' package instead of using the
'tunable-base-distro-%{version}-${release}'. This is done b/c the
tunables-base-distro package can be respun many times during a release (for new
kernels that might change their /proc or  /sysfs layout) and there is absolutely
no reason to re-release the libtune package.

ok SHOULD items:
 - if the source package does not include license text... : it does have it: ok
 - test package in koji: ok
 - compile and build binary packages on all architecture: ok
 - test the package functions as described: ok
 - if scriptlets are used... : ok.

N/A SHOULD items:
 - The placement of pkgconfig ... : N/A
 - If the package has file dependency on .. : N/A
 - The description and summary sections in the package should contain
translations for supported Non-English language: not done. This package does not
contain any localized information, hence no translation effort was involved and
this is N/A.

PACKAGE REVIEWED. ACCEPT.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431277] Review Request: ocfs2-tools - programs for managing Ocfs2 file systems

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocfs2-tools - programs for managing Ocfs2 file systems


https://bugzilla.redhat.com/show_bug.cgi?id=431277





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 19:42 EST ---
I guess I misread the BuildRequires. 

Change the buildroot to

%{_tmppath}/%{name}-%{version}-%{release}-root

The guidelines recommend against mixing two styles 

http://fedoraproject.org/wiki/Packaging/Guidelines#head-f3d77b27a5d29dfc1f5600ef3fc836f2e317badf

The part of the guidelines, I wanted you to refer to regarding static libs was, 

In general, packagers are strongly encouraged not to ship static libs unless a
compelling reason exists.

If you do have compelling reasons, it would be good to specify that in the
review. Other than those minor nit-picks, the latest spec looks ok to me. I did
a scratch build of the latest ocfs2 srpm and it builds and installs correctly.

http://koji.fedoraproject.org/koji/taskinfo?taskID=395837

A sponsor has to do a official review and approve your spec before you get
commit access.

http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428113] Review Request: perl-Net-eBay - Perl Interface to XML based eBay API

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-eBay - Perl Interface to XML based eBay API


https://bugzilla.redhat.com/show_bug.cgi?id=428113





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 20:27 EST ---
unable to download upstream source tarball.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431356] Review Request: dvipng - Converts DVI files to PNG/GIF format

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dvipng - Converts DVI files to PNG/GIF format


https://bugzilla.redhat.com/show_bug.cgi?id=431356


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 20:27 EST ---
Thanks Kevin. Thanks Patrice.

Package imported and built.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 253741] Review Request: perl-VCS-LibCVS - Access CVS working directories and repositories

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-VCS-LibCVS - Access CVS working directories and 
repositories
Alias: perl-VCS-LibCVS

https://bugzilla.redhat.com/show_bug.cgi?id=253741





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 22:55 EST ---
ping?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 430619] Review Request: perl-Color-Library - Easy-to-use and comprehensive named-color library

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Color-Library - Easy-to-use and comprehensive 
named-color library


https://bugzilla.redhat.com/show_bug.cgi?id=430619





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 22:56 EST ---
ping?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has 
been idle


https://bugzilla.redhat.com/show_bug.cgi?id=430441


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 23:52 EST ---
thanks kevin.

srpms imported, koji build ok, added to bodhi
== NEXTRELEASE ==

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431381] Review Request: unicap - Library to access different kinds of (video) capture devices

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: unicap - Library to access different kinds of (video) 
capture devices


https://bugzilla.redhat.com/show_bug.cgi?id=431381





--- Additional Comments From [EMAIL PROTECTED]  2008-02-05 01:34 EST ---
Koji build failed =
http://koji.fedoraproject.org/koji/taskinfo?taskID=396090

SHOULD:
   1) Change defattr usage to defattr(-,root,root,-)
   2) -devel description says only The unicap-devel package includes header
files and libraries necessary for for developing programs which use the unicap
and ucil library. which missed to mention libunicapgtk library. Please add that
to this description line.
   3) Add README.troubleshooting to %docs
   


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431371] Review Request: gyachi - A Yahoo! chat client with Webcam and voice support

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gyachi - A Yahoo! chat client with Webcam and voice 
support


https://bugzilla.redhat.com/show_bug.cgi?id=431371


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED




--- Additional Comments From [EMAIL PROTECTED]  2008-02-05 01:34 EST ---
Created an attachment (id=293980)
 -- (https://bugzilla.redhat.com/attachment.cgi?id=293980action=view)
fix for compile problem on non-x86 platforms


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431371] Review Request: gyachi - A Yahoo! chat client with Webcam and voice support

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gyachi - A Yahoo! chat client with Webcam and voice 
support


https://bugzilla.redhat.com/show_bug.cgi?id=431371





--- Additional Comments From [EMAIL PROTECTED]  2008-02-05 01:36 EST ---
I have created a patch (attached) which *should* address the non-x86 build
problem. I specifically only addressed ppc64 ppc x86_64, but extending this to
any other architecture is (at this point) a really trivial matter.

I say *should* as I do not have a ppc/etc machine to physically test on.
However, I extended the arch list to i386 (temporarily, for testing purposes
only), and I got the desired result (the files which will fail, don't compile).

See attachment (id=293980)

-Greg

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 411881] Package review: sim

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Package review: sim


https://bugzilla.redhat.com/show_bug.cgi?id=411881





--- Additional Comments From [EMAIL PROTECTED]  2008-02-05 02:29 EST ---
desktop-file-install --vendor fedora\
  --dir ${RPM_BUILD_ROOT}%{_datadir}/applications/kde/sim.desktop

files -f %{name}.lang
%{_datadir}/applications/fedora-sim.desktop

The whole spec is on:
http://mmaslano.fedorapeople.org/sim/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review