[Bug 442022] Review Request: wordwarvi - Side-scrolling shoot 'em up '80s style arcade game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: wordwarvi - Side-scrolling shoot 'em up '80s style arcade game https://bugzilla.redhat.com/show_bug.cgi?id=442022 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 02:03 EST --- Ok, About portaudio versus pulse I've tested this on 2 different machines (both with only onboard sound) and it both works fine there. Jonathan you may be having troubles as you're using pa in F-7 where it wasn't officially supported. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444792] Review Request: Augeas - library for changing configuration files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Augeas - library for changing configuration files https://bugzilla.redhat.com/show_bug.cgi?id=444792 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444792] Review Request: Augeas - library for changing configuration files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Augeas - library for changing configuration files https://bugzilla.redhat.com/show_bug.cgi?id=444792 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 03:37 EST --- Ok, I will review the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444792] Review Request: Augeas - library for changing configuration files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Augeas - library for changing configuration files https://bugzilla.redhat.com/show_bug.cgi?id=444792 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 03:40 EST --- I assume we want the new release version 0.1.0. http://people.redhat.com/dlutter/yum/spec/augeas.spec http://people.redhat.com/dlutter/yum/SRPMS/augeas-0.1.0-1.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 436033] Review Request: mona - a solver for the WS1S and WS2S logics
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: mona - a solver for the WS1S and WS2S logics
https://bugzilla.redhat.com/show_bug.cgi?id=436033
--- Additional Comments From [EMAIL PROTECTED] 2008-05-02 03:41 EST ---
+ rpmlint output
mona-devel.i386: W: no-documentation
mona-emacs.i386: W: no-documentation
mona-emacs-el.i386: W: no-documentation
mona-libs.i386: W: no-documentation
mona-xemacs.i386: W: no-documentation
mona-xemacs-el.i386: W: no-documentation
mona-devel.i386: W: no-dependency-on mona
This one is caused because you've split the libraries into a 'libs'
subpackage. This is wrong.
*.so should go in devel subpackage.
*.so.* should go in the main package.
+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license
+ %doc includes license file
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
47842cbed7ee11310ef9747ef0d0d42c
+ package successfully builds on at least one architecture
i386
n/a ExcludeArch bugs filed
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
+ binary RPM with shared library files must call ldconfig in %post and %postun
+ does not use Prefix: /usr
+ package owns all directories it creates
+ no duplicate files in %files
+ %defattr line
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package
appear to be just examples that shouldn't affect anything
+ header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
- libfoo.so must go in -devel
*.so should go in devel subpackage.
*.so.* should go in the main package.
- -devel must require the fully versioned base
Depends on -libs, should depend on base.
+ packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ %install must start with rm -rf %{buildroot} etc.
+ filenames must be valid UTF-8
Optional:
n/a if there is no license file, packager should query upstream
n/a translations of description and summary for non-English languages, if
available
+ reviewer should build the package in mock
+ the package should build into binary RPMs on all supported architectures
reviewer built it in Koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=592445
- review should test the package functions as described
+ scriptlets should be sane
n/a pkgconfig files should go in -devel
n/a shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or
/usr/sbin
=
Please fix the -libs thing as described above.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 262401] Review Request: jcip-annotations - Java 5 thread safety annotations
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: jcip-annotations - Java 5 thread safety annotations
https://bugzilla.redhat.com/show_bug.cgi?id=262401
--- Additional Comments From [EMAIL PROTECTED] 2008-05-02 03:56 EST ---
+ rpmlint output
jcip-annotations.src: W: non-standard-group Development/Libraries/Java
jcip-annotations.noarch: W: no-documentation
jcip-annotations.noarch: W: non-standard-group Development/Libraries/Java
jcip-annotations-javadoc.noarch: W: non-standard-group
Development/Documentation
The Java guidelines are all over the place on the usage of 'Group:'.
I would rename 'Development/Libraries/Java' - 'Development/Libraries'
and leave the other one alone.
+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
CC-BY
+ license matches the actual package license
- %doc includes license file
You need to add %doc /package.html to the main package.
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
0a63cc4bca4a045aa56f3a12857857ea
+ package successfully builds on at least one architecture
n/a ExcludeArch bugs filed
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and %postun
n/a does not use Prefix: /usr
+ package owns all directories it creates
+ no duplicate files in %files
+ %defattr line
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
n/a files marked %doc should not affect package
n/a header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a -devel must require the fully versioned base
... but javadoc subpackage is OK
n/a packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
n/a packages must not own files or directories owned by other packages
+ %install must start with rm -rf %{buildroot} etc.
+ filenames must be valid UTF-8
Optional:
n/a if there is no license file, packager should query upstream
n/a translations of description and summary for non-English languages, if
available
+ reviewer should build the package in mock
Reviewer built it in Koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=592450
n/a the package should build into binary RPMs on all supported architectures
- review should test the package functions as described
n/a scriptlets should be sane
n/a pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin
==
Please add the %doc line, and if necessary rename the groups. If you present
an updated package with these changes then there shouldn't be any issue getting
approval.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444792] Review Request: Augeas - library for changing configuration files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Augeas - library for changing configuration files
https://bugzilla.redhat.com/show_bug.cgi?id=444792
--- Additional Comments From [EMAIL PROTECTED] 2008-05-02 04:07 EST ---
- MUST: rpmlint must be run on every package. The output should be posted in the
review.
* rpmlint output: OK
augeas-devel.i386: W: no-documentation
- MUST: The package must be named according to the Package Naming Guidelines.
* OK
- MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption on Package Naming Guidelines.
* OK
- MUST: The package must meet the Packaging Guidelines.
* OK
- MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines.
* OK, LGPLv2+
- MUST: The License field in the package spec file must match the actual
license.
* OK
- MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
* OK
- MUST: The spec file must be written in American English.
* OK
- MUST: The spec file for the package MUST be legible. If the reviewer is unable
to read the spec file, it will be impossible to perform a review. Fedora is not
the place for entries into the Obfuscated Code Contest (http://www.ioccc.org/).
* OK
- MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
* OK
- MUST: The package must successfully compile and build into binary rpms on at
least one supported architecture.
* OK
- MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch needs to have a bug filed
in bugzilla, describing the reason that the package does not compile/build/work
on that architecture. The bug number should then be placed in a comment, next to
the corresponding ExcludeArch line. New packages will not have bugzilla entries
during the review process, so they should put this description in the comment
until the package is approved, then file the bugzilla entry, and replace the
long explanation with the bug number. (Extras Only) The bug should be marked as
blocking one (or more) of the following bugs to simplify tracking such issues:
FE-ExcludeArch-x86, FE-ExcludeArch-x64, FE-ExcludeArch-ppc, FE-ExcludeArch-ppc64
* OK
- MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines; inclusion of
those as BuildRequires is optional. Apply common sense.
* OK
- MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
* OK, but no translations included
- MUST: Every binary RPM package which stores shared library files (not just
symlinks) in any of the dynamic linker's default paths, must call ldconfig in
%post and %postun. If the package has multiple subpackages with libraries, each
subpackage should also have a %post/%postun section that calls /sbin/ldconfig.
* OK
- MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
* OK
- MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory. Refer to the Guidelines for examples.
* OK
- MUST: A package must not contain any duplicate files in the %files listing.
* OK
- MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
* OK, but not explicitly set in the specfile
- MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
* OK
- MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines.
* OK
- MUST: The package must contain code, or permissable content. This is described
in detail in the code vs. content section of Packaging Guidelines.
* OK
- MUST: Large documentation files should go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity)
* OK
- MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is
[Bug 444792] Review Request: Augeas - library for changing configuration files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Augeas - library for changing configuration files https://bugzilla.redhat.com/show_bug.cgi?id=444792 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 04:09 EST --- - SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. * OK - SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. * non available - SHOULD: The reviewer should test that the package builds in mock. See MockTricks for details on how to do this. * OK - SHOULD: The package should compile and build into binary rpms on all supported architectures. * we will see - SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. * OK - SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity. * OK - SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. * OK - SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb. * OK - SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. Please see File Dependencies in the Guidelines for further information. * OK -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444792] Review Request: Augeas - library for changing configuration files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Augeas - library for changing configuration files https://bugzilla.redhat.com/show_bug.cgi?id=444792 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 04:11 EST --- Summary: OK - augeas-devel should require augeas-libs only. - consider translations for the tools. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444792] Review Request: Augeas - library for changing configuration files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Augeas - library for changing configuration files https://bugzilla.redhat.com/show_bug.cgi?id=444792 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED Flag|fedora-review? |fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444792] Review Request: Augeas - library for changing configuration files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Augeas - library for changing configuration files https://bugzilla.redhat.com/show_bug.cgi?id=444792 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 04:17 EST --- Summary: NEEDSWORK -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 434827] Review Request: jcommon - java jfreereport base utility library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jcommon - java jfreereport base utility library https://bugzilla.redhat.com/show_bug.cgi?id=434827 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 04:15 EST --- Thanks for rescuing this from review ghetto :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444792] Review Request: Augeas - library for changing configuration files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Augeas - library for changing configuration files https://bugzilla.redhat.com/show_bug.cgi?id=444792 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review+ |fedora-review- --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 04:16 EST --- Correction: - MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). * Not OK -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444792] Review Request: Augeas - library for changing configuration files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Augeas - library for changing configuration files https://bugzilla.redhat.com/show_bug.cgi?id=444792 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review- |fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442022] Review Request: wordwarvi - Side-scrolling shoot 'em up '80s style arcade game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: wordwarvi - Side-scrolling shoot 'em up '80s style arcade game https://bugzilla.redhat.com/show_bug.cgi?id=442022 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 04:27 EST --- Created an attachment (id=304365) -- (https://bugzilla.redhat.com/attachment.cgi?id=304365action=view) Output for six sound cards Um, I'm actually running F8 with what should be a standard pulseaudio setup. I've attached the output from wordwarvi --sounddevice [0-5]. Honestly, though, this is a separate (non-blocking) bug and should probably be listed as such. On that note, the review will follow in an hour or two. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 443449] Review Request: udpcast - UDP broadcast file distribution and installation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: udpcast - UDP broadcast file distribution and installation https://bugzilla.redhat.com/show_bug.cgi?id=443449 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 04:46 EST --- Right, here's a new version which should fix all of the above except trimming the changelog which I like to keep. This is rpmlint clean. Spec URL: http://www.annexia.org/tmp/udpcast.spec SRPM URL: http://www.annexia.org/tmp/udpcast-20071228-3.fc9.src.rpm * Fri May 2 2008 Richard W.M. Jones [EMAIL PROTECTED] - 20071228-3 - Remove '-s' flag from Makefile. - Remove unused udpcast_version macro. - Use configure macro. - Fix the license, GPLv2+ and BSD. - BuildRequires perl. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444945] New: Review Request: python-augeas - python bindings for augeas
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=444945 Summary: Review Request: python-augeas - python bindings for augeas Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://harald.fedorapeople.org/downloads/python-augeas/python-augeas.spec SRPM URL: http://harald.fedorapeople.org/downloads/python-augeas/python-augeas-1.0-1.fc9.src.rpm Description: python-augeas is a set of Python bindings around augeas. augeas package review is here: https://bugzilla.redhat.com/show_bug.cgi?id=444792 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444952] New: Review Request: tlock - terminal lock
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=444952 Summary: Review Request: tlock - terminal lock Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://pjp.dgplug.org/tools/tlock.spec SRPM URL: http://pjp.dgplug.org/tools/tlock-1.1-0.1.fc8.src.rpm Description: tlock is a small program intended to lock the terminal until the correct password is supplied by the user. By default 'tlock' prompts you for the password, but can also lock the terminal with system password when invoked with the -s switch. tlock is distributed under the GNU General Public License - GPLv2. Please note that, this is my first ever fedora package, and am looking for the sponsor for my package. I'd really appreciate if somebody could come forward for the sponsorship. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 426985] Review Request: php-suhosin - Suhosin extension for the php language
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-suhosin - Suhosin extension for the php language https://bugzilla.redhat.com/show_bug.cgi?id=426985 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 06:25 EST --- Would really be nice to have that package ... +1 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444952] Review Request: tlock - terminal lock
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tlock - terminal lock https://bugzilla.redhat.com/show_bug.cgi?id=444952 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||177841 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442009] Review Request: bind-libbind - The Berkeley Internet Name Domain (BIND) libbind resolver libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bind-libbind - The Berkeley Internet Name Domain (BIND) libbind resolver libraries https://bugzilla.redhat.com/show_bug.cgi?id=442009 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 06:11 EST --- Looks fine for me, reviewed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442009] Review Request: bind-libbind - The Berkeley Internet Name Domain (BIND) libbind resolver libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bind-libbind - The Berkeley Internet Name Domain (BIND) libbind resolver libraries https://bugzilla.redhat.com/show_bug.cgi?id=442009 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 06:46 EST --- New Package CVS Request === Package Name: bind-libbind Short Description: Berkeley Internet Name Domain (BIND) libbind resolver library Owners: robert Branches: EL-4 InitialCC: Cvsextras Commits: no If somehow possible, PLEASE DO NO BRANCHING FOR DEVEL, JUST EL-4! As spoken in this bug report, libbind is included in bind package on EL-5+/FC-6+ and thus a devel branch won't be ever needed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442022] Review Request: wordwarvi - Side-scrolling shoot 'em up '80s style arcade game
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: wordwarvi - Side-scrolling shoot 'em up '80s style
arcade game
https://bugzilla.redhat.com/show_bug.cgi?id=442022
--- Additional Comments From [EMAIL PROTECTED] 2008-05-02 06:38 EST ---
Okay, here's the official review:
MD5SUM:
63c65ef135d69f8248af97f6250fca37 wordwarvi-0.07.tar.gz
Good:
* The package is named according to the Package Naming Guidelines.
* The spec file name matches the base package.
* The package meets the Packaging Guidelines.
* The package is licensed with a Fedora approved license (GPLv2+ for code, CC-BY
and CC-BY-SA for sounds)
* The License field in the package spec file matches the actual license.
* COPYING is included in %doc.
* The spec file is written in American English.
* The spec file for the package is legible.
* The sources used to build the package matches the upstream source.
* The package successfully compiles and builds into binary rpms on i386.
* All build dependencies are listed in BuildRequires.
* The package owns all directories that it creates.
* The package doesn't contain any duplicate files in the %files listing.
* Permissions on files are set properly.
* The package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT.
* The package consistently uses macros.
* The package contains code and permissable content.
* All %doc files do not affect the runtime of the application.
* The package includes a desktop-file-installed %{name}.desktop file.
* At the beginning of %install, the package runs rm -rf $RPM_BUILD_ROOT).
* All filenames in rpm packages are valid UTF-8.
* Source URL is canonical
* Buildroot has all required elements
* All paths begin with macros
* All necessary BuildRequires listed
* All desired features are enabled
* Desktop file has the vendor set to 'fedora'
* Group Tag is from the official list
* Package builds in mock with no errors and one odd warning that has no effect:
make[1]: warning: jobserver unavailable: using -j1. Add `+' to parent make
rule.
Bad:
Nothing that I could find
rpmlint output:
SRPM: None
RPM: None
Once a version gets pushed that fixes the segfaults, I'll be happy to approve
this.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442276] Review Request: evas - Hardware-accelerated state-aware canvas API for X-Windows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: evas - Hardware-accelerated state-aware canvas API for X-Windows https://bugzilla.redhat.com/show_bug.cgi?id=442276 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 07:23 EST --- He's not in CC of this bug -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444817] Review Request: Spicebird - Collaboration Suite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Spicebird - Collaboration Suite https://bugzilla.redhat.com/show_bug.cgi?id=444817 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] Summary|Review Request: Spicebird - |Review Request: Spicebird - |Collaboration Suite - 1st |Collaboration Suite |Package Need Sponsor| --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 09:07 EST --- adjusting summary (blocking FE_NEEDSPONSOR is sufficient). :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444817] Review Request: Spicebird - Collaboration Suite
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Spicebird - Collaboration Suite
https://bugzilla.redhat.com/show_bug.cgi?id=444817
--- Additional Comments From [EMAIL PROTECTED] 2008-05-02 09:13 EST ---
A few quick comments:
1. BuildRoot: /tmp/spicebird
Use one of the suggested buildroots in the packaging guidelines.
2. Source0:spicebird-0.4.source.tar.bz2
This should be a full URL
3. Release:0%{?dist}
Start with 1
4. MOZ_OPT_FLAGS=$(echo
$RPM_OPT_FLAGS | %{__sed} -e 's/-O2/-Os/' -e 's/-Wall//')
ill-advised. I'd recommend omitting this.
Also, good idea to try a scratch build in koji (I can help on irc if you don't
know how to do that).
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444817] Review Request: Spicebird - Collaboration Suite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Spicebird - Collaboration Suite https://bugzilla.redhat.com/show_bug.cgi?id=444817 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444817] Review Request: Spicebird - Collaboration Suite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Spicebird - Collaboration Suite https://bugzilla.redhat.com/show_bug.cgi?id=444817 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 09:50 EST --- koji build --background --scratch dist-f9 spicebird-0.4-0.fc8.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=592747 failed. looks like you need at least: BuildRequires: python Fix that and the (1-4) items above, and then we can try another scratch build. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444952] Review Request: tlock - terminal lock
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: tlock - terminal lock
https://bugzilla.redhat.com/show_bug.cgi?id=444952
--- Additional Comments From [EMAIL PROTECTED] 2008-05-02 09:59 EST ---
This package suffers from several issues:
1. MUSTFIX: BuildRequires: ncurses is meaningless.
You will want
BuildRequires: ncurses-devel
instead.
Without it, this package doesn't build in mock at all.
2. MUSTFIX: Use %{_bindir}, %{_libdir}, %{_infodir}, %{_mandir} in %files
instead of
%_prefix/bin/tlock
%_prefix/lib/*
%_prefix/share/info/*
%_prefix/share/man/*
Additionally, using %_prefix/lib also breaks building this package on 64bit
targets.
3. MUSTFIX: Source0: must be an URL pointing to the tarball
(http://pjp.dgplug.org/tools/%{name}-%{version}.tar.gz) not a relative
filename.
4. MUSTFIX: Library packaging:
- Package ships static library. If you really want to ship it, package the *.a
into a separate package. If not, disable building it (Append --disable-static to
%configure)
- Package ships *.la. Remove it in %install.
5. MUSTFIX: Devel files in base package.
Your base package %{name} contains development files, which are not needed at
run time. Either do not ship them at all or move them into a separate
%{name}-devel subpackage
6. MUSTFIX: The info files are packaged incorrectly.
Infos require special treatment in %post/%postun
Check the FPG and/or how other packages do so.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442353] Review Request: ecore - Event/X abstraction layer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ecore - Event/X abstraction layer https://bugzilla.redhat.com/show_bug.cgi?id=442353 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 10:27 EST --- * Fri May 02 2008 Pavel Stalwart Shevchuk [EMAIL PROTECTED] - 0.9.9.042-2 - Fixed ecore-devel dependencies - Fixed timestamp of source tarball - Preserve timestamps of installed files - Added html docs Docs are fixed for multilib New spec: http://rpm.scwlab.com/ecore-goes-rawhide/ecore.spec New SRPM: http://rpm.scwlab.com/fedora/e/9/ecore-0.9.9.042-2.x86_64/ ecore-0.9.9.042-2.fc9.src.rpm Built RPMs: http://rpm.scwlab.com/fedora/e/9/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 440597] Review Request: olpcsound - OLPC subset of csound 5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: olpcsound - OLPC subset of csound 5 https://bugzilla.redhat.com/show_bug.cgi?id=440597 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 10:24 EST --- I have now addressed all the points raised in the comments above. Could someone take another look? I would like to continue the review process, as the Csound developers for OLPC are depending on this. I also need sponsoring... Spec URL: http://music.nuim.ie/vlazzarini/tmp/olpcsound.spec SRPM URL: http://music.nuim.ie/vlazzarini/tmp/olpcsound-5.08.91-0.fc7.src.rpm The source rpm name has changed due the use of the dist tag. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 285551] Review Request: idw-gpl - Java Swing based docking windows framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: idw-gpl - Java Swing based docking windows framework https://bugzilla.redhat.com/show_bug.cgi?id=285551 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 10:33 EST --- Thanks, Jerry. Everything looks good. I'm sorry I didn't think of this yesterday, but do you think we should add Provides statements for ilf-gpl and itp-gpl? Since we're packaging the LAF and the tabbed panel all in this one RPM, I think virtual Provides are in order. What do you think? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444817] Review Request: Spicebird - Collaboration Suite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Spicebird - Collaboration Suite https://bugzilla.redhat.com/show_bug.cgi?id=444817 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 10:43 EST --- Got all fixed but #1. Have to get server up to host file. New SPEC file: http://www.mediafire.com/?xn9o5m3x40p New SRPM: http://www.mediafire.com/?eymdzdfmnmd -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444817] Review Request: Spicebird - Collaboration Suite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Spicebird - Collaboration Suite https://bugzilla.redhat.com/show_bug.cgi?id=444817 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 11:40 EST --- http://www.spicebird.com for those who want to check it out -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 434827] Review Request: jcommon - java jfreereport base utility library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jcommon - java jfreereport base utility library https://bugzilla.redhat.com/show_bug.cgi?id=434827 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] Status|NEW |ASSIGNED --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 11:47 EST --- Caolan: Can you add a cvs template here with what branches you want, etc? See: http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 437694] Review Request: bip - IRC Bouncer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bip - IRC Bouncer https://bugzilla.redhat.com/show_bug.cgi?id=437694 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] Flag|fedora-cvs? | --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 11:49 EST --- I don't see mcpierce in the cvsextras group. Have they been sponsored? Can you double check the name? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 434827] Review Request: jcommon - java jfreereport base utility library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jcommon - java jfreereport base utility library https://bugzilla.redhat.com/show_bug.cgi?id=434827 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 12:12 EST --- ug, forgot final step New Package CVS Request === Package Name: jcommon Short Description: JFree Java utility classes Owners: caolanm Branches: devel InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 434827] Review Request: jcommon - java jfreereport base utility library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jcommon - java jfreereport base utility library https://bugzilla.redhat.com/show_bug.cgi?id=434827 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 12:18 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444817] Review Request: Spicebird - Collaboration Suite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Spicebird - Collaboration Suite https://bugzilla.redhat.com/show_bug.cgi?id=444817 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 12:21 EST --- Doing a local mock build now, seeing this: c++ -o nsProxyEventObject.o -c -I../../../dist/include/system_wrappers -include ../../../config/gcc_hidden.h -D_IMPL_NS_COM -DEXPORT_XPTC_API -DMOZILLA_INTERNAL_API -DOSTYPE=\Linux2.6.23.15-80\ -DOSARCH=Linux -I/xpcom/threads/ -I./../../reflect/xptinfo/src -I../../../dist/include/string -I../../../dist/include -I../../../dist/include/xpcom -I../../../dist/include/nspr-fPIC -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -pedantic -fshort-wchar -pthread -pipe -DNDEBUG -DTRIMMED -O -DMOZILLA_CLIENT -include ../../../mozilla-config.h -Wp,-MD,.deps/nsProxyEventObject.pp nsProxyEventObject.cpp looks like optflags aren't being honored, so consider that MUSTFIX item 5. As discussed on irc item 6: currently bundles it's own copy of mozilla sources and runtime. Look into using system-provided firefox-devel or xulrunner-devel -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 437694] Review Request: bip - IRC Bouncer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bip - IRC Bouncer https://bugzilla.redhat.com/show_bug.cgi?id=437694 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 13:29 EST --- Kevin: I was sponsored by T Callaway. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 437694] Review Request: bip - IRC Bouncer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bip - IRC Bouncer https://bugzilla.redhat.com/show_bug.cgi?id=437694 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 13:45 EST --- It doesn't look that way. Or at least, the process is not complete because currently mcpierce is not yet in the cvsextras group. https://admin.fedoraproject.org/accounts/user/view/mcpierce -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442276] Review Request: evas - Hardware-accelerated state-aware canvas API for X-Windows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: evas - Hardware-accelerated state-aware canvas API for X-Windows https://bugzilla.redhat.com/show_bug.cgi?id=442276 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 13:58 EST --- APPROVED anyway, he had enough time to state his concerns. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439337] Review Request: python-sphinx - Python documentation generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-sphinx - Python documentation generator https://bugzilla.redhat.com/show_bug.cgi?id=439337 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 14:01 EST --- Thanks Jose. Will incorporate the patch -- I should probably split it into a -doc subpackage as well. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444792] Review Request: Augeas - library for changing configuration files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Augeas - library for changing configuration files https://bugzilla.redhat.com/show_bug.cgi?id=444792 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 14:02 EST --- Thanks for the review; addressed everything except for the translations. Spec URL: http://people.redhat.com/dlutter/yum/spec/augeas.spec SRPM URL: http://people.redhat.com/dlutter/yum/SRPMS/augeas-0.1.0-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442276] Review Request: evas - Hardware-accelerated state-aware canvas API for X-Windows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: evas - Hardware-accelerated state-aware canvas API for X-Windows https://bugzilla.redhat.com/show_bug.cgi?id=442276 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 14:09 EST --- New Package CVS Request === Package Name: evas Short Description: Hardware-accelerated state-aware canvas API Owners: stalwart Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439337] Review Request: python-sphinx - Python documentation generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-sphinx - Python documentation generator https://bugzilla.redhat.com/show_bug.cgi?id=439337 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 14:20 EST --- Problem fixed, documentation included and split into -doc. Thanks for the suggestion -- ready when you are, Jose. Spec URL: http://salimma.fedorapeople.org/for_review/python/python-sphinx.spec SRPM URL: http://salimma.fedorapeople.org/for_review/python/python-sphinx-0.1.61950-3.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 246782] Review Request: postgresql-plr - Procedural language interface between PostgreSQL and R
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: postgresql-plr - Procedural language interface between PostgreSQL and R https://bugzilla.redhat.com/show_bug.cgi?id=246782 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 14:22 EST --- This ticket has been set to needinfo for over three months now. Is it time to close it? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 438543] Review Request: Synopsis - Source-code introspection tool.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Synopsis - Source-code introspection tool. https://bugzilla.redhat.com/show_bug.cgi?id=438543 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 14:30 EST --- Okay, almost clean. For 0.11-2: * License issue: -- Synopsis/Parsers/Cxx/occ/HashTable.cc Xerox Synopsis/Parsers/Cxx/occ/HashTable.hh Xerox Synopsis/Parsers/Cxx/occ/MetaClass.cc Xerox Synopsis/Parsers/Cxx/occ/MetaClass.hh Xerox Synopsis/Parsers/Cxx/occ/QuoteClass.cc Xerox Synopsis/Parsers/Cxx/occ/QuoteClass.hh Xerox Synopsis/Parsers/IDL/ GPLv2+ Synopsis/Parsers/Python/__init__.py GPLv2+ src/Synopsis/PTree/generation.ccXerox src/Synopsis/gc/libatomic_ops-1.2/tests/GPLv2 src/Synopsis/gc/libatomic_ops/test/ GPLv2 -- ! The license tag Xerox is tagged by spot: https://www.redhat.com/archives/fedora-legal-list/2008-April/msg00035.html - Well, I don't know why Synopsis/Parsers/Python/__init__.py is licensed under GPLv2+. I guess you want to release this as LGPLv2+ (the license holder seems you). Currently, the license tag of synopsis (main) package should be LGPLv2+ and Xerox and GPLv2+. note that Xerox and GPLv2+ are incompatible, however on current situation no legal conflict is happening. The license tags of other subpackages (except for -idl) can be okay with LGPLv2+. (In reply to comment #22) I was wrongly installing libSynopsis.so.0.11 with INSTALL_DATA, not INSTALL_PROGRAM. Now it seems good In my local tests (using mock) I still see errors for all the extension modules, as they end up with 0775 permissions, instead of 0755. Are you not seeing those ? Actually no. rpmbuild appears to invoke 'umask 0022', too, Actually. but those files still appear to be group-writable, i.e. have 0775 permission. Ummm PS: If I make an official release in the coming days, will that be able to ship as part of the upcoming Fedora 9 ? No problem :) Anyway as this is NEEDSPONSOR ticket: - NOTE: Before being sponsored: This package will be accepted with another few work. But before I accept this package, someone (I am a candidate) must sponsor you. Once you are sponsored, you have the right to review other submitters' review requests and approve the packages formally. For this reason, the person who want to be sponsored (like you) are required to show that you have an understanding of the process and of the packaging guidelines as is described on : http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored Usually there are two ways to show this. A. submit other review requests with enough quality. B. Do a pre-review of other person's review request (at the time you are not sponsored, you cannot do a formal review) When you have submitted a new review request or have pre-reviewed other person's review request, please write the bug number on this bug report so that I can check your comments or review request. Fedora package collection review requests which are waiting for someone to review can be checked on: http://fedoraproject.org/PackageReviewStatus/NEW.html (NOTE: please don't choose Merge Review) Review guidelines are described mainly on: http://fedoraproject.org/wiki/Packaging/ReviewGuidelines http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ScriptletSnippets -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445010] New: Review Request: xvarstar - an astronomical program used for searching GCVS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=445010 Summary: Review Request: xvarstar - an astronomical program used for searching GCVS Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] This is my first package and I'm actually looking for a sponsor. Spec URL: http://telimektar.com/rpm/xvarstar/xvarstar.spec SRPM URL: http://telimektar.com/rpm/xvarstar/xvarstar-0.9-1.fc9.src.rpm Description: This software is intended to become a part of the Astronomy spin. XVarStar is a astronomical program written for variable star observers, and is used for searching GCVS catalogue. It allows searching by following criteria : -star name -magnitude -type -constellation -amplitude -This searching criteria can be combined so one can search for example all variable stars located in Andromeda constellation and with magnitude brighter than 5.00. The package succesfully pass rpmlint and is build without errors with mock. Please let me know if something's missing. I'd be happy if someone find the time to review this little package. Have a nice day ! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445010] Review Request: xvarstar - an astronomical program used for searching GCVS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xvarstar - an astronomical program used for searching GCVS https://bugzilla.redhat.com/show_bug.cgi?id=445010 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 14:41 EST --- Nice! I'll check this next week as I'm on business trip this week. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 438543] Review Request: Synopsis - Source-code introspection tool.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Synopsis - Source-code introspection tool. https://bugzilla.redhat.com/show_bug.cgi?id=438543 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 14:43 EST --- OK, thanks for the feedback again. I'm glad to see I'm making progress. :-) Just a little note on the license issue: The XEROX files aren't actually used my my code (I originally forked OpenC++, but have been moving away as I continue development), so I believe I can just strip them off the repository entirely. The IDL parser is indeed licensed under GPL, which is the reason why I split this into a separate binary package (synopsis-idl), so it can be distributed under GPL without any impact on the rest being released as LGPL. the libatomic code is an import, too, and for the fedora binary packages not used (I link to an external libgc). Do you think this conflict between LGPLv2 and LGPLv2+ is a problem ? Should I release as LGPLv2, too ? Thanks, -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445018] New: Review Request: python-beaker - WSGI middleware for sessions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=445018 Summary: Review Request: python-beaker - WSGI middleware for sessions Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://www.kylev.com/pylons-rpm/python-beaker.spec SRPM URL: http://www.kylev.com/pylons-rpm/python-beaker-0.9.3-1.fc8.src.rpm Description: Beaker is a caching and web session library. It includes middleware for WSGI, and is a prerequisite for using Pylons. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445020] New: Review Request: python-mako - The Mako template system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=445020 Summary: Review Request: python-mako - The Mako template system Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://www.kylev.com/pylons-rpm/python-mako.spec SRPM URL: http://www.kylev.com/pylons-rpm/python-mako-0.1.10-1.fc8.src.rpm Description: The Mako template library is a simple python templating system, and the default used by Pylons. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445019] New: Review Request: python-decorator - Simplified decorator functions for python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=445019 Summary: Review Request: python-decorator - Simplified decorator functions for python Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://www.kylev.com/pylons-rpm/python-decorator.spec SRPM URL: http://www.kylev.com/pylons-rpm/python-decorator-2.2.0-1.fc8.src.rpm Description: The decorator library simplifies the sometimes-awkward Python decorator syntax with several helpers. It is a prerequisite of Pylons. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445021] New: Review Request: python-routes - A RoR-like routes library for python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=445021 Summary: Review Request: python-routes - A RoR-like routes library for python Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://www.kylev.com/pylons-rpm/python-routes.spec SRPM URL: http://www.kylev.com/pylons-rpm/python-routes-1.8-1.fc8.src.rpm Description: This is a flexible routes implementation for python that eases the task of configuring the direction of URLs to actions in web applications. It is a prerequisite of Pylons. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 438543] Review Request: Synopsis - Source-code introspection tool.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Synopsis - Source-code introspection tool. https://bugzilla.redhat.com/show_bug.cgi?id=438543 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 15:12 EST --- (Umm... currently I don't receive any mails.. Perhaps the mail server of my university is down...??) (In reply to comment #24) The XEROX files aren't actually used my my code Umm? Currently they are used as: - 1201 ar rcs opencxx.a occ/HashTable.o occ/Environment.o occ/TypeInfo.o occ/TypeInfoVisitor.o occ/Walker.o occ/Class.o occ/ClassWalker.o occ/MetaClass.o occ/QuoteClass.o occ/Member.o occ/ClassBodyWalker.o 1202 g++ -shared -o ParserImpl.so syn/swalker.o syn/ast.o syn/builder.o syn/type.o syn/dict.o syn/TypeIdFormatter.o syn/decoder.o syn/lookup.o syn/filter.o syn/Translator.o syn/SXRGenerator.o syn/ParserImpl.o opencxx.a -L/builddir/build/BUILD/synopsis-0.11/build/ctemp.linux-i686/src/lib -lSupport -lSynopsis -- The IDL parser is indeed licensed under GPL, which is the reason why I split this into a separate binary package (synopsis-idl), so it can be distributed under GPL without any impact on the rest being released as LGPL. No problem. the libatomic code is an import, too, and for the fedora binary packages not used (I link to an external libgc). Okay. Well, then is this part okay? Well, I don't know why Synopsis/Parsers/Python/__init__.py is licensed under GPLv2+. I guess you want to release this as LGPLv2+ (the license holder seems you). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444722] Review Request: phplogcon - A syslog data viewer for the web
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: phplogcon - A syslog data viewer for the web
https://bugzilla.redhat.com/show_bug.cgi?id=444722
--- Additional Comments From [EMAIL PROTECTED] 2008-05-02 15:16 EST ---
W:symlink-should-be-relative /usr/share/phplogcon/config.php
/etc/phplogcon/config.php
How can I fix it?
ln -s %{_sysconfdir}/%{name}/config.php
%{buildroot}/%{_datadir}/%{name}/config.php
=
ln -s ../../../%{_sysconfdir}/%{name}/config.php
%{buildroot}/%{_datadir}/%{name}/config.php
phplogcon.noarch: E: zero-length /etc/phplogcon/config.php
It's empty config file, what's the problem?
Why is a empty file needed? Put a comment or something there or remove it.
phplogcon.noarch: E: non-standard-gid /etc/phplogcon apache
phplogcon.noarch: E: non-standard-gid /etc/phplogcon/config.php apache
I have Requires: httpd
Could be ignored.
However
Require: webserver
is more correct than
Require: httpd ?
You are not using dist tags?
Put a README.fedora in %doc to explain how to do the initial setup?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445024] New: Review Request: python-webhelpers - Helper routines for writing web applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=445024 Summary: Review Request: python-webhelpers - Helper routines for writing web applications Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://www.kylev.com/pylons-rpm/python-webhelpers.spec SRPM URL: http://www.kylev.com/pylons-rpm/python-webhelpers-0.3.4-1.fc8.src.rpm Description: Webhelpers is a library of useful and common functions used in generating web pages including HTML generation, escaping, and URL construction. It is a prerequisite of Pylons. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445028] New: Review Request: python-pylons - A python web application toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=445028 Summary: Review Request: python-pylons - A python web application toolkit Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://www.kylev.com/pylons-rpm/python-pylons.spec SRPM URL: http://www.kylev.com/pylons-rpm/python-routes-1.8-1.fc8.src.rpm Description: The Pylons framework is an up-and-coming python kit for developing flexible web applications. It has a structure inspired RoR, allows for the substitution of a variety off different ORMs and templating systems, and is the framework upon which TurboGears2 will be built. http://pylonshq.com/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445027] Review Request: dnrd - A caching, forwarding DNS proxy server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dnrd - A caching, forwarding DNS proxy server https://bugzilla.redhat.com/show_bug.cgi?id=445027 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||177841 nThis|| Summary|Review Request: dnrd - A|Review Request: dnrd - A |caching, forwarding DNS |caching, forwarding DNS |proxy server|proxy server -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445027] New: Review Request: dnrd - A caching, forwarding DNS proxy server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=445027 Summary: Review Request: dnrd - A caching, forwarding DNS proxy server Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://rishi.fedorapeople.org/dnrd.spec SRPM URL: http://rishi.fedorapeople.org/dnrd-2.20.3-1.fc8.src.rpm Description: dnrd is a proxying nameserver. It forwards DNS queries to the appropriate nameserver, but can also act as the primary nameserver for a subnet behind a firewall. It also has features such as caching DNS requests, support for DNS servers, cache poisoning prevention, TCP support, etc.. This is my first package submission and I am seeking a sponsor. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 438543] Review Request: Synopsis - Source-code introspection tool.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Synopsis - Source-code introspection tool. https://bugzilla.redhat.com/show_bug.cgi?id=438543 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 15:21 EST --- Indeed, the XEROX files are all linked in, but the code is never executed. The Python/__init__.py header looks like a typo. I meant to license all my own work under LGPLv2+. I'll submit an appropriate fix. Thanks ! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445018] Review Request: python-beaker - WSGI middleware for sessions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-beaker - WSGI middleware for sessions https://bugzilla.redhat.com/show_bug.cgi?id=445018 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||445028 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445028] Review Request: python-pylons - A python web application toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-pylons - A python web application toolkit https://bugzilla.redhat.com/show_bug.cgi?id=445028 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn||445018, 445019, 445020, ||445021, 445024 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445020] Review Request: python-mako - The Mako template system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-mako - The Mako template system https://bugzilla.redhat.com/show_bug.cgi?id=445020 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||445028 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445021] Review Request: python-routes - A RoR-like routes library for python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-routes - A RoR-like routes library for python https://bugzilla.redhat.com/show_bug.cgi?id=445021 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||445028 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445024] Review Request: python-webhelpers - Helper routines for writing web applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-webhelpers - Helper routines for writing web applications https://bugzilla.redhat.com/show_bug.cgi?id=445024 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||445028 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444792] Review Request: Augeas - library for changing configuration files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Augeas - library for changing configuration files https://bugzilla.redhat.com/show_bug.cgi?id=444792 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 15:38 EST --- Status: OK -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444792] Review Request: Augeas - library for changing configuration files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Augeas - library for changing configuration files https://bugzilla.redhat.com/show_bug.cgi?id=444792 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 15:44 EST --- I have spotted a Requires: readline which is certainly autodetected by rpmbuild. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442353] Review Request: ecore - Event/X abstraction layer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ecore - Event/X abstraction layer https://bugzilla.redhat.com/show_bug.cgi?id=442353 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 16:12 EST --- In the configure output there is Ecore_Evas SDL Support...: no Maybe something is missing from the evas build? I think it would be better to break a bit the BuildRequires line in more lines, and break at 80 columns (if possible). 2 man pages are without prefix, I think it is bad: /usr/share/man/man3/Idle_Group.3.gz /usr/share/man/man3/X_Window_System_Page.3.gz I think it would be better to use rm doc/man/man3/todo.3 such that if tere is no such man page, it is detected. In ecore-x.pc there is an unneeded -L/usr/X11R6/lib, but I don't think it needs to be fixed: it doesn't hurt and it is for static linking which is not possible anyway. None of these issues are blockers. So * rpmlint is silent * follow guidelines * free software, license included * match upstream: a66df2b5f0b1a6abc47bb50bf2b26846 ecore-0.9.9.042.tar.bz2 * library correctly packaged * %files section right APPROVED Please consider my comments before importing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 188445] Review Request: bootconf
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: bootconf
https://bugzilla.redhat.com/show_bug.cgi?id=188445
[EMAIL PROTECTED] changed:
What|Removed |Added
Flag|needinfo?([EMAIL PROTECTED]|
|mta.com)|
--- Additional Comments From [EMAIL PROTECTED] 2008-05-02 16:34 EST ---
Sorry, I was just doing triage on these old tickets, trying to find out whether
the submitters were still interested.
But this seems pretty simple, and most of the comments above seem to have been
addressed. This builds fine on current F9/rawhide; rpmlint is down to:
bootconf.src: W: strange-permission bootconf.spec 0600
I don't particularly care about this as long as it's not 666 or something like
that.
bootconf-gui.noarch: W: no-documentation
bootconf-gui.noarch: W: non-conffile-in-etc /etc/pam.d/bootconf
bootconf-gui.noarch: W: non-conffile-in-etc
/etc/security/console.apps/bootconf
All addressed as OK above.
The specfile still refers to a file which doesn't exist when you look at the
srpm. You have to realize that you need to unpack the tarball and look there
for the license file. I brought the topic on fedora-packaging and nobody else
stated an opinion so I won't block on it though I do think it's suboptimal.
(Honestly there's not much that's copyrightable in a specfile anyway.)
If you're going to use the macro-ized forms of things like %{__make} then you
should use %{__rm} and %{__cat} as well.
There are a couple of issues with the scriptlets. Firstly, for the scriptlets
you have, you need fine-grained dependencies for desktop-file-utils (like
Requires(pre):. However, the desktop-database section of
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets has some explanatory
text about making the scriptlets so that they don't depend on desktop-file-utils
; can you check that page and update accordingly?
I will also say that I understand previous comments about this duplicating
existing functionality, but I don't really have a problem with that. If there
were a hard rule against it, we wouldn't have apt and such in the distro.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442353] Review Request: ecore - Event/X abstraction layer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ecore - Event/X abstraction layer https://bugzilla.redhat.com/show_bug.cgi?id=442353 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 16:39 EST --- I intentionally left out SDL support. For Fedora target audience (desktop and developers) XRender + native OpenGL + DirectFB acceleration backends are enough. Will fix BuildRequires line before importing. Thanks for fast review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442353] Review Request: ecore - Event/X abstraction layer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ecore - Event/X abstraction layer https://bugzilla.redhat.com/show_bug.cgi?id=442353 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 16:41 EST --- New Package CVS Request === Package Name: ecore Short Description: Event/X abstraction layer Owners: stalwart Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 436637] Review Request: disktype - Detect the content format of a disk or disk image
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: disktype - Detect the content format of a disk or disk image https://bugzilla.redhat.com/show_bug.cgi?id=436637 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 17:02 EST --- I've taken the CFLAGS/LDFLAGS changes out of the patch and also added EWF to the man page (in the list of recognised formats). The new spec/SRPM are here: Spec URL: http://richardfearn.co.uk/files/fedora/disktype-9-3/disktype.spec SRPM URL: http://richardfearn.co.uk/files/fedora/disktype-9-3/disktype-9-3.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445036] New: Review Request: vagalume - Last.fm client for GNOME and Maemo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=445036 Summary: Review Request: vagalume - Last.fm client for GNOME and Maemo Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://salimma.fedorapeople.org/for_review/music/vagalume.spec SRPM URL: http://salimma.fedorapeople.org/for_review/music/vagalume-0.5.1-1.fc9.src.rpm Description: **NOTE** vagalume uses GStreamer, so while not usable out-of-the-box without an MP3 decoder, it does not break any Fedora guidelines. Let me know if I should add a README.Fedora stating that users are responsible for finding a way to play MP3 themselves (presumably we could point to the free MP3 codec from Fluendo) Vagalume is a Last.fm client based on Gnome, and specially designed to work in the Maemo platform. Vagalume has the following features: * It plays Last.fm streams using the Last.fm protocol v1.2 * It can play any Last.fm radio: personal, neighbours, loved tracks, or any other arbitrary URL. * It can download free tracks * It implements the Audioscrobbler Realtime Submission Protocol v1.2, specifically: * Now Playing information * Scrobbling of tracks that you listen * Love/Ban ratings * It displays the album cover of the track being played * The user can tag artists, tracks and albums * The user can send recommendations to other users * The user can add tracks to their playlist -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435576] Review Request: ncdu - Text-based disk usage viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ncdu - Text-based disk usage viewer https://bugzilla.redhat.com/show_bug.cgi?id=435576 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 17:20 EST --- New Package CVS Request === Package Name: ncdu Short Description: Text-based disk usage viewer Owners: richardfearn Branches: F-9 InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435623] Review Request: php-pdb - PHP classes for manipulating Palm OS databases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pdb - PHP classes for manipulating Palm OS databases https://bugzilla.redhat.com/show_bug.cgi?id=435623 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 17:21 EST --- New Package CVS Request === Package Name: php-pdb Short Description: PHP classes for manipulating Palm OS databases Owners: richardfearn Branches: F-9 InitialCC: Cvsextras Commits: yes Thanks in advance to the CVS admins! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445036] Review Request: vagalume - Last.fm client for GNOME and Maemo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vagalume - Last.fm client for GNOME and Maemo https://bugzilla.redhat.com/show_bug.cgi?id=445036 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 18:18 EST --- Does this do anything useful when you don't have the codecs? Because, say, amarok can do a lot of that while it's playing ogg tracks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435576] Review Request: ncdu - Text-based disk usage viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ncdu - Text-based disk usage viewer https://bugzilla.redhat.com/show_bug.cgi?id=435576 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 18:23 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435623] Review Request: php-pdb - PHP classes for manipulating Palm OS databases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pdb - PHP classes for manipulating Palm OS databases https://bugzilla.redhat.com/show_bug.cgi?id=435623 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 18:24 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442276] Review Request: evas - Hardware-accelerated state-aware canvas API for X-Windows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: evas - Hardware-accelerated state-aware canvas API for X-Windows https://bugzilla.redhat.com/show_bug.cgi?id=442276 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 18:26 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442353] Review Request: ecore - Event/X abstraction layer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ecore - Event/X abstraction layer https://bugzilla.redhat.com/show_bug.cgi?id=442353 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 18:29 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442022] Review Request: wordwarvi - Side-scrolling shoot 'em up '80s style arcade game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: wordwarvi - Side-scrolling shoot 'em up '80s style arcade game https://bugzilla.redhat.com/show_bug.cgi?id=442022 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 19:37 EST --- Ok, I put v. 0.08 on sourceforge. http://wordwarvi.sourceforge.net -- steve -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 443177] Review Request: html2ps - HTML to PostScript converter
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: html2ps - HTML to PostScript converter
https://bugzilla.redhat.com/show_bug.cgi?id=443177
[EMAIL PROTECTED] changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Additional Comments From [EMAIL PROTECTED] 2008-05-02 22:41 EST ---
Sorry for the delays (again)
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines.
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on: F-8/noarch
[x] Rpmlint output:
source RPM: empty
binary RPM: html2ps.noarch: E: explicit-lib-dependency libpaper
[x] Package is not relocatable.
[x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type: GPLv2+
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
[x] Package is not known to require ExcludeArch
[x] All build dependencies are listed in BuildRequires, except for any that are
listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[x] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[x] Package does not contain any libtool archives (.la).
[x] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS ===
[x] Latest version is packaged.
[x] Package does not include license text files separate from upstream.
[-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: devel/noarch (koji)
[x] Package should compile and build into binary rpms on all supported
architectures.
Tested on:devel/noarch
[x] Package functions as described.
[x] Scriptlets must be sane, if used.
[-] The placement of pkgconfig(.pc) files is correct.
[-] File based requires are sane
*** APPROVED ***
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 443195] Review Request: pAgenda -A cross platform calendar and scheduler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pAgenda -A cross platform calendar and scheduler https://bugzilla.redhat.com/show_bug.cgi?id=443195 --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 22:45 EST --- pAgenda-3.2-2.fc9 has been submitted as an update for Fedora 9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442353] Review Request: ecore - Event/X abstraction layer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ecore - Event/X abstraction layer https://bugzilla.redhat.com/show_bug.cgi?id=442353 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 23:19 EST --- Imported to cvs and built RPMs for f10. Thanks to everyone! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442353] Review Request: ecore - Event/X abstraction layer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ecore - Event/X abstraction layer https://bugzilla.redhat.com/show_bug.cgi?id=442353 Bug 442353 depends on bug 442276, which changed state. Bug 442276 Summary: Review Request: evas - Hardware-accelerated state-aware canvas API for X-Windows https://bugzilla.redhat.com/show_bug.cgi?id=442276 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442276] Review Request: evas - Hardware-accelerated state-aware canvas API for X-Windows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: evas - Hardware-accelerated state-aware canvas API for X-Windows https://bugzilla.redhat.com/show_bug.cgi?id=442276 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2008-05-02 23:18 EST --- Imported to cvs and built RPMs for f10. Thanks to everyone! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442640] Review Request: epeg - Immensely fast JPEG thumbnailer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: epeg - Immensely fast JPEG thumbnailer https://bugzilla.redhat.com/show_bug.cgi?id=442640 Bug 442640 depends on bug 442353, which changed state. Bug 442353 Summary: Review Request: ecore - Event/X abstraction layer https://bugzilla.redhat.com/show_bug.cgi?id=442353 What|Old Value |New Value Status|NEW |ASSIGNED Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442437] Review Request: edje - A graphical layout and animation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: edje - A graphical layout and animation library https://bugzilla.redhat.com/show_bug.cgi?id=442437 Bug 442437 depends on bug 442353, which changed state. Bug 442353 Summary: Review Request: ecore - Event/X abstraction layer https://bugzilla.redhat.com/show_bug.cgi?id=442353 What|Old Value |New Value Status|NEW |ASSIGNED Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442462] Review Request: e_dbus - Wrappers around dbus for EFL based applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: e_dbus - Wrappers around dbus for EFL based applications https://bugzilla.redhat.com/show_bug.cgi?id=442462 Bug 442462 depends on bug 442353, which changed state. Bug 442353 Summary: Review Request: ecore - Event/X abstraction layer https://bugzilla.redhat.com/show_bug.cgi?id=442353 What|Old Value |New Value Status|NEW |ASSIGNED Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442404] Review Request: efreet - An implementation of several specifications from freedesktop.org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: efreet - An implementation of several specifications from freedesktop.org https://bugzilla.redhat.com/show_bug.cgi?id=442404 Bug 442404 depends on bug 442353, which changed state. Bug 442353 Summary: Review Request: ecore - Event/X abstraction layer https://bugzilla.redhat.com/show_bug.cgi?id=442353 What|Old Value |New Value Status|NEW |ASSIGNED Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445036] Review Request: vagalume - Last.fm client for GNOME and Maemo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vagalume - Last.fm client for GNOME and Maemo https://bugzilla.redhat.com/show_bug.cgi?id=445036 --- Additional Comments From [EMAIL PROTECTED] 2008-05-03 00:12 EST --- Could potentially be useful if/when Last.fm serves out files in other formats. Otherwise -- well, it can play any arbitrary lastfm URL, so if someone reimplements the protocol and serves out Ogg Vorbis tracks, Vagalume should handle it just fine. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
