[Bug 454220] Review Request: germanium - a download manager for eMusic.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454220 Adam Huffman [EMAIL PROTECTED] changed: What|Removed |Added Flag|needinfo?([EMAIL PROTECTED] | |m) | --- Comment #33 from Adam Huffman [EMAIL PROTECTED] 2008-09-19 01:59:55 EDT --- I am working on another package, which I'll probably submit over the weekend. Also have a couple of others I plan to work on. Will try to do some pre-reviews this weekend, too. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462357] Review Request: rcsslogplayer - RoboCup Soccer Simulator LogPlayer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462357 Mamoru Tasaka [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #1 from Mamoru Tasaka [EMAIL PROTECTED] 2008-09-19 02:14:10 EDT --- Rebuild failed: http://koji.fedoraproject.org/koji/taskinfo?taskID=832977 Note: You can try to rebuild an arbitrary srpm on koji by the following: $ koji build --scratch target srpm_you_want_try where target can be 'dist-f10', 'dist-f9-updates-candidate', 'dist-f8-updates-candidate' and some specific value. When the build is successful, the rebuilt rpms and some logs are saved about one week under http://koji.fedoraproject.org/scratch/your_FAS_name/task_taskid/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454220] Review Request: germanium - a download manager for eMusic.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454220 --- Comment #34 from Mamoru Tasaka [EMAIL PROTECTED] 2008-09-19 02:18:05 EDT --- Okay, thank you for replying. If you are ready please let me know on this bug. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439772] Review Request: x11vnc - VNC server for the current X11 session
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=439772 Axel Thimm [EMAIL PROTECTED] changed: What|Removed |Added Depends on||439979 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460867] Review Request: perl-ORLite - Extremely light weight SQLite-specific ORM
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460867 --- Comment #8 from Marcela Maslanova [EMAIL PROTECTED] 2008-09-19 03:42:00 EDT --- Please bump the revision and update the changelog whenever changing the spec helps keep things clear. I was always confused why new package has release different from 1. It makes sense to bump release even if don't like it. Also, I note while the changes to %description have been made, there are still explicit requires in the spec causing issues... rpmlint is quite. Which issues? Please fix the explicit provides and update to 0.11. Updated. http://mmaslano.fedorapeople.org/perl-ORLite/perl-ORLite.spec http://mmaslano.fedorapeople.org/perl-ORLite/perl-ORLite-0.11-1.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 451768] Review Request: go-home-applet - applet for gnome
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=451768 Jaroslav Reznik [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #5 from Jaroslav Reznik [EMAIL PROTECTED] 2008-09-19 03:57:20 EDT --- Specified URL doesn't exist (No such resource) and it should be Source0 URL. Project URL is http://www.canonical.com/netbooks. But it seems that Canonical does not publish sources to download. So there is https://launchpad.net/ubuntu/intrepid/+source/go-home-applet/0.1-0ubuntu2/+files/go-home-applet_0.1.orig.tar.gz. We can use this as upstream 0.1 version and then apply attached patches. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454462] Review Request: ksplice - Patching a Linux kernel without reboot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454462 --- Comment #19 from Thomas Moschny [EMAIL PROTECTED] 2008-09-19 04:01:46 EDT --- Sorry again for the delay. There's a new version upstream, 0.9.0, would you like to update your package? The runtime dependency on rsync has been dropped in the new version. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 451768] Review Request: go-home-applet - applet for gnome
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=451768 --- Comment #6 from Jaroslav Reznik [EMAIL PROTECTED] 2008-09-19 04:09:12 EDT --- The same rule apply to other Netbook packages - we may not use Ubuntu vendor specific modifications to source package (ubuntu2 postfix) as it is stated in http://fedoraproject.org/wiki/Packaging/SourceURL. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462357] Review Request: rcsslogplayer - RoboCup Soccer Simulator LogPlayer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462357 --- Comment #2 from Hedayat Vatankhah [EMAIL PROTECTED] 2008-09-19 04:33:49 EDT --- Yes I know, sorry :( The package built successfully on my system using mock and I thought that it's enough (unfortunately AFAIK koji cannot get the package from a URL, and uploading a package is a little annoying with slow internet connection and I try to avoid it as far as possible!). I'll check my packages using koji from now on. Thanks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460867] Review Request: perl-ORLite - Extremely light weight SQLite-specific ORM
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460867 --- Comment #9 from manuel wolfshant [EMAIL PROTECTED] 2008-09-19 05:39:46 EDT --- Marcela: I bet Chris is speaking about Requires: perl(DBD::SQLite) = 1.14 Requires: perl(DBI) = 1.58 rpmbuild should pick these automatically. Generally speaking, Requires lines should be added only when rpmbuild does not lead to the explicitely results by itself. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456337] Review Request: NetBeans 6.1 - Integrated Development Environment (IDE)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456337 --- Comment #17 from Victor G. Vasilyev [EMAIL PROTECTED] 2008-09-19 05:46:31 EDT --- Hello Milos, Our original plan considers only F10 as a target release for NetBeans. We need complete this plan before any next steps, including updates. The NetBeans packages have been completely prepared on F9, so, I think, they will work properly on F9 if all *_fc10 packages, including required ones (see http://wiki.netbeans.org/Fedora10PackagingNBStatus ), will be installed from the rawhide repo on F9 platform via yum. However, I'm not sure about F8. Milos, your comments/ideas/help in this area will be very much appreciated. You can use [EMAIL PROTECTED] to discuss it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462835] New: Review Request: perl-Math-Calc-Units - Math-Calc-Units - Human-readable unit-aware calculator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-Math-Calc-Units - Math-Calc-Units - Human-readable unit-aware calculator https://bugzilla.redhat.com/show_bug.cgi?id=462835 Summary: Review Request: perl-Math-Calc-Units - Math-Calc-Units - Human-readable unit-aware calculator Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: [EMAIL PROTECTED], fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://amorsen.dk/fedora/perl-Math-Calc-Units.spec SRPM URL: http://amorsen.dk/fedora/perl-Math-Calc-Units-1.06-1.src.rpm Description: CMath::Calc::Units is a simple calculator that keeps track of units. It currently handles combinations of byte sizes and duration only, although adding any other multiplicative types is easy. Any unknown type is treated as a unique user type (with some effort to map English plurals to their singular forms). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460867] Review Request: perl-ORLite - Extremely light weight SQLite-specific ORM
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460867 --- Comment #10 from manuel wolfshant [EMAIL PROTECTED] 2008-09-19 06:04:19 EDT --- Scrap the last phrase, it contains a pasted word from another context. I wanted to say: Generally speaking, Requires lines should be added only when rpmbuild does not lead to the correct results by itself. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462835] Review Request: perl-Math-Calc-Units - Human-readable unit-aware calculator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462835 manuel wolfshant [EMAIL PROTECTED] changed: What|Removed |Added Summary|Review Request: |Review Request: |perl-Math-Calc-Units -|perl-Math-Calc-Units - |Math-Calc-Units - |Human-readable unit-aware |Human-readable unit-aware |calculator |calculator | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456337] Review Request: NetBeans 6.1 - Integrated Development Environment (IDE)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456337 --- Comment #18 from Victor G. Vasilyev [EMAIL PROTECTED] 2008-09-19 06:23:01 EDT --- FYI http://wiki.netbeans.org/FedoraPackagingNBWishList -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454215] Review Request: stk - Synthesis ToolKit in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454215 --- Comment #21 from Fedora Update System [EMAIL PROTECTED] 2008-09-19 06:39:53 EDT --- stk-4.3.1-6.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/stk-4.3.1-6.fc8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454215] Review Request: stk - Synthesis ToolKit in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454215 --- Comment #22 from Fedora Update System [EMAIL PROTECTED] 2008-09-19 06:41:07 EDT --- stk-4.3.1-6.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/stk-4.3.1-6.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452427] Review Request: awesome - Extremely fast, small, dynamic and awesome floating and tiling window manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452427 --- Comment #35 from Michal Nowak [EMAIL PROTECTED] 2008-09-19 06:50:17 EDT --- * Fri Sep 19 2008 Michal Nowak [EMAIL PROTECTED] 3.0-1 - bump to 3.0 assam SPECS # rpmlint awesome.spec /usr/src/redhat/SRPMS/awesome-3.0-1.fc9.src.rpm /usr/src/redhat/RPMS/i386/awesome-3.0-1.fc9.i386.rpm /usr/src/redhat/RPMS/i386/awesome-doc-3.0-1.fc9.i386.rpm /usr/src/redhat/RPMS/i386/awesome-debuginfo-3.0-1.fc9.i386.rpm awesome.i386: E: file-in-usr-marked-as-conffile /usr/share/awesome/themes/default 4 packages and 1 specfiles checked; 1 errors, 0 warnings. http://mnowak.fedorapeople.org/awesome/awesome.spec http://mnowak.fedorapeople.org/awesome/awesome-3.0-1.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226322] Merge Review: psmisc
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226322 --- Comment #6 from Daniel Novotny [EMAIL PROTECTED] 2008-09-19 06:55:13 EDT --- Jon, I am the new maintainer of psmisc. You can take the ownership and complete the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458784] Review Request: xcb-util - The xcb-util module provides a number of libraries which sit on top of libxcb
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458784 --- Comment #5 from Michal Nowak [EMAIL PROTECTED] 2008-09-19 06:47:05 EDT --- Updated to v 0.3.0: http://mnowak.fedorapeople.org/xcb-util/xcb-util.spec http://mnowak.fedorapeople.org/xcb-util/xcb-util-0.3.0-1.fc9.src.rpm (necessary for bug 452427) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460867] Review Request: perl-ORLite - Extremely light weight SQLite-specific ORM
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460867 --- Comment #11 from Marcela Maslanova [EMAIL PROTECTED] 2008-09-19 07:03:43 EDT --- http://mmaslano.fedorapeople.org/perl-ORLite/perl-ORLite.spec http://mmaslano.fedorapeople.org/perl-ORLite/perl-ORLite-0.11-2.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454462] Review Request: ksplice - Patching a Linux kernel without reboot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454462 --- Comment #20 from Thomas Moschny [EMAIL PROTECTED] 2008-09-19 07:34:08 EDT --- Just an additional note: There is a patent application by MS that could be related, see http://article.gmane.org/gmane.linux.kernel/670282, and author's reply http://article.gmane.org/gmane.linux.kernel/673351. But as it is only an application (yet), it shouldn't affect us, I guess. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456190] Review Request: dosemu - dos emulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456190 --- Comment #10 from Justin Zygmont [EMAIL PROTECTED] 2008-09-19 07:59:35 EDT --- Thanks a lot, your help went a long ways. I have fixed everything you listed, and here is the output of rpmlint: # rpmlint -i dosemu-1.4.0-1868svn.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. # rpmlint -i dosemu-1.4.0-1868svn.i386.rpm dosemu.i386: W: symlink-should-be-relative /etc/dosemu/drives/d /usr/share/dosemu/drive_z Absolute symlinks are problematic eg. when working with chroot environments. dosemu.i386: W: file-not-utf8 /usr/share/man/ru/man1/dosemu.1.gz The character encoding of this file is not UTF-8. Consider converting it in the specfile for example using iconv(1). dosemu.i386: W: symlink-should-be-relative /etc/dosemu/drives/c /usr/share/dosemu/drive_z Absolute symlinks are problematic eg. when working with chroot environments. dosemu.i386: W: file-not-utf8 /usr/share/doc/dosemu-1.4.0/COPYING.DOSEMU The character encoding of this file is not UTF-8. Consider converting it in the specfile for example using iconv(1). dosemu.i386: W: file-not-utf8 /usr/share/man/ru/man1/mkfatimage16.1.gz The character encoding of this file is not UTF-8. Consider converting it in the specfile for example using iconv(1). dosemu.i386: W: dangling-symlink /usr/share/dosemu/drive_z/tmp /tmp The symbolic link points nowhere. dosemu.i386: W: symlink-should-be-relative /usr/share/dosemu/drive_z/tmp /tmp Absolute symlinks are problematic eg. when working with chroot environments. dosemu.i386: W: file-not-utf8 /usr/share/man/ru/man1/dosemu.bin.1.gz The character encoding of this file is not UTF-8. Consider converting it in the specfile for example using iconv(1). 1 packages and 0 specfiles checked; 0 errors, 8 warnings. As well my updated spec file and rpms are here: http://fedorapeople.org/~jzygmont/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447844] Review Request: krazy2 - KDE code checking tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447844 --- Comment #15 from Ben Boeckel [EMAIL PROTECTED] 2008-09-19 08:26:46 EDT --- (In reply to comment #14) * One issue - Requires: desktop-file-utils is not needed. Actually, it is. Krazy uses desktop-file-validate (it has 0.14 upstream, 0.15 is in Fedora, so I went with that). Should I comment that in the spec file? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462357] Review Request: rcsslogplayer - RoboCup Soccer Simulator LogPlayer
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462357
--- Comment #3 from Mamoru Tasaka [EMAIL PROTECTED] 2008-09-19 08:17:27 EDT
---
%configure --with-qt4-moc=%{_bindir}/moc-qt4 seems happy:
http://koji.fedoraproject.org/koji/taskinfo?taskID=833207
I will check this later.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456190] Review Request: dosemu - dos emulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456190 --- Comment #11 from Rakesh Pandit [EMAIL PROTECTED] 2008-09-19 08:32:30 EDT --- Reverted fedora-review flag @Justin - you are not supposed to change flag. When some sponsor comes for review he will first set it to '?' once official review starts. Once it is complete then it is marked as '+' Thanks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450371] Review Request: sigen - Strategy/RPG game engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450371 --- Comment #48 from Ben Boeckel [EMAIL PROTECTED] 2008-09-19 08:32:17 EDT --- (In reply to comment #47) I found your account on FAS (Fedora Account System), however it seems that your FAS mail account differs from that you use on this bugzilla. Please fix either of them, then I will sponsor you. They differ by case. FAS and BZ says an email address already exists when I try to change either one of them (BZ used all lower case when I joined IIRC; I'd have used the correct case if I could). If they need to match 100%, where can I request that the already-exists error be overridden? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226322] Merge Review: psmisc
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226322 Jon Ciesla [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] --- Comment #7 from Jon Ciesla [EMAIL PROTECTED] 2008-09-19 08:35:31 EDT --- Excellent. I'll get right on it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226322] Merge Review: psmisc
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226322 --- Comment #8 from Jon Ciesla [EMAIL PROTECTED] 2008-09-19 09:00:44 EDT --- Full review is stellar. One think I might ask, and it's not worth a rebuild, but could you comment in the spec on the purpose and upstream status of the patches? Just got added to the Guidelines and I think it's a good practice. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447844] Review Request: krazy2 - KDE code checking tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447844 --- Comment #16 from Mamoru Tasaka [EMAIL PROTECTED] 2008-09-19 09:06:25 EDT --- (In reply to comment #15) (In reply to comment #14) * One issue - Requires: desktop-file-utils is not needed. Actually, it is. Krazy uses desktop-file-validate (it has 0.14 upstream, 0.15 is in Fedora, so I went with that). Should I comment that in the spec file? Ah, okay. Then I recommend to write in a spec file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450371] Review Request: sigen - Strategy/RPG game engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450371 --- Comment #49 from Ben Boeckel [EMAIL PROTECTED] 2008-09-19 09:23:55 EDT --- Nevermind, used an intermediate email address. FAS is now all lower case. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456190] Review Request: dosemu - dos emulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456190 --- Comment #12 from Andrea Musuruane [EMAIL PROTECTED] 2008-09-19 09:26:08 EDT --- (In reply to comment #10) Thanks a lot, your help went a long ways. I have fixed everything you listed, and here is the output of rpmlint: You are welcome. Since rpmlint output is not clean, you still have some work to do. Please go on and fix those errors. You might find help here: https://fedoraproject.org/wiki/PackageMaintainers/Common_Rpmlint_Issues -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226204] Merge Review: nss
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226204 Jon Ciesla [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #1 from Jon Ciesla [EMAIL PROTECTED] 2008-09-19 09:44:45 EDT --- My local build hangs in a loop during the ssl tests: Running tests for ssl TIMESTAMP ssl BEGIN: Fri Sep 19 08:41:25 CDT 2008 ssl.sh: SSL tests === ssl.sh: CRL SSL Client Tests === ssl.sh: TLS Request don't require client auth (client does not provide auth) selfserv_9400 starting at Fri Sep 19 08:41:25 CDT 2008 selfserv_9400 -D -p 9400 -d ../server -n localhost.localdomain \ -w nss -r -i ../tests_pid.17210 trying to connect to selfserv_9400 at Fri Sep 19 08:41:26 CDT 2008 tstclnt -p 9400 -h localhost.localdomain -q \ -d ../client /home/limb/rpmbuild/BUILD/nss-3.12.1.1/mozilla/security/nss/tests/ssl/sslreq.dat tstclnt: Client timed out while waiting for connection to server: TCP connection reset by peer. retrying to connect to selfserv_9400 at Fri Sep 19 08:42:32 CDT 2008 tstclnt -p 9400 -h localhost.localdomain -q \ -d ../client /home/limb/rpmbuild/BUILD/nss-3.12.1.1/mozilla/security/nss/tests/ssl/sslreq.dat tstclnt: Client timed out while waiting for connection to server: TCP connection reset by peer. ssl.sh: #282: Waiting for Server - FAILED kill -0 28287 /dev/null 2/dev/null selfserv_9400 with PID 28287 found at Fri Sep 19 08:43:33 CDT 2008 selfserv_9400 with PID 28287 started at Fri Sep 19 08:43:33 CDT 2008 tstclnt -p 9400 -h localhost.localdomain -f -d ../client \ -w nss -n none /home/limb/rpmbuild/BUILD/nss-3.12.1.1/mozilla/security/nss/tests/ssl/sslreq.dat tstclnt: unable to connect (poll): Connection refused by peer. ssl.sh: #283: TLS Request don't require client auth (client does not provide auth) (cert TestUser40 - revoked) produced a returncode of 1, expected is 0 - FAILED trying to kill selfserv_9400 with PID 28287 at Fri Sep 19 08:43:34 CDT 2008 kill -USR1 28287 selfserv: 0 cache hits; 0 cache misses, 0 cache not reusable 0 stateless resumes, 0 ticket parse failures selfserv: normal termination selfserv_9400 -b -p 9400 2/dev/null; selfserv_9400 with PID 28287 killed at Fri Sep 19 08:43:34 CDT 2008 ssl.sh: TLS Request don't require client auth (client does not provide auth) selfserv_9400 starting at Fri Sep 19 08:43:35 CDT 2008 selfserv_9400 -D -p 9400 -d ../server -n localhost.localdomain \ -w nss -r -i ../tests_pid.17210 trying to connect to selfserv_9400 at Fri Sep 19 08:43:35 CDT 2008 tstclnt -p 9400 -h localhost.localdomain -q \ -d ../client /home/limb/rpmbuild/BUILD/nss-3.12.1.1/mozilla/security/nss/tests/ssl/sslreq.dat -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450371] Review Request: sigen - Strategy/RPG game engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450371 Mamoru Tasaka [EMAIL PROTECTED] changed: What|Removed |Added Blocks|177841 | --- Comment #50 from Mamoru Tasaka [EMAIL PROTECTED] 2008-09-19 09:46:57 EDT --- Okay now I am sponsoring you. Please follow Join wiki again. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447844] Review Request: krazy2 - KDE code checking tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447844 Mamoru Tasaka [EMAIL PROTECTED] changed: What|Removed |Added Blocks|177841 | --- Comment #17 from Mamoru Tasaka [EMAIL PROTECTED] 2008-09-19 09:47:26 EDT --- (Now I am sponsoring the submitter) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 451773] Review Request: window-picker-applet - an alternative window chooser for small screens
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=451773 --- Comment #4 from Tim Lauridsen [EMAIL PROTECTED] 2008-09-19 10:09:02 EDT --- forgot the URL https://launchpad.net/netbook-remix is the closest to and upstream homepage. and Source0 shall point to http://launchpadlibrarian.net/14942872/window-picker-applet_%(version).tar.gz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 451773] Review Request: window-picker-applet - an alternative window chooser for small screens
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=451773 Tim Lauridsen [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] ||m AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] ||m --- Comment #3 from Tim Lauridsen [EMAIL PROTECTED] 2008-09-19 10:03:58 EDT --- I will review this one: Initial comments: Requires and BuildRequires are missing libpanelapplet-2.0 gtk+-2.0 gconf-2.0 libwnck-1.0 and maybe others URL should point to upstream home page not to source URL should be Source0: http://launchpadlibrarian.net/14942872/window-picker-applet_%(version).tar.gz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447844] Review Request: krazy2 - KDE code checking tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447844 --- Comment #18 from Ben Boeckel [EMAIL PROTECTED] 2008-09-19 10:21:27 EDT --- New Package CVS Request === Package Name: krazy2 Short Description: KDE code checking tool Owners: mathstuf Branches: F-8 F-9 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450371] Review Request: sigen - Strategy/RPG game engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450371 --- Comment #51 from Ben Boeckel [EMAIL PROTECTED] 2008-09-19 10:21:30 EDT --- New Package CVS Request === Package Name: sigen Short Description: Strategy/RPG game engine Owners: mathstuf Branches: F-8 F-9 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 433398] Review Request: synbak - Synbak Universal Backup System (first package, need sponsor)
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=433398
Jon Ciesla [EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||[EMAIL PROTECTED]
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
--- Comment #3 from Jon Ciesla [EMAIL PROTECTED] 2008-09-19 10:31:23 EDT ---
Official review. I am also willing to sponsor you, once this package is
approved. To that end, have you done any unoffical reviews of other's
packages? If so, please post links. If not, do a few, and post links.
- MUST: rpmlint must be run on every package. The output should be posted in
the review.
Clean.
- MUST: The package must be named according to the Package Naming Guidelines .
Good.
- MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption on Package Naming Guidelines
.
Good.
- MUST: The package must meet the Packaging Guidelines .
Good.
- MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
Good.
- MUST: The License field in the package spec file must match the actual
license.
License tag should be GPLv2+ and CC-BY-SA.
- MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
Good.
- MUST: The spec file must be written in American English.
Good.
- MUST: The spec file for the package MUST be legible. If the reviewer is
unable to read the spec file, it will be impossible to perform a review. Fedora
is not the place for entries into the Obfuscated Code Contest
(http://www.ioccc.org/).
Good. Might want to limit the description to the first 7 lines. Your call.
- MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
Good.
- MUST: The package must successfully compile and build into binary rpms on at
least one supported architecture.
Good.
- MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch needs to have a bug filed
in bugzilla, describing the reason that the package does not compile/build/work
on that architecture. The bug number should then be placed in a comment, next
to the corresponding ExcludeArch line. New packages will not have bugzilla
entries during the review process, so they should put this description in the
comment until the package is approved, then file the bugzilla entry, and
replace the long explanation with the bug number. The bug should be marked as
blocking one (or more) of the following bugs to simplify tracking such issues:
FE-ExcludeArch-x86 , FE-ExcludeArch-x64 , FE-ExcludeArch-ppc ,
FE-ExcludeArch-ppc64
NA, noarch.
- MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
Good.
- MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
Good.
- MUST: Every binary RPM package which stores shared library files (not just
symlinks) in any of the dynamic linker's default paths, must call ldconfig in
%post and %postun. If the package has multiple subpackages with libraries, each
subpackage should also have a %post/%postun section that calls /sbin/ldconfig.
An example of the correct syntax for this is:
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
NA.
- MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
NA.
- MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory. Refer to the Guidelines for examples.
Good.
- MUST: A package must not contain any duplicate files in the %files listing.
Good.
- MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
Good.
- MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} ( or $RPM_BUILD_ROOT ).
Good.
- MUST:
[Bug 451772] Review Request: ume-launcher - a full screen application launcher for gnome
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=451772
Tim Lauridsen [EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
||m
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
||m
--- Comment #3 from Tim Lauridsen [EMAIL PROTECTED] 2008-09-19 10:47:09 EDT
---
i will review this one:
URL sould point to https://launchpad.net/netbook-remix
(in top of spec)
%define mayor_ver 0.5
%define minor_ver 18
Version: %{mayor_ver}.{minor_ver}
Source0:
http://launchpadlibrarian.net/14969174/ume-launcher_%{mayor_ver}ubuntu%{minor_ver}.tar.gz
i think the .desktop should be installed using desktop-file-install
https://fedoraproject.org/wiki/Packaging/Guidelines#desktop
BuildRequires/Requires is missing deps
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458054] Review Request: arm4 - Application Response Measurement (ARM) agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458054 Jon Ciesla [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED CC||[EMAIL PROTECTED] AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] --- Comment #1 from Jon Ciesla [EMAIL PROTECTED] 2008-09-19 11:01:48 EDT --- Hi, I'll do a full review, and can sponsor you once this is approved. Also, I'd like to see some unofficial reviews of others' packages. Post links here. To begin with, rpmlint on SRPM: arm4.i386: W: devel-file-in-non-devel-package /usr/lib/libarm4.so A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. arm4.i386: W: devel-file-in-non-devel-package /usr/lib/libarm4_null.so A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. Probably ok. arm4.i386: W: non-standard-uid /var/arm4 arm4 A file in this package is owned by a non standard user. Standard users are: root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator, games, gopher, ftp, nobody. arm4.i386: W: non-standard-gid /var/arm4 arm4 A file in this package is owned by a non standard group. Standard groups are: root, bin, daemon, sys, adm, tty, disk, lp, mem, kmem, wheel, mail, news, uucp, man, games, gopher, dip, ftp, lock, nobody, users. Ok. But might this not be better placed in /var/lib? What is this dir for? arm4.i386: W: no-reload-entry /etc/rc.d/init.d/arm4 In your init script (/etc/rc.d/init.d/your_file), you don't have a 'reload' entry, which is necessary for good functionality. Fix. If the daemon doesn't support this, just duplicate the restart entry. arm4-devel.i386: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. Fix. arm4-java.i386: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. Fix. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 451768] Review Request: go-home-applet - applet for gnome
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=451768 --- Comment #7 from Jonathan Roberts [EMAIL PROTECTED] 2008-09-19 11:14:28 EDT --- I've been in touch with upstream, and there's a new release tarball due out next week so I'll wait before updating these packages until then. Also, upstream has said that they'll try and make more regular, formal releases to make our lives a little easier. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 451772] Review Request: ume-launcher - a full screen application launcher for gnome
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=451772 --- Comment #4 from Jonathan Roberts [EMAIL PROTECTED] 2008-09-19 11:16:07 EDT --- I've spoken to upstream and new source tarballs are due out next week, so I'll hold on making these fixes and changing the source details until then. They've also committed to making more regular releases that will be better to use. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 451773] Review Request: window-picker-applet - an alternative window chooser for small screens
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=451773 --- Comment #5 from Jonathan Roberts [EMAIL PROTECTED] 2008-09-19 11:16:18 EDT --- I've spoken to upstream and new source tarballs are due out next week, so I'll hold on making these fixes and changing the source details until then. They've also committed to making more regular releases that will be better to use. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460885] Review Request: netdude - a libpcap trace file manipulation tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460885 Jon Ciesla [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED CC||[EMAIL PROTECTED] AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] --- Comment #1 from Jon Ciesla [EMAIL PROTECTED] 2008-09-19 11:15:42 EDT --- Hi, I can sponsor you once this is approved, and will do a full review. To that then, please complete a few unofficial reviews, and post links here. In the mean time, my attempt to build this fails: snip make[2]: Entering directory `/home/limb/rpmbuild/BUILD/netdude-0.5.0/src' gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../libltdl -I../src -I/usr/include/gtk-1.2 -I/usr/include/glib-1.2 -I/usr/lib/glib/include -DLIBNETDUDE_CFLAGS=\\ -DGTK_CFLAGS=\-I/usr/include/gtk-1.2 -I/usr/include/glib-1.2 -I/usr/lib/glib/include\ -W -Wall -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -MT nd_debug.o -MD -MP -MF .deps/nd_debug.Tpo -c -o nd_debug.o nd_debug.c In file included from nd_debug.c:29: ./nd.h:32:19: error: libnd.h: No such file or directory make[2]: *** [nd_debug.o] Error 1 make[2]: Leaving directory `/home/limb/rpmbuild/BUILD/netdude-0.5.0/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/limb/rpmbuild/BUILD/netdude-0.5.0' make: *** [all] Error 2 error: Bad exit status from /var/tmp/rpm-tmp.55618 (%build) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.55618 (%build) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460885] Review Request: netdude - a libpcap trace file manipulation tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460885 --- Comment #2 from Jon Ciesla [EMAIL PROTECTED] 2008-09-19 11:18:30 EDT --- Leave it to me to miss the blocker bug. . .facepalm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460886] Review Request: libnetdude - a libpcap trace file manipulation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460886 Jon Ciesla [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #2 from Jon Ciesla [EMAIL PROTECTED] 2008-09-19 11:22:55 EDT --- Fabian, I can sponsor Christian once you complete the full review. If you like I can just do the review as well. I'll be doing the review this blocks, just want to avoid treading on toes. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Philip Prindeville [EMAIL PROTECTED] changed: What|Removed |Added Attachment #315605|0 |1 is obsolete|| --- Comment #37 from Philip Prindeville [EMAIL PROTECTED] 2008-09-19 11:30:18 EDT --- Created an attachment (id=317204) -- (https://bugzilla.redhat.com/attachment.cgi?id=317204) Replacement .spec file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Philip Prindeville [EMAIL PROTECTED] changed: What|Removed |Added Attachment #315606|0 |1 is obsolete|| --- Comment #38 from Philip Prindeville [EMAIL PROTECTED] 2008-09-19 11:31:08 EDT --- Created an attachment (id=317205) -- (https://bugzilla.redhat.com/attachment.cgi?id=317205) Replacement .src.rpm file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 --- Comment #39 from Joe Orton [EMAIL PROTECTED] 2008-09-19 11:42:35 EDT --- You lost BuildRequires: libxml2-devel httpd-devel somewhere along the way - if that was a result of my comments about losing the Requires, my apologies. The LoadModule for the module should be uncommented by default; i.e. the module should be loaded by default, when installed. If someone doesn't want the module loaded, they can remove the package :) Other than that, this looks great, thanks for persevering! I'm not an Official Sponsor so I can't do the formal review unfortunately. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462357] Review Request: rcsslogplayer - RoboCup Soccer Simulator LogPlayer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462357 --- Comment #4 from Hedayat Vatankhah [EMAIL PROTECTED] 2008-09-19 11:49:01 EDT --- Thanks :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Philip Prindeville [EMAIL PROTECTED] changed: What|Removed |Added Attachment #317204|0 |1 is obsolete|| --- Comment #40 from Philip Prindeville [EMAIL PROTECTED] 2008-09-19 11:58:54 EDT --- Created an attachment (id=317207) -- (https://bugzilla.redhat.com/attachment.cgi?id=317207) Replacement .spec file Put back BuildRequires: as before. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462357] Review Request: rcsslogplayer - RoboCup Soccer Simulator LogPlayer
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462357
Mamoru Tasaka [EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
--- Comment #5 from Mamoru Tasaka [EMAIL PROTECTED] 2008-09-19 12:00:59 EDT
---
For 12.1.1-1:
* License tag
- Your license analysis is correct.
Then, you use License: LGPLv2+ and GPLv2+ as license tag.
This tag is inherited by all subpackages
(i.e. rpm -qi rcsslogplayer-devel shows this license tag).
So you have to write explicitly License: LGPLv2+ in
-devel subpackage.
* Build Failure
- As said above, please use
--
%configure --with-qt4-moc=%{_bindir}/moc-qt4
--
to fix build failure (successful build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=833207 )
* Desktop file
--
1572 + desktop-file-install --vendor=fedora
--dir=/builddir/build/BUILDROOT/rcsslogplayer-12.1.1-1.1.fc10.i386//usr/share/applications
/builddir/build/SOURCES/rcsslogplayer.desktop
1573 /builddir/build/SOURCES/rcsslogplayer.desktop: key Categories is a
list and does not have a semicolon as trailing character, fixing
--
- The category should be:
--
Categories=Education;Science;Robotics;
--
+ build successful with modification
+ spec description good
+ tarball matches upstream
+ can be installed
+ seems to work
--
This package (rcsslogplayer) is APPROVED by mtasaka
--
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452636] Review Request: mod_proxy_html - Module to rewrite content as it passes through an apache proxy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452636 Philip Prindeville [EMAIL PROTECTED] changed: What|Removed |Added Attachment #317205|0 |1 is obsolete|| --- Comment #41 from Philip Prindeville [EMAIL PROTECTED] 2008-09-19 12:02:20 EDT --- Created an attachment (id=317209) -- (https://bugzilla.redhat.com/attachment.cgi?id=317209) Replacement .src.rpm file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458054] Review Request: arm4 - Application Response Measurement (ARM) agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458054 --- Comment #2 from David Carter [EMAIL PROTECTED] 2008-09-19 12:51:52 EDT --- Thanks for the review. I'm already in the midst of preparing an updated version, and most of your comments have already been incorporated. I need some advice from the selinux guys before the directory setup is complete, as some temp files may have to move out of temp, so it may be a couple of days before I get an updated version ready for review. Some comments... arm4.i386: W: devel-file-in-non-devel-package /usr/lib/libarm4.so A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. arm4.i386: W: devel-file-in-non-devel-package /usr/lib/libarm4_null.so A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. These are needed in the non-devel versions, as many ARM programs are designed to dynamically link against these libraries. An example is the apache mod_arm4 module, which I'll be packaging as soon as I get the selinux issues worked out :) I've moved the offending directories from /var/arm4 to /var/lib/arm4. There is documentation for the devel and java packages that will be included. I'm updating the start up file as you requested. Finally, if you're reviewing this, you may want to consider reviewing 458279 which is a python module related to this. Thanks for your efforts! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458054] Review Request: arm4 - Application Response Measurement (ARM) agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458054 --- Comment #3 from Jon Ciesla [EMAIL PROTECTED] 2008-09-19 13:14:35 EDT --- Sounds good. I'll watch this space for updates. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460886] Review Request: libnetdude - a libpcap trace file manipulation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460886 --- Comment #3 from [EMAIL PROTECTED] 2008-09-19 13:25:52 EDT --- Hi guys, thanks for the sponsor offer and the RPM suggestions. I'll address them asap and post an update when complete. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460885] Review Request: netdude - a libpcap trace file manipulation tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460885 --- Comment #3 from [EMAIL PROTECTED] 2008-09-19 13:26:11 EDT --- Hi guys -- many thanks for your responses. Jon, you need libnetdude installed before you can build Netdude. See https://bugzilla.redhat.com/show_bug.cgi?id=460886 . -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462074] Review Request: gnome-applet-jalali-calendar - Jalali calendar panel applet for GNOME
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462074
Mamoru Tasaka [EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
--- Comment #1 from Mamoru Tasaka [EMAIL PROTECTED] 2008-09-19 14:28:23 EDT
---
Well, for 1.6.5-1:
* %{_libdir} in noarch package
.src:40: W: libdir-macro-in-noarch-package %{_libdir}/bonobo/servers/*
- The explanation of this is shown by
$ rpmlint -I libdir-macro-in-noarch-package . Generally
this warning means that
* If you rebuild this on i386, some files are installed under
/usr/lib
* On x86_64, they are put under /usr/lib64
* However as this package is marked as _noarch_, the result
binary rpm should be the same regardless of the architecture used
when rebuilding
So for noarch packages macros like %_libdir or %_lib should not
be used. For the case of this package AFAIK even on 64 arch
bonobo server picks up server files under %_prefix/lib (see:
https://bugzilla.redhat.com/show_bug.cgi?id=426149#c3 )
* python related dependency
- Please examine python module related dependencies for this package
and add them as Requires.
! Example:
/usr/share/jalali-calendar/jcalendar.py contains the line:
-
25 import pygtk
26 pygtk.require('2.0')
-
This means that this package should have Requires: pygtk2.
Note that such python related dependencies are not detected
automatically by rpmbuild. To find out these dependencies, I usually
try like below:
-
$ grep -h 'import ' /usr/share/jalali-calendar/*py | sort | uniq
from gtk import gdk
from string import strip, lower
from xml.dom.minidom import getDOMImplementation, parse
from xml.parsers.expat import ExpatError
import birthdaydialog
import cairo
...
---
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462580] Review Request: wstx - Woodstox Stax Implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462580 John Guthrie [EMAIL PROTECTED] changed: What|Removed |Added Blocks||462923 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462923] Review Request: jibx - Framework for binding XML data to Java objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462923 John Guthrie [EMAIL PROTECTED] changed: What|Removed |Added Depends on||462560, 462580 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462560] Review Request: xmlpull-api - XmlPull v1 API is a simple to use XML pull parsing API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462560 John Guthrie [EMAIL PROTECTED] changed: What|Removed |Added Blocks||462923 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462074] Review Request: gnome-applet-jalali-calendar - Jalali calendar panel applet for GNOME
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462074
--- Comment #2 from Mamoru Tasaka [EMAIL PROTECTED] 2008-09-19 14:32:49 EDT
---
One more issue
* python bytecompiling (BR: python)
- If python is installed when rebuilding, all python files in this packages
are
bytecompile'd and some .py{c,o} files are also packaged (this is normal)
However with koji build python is not installed by default so bytecompiling
cannot be done.
Please add BuildRequires: python (for python bytecompiling)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462923] New: Review Request: jibx - Framework for binding XML data to Java objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: jibx - Framework for binding XML data to Java objects https://bugzilla.redhat.com/show_bug.cgi?id=462923 Summary: Review Request: jibx - Framework for binding XML data to Java objects Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: [EMAIL PROTECTED], fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://www.guthrie.info/RPMS/f9/jibx.spec SRPM URL: http://www.guthrie.info/RPMS/f9/jibx-1.1.6a-1.fc9.src.rpm Description: JiBX is a framework for binding XML data to Java objects. It lets you work with data from XML documents using your own class structures. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462923] Review Request: jibx - Framework for binding XML data to Java objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462923 --- Comment #1 from John Guthrie [EMAIL PROTECTED] 2008-09-19 14:37:00 EDT --- This package has xmlpull-api and wstx as dependencies. I have indicated that with links to the package review bugs above. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 246525] Review Request: libMini - A high-performance terrain rendering library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=246525 --- Comment #21 from Rick L Vinyard Jr [EMAIL PROTECTED] 2008-09-19 15:43:44 EDT --- I think this covers everything except the missing gl.pc and glu.pc workaround. http://miskatonic.cs.nmsu.edu/pub/libMini-8.8.8-0.1.1091svn.fc9.src.rpm http://miskatonic.cs.nmsu.edu/pub/libMini.spec - Changed mesa-libGL-devel and mesa-libGLU-devel to libGL-devel and libGLU-devel - Changed name back to libMini - Changed release to 8.8.8 pre-release and used specific svn release number - Added 0 to release tag to ensure upgrade path to 8.8.8 - Removed previous patches for new release - Added Mini.pc.in patch to remove -DNOSQUISH flag - Added Makefile.am patch to add -lMini to compilation of libMiniSFX - Added line to remove unused-direct-shlib-dependency warning -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462932] Review Request: echomine-muse - Java API for XMPP/Jabber
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462932 John Guthrie [EMAIL PROTECTED] changed: What|Removed |Added Depends on||462560 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462560] Review Request: xmlpull-api - XmlPull v1 API is a simple to use XML pull parsing API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462560 John Guthrie [EMAIL PROTECTED] changed: What|Removed |Added Blocks||462932 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462932] New: Review Request: echomine-muse - Java API for XMPP/Jabber
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: echomine-muse - Java API for XMPP/Jabber https://bugzilla.redhat.com/show_bug.cgi?id=462932 Summary: Review Request: echomine-muse - Java API for XMPP/Jabber Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: [EMAIL PROTECTED], fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://www.guthrie.info/RPMS/f9/echomine-muse.spec SRPM URL: http://www.guthrie.info/RPMS/f9/echomine-muse-0.81-3.fc9.src.rpm Description: Echomine Muse provides an easy-to-use Java API that gives you quick and easy yet powerful access to network collaboration services. Specifically, it allows you to communicate with XMPP/Jabber servers to perform instant messaging and presence management in a secure and real-time environment. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462932] Review Request: echomine-muse - Java API for XMPP/Jabber
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462932 --- Comment #1 from John Guthrie [EMAIL PROTECTED] 2008-09-19 15:56:21 EDT --- This package depends on the xmlpull-api package which is also under review. I have added the bug number for that review as a dependency to reflect this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462952] New: Review Request: hunspell-ve - Vietnamese hunspell dictionaries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: hunspell-ve - Vietnamese hunspell dictionaries https://bugzilla.redhat.com/show_bug.cgi?id=462952 Summary: Review Request: hunspell-ve - Vietnamese hunspell dictionaries Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: [EMAIL PROTECTED], fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://people.redhat.com/caolanm/hunspell/hunspell-ve.spec SRPM URL: http://people.redhat.com/caolanm/hunspell/hunspell-ve-0.20060706-1.fc9.src.rpm Description: Vietnamese spellchecking dictionaries -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 187317] Review Request: mindi
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=187317 --- Comment #35 from Bruno Cornec [EMAIL PROTECTED] 2008-09-19 19:56:41 EDT --- Here is the ticket for afio: https://bugzilla.redhat.com/show_bug.cgi?id=449037 And for buffer: https://bugzilla.redhat.com/show_bug.cgi?id=462982 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 187318] Review Request: mondo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=187318 Bruno Cornec [EMAIL PROTECTED] changed: What|Removed |Added Depends on||462982 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462982] Review Request: buffer - General purpose buffer program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462982 Bruno Cornec [EMAIL PROTECTED] changed: What|Removed |Added Blocks||187318 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 187318] Review Request: mondo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=187318 --- Comment #33 from Bruno Cornec [EMAIL PROTECTED] 2008-09-19 19:57:18 EDT --- Buffer is now submitted at https://bugzilla.redhat.com/show_bug.cgi?id=462982 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462982] New: Review Request: buffer - General purpose buffer program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: buffer - General purpose buffer program https://bugzilla.redhat.com/show_bug.cgi?id=462982 Summary: Review Request: buffer - General purpose buffer program Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: [EMAIL PROTECTED], fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: ftp://ftp.mondorescue.org/test/fedora/9/buffer.spec SRPM URL: ftp://ftp.mondorescue.org/test/fedora/9/buffer-1.19-1.fc9.src.rpm Description: General purpose buffer program -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 449037] Review Request: afio - cpio compatible archiver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=449037 --- Comment #8 from Bruno Cornec [EMAIL PROTECTED] 2008-09-19 18:59:33 EDT --- (In reply to comment #7) (In reply to comment #6) xx - rpmlint is unclean on RPM + [EMAIL PROTECTED] x86_64]$ rpmlint afio-2.5-1.fc9.x86_64.rpm afio.x86_64: W: spurious-executable-perm /usr/share/doc/afio-2.5/script2/restore Just chmod and remove the executable bits. Ok. Done. + It might be a good idea to add a check stanza and run 'make regtest' and 'make regtest2gb' in it. It is possible, but it would be better to have them during the review itself, if possible. :-) Indeed. I added them. + According to https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps you should use 'install -p'. I don't see exactly the point here. The Makefile provided doesn't use install. Yes, but you are using 'install -m ...' in the %install stanza. You should use 'install -p -m ...' instead. Oops, sorry, missed that. Fixed now. Please try to fix this because the packaged source tarball should match the upstream tarball if there is no valid reason otherwise. Yep. Agreed. I fixed the tool in the mean time. New RPM available at ftp://ftp.mondorescue.org/test/fedora/9/afio-2.5-1.fc9.src.rpm and spec file at ftp://ftp.mondorescue.org/test/fedora/9/afio.spec Let me know if you think it's better now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462982] Review Request: buffer - General purpose buffer program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462982 Jan ONDREJ [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||needinfo?([EMAIL PROTECTED] ||om) --- Comment #1 from Jan ONDREJ [EMAIL PROTECTED] 2008-09-20 01:54:01 EDT --- Fix licence. Source code says: either version 1, or (at your option) any later version.. According to FedoraLicenses, it must be GPL+, not GPLv2+. Fix Source: path. Your URL points to different URL like Source. I think your URL is OK, but you have to change Source to original path, not path to your local site. Fix BuildRoot, use any of these: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag Your path is similar, but not same as described here. [EMAIL PROTECTED] result]$ rpmlint *.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Builds well on i386, x86_64, f8, f9 and devel. Other personal suggestions: 01-debian-patches.all.gz does not look as an Fedora patch. Please, can you rename it and remove debian specific parts? I don't see more problems in this package. Fix described problems and I can approve this package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
