[Bug 469585] Review Request: moon-buggy - Drive and jump with some kind of car across the moon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469585 --- Comment #18 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-01-04 04:15:08 EDT --- (In reply to comment #17) Spec URL: http://labs.linuxnetz.de/bugzilla/moon-buggy.spec SRPM URL: http://labs.linuxnetz.de/bugzilla/moon-buggy-1.0.51-1.src.rpm Well, [tasa...@localhost moon-buggy]$ LANG=C rpmbuild --rebuild moon-buggy-1.0.51-1.src.rpm Installing moon-buggy-1.0.51-1.src.rpm error: source package expected, binary found error: moon-buggy-1.0.51-1.src.rpm cannot be installed [tasa...@localhost moon-buggy]$ LANG=C rpm -ivh moon-buggy-1.0.51-1.src.rpm error: can't create transaction lock on /var/lib/rpm/__db.000 (Permission denied) Something seems broken on your srpm... For now I unpacked your srpm by rpmdev-extract and repackaged it. Then: - Installing moon-buggy binary rpm rebuilt from your srpm - as tasaka1 (i.e. non-root) execute moon-buggy Then this creates the file mbscore under /var/games/moon-buggy with (owner:group) = (tasaka1:games). Then what happens if tasaka1 user does some malicious things on mbscore (as tasaka1 can modify this file) and root executes moon-buggy? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476720] Review Request: beteckna-sfd-fonts - Beteckna fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476720 Nicolas Mailhot nicolas.mail...@laposte.net changed: What|Removed |Added CC||nicolas.mail...@laposte.net AssignedTo|nob...@fedoraproject.org|nicolas.mail...@laposte.net Flag||fedora-review?, ||needinfo?(sanjay_an...@yaho ||o.co.in) --- Comment #3 from Nicolas Mailhot nicolas.mail...@laposte.net 2009-01-04 05:06:51 EDT --- Hi Ankur, This looks quite good and you've progressed a lot since your first submissions. However, you need to adapt this spec file to the new templates, like for your other submissions -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475032] Review Request: gnaural - A multi-platform programmable binaural-beat generator.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475032 --- Comment #5 from Debarshi Ray debarshi@gmail.com 2009-01-04 04:43:28 EDT --- MUST Items: xx - package meets Packaging Guidelines [...] + According to https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps 'install -p' should be used to preserve timestamps. You missed this one. :-) Recently the Fedora Packaging Committee decided to not use --vendor=fedora anymore, but that decision was waiting to be approved by FESCo. See: + http://fedoraproject.org/wiki/Packaging/Minutes/20081021 + https://fedoraproject.org/wiki/TomCallaway/DesktopFileVendor I have just dropped a mail on fedora-devel-list to find out what the current is. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463912] Review Request: tinyows - WFS-T and FE implementation server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463912 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added CC||lkund...@v3.sk AssignedTo|nob...@fedoraproject.org|lkund...@v3.sk Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 451153] Review Request: mapbender - Geospatial portal for OGC OWS architectures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=451153 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added CC||lkund...@v3.sk AssignedTo|nob...@fedoraproject.org|lkund...@v3.sk Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463912] Review Request: tinyows - WFS-T and FE implementation server
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=463912
--- Comment #4 from Balint Cristian re...@rdsor.ro 2009-01-04 07:45:59 EDT
---
(In reply to comment #3)
1.) Why do you throw away the valgrind run results?
make %{?_smp_mflags} valgrind || true
- My behaviour is to trow it, but _allways_ look at build logs.
I am unsure if on ppc64 will fail some tests (always an issue),
if so than I complicate my life. Olso i prepare for alpha
sparc/sparc64 and i can see some failures wich stop rpm build
process.
2.) This can be replaced
%dir %{_datadir}/%{name}
%{_datadir}/%{name}/*
with
%{_datadir}/%{name}
- will NEXTRELEASE
and this
pushd %{buildroot}%{_datadir}/%{name}/
ln -s ../../../%{_sysconfdir}/%{name}/config.xml config.xml
popd
with
ln -s ../../../%{_sysconfdir}/%{name}/config.xml
%{buildroot}%{_datadir}/%{name}/config.xml
- will NEXTRELEASE
Sorry -- I could not resist these; just because I found nothing severe ;)
None of these is anything that would block the review:
I must Thanks for the patient and meticulous review !
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469585] Review Request: moon-buggy - Drive and jump with some kind of car across the moon
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469585
--- Comment #20 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-01-04
09:36:30 EDT ---
(In reply to comment #19)
Interesting. Which Fedora release and which RPM version? I've _no_ issues to
rebuild or install this package on plain Fedora 10 and CentOS 5. Maybe we can
get out, what's broken here (btw, rpm2cpio src | cpio -idm would have also
worked).
Both on my rawhide i386 system and koji scratch build
fails (ref:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1031143 )
Danger is everywhere. You could exploit vi(1) with nice stuff, insert and
execute your own malicious code written in the file, vi is going to read and
edit -
I guess vi case does not apply for the case in this package.
What I am saying is that the malicious code inserted by _one_ person
is read by _another_ person unintentionally (i.e. like
the case in which some malicious png file created by unknown
person on the internet is accessed by local users).
For /bin/vi case, the impact of the risk should be limited
to the person who intentionally tried to read the file.
AFAIK this even was recently possible and is now fixed there. For me
this example is the same situation as what you try to describe above, but for
software like vi this seems much more dangerous to me rather to moon-buggy.
So I don't think vi and moon-buggy are the same situation.
There is always some risk once more than a single user is able to touch a
file. Yesterday evening when enabling that feature I already had some kind
of IRC discussion on #fedora-devel. But removing the highscore feature isn't
acceptable for me at all.
Then please do this in the safe way. By the way the basic problem
I think is that the file mbscore is created by arbitrary person.
My C knowledge isn't the best, but when reading read_version2_data() or the
read_version3_data() from highscore.c, the C code seems to be good. On the
other hand, there AFAIK was no CVE report for that possible issue ever, even
many various Linux distributions deliver(ed) moon-buggy to their users. So
why should I feel not good for Fedora here?
Because Fedora is more careful? (actually security responsible
team on RedHat is very concerned about setuid/setgid binaries:
e.g.
https://www.redhat.com/archives/fedora-security-list/2007-April/msg4.html )
[20:32:08] rsc Packagers around? I've got a game which would like to write
a
multiuser highscore file. Where? /var/games/%{name}/*? And which permissions?
Program offers setgid with games user.
[20:32:22] ixs why not?
[20:32:39] ixs but I'd give it a special user...
[20:32:42] ixs for security reasons
[20:32:56] ixs or simple remove the highscore feature
[20:33:08] rsc ixs: wäh!
[20:33:18] ixs :
[20:34:30] lkundrak ixs: yes, rsc is right
[20:34:53] ixs ahh come on
[20:34:57] ixs nobody needs highscores
[20:34:58] ixs amirite?
[20:35:54] lkundrak ixs: i suggest looking at some already existing game.
probably nethack or something like that
[20:37:11] ivazquez Using games should be fine. What are they going to do,
overwrite other games' high scores? :P
[20:37:35] rsc lkundrak: existing games are doing what the program offers
(setgit + /var/games/)
[20:37:51] rsc lkundrak: at least one, I was pointed to.
[20:38:43] ivazquez nethack and Maelstrom both use the games group.
[20:40:14] rsc ivazquez: /var/games/%{name}.highscore or
/var/games/%{name}/highscore or what would you suggest?
[20:44:53] ivazquez I would put it in its own directory.
[20:45:19] ivazquez I would consider /var/games to be a games-specific
/var/lib.
[20:47:43] rsc ivazquez: thanks
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469585] Review Request: moon-buggy - Drive and jump with some kind of car across the moon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469585 --- Comment #21 from Robert Scheck redhat-bugzi...@linuxnetz.de 2009-01-04 09:57:04 EDT --- (In reply to comment #20) Both on my rawhide i386 system and koji scratch build fails (ref: http://koji.fedoraproject.org/koji/taskinfo?taskID=1031143) Looks like my Rawhide system is then somehow broken, possible. But shouldn't prevent us here from continuing, the packages for Fedora are anyway built by the build system hopefully not broken ;-) For /bin/vi case, the impact of the risk should be limited to the person who intentionally tried to read the file. And if the person doing intentionally this is root? Thus it is simply the same case as vi. You unluckily didn't get my point. Then please do this in the safe way. By the way the basic problem I think is that the file mbscore is created by arbitrary person. Patches by you are cheerfully accepted. As other packages having exactly (!) the same got successfully reviewed, I'm definately not going to change this as downstream. This would be upstream's job, I'm not forking foreign software as other packagers do, because we're just Fedora and because of we're just cool or we want to be better and more concerned about something than others. Again, can you show me how to exploit or manipulate read_version2_data() or read_version3_data() somehow? As mentioned - my C knowledge isn't the best, but the C code seems straight-forward to me. Because Fedora is more careful? (actually security responsible team on RedHat is very concerned about setuid/setgid binaries: e.g. https://www.redhat.com/archives/fedora-security-list/2007-April/msg4.html That thread talks about SELinux, PAM and that setuid is here not needed at all; wrong topic. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478628] Review Request: dhcping - DHCP daemon ping program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478628 Marek Mahut mma...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #1 from Marek Mahut mma...@redhat.com 2009-01-04 10:03:47 EDT --- Your package looks sane, just fix the typo in SOURCE1. + name is acceptable + version matches + disttag is correct + license is correct and Fedora compatible (MIT) + source is same as upstream + BuildRoot is correct (F9) + compiler uses appropriate flags + package builds in mock + rpmlint is sane APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478743] New: Review Request: saga - SAGA is a free, hybrid, cross-platform GIS software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: saga - SAGA is a free, hybrid, cross-platform GIS software https://bugzilla.redhat.com/show_bug.cgi?id=478743 Summary: Review Request: saga - SAGA is a free, hybrid, cross-platform GIS software Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: re...@rdsor.ro QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://openrisc.rdsor.ro/saga.spec SRPM URL: http://openrisc.rdsor.ro/saga-2.0.3-1.fc11.src.rpm Description: SAGA - short hand for System for Automated Geoscientific Analyses is a free, hybrid, cross-platform GIS software. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478744] Review Request: wmfire - WindowMaker dock app that displays cpu, memory or network load as flames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478744 steve st...@lonetwin.net changed: What|Removed |Added Blocks||177841 --- Comment #1 from steve st...@lonetwin.net 2009-01-04 10:17:54 EDT --- I need a sponsor although this is not the first package I have submitted (bug 473583 is the first, which is still has NEW status and has yet to be reviewed). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478570] Review Request: RiordonFancy-fonts - A stylized font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478570 Nicolas Mailhot nicolas.mail...@laposte.net changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|nicolas.mail...@laposte.net Flag||fedora-review?, ||needinfo?(ivazquez...@gmail ||.com) --- Comment #1 from Nicolas Mailhot nicolas.mail...@laposte.net 2009-01-04 05:29:37 EDT --- Thank you for packaging a new font. Initial remarks: — you should convert to the new Fedora packaging templates. That will make Behdad happy and simplify your spec file quite a bit http://fedoraproject.org/wiki/Simple_fonts_spec_template (plain text version in fontpackages-devel) — please use lowercase package name to keep consistency with other font packages such as dejavu-fonts — You have more complete fontconfig templates that just need filing in fontpackages-devel (please send them upstream for inclusion in the font archive when you're happy with them) — please ask upstream to add a detached txt license file, a readme and a fontlog. The OFL is quite specific about stuff like reserved font names, that require documentation in the license text and fontlog — this font is available in the Open Font Library. Please ask upstream what the canonical home should be. If it is the Open Font Library, add the oflb- prefix to the fontname — please add a page to the wiki that describes this font and will be referenced in the F11 release notes, using this template: http://fedoraproject.org/wiki/Font_description_template (see also http://fedoraproject.org/wiki/Font_package_lifecycle ) ⇒ NEEDINFO while this is being taken care of -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 Chitlesh GOORAH cgoo...@yahoo.com.au changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #22 from Chitlesh GOORAH cgoo...@yahoo.com.au 2009-01-04 06:16:28 EDT --- (In reply to comment #21) If you are packaging the one from Wilson Snyder, then I can remove these files. Yes, I'll package the ones from Wilson Snyder. I'm also trying to package everything from veripool for F-11. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469585] Review Request: moon-buggy - Drive and jump with some kind of car across the moon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469585 --- Comment #22 from Robert Scheck redhat-bugzi...@linuxnetz.de 2009-01-04 10:25:03 EDT --- According to the Fedora Packaging Guidelines of the Games SIG (http:// fedoraproject.org/wiki/SIGs/Games/Packaging), the current behaviour is okay and accepted ([...] If necessary, a game can be made setgid 'games' in order to allow a shared scoreboard file. [...]). So why are you here unneccessarily making the review more hard? If you would like to change something in general, please go to FESCO or ask the Games SIG to change this. But don't question the Packaging Guidelines in a Review, that's the wrong point in the process. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448122] Review Request: trash-cli - Command line trashcan (recycle bin) interface
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=448122 Andrea Francia andrea.fran...@gmx.it changed: What|Removed |Added Flag|needinfo?(pertu...@free.fr) | --- Comment #30 from Andrea Francia andrea.fran...@gmx.it 2009-01-04 10:41:21 EDT --- After some discussion and consultation with other people, in particular with Ben Finney[1] I decided to rename the trash-file command to trash-put. [1] http://lists.freedesktop.org/archives/distributions/2009-January/000285.html The updated package can be found on pipy: http://pypi.python.org/pypi/trash-cli/ You can use the same instructions as before for installing and testing the package. Taking care of using the new download url[2], and using the test script with the updated name: bash trash-put-test.bash [2] http://pypi.python.org/packages/source/t/trash-cli/trash-cli-0.2.1.dev-r143.tar.gz#md5=7ec53b0039a41215d0e546c19f667f41 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469585] Review Request: moon-buggy - Drive and jump with some kind of car across the moon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469585 --- Comment #23 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-01-04 10:39:15 EDT --- (In reply to comment #21) For /bin/vi case, the impact of the risk should be limited to the person who intentionally tried to read the file. And if the person doing intentionally this is root? Thus it is simply the same case as vi. You unluckily didn't get my point. Again what I am saying that a malious file created by one person can be read by other person, not only by root. Then please do this in the safe way. By the way the basic problem I think is that the file mbscore is created by arbitrary person. Patches by you are cheerfully accepted. As other packages having exactly (!) the same got successfully reviewed, This package is not the other packages, of course. I'm definately not going to change this as downstream. This would be upstream's job, No, maintaining the software in the safe way is definitely distribution maintainer's job (well, I really don't like the word it is upstream's job which is spoken carelessly. It must not be a maintainer's attitude). I'm not forking foreign software as other packagers do, because we're just Fedora and because of we're just cool or we want to be better and more concerned about something than others. I think this must not be a maintainer's attitude. Again, can you show me how to exploit or manipulate read_version2_data() or read_version3_data() somehow? As mentioned - my C knowledge isn't the best, but the C code seems straight-forward to me. Potential crafted files may cause buffer overflow or numerical overflow, in such case we cannot tell what happens, for example? Because Fedora is more careful? (actually security responsible team on RedHat is very concerned about setuid/setgid binaries: e.g. https://www.redhat.com/archives/fedora-security-list/2007-April/msg4.html That thread talks about SELinux, PAM and that setuid is here not needed at all; wrong topic. I just showed an example that RH security responsible team is very concerned about setuid/gid binaries. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469585] Review Request: moon-buggy - Drive and jump with some kind of car across the moon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469585 --- Comment #24 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-01-04 10:47:39 EDT --- (In reply to comment #22) According to the Fedora Packaging Guidelines of the Games SIG (http:// fedoraproject.org/wiki/SIGs/Games/Packaging), the current behaviour is okay and accepted ([...] If necessary, a game can be made setgid 'games' in order to allow a shared scoreboard file. [...]). And of course this must be done safely. Unfortunately all setgid binaries under %_bindir related to game programs on my system are in gnome-games or gnuchess, and they handle high score files in a safe way. So why are you here unneccessarily making the review more hard? It is definitely needed. Review request is _NOT_ just checking packaging issue. If you would like to change something in general, I am not changing anything. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469585] Review Request: moon-buggy - Drive and jump with some kind of car across the moon
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469585
--- Comment #19 from Robert Scheck redhat-bugzi...@linuxnetz.de 2009-01-04
07:54:33 EDT ---
Interesting. Which Fedora release and which RPM version? I've _no_ issues to
rebuild or install this package on plain Fedora 10 and CentOS 5. Maybe we can
get out, what's broken here (btw, rpm2cpio src | cpio -idm would have also
worked).
Danger is everywhere. You could exploit vi(1) with nice stuff, insert and
execute your own malicious code written in the file, vi is going to read and
edit - AFAIK this even was recently possible and is now fixed there. For me
this example is the same situation as what you try to describe above, but for
software like vi this seems much more dangerous to me rather to moon-buggy.
There is always some risk once more than a single user is able to touch a
file. Yesterday evening when enabling that feature I already had some kind
of IRC discussion on #fedora-devel. But removing the highscore feature isn't
acceptable for me at all.
My C knowledge isn't the best, but when reading read_version2_data() or the
read_version3_data() from highscore.c, the C code seems to be good. On the
other hand, there AFAIK was no CVE report for that possible issue ever, even
many various Linux distributions deliver(ed) moon-buggy to their users. So
why should I feel not good for Fedora here?
[20:32:08] rsc Packagers around? I've got a game which would like to write a
multiuser highscore file. Where? /var/games/%{name}/*? And which permissions?
Program offers setgid with games user.
[20:32:22] ixs why not?
[20:32:39] ixs but I'd give it a special user...
[20:32:42] ixs for security reasons
[20:32:56] ixs or simple remove the highscore feature
[20:33:08] rsc ixs: wäh!
[20:33:18] ixs :
[20:34:30] lkundrak ixs: yes, rsc is right
[20:34:53] ixs ahh come on
[20:34:57] ixs nobody needs highscores
[20:34:58] ixs amirite?
[20:35:54] lkundrak ixs: i suggest looking at some already existing game.
probably nethack or something like that
[20:37:11] ivazquez Using games should be fine. What are they going to do,
overwrite other games' high scores? :P
[20:37:35] rsc lkundrak: existing games are doing what the program offers
(setgit + /var/games/)
[20:37:51] rsc lkundrak: at least one, I was pointed to.
[20:38:43] ivazquez nethack and Maelstrom both use the games group.
[20:40:14] rsc ivazquez: /var/games/%{name}.highscore or
/var/games/%{name}/highscore or what would you suggest?
[20:44:53] ivazquez I would put it in its own directory.
[20:45:19] ivazquez I would consider /var/games to be a games-specific
/var/lib.
[20:47:43] rsc ivazquez: thanks
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478749] New: Review Request: dinotrace - X11 waveform viewer for electronics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: dinotrace - X11 waveform viewer for electronics https://bugzilla.redhat.com/show_bug.cgi?id=478749 Summary: Review Request: dinotrace - X11 waveform viewer for electronics Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: cgoo...@yahoo.com.au QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://chitlesh.fedorapeople.org/RPMS/dinotrace.spec SRPM URL: http://chitlesh.fedorapeople.org/RPMS/dinotrace-9.3f-1.fc10.src.rpm Description: Dinotrace is a X-11 waveform viewer which understands Verilog Value Change Dumps, ASCII, and other trace formats. It allows placing cursors, highlighting signals, searching, printing, and other capabilities superior to many commercial waveform viewers. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457947] Review Request: oldstandard-sfd-fonts - Old Standard Fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457947 --- Comment #26 from Ankur Sinha sanjay_an...@yahoo.co.in 2009-01-04 11:07:40 EDT --- hi, packages : http://ankursinha.fedorapeople.org/oldstandard_sfd_fonts/oldstandard-sfd-fonts.spec http://ankursinha.fedorapeople.org/oldstandard_sfd_fonts/oldstandard-sfd-fonts-2.0.2-2.fc10.src.rpm same warning with the rpm for this package too : oldstandard-sfd-fonts.noarch: W: symlink-should-be-relative /etc/fonts/conf.d/60-oldstandard.conf /usr/share/fontconfig/conf.avail/60-oldstandard.conf hope its okay other than that. @pablo : ive just really replaced the font name and generic name etc in the fontconfig template that nicolas has given. I dont exactly understand it. hope its okay other than that.. regards, -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469585] Review Request: moon-buggy - Drive and jump with some kind of car across the moon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469585 --- Comment #25 from Robert Scheck redhat-bugzi...@linuxnetz.de 2009-01-04 11:17:40 EDT --- Args, you're expecting me to create and own the /var/games/moon-buggy/mbscore file inside of the RPM package with 664 and root:games - right? As the mbscore file should be created after installing or with the first run of the game (if you looked to it, there are dates and expires mentioned), I would like to do that with %ghost and something in %post - also acceptable? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457947] Review Request: oldstandard-sfd-fonts - Old Standard Fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457947 --- Comment #27 from Nicolas Mailhot nicolas.mail...@laposte.net 2009-01-04 11:20:40 EDT --- (In reply to comment #26) same warning with the rpm for this package too : oldstandard-sfd-fonts.noarch: W: symlink-should-be-relative /etc/fonts/conf.d/60-oldstandard.conf /usr/share/fontconfig/conf.avail/60-oldstandard.conf You can ignore this warning for now, it's not even sure if we'll keep in in Fedora rpmlint http://fedoraproject.org/wiki/PackagingDrafts/Absolute_symlinks_in_fonts_templates_%282009-01-02%29 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225865] Merge Review: gstreamer-plugins-base
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225865 --- Comment #3 from Debarshi Ray debarshi@gmail.com 2009-01-04 11:11:34 EDT --- Created an attachment (id=328138) -- (https://bugzilla.redhat.com/attachment.cgi?id=328138) Sample Patch1 to avoid libtheora version checking. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476720] Review Request: beteckna-sfd-fonts - Beteckna fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476720 Ankur Sinha sanjay_an...@yahoo.co.in changed: What|Removed |Added Flag|needinfo?(sanjay_an...@yaho | |o.co.in)| --- Comment #4 from Ankur Sinha sanjay_an...@yahoo.co.in 2009-01-04 11:29:44 EDT --- hi, packages: http://ankursinha.fedorapeople.org/beteckna-0.3/beteckna-sfd-fonts-0.3-2.fc10.src.rpm http://ankursinha.fedorapeople.org/beteckna-0.3/beteckna-sfd-fonts.spec Gives this error while building packages..During the build using fontforge..FindMatchinHVEdge didn't I havent been able to understad what it is..Packages build normally though.. Getting this warning here too with rpmlint : beteckna-sfd-fonts.noarch: W: symlink-should-be-relative /etc/fonts/conf.d/60-beteckna.conf /usr/share/fontconfig/conf.avail/60-beteckna.conf regards, -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475032] Review Request: gnaural - A multi-platform programmable binaural-beat generator.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475032 Debarshi Ray debarshi@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #8 from Debarshi Ray debarshi@gmail.com 2009-01-04 11:33:20 EDT --- Sorry for not pointing this out earlier, but Application should not be a part of the Categories key in the .desktop file: [ri...@ginger SPECS]$ desktop-file-validate /usr/share/applications/gnaural.desktop /usr/share/applications/gnaural.desktop: warning: value Application;AudioVideo;AudioVideoEditing; for key Categories in group Desktop Entry contains a deprecated value Application [ri...@ginger SPECS]$ Also, please try to discuss and submit your modifications to the .desktop file upstream. Otherwise it looks fine. +-+ | This package is APPROVED by me. | +-+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469585] Review Request: moon-buggy - Drive and jump with some kind of car across the moon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469585 --- Comment #26 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-01-04 11:36:43 EDT --- Well, the more acceptable method is - do touch %buildroot%_localstatedir/games/%name/mbscore at %install - In %files %verify(not md5 size mtime) %config(noreplace) %attr(664, root, games) (or %attr(644, games, games)) %_localstatedir/games/%names/mbscore With this no %post is required, and $ rpm -V won't complain because of %verify(not). Also I checked that with this (i.e. creating zero-size mbscore with (root,games)), mbscore is initialized, however (user, group) is still (root,games). Also normal user cannot write this file anymore. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469585] Review Request: moon-buggy - Drive and jump with some kind of car across the moon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469585 --- Comment #27 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-01-04 11:37:55 EDT --- (In reply to comment #26) (or %attr(644, games, games)) %_localstatedir/games/%names/mbscore Of course %attr(664, games,games)... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456182] Review Request: rssh - Restricted shell for use with OpenSSH, allowing only scp and/or sftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456182 Debarshi Ray debarshi@gmail.com changed: What|Removed |Added Flag||needinfo?(sunda...@redhat.c ||om) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469585] Review Request: moon-buggy - Drive and jump with some kind of car across the moon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469585 --- Comment #28 from Robert Scheck redhat-bugzi...@linuxnetz.de 2009-01-04 11:43:06 EDT --- Okay, if zero-sized mbscore works for moon-buggy, I'll do it that way with the next build of the package. Something else, you would like to see changed? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475032] Review Request: gnaural - A multi-platform programmable binaural-beat generator.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475032 Rakesh Pandit rakesh.pan...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Rakesh Pandit rakesh.pan...@gmail.com 2009-01-04 11:50:02 EDT --- Will fix it before importing. New Package CVS Request === Package Name: gnaural Short Description: A multi-platform programmable binaural-beat generator. Owners: rakesh Branches: F-8 F-9 F-10 InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225865] Merge Review: gstreamer-plugins-base
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225865
--- Comment #1 from Debarshi Ray debarshi@gmail.com 2009-01-04 11:06:24
EDT ---
MUST Items:
xx - rpmlint is unclean on RPM and SRPM
+ See: http://rishi.fedorapeople.org/gstreamer-plugins-base.rpmlint
OK - follows Naming Guidelines
+ Although the upstream tarball is named gst-plugins-base, the project is
named gstreamer, which is the prefix used by Debian also.
OK - spec file is named as %{name}.spec
xx - package does not meet Packaging Guidelines
+ Please try not to mix spaces and tabs as field separators.
+ You could consider passing --disable-gnome_vfs to %configure, because
a simple non-Mock or non-Koji rpmbuild will fail if gnome-vfs is present
due to PolicyKit-gnome, abiword, brasero, evolution, yelp, etc..
+ According to
https://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath we
should avoid rpaths, especially for standard locations like %{_libdir}.
Here is a possible solution:
BuildRequires: libtool
[...]
%build
%configure \
[...]
rm -f ./libtool
cp %{_bindir}/libtool .
[...]
+ Here is how the unused-direct-shlib-dependency can be removed:
https://fedoraproject.org/wiki/PackageMaintainers/Common_Rpmlint_Issues#unused-direct-shlib-dependency
+ According to
https://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used
%makeinstall macro should not be used. To also preserve timestamps you
could consider using:
make install INSTALL=%{__install} -p DESTDIR=$RPM_BUILD_ROOT
+ Why not include ChangeLog, NEWS and RELEASE in %doc?
+ According to
https://fedoraproject.org/wiki/Packaging/Guidelines#Documentation the
REQUIREMENTS file should not be distributed.
+ The most recent entry in the %changelog has a typo. The
%{version}-%{release} should be 0.10.21-3.
+ In the %changelog %files should be replaced by %%files in this entry:
* Wed Jan 18 2006 John (J5) Palmieri jo...@redhat.com - 0.10.2-1
+ The following lines in gst-libs/gst/fft, are responsible for
libgstfft-0.10.so.0.15.0 calling exit:
kiss_fftr_f32.c:81:exit (1);
kiss_fftr_f32.c:138:exit (1);
kiss_fftr_f64.c:81:exit (1);
kiss_fftr_f64.c:138:exit (1);
kiss_fftr_s16.c:81:exit (1);
kiss_fftr_s16.c:138:exit (1);
kiss_fftr_s32.c:81:exit (1);
kiss_fftr_s32.c:138:exit (1);
I do not know what we can do about this, but nowadays rpmlint marks this
as a warning.
OK - license meets Licensing Guidelines
OK - License field meets actual license
xx - upstream license file included in %doc
+ COPYING contains the GPLv2, while the actual license of this package is
LGPLv2+. Please include COPYING.LIB instead.
OK - spec file uses American English
OK - spec file is legible
OK - sources match upstream sources
xx - package does not build successfully
+ Libtheora has a broken version numbering in its *.pc file. See:
https://bugzilla.redhat.com/478651 Since the version of libtheora in
Fedora 8 and above is recent enough, we can disable the version check in
the configure script.
OK - ExcludeArch not needed
OK - build dependencies correctly listed
+ Pedantically speaking 'BuildRequires: libtheora = 1.0' is wrong, but
libtheora has a broken NEVRA (https://bugzilla.redhat.com/478651) so
we have to live with it.
OK - locales handled properly
xx - %post and %postun do not invoke ldconfig
+ Since shared libraries are being installed in the dynamic linker's
default path, ldconfig should be invoked in the %post and %postun
scriptlets. See:
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Shared_libraries
OK - package is not relocatable
xx - file and directory ownership
+ The -devel sub-package should have 'Requires: gtk-doc' as it installs
files under /usr/share/gtk-doc.
+ The -devel sub-package should have 'Requires: pkgconfig' as it installs
files under /usr/lib/pkgconfig. Or has the new autogenerated pkgconfig
dependencies feature removed this requirement?
OK - no duplicates in %file
OK - file permissions set properly
+ The preferred attribute definition is: %defattr(-,root,root,-)
OK - %clean present
OK - macros used consistently
OK - contains code and permissable content
OK - -doc is not needed
OK - contents of %doc does not affect the runtime
OK - header files in -devel
OK - no static libraries
xx - -devel has *.pc file and does not require pkgconfig
+ The -devel sub-package should have 'Requires: pkgconfig' as it installs
a *.pc file under /usr/lib/pkgconfig. Or has the new autogenerated
pkgconfig dependencies feature removed this
[Bug 478749] Review Request: dinotrace - X11 waveform viewer for electronics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478749 --- Comment #1 from Chitlesh GOORAH cgoo...@yahoo.com.au 2009-01-04 12:36:26 EDT --- Updated: Spec URL: http://chitlesh.fedorapeople.org/RPMS/dinotrace.spec SRPM URL: http://chitlesh.fedorapeople.org/RPMS/dinotrace-9.3f-2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457955] Review Request: bonvenocf-fonts - BonvenoCF font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457955 --- Comment #16 from Nicolas Mailhot nicolas.mail...@laposte.net 2009-01-04 12:00:12 EDT --- (In reply to comment #15) The new spec template says change *.ttf to where your files actually are. I dint quite get that. You did ok, I've tried to clarify the wiki page ping me if it's still unclear Also, rpmlint for the rpm gives this warning.. : cf-bonveno-fonts.noarch: W: symlink-should-be-relative /etc/fonts/conf.d/60-cf-bonveno.conf /usr/share/fontconfig/conf.avail/60-cf-bonveno.conf This is an rpmlint of dubious utility that will be discussed by FPC soonish. In the meanwhile, ignore it http://fedoraproject.org/wiki/PackagingDrafts/Absolute_symlinks_in_fonts_templates_%282009-01-02%29 Please make your fontconfig file adhere more closely to the basic template in fontpackages-devel. Otherwise, everything else seems fine -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478628] Review Request: dhcping - DHCP daemon ping program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478628 Marek Mahut mma...@redhat.com changed: What|Removed |Added CC||mma...@redhat.com AssignedTo|nob...@fedoraproject.org|mma...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478628] Review Request: dhcping - DHCP daemon ping program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478628 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Fabian Affolter fab...@bernewireless.net 2009-01-04 11:05:09 EDT --- New Package CVS Request === Package Name: dhcping Short Description: DHCP daemon ping program Owners: fab Branches: F-9 F-10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463912] Review Request: tinyows - WFS-T and FE implementation server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463912 Balint Cristian re...@rdsor.ro changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Balint Cristian re...@rdsor.ro 2009-01-04 07:49:15 EDT --- New Package CVS Request === Package Name: tinyows Short Description: WFS-T and FE implementation server Owners: rezso Branches: F-8 F-9 F-10 devel -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476720] Review Request: beteckna-sfd-fonts - Beteckna fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476720 --- Comment #6 from Nicolas Mailhot nicolas.mail...@laposte.net 2009-01-04 13:05:36 EDT --- PS for the fontforge warning, ask on the fontforge mailing list -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=468516
--- Comment #23 from Chitlesh GOORAH cgoo...@yahoo.com.au 2009-01-04
13:06:33 EDT ---
(In reply to comment #11)
#004: Are these useful ?
/usr/share/verilator/bin
/usr/share/verilator/bin/verilator_includer
Yes. As far as I know, verilator uses these.
/usr/share/verilator/bin
/usr/share/verilator/bin/verilator_includer
is a duplicate of
/usr/bin/verilator_includer
You will need to remove the duplicates as well
%{__rm} -rf %{buildroot}%{_datadir}%{name}/bin
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478759] New: Review Request: perl-SystemPerl - SystemPerl Perl module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-SystemPerl - SystemPerl Perl module https://bugzilla.redhat.com/show_bug.cgi?id=478759 Summary: Review Request: perl-SystemPerl - SystemPerl Perl module Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: cgoo...@yahoo.com.au QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://chitlesh.fedorapeople.org/RPMS/perl-SystemPerl.spec SRPM URL: http://chitlesh.fedorapeople.org/RPMS/perl-SystemPerl-1.300-1.fc10.src.rpm Description: SystemPerl is a version of the SystemC language. It is designed to expand text so that needless repetition in the language is minimized. By using sp_preproc, SystemPerl files can be expanded into C++ files at compile time, or expanded in place to make them valid stand-alone SystemC files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #24 from Chitlesh GOORAH cgoo...@yahoo.com.au 2009-01-04 13:07:39 EDT --- Use perl-SystemPerl as from now on: Bug 478759 - Review Request: perl-SystemPerl - SystemPerl Perl module -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478759] Review Request: perl-SystemPerl - SystemPerl Perl module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478759 Chitlesh GOORAH cgoo...@yahoo.com.au changed: What|Removed |Added Blocks||468516 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 Chitlesh GOORAH cgoo...@yahoo.com.au changed: What|Removed |Added Depends on||478759 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456182] Review Request: rssh - Restricted shell for use with OpenSSH, allowing only scp and/or sftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456182 --- Comment #26 from Debarshi Ray debarshi@gmail.com 2009-01-04 11:39:46 EDT --- Is there anything which is keeping us from closing this? It has been more than 2 months now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457955] Review Request: bonvenocf-fonts - BonvenoCF font
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457955
Ankur Sinha sanjay_an...@yahoo.co.in changed:
What|Removed |Added
Flag|needinfo?(sanjay_an...@yaho |
|o.co.in)|
--- Comment #15 from Ankur Sinha sanjay_an...@yahoo.co.in 2009-01-04
06:20:33 EDT ---
hi,
packages :
http://ankursinha.fedorapeople.org/cf-bonveno-fonts/cf-bonveno-fonts-1.1-2.fc10.src.rpm
http://ankursinha.fedorapeople.org/cf-bonveno-fonts/cf-bonveno-fonts.spec
Im not too sure of line 53 :
install -pm 644 *.ttf %{buildroot}%{fontdir}
The new spec template says change *.ttf to where your files actually are. I
dint quite get that.
Also, rpmlint for the rpm gives this warning.. : cf-bonveno-fonts.noarch: W:
symlink-should-be-relative /etc/fonts/conf.d/60-cf-bonveno.conf
/usr/share/fontconfig/conf.avail/60-cf-bonveno.conf
so there must be something wrong in the ln ... command.. line 61.
I havent been able to correct that either.
regards,
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225865] Merge Review: gstreamer-plugins-base
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225865 --- Comment #2 from Debarshi Ray debarshi@gmail.com 2009-01-04 11:10:06 EDT --- Created an attachment (id=328137) -- (https://bugzilla.redhat.com/attachment.cgi?id=328137) Sample Spec file fixes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478674] Review Request: pp3 - Creation of sky charts in Postscript or PDF format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478674 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added CC||lkund...@v3.sk AssignedTo|nob...@fedoraproject.org|lkund...@v3.sk Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469585] Review Request: moon-buggy - Drive and jump with some kind of car across the moon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469585 --- Comment #30 from Robert Scheck redhat-bugzi...@linuxnetz.de 2009-01-04 13:51:45 EDT --- Spec URL: http://labs.linuxnetz.de/bugzilla/moon-buggy.spec SRPM URL: http://labs.linuxnetz.de/bugzilla/moon-buggy-1.0.51-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475032] Review Request: gnaural - A multi-platform programmable binaural-beat generator.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475032 --- Comment #6 from Rakesh Pandit rakesh.pan...@gmail.com 2009-01-04 05:44:52 EDT --- Removed vendor SPEC: http://rakesh.fedorapeople.org/spec/gnaural.spec SRPM: http://rakesh.fedorapeople.org/srpm/gnaural-1.0.20080808-3.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 451153] Review Request: mapbender - Geospatial portal for OGC OWS architectures
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=451153
--- Comment #6 from Balint Cristian re...@rdsor.ro 2009-01-04 07:24:11 EDT
---
(In reply to comment #5)
Just a few minor issues/notes:
1.) The license seems to be GPL 2 or newer, therefore GPLv2+, please correct
the License tag
2.) What is %contentdir for?
You do:
%define contentdir /var/www
mkdir -p -m0755 %{buildroot}%{contentdir}/html
- Temporary macro to allow /var/www path. Since this package deal a lot
with /var/www path, and will in the future if this piece of software will
expand. RPM really miss many of some handfull macros, this is not the first
in my opinion.
Yet you do not seem to be putting anything there, nor is it included in the
resulting package.
3.) This does not look very nice:
set +x
for f in `find . -type f` ; do
if file $f | grep -q ISO-8859 ; then
I'm not sure whether it's safe to rely on libmagic, since as far as I know (I
may be wrong as well..), it identifies the charset used by the first few
(kilo?) bytes, not reading the whole file. Why not convert all files -- it may
be that iconving all files may be even faster than, or at least comparable,
with calling file against them.
set -x
iconv -f ISO-8859-1 -t UTF-8 $f ${f}.tmp \
mv -f ${f}.tmp $f
- Yes true. However if file is not ISO-8859-1 and try force convert to UTF-8
than rpmlint will yale, so its safe for now. ~99% is always ISO-8859-2.
- I am upset all time when upstream not follow UTF-8 so this jhack is usefull,
especialy rpmlint will allways signal if something.
I'm not sure about use of here. I think you should break the build if iconv
fails instead of leaving a stale .tmp file.
- Hmm. Never encounter such issue. However this combination never failed on
any of my packages untill now.
Also, a good habit is to preserve timestamp -- touch -r $f $f.tmp before mv.
set +x
fi
if file $f | grep -q CRLF ; then
- Will take care in next spin %{version}+1
I'd say you don't have to call file here as well. It is safe to remove all
\r-s.
set -x
sed -i -e 's|\r||g' $f
set +x
fi
done
set -x
- Will proceed in next spin %{version}+1
However these 'sanity' bits was suggested by Patrice Dumas and Mamoru Tasaka,
my very first reviewers. I never investigated deeply how can be improved,
i just always do it on any of my packages.
Given none of these are serious enough to warrant a blocker, the package is
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475032] Review Request: gnaural - A multi-platform programmable binaural-beat generator.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475032 --- Comment #7 from Rakesh Pandit rakesh.pan...@gmail.com 2009-01-04 06:17:55 EDT --- Fixed missing install -p SPEC: http://rakesh.fedorapeople.org/spec/gnaural.spec SRPM: http://rakesh.fedorapeople.org/srpm/gnaural-1.0.20080808-4.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463912] Review Request: tinyows - WFS-T and FE implementation server
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=463912
Lubomir Rintel lkund...@v3.sk changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #3 from Lubomir Rintel lkund...@v3.sk 2009-01-04 07:35:44 EDT ---
1.) Why do you throw away the valgrind run results?
make %{?_smp_mflags} valgrind || true
2.) This can be replaced
%dir %{_datadir}/%{name}
%{_datadir}/%{name}/*
with
%{_datadir}/%{name}
and this
pushd %{buildroot}%{_datadir}/%{name}/
ln -s ../../../%{_sysconfdir}/%{name}/config.xml config.xml
popd
with
ln -s ../../../%{_sysconfdir}/%{name}/config.xml
%{buildroot}%{_datadir}/%{name}/config.xml
Sorry -- I could not resist these; just because I found nothing severe ;)
None of these is anything that would block the review:
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457955] Review Request: bonvenocf-fonts - BonvenoCF font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457955 Nicolas Mailhot nicolas.mail...@laposte.net changed: What|Removed |Added Flag||needinfo?(sanjay_an...@yaho ||o.co.in) --- Comment #14 from Nicolas Mailhot nicolas.mail...@laposte.net 2009-01-04 05:02:44 EDT --- Please adapt to the new guidelines ; that should be easy and simplify your spec quite a bit -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469585] Review Request: moon-buggy - Drive and jump with some kind of car across the moon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469585 --- Comment #29 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-01-04 11:55:08 EDT --- Well, we recommend %defattr(-,root,root,-), however I think that's all. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 451153] Review Request: mapbender - Geospatial portal for OGC OWS architectures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=451153 Balint Cristian re...@rdsor.ro changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Balint Cristian re...@rdsor.ro 2009-01-04 07:29:43 EDT --- New Package CVS Request === Package Name: mapbender Short Description: Geospatial portal for OGC OWS architectures Owners: rezso Branches: F-8 F-9 F-10 devel -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478744] New: Review Request: wmfire - WindowMaker dock app that displays cpu, memory or network load as flames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: wmfire - WindowMaker dock app that displays cpu, memory or network load as flames https://bugzilla.redhat.com/show_bug.cgi?id=478744 Summary: Review Request: wmfire - WindowMaker dock app that displays cpu, memory or network load as flames Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: st...@lonetwin.net QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://lonetwin.net/wmfire.spec SRPM URL: http://lonetwin.net/wmfire-1.2.3-1.fc10.src.rpm Description: wmfire is a WindowMaker dock app which displays cpu, memory, or network load as flames with a docked icon. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476720] Review Request: beteckna-sfd-fonts - Beteckna fonts
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=476720
Nicolas Mailhot nicolas.mail...@laposte.net changed:
What|Removed |Added
Status|NEW |ASSIGNED
Flag||needinfo?(sanjay_an...@yaho
||o.co.in)
--- Comment #5 from Nicolas Mailhot nicolas.mail...@laposte.net 2009-01-04
12:51:16 EDT ---
Looks nice so here is a complete review:
1. probably better to use
%define archivename %{fontname}-%{version}
2. The summary needs a little work
(for example 'Geometric sans-serif font inspired by Futura')
3. you do not need to add sfd to the name, renaming is only a requirement for
OFL fonts, GPL does not require it
4. beteckna.se seems dead, no need to reference it in the description
5. we already have a licensing field, do not include The font is free,
licensed under terms of the GNU GPL in the description
6. You're wrapping your description lines too short, Fedora standard is 79
columns not 50
7. do package AUTHORS LICENSE CHANGELOG as %doc too
8. I see beteckna is actually 3 different font families: Beteckna,
BetecknaLowerCase, Beteckna Small Caps. Please package them in 3 different
subpackages using the -multi template (the two families which do not have a
correct uppercase/lowercase mix are probably more fantasy than sans-serif
fonts anyway)
9.[not a blocker] Please ask upstream to consider adding the FSF Font exception
to their licensing so the font can be used by people who embed fonts in PDF
files
10. Please change the category of the wiki page describing the font so other
packagers see they need not work on it
http://fedoraproject.org/wiki/Beteckna_fonts
(see the help in http://fedoraproject.org/wiki/Font_description_template )
You do not need a packager sponsorship for this, just a Fedora FAS account
Anyway that's all mostly small stuff and nothing that should be too hard for
you to fix.
⇒ NEEDINFO in the meanwhile
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478662] Review Request: dustismo-fonts - font with serif and sans-serif versions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478662 Nicolas Mailhot nicolas.mail...@laposte.net changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|nicolas.mail...@laposte.net Flag||fedora-review?, ||needinfo?(s...@lank.es) --- Comment #4 from Nicolas Mailhot nicolas.mail...@laposte.net 2009-01-04 05:56:13 EDT --- Hi Sven, Thank you for this new font package! Dustimo is a neat font that suffers from a missing upstream. We'll accept it nevertheless, but please continue to try getting an upstream response even after the package integration (sfd sources, addition of the font exception to the license). Anyway: — Right now the best font source is probably Debian, as the font was created for this distribution. They have a more current dustimo.zip in their ttf-dustin package (20030318) — Please make separate sans and sans-serif subpackages using the multi template in fontpackages-devel — Please add fontconfig declarations to each subpackage. It's not difficult, just fill in the basic template in fontpackages-devel (you can ask for help on the list if you have a problem at some point) — you don't really need to add an archivename if its value is the same as fontname — please don't deviate from the template and use the provided macros or we'll have no end of problems lates ⇒ NEEDINFO till this is taken care of -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 451153] Review Request: mapbender - Geospatial portal for OGC OWS architectures
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=451153
Lubomir Rintel lkund...@v3.sk changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #5 from Lubomir Rintel lkund...@v3.sk 2009-01-04 07:10:59 EDT ---
Just a few minor issues/notes:
1.) The license seems to be GPL 2 or newer, therefore GPLv2+, please correct
the License tag
2.) What is %contentdir for?
You do:
%define contentdir /var/www
mkdir -p -m0755 %{buildroot}%{contentdir}/html
Yet you do not seem to be putting anything there, nor is it included in the
resulting package.
3.) This does not look very nice:
set +x
for f in `find . -type f` ; do
if file $f | grep -q ISO-8859 ; then
I'm not sure whether it's safe to rely on libmagic, since as far as I know (I
may be wrong as well..), it identifies the charset used by the first few
(kilo?) bytes, not reading the whole file. Why not convert all files -- it may
be that iconving all files may be even faster than, or at least comparable,
with calling file against them.
set -x
iconv -f ISO-8859-1 -t UTF-8 $f ${f}.tmp \
mv -f ${f}.tmp $f
I'm not sure about use of here. I think you should break the build if iconv
fails instead of leaving a stale .tmp file.
Also, a good habit is to preserve timestamp -- touch -r $f $f.tmp before mv.
set +x
fi
if file $f | grep -q CRLF ; then
I'd say you don't have to call file here as well. It is safe to remove all
\r-s.
set -x
sed -i -e 's|\r||g' $f
set +x
fi
done
set -x
Given none of these are serious enough to warrant a blocker, the package is
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457955] Review Request: bonvenocf-fonts - BonvenoCF font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457955 Nicolas Mailhot nicolas.mail...@laposte.net changed: What|Removed |Added Flag||needinfo?(sanjay_an...@yaho ||o.co.in) --- Comment #17 from Nicolas Mailhot nicolas.mail...@laposte.net 2009-01-04 12:00:35 EDT --- . -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478628] Review Request: dhcping - DHCP daemon ping program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478628 --- Comment #3 from Marek Mahut mma...@redhat.com 2009-01-04 14:54:22 EDT --- Fabian, do you mind to maintain it in EL-5? I'd like to see this package there. If not, I'll take it. Thank you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 451153] Review Request: mapbender - Geospatial portal for OGC OWS architectures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=451153 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Status|NEW |ASSIGNED Flag|fedora-cvs? |fedora-cvs+ --- Comment #8 from Kevin Fenzi ke...@tummy.com 2009-01-04 15:07:09 EDT --- F-8 branches are no longer accepted. Please do remember to fix the License before import. cvs done for the rest. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478616] Review Request: srm - Secure file deletion
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478616 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Status|NEW |ASSIGNED Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Kevin Fenzi ke...@tummy.com 2009-01-04 15:03:44 EDT --- cvs done. note that this package doesn't seem to obey the normal rpm CFLAGS. You might need to patch the Makefile or otherwise get it to use them... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462181] Review Request: teeworlds - Online multi-player platform 2D shooter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462181 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Status|NEW |ASSIGNED Flag|fedora-cvs? |fedora-cvs+ --- Comment #17 from Kevin Fenzi ke...@tummy.com 2009-01-04 15:09:37 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 471754] Review Request: virtaal - Localization and translation editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=471754 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #12 from Kevin Fenzi ke...@tummy.com 2009-01-04 15:16:08 EDT --- ok, sounds good. Nothing preventing them, just that we like to avoid making them if they aren't needed. cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478628] Review Request: dhcping - DHCP daemon ping program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478628 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Status|NEW |ASSIGNED Flag|fedora-cvs? |fedora-cvs+ --- Comment #4 from Kevin Fenzi ke...@tummy.com 2009-01-04 15:13:40 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478563] Review Request: libnice - GLib ICE implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478563 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Kevin Fenzi ke...@tummy.com 2009-01-04 15:16:56 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 472060] Review Request: mumbles - growl like notification system for gnome
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472060 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #22 from Kevin Fenzi ke...@tummy.com 2009-01-04 15:19:06 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478614] Review Request: python-transitfeed - Google Transit Feed Specification library and tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478614 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #6 from Kevin Fenzi ke...@tummy.com 2009-01-04 15:21:28 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478655] Review Request: sion - GIO/GVFS management application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478655 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #6 from Kevin Fenzi ke...@tummy.com 2009-01-04 15:20:14 EDT --- Good catch. I will fix that before importing. cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 463912] Review Request: tinyows - WFS-T and FE implementation server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463912 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Status|NEW |ASSIGNED Flag|fedora-cvs? |fedora-cvs+ --- Comment #6 from Kevin Fenzi ke...@tummy.com 2009-01-04 15:11:41 EDT --- F-8 branches are no longer accepted. cvs done for the rest. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478593] Review Request: fspy - Filesystem activity monitoring utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478593 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #4 from Kevin Fenzi ke...@tummy.com 2009-01-04 15:25:11 EDT --- Additionally, there is no need to BuildRequire: glibc-devel. Thats always pulled in by gcc, which is in the base set of packages you can assume are present. cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478620] Review Request: conspy - Remote control for text mode virtual consoles
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478620 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Kevin Fenzi ke...@tummy.com 2009-01-04 15:28:35 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478659] Review Request: xfce4-screenshooter - Screenshot utility for the Xfce desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478659 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #4 from Kevin Fenzi ke...@tummy.com 2009-01-04 15:29:56 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473718] Review Request: perl-Directory-Scratch-Structured - Creates temporary files and directories from a structured description
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473718 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #7 from Kevin Fenzi ke...@tummy.com 2009-01-04 15:31:53 EDT --- cvs done. BTW, your cvs requests for perl packages recently don't seem to have perl-sig as a CC. Is that an oversight? If you want me to go back and add that to a list of packages, just email me the request. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459944] Review Request: pfstools - Programs for handling high-dynamic range images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459944 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #25 from Kevin Fenzi ke...@tummy.com 2009-01-04 15:36:33 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478504] Review Request: gget - Download Manager for the GNOME desktop.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478504 Christoph Wickert fed...@christoph-wickert.de changed: What|Removed |Added Status|NEW |ASSIGNED CC||fed...@christoph-wickert.de AssignedTo|nob...@fedoraproject.org|fed...@christoph-wickert.de Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478368] Review Request: linsmith - a Smith Charting program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478368 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #7 from Kevin Fenzi ke...@tummy.com 2009-01-04 15:32:58 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478345] Review Request: mr - A multiple repository management tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478345 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #5 from Kevin Fenzi ke...@tummy.com 2009-01-04 15:37:38 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478533] Review Request: hyphen-fr - French Hyphenation rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478533 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Kevin Fenzi ke...@tummy.com 2009-01-04 15:40:18 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478290] Review Request: screenie - A small and lightweight screen wrapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478290 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #4 from Kevin Fenzi ke...@tummy.com 2009-01-04 15:39:18 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475508] Review Request: javassist - The Java Programming Assistant provides simple Java bytecode manipulation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475508 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #7 from Kevin Fenzi ke...@tummy.com 2009-01-04 15:45:24 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475032] Review Request: gnaural - A multi-platform programmable binaural-beat generator.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475032 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #10 from Kevin Fenzi ke...@tummy.com 2009-01-04 15:42:23 EDT --- F-8 branches are no longer accepted. cvs done for the rest. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427996] Review Request: xqilla - XQilla is an XQuery and XPath 2.0 library, built on top of Xerces-C
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=427996 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #11 from Kevin Fenzi ke...@tummy.com 2009-01-04 15:48:32 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478581] Package Review: pnglite - A lightweight C library for loading PNG images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478581 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #4 from Kevin Fenzi ke...@tummy.com 2009-01-04 15:47:35 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477338] Review Request: php-pecl-imagick - Provides a wrapper to the ImageMagick library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=477338
--- Comment #3 from Pavel Alexeev pa...@hubbitus.spb.su 2009-01-04 15:43:01
EDT ---
(In reply to comment #1)
A few notes :
- License is PHP, not BSD (according to pecl.php.net)
Off course. It has initialy 'PHP License' which is not correct, and I
erroneously wasn't find PHP in list...
- must use %setup -q -c (to not have package.xml outside the build tree)
Ok, I add -c flag
- missing require for ABI check : php(zend-abi)
Hm... I fully borrow %if...%endif statement for that from your spec-file...
Updated later: I found this in doc by link provided by you.
- should use %{pecl_install} and %{pecl_uninstall} when exists
Ok. This is good note, thank you.
- why PEAR in sumnary ?
Because description from it.
Right, removed.
- should add example directory in %doc (rather than each files)
Ok.
Read : http://fedoraproject.org/wiki/Packaging/PHP
Thanks a lot.
(In reply to comment #2)
Also
- use %{php_extdir} instead of %{_libdir}/php/modules
- use %{pecl_xmldir} instead of your %{xmldir}
Done.
As the package is available in my little testing repo, you can have a look to
http://rpms.famillecollet.com/SPEC/php-pecl-imagick.spec
Yes, I have seen this new in your blog. Thank you for help.
Your spec-file was very useful , but it also has some shortcomings (such as
undocumented options documented only what its is undocumented :) in config,
created from SPEC...)
http://hubbitus.net.ru/rpm/Fedora9/php-pecl-imagick/php-pecl-imagick-2.2.1-2.fc9.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478614] Review Request: python-transitfeed - Google Transit Feed Specification library and tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478614 --- Comment #7 from Ian Weller ianwel...@gmail.com 2009-01-04 15:27:01 EDT --- Thanks, Kevin. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478767] New: Review Request: spring - Realtime strategy game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: spring - Realtime strategy game https://bugzilla.redhat.com/show_bug.cgi?id=478767 Summary: Review Request: spring - Realtime strategy game Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: gau...@free.fr QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://gauret.free.fr/fichiers/rpms/fedora/spring/spring.spec SRPM URL: http://gauret.free.fr/fichiers/rpms/fedora/spring/spring-0.77-1.b5.fc10.src.rpm Description: Spring is a project to create a realtime stategy game inspired by Total Anihilation (by Cavedog). There are 4 packages involved in bringing spring to Fedora : - spring (this one): the engine and a meta-package - spring-installer: GUI to install maps and mods - springlobby: the lobby, i.e. the GUI for the engine (main GUI) - spring-maps-default: a default set of maps for Spring I will post the links to the review bugs below. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478769] New: Review Request: spring-installer - Installer for the Spring game's maps and mods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: spring-installer - Installer for the Spring game's maps and mods https://bugzilla.redhat.com/show_bug.cgi?id=478769 Summary: Review Request: spring-installer - Installer for the Spring game's maps and mods Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: gau...@free.fr QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://gauret.free.fr/fichiers/rpms/fedora/spring/spring-installer.spec SRPM URL: http://gauret.free.fr/fichiers/rpms/fedora/spring/spring-installer-20081228-1.fc10.src.rpm Description: Spring Installer is a GTK+ program that will install your Spring mods and maps for you. CA Installer is a GTK+ program that will install and keep up to date, the Spring, Complete Annihilation mod. Please see Spring's main review bug for details : bug 478767. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 472060] Review Request: mumbles - growl like notification system for gnome
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472060 --- Comment #23 from Fedora Update System upda...@fedoraproject.org 2009-01-04 16:23:30 EDT --- mumbles-0.4-8.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/mumbles-0.4-8.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478770] New: Review Request: springlobby - A lobby client for the spring RTS game engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: springlobby - A lobby client for the spring RTS game engine https://bugzilla.redhat.com/show_bug.cgi?id=478770 Summary: Review Request: springlobby - A lobby client for the spring RTS game engine Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: gau...@free.fr QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://gauret.free.fr/fichiers/rpms/fedora/spring/springlobby.spec SRPM URL: http://gauret.free.fr/fichiers/rpms/fedora/spring/springlobby-0.0.1.10372-1.fc10.src.rpm Description: SpringLobby is a free cross-platform lobby client for the Spring RTS project. Please see Spring's main review bug for details : bug 478767. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478771] Review Request: spring-maps-default - Default maps for Spring
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478771 Aurelien Bompard gau...@free.fr changed: What|Removed |Added Blocks||478767 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478770] Review Request: springlobby - A lobby client for the spring RTS game engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478770 Aurelien Bompard gau...@free.fr changed: What|Removed |Added Blocks||478767 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478769] Review Request: spring-installer - Installer for the Spring game's maps and mods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478769 Aurelien Bompard gau...@free.fr changed: What|Removed |Added Blocks||478767 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478767] Review Request: spring - Realtime strategy game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478767 Aurelien Bompard gau...@free.fr changed: What|Removed |Added Depends on||478769, 478770, 478771 --- Comment #1 from Aurelien Bompard gau...@free.fr 2009-01-04 16:29:26 EDT --- Here are the other review bugs: - spring-installer: bug 478769 - springlobby: bug 478770 - spring-maps-default: bug 478771 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478771] New: Review Request: spring-maps-default - Default maps for Spring
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: spring-maps-default - Default maps for Spring https://bugzilla.redhat.com/show_bug.cgi?id=478771 Summary: Review Request: spring-maps-default - Default maps for Spring Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: gau...@free.fr QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://gauret.free.fr/fichiers/rpms/fedora/spring/spring-maps-default.spec SRPM URL: http://gauret.free.fr/fichiers/rpms/fedora/spring/spring-maps-default-0.1-1.fc10.src.rpm Description: This package contains the default maps for Spring: Small Divide, Comet Catcher Redux, and Sands of War Please see Spring's main review bug for details : bug 478767. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478662] Review Request: dustismo-fonts - font with serif and sans-serif versions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478662 Sven Lankes s...@lank.es changed: What|Removed |Added Flag|needinfo?(s...@lank.es) | --- Comment #5 from Sven Lankes s...@lank.es 2009-01-04 16:31:52 EDT --- (In reply to comment #4) Spec-URL: http://sven.lank.es/Fedora/SPECS/dustismo-fonts.spec SRPM-URL: http://sven.lank.es/Fedora/SRPM/dustismo-fonts-20030318-1.fc11.src.rpm Updated SPEC - the spec should address all the issues you listed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467627] Review Request: fsniper - A tool that monitors directories for new files and invokes scripts on them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467627 --- Comment #5 from Jakub Hrozek jhro...@redhat.com 2009-01-04 16:44:23 EDT --- (In reply to comment #4) It looks like the patch included in the srpm is neither the one that you have submitted to http://bugs.l3ib.org/index.php?do=detailstask_id=21, nor the one approved by Andrew Yates (andrewy). You use 077 in the bundled patch, suggest 177 and Andrew uses 0177. I suggest to create a new src.rpm with http://code.l3ib.org/?p=fsniper.git;a=blobdiff;f=src/main.c;h=cd49dffebe4b4c728b62c28c1381c4fb6f5ad87d;hp=03a8d701d6f9802ba346b591429e58741ca53479;hb=82cb0b46c48485fd4f6231ce3169c7be87d1ea07;hpb=2bbeb5d6e6b55bb9692c043fcdbeab15d9723c9e as patch Yep, you're right, thanks for the sharp eye. I'll fix the srpm, as soon as I get some free time..hopefully this week. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 471754] Review Request: virtaal - Localization and translation editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=471754 --- Comment #13 from Dwayne Bailey dwa...@translate.org.za 2009-01-04 16:43:53 EDT --- Fabian, Brennan and Kevin - thanks for your work and effort to get this package in. Happy 2009 to all of you... I'm busy getting the sources into CVS as I type this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478655] Review Request: sion - GIO/GVFS management application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478655 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #7 from Kevin Fenzi ke...@tummy.com 2009-01-04 16:52:20 EDT --- Imported and built. Thanks for the review! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
