[Bug 467854] Review Request: parprouted - Proxy ARP IP bridging daemon

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467854


Paulo Roma Cavalcanti pro...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||CURRENTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 472676] Review Request: partimage

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472676


Paulo Roma Cavalcanti pro...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||CURRENTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481482] Review Request: perl-Perl6-Junction - Perl6 style Junction operators in Perl5

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481482


Marcela Maslanova mmasl...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|mmasl...@redhat.com
   Flag||fedora-review+




--- Comment #1 from Marcela Maslanova mmasl...@redhat.com  2009-01-27 
03:08:01 EDT ---
OK source files match upstream: 0d94cc39ac646175ad38451ef752e982
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
OK license field matches the actual license.
OK license is open source-compatible. License text not included upstream.
OK latest version is being packaged.
OK BuildRequires are proper.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
  http://koji.fedoraproject.org/koji/taskinfo?taskID=1085238
OK debuginfo package isn't need.
OK rpmlint is silent.
OK final provides and requires look sane.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK no duplicates in %files.
OK file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.

Please remove the empty lines from description before build.

ACCEPTED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481173] Review Request: libnss-pgsql - NSS library that interface with PostgreSQL

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481173





--- Comment #8 from Edouard Bourguignon ma...@linuxed.net  2009-01-27 
03:09:15 EDT ---
thank you

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 451298] Review Request: purple-msn-pecan - Alternative MSN protocol plugin for libpurple

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=451298





--- Comment #31 from Edouard Bourguignon ma...@linuxed.net  2009-01-27 
03:09:06 EDT ---
Thank you

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481701] New: Review Request: python-TraitsGUI - Traits-capable windowing framework

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: python-TraitsGUI - Traits-capable windowing framework

https://bugzilla.redhat.com/show_bug.cgi?id=481701

   Summary: Review Request: python-TraitsGUI - Traits-capable
windowing framework
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: rakesh.pan...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Description:
The TraitsGUI project contains a toolkit-independent GUI abstraction layer
(known as Pyface), which is used to support the visualization features of the
Traits package.

SPEC: http://rakesh.fedorapeople.org/spec/python-TraitsGUI.spec
SRPM: http://rakesh.fedorapeople.org/srpm/python-TraitsGUI-3.0.3-1.fc10.src.rpm

Need for Mayavi packaging.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481508] Review Request: pipviewer - Visualizer for multiple alignments of genomic sequences

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481508


Marcela Maslanova mmasl...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|mmasl...@redhat.com




--- Comment #1 from Marcela Maslanova mmasl...@redhat.com  2009-01-27 
03:26:18 EDT ---
OK source files match upstream: 6da4d203440470d2709f3894e648b4aa
OK package meets naming and versioning guidelines.
FAIL specfile is properly named, is cleanly written and uses macros 
consistently.
- RPM_BUILD_ROOT vs. buildroot - use only one of these macros
OK dist tag is present.
OK build root is correct.
FAIL license field matches the actual license.
- You can find GPLv3+ in COPYING and PKG-INFO
OK license is open source-compatible. License text not included upstream.
OK latest version is being packaged.
OK BuildRequires are proper.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package isn't need.
OK rpmlint is silent.
OK final provides and requires look sane.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK no duplicates in %files.
OK file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481695] Review Request: python-TraitsBackendQt - PyQt backend for Traits and TraitsGUI

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481695





--- Comment #2 from Rakesh Pandit rakesh.pan...@gmail.com  2009-01-27 
03:51:38 EDT ---
http://rakesh.fedorapeople.org/srpm/python-TraitsBackendQt-3.0.3-3.fc10.src.rpm
http://rakesh.fedorapeople.org/spec/python-TraitsBackendQt.spec

pasted wrong spec earlier.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481701] Review Request: python-TraitsGUI - Traits-capable windowing framework

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481701





--- Comment #1 from Rakesh Pandit rakesh.pan...@gmail.com  2009-01-27 
03:52:12 EDT ---
SPEC: http://rakesh.fedorapeople.org/spec/python-TraitsGUI.spec
SRPM: http://rakesh.fedorapeople.org/srpm/python-TraitsGUI-3.0.3-2.fc10.src.rpm

Fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 479835] Review Request: log4c - an application message logging library

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479835





--- Comment #6 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2009-01-27 
03:53:36 EDT ---
About automake .m4 file:

My recognition is that we have not reached consensus yet about
whether every packaging shipping aclocal .m4 files should have
Requires: automake or not. c.f.
http://www.redhat.com/archives/fedora-packaging/2007-October/msg00046.html

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481564] Review Request: bind-to-tinydns - Convert DNS zone files in BIND format to tinydns format

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481564





--- Comment #2 from Tim Jackson r...@timj.co.uk  2009-01-27 04:19:24 EDT ---
(In reply to comment #1)
 Can you follow the packaging source url guidelines ?

Sure, I can't imagine why that's not there - must have been having a bad day or
something when I originally wrote the spec. Updated.

 Can you merge this 2 lines in only one ?
 
 mkdir -p $RPM_BUILD_ROOT%{_bindir}
 install -m 755 bind-to-tinydns $RPM_BUILD_ROOT%{_bindir}/
 
 something like this
 install -Dp -m 755 bind-to-tinydns $RPM_BUILD_ROOT%{_bindir}/bind-to-tinydns

Yes, but it's unnecessary. However I've changed it to avoid any debate.

Spec URL:
http://fedorapeople.org/~timj/packaging/bind-to-tinydns/bind-to-tinydns.spec
SRPM URL:
http://fedorapeople.org/~timj/packaging/bind-to-tinydns/bind-to-tinydns-0.4.3-2.el5.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 479835] Review Request: log4c - an application message logging library

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479835





--- Comment #7 from Alex Hudson (Fedora Address) fed...@alexhudson.com  
2009-01-27 04:29:27 EDT ---
Guys,

Thanks very much for the comments - I have a better appreciation of the
automake issue now; I had just thought about it in terms of what dependencies
are needed to develop? instead of the technical directory ownership issue. 

It does seem on the face of it that moving /usr/share/aclocal to filesystem
would be a good idea, or at least some new automake-macros package which can
then be required and not bring in the entire automake system. However, that's
obviously something which needs agreement project-wide.

So in that context, I suspect the best solution right now is Requires:
automake. It solves the guideline issue, and it's consistent with other -devel
packages. I can put a comment in the spec. about keeping a weather-eye out for
changes to that, but I imagine there would be some mass bug-posting if that
changed anyway.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481513] Review Request: sugar-pippy - Pippy for Sugar

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481513





--- Comment #1 from Fabian Affolter fab...@bernewireless.net  2009-01-27 
04:50:05 EDT ---
This activity is more or less working on Fedora.  Some examples/scripts need
olpcgames.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468491] Review Request: sugar-connect - Connect for Sugar

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468491





--- Comment #3 from Fabian Affolter fab...@bernewireless.net  2009-01-27 
04:47:56 EDT ---
Thanks Steven for the review.

(In reply to comment #1)

 ??  SOURCE1: sugar-connect-checkout.sh  ??
 Not sure what the purpose of this is.  Not used during the creation of the 
 SRPM
 or build process.

This is the script to checkout the source code from the VCS.  The reason why
this is 'SOURCE1' is that everybody, especially the reviewer, is able to
checkout the source the same way as I did.  I know it is a bit unusual but this
way I can reuse it easily and it's part of the Source RPM.

The bug about the release tarball is open for three months now.
https://dev.laptop.org/ticket/8966

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481521] Review Request: sugar-clock - Clock activity for Sugar

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481521





--- Comment #1 from Fabian Affolter fab...@bernewireless.net  2009-01-27 
05:00:41 EDT ---
After a short test it shows that this activity is working on Fedora.  I think
that the sound is not working if there is any.  Same problem as in
https://bugzilla.redhat.com/show_bug.cgi?id=467644

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481272] Review Request: python-webunit - it test your websites with code that acts like a web browser

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481272


Richard Jones r1chardj0...@gmail.com changed:

   What|Removed |Added

 CC||r1chardj0...@gmail.com




--- Comment #5 from Richard Jones r1chardj0...@gmail.com  2009-01-27 05:02:58 
EDT ---
The license text may be found at the end of the README file. If you need it to 
be in a separate file I grant you permission to copy it there.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468491] Review Request: sugar-connect - Connect for Sugar

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468491


Fabian Affolter fab...@bernewireless.net changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #4 from Fabian Affolter fab...@bernewireless.net  2009-01-27 
05:01:49 EDT ---
New Package CVS Request
===
Package Name:   sugar-connect
Short Description:  Connect for Sugar
Owners:  fab
Branches: F-10
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481272] Review Request: python-webunit - it test your websites with code that acts like a web browser

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481272





--- Comment #6 from Richard Jones r1chardj0...@gmail.com  2009-01-27 05:03:34 
EDT ---
(In reply to comment #5)
 The license text may be found at the end of the README file. If you need it 
 to 
 be in a separate file I grant you permission to copy it there.

ps. I am the author of webunit

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478393] Review Request: sugar-imageviewer - Simple image viewer for Sugar

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478393


Fabian Affolter fab...@bernewireless.net changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #2 from Fabian Affolter fab...@bernewireless.net  2009-01-27 
05:00:17 EDT ---
New Package CVS Request
===
Package Name:   sugar-imageviewer
Short Description:   Simple image viewer for Sugar
Owners:  fab
Branches: F-10
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480146] Review Request: python-bicyclerepair - Python Refactoring Browser

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480146





--- Comment #6 from Jerome Soyer sai...@gmail.com  2009-01-27 05:37:41 EDT ---
Hi, excuse me i'm away for a couple of days.

I see the error but haven't got any 64bits machine to test, it's due to %{_lib}
in chmod command under 64bits which try to use /usr/lib64 and all
python-bicyclerpair files are un /usr/lib.

I think i must patch the setup.py or something else.

Will see.

Thanks for the build log.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481717] Review Request: ugene - genome analysis suite

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481717





--- Comment #1 from Ivan Efremov iefre...@unipro.ru  2009-01-27 06:01:28 EDT 
---
Note: this is my first package in fedora so I need a sponsorship

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481717] New: Review Request: ugene - genome analysis suite

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: ugene - genome analysis suite

https://bugzilla.redhat.com/show_bug.cgi?id=481717

   Summary: Review Request: ugene - genome analysis suite
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: iefre...@unipro.ru
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://ugene.unipro.ru/downloads/ugene.spec
SRPM URL: http://ugene.unipro.ru/downloads/ugene-1.3.2-1.src.rpm
Description: 
Review is needed for UGENE - complex bioinformatics toolkit based on Qt.

Unipro UGENE is a cross-platform visual environment for DNA and protein
sequence analysis. UGENE integrates the most important bioinformatics
computational algorithms and provides an easy-to-use GUI for performing
complex analysis of the genomic data. One of the main features of UGENE
is a designer for custom bioinformatics workflows.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 462311] Review Request: raidutils - Utilities to manage Adaptec I2O compliant RAID controllers

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462311





--- Comment #5 from Dominik 'Rathann' Mierzejewski r...@greysector.net  
2009-01-27 05:59:27 EDT ---
(In reply to comment #4)
 (In reply to comment #3)
  This software is from 2005. Why do you need you still need this ?
  Why Fedora tools aren't enought for Adaptec support. (dmraid should support
  most hardware raid controller nowadays)
 
 I need this for an old Adaptec (formerly DPT) hardware RAID controller. 
 Frankly
 I haven't tried using dmraid to access it. I'll investigate that.

OK, I've checked dmraid and it seems to support only various fakeRAID
controllers. Adaptec/DPT 2400A is a real hardware RAID and raidutils are
necessary to monitor and manage it without rebooting and entering controller
BIOS setup.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481717] Review Request: ugene - genome analysis suite

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481717


Ivan Efremov iefre...@unipro.ru changed:

   What|Removed |Added

 Blocks||177841




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478007] Review Request: vmware-requirements - Installs packages needed for VMware's virtualization programs to run

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478007


Itamar Reis Peixoto ita...@ispbrasil.com.br changed:

   What|Removed |Added

 Blocks|182235  |




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481725] New: Review Request: python-setupdocs - Setuptools plugin

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: python-setupdocs -  Setuptools plugin

https://bugzilla.redhat.com/show_bug.cgi?id=481725

   Summary: Review Request: python-setupdocs -  Setuptools plugin
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: rakesh.pan...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Description:
Setuptools plugin that automates building of docs from ReST source.

SPEC: http://rakesh.fedorapeople.org/spec/python-setupdocs.spec
SRPM: http://rakesh.fedorapeople.org/srpm/python-setupdocs-1.0.1-1.fc10.src.rpm

Required for packaging Mayavi

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481695] Review Request: python-TraitsBackendQt - PyQt backend for Traits and TraitsGUI

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481695


Rakesh Pandit rakesh.pan...@gmail.com changed:

   What|Removed |Added

 Blocks||481701




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481701] Review Request: python-TraitsGUI - Traits-capable windowing framework

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481701


Rakesh Pandit rakesh.pan...@gmail.com changed:

   What|Removed |Added

 Depends on||481695




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480727] Review Request: daemontools: is a collection of tools for managing UNIX services.

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480727





--- Comment #24 from _pjp_ pj.pan...@yahoo.co.in  2009-01-27 06:59:03 EDT ---
(In reply to comment #22)
 http://qmail.kldp.org/src/patches/glibc-2.3.1/daemontools-0.76.errno.patch

  is it different than saying -include /usr/include/errno.h?

 but if you want to use patch there are no problem, but create one patch for
 each change for example.

  Are you kidding, one patch for each change? May I know what's the advantage
of doing that??

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480727] Review Request: daemontools: is a collection of tools for managing UNIX services.

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480727





--- Comment #25 from _pjp_ pj.pan...@yahoo.co.in  2009-01-27 07:02:39 EDT ---
 sed -i -e \
 s!^gcc.*\$!%{__cc} ${RPM_OPT_FLAGS} -include /usr/include/errno.h!
 src/conf-cc
 sed -i -e \
 s!^gcc.*\$!%{__cc} ${RPM_OPT_FLAGS}! src/conf-ld

  Yeah, may be that looks clean. But still I fail to see how it is helpful.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481717] Review Request: ugene - genome analysis suite

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481717


Fabian Affolter fab...@bernewireless.net changed:

   What|Removed |Added

 CC||fab...@bernewireless.net




--- Comment #2 from Fabian Affolter fab...@bernewireless.net  2009-01-27 
07:14:31 EDT ---
Some quick comments on your spec file

- Please place the changelog section at the end of the file.  It's not wrong
just unusual.
- Please add the dist tag to Release - 'Release: 1%{?dist}'
- You don't need to define macros at the beginning of the file.  'Name:' and
'Version:' are already macros.  But you must use macros in the %files section
  https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#Macros
- Please preserve the time stamps, use ' make install DESTDIR=%{buildroot}
INSTALL=install -p ' if possible instead of ' make install
INSTALL_ROOT=%{buildroot} '
- This application has a GUI.  You need to install the .desktop file.
  https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files
- COPYRIGHT and LICENSE must be added as %doc in the %files section.  Maybe
adding the sample files (out of data/samples in the source) is also a good
idea. 
- There are 'unowned directories' in your %files section.
  https://fedoraproject.org/wiki/Packaging/UnownedDirectories

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 479515] Review Request: Music Organizer - Music Organizer , organize your mp3, ogg, flac and mp4

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479515


Fabian Affolter fab...@bernewireless.net changed:

   What|Removed |Added

   Flag||needinfo?(camillegal...@yah
   ||oo.fr)




--- Comment #2 from Fabian Affolter fab...@bernewireless.net  2009-01-27 
07:18:23 EDT ---
Any progress on this?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 475799] Review Request: pidgin-musictracker - Pidgin displays the musictrack currently playing in your status

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475799


Fabian Affolter fab...@bernewireless.net changed:

   What|Removed |Added

   Flag||needinfo?(watchm...@bol.com
   ||.br)




--- Comment #18 from Fabian Affolter fab...@bernewireless.net  2009-01-27 
07:20:25 EDT ---
Any progress on this bug?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478609] Review Request: djmount - Mounts UPnP Audio/Video/Photo shares as FUSE filesystems.

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478609





--- Comment #5 from Fabian Affolter fab...@bernewireless.net  2009-01-27 
07:18:42 EDT ---
Any progress on this?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481725] Review Request: python-setupdocs - Setuptools plugin

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481725


Rakesh Pandit rakesh.pan...@gmail.com changed:

   What|Removed |Added

 Blocks||481727




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481727] New: Review Request: python-EnvisageCore - Extensible Application Framework

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request:  python-EnvisageCore - Extensible Application Framework

https://bugzilla.redhat.com/show_bug.cgi?id=481727

   Summary: Review Request:  python-EnvisageCore - Extensible
Application Framework
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: rakesh.pan...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
Depends on: 481725
   Estimated Hours: 0.0
Classification: Fedora


Description:
Envisage is a Python-based framework for building extensible
applications, that is, applications whose functionality can be
extended by adding plug-ins. Envisage provides a standard mechanism
for features to be added to an application, whether by the original
developer or by someone else.

SPEC: http://rakesh.fedorapeople.org/spec/python-EnvisageCore.spec
SRPM:
http://rakesh.fedorapeople.org/srpm/python-EnvisageCore-3.0.1-1.fc10.src.rpm

Need for Mayavi package

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480727] Review Request: daemontools: is a collection of tools for managing UNIX services.

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480727





--- Comment #26 from _pjp_ pj.pan...@yahoo.co.in  2009-01-27 07:32:19 EDT ---
(In reply to comment #23)
 sed -i -e \
 s!^gcc.*\$!%{__cc} ${RPM_OPT_FLAGS} -include /usr/include/errno.h!
 src/conf-cc

  Wait, this changes the whole command in src/conf-cc, I don't think that's
intended, do you?


 sed -i -e \
 s!^gcc.*\$!%{__cc} ${RPM_OPT_FLAGS}! src/conf-ld

  How/where do you set this RPM_OPT_FLAGS?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480860] Review Request: timespan - A tool that performs date-based time calculations

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480860





--- Comment #2 from Fabian Affolter fab...@bernewireless.net  2009-01-27 
07:35:13 EDT ---
Usually I like the freedom to choose from several applications with similar
functionality but your reason not to go on with this review is quite good.  I
don't want to waste your time.  Let's drop this review request.

At the other hand it's a simple package and a simple review.  Maybe a person
who is seeking a sponsor would like to review this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478372] Review request: Mathgl - Scientific plotting library.

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478372


Fabian Affolter fab...@bernewireless.net changed:

   What|Removed |Added

 CC||fab...@bernewireless.net




--- Comment #4 from Fabian Affolter fab...@bernewireless.net  2009-01-27 
07:32:47 EDT ---
Some comment for me.

- Summary without package name would be nice (as UDAV :-) )
- Please preserve the time stamps, use ' make install DESTDIR=%{buildroot}
INSTALL=install -p ' if possible instead of ' make install
INSTALL_ROOT=%{buildroot} '
- Use '%defattr(-,root,root,-)' instead of '%defattr(-, root, root)'


(In reply to comment #3)
 rpmlint output (spec, SRPM and RPM):
 mathgl.i386: W: shared-lib-calls-exit /usr/lib/libmgl-glut.so.5.0.0
 e...@glibc_2.0

Will the upstream fix this issue?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 476973] Review Request: eclipse-rpmstubby - Rpm specfile generator for Eclipse features

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476973





--- Comment #5 from Alexander Kurtakov akurt...@redhat.com  2009-01-27 
07:40:30 EDT ---
Builded in rawhide now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481731] New: Review Request: resource-agents - Open Source HA Resource Agents for Red Hat Cluster

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: resource-agents - Open Source HA Resource Agents for 
Red Hat Cluster

https://bugzilla.redhat.com/show_bug.cgi?id=481731

   Summary: Review Request: resource-agents - Open Source HA
Resource Agents for Red Hat Cluster
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: fdini...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL: http://fabbione.fedorapeople.org/ras/01/resource-agents.spec
SRPM URL:
http://fabbione.fedorapeople.org/ras/01/resource-agents-3.0.0-1.alpha3.fc11.src.rpm
Description: Red Hat Resource Agents provides a set of scripts to interface
with several services to operate in a High Availability environment.

The resource-agents are, at this point in time, released together with cluster
(srpm). Upstream has been evaluating for sometime the area that receives the
most frequent updates. resource agents is one of them. by separating the agents
into its own tarball and rpm it makes updates a lot simpler for everybody.

This package will replace parts of rgmanager rpm once approved (see also note
in the spec file). rgmanager will be update accordingly at the right time as I
don't want to break rgmanager functionalities in a transition phase while this
package is reviewed.

thanks
Fabio

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481732] Review Request: stardict-english-czech - czech dictionary for stardict

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481732


Petr Sklenar pskle...@redhat.com changed:

   What|Removed |Added

 Blocks||177841




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480538] Review Request: iptux -- a tool for sharing and transporting files and directories in Lan

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480538





--- Comment #7 from Simon Wesp cassmod...@fedoraproject.org  2009-01-27 
07:54:15 EDT ---
https://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

Some tipps:
- List of Sponsors
  https://admin.fedoraproject.org/accounts/group/members/packager/*/sponsor

- show that you have an understanding of the process and of the 
  packaging guidelines
  https://fedoraproject.org/wiki/PackageMaintainers/Join#Read_the_Guidelines
  a) try to find other reviews and give tipps to make theyr rpms better
(at the time you are not sponsored, you can not do a formal review)
  b) submit other review requests (with enough quality) 

- Are you a member of the mailinglists?
 
https://fedoraproject.org/wiki/PackageMaintainers/Join#Join_the_important_Mailing_Lists


for your package:
take a look at the rpm-opt-flags (Jochen told you, i haven't take a look on it
yet)
https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481732] New: Review Request: stardict-english-czech - czech dictionary for stardict

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request:  stardict-english-czech - czech dictionary for stardict

https://bugzilla.redhat.com/show_bug.cgi?id=481732

   Summary: Review Request:  stardict-english-czech - czech
dictionary for stardict
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: pskle...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL: http://people.redhat.com/psklenar/stardict-english-czech.spec
SRPM URL:
http://people.redhat.com/psklenar/stardict-english-czech-1.0.0-1.fc10.src.rpmCzech
dictionaries for StarDict.

Description:

This is autogenerated dictionary for StarDict.
Data were downloaded from following website:
GNU/FDL: http://slovnik.zcu.cz/

Dictionary was generated using:
GNU/FDL Anglicko-Český slovník to stardict converter version 1.2
You can get conversion script from:
http://cihar.com/software/slovnik

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481725] Review Request: python-setupdocs - Setuptools plugin

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481725


Rakesh Pandit rakesh.pan...@gmail.com changed:

   What|Removed |Added

 Blocks||481734




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481727] Review Request: python-EnvisageCore - Extensible Application Framework

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481727


Rakesh Pandit rakesh.pan...@gmail.com changed:

   What|Removed |Added

 Blocks||481734




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480860] Review Request: timespan - A tool that performs date-based time calculations

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480860


manuel wolfshant wo...@nobugconsulting.ro changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
 CC||wo...@nobugconsulting.ro
 AssignedTo|wo...@nobugconsulting.ro|nob...@fedoraproject.org
   Flag|fedora-review?  |




--- Comment #3 from manuel wolfshant wo...@nobugconsulting.ro  2009-01-27 
07:53:19 EDT ---
I am sorry , I did not want to imply that there is a problem or something. It's
just that I simply find it useless.

I like your idea with leaving this review for someone seeking for sponsorship.
Unassigning...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481734] New: Review Request: python-EnvisagePlugins - Plug-ins for the Envisage framework

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request:  python-EnvisagePlugins - Plug-ins for the Envisage 
framework

https://bugzilla.redhat.com/show_bug.cgi?id=481734

   Summary: Review Request:  python-EnvisagePlugins - Plug-ins for
the Envisage framework
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: rakesh.pan...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
Depends on: 481725,481727
   Estimated Hours: 0.0
Classification: Fedora


Description:
The EnvisagePlugins project includes a number of plug-ins for the
Envisage framework that Enthought has found useful for building
scientific applications.

SPEC: http://rakesh.fedorapeople.org/spec/python-EnvisagePlugins.spec
SRPM:
http://rakesh.fedorapeople.org/srpm/python-EnvisagePlugins-3.0.1-1.fc10.src.rpm

Need for Mayavi

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 476973] Review Request: eclipse-rpmstubby - Rpm specfile generator for Eclipse features

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476973


Alexander Kurtakov akurt...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481732] Review Request: stardict-english-czech - czech dictionary for stardict

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481732





--- Comment #1 from Petr Sklenar pskle...@redhat.com  2009-01-27 08:06:16 EDT 
---
Hello, this is my second package, I am seeking sponsor like at bug 481272

There is GNU/FDL licence in separate file
/usr/share/doc/stardict-english-czech-20081201/README

Should I rename it to 'LICENSE' or is it OK? Original author has this name of
file for licence.

I made mistake for URL in first comment, this is right URL: 
Spec URL: http://people.redhat.com/psklenar/stardict-english-czech.spec
SRPM URL:
http://people.redhat.com/psklenar/stardict-english-czech-1.0.0-1.fc10.src.rpm

Czech dictionaries for StarDict.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 479594] Review Request: email - A command line SMTP client

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479594





--- Comment #2 from Fabian Affolter fab...@bernewireless.net  2009-01-27 
08:06:44 EDT ---
The release history of 'email' goes back till 2001.  I guess that those guys
definitely aren't going to change the name.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481732] Review Request: stardict-english-czech - czech dictionary for stardict

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481732





--- Comment #2 from manuel wolfshant wo...@nobugconsulting.ro  2009-01-27 
08:13:36 EDT ---
No, it is not necessary to rename the files from the source (unless there is a
very good reason, for instance in order to avoid a conflict with another
package)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481725] Review Request: python-setupdocs - Setuptools plugin

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481725


Rakesh Pandit rakesh.pan...@gmail.com changed:

   What|Removed |Added

 Blocks||481738




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481738] New: Review Request: python-EnthoughtBase - Core packages for the Enthought Tool Suite

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: python-EnthoughtBase - Core packages for the Enthought 
Tool Suite

https://bugzilla.redhat.com/show_bug.cgi?id=481738

   Summary: Review Request: python-EnthoughtBase - Core packages
for the Enthought Tool Suite
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: rakesh.pan...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
Depends on: 481725
   Estimated Hours: 0.0
Classification: Fedora


Description:

The EnthoughtBase project includes a few core packages that are used
by many other projects in the Enthought Tool Suite:

* enthought.etsconfig: Supports configuring settings that need to
  be shared across multiple projects or programs on the same
  system.

* enthought.logger: Provides convenience functions for creating
  logging handlers.

* enthought.util: Provides miscellaneous utility functions.

SPEC: http://rakesh.fedorapeople.org/spec/python-EnthoughtBase.spec
SRPM:
http://rakesh.fedorapeople.org/srpm/python-EnthoughtBase-3.0.1-1.fc10.src.rpm

Need for Mayavi

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481738] Review Request: python-EnthoughtBase - Core package for the Enthought Tool Suite

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481738


Rakesh Pandit rakesh.pan...@gmail.com changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |python-EnthoughtBase - Core |python-EnthoughtBase - Core
   |packages for the Enthought  |package for the Enthought
   |Tool Suite  |Tool Suite




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480886] Review Request: tse3 - MIDI Sequencer Engine

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480886


Michael Schwendt bugs.mich...@gmx.net changed:

   What|Removed |Added

 CC||bugs.mich...@gmx.net




--- Comment #10 from Michael Schwendt bugs.mich...@gmx.net  2009-01-27 
08:26:42 EDT ---
 Requires:   %{name} == %{version}-%{release}

Does that work?

 %install
 make install DESTDIR=%{buildroot} INSTALL=install -p \

rm -rf %{buildroot} is missing as the first cmd in %install section.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478452] Review Request: libxnm - A library for parsing the XNM format

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478452


Michael Schwendt bugs.mich...@gmx.net changed:

   What|Removed |Added

 CC||bugs.mich...@gmx.net




--- Comment #5 from Michael Schwendt bugs.mich...@gmx.net  2009-01-27 
08:23:43 EDT ---
 + Does owns the directories it creates.

Directory %{_includedir}/xnm/ is not included. This can easily be seen in the
spec file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478452] Review Request: libxnm - A library for parsing the XNM format

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478452





--- Comment #6 from Fabian Affolter fab...@bernewireless.net  2009-01-27 
08:42:19 EDT ---
(In reply to comment #5)
  + Does owns the directories it creates.
 
 Directory %{_includedir}/xnm/ is not included. This can easily be seen in the
 spec file.

Yes, this need to be fixed before the import.  Thanks Michael.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481751] New: Review Request: fence-agentes - Fence Agents for Red Hat Cluster

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: fence-agentes - Fence Agents for Red Hat Cluster

https://bugzilla.redhat.com/show_bug.cgi?id=481751

   Summary: Review Request: fence-agentes - Fence Agents for Red
Hat Cluster
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: fdini...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL: http://fabbione.fedorapeople.org/fas/01/fence-agents.spec
SRPM URL:
http://fabbione.fedorapeople.org/fas/01/fence-agents-3.0.0-1.alpha3.fc11.src.rpm
Description: Red Hat Fence Agents is a collection of scripts to handle remote 
power management for several devices.

The fence-agents are, at this point in time, released together with cluster
(srpm). Upstream has been evaluating for sometime the area that receives the
most frequent updates. fence agents is one of them. by separating the agents
into its own tarball and rpm it makes updates a lot simpler for everybody.
Other projects, non cluster related, are using those agents now. This split
will allow those external projects to use the agents without pulling in the
whole cluster stack.

This package will replace parts of cman rpm once approved (see also note
in the spec file). cman will be update accordingly at the right time as I
don't want to break cman functionalities in a transition phase while this
package is reviewed.

thanks
Fabio

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481564] Review Request: bind-to-tinydns - Convert DNS zone files in BIND format to tinydns format

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481564


Itamar Reis Peixoto ita...@ispbrasil.com.br changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #3 from Itamar Reis Peixoto ita...@ispbrasil.com.br  2009-01-27 
08:49:45 EDT ---
I can't access your src.rpm files (2009-01-27 11:37:09 ERROR 404: Not Found)

but here are the review.

GOOD - 

- no rpmlint's message.

rpmlint /home/itamar/rpmbuild/SRPMS/bind-to-tinydns-0.4.3-2.fc10.src.rpm \
/home/itamar/rpmbuild/RPMS/x86_64/bind-to-tinydns-0.4.3-2.fc10.x86_64.rpm \
/home/itamar/rpmbuild/RPMS/x86_64/bind-to-tinydns-debuginfo-0.4.3-2.fc10.x86_64.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

- package builds fine in koji (dist-F11)
http://koji.fedoraproject.org/koji/taskinfo?taskID=1085805

- package meets naming and versioning guidelines.
- specfile is properly named, is cleanly written and uses macros consistently.
- dist tag is present.
- latest version is being packaged.
- BuildRequires are proper.
- %clean is present.
- package installs properly.
- debuginfo package looks complete.
- no scriptlets present.
- license is open source-compatible.
- package works as expected

SHOULD VERIFY -
license sounds like GPLv2 for me instead GPLv2+  

I see no  blocker issue


   This package (bind-to-tinydns) is APPROVED by itamarjp


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 479903] Review Request: gdesklet-slideshow - Cycle through a collection of pictures

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479903


Michael Schwendt bugs.mich...@gmx.net changed:

   What|Removed |Added

 CC||bugs.mich...@gmx.net




--- Comment #14 from Michael Schwendt bugs.mich...@gmx.net  2009-01-27 
08:52:33 EDT ---
The original %files section was fine:

 %{_datadir}/gdesklets/Controls/ImageSlideShow/
 %{_datadir}/gdesklets/Displays/SlideShow/

Why did you change it...?

 %dir %{_datadir}/gdesklets/Controls/%{_ctrlname}
 %dir %{_datadir}/gdesklets/Displays/%{_appname}
 %{_datadir}/gdesklets/Controls/%{_ctrlname}/*
 %{_datadir}/gdesklets/Displays/%{_appname}/*

Both are equivalent.


 %setup -q -n %{_appname}
 tar -xf %{SOURCE1} -C ../

The way the two tarballs are extracted is strange. Sure, you can do it like
that, but having to deal with the ../ in subsequent commands decreases the
readability of the spec file. I strongly encourage you to use

%setup -q -c %{name}-%{version} -a1

to extract both tarballs into the same root directory, and then either use your
two macros %_appname and %_ctrlname when accessing files or entering
directories.


The LICENSE, MANIFEST, README and todo files are installed in addition to
%doc, and it is important to note that the LICENSE file must not be removed
from /usr/share/gdesklets/Displays/SlideShow/LICENSE - or else it cannot be
displayed by the desklet.


Opening Configure desklet and selecting a folder from which to load images
always displays an error dialog:

| The folder contents could not be displayed
| 
| Operation not supported

It seems it always starts in the root directory due to that.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480886] Review Request: tse3 - MIDI Sequencer Engine

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480886





--- Comment #11 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2009-01-27 
09:00:38 EDT ---
(In reply to comment #10)
  Requires:   %{name} == %{version}-%{release}
 
 Does that work?

Yes (at least on F-9/10/11)


  %install
  make install DESTDIR=%{buildroot} INSTALL=install -p \
 
 rm -rf %{buildroot} is missing as the first cmd in %install section.

Sorry for not pointing this out...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481564] Review Request: bind-to-tinydns - Convert DNS zone files in BIND format to tinydns format

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481564


manuel wolfshant wo...@nobugconsulting.ro changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Flag|fedora-review+  |fedora-review?




--- Comment #4 from manuel wolfshant wo...@nobugconsulting.ro  2009-01-27 
09:00:17 EDT ---
The build step does not respect the mandatory compiling flags:

cc -Wall -g -o bind-to-tinydns bind-to-tinydns.c
bind-to-tinydns.c: In function 'handle_entry':
bind-to-tinydns.c:610: warning: pointer targets in passing argument 1 of
'str_to_uint' differ in signedness
bind-to-tinydns.c: In function 'main':
bind-to-tinydns.c:969: warning: pointer targets in passing argument 5 of
'handle_entry' differ in signedness
+ exit 0


this must be fixed before approval.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 479978] Review Request: libnewmat - Newmat C++ matrix library

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479978





--- Comment #3 from Michael Schwendt bugs.mich...@gmx.net  2009-01-27 
09:04:13 EDT ---
 -shared -Wl,-soname,libnewmat.so.10.4 

 ln -s libnewmat.so.10.4 libnewmat.so.10

Are you sure you didn't want the soname to be libnewmat.so.10?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481564] Review Request: bind-to-tinydns - Convert DNS zone files in BIND format to tinydns format

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481564


manuel wolfshant wo...@nobugconsulting.ro changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|ita...@ispbrasil.com.br




--- Comment #5 from manuel wolfshant wo...@nobugconsulting.ro  2009-01-27 
09:01:43 EDT ---
 Itamar, please assign the bug to yourself and change the status from NEW to
ASSIGNED when you perform a review. Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481034] Review Request: coccinelle - Semantic patching for Linux (spatch)

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481034





--- Comment #11 from Michal Schmidt mschm...@redhat.com  2009-01-27 09:03:26 
EDT ---
I don't think %{_libdir} is the correct path for the stub lib. Other ocaml-*
packages put them in %{_libdir}/ocaml/stublibs/. And they have a *.so.owner
file there too. I don't how that file is created.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481725] Review Request: python-setupdocs - Setuptools plugin

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481725


Rakesh Pandit rakesh.pan...@gmail.com changed:

   What|Removed |Added

 Blocks||481759




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225854] Merge Review: gperf

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225854





--- Comment #4 from Roman Rakus rra...@redhat.com  2009-01-27 09:16:47 EDT ---
Created an attachment (id=330088)
 -- (https://bugzilla.redhat.com/attachment.cgi?id=330088)
gperf specfile

Roman, thank you for taking action. I think, I've forgotten the suggestion
of preserving timestamps before and to avoid the usage of %makeinstall, thus
we recommend packagers to use instead:

  make DESTDIR=$RPM_BUILD_ROOT install INSTALL='install -p'


Ok. I changed it to make install. But why to use install -p?

Regarding the documentation I'm not really happy. We've currently much more 
documentation rather rest of gperf inside of the package.

We've multiple options: Creating -docs subpackage and moving everything out 
there OR just kill the huge *.ps from %doc (*.ps vs. *.pdf seems to be a bit
redundant and *.pdf is usually better searchable) - last of it was accepted
and got told to be useful in Freenode #fedora-devel, #fedora-de by several 
packagers.

Choose what you like as packager and let me know. I can deal with both or
even a better option - afterwards we should be (hopefully) fine with review.

I removed *.ps files.

I am including specfile for review. Maybe there is something more and I'd like
to prevent many useless builds.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481759] New: Review Request: python-Apptools - Enthough Tool Suite Application Tools

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: python-Apptools - Enthough Tool Suite Application Tools

https://bugzilla.redhat.com/show_bug.cgi?id=481759

   Summary: Review Request: python-Apptools - Enthough Tool Suite
Application Tools
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: rakesh.pan...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
Depends on: 481725
   Estimated Hours: 0.0
Classification: Fedora


Description of problem:

The AppTools project includes a set of packages that Enthought has
found useful in creating a number of applications. They implement
functionality that is commonly needed by many applications

* enthought.appscripting: Framework for scripting applications.

* enthought.help: Provides a plugin for displaying documents and
  examples and running demos in Envisage Workbench applications.

* enthought.io: Provides an abstraction for files and folders in a
  file system.

* enthought.naming: Manages naming contexts, supporting non-string
  data types and scoped preferences

* enthought.permissions: Supports limiting access to parts of an
  application unless the user is appropriately authorised (not
  full-blown security).

and many more.

SPEC: http://rakesh.fedorapeople.org/spec/python-AppTools.spec
SRPM: http://rakesh.fedorapeople.org/srpm/python-AppTools-3.1.0-1.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 479978] Review Request: libnewmat - Newmat C++ matrix library

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479978





--- Comment #4 from Pascal pascal...@parois.net  2009-01-27 09:35:05 EDT ---
You are right, it's a mistake.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225854] Merge Review: gperf

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225854


Robert Scheck red...@linuxnetz.de changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #5 from Robert Scheck red...@linuxnetz.de  2009-01-27 09:37:12 
EDT ---
A 'install -p' makes install preserving the original timestamps of the files
it is installing (e.g. for stuff like man pages or non-generated files during
build). That's optional and nice to see for people (whether something changed
or not), but just suggested.

Spec file from comment #4 looks fine to me now, thus: APPROVED.

Thank you, Roman for solving the issues fast. Please close this bug report,
once you've applied the changes from comment #4 into CVS.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481411] Review Request: perl-Test-Email - Test email contents

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481411


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review+




--- Comment #1 from Parag AN(पराग) panem...@gmail.com  2009-01-27 09:43:23 
EDT ---
+ is OK
- Need work

Review:
+ package builds in mock (rawhide i386).
koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=1085955
+ rpmlint is silent for SRPM
- rpmlint is NOT silent for RPM.
perl-Test-Email.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/perl-Test-Email-0.04/Changes
perl-Test-Email.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/perl-Test-Email-0.04/README
==This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

+ source files match upstream url
bb409977cffb292cd85d80d10506f59e  Test-Email-0.04.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
All tests successful.
Files=1, Tests=7,  0 wallclock secs ( 0.01 usr  0.00 sys +  0.15 cusr  0.01
csys =  0.17 CPU)
+ Package  perl-Test-Email-0.04-1.fc11 -
Provides: perl(Test::Email) = 0.04 perl(Test::POP3) = 0.05
Requires: perl(Carp) perl(MIME::Parser) perl(Mail::POP3Client)
perl(Test::Builder) perl(Test::Email) perl(base) perl(strict) perl(warnings)

Suggestion:-
1) Fix rpmlint message before importing to cvs.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467402] Review Request: mingw32-glib2 - MinGW Windows GLib2 library

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467402





--- Comment #17 from Levente Farkas lfar...@lfarkas.org  2009-01-27 09:50:21 
EDT ---
for #9 is there any reason you not pushed 43.6 or 44.1 to f10 and epel?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467401] Review Request: mingw32-libjpeg - MinGW Windows Libjpeg library

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467401


Levente Farkas lfar...@lfarkas.org changed:

   What|Removed |Added

 CC||lfar...@lfarkas.org




--- Comment #4 from Levente Farkas lfar...@lfarkas.org  2009-01-27 09:51:28 
EDT ---
Adam, will you take this review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478452] Review Request: libxnm - A library for parsing the XNM format

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478452





--- Comment #7 from Parag AN(पराग) panem...@gmail.com  2009-01-27 09:23:19 
EDT ---
(In reply to comment #5)
  + Does owns the directories it creates.
 
 Directory %{_includedir}/xnm/ is not included. This can easily be seen in the
 spec file.

aha. Thanks for catching that.
I missed that when I looked into output of 
rpm -qlvp libxnm-devel-0.1.2-1.fc11.i386.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481564] Review Request: bind-to-tinydns - Convert DNS zone files in BIND format to tinydns format

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481564





--- Comment #6 from Tim Jackson r...@timj.co.uk  2009-01-27 09:24:41 EDT ---
Sorry, the SRPM was:
http://fedorapeople.org/~timj/packaging/bind-to-tinydns/bind-to-tinydns-
0.4.3-2.src.rpm

Since no specific license version is explicitly specified by the author, it
should actually be marked as GPL+ as per
https://fedoraproject.org/wiki/Licensing#Good_Licenses

This is corrected in
http://fedorapeople.org/~timj/packaging/bind-to-tinydns/bind-to-tinydns-0.4.3-3.src.rpm
and the corresponding spec.

Manuel, those are warnings only in the compiler output; the package builds
successfully on all architectures and whilst it would be better if they weren't
there, as far as I can see there is nothing in the Packaging Guidelines stating
that all compiler warnings must be patched out.

Final point: I am intending to only import this on the EL-5 branch so if anyone
wants to co-maintain in devel/F-10/F-9 then let me know.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481701] Review Request: python-TraitsGUI - Traits-capable windowing framework

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481701


Rakesh Pandit rakesh.pan...@gmail.com changed:

   What|Removed |Added

 Depends on|481695  |




--- Comment #2 from Rakesh Pandit rakesh.pan...@gmail.com  2009-01-27 
09:57:40 EDT ---
removed dependency - not applicable.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481695] Review Request: python-TraitsBackendQt - PyQt backend for Traits and TraitsGUI

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481695


Rakesh Pandit rakesh.pan...@gmail.com changed:

   What|Removed |Added

 Blocks|481701  |




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225854] Merge Review: gperf

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225854


Roman Rakus rra...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




--- Comment #6 from Roman Rakus rra...@redhat.com  2009-01-27 09:58:03 EDT ---
Hmm, I think, noone looks at timestamps, but ok.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 472525] Review Request: kio_sysinfo - KIO slave which shows basic system information

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472525





--- Comment #1 from Rex Dieter rdie...@math.unl.edu  2009-01-27 10:06:15 EDT 
---
Hrm... looks like we kinda forgot about this... let's see if we can get this
reviewed soonish, and push with (or near after) kde-4.2.0.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 475000] Review Request: cmconvert - CacheMate import file converter

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475000


Thorsten Leemhuis fed...@leemhuis.info changed:

   What|Removed |Added

 CC||fed...@leemhuis.info




--- Comment #16 from Thorsten Leemhuis fed...@leemhuis.info  2009-01-27 
10:02:05 EDT ---
Fabian,

(In reply to comment #5)
 - Use make install DESTDIR=%{buildroot} INSTALL=install -p to preserve the
 timestamps instead of make install DESTDIR=%{buildroot}

And specific reasons for that? It's likely unneeded. 

This topic recently was discussed on 
https://bugzilla.rpmfusion.org/show_bug.cgi?id=195#c9 and 
http://lists.rpmfusion.org/pipermail/rpmfusion-developers/2009-January/003546.html

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431047] Review Request: latencytop - System latency monitor

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=431047


Michal Schmidt mschm...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481564] Review Request: bind-to-tinydns - Convert DNS zone files in BIND format to tinydns format

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481564





--- Comment #8 from Itamar Reis Peixoto ita...@ispbrasil.com.br  2009-01-27 
10:11:43 EDT ---
 Manuel, those are warnings only in the compiler output; the package builds
 successfully on all architectures and whilst it would be better if they 
 weren't
 there, as far as I can see there is nothing in the Packaging Guidelines 
 stating
 that all compiler warnings must be patched out.

Manuel is talking about CFLAGS, 

include the patch in Comment #7 and change your spec file to pass the correct
CFLAGS parameters.

make %{?_smp_mflags} CFLAGS=%{optflags}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480727] Review Request: daemontools: is a collection of tools for managing UNIX services.

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480727





--- Comment #27 from Ralf Corsepius rc040...@freenet.de  2009-01-27 10:20:20 
EDT ---
(In reply to comment #26)
 (In reply to comment #23)
  sed -i -e \
  s!^gcc.*\$!%{__cc} ${RPM_OPT_FLAGS} -include /usr/include/errno.h!
  src/conf-cc
 
   Wait, this changes the whole command in src/conf-cc, I don't think that's
 intended, do you?
This is what is intended. It changes the compiler call to acknowledge the
settings rpm-packaging expects it to acknowledge.

It has the same effect as
make CC=%{__cc} CFLAGS=${RPM_OPT_FLAGS} -include /usr/include/errno.h
would have with ordinary Makefiles.

Unfortunately DJB's build-system is special and doesn't allow overriding
settings from the environment, therefore one has to resort to hardcoding
settings (which is what this sed call does).

  sed -i -e \
  s!^gcc.*\$!%{__cc} ${RPM_OPT_FLAGS}! src/conf-ld
 
   How/where do you set this RPM_OPT_FLAGS?
RPM_OPT_FLAGS is an rpm internal variable. It contains the CFLAGS all packages
are supposed to compile with.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481224] Review Request: rabbitmq-server - An AMQP server written in Erlang

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481224


Peter Lemenkov lemen...@gmail.com changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|lemen...@gmail.com
   Flag||fedora-review?




--- Comment #2 from Peter Lemenkov lemen...@gmail.com  2009-01-27 10:18:30 
EDT ---
Ok, I'll review it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481564] Review Request: bind-to-tinydns - Convert DNS zone files in BIND format to tinydns format

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481564





--- Comment #7 from Itamar Reis Peixoto ita...@ispbrasil.com.br  2009-01-27 
10:08:45 EDT ---
Created an attachment (id=330097)
 -- (https://bugzilla.redhat.com/attachment.cgi?id=330097)
change makefile to accept cflags.

change makefile to accept cflags.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481528] Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481528





--- Comment #3 from Itamar Reis Peixoto ita...@ispbrasil.com.br  2009-01-27 
10:29:15 EDT ---
please look now

http://ispbrasil.com.br/perl-DBIx-Safe/perl-DBIx-Safe.spec
http://ispbrasil.com.br/perl-DBIx-Safe/perl-DBIx-Safe-1.2.5-2.fc10.src.rpm

http://koji.fedoraproject.org/koji/taskinfo?taskID=108604

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 472525] Review Request: kio_sysinfo - KIO slave which shows basic system information

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472525





--- Comment #2 from Jaroslav Reznik jrez...@redhat.com  2009-01-27 10:30:21 
EDT ---
I hoped so and asked ltinkl for review several times to review this ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467401] Review Request: mingw32-libjpeg - MinGW Windows Libjpeg library

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467401


Adam Tkac at...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED




--- Comment #5 from Adam Tkac at...@redhat.com  2009-01-27 10:46:19 EDT ---
(In reply to comment #4)
 Adam, will you take this review?

yes, of course. Sorry for late response, I lost this review in my working
queue.

Review:

source files match upstream: YES
package meets naming and versioning guidelines: YES
specfile is properly named, is cleanly written and uses macros consistently:
YES
dist tag is present: YES
build root is correct: YES
license field matches the actual license: YES
license is open source-compatible. YES
latest version is being packaged: YES
BuildRequires are proper: YES
compiler flags are appropriate: YES
%clean is present: YES
package builds in mock (Rawhide/x86_64): YES
rpmlint is silent: NO but errors are ok for mingw32 package
final provides and requires look sane: NO
owns the directories it creates: YES
no duplicates in %files: YES
file permissions are appropriate: YES
code, not content: YES
---

Currently I see one problem - win32 binaries are installed:
/usr/i686-pc-mingw32/sys-root/mingw/bin/cjpeg
/usr/i686-pc-mingw32/sys-root/mingw/bin/djpeg
/usr/i686-pc-mingw32/sys-root/mingw/bin/jpegtran
/usr/i686-pc-mingw32/sys-root/mingw/bin/rdjpgcom
/usr/i686-pc-mingw32/sys-root/mingw/bin/wrjpgcom

Is here any reason to have them installed?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481594] Review Request: python-pygooglechart - A complete Python wrapper for the Google Chart API

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481594





--- Comment #3 from Jochen Schmitt joc...@herr-schmitt.de  2009-01-27 
10:52:44 EDT ---
Good:
+ Package contains verbatin copy of the license text
+ Package contains a %check stanza
+ Local build works fine

Bad:
- Koji build fails. Please refer to
http://koji.fedoraproject.org/koji/taskinfo?taskID=1086077
This is caused by the PyQrCodec issue, If you are unable to fix it, we should
remove the %scheck stanza.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481564] Review Request: bind-to-tinydns - Convert DNS zone files in BIND format to tinydns format

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481564





--- Comment #9 from Tim Jackson r...@timj.co.uk  2009-01-27 10:53:44 EDT ---
Ah, OK. Thanks for spotting that.

New SRPM:
http://fedorapeople.org/~timj/packaging/bind-to-tinydns/bind-to-tinydns-0.4.3-4.src.rpm

Spec:
http://fedorapeople.org/~timj/packaging/bind-to-tinydns/bind-to-tinydns.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481676] blender-wrapper doesn't tweak the user script directory as appropriate.

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481676


Jochen Schmitt joc...@herr-schmitt.de changed:

   What|Removed |Added

 Status|NEW |ASSIGNED




--- Comment #2 from Jochen Schmitt joc...@herr-schmitt.de  2009-01-27 
10:57:09 EDT ---
It may be nice, if you may remove your ¨/.blender directory and try your test
again.

It may be helpful, if you can explain all your steps you have done for your
test.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481411] Review Request: perl-Test-Email - Test email contents

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481411





--- Comment #2 from Ralf Corsepius rc040...@freenet.de  2009-01-27 10:57:45 
EDT ---
Thanks for the reviews, Parag!

New Package CVS Request
===
Package Name: perl-Test-Email
Short Description: Test email contents
Owners: corsepiu
Branches: F-10 F-9
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 365141] Review Request: iotop - Top like utility for I/O

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=365141





--- Comment #9 from Adel Gadllah adel.gadl...@gmail.com  2009-01-27 10:58:06 
EDT ---
(In reply to comment #7)
 iotop requires python 2.5, which neither EL4 nor EL5 have. 
 Did you find some way to port it back to previous python versions?

The python version issue might be fixable, but the kernel support is missing in
RHEL4/5 too..

So no this package is not suitable for EPEL until RHEL6 is released.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225698] Merge Review: dmidecode

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225698





--- Comment #3 from Prarit Bhargava pra...@redhat.com  2009-01-27 11:03:20 
EDT ---
Created an attachment (id=330102)
 -- (https://bugzilla.redhat.com/attachment.cgi?id=330102)
Patch to resolve this issue

I'm waiting for write access to fedora cvs.

I'm also going to ping Alan to see if he wants to remain as the owner.

P.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467401] Review Request: mingw32-libjpeg - MinGW Windows Libjpeg library

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467401





--- Comment #6 from Levente Farkas lfar...@lfarkas.org  2009-01-27 11:07:55 
EDT ---
yes and no. we usually ship those binaries which needed on win32 eg:
openssl.exe the reason for this is that nsis or nsiswrapper can collect all
required libs and exes for the installer and then the final installer can
contain all component which required on win32. however in this case these exe
should have to be called *.exe:-(
i send a patch to the mailing list.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 472144] Review Request: tvbrowser - Free EPG for over 500 stations.

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472144





--- Comment #14 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2009-01-27 
11:15:53 EDT ---
Created an attachment (id=330106)
 -- (https://bugzilla.redhat.com/attachment.cgi?id=330106)
License analysis

License analysis for l2fprod-common and skinlf is attached.

Some files in l2fprod-common and almost all files in skinlf
are under ASL 1.1 (for skinlf, LICENSE text itself shows ASL 1.1).

For skinlf, src/examples/Clock.java has a quite questionable
license clause:
-
ii) Licensee does not utilize the software in a manner
which is disparaging to Sun.
-
I guess this clause is NON-FREE. In Fedora skinlf this file
is currently removed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481594] Review Request: python-pygooglechart - A complete Python wrapper for the Google Chart API

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481594





--- Comment #4 from Michael Stahnke mastah...@gmail.com  2009-01-27 11:23:24 
EDT ---
Yes, it appears that trying to connect to the internet is the problem through
Koji.  The unit tests attempt to contact GoogleCharts.  I actually don't think
it's PyQrCodec.  Either way, the %check has to go. 


Rebuilt:
http://stahnma.fedorapeople.org/reviews/python-pygooglechart-0.2.1-3.fc11.src.rpm
http://stahnma.fedorapeople.org/reviews/python-pygooglechart.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 472525] Review Request: kio_sysinfo - KIO slave which shows basic system information

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472525





--- Comment #3 from Lukáš Tinkl lti...@redhat.com  2009-01-27 11:35:08 EDT ---
Well hopefully after I'm done with the 4.2.0 updates :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 479983] Review Request: emacs-mew - Email client for GNU Emacs

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479983


Jochen Schmitt joc...@herr-schmitt.de changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #11 from Jochen Schmitt joc...@herr-schmitt.de  2009-01-27 
11:36:35 EDT ---
I have done some examinations:

It's seems that something with the F-10 info package is broken. I have found
odd entries in the %{_infodir}/dir file.

After I have built the texinfo package from the devel branch the complainted
issue doesn't occurs anymore.

Because that was the last issue with your package I'm glade that I can APPROVE
your package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


  1   2   3   >