[Bug 484933] Review Request: libwps - Library for reading and converting Microsoft Works word processor documents

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484933





--- Comment #10 from Michael Schwendt bugs.mich...@gmx.net  2009-02-16 
03:26:49 EDT ---
Typically, such test-suites are made to be run after make install, which
means in RPM buildroot installations one needs to consider that:

   %check
   LD_LIBRARY_PATH=$(pwd)/src/lib/.libs make check

I'm certain other packages do something similar.

[...]

cd src/test  make check
make[1]: Entering directory `/home/qa/tmp/rpm/BUILD/libwps-0.1.2/src/test'
./test
Test::testStream : OK
OK (1)
make[1]: Leaving directory `/home/qa/tmp/rpm/BUILD/libwps-0.1.2/src/test'

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 479803] Review Request: cabal2spec - generates spec files for Haskell packages

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479803





--- Comment #11 from Jens Petersen peter...@redhat.com  2009-02-16 03:39:18 
EDT ---
Fixed

Spec URL:
http://petersen.fedorapeople.org/cabal2spec/cabal2spec.spec
SRPM URL:
http://petersen.fedorapeople.org/cabal2spec/cabal2spec-0.6-1.fc10.src.rpm

Noarch:
http://petersen.fedorapeople.org/cabal2spec/cabal2spec-0.6-1.fc10.noarch.rpm

(The project will be hosted very soon at fedorahosted.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485580] Review Request: netactview - Graphical network connections viewer for Linux

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485580





--- Comment #6 from manuel wolfshant wo...@nobugconsulting.ro  2009-02-16 
03:38:55 EDT ---
I do not think that
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database
applies to this case, there is no MimeType key desktop entry.



The author denied my request to add the license to all source files. I am
quoting below our mails and his translated answer:

Deliberately I have not included a header with the license in each file. The
license is specified in the file named COPYING and is relevant to the whole
program with all its files. The program and all its files are licensed as
GPLv2

Based on the content of the COPYING and the header of the main.c files, I think
that it is safe to presume that the author makes no difference between GPLv2
and GPLv2+ and since both files indicate GPLv2+, this is the license to be used
by us.




Delivered-To: wo...@fedoraproject.org
Received: by bastion.fedora.phx.redhat.com (Postfix, from userid 404)
 id 4529F20847C; Sun, 15 Feb 2009 16:18:20 + (UTC)
Received: from mx1.util.phx.redhat.com (mx1.util.phx.redhat.com [10.8.4.92])
 by bastion.fedora.phx.redhat.com (Postfix) with ESMTP id B97852081FB
 for wo...@fedoraproject.org; Sun, 15 Feb 2009 16:18:14 + (UTC)
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
[172.16.52.254])
 by mx1.util.phx.redhat.com (8.13.1/8.13.1) with ESMTP id n1FGIDHU018478
 for wo...@fedoraproject.org; Sun, 15 Feb 2009 11:18:14 -0500
Received: from mx1.redhat.com (mx1.redhat.com [172.16.48.31])
 by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n1FGIDsK001041
 for wo...@fedoraproject.org; Sun, 15 Feb 2009 11:18:13 -0500
Received: from mail-fx0-f10.google.com (mail-fx0-f10.google.com
[209.85.220.10])
 by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n1FGHxAq020472
 for wo...@fedoraproject.org; Sun, 15 Feb 2009 11:18:00 -0500
Received: by fxm3 with SMTP id 3so3277418fxm.17
for wo...@fedoraproject.org; Sun, 15 Feb 2009 08:17:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=gamma;
h=domainkey-signature:mime-version:received:in-reply-to:references
 :date:message-id:subject:from:to:content-type;
bh=DLQZiH7Fh1evsUpENhH8aXdLCHG1tqLvZsK9fxGkgTE=;
b=Nk1rVe4XYZ3daCwHijc/hVE0+P4ialpDxKFP0KaHUbfSHDUC2HQuIFD405JZ7arcKU
 kttOr3s0q0qc9iLXvVTVNcvo6Z+pQdKwA+FrpGoFmggN8NtBp67RTq0R1OatBXNeRcev
 g7iOJ/X2JNraHhh2bK9EJesVqywpsp+I/bIkk=
DomainKey-Signature: a=rsa-sha1; c=nofws;
d=gmail.com; s=gamma;
h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :content-type;
b=duG5Js4Xso5qHHOtetWIFwB27h/H81yxbksICyx6AShyaRBFuDavyHuPV0IswUlwsg
 0fEu84CqE7AdezUW0BMA3gFxoOUfnX6mLksNQsVX+Lqpb50W52tmh6xOJ1+oW87jUL2g
 CSTXo+hMRsA3erbooEMLegUJkr+7bN1g8Ik/c=
MIME-Version: 1.0
Received: by 10.103.241.15 with SMTP id t15mr2381592mur.85.1234714679154; Sun, 
 15 Feb 2009 08:17:59 -0800 (PST)
In-Reply-To: 4997b5c9.7070...@fedoraproject.org
References: 4997b5c9.7070...@fedoraproject.org
Date: Sun, 15 Feb 2009 18:17:59 +0200
Message-ID: 8a5752f30902150817q187a872ajd01433b81e0b3...@mail.gmail.com
Subject: Re: Net Activity Viewer - licenta
From: Mihai Varzaru mih...@gmail.com
To: manuel wolfshant wo...@fedoraproject.org
Content-Type: multipart/alternative; boundary=001636b430c8d999200462f769fe
X-RedHat-Spam-Score: 0.001 
X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254
X-Scanned-By: MIMEDefang 2.63 on 172.16.48.31

--001636b430c8d999200462f769fe
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Nu am inclus in mod intentionat un header cu licenta in fiecare fisier.
Licenta este specificata in fisierul COPYING si se aplica intregului program
cu toate fisierele sale. Programul cu toate fisierele sale sunt licentiate
cu GPL v2.


2009/2/15 manuel wolfshant wo...@fedoraproject.org

  Buna Mihai

 Scuze ca te deranjez, dar am o rugaminte. Programul tau este in curs de
 a fi inclus in Fedora ( https://bugzilla.redhat.com/show_bug.cgi?id=485580),  
 dar in cursul verificarilor premergatoare includerii am observat ca
 fisierele sursa nu au inclusa licenta sub care este distribuit programul
 decit in fisierul main.c. Din considerente legale (in SUA..) este preferabil
 ca fiecare fisier sursa (.h / .c) sa includa un header in care sa fie
 specificata licenta exacta sub care se afla, facilitind astfel si
 posibilitatea ca fisiere din un program sa fie folosite in altul.
 De aceea avem rugamintea sa incluzi si tu aceste informatii in toate
 fisierele sursa.
 Multumesc anticipat

manuel


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 479796] Review Request: ghc-haskell-src-exts - Library for Manipulating Haskell source

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479796





--- Comment #7 from Jens Petersen peter...@redhat.com  2009-02-16 03:49:04 
EDT ---
Created an attachment (id=332010)
 -- (https://bugzilla.redhat.com/attachment.cgi?id=332010)
ghc-haskell-src-exts.spec-1.patch

Sorry to keep moving the goal-posts... I released cabal2spec-0.6.

This little patch should bring this package in line with it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485607] Review Request: SciTools - A Python library for scientific computing

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485607





--- Comment #8 from Joseph Smidt josephsm...@gmail.com  2009-02-16 03:56:01 
EDT ---
Okay, here are the latest files with the +python-pmw grace-pygrace and -%doc
in extras changes:

Spec URL: http://jsmidt.fedorapeople.org/scitools.spec
SRPM URL: http://jsmidt.fedorapeople.org/scitools-0.4-0.3.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 479796] Review Request: ghc-haskell-src-exts - Library for Manipulating Haskell source

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479796





--- Comment #8 from Conrad Meyer kon...@tylerc.org  2009-02-16 04:07:49 EDT 
---
New URLs:
http://konradm.fedorapeople.org/fedora/SPECS/ghc-haskell-src-exts.spec
http://konradm.fedorapeople.org/fedora/SRPMS/ghc-haskell-src-exts-0.4.8-3.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 468189] Review Request: rear - Relax and Recovery (disaster recovery framework)

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468189





--- Comment #28 from Gratien D'haese gratien.dha...@it3.be  2009-02-16 
04:17:05 EDT ---
Hi Robert and Andreas,
Thank you (again) for being so helpful.

Robert,
Yes, you may send me an example of the if clause as you talked about in c#26.
That would be very helpful as a starter.

Andreas,
That sounds fine to me! Thanks.

About SVN I meant that we probably will upload our sources into SVN very soon
so it would become easier for us (and other developers) to sync with the latest
updates.

Please give me a few days (I have a very, very busy week with making a
presentation and a deadline of sub-project) to discuss this over with my friend
Schlomo and to prepare rear for the latest suggestions.

Rgds, Gratien

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 466953] Review Request: perl-NOCpulse-Utils - NOCpulse utility packages

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466953


Miroslav Suchy msu...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485641] Review Request: pdftk - The PDF Toolkit

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485641


Andrew Haley a...@redhat.com changed:

   What|Removed |Added

 CC||a...@redhat.com




--- Comment #2 from Andrew Haley a...@redhat.com  2009-02-16 04:35:14 EDT ---
Yes, this must be caused by automatic dependency generation in RPM.
I suppose the best thing usually is to tell the truth: pdftk needs the
library and itext provides it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 453847] Review Request: grid-packaging-tools - The Grid Packaging Tools (GPT)

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453847


Hans de Goede hdego...@redhat.com changed:

   What|Removed |Added

 CC||hdego...@redhat.com




--- Comment #18 from Hans de Goede hdego...@redhat.com  2009-02-16 04:46:11 
EDT ---
As discussed by mail, after I've reviewed 3 of your submission and deemed them
approvable (the actual approving will happen when you get sponsored) I'll
sponsor you.

Full review done, looks good, I only have a few small nitpicks:

MUST FIX

* You are missing: BuildRequires: perl, note that Requires will not get
installed
  during the build, only BuildRequires (and visa versa during install)
* Source code changes / conversions should be done in %prep, so please move
these 
  3 lines:
iconv -f iso-8859-1 -t utf-8 LICENSE  LICENSE.utf8
touch -c -r LICENSE LICENSE.utf8
mv LICENSE.utf8 LICENSE
  to %prep

SHOULD FIX
--
* Please add a comment as to why you are removing these files:
rm $RPM_BUILD_ROOT%{_sbindir}/gpt-perl-version
rm $RPM_BUILD_ROOT%{_datadir}/globus/globus_core-src.tar.gz
rm $RPM_BUILD_ROOT%{_datadir}/globus/gpt_scripts_list

* It is sort of standard to put %doc in %files the line below %defattr, instead 
  of at the end

* These 2 rpmlint messages:
grid-packaging-tools.noarch: E: non-executable-script
/usr/share/globus/aclocal/bootstrap.frg 0644
grid-packaging-tools.src: W: mixed-use-of-spaces-and-tabs (spaces: line 115,
tab: line 1)

  Simple chmod 755 the bootstrap.frg file, and in your specfile either uses
  tabs everywhere to indent or spaces, do not mix the 2 note that the Fedora
  standard is sort of to use spaces. But you're free to use tabs if you prefer.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 225797] Review Request: gimp-data-extras

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225797


Nils Philippsen nphil...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #19 from Nils Philippsen nphil...@redhat.com  2009-02-16 05:37:52 
EDT ---
(In reply to comment #18)
 APPROVED; just fix up the release to an integer = 1 when you check in.

I've changed that in the SRPM I intend to import. Thanks for reviewing!

New Package CVS Request
===
Package Name: gimp-data-extras
Short Description: Extra files for GIMP
Owners: nphilipp
Branches: F-9 F-10
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485643] Review Request: django-authopenid - Django application to integrate Django authentication system with OpenID

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485643


Peter Lemenkov lemen...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||lemen...@gmail.com
 AssignedTo|nob...@fedoraproject.org|lemen...@gmail.com
   Flag||fedora-review?




--- Comment #1 from Peter Lemenkov lemen...@gmail.com  2009-02-16 06:00:39 
EDT ---
I'll review it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485643] Review Request: django-authopenid - Django application to integrate Django authentication system with OpenID

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485643


Peter Lemenkov lemen...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #2 from Peter Lemenkov lemen...@gmail.com  2009-02-16 06:39:28 
EDT ---
REVIEW:

+ rpmlint is silent:

[pe...@host-12-116 Desktop]$ rpmlint django-authopenid-0.9.6-1.fc10.*
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
[pe...@host-12-116 Desktop]$

+ I'm in doubts about package naming - Django packages in Fedora are named with
first letter capitalized. However the upstream named it with all letters in
lowercase, so I don't think this is a problem at all.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines .
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines .
+ The License field in the package spec file matches the actual license.
+ The file with text of the license, is be included in %doc.
+ The spec file is be written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package matches the upstream source, as
provided in the spec URL.

[pe...@sulaco SOURCES]$ md5sum django-authopenid-0.9.6.tar.gz*
b15d22dd9d83a5c5fa8a0a640b40b3f4  django-authopenid-0.9.6.tar.gz
b15d22dd9d83a5c5fa8a0a640b40b3f4  django-authopenid-0.9.6.tar.gz.from_srpm
[pe...@sulaco SOURCES]$ 

+ The package MUST successfully compiles and builds into binary rpms on at
least one primary architecture.

http://koji.fedoraproject.org/koji/taskinfo?taskID=1129812

+ All build dependencies are listed in BuildRequires.
+ The package owns all directories that it creates.
+ The package does not contain any duplicate files in the %files listing.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ The package consistently uses macros.
+ The package contains code, or permissable content.
+ Everything, that the package includes as %doc, does not affect the runtime of
the application.
+ The package does not own files or directories already owned by other
packages. 
+  At the beginning of %install, the package runs rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ All filenames in the package are valid UTF-8. [26]


APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485668] Review Request: irc-otr - Off-The-Record Messaging plugin for various irc clients

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485668


manuel wolfshant wo...@nobugconsulting.ro changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|wo...@nobugconsulting.ro
   Flag||fedora-review?




--- Comment #3 from manuel wolfshant wo...@nobugconsulting.ro  2009-02-16 
06:42:24 EDT ---
I happen to use xchat :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485693] New: Review Request: hunspell-da - Danish thesaurus

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: hunspell-da - Danish thesaurus

https://bugzilla.redhat.com/show_bug.cgi?id=485693

   Summary: Review Request: hunspell-da - Danish thesaurus
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: caol...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL: http://people.redhat.com/caolanm/rpms/mythes-da.spec
SRPM URL:
http://people.redhat.com/caolanm/rpms/mythes-da-0.1.9-0.1.beta.fc10.src.rpm
Description: Danish thesaurus

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 474356] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474356





--- Comment #17 from Robert Marcano rob...@marcanoonline.com  2009-02-16 
07:24:31 EDT ---
done

http://www.marcanoonline.com/downloads/fedora/package_submissions/trilead-ssh2/trilead-ssh2-213-3.fc10.src.rpm
http://www.marcanoonline.com/downloads/fedora/package_submissions/trilead-ssh2/trilead-ssh2.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485641] Review Request: pdftk - The PDF Toolkit

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485641





--- Comment #3 from Andrew Haley a...@redhat.com  2009-02-16 07:33:43 EDT ---
Thinking about this some more, simply exporting itext-2.1.4.jar.so is probably
wrong.  When itext gets rebuilt, we need to rebuild pdftk as well.  So I think
we're going to need a versioned symlink:

  itext-2.1.4.jar.so - itext-2.1.4-1.fc10.jar.so

and export the full version rather than itext-2.1.4.jar.so.

We don't know for certain that any minor change to itext will require pdftk to
be
recompiled. but it might. so it's safer to insist on an exact build match.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 476720] Review Request: beteckna-sfd-fonts - Beteckna fonts

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476720





--- Comment #9 from Ankur Sinha sanjay.an...@gmail.com  2009-02-16 07:41:11 
EDT ---
Packages:
http://ankursinha.fedorapeople.org/beteckna-0.3/beteckna-sfd-fonts-0.3-3.fc10.src.rpm

http://ankursinha.fedorapeople.org/beteckna-0.3/beteckna-sfd-fonts.spec


It builds fine.. I am still having trouble with the %package etc part.. 
This package too, the rpm names arent as they are supposed to be..

Wrote: /home/Package/rpmbuild/SRPMS/beteckna-sfd-fonts-0.3-3.fc10.src.rpm
Wrote:
/home/Package/rpmbuild/RPMS/noarch/beteckna-sfd-fonts-0.3-3.fc10.noarch.rpm
Wrote:
/home/Package/rpmbuild/RPMS/noarch/beteckna-sfd-fonts-beteckna-sfd-general-fonts-0.3-3.fc10.noarch.rpm
Wrote:
/home/Package/rpmbuild/RPMS/noarch/beteckna-sfd-fonts-beteckna-sfd-lower-case-fonts-0.3-3.fc10.noarch.rpm
Wrote:
/home/Package/rpmbuild/RPMS/noarch/beteckna-sfd-fonts-beteckna-sfd-small-caps-fonts-0.3-3.fc10.noarch.rpm

Ive tried what the multi spec has in it.. Got stuck there.. Doing anything else
with the spec gives me %post file not found.. I've been stuck there for
almost two weeks until i atleast managed to build this. One of you will have to
please tell me how to do that part properly.. 

The fontforge warning/error persists. It gives a 0 exit status though.. Am
waiting for a reply from the mailing list for confirmation.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 453848] Review Request: globus-core - Globus Toolkit - Globus Core

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453848


Hans de Goede hdego...@redhat.com changed:

   What|Removed |Added

 CC||hdego...@redhat.com




--- Comment #6 from Hans de Goede hdego...@redhat.com  2009-02-16 07:44:01 
EDT ---
Not a full review yet but a first round of remarks:

MUST FIX:
-
* Add a comment explaining how to get the Source0 tarbal, so people who want
  to verify its contents against the original can do that
* s390x is a 64 bit arch also
* since the devel subpackage requires the main package there is no need for it
  to own directories which are also owned by the main package


SHOULD FIX:
---
* rpmlint warning:
globus-core.src: W: mixed-use-of-spaces-and-tabs (spaces: line 116, tab: line
1)

* How did you come to the devel / non-devel split. Atleast the aclocal and
doxygen
  files look like devel files to me. Only files which are needed to *run*
globus
  tk using applications should be in the main package, the rest should all be
in
  the devel package

* Given the short list of files in the package I see no need for all the magic
  to generate filelists. Why not just add everything manually (with wildcards)
  to %files, that way it is much clearer what is going on

* Why do you filter out the requires on the gpt modules, the -devel package
  requiring gpt is fine, and if the main package gets auto requires for gpt
  that feels like a hint that the package is not split properly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 476315] Review Request: evolution-mapi - Exchange 2007 support for Evolution

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476315





--- Comment #9 from Matthew Barnes mbar...@redhat.com  2009-02-16 08:04:06 
EDT ---
Update for 0.25.91.  No changes to packaging.

http://mbarnes.fedorapeople.org/mapi/SPECS/evolution-mapi.spec
http://mbarnes.fedorapeople.org/mapi/SRPMS/evolution-mapi-0.25.91-1.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 459751] Review Request: osgGtk - Gtk and Gtkmm widgets for OpenSceneGraph

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459751


Fabian Affolter fab...@bernewireless.net changed:

   What|Removed |Added

 CC||fab...@bernewireless.net




--- Comment #1 from Fabian Affolter fab...@bernewireless.net  2009-02-16 
08:16:02 EDT ---
Just some quick comments

- '--vendor fedora' is obsolete for new packages
- I think that 'Requires: hicolor-icon-theme' is needed
- To make your life easier in the future, change 'Source:
http://download.sourceforge.net/osggtk/osggtk-0.1.2.tar.bz2' to 'Source:
http://download.sourceforge.net/osggtk/osggtk-%{version}.tar.bz2'. Same in
'%setup -q -n osggtk-0.1.2'

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 253813] Package Review: cjkunifonts (split from fonts-chinese) [renamed to cjkuni-fonts]

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=253813


Caius kaio Chance ccha...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 459751] Review Request: osgGtk - Gtk and Gtkmm widgets for OpenSceneGraph

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459751


Michael Schwendt bugs.mich...@gmx.net changed:

   What|Removed |Added

 CC||bugs.mich...@gmx.net




--- Comment #2 from Michael Schwendt bugs.mich...@gmx.net  2009-02-16 
08:41:08 EDT ---
 -n osggtk-0.1.2

-n %{name}-%{version}   is the default.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485424] Review Request: eclipse-birt - Eclipse-based reporting system

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485424





--- Comment #7 from Alexander Kurtakov akurt...@redhat.com  2009-02-16 
09:34:52 EDT ---
Builded in rawhide.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 474356] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474356


Alexander Kurtakov akurt...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #18 from Alexander Kurtakov akurt...@redhat.com  2009-02-16 
09:32:59 EDT ---
OK, There is nothing else holding this review.

This package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485424] Review Request: eclipse-birt - Eclipse-based reporting system

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485424





--- Comment #6 from Alexander Kurtakov akurt...@redhat.com  2009-02-16 
09:34:11 EDT ---
Builded in rawhide.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485424] Review Request: eclipse-birt - Eclipse-based reporting system

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485424


Alexander Kurtakov akurt...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Comment #8 from Alexander Kurtakov akurt...@redhat.com  2009-02-16 
09:35:37 EDT ---
Close.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 484676] Review Request: eclipse-dtp - Eclipse Data Tools Platform

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484676


Alexander Kurtakov akurt...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Comment #7 from Alexander Kurtakov akurt...@redhat.com  2009-02-16 
09:37:59 EDT ---
Packages available in rawhide now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 476471] Review Request: fedora-security-guide - A security guide for Linux

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476471





--- Comment #48 from Eric Christensen e...@christensenplace.us  2009-02-16 
09:55:37 EDT ---
Of course, and it will until a major rewrite of Publican occurs.  Apparently
this is how all RH Publican packages appear.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 481224] Review Request: rabbitmq-server - An AMQP server written in Erlang

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481224





--- Comment #8 from Peter Lemenkov lemen...@gmail.com  2009-02-16 10:38:06 
EDT ---
Ping, Hubert :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 451744] Review Request: root - The CERN analyzer for high to medium energy physics

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=451744





--- Comment #12 from Kostas Georgiou k.georg...@imperial.ac.uk  2009-02-16 
10:51:18 EDT ---
Here is the one that I used http://georgiou.fedorapeople.org/tmp/root.spec not
perfect but it does build a usable 5.22 root.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 477570] Review Request: couchdb - A document database server, accessible via a RESTful JSON API

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=477570





--- Comment #4 from Peter Lemenkov lemen...@gmail.com  2009-02-16 10:34:29 
EDT ---
* I also think that the mochiweb should be excluded and packaged separately.
How different version, shipped with couchdb, from the upstream one? 

* rpmlint warnings (and one error) should be safely ignored.

* Requires: %{_bindir}/icu-config looks ugly. First, is it really need, to
have libicu-devel, to couchdb to work? Second, why you decided to require
%{_bindir}/icu-config instead of libicu-devel?

Other (still remaining) issues from Hubert's notes:

* No need to explicitly require shadow-utils (as Hubert already mentioned).

* Use %{_localstatedir} in sed string and in couchdb_home var instead of /var 

* remove 'exit 0' in %pre

* use %{_initrddir} instead of %{_sysconfdir}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 453847] Review Request: grid-packaging-tools - The Grid Packaging Tools (GPT)

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453847





--- Comment #19 from Mattias Ellert mattias.ell...@fysast.uu.se  2009-02-16 
10:28:49 EDT ---
(In reply to comment #18)
 
 MUST FIX
 
 * You are missing: BuildRequires: perl, note that Requires will not get
 installed
   during the build, only BuildRequires (and visa versa during install)

I know the difference between Requires and BuildRequires, however perl always
got dragged in for me in the default build environment by e.g. rpm-build or
redhat-rpm-config. But an explicit BuildRequires on perl doesn't hurt - added.

 * Source code changes / conversions should be done in %prep, so please move
 these 
   3 lines:
 iconv -f iso-8859-1 -t utf-8 LICENSE  LICENSE.utf8
 touch -c -r LICENSE LICENSE.utf8
 mv LICENSE.utf8 LICENSE
   to %prep

Changed accordingly.

 SHOULD FIX
 --
 * Please add a comment as to why you are removing these files:
 rm $RPM_BUILD_ROOT%{_sbindir}/gpt-perl-version
 rm $RPM_BUILD_ROOT%{_datadir}/globus/globus_core-src.tar.gz
 rm $RPM_BUILD_ROOT%{_datadir}/globus/gpt_scripts_list

Done.

 * It is sort of standard to put %doc in %files the line below %defattr, 
 instead 
   of at the end

Done.

 * These 2 rpmlint messages:
 grid-packaging-tools.noarch: E: non-executable-script
 /usr/share/globus/aclocal/bootstrap.frg 0644
 grid-packaging-tools.src: W: mixed-use-of-spaces-and-tabs (spaces: line 115,
 tab: line 1)

The /usr/share/globus/aclocal/bootstrap.frg file is a script fragment - it is
not intended to be executable standalone. It does have a shebang so that when
put together with other pieces to create a complete script that script will be
executable. Making the fragment executable would silence rpmlint, but it would
contradict the intended usage of the file.

The specfile uses tabs everywhere for indentation. However it is not possible
to enter 1.375 tabs. For this you have do 1 tab + 3 spaces. Line 115 (now 120)
starts with a tab, so I don't see why rpmlint complains about it using spaces
for indentation. If there at some place in the file was a tab immediately
following a space, or a set of 2 or more consecutive spaces crossing or ending
at an even 8 column boundary then the warning would make sense. This is not the
case. I consider this warning a false positive - at least for my
understanding of what mixed-use-of-spaces-and-tabs means.

New version available here:

http://www.grid.tsl.uu.se/repos/globus/info/grid-packaging-tools.spec
http://www.grid.tsl.uu.se/repos/globus/fedora/10/src/SRPMS/grid-packaging-tools-3.2-14.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 474356] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474356


Robert Marcano rob...@marcanoonline.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #19 from Robert Marcano rob...@marcanoonline.com  2009-02-16 
10:15:35 EDT ---
New Package CVS Request
===
Package Name: trilead-ssh2
Short Description: Trilead SSH-2 for Java is a library which implements the
SSH-2 protocol in pure
Owners: robmv
Branches: F-10
InitialCC: robmv

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 479585] Review Request: megaupload-dl - Megaupload automatic downloader

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479585





--- Comment #24 from Marek Mahut mma...@redhat.com  2009-02-16 11:07:21 EDT 
---
(In reply to comment #19)
 Plese refer to
 
 https://fedoraproject.org/wiki/Packaging/Guidelines#Libexecdir
 
 Because the complaints files contains executable code, the files perms should
 set for allow executing of this files.

These files are scripts used from the main executable script. I don't think
they should be executable - nobody will never execute it separately. Looking in
my site-packages directory, no files is set as executable. Also, only very few
__init__.py files starts with shebang.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 453848] Review Request: globus-core - Globus Toolkit - Globus Core

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453848





--- Comment #7 from Mattias Ellert mattias.ell...@fysast.uu.se  2009-02-16 
11:30:07 EDT ---
(In reply to comment #6)

 MUST FIX:
 -
 * Add a comment explaining how to get the Source0 tarbal, so people who want
   to verify its contents against the original can do that

The source was extracted from the globus distribution tarball:

http://www-unix.globus.org/ftppub/gt4/4.2.1/installers/src/gt4.2.1-all-source-installer.tar.bz2

using this script:

http://www.grid.tsl.uu.se/repos/globus/scripts/split-release.sh

I should be able to think up a short comment along those lines (and reuse it
for the other globus packages.)

 * s390x is a 64 bit arch also

I'll add it

 * since the devel subpackage requires the main package there is no need for it
   to own directories which are also owned by the main package

OK I'll fix that. (I previously saw some problems with left-behind orphaned
directories, but I can't seem the reproduce those problems now.)

 SHOULD FIX:
 ---
 * rpmlint warning:
 globus-core.src: W: mixed-use-of-spaces-and-tabs (spaces: line 116, tab: line
 1)

This is the same thing as in the grid-packaging-tools package - I still think
this is a false positive.

 * How did you come to the devel / non-devel split. Atleast the aclocal and
 doxygen
   files look like devel files to me. Only files which are needed to *run*
 globus
   tk using applications should be in the main package, the rest should all be
 in
   the devel package

The globus-core package is very different from the rest of the globus packages.
All of globus-core is devel, none of it is needed at runtime. I did the split
so that architecture independent files are in the main package and the
architecture dependent files are in the devel-package. For a i386 on x86_64
installation you could then install main + devel from x86_64 and devel from
i386. I found that to be the most natural split if a split should be done.
Thinking about it, it might make more sense to just put all the files in main
and not split it into subpackages. You could then still install both i386 and
x86_64 together since the common files would be exactly the same. Is more
sensible?

 * Given the short list of files in the package I see no need for all the magic
   to generate filelists. Why not just add everything manually (with wildcards)
   to %files, that way it is much clearer what is going on

There is no magic here. The split between packages is automatically defined by
gpt. What is done is simply a format conversion form the gpt filelist format to
the rpm filelist format. I agree that in the case of globus-core, which is not
split in so many sub packages you don't gain a lot. The gain is much more
noticeable in packages that generate four or five sub packages. From a package
maintainability point of view it is however much easier to use the same
packaging instructions for all globus packages, though it is a slight overkill
for globus-core.

 * Why do you filter out the requires on the gpt modules, the -devel package
   requiring gpt is fine, and if the main package gets auto requires for gpt
   that feels like a hint that the package is not split properly.

As I said, all of globus-core is really devel. No non-devel package requires
globus-core. However all globus-*-devel packages require globus-core and If you
install a globus-*-devel package for anything else than building other globus
packages you don't need gpt. I really don't like having gpt being dragged in by
anything. I consider this a major feature of the packaging.

I didn't prepare a new package yet, since you indicated that you might have
additional comments already. Let me know if you want me to create a new package
version at this stage.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 476720] Review Request: beteckna-sfd-fonts - Beteckna fonts

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476720





--- Comment #10 from Ankur Sinha sanjay.an...@gmail.com  2009-02-16 11:49:50 
EDT ---
This is what George said about the error,It indicates an internal problem in
fontforge that will sometimes cause
an error. You can correct it by rewriting fontforge's code so that it
handles rounding errors better. This is not something I can do, but if
you can please do so.. I certainly cannot rewrite the code to fontforge. How
should i handle it?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 477570] Review Request: couchdb - A document database server, accessible via a RESTful JSON API

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=477570





--- Comment #5 from Allisson Azevedo allis...@gmail.com  2009-02-16 11:53:41 
EDT ---
Hi Peter,

 * I also think that the mochiweb should be excluded and packaged separately.
 How different version, shipped with couchdb, from the upstream one?
I think is better wait for first official release of mochiweb.

 * Requires: %{_bindir}/icu-config looks ugly. First, is it really need, to
 have libicu-devel, to couchdb to work? Second, why you decided to require
 %{_bindir}/icu-config instead of libicu-devel?
Using requires: libicu-devel results in two erros in rpmlint output:

[allis...@notebook RPMS]$ rpmlint couchdb-0.8.1-3.fc11.i386.rpm 
couchdb.i386: W: non-standard-uid /var/lib/couchdb couchdb
couchdb.i386: W: non-standard-uid /var/run/couchdb couchdb
couchdb.i386: W: non-standard-uid /var/log/couchdb couchdb
couchdb.i386: E: devel-dependency libicu-devel
couchdb.i386: E: explicit-lib-dependency libicu-devel
couchdb.i386: E: invalid-soname
/usr/lib/couchdb/erlang/lib/couch-0.8.1-incubating/priv/lib/couch_erl_driver.so
couch_erl_driver.so
1 packages and 0 specfiles checked; 3 errors, 3 warnings.

 * No need to explicitly require shadow-utils (as Hubert already mentioned).
 * remove 'exit 0' in %pre
I following http://fedoraproject.org/wiki/Packaging/UsersAndGroups

 * use %{_initrddir} instead of %{_sysconfdir}
I don't see is wrong here, i using %{_initrddir}/couchdb for sysvinit script.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 477570] Review Request: couchdb - A document database server, accessible via a RESTful JSON API

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=477570





--- Comment #6 from Allisson Azevedo allis...@gmail.com  2009-02-16 11:57:00 
EDT ---
Update package:

Spec URL: http://allisson.fedorapeople.org/packages/couchdb/couchdb.spec

SRPM URL:
http://allisson.fedorapeople.org/packages/couchdb/couchdb-0.8.1-3.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 457916] Review Request: lmbench - lmbench benchmark tools

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457916


Tom spot Callaway tcall...@redhat.com changed:

   What|Removed |Added

   Flag|needinfo?(tcall...@redhat.c |
   |om) |




--- Comment #11 from Tom spot Callaway tcall...@redhat.com  2009-02-16 
12:12:06 EDT ---
(In reply to comment #10)

 spot, can we ship this?

Nope. Those use restrictions clearly make lmbench non-free.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 457916] Review Request: lmbench - lmbench benchmark tools

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457916


Eric Sandeen esand...@redhat.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||CANTFIX




--- Comment #12 from Eric Sandeen esand...@redhat.com  2009-02-16 12:21:45 
EDT ---
Thanks Spot, thought so but wanted the official word. :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 480857] Review Request: pdumpfs - Daily backup system

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480857





--- Comment #6 from Henrique LonelySpooky Junior henrique...@gmail.com  
2009-02-16 12:39:51 EDT ---
Hi, Fabian. Ja man pages added. Thanks a lot.
SPEC: http://lonelyspooky.com/fedora/packages/pdumpfs/1.3-4/pdumpfs.spec
SRPM:
http://lonelyspooky.com/fedora/packages/pdumpfs/1.3-4/pdumpfs-1.3-4.fc10.src.rpm

(I'm having some troubles with my fedora peolpe account.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 476404] Review Request: bullet - 3D Collision Detection and Rigid Body Dynamics Library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476404





--- Comment #19 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2009-02-16 
12:46:07 EDT ---
Created an attachment (id=332070)
 -- (https://bugzilla.redhat.com/attachment.cgi?id=332070)
License in need of audit - no2

To spot:

This time would you review the license of the file attached?
It seems that I overlooked this file in the previous check,

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 476404] Review Request: bullet - 3D Collision Detection and Rigid Body Dynamics Library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476404





--- Comment #20 from Tom spot Callaway tcall...@redhat.com  2009-02-16 
12:50:59 EDT ---
That's an MIT variant, no problem.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485607] Review Request: SciTools - A Python library for scientific computing

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485607





--- Comment #9 from Joseph Smidt josephsm...@gmail.com  2009-02-16 12:51:30 
EDT ---
Feedback from the upstream author:



I've examined the files in the bin directory and removed some of the
too specialized files and also modified/updated some of them.
Now the directory contains

_gnuplot.py gnuplot.bat pyreport
file2interactive.py profiler.py regression.py
floatdiff.pyps2mpeg.py  subst.py

All of these, except pyreport, are scripts developed or used in my
Python for Computational Science book (a new README file in the bin
directory briefly explains what the remaining files here are used
for).  The files may well go to another bin directory (/usr/local/bin,
for instance). The only problem I can foresee is that they go to a
directory that users do not have in their PATH.

Another possibility is to say that these files (except pyreport) are
for the mentioned book only, and since this book has a special bin
directory I can easily move them there. This is okay with me if
SciTools users do not think they lose much. What they lose is
basically the following:

gnuplot.bat, _gnuplot.py: ability to run Gnuplot on Windows as it is run on
Unix

file2interactive.py: quick creation of interactive sessions (maybe more a
utility for a book writer...)

profiler.py: trivial front-end, but makes profiling a one-line command

regression.py, floatdiff.py: original tools supporting regression tests with
floating-point numbers (i.e., reference results change with hardware)

subst.py: cross-platform sed-like substitution command

pyreport in this dir allows the original pyreport program to work with
scitools.easyviz.

Tell me what you think. An update to v0.6 was just committed to the
svn repository (incl. the updates mentioned above).


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 480857] Review Request: pdumpfs - Daily backup system

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480857





--- Comment #7 from Henrique LonelySpooky Junior henrique...@gmail.com  
2009-02-16 12:57:28 EDT ---
New Package CVS Request
===
Package Name: pdumpfs
Short Description: Daily backup system
Owners: lspooky
Branches: F-9 F-10
InitialCC: fab

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 480857] Review Request: pdumpfs - Daily backup system

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480857


Henrique LonelySpooky Junior henrique...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485607] Review Request: SciTools - A Python library for scientific computing

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485607





--- Comment #10 from Joseph Smidt josephsm...@gmail.com  2009-02-16 13:06:35 
EDT ---
Should the solution be move all the /bin files to the doc directory except
pyreport and maybe a couple others and have a README in the doc directory
saying These /bin files are needed to run the examples from the book, if you
want to run these example move them to somewhere in your $PATH such as your
current directory or add this directory to your $PATH?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 478470] Review Request: mrpt - The Mobile Robot Programming Toolkit (MRPT)

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478470





--- Comment #25 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2009-02-16 
13:07:26 EDT ---
Well, would you explain why you want to split each binaries into
different subpackages? I don't think people using mrpt can get
much gain , and the naming of subpackages seems confusing because
from the first look some subpackages have names which don't seem
to be related to mrpt.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 451744] Review Request: root - The CERN analyzer for high to medium energy physics

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=451744





--- Comment #13 from Joseph Smidt josephsm...@gmail.com  2009-02-16 13:19:24 
EDT ---
Thanks a lot for that .spec file.  I will go back to work and try to clean
everything up.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 484726] Review Request: impressive - The stylish way of giving presentations

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484726





--- Comment #6 from Allisson Azevedo allis...@gmail.com  2009-02-16 13:31:29 
EDT ---
Update package:

Spec URL: http://allisson.fedorapeople.org/packages/impressive/impressive.spec

SRPM URL:
http://allisson.fedorapeople.org/packages/impressive/impressive-0.10.2-4.fc10.src.rpm

Notes:
- Fix requires for dejavu fonts.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485607] Review Request: SciTools - A Python library for scientific computing

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485607





--- Comment #11 from Jussi Lehtola jussi.leht...@iki.fi  2009-02-16 13:27:34 
EDT ---
(In reply to comment #10)
 Should the solution be move all the /bin files to the doc directory except
 pyreport and maybe a couple others and have a README in the doc directory
 saying These /bin files are needed to run the examples from the book, if you
 want to run these example move them to somewhere in your $PATH such as your
 current directory or add this directory to your $PATH?

Well, that is one option; another would be to put the files in a
package-provided dir that is added in the system $PATH.

Looking at the reply for upstream, I'd put the files under %doc, since the
package works without them; but this is your decision to make. Just as long as
the files don't interfere with other packages.

pyreport is a probable troublemaker, since (as the author stated) there is a
program called pyreport, even though it is not in Fedora at the moment.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 476404] Review Request: bullet - 3D Collision Detection and Rigid Body Dynamics Library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476404





--- Comment #21 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2009-02-16 
13:28:48 EDT ---
(In reply to comment #20)
 That's an MIT variant, no problem.

Thank you. Now the license issue on this package is all cleared.
Full review will follow later.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 456150] Review Request: slapi-nis - NIS Server and Schema Compatibility plugins for Fedora DS

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=456150


Peter Lemenkov lemen...@gmail.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 456150] Review Request: slapi-nis - NIS Server and Schema Compatibility plugins for Fedora DS

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=456150


Peter Lemenkov lemen...@gmail.com changed:

   What|Removed |Added

 CC||lemen...@gmail.com




--- Comment #6 from Peter Lemenkov lemen...@gmail.com  2009-02-16 13:32:20 
EDT ---
Don't forget to close tickets when package was pushed to main repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 455539] Review Request: yui - JavaScript library for building dynamic web sites

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=455539


Peter Lemenkov lemen...@gmail.com changed:

   What|Removed |Added

   Flag|needinfo?   |




--- Comment #3 from Peter Lemenkov lemen...@gmail.com  2009-02-16 13:33:48 
EDT ---
ping!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 455541] Review Request: dojo - javascript library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=455541


Peter Lemenkov lemen...@gmail.com changed:

   What|Removed |Added

 CC||lemen...@gmail.com
   Flag|needinfo?   |




--- Comment #4 from Peter Lemenkov lemen...@gmail.com  2009-02-16 13:33:30 
EDT ---
Ping!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 484726] Review Request: impressive - The stylish way of giving presentations

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484726


Jochen Schmitt joc...@herr-schmitt.de changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #7 from Jochen Schmitt joc...@herr-schmitt.de  2009-02-16 
13:37:46 EDT ---
I'm sorry that I have talk you anything wrong about the dajavu fonts
packagenames on the differents Fedora releases. So it may be nice, if you can
revert to impressive-0.10-2-3

Good:
+ Local build works fine
+ Local install works fine.
+ Start of the application works fine
+ Local uninstall works fine.

If you are revert to impressive-0.1.2-3, you are APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 484726] Review Request: impressive - The stylish way of giving presentations

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484726


Allisson Azevedo allis...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #9 from Allisson Azevedo allis...@gmail.com  2009-02-16 13:46:24 
EDT ---
New Package CVS Request
===
Package Name: impressive
Short Description: The stylish way of giving presentations
Owners: allisson
Branches: F-9 F-10

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 484726] Review Request: impressive - The stylish way of giving presentations

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484726





--- Comment #8 from Allisson Azevedo allis...@gmail.com  2009-02-16 13:44:52 
EDT ---
Ok, i'll use impressive-0.1.2-3, thanks for review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 484933] Review Request: libwps - Library for reading and converting Microsoft Works word processor documents

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484933





--- Comment #11 from Simon Wesp cassmod...@fedoraproject.org  2009-02-16 
13:43:55 EDT ---
Spec URL:
http://cassmodiah.fedorapeople.org/libwps-0.1.2/libwps.spec

SRPM URL:
http://cassmodiah.fedorapeople.org/libwps-0.1.2/libwps-0.1.2-3.fc10.src.rpm

Okay, I added this - Thank you.

I`ll try to learn more about this!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485617] Review Request: pygrace - Python bindings for grace

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485617


José Matos jama...@fc.up.pt changed:

   What|Removed |Added

 CC||jama...@fc.up.pt
 AssignedTo|nob...@fedoraproject.org|jama...@fc.up.pt
   Flag||fedora-review?




--- Comment #2 from José Matos jama...@fc.up.pt  2009-02-16 13:47:04 EDT ---
I will take care of the review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485607] Review Request: SciTools - A Python library for scientific computing

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485607


José Matos jama...@fc.up.pt changed:

   What|Removed |Added

 CC||jama...@fc.up.pt




--- Comment #12 from José Matos jama...@fc.up.pt  2009-02-16 13:59:43 EDT ---
I will take of the review of pygrace and so I am interested in the progress of
this package. :-)

Joseph is this your first package? Are you sponsored?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 467703] Review Request: lekhonee - A blog client

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467703


Peter Lemenkov lemen...@gmail.com changed:

   What|Removed |Added

 CC||lemen...@gmail.com




--- Comment #15 from Peter Lemenkov lemen...@gmail.com  2009-02-16 13:58:32 
EDT ---
Any news since Oclober 2008? Please import it and build (if you didn't loose
interest).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 484644] Review Request: screenlets - Fully themeable mini-apps

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484644





--- Comment #14 from manuel wolfshant wo...@nobugconsulting.ro  2009-02-16 
14:04:48 EDT ---
(In reply to comment #10)

 I also add some french translation in the desktop file, do I have the right to
 do that?

Yes, adding translations are always welcome (assuming they are correct, of
course :) )

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485607] Review Request: SciTools - A Python library for scientific computing

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485607





--- Comment #13 from Joseph Smidt josephsm...@gmail.com  2009-02-16 14:19:41 
EDT ---
This is my first package.  With any luck I will try to have the whole thing
completed today. :)   I don't know about being sponsored, but Jussi above is
doing a great job helping me get through the packaging process.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485636] Review Request: cutecom - A GUI application for serial port communications

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485636





--- Comment #1 from manuel wolfshant wo...@nobugconsulting.ro  2009-02-16 
14:23:30 EDT ---
What is the reason of using
 # Upstream script does not install the .desktop file if KDE is not installed, 
 # so we install it manually:
 install -D -m 644 $(pwd)/cutecom.desktop
${RPM_BUILD_ROOT}%{_datadir}/applications/cutecom.desktop 
 # Validate .desktop files:
 desktop-file-validate
${RPM_BUILD_ROOT}%{_datadir}/applications/cutecom.desktop

instead of desktop-file-install which install and validates in a sigle step ?


According to the source files, the license should be GPLv2+. All of them
include:
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.

You must include the license (COPYING) as %doc. I would also include the
changelog and the todo files but I wouldn't cry if you choose to ignore them.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485416] Review Request: msp430-gcc - Cross compiling GNU GCC for the MSP430

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485416


Steve Whitehouse swhit...@redhat.com changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|swhit...@redhat.com
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485607] Review Request: SciTools - A Python library for scientific computing

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485607


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
 Blocks||177841
 AssignedTo|jussi.leht...@iki.fi|nob...@fedoraproject.org
   Flag|fedora-review?  |




--- Comment #14 from Jussi Lehtola jussi.leht...@iki.fi  2009-02-16 14:39:12 
EDT ---
(In reply to comment #13)
 This is my first package.  With any luck I will try to have the whole thing
 completed today. :)   I don't know about being sponsored, but Jussi above is
 doing a great job helping me get through the packaging process.

Well, in that case I can't formally review the package, you need to get a
sponsor to do it; see
http://fedoraproject.org/wiki/PackageMaintainers/Join#Get_Sponsored

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485416] Review Request: msp430-gcc - Cross compiling GNU GCC for the MSP430

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485416





--- Comment #3 from Steve Whitehouse swhit...@redhat.com  2009-02-16 14:46:24 
EDT ---
Review comments:

Regarding comment #1, I think you need to open a separate bug for the ppc64
issues. That can then be addressed at a later date. It doesn't look like its
likely to be a big issue to solve though, so it might be easier to solve it
rather than open the bug.

I've been all though the review guidelines and thats all that I can find which
isn't already done, so if we can resolve that, then I think its good to go.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485607] Review Request: SciTools - A Python library for scientific computing

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485607





--- Comment #15 from José Matos jama...@fc.up.pt  2009-02-16 14:43:07 EDT ---
I am sponsor that was why I was asking. :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485693] Review Request: hunspell-da - Danish thesaurus

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485693


manuel wolfshant wo...@nobugconsulting.ro changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|wo...@nobugconsulting.ro
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 250504] Review Request: blktrace - block IO tracer

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=250504


Eric Sandeen esand...@redhat.com changed:

   What|Removed |Added

 Blocks||472898




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485607] Review Request: SciTools - A Python library for scientific computing

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485607





--- Comment #16 from Jussi Lehtola jussi.leht...@iki.fi  2009-02-16 14:51:09 
EDT ---
(In reply to comment #15)
 I am sponsor that was why I was asking. :-)

Well then, that's nice. I didn't check if Joseph was already in the packager
database, but the mistakes in the packaging did raise some suspicion in my mind
:P

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 474044] Review Request: libzdb - A small, fast, and easy to use database API

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474044





--- Comment #14 from Bernard Johnson bjohn...@symetrix.com  2009-02-16 
14:48:12 EDT ---
Spec URL: http://fedorapeople.org/~bjohnson/libzdb.spec
SRPM URL: http://fedorapeople.org/~bjohnson/libzdb-2.4-1.fc10.src.rpm

Thanks to both of your for your insightful comments.  Here is the latest
version 2.4 which upstream has made the requested changes (soname changes 
include file directory change). 

(In reply to comment #11)
 I would advise that we not package the EXCEPTIONS file, as it is of little
 value to anyone.

The files src/exceptions/Exception.* refer to the EXCEPTIONS file.  Since this
is in the copyright notice, I'd rather leave the EXCEPTIONS file in %doc for
reference rather than have the copyright notice refer to a file that doesn't
exist.

Furthermore, I don't feel that we have the option to changing the copyright
notice to not refer to EXCEPTIONS.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485607] Review Request: SciTools - A Python library for scientific computing

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485607





--- Comment #17 from José Matos jama...@fc.up.pt  2009-02-16 14:58:42 EDT ---
Jussi, please continue the review. You have been doing a fantastic job. :-)
I coordinate all the issues regarding Joseph sponsorship. :-)

Please give your nod when you think that all issues have been dealt.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485607] Review Request: SciTools - A Python library for scientific computing

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485607


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|jussi.leht...@iki.fi
   Flag||fedora-review?




--- Comment #18 from Jussi Lehtola jussi.leht...@iki.fi  2009-02-16 15:17:38 
EDT ---
(In reply to comment #17)
 Jussi, please continue the review. You have been doing a fantastic job. :-)
 I coordinate all the issues regarding Joseph sponsorship. :-)
 
 Please give your nod when you think that all issues have been dealt.

Thanks. Okay, if you say so. Reassigning to myself.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 478470] Review Request: mrpt - The Mobile Robot Programming Toolkit (MRPT)

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478470





--- Comment #26 from Jose Luis joseluisblan...@gmail.com  2009-02-16 15:20:24 
EDT ---
(In reply to comment #25)
 Well, would you explain why you want to split each binaries into
 different subpackages? I don't think people using mrpt can get
 much gain , and the naming of subpackages seems confusing because
 from the first look some subpackages have names which don't seem
 to be related to mrpt.

Honestly, I wasn't unsure about this split. 

On the one hand, I do see a gain as many people will not use all mrpt programs,
so they can install what I guess are the most useful ones. Each subpackage
carries its own executable, plus a subdirectory in /share/ with sample
script/configuration files, so I also see a good thing that only those files of
the programs of interest are installed.

OTOH, I have to admit that the package namespace is messed up with this change,
while there's not a huge gain in disk space.

If your final opinion is to leave all programs in mrpt-apps, I would see that
fine. In that case, I might also join mrpt-example-datasets back into
mrpt-apps as it was in the beginning.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485668] Review Request: irc-otr - Off-The-Record Messaging plugin for various irc clients

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485668


manuel wolfshant wo...@nobugconsulting.ro changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #4 from manuel wolfshant wo...@nobugconsulting.ro  2009-02-16 
15:22:35 EDT ---
Package Review
==

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [x] Package meets the Packaging Guidelines.
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
 Tested on: devel/x86_64
 [x] Rpmlint output:
source RPM: empty
binary RPM:empty
 [x] Package is not relocatable.
 [x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
 License type: GPLv2+
= see also note 1
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package match the upstream source, as provided
in the spec URL.
 SHA1SUM of package: 1481ac792aa58d9a7ce20d51b93eca0a28941ff4 
irc-otr-0.3.tar.gz
 [x] Package is not known to require ExcludeArch.
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains $RPM_BUILD_ROOT.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [x] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.
 [x] Final provides and requires are sane.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
 Tested on: devel/x86_64, F10/x86_64
 [x] Package should compile and build into binary rpms on all supported
architectures.
 Tested on: koji scratch build
 [x] Package functions as described.
== see note 2
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [-] %check is present and the test passes.


=== Final Notes ===
1. pedantic mode on Please ask the upstream author to add the licensing bits
to all the source files. pedantic mode off
2. Only tested in xchat. /otr genkey is painfully slow, I am sure this can be
improved in the code. please ping the author, I hardly believe that 12 minutes
on an AMD X2 5600+ is normal, even if it was idle and there was a message
saying This might take several minutes or on some systems even an hour.



*** APPROVED ***


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 225683] Merge Review: dev86

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225683


Peter Lemenkov lemen...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||lemen...@gmail.com
 AssignedTo|nob...@fedoraproject.org|lemen...@gmail.com
   Flag||fedora-review?




--- Comment #3 from Peter Lemenkov lemen...@gmail.com  2009-02-16 15:32:45 
EDT ---
I'll review it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 470727] Review Request: slimdata - Tools and library for reading and writing slim compressed data

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470727





--- Comment #7 from Matthew Truch m...@truch.net  2009-02-16 15:33:03 EDT ---
Still having trouble with the soname stuff.  It seems that regardless of what I
do, rpmlint complains about the soname.  Also, regardless of what the
executable bit is set to, rpmlint also complains about the unstripped binaries. 

As for upstream, they do not want to change how they do the sonames as they
claim that Debian requires it the way they do it.  In regards to the exit()
calls, they have it on the todo list, but won't get to it in the short-term.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 470727] Review Request: slimdata - Tools and library for reading and writing slim compressed data

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470727





--- Comment #8 from Matthew Truch m...@truch.net  2009-02-16 15:36:23 EDT ---
(In reply to comment #7)
 Still having trouble with the soname stuff.  It seems that regardless of what 
 I
 do, rpmlint complains about the soname.  Also, regardless of what the
 executable bit is set to, rpmlint also complains about the unstripped 
 binaries. 

I forgot to add that things work much better on F-10 (which is all I have to
test on).  See the scratch build I did: 
http://koji.fedoraproject.org/koji/taskinfo?taskID=1131415

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 484931] Renaming Review Request: hosts3d - 3D real-time network visualiser

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484931





--- Comment #12 from Simon Wesp cassmod...@fedoraproject.org  2009-02-16 
15:46:12 EDT ---
mh, replace autoreconf with autoconf for a better koji-compatibility

Spec URL: 
http://cassmodiah.fedorapeople.org/hosts3d-0.97/hosts3d.spec

SRPM URL: 
http://cassmodiah.fedorapeople.org/hosts3d-0.97/hosts3d-0.97-3.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485418] Review Request: vgabios - vga option rom for bochs/qemu

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485418





--- Comment #13 from Glauber de Oliveira Costa gco...@redhat.com  2009-02-16 
15:31:23 EDT ---
Okay, I've updated the package to address your concerns. Hopefully I'm covering
all of them

grab them at 

http://glommer.fedorapeople.org/vgabios-0.6-0.3beta.fc11.src.rpm
http://glommer.fedorapeople.org/vgabios.spec

Note that koji builds will fail on ppc64. This is due to a dev86 bug, to which
I've already submitted the patch.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 483615] Review Request: CodeAnalyst - Performance Analysis Suite for AMD-based System (based on Oprofile)

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483615





--- Comment #8 from Suravee Suthikulpanit suravee.suthikulpa...@amd.com  
2009-02-16 15:46:20 EDT ---
I have posted the new SRPM and specfile here:

Spec URL:
http://ftp-developer.amd.com/user/ssuthiku/CodeAnalyst-gui-2.8.38-1.fc10/CodeAnalyst-gui.spec

SRPM URL:
http://ftp-developer.amd.com/user/ssuthiku/CodeAnalyst-gui-2.8.38-1.fc10/CodeAnalyst-gui-2.8.38-1.fc10.src.rpm

I have added the suggestions in comment 5-7 in this release. Please see the
changelog in spec file for more information.

Thank you,

Suravee

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485693] Review Request: hunspell-da - Danish thesaurus

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485693


manuel wolfshant wo...@nobugconsulting.ro changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #1 from manuel wolfshant wo...@nobugconsulting.ro  2009-02-16 
15:46:41 EDT ---
All well, package APPROVED

PS: since you are using cp -p to install the actual dictionaries, it would be
nice to do:
tr -d '\r'  README_th_da_DK.txt  README_th_da_DK.txt.new
touch -r  README_th_da_DK.txt README_th_da_DK.txt.new
mv -f README_th_da_DK.txt.new README_th_da_DK.txt
tr -d '\r'  README_th_en-US.txt  README_th_en-US.txt.new
touch -r README_th_en-US.txt README_th_en-US.txt.new
mv -f README_th_en-US.txt.new README_th_en-US.txt

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 484931] Renaming Review Request: hosts3d - 3D real-time network visualiser

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484931


Jochen Schmitt joc...@herr-schmitt.de changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #13 from Jochen Schmitt joc...@herr-schmitt.de  2009-02-16 
15:54:19 EDT ---
Good:
+ Koji build works fine.

*** APPROVED ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485642] Review Request: perl-FCGI-ProcManager - A FastCGI process manager

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485642


manuel wolfshant wo...@nobugconsulting.ro changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|wo...@nobugconsulting.ro
   Flag||fedora-review+




--- Comment #1 from manuel wolfshant wo...@nobugconsulting.ro  2009-02-16 
15:54:28 EDT ---
All well. License checks (LGPLv2+), sha1sum matches with upstream
(5f6bdf95148e3e58150eebefb735a2ce4b2ec103 FCGI-ProcManager-0.18.tar.gz),
provides/requires are sane, make check passes., mock build is OK

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 484931] Renaming Review Request: hosts3d - 3D real-time network visualiser

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484931


Simon Wesp cassmod...@fedoraproject.org changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #14 from Simon Wesp cassmod...@fedoraproject.org  2009-02-16 
15:58:04 EDT ---
thank you Jochen.

New Package CVS Request
===
Package Name: hosts3d
Short Description: 3D real-time network visualiser
Owners: cassmodiah
Branches: F-10 EL-5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485607] Review Request: SciTools - A Python library for scientific computing

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485607





--- Comment #19 from José Matos jama...@fc.up.pt  2009-02-16 15:57:57 EDT ---
Joseph as part of the sponsorship process to show that you understand the
packaging review scheme there some steps to be fulfilled.

I will ask you to review (without approving) pygrace (mentioned by Jussi above)
and any other package that you choose that is not yet reviewed.

PS: Talking with someone two timezones away while typing in this thread can
result in missing words or worse. ;-)

I am _a_ sponsor...
I _will_ coordinate...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 480857] Review Request: pdumpfs - Daily backup system

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480857


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #8 from Kevin Fenzi ke...@tummy.com  2009-02-16 16:12:43 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485563] Review Request: fsarchiver - Safe and flexible file-system backup/deployment tool

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485563


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #4 from Kevin Fenzi ke...@tummy.com  2009-02-16 16:13:49 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 484931] Renaming Review Request: hosts3d - 3D real-time network visualiser

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484931


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #15 from Kevin Fenzi ke...@tummy.com  2009-02-16 16:16:09 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 484726] Review Request: impressive - The stylish way of giving presentations

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484726


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #10 from Kevin Fenzi ke...@tummy.com  2009-02-16 16:15:12 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 474356] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474356


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 463767] Review Request: cloog - The Chunky Loop Generator

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463767


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #32 from Kevin Fenzi ke...@tummy.com  2009-02-16 16:21:44 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 479903] Review Request: gdesklet-slideshow - Cycle through a collection of pictures

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479903


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |




--- Comment #32 from Kevin Fenzi ke...@tummy.com  2009-02-16 16:11:07 EDT ---
I don't see fedora-review + here, and it's not clear to me who is reviewing
this. 

Please wait until a reviewer marks it fedora-review + for requesting cvs.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 474356] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474356


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|akurt...@redhat.com




--- Comment #20 from Kevin Fenzi ke...@tummy.com  2009-02-16 16:08:07 EDT ---
cvs done.

Alexander: Please remember to assign reviews to yourself as reviewer.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 225797] Review Request: gimp-data-extras

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225797


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #20 from Kevin Fenzi ke...@tummy.com  2009-02-16 16:29:15 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485643] Review Request: django-authopenid - Django application to integrate Django authentication system with OpenID

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485643





--- Comment #3 from Ian Weller ianwel...@gmail.com  2009-02-16 16:28:23 EDT 
---
(In reply to comment #2)
 + I'm in doubts about package naming - Django packages in Fedora are named 
 with
 first letter capitalized. However the upstream named it with all letters in
 lowercase, so I don't think this is a problem at all.
I'm going to ask somebody about this real quick.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review