[Bug 484323] Review Request: perl-KinoSearch - Search engine library

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484323





--- Comment #10 from Lubomir Rintel lkund...@v3.sk  2009-02-26 21:18:58 EDT 
---
Ping?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467413] Review Request: mingw32-fontconfig - MinGW Windows Fontconfig library

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467413





--- Comment #5 from Peter Robinson pbrobin...@gmail.com  2009-02-27 06:52:40 
EDT ---
Any update on a review request for mingw32-expat?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481516] Review Request: sugar-stopwatch - Simple stopwatch for Sugar

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481516





--- Comment #3 from Fabian Affolter fab...@bernewireless.net  2009-02-27 
06:06:22 EDT ---
Steven, is something missing to get this done?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 479585] Review Request: megaupload-dl - Megaupload automatic downloader

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479585





--- Comment #28 from Marek Mahut mma...@redhat.com  2009-02-27 02:01:10 EDT 
---
(In reply to comment #27)
 Why would they do that?

Because they are nice people?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226423] Merge Review: smartmontools

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226423


Michal Nowak mno...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-review?  |




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226423] Merge Review: smartmontools

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226423


Michal Nowak mno...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487639] Review Request: armstrong - Powerful music sequencing library *** RENAMED PACKAGE ***

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487639


Orcan 'oget' Ogetbil oget.fed...@gmail.com changed:

   What|Removed |Added

 Depends on||487637




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426751] Review Request: ghc-X11 - A Haskell binding to the X11 graphics library.

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=426751


Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478553] Review Request: perl-WWW-Curl - Perl extension interface for libcurl

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478553


Nicole Yancey nyan...@redhat.com changed:

   What|Removed |Added

 Depends on|485731  |




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426753] Review Request: xmonad - A tiling window manager

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=426753





--- Comment #19 from Jens Petersen peter...@redhat.com  2009-02-27 10:29:06 
EDT ---
Created an attachment (id=333495)
 -- (https://bugzilla.redhat.com/attachment.cgi?id=333495)
xmonad.spec-2.patch

cabal2spec sync and some other requires tweaks.

This also build, installs and uninstalls for me.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 475823] Review Request: menu-cache - Caching mechanism for freedesktop.org compilant menus

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475823





--- Comment #6 from Fedora Update System upda...@fedoraproject.org  
2009-02-26 21:09:46 EDT ---
menu-cache-0.2.2-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/menu-cache-0.2.2-1.fc10

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478553] Review Request: perl-WWW-Curl - Perl extension interface for libcurl

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478553


Nicole Yancey nyan...@redhat.com changed:

   What|Removed |Added

 Depends on||485731




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 471915] Review Request: jbossweb2 - JBoss Web Server based on Apache Tomcat

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471915





--- Comment #22 from Andrew Overholt overh...@redhat.com  2009-02-27 11:54:43 
EDT ---
(In reply to comment #21)
 Sure. That zip is ASL 2.0, which is fine.

Awesome!

 Since JSON seems to be useful for multiple projects, would it make sense to
 package it separately?

Yes.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487665] Review Request: soud - Tools for hardware related services based on udev events

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487665


Petr Lautrbach plaut...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426751] Review Request: ghc-X11 - A Haskell binding to the X11 graphics library.

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=426751





--- Comment #53 from Jens Petersen peter...@redhat.com  2009-02-27 10:31:17 
EDT ---
One strange I think I did notice is that it seems like the binary
redistribution clause is missing from the BSD3 License - we should probably
ask fedora-legal and upstream about it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426751] Review Request: ghc-X11 - A Haskell binding to the X11 graphics library.

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=426751





--- Comment #52 from Jens Petersen peter...@redhat.com  2009-02-27 10:00:18 
EDT ---
Created an attachment (id=333489)
 -- (https://bugzilla.redhat.com/attachment.cgi?id=333489)
ghc-X11.spec-3.patch

Patch to latest cabal2spec-0.12.

I think I am basically happy with the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487645] Review Request: mediawiki-wikicalendar - Simple calendar extension for mediawiki

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487645





--- Comment #2 from Christof Damian chris...@damian.net  2009-02-27 09:17:59 
EDT ---
New Package CVS Request
===
Package Name: mediawiki-wikicalendar
Short Description: Simple calendar extension for mediawiki
Owners: cdamian
Branches: F-10 EL-5
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487365] Review Request: eclipse-oprofile - Eclipse plugin for OProfile integration

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487365





--- Comment #10 from Kent Sebastian kseba...@redhat.com  2009-02-27 10:21:27 
EDT ---
(In reply to comment #8)
 Kent: I don't see you in the packager group. Is this your first package?

First package indeed. I applied to the packager group, and overholt has since
sponsored :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487665] Review Request: soud - Tools for hardware related services based on udev events

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487665





--- Comment #5 from Petr Lautrbach plaut...@redhat.com  2009-02-27 09:00:41 
EDT ---
New Package CVS Request
===
Package Name: soud
Short Description: Tools for hardware related services based on udev events
Owners: plautrba
Branches: F-9 F-10
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487115] Review Request: perl-NOCpulse-Gritch - Perl throttled email notification for Spacewalk

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487115


Miroslav Suchy msu...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226413] Merge Review: setuptool

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226413


Michal Nowak mno...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mno...@redhat.com
 AssignedTo|nob...@fedoraproject.org|mno...@redhat.com
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 484563] Review Request: php-ezc-ConsoleTools - eZ Components ConsoleTools

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484563


Toshio Ernie Kuratomi a.bad...@gmail.com changed:

   What|Removed |Added

 CC||a.bad...@gmail.com
   Flag|fedora-cvs? |fedora-cvs+




--- Comment #7 from Toshio Ernie Kuratomi a.bad...@gmail.com  2009-02-26 
21:02:58 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453395] Review Request: OpenChange - Microsoft Exchange access with native protocols

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453395


Bug 453395 depends on bug 453083, which changed state.

Bug 453083 Summary: Review Request: Samba4 - Samba4 CIFS and AD server and 
client
https://bugzilla.redhat.com/show_bug.cgi?id=453083

   What|Old Value   |New Value

 Status|NEW |CLOSED
 Resolution||RAWHIDE



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487637] Review Request: rtaudio - Real-time Audio I/O Library

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487637


Orcan 'oget' Ogetbil oget.fed...@gmail.com changed:

   What|Removed |Added

 Blocks||487639




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 476315] Review Request: evolution-mapi - Exchange 2007 support for Evolution

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476315


Bug 476315 depends on bug 453083, which changed state.

Bug 453083 Summary: Review Request: Samba4 - Samba4 CIFS and AD server and 
client
https://bugzilla.redhat.com/show_bug.cgi?id=453083

   What|Old Value   |New Value

 Status|NEW |CLOSED
 Resolution||RAWHIDE



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487281] Review Request: eGroupware - A web-based groupware suite

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487281


Pavel Alexeev pa...@hubbitus.spb.su changed:

   What|Removed |Added

  Alias||egroupware




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 484535] Review Request: kde-plasma-networkmanagement - Plasmoid to control Network Manager

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484535


Ben Boeckel maths...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #19 from Ben Boeckel maths...@gmail.com  2009-02-27 11:12:59 EDT 
---
New Package CVS Request
===
Package Name: kde-plasma-networkmanagement
Short Description: NetworkManager KDE 4 integration
Owners: mathstuf rdieter
Branches: F-9 F-10
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226413] Merge Review: setuptool

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226413





--- Comment #2 from Michal Nowak mno...@redhat.com  2009-02-27 05:16:06 EDT 
---
(In reply to comment #1)
  setuptool.x86_64: W: unstripped-binary-or-object /usr/sbin/setup
 
 +
 
  [...]
  gcc -DHAVE_CONFIG_H -DGETTEXT_PACKAGE=\setup\ -DSETUPTOOLDDIR=\/etc
  /setuptool.d\ -DOTHERSETUPTOOLDDIR=\/usr/share/setuptool/setuptool.d\ 
  -I.-Wall -Wextra -O2 -g -MT setup.o -MD -MP -MF .deps/setup.Tpo -c -o 
  setup.o setup.c
 
 The setuptool build system does not honor Fedora compiler flags. Even though 
 -g
 is present the -debuginfo pkg is not written.

This is some problem in my setup.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226268] Merge Review: perl-libwww-perl

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226268


Lubomir Rintel lkund...@v3.sk changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 CC||lkund...@v3.sk
 Resolution||NEXTRELEASE
   Flag|fedora-review?  |fedora-review+




--- Comment #3 from Lubomir Rintel lkund...@v3.sk  2009-02-26 21:56:09 EDT ---
(In reply to comment #2)
 3) I don't really know enough about the module to fix them.  I looked at them 
 a
 few months ago, and couldn't figure out why they were failing in mock but not 
 on
 my system.

You didn't in fact look, did you? ;)
It's this: bug #487620, nothing that would block this review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487665] Review Request: pmut - power management udev tools

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487665


Marcela Maslanova mmasl...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|mmasl...@redhat.com
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426751] Review Request: ghc-X11 - A Haskell binding to the X11 graphics library.

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=426751


Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

 AssignedTo|michel.syl...@gmail.com |peter...@redhat.com




--- Comment #51 from Jens Petersen peter...@redhat.com  2009-02-27 09:46:23 
EDT ---
Taking over review for Michel based on comment 47.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487713] New: Review Request: wcslib - An implementation of the FITS World Coordinate System standard

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: wcslib -  An implementation of the FITS World 
Coordinate System standard

https://bugzilla.redhat.com/show_bug.cgi?id=487713

   Summary: Review Request: wcslib -  An implementation of the
FITS World Coordinate System standard
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: sergio.pa...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://sergiopr.fedorapeople.org/wcslib.spec
SRPM URL: http://sergiopr.fedorapeople.org/wcslib-4.3.1-1.fc10.src.rpm
Description: WCSLIB is a library that implements the World Coordinate System
(WCS) convention in FITS (Flexible Image Transport System)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487665] New: Review Request: pmut - power management udev tools

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: pmut - power management udev tools

https://bugzilla.redhat.com/show_bug.cgi?id=487665

   Summary: Review Request: pmut - power management udev tools
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: plaut...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL: http://plautrba.fedorapeople.org/pmut/pmut.spec
SRPM URL: http://plautrba.fedorapeople.org/pmut/pmut-0.1.2-2.fc10.src.rpm
Description: 

Pmut is set of tools and services for automated starting or stopping services
related to hardware, using udev to detect event on hardware and DeviceKit to
examine hw devices in udev subsystems.

It's part of https://fedoraproject.org/wiki/Features/PowerManagement

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487617] Review Request: perl-DateTime-Format-ISO8601 - Parses ISO8601 formats

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487617


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #1 from Parag AN(पराग) panem...@gmail.com  2009-02-27 05:52:02 
EDT ---
aah. firefox crashed when I clicked commit. I will not go with full detailed
review now.

+ rpmlint is clean
+ source verified as
4e0faf82577b4d7a9b116fc5a6825728  DateTime-Format-ISO8601-0.06.tar.gz
+ Package perl-DateTime-Format-ISO8601-0.06-1.fc11-noarch =
Provides: perl(DateTime::Format::ISO8601) = 0.06
Requires: perl(Carp) perl(DateTime) perl(DateTime::Format::Builder)
perl(Params::Validate) perl(strict) perl(vars) perl(warnings)

APROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 476315] Review Request: evolution-mapi - Exchange 2007 support for Evolution

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476315


Matthew Barnes mbar...@redhat.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||RAWHIDE




--- Comment #21 from Matthew Barnes mbar...@redhat.com  2009-02-26 23:25:18 
EDT ---
Package built.  Closing review.

http://kojipkgs.fedoraproject.org/packages/evolution-mapi/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453395] Review Request: OpenChange - Microsoft Exchange access with native protocols

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453395


Matthew Barnes mbar...@redhat.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||RAWHIDE




--- Comment #29 from Matthew Barnes mbar...@redhat.com  2009-02-26 22:55:24 
EDT ---
Package built.  Closing review.

http://kojipkgs.fedoraproject.org/packages/openchange/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487639] Review Request: armstrong - Powerful music sequencing library *** RENAMED PACKAGE ***

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487639


Orcan 'oget' Ogetbil oget.fed...@gmail.com changed:

   What|Removed |Added

 CC||mtas...@ioa.s.u-tokyo.ac.jp




--- Comment #1 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-02-27 
02:39:23 EDT ---
This package obsoletes/provides libzzub since the upstream changed their name
to armstrong. I'm adding Mamoru to CC since he was the original reviewer.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487667] Review Request: perl-Net-XMPP2 - Implementation of the XMPP Protocol

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487667


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487665] Review Request: pmut - power management udev tools

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487665


Marcela Maslanova mmasl...@redhat.com changed:

   What|Removed |Added

Summary|Review Request: soud -  |Review Request: pmut -
   |power management udev tools |power management udev tools
   Flag|fedora-review?  |fedora-review+




--- Comment #3 from Marcela Maslanova mmasl...@redhat.com  2009-02-27 
08:49:35 EDT ---
Everything ok. Also the source is matching 531917bbd9c1c48e81799457f90f6c7e
The source should be changed after release into:
https://fedorahosted.org/releases/something/soud-something.tgz

ACCEPTED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487665] Review Request: soud - Tools for hardware related services based on udev events

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487665


Petr Lautrbach plaut...@redhat.com changed:

   What|Removed |Added

Summary|Review Request: pmut -  |Review Request: soud -
   |power management udev tools |Tools for hardware related
   ||services based on udev
   ||events




--- Comment #4 from Petr Lautrbach plaut...@redhat.com  2009-02-27 08:58:35 
EDT ---
New Package CVS Request
===
Package Name: soud
Short Description: power management udev tools
Owners: foo bar
Branches: F-9 F-10
InitialCC: baz

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487667] New: Review Request: perl-Net-XMPP2 - Implementation of the XMPP Protocol

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-Net-XMPP2 - Implementation of the XMPP Protocol

https://bugzilla.redhat.com/show_bug.cgi?id=487667

   Summary: Review Request: perl-Net-XMPP2 - Implementation of the
XMPP Protocol
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: allis...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL:
http://allisson.fedorapeople.org/packages/perl-Net-XMPP2/perl-Net-XMPP2.spec

SRPM URL:
http://allisson.fedorapeople.org/packages/perl-Net-XMPP2/perl-Net-XMPP2-0.14-1.fc10.src.rpm

Description: Net::XMPP2 - An implementation of the XMPP Protocol.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487645] New: Review Request: mediawiki-wikicalendar - Simple calendar extension for mediawiki

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: mediawiki-wikicalendar - Simple calendar extension for 
mediawiki

https://bugzilla.redhat.com/show_bug.cgi?id=487645

   Summary: Review Request: mediawiki-wikicalendar - Simple
calendar extension for mediawiki
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: chris...@damian.net
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://rpms.damian.net/SPECS/mediawiki-wikicalendar.spec
SRPM URL:
http://rpms.damian.net/SRPMS/mediawiki-wikicalendar-1.15-1.fc10.src.rpm
Description: 

The extension adds an calendar tag to the mediawiki syntax which can show
calendars in different formats.

The idea was to keep the calendar as simple as possible and leave all
the editing and page creation to mediawiki. It doesn't require any new
database tables or files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487637] New: Review Request: rtaudio - Real-time Audio I/O Library

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: rtaudio - Real-time Audio I/O Library

https://bugzilla.redhat.com/show_bug.cgi?id=487637

   Summary: Review Request: rtaudio - Real-time Audio I/O Library
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: oget.fed...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://oget.fedorapeople.org/review/rtaudio.spec
SRPM URL: http://oget.fedorapeople.org/review/rtaudio-4.0.5-1.fc10.src.rpm
Description: 
RtAudio is a set of C++ classes that provide a common API for realtime audio
input/output across different operating systems. RtAudio significantly
simplifies the process of interacting with computer audio hardware. It was
designed with the following objectives:

  * object-oriented C++ design
  * simple, common API across all supported platforms
  * allow simultaneous multi-api support
  * support dynamic connection of devices
  * provide extensive audio device parameter control
  * allow audio device capability probing
  * automatic internal conversion for data format, channel number compensation,
(de)interleaving, and byte-swapping


rpmlint: silent

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487535] Review Request: bltk - Baterry Life Tool Kit

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487535





--- Comment #1 from Marcela Maslanova mmasl...@redhat.com  2009-02-27 
03:02:44 EDT ---
? Rpmlint must be run on every package.
bltk.x86_64: W: dangling-relative-symlink /usr/bin/bltk_report
../lib/bltk/bin/bltk_report
bltk.x86_64: W: dangling-relative-symlink /usr/bin/bltk_report_uncompress
../lib/bltk/bin/bltk_report_uncompress
bltk.x86_64: W: dangling-relative-symlink /usr/bin/bltk_report_table
../lib/bltk/bin/bltk_report_table
bltk.x86_64: W: dangling-relative-symlink /usr/bin/bltk_report_compress
../lib/bltk/bin/bltk_report_compress
bltk.x86_64: E: setuid-binary /usr/lib64/bltk/bin/bltk_sudo root 04755
bltk.x86_64: E: non-standard-executable-perm /usr/lib64/bltk/bin/bltk_sudo
04755
bltk.x86_64: W: dangling-relative-symlink /usr/bin/bltk_plot
../lib/bltk/bin/bltk_plot
bltk.x86_64: W: dangling-relative-symlink /usr/bin/bltk ../lib/bltk/bin/bltk

OK The package must be named according to the Package Naming Guidelines.
OK The spec file name must match the base package %{name}.
OK The package must meet the Packaging Guidelines.
OK The package must be licensed with a Fedora approved license.
OK The License field in the package spec file must match the actual license.
OK If (and only if) the source package includes the text of the license(s) in
its own file.
OK The spec file must be written in American English.
OK The spec file for the package MUST be legible.
OK The sources used to build the package must match the upstream source.
OK The package MUST successfully compile.
? Correct BuildRequires.
You can remove BR commented out.

OK Proper use of %find_lang macro. Using %{_datadir}/locale/* is strictly
forbidden.
OK Shared library files (not just symlinks) must call ldconfig in %post and
%postun.
OK Relocatable package must state this fact in the request for review.
OK A package must own all directories that it creates.
OK A package must not contain any duplicate files in the %files listing.
OK Permissions on files must be set properly.
OK Each package must have a %clean section, which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
OK Each package must consistently use macros.
OK The package must contain code, or permissable content.
OK Large documentation files must go in a -doc subpackage.
OK If a package includes something as %doc, it must not affect the runtime of
the application.
OK Header files must be in a -devel package.
OK Static libraries must be in a -static package.
OK Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'.
? Library files with a suffix (e.g. libfoo.so.1.1) and files that end in .so
(without suffix) must go in -devel.
Shouldn't be %{_libdir}/bltk/lib/libxse.so.0 in devel package?

OK In the vast majority of cases, devel packages must require the base package.
OK Packages must NOT contain any .la libtool archives.
OK Packages containing GUI applications must include a %{name}.desktop file.
OK At the beginning of %install, each package MUST run rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).

Comments:
Setuid is ok in this case because it's needed by package, but dangling symlink
is must fix.
Is it arch specific? Shouldn't this be noarch?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226413] Merge Review: setuptool

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226413





--- Comment #1 from Michal Nowak mno...@redhat.com  2009-02-27 05:09:01 EDT 
---
 Conflicts: pam  0.78

Can be deleted, for Fedora at least.

 You should install the setuptool package because you may find
 yourself using its features for essential system administration.

Kinda funny.

 %configure

Needs fix, see at the bottom.

 make

https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make

 %defattr(-,root,root)

Use: %defattr(-,root,root,-)

 %doc README

Missing COPYING.

%attr(0755,root,root) %{_bindir}/setup
%attr(0644,root,root) %{_sysconfdir}/pam.d/*
%attr(0644,root,root) %{_sysconfdir}/security/console.apps/*
%attr(0755,root,root) %{_sbindir}/setup
%attr(0755,root,root) %dir %{_datadir}/%{name}
%attr(0755,root,root) %dir %{_datadir}/%{name}/setuptool.d
%attr(0755,root,root) %dir %{_sysconfdir}/setuptool.d
%attr(0644,root,root) %{_sysconfdir}/setuptool.d/*

` 

I don't think you need this that much. Just fix /usr/bin/setup not to have +w
for group  others in the post-install phase and you have it.


RPMLINT

 setuptool.x86_64: W: no-url-tag

If you don't know the correct URI, I will not mind stay in status quo.

 setuptool.x86_64: W: non-conffile-in-etc /etc/pam.d/setup
 setuptool.x86_64: W: non-conffile-in-etc /etc/setuptool.d/99Xconfigurator
 setuptool.x86_64: W: non-conffile-in-etc 
 /etc/setuptool.d/98system-config-keyboard
 setuptool.x86_64: W: non-conffile-in-etc /etc/setuptool.d/99kbdconfig
 setuptool.x86_64: W: non-conffile-in-etc /etc/setuptool.d/98netconfig
 setuptool.x86_64: W: non-conffile-in-etc /etc/setuptool.d/99timeconfig
 setuptool.x86_64: W: non-conffile-in-etc 
 /etc/setuptool.d/99system-config-network-tui
 setuptool.x86_64: W: non-conffile-in-etc 
 /etc/setuptool.d/98system-config-authentication
 setuptool.x86_64: W: non-conffile-in-etc /etc/setuptool.d/99authconfig
 setuptool.x86_64: W: non-conffile-in-etc /etc/setuptool.d/99lokkit
 setuptool.x86_64: W: non-conffile-in-etc /etc/security/console.apps/setup
 setuptool.x86_64: W: non-conffile-in-etc /etc/setuptool.d/99ntsysv
 setuptool.x86_64: W: non-conffile-in-etc /etc/setuptool.d/99sndconfig
 setuptool.x86_64: W: non-conffile-in-etc /etc/setuptool.d/99mouseconfig
 setuptool.x86_64: W: non-conffile-in-etc 
 /etc/setuptool.d/98system-config-display
 setuptool.x86_64: W: non-conffile-in-etc /etc/setuptool.d/99printconf-tui

This could be %config, if not %config(noreplace), at least.

 setuptool.x86_64: W: unstripped-binary-or-object /usr/sbin/setup

+

 [...]
 gcc -DHAVE_CONFIG_H -DGETTEXT_PACKAGE=\setup\ -DSETUPTOOLDDIR=\/etc
 /setuptool.d\ -DOTHERSETUPTOOLDDIR=\/usr/share/setuptool/setuptool.d\ 
 -I.-Wall -Wextra -O2 -g -MT setup.o -MD -MP -MF .deps/setup.Tpo -c -o 
 setup.o setup.c

The setuptool build system does not honor Fedora compiler flags. Even though -g
is present the -debuginfo pkg is not written.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 459751] Review Request: osgGtk - Gtk and Gtkmm widgets for OpenSceneGraph

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459751





--- Comment #4 from Debarshi Ray debarshi@gmail.com  2009-02-27 00:15:57 
EDT ---
MUST Items: 

OK - rpmlint is clean

xx - does not follow Naming Guidelines
+ It would be better to name this package 'osggtk' instead of 'osgGtk'.
  The tarball is named 'osggtk' and Fedora's other OpenSceneGraph
  packages are named 'osgcal' and 'osgal'. Therefore having a completely
  lower-case name would be more consistent. But since you are also the
  upstream author, I would be willing to listen to your rationale for
  preferring otherwise. :-)

OK - spec file is named as %{name}.spec

xx - package does not meet Packaging Guidelines
+ Although the current Source0 URL works, according to
  https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net
  the Source0 tag should have 'downloads' and not 'download'.
+ Even Fedora 9 has OpenSceneGraph-devel = 2.2.0 for sometime now.
  According to
  https://fedoraproject.org/wiki/Packaging:Guidelines#Requires no need to
  add it if its not really required.
+ Why is there a runtime dependency on 'OpenSceneGraph-devel = 2.2.0' for
  osgGtkmm-devel? If it is because the osgGtkmm header files need the
  OpenSceneGraph headers, then the osgGtkmm-1.0.pc should mention it.
+ The osgGtkmm sub-package does not explicitly require osgGtk. Now I can
  understand that RPM is going to autogenerate the dependency on the
  shared library, but
 
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
  does that subpackages other than -devel should also require the base
  package using a fully versioned dependency. I find that you have done
  so for all the other sub-packages, but only not for osgGtkmm. I confess
  that I do not know the rationale behind this guideline. In the meantime,
  I will try to find out the reason.
+ You could consider using '%{__install} -p' consistently through the
  %install stanza.

OK - license meets Licensing Guidelines

xx - License field does not meet actual license
+ Going by the license notices in the source code:
  (i)  Makefile.am, examples/Makefile.am, osgGtk/Makefile.am,
   osgGtkmm/Makefile.am are under LGPLv3.
  (ii) the others are under GPLv3.
  Since you are the upstream author, for the Makefile.ams please consider
  marking them as GPLv3 or use the license notices in the autogenerated
  Makefile.ins.

OK - upstream license file included in %doc
OK - spec file uses American English
OK - spec file is legible
OK - sources match upstream sources
OK - package builds successfully
OK - ExcludeArch not needed

xx - redundant and extra build dependencies listed
+ pkgconfig is brought in by all the -devel packages providing *.pc files

OK - no locales
OK - %post and %postun invoke ldconfig
OK - package is not relocatable

xx - file and directory ownership
+ The -devel and osgGtkmm-devel sub-packages should have
  'Requires: gtk-doc' as it needs /usr/share/gtk-doc.

OK - no duplicates in %file
OK - file permissions set properly
OK - %clean present

OK - macros used consistently
+ Both %{name} and osgGtk are used. You could consider using %{name}
  throughout.
+ Using both %{buildroot} and $RPM_BUILD_ROOT is looked down upon. See
 
https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS

OK - contains code and permissable content
OK - -doc is not needed
OK - contents of %doc does not affect the runtime
OK - header files in -devel
OK - no static libraries

OK - devel has *.pc file and requires pkgconfig
+ Even though
  https://fedoraproject.org/wiki/Packaging:Guidelines#Pkgconfig_Files
  lays down that the -devel sub-package must have 'Requires: pkgconfig' if
  it includes a *.pc file, Fedora 11 onwards rpm-4.6 autogenerates this
  runtime dependency and the ones on the other -devel subpackages mentioned
  in the *.pc file. So please consider removing them from Fedora 11 and
  onwards using a %if %endif pair.
  In osgGtk-devel:
  Requires: gtk2-devel
  Requires: gtkglext-devel
  Requires: OpenSceneGraph-devel = 2.2.0
  Requires: pkgconfig
  In osgGtkmm-devel:
  Requires: gtkmm24-devel
  Requires: gtkglextmm-devel
  Requires: pkgconfig

OK - library files without suffix in -devel
OK - -devel requires base package
OK - no libtool archives

xx - %{name}.desktop file is invalid
+ According to https://fedoraproject.org/wiki/Packaging/Guidelines#desktop
  desktop-file-validate must be run on the .desktop file, and it says:
  [ri...@freebook osggtk-0.1.3]$ desktop-file-validate osgviewerGtk.desktop
  osgviewerGtk.desktop: warning: key Encoding 

[Bug 484323] Review Request: perl-KinoSearch - Search engine library

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484323


Lubomir Rintel lkund...@v3.sk changed:

   What|Removed |Added

   Flag||needinfo?(ianburr...@gmail.
   ||com)




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487665] Review Request: soud - power management udev tools

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487665


Petr Lautrbach plaut...@redhat.com changed:

   What|Removed |Added

Summary|Review Request: pmut -  |Review Request: soud -
   |power management udev tools |power management udev tools




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 485007] Review Request: rhnpush - Package uploader for the RHN Satellite/Spacewalk Server

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485007


Miroslav Suchy msu...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226423] Merge Review: smartmontools

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226423


Michal Nowak mno...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mno...@redhat.com
 AssignedTo|nob...@fedoraproject.org|mno...@redhat.com




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226258] Merge Review: perl-Frontier-RPC

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226258


Lubomir Rintel lkund...@v3.sk changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 CC||lkund...@v3.sk
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 458643] Review Request: dansguardian - Content filtering web proxy

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458643





--- Comment #19 from Felix Kaechele fe...@fetzig.org  2009-02-27 04:53:21 EDT 
---
#18: I believe that you should contact Thomas Woerner on that. He maintains
system-config-firewall. He might include it as a template into his package.

I hope to finish the review soon but there are still some issues that need to
be addressed. More to follow. Sorry for having you wait so long.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487535] Review Request: bltk - Baterry Life Tool Kit

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487535


Marcela Maslanova mmasl...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|mmasl...@redhat.com
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 485159] Review Request: anki - Flashcard program for using space repetition learning

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485159


Tom spot Callaway tcall...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||tcall...@redhat.com
 AssignedTo|nob...@fedoraproject.org|tcall...@redhat.com




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 471915] Review Request: jbossweb2 - JBoss Web Server based on Apache Tomcat

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471915





--- Comment #23 from Tom spot Callaway tcall...@redhat.com  2009-02-27 
11:57:53 EDT ---
So, the logical followup is that someone should make a JSON package, get it
reviewed, then have this package pull out its local copy and depend on the JSON
package. This will also prevent odd things like having eclipse bits depend on a
JBoss Web Server. ;)

It should be a trivial package, feel free to poke me when it is ready for
review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487730] New: Review Request: perl-AnyEvent-XMPP - Implementation of the XMPP Protocol

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-AnyEvent-XMPP - Implementation of the XMPP 
Protocol

https://bugzilla.redhat.com/show_bug.cgi?id=487730

   Summary: Review Request: perl-AnyEvent-XMPP - Implementation of
the XMPP Protocol
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: allis...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL:
http://allisson.fedorapeople.org/packages/perl-AnyEvent-XMPP/perl-AnyEvent-XMPP.spec

SRPM URL:
http://allisson.fedorapeople.org/packages/perl-AnyEvent-XMPP/perl-AnyEvent-XMPP-0.4-1.fc10.src.rpm

Description: AnyEvent::XMPP - An implementation of the XMPP Protocol.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 476315] Review Request: evolution-mapi - Exchange 2007 support for Evolution

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476315


Bug 476315 depends on bug 453395, which changed state.

Bug 453395 Summary: Review Request: OpenChange - Microsoft Exchange access with 
native protocols
https://bugzilla.redhat.com/show_bug.cgi?id=453395

   What|Old Value   |New Value

 Status|NEW |CLOSED
 Resolution||RAWHIDE



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453083] Review Request: Samba4 - Samba4 CIFS and AD server and client

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453083


Matthew Barnes mbar...@redhat.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||RAWHIDE




--- Comment #68 from Matthew Barnes mbar...@redhat.com  2009-02-26 21:30:33 
EDT ---
Package built.  Closing review.  Finally.

http://kojipkgs.fedoraproject.org/packages/samba4/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487665] Review Request: pmut - power management udev tools

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487665





--- Comment #2 from Petr Lautrbach plaut...@redhat.com  2009-02-27 08:13:35 
EDT ---
project renamed:

Spec URL: http://plautrba.fedorapeople.org/soud/soud.spec
SRPM URL: http://plautrba.fedorapeople.org/soud/soud-0.1.2-3.fc10.src.rpm
Description: 

Soud is set of tools and services for automated starting or stopping services
related to hardware, using udev to detect event on hardware and DeviceKit to
examine hw devices in udev subsystems.

It's part of https://fedoraproject.org/wiki/Features/PowerManagement

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 484323] Review Request: perl-KinoSearch - Search engine library

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484323


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

 CC||ke...@tummy.com




--- Comment #11 from Kevin Fenzi ke...@tummy.com  2009-02-27 11:18:53 EDT ---
Ian: Can we please make sure the license is right before doing builds?

Did you query upstream about the ASL issue? what was the reply?

Please don't build until this is all figured out.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 471915] Review Request: jbossweb2 - JBoss Web Server based on Apache Tomcat

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471915


Tom spot Callaway tcall...@redhat.com changed:

   What|Removed |Added

   Flag|needinfo?(tcall...@redhat.c |
   |om) |




--- Comment #21 from Tom spot Callaway tcall...@redhat.com  2009-02-27 
09:37:57 EDT ---
Sure. That zip is ASL 2.0, which is fine.

Since JSON seems to be useful for multiple projects, would it make sense to
package it separately?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486561] Review Request: monsoon - Monsoon is a Bittorrent client written in Mono and GTK#

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486561


David Nielsen gnomeu...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




--- Comment #7 from David Nielsen gnomeu...@gmail.com  2009-02-26 20:58:36 
EDT ---
Monsoon is now in rawhide, F9 and F10 will follow as the required build deps
make their way through bodhi.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487114] Review Request: gvrpcd - A program for announcing VLANs using GVRP.

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487114


Michael Schwendt bugs.mich...@gmx.net changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||bugs.mich...@gmx.net
 Blocks|177841(FE-NEEDSPONSOR)  |
 AssignedTo|nob...@fedoraproject.org|bugs.mich...@gmx.net
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 484535] Review Request: kde-plasma-networkmanagement - Plasmoid to control Network Manager

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484535


Milos Jakubicek xja...@fi.muni.cz changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #18 from Milos Jakubicek xja...@fi.muni.cz  2009-02-27 10:10:06 
EDT ---
OK, there are some minor outstanding issues regarding licensing, but none of
them are blocking and can be done later on, otherwise all the problems have
been addressed, this package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480102] Review Request: weka - Waikato Environment for Knowledge Analysis

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480102





--- Comment #4 from Michel Alexandre Salim michel.syl...@gmail.com  
2009-02-27 01:36:33 EDT ---
Most of the changes are fine. Would be a good idea to turn on the test suite,
between %build and %install:

%check
CLASSPATH=/usr/share/java/junit4.jar ant run_tests

This currently fails, though:
run_tests:
[junit] Error: java.lang.ClassCastException: class weka.AllTests

not sure why, you might want to ask on the upstream mailing list.

Oh, and the %files section needs to be updated: it's still refering to
fedora-%{name}.desktop.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486657] Review Request: blahtexml - Converts TeX equations to MathML

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486657


Michael Schwendt bugs.mich...@gmx.net changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||bugs.mich...@gmx.net
 Blocks|177841(FE-NEEDSPONSOR)  |




--- Comment #10 from Michael Schwendt bugs.mich...@gmx.net  2009-02-27 
03:55:31 EDT ---
You would need to become a sponsor first:
https://fedoraproject.org/wiki/PackageMaintainers/SponsorProcess
I'll look at gvrpcd and sponsor Jasper...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480102] Review Request: weka - Waikato Environment for Knowledge Analysis

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480102





--- Comment #5 from Michel Alexandre Salim michel.syl...@gmail.com  
2009-02-27 10:11:48 EDT ---
(In reply to comment #4)
 Most of the changes are fine. Would be a good idea to turn on the test suite,
 between %build and %install:
 
 %check
 CLASSPATH=/usr/share/java/junit4.jar ant run_tests
 
Of course, that should have been

BuildRequires: junit

%check
CLASSPATH=/usr/share/java/junit.jar ant run_tests

It takes forever to run, though, so perhaps surround it in an %if?

%if %{?_with_tests:1}%{!?_with_tests:0}
%check
...
%endif

(and put a one-line comment at the top describing the --with tests option)

But that's secondary -- apart from the desktop file naming, this is good to go.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487507] Review Request: perl-Class-XSAccessor-Array - Generate fast XS accessors without runtime compilation

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487507





--- Comment #3 from Parag AN(पराग) panem...@gmail.com  2009-02-27 01:30:01 
EDT ---
(In reply to comment #2)
 (In reply to comment #1)
  package build failed.
  koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=1190374
  
  Suggestions:
  1) You don't need following in SPEC
  Requires:   perl(AutoXS::Header) = 0.02
  

  I see this Requires: will get automatically installed via yum command. so
thought not needed in SPEC. 

 Did you mean BR? It fails without it.
 http://koji.fedoraproject.org/koji/getfile?taskID=1190561name=build.log
  2) Missing 
   BuildRequires:  perl(Test::More)
 Added.
 
 Thanks. New koji build could be found at:
 http://koji.fedoraproject.org/koji/taskinfo?taskID=1190611

thanks but I am unable to download SRPM.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487639] New: Review Request: armstrong - Powerful music sequencing library *** RENAMED PACKAGE ***

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: armstrong - Powerful music sequencing library *** 
RENAMED PACKAGE ***

https://bugzilla.redhat.com/show_bug.cgi?id=487639

   Summary: Review Request: armstrong - Powerful music sequencing
library *** RENAMED PACKAGE ***
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: oget.fed...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://oget.fedorapeople.org/review/armstrong.spec
SRPM URL: http://oget.fedorapeople.org/review/armstrong-0.2.6-1.fc10.src.rpm
Description:
If you are searching for a foundation for your next soundtracker, armstrong is
what you want. armstrong provides an extensible DSP plugin system, a wavetable,
instruments, a multitrack sequencer and support for major soundcard APIs.
armstrong includes zzub and lunar libraries.

Rpmlint:
There are bunch of 
   W: devel-file-in-non-devel-package
warnings. But these files are really needed during runtime. I know it is weird.

If you want to test these libraries you can try aldrin:
   http://oget.fedorapeople.org/aldrin/
There will be sample files inside 
   /usr/share/aldrin/demosongs/
aldrin is an accepted package but I didn't update it because it requires
armstrong-0.2.6.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 485159] Review Request: anki - Flashcard program for using space repetition learning

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485159





--- Comment #3 from Tom spot Callaway tcall...@redhat.com  2009-02-27 
10:13:48 EDT ---
Christian, at first glance, this package looks great. I only noticed one thing
when I did the review:

The package is internationalized, with .mo files for libanki and libankiqt.
Unfortunately, they're in a location that %find_lang
(https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files)
doesn't know how to find them in
(%{python_sitelib}/ankiqt/locale/*/LC_MESSAGES). Since you can't use
%find_lang, you're going to have to tag those files manually, like this:

%lang(cs) %{python_sitelib}/ankiqt/locale/cs_*/

(rpm tags on the first half of the locale country code only)

Unfortunately, this will make your %files more complicated, as you cannot
simply claim the toplevel directory or these files will be listed twice.

Start with something like this:

%files
%defattr(-,root,root,-)
%doc COPYING ChangeLog CREDITS README*
%dir %{python_sitelib}/ankiqt/
%{python_sitelib}/ankiqt/*.py*
%{python_sitelib}/ankiqt/forms/
%{python_sitelib}/ankiqt/ui/
%dir %{python_sitelib}/ankiqt/locale/
%lang(cs) %{python_sitelib}/ankiqt/locale/cs_*/
%lang(de) %{python_sitelib}/ankiqt/locale/de_*/
...

It is also possible to script a version of find_lang that can find these files
and tag them properly in a file list to use in %files, but that might be more
complicated than doing what I've proposed.

rpmlint caught this problem, you should run rpmlint on your packages to look
for issues like this. :)

Show me a new package that has this issue fixed and I'll finish out this
review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487645] Review Request: mediawiki-wikicalendar - Simple calendar extension for mediawiki

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487645


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review+




--- Comment #1 from Parag AN(पराग) panem...@gmail.com  2009-02-27 06:33:02 
EDT ---
Review:
+ package builds in mock (rawhide i386).
koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=1204564
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
f99d5fa46be90862952e8f914e217f4d  wikicalendar-1.15.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

Suggestions:
1) License tag should be GPLv2+

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 469291] Review Request: uml_utilities - Utilities for user-mode linux kernel

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469291


Tom spot Callaway tcall...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||tcall...@redhat.com
 AssignedTo|nob...@fedoraproject.org|tcall...@redhat.com
   Flag||fedora-review?




--- Comment #13 from Tom spot Callaway tcall...@redhat.com  2009-02-27 
10:35:33 EDT ---
%define ver20070815

Please don't do this. Just put that in Version: and use %{version}. It will
simplify the spec.

Also, the license tag is wrong. All of the code simply says GPL, so the tag
should be : License: GPL+

See:
http://fedoraproject.org/wiki/Licensing/FAQ#How_do_I_figure_out_what_version_of_the_GPL.2FLGPL_my_package_is_under.3F

Also, it looks like the Source0 url is wrong, it should be:

http://user-mode-linux.sourceforge.net/%{name}_%{version}.tar.bz2

And... ncurses-devel is a Requires of readline-devel, so you shouldn't need to
BuildRequires it.

Aside from that, everything looks fine. I'll finish the review, but please show
me a finished package before I can flip the approved flag.

== Review ==
Good:

- rpmlint checks return:
uml_utilities.x86_64: E: setuid-binary /usr/bin/uml_net root 04755
uml_utilities.x86_64: E: non-standard-executable-perm /usr/bin/uml_net 04755
Safe to ignore.
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL+) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream (4e10de8e0f5bf681fa295572009518b77fd8a1dd)
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487665] Review Request: pmut - power management udev tools

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487665





--- Comment #1 from Marcela Maslanova mmasl...@redhat.com  2009-02-27 
06:43:58 EDT ---
? Rpmlint must be run on every package.
pmut.noarch: W: incoherent-version-in-changelog 0.1.2-1 ['0.1.2-2.fc10',
'0.1.2-2']

? The package must be named according to the Package Naming Guidelines.
This name can collide with
http://bioinformatics.oxfordjournals.org/cgi/content/abstract/21/14/3176 or
libraries for genetic algorithm http://gtps.math.cmu.edu/htmldoc-etps/pmut.html

OK The spec file name must match the base package %{name}.
OK The package must meet the Packaging Guidelines.
OK The package must be licensed with a Fedora approved license.
OK The License field in the package spec file must match the actual license.
OK If (and only if) the source package includes the text of the license(s) in
its own file.
OK The spec file must be written in American English ;-)
OK The spec file for the package MUST be legible.
? The sources used to build the package must match the upstream source.
The source must be located on f.e. project page.
OK The package MUST successfully compile.
OK Correct BuildRequires.
OK Proper use of %find_lang macro. Using %{_datadir}/locale/* is strictly
forbidden.
OK Shared library files (not just symlinks) must call ldconfig in %post and
%postun.
OK Relocatable package must state this fact in the request for review.
OK A package must own all directories that it creates.
OK A package must not contain any duplicate files in the %files listing.
OK Permissions on files must be set properly.
OK Each package must have a %clean section, which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
OK Each package must consistently use macros.
OK The package must contain code, or permissable content.
OK Large documentation files must go in a -doc subpackage.
OK If a package includes something as %doc, it must not affect the runtime of
the application.
OK Header files must be in a -devel package.
OK Static libraries must be in a -static package.
OK Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'.
OK Library files with a suffix (e.g. libfoo.so.1.1) and files that end in .so
(without suffix) must go in -devel.
OK In the vast majority of cases, devel packages must require the base package.
OK Packages must NOT contain any .la libtool archives.
OK Packages containing GUI applications must include a %{name}.desktop file.
OK At the beginning of %install, each package MUST run rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).

The require line is too long, please create at least two instead. %doc can be
on one line ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487737] New: Review Request: slock - Simple X display locker

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: slock - Simple X display locker

https://bugzilla.redhat.com/show_bug.cgi?id=487737

   Summary: Review Request: slock - Simple X display locker
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: stl...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://rpm.scwlab.com/fedora/slock/slock.spec
SRPM URL: http://rpm.scwlab.com/fedora/slock/slock-0.9-1.fc10.src.rpm
Built RPMs for F10 i386 and x86_64: http://rpm.scwlab.com/fedora/slock/

Description:
slock is a simple X display locker. Really this is the simplest X screen locker
we are aware of. It is stable and quite a lot people in this community are
using it every day when they are out with friends or fetching some food from
the local pub.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 437321] Review Request: libarchive - A library for handling streaming archive formats

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=437321


Terje Røsten terje...@phys.ntnu.no changed:

   What|Removed |Added

 CC||terje...@phys.ntnu.no




--- Comment #8 from Terje Røsten terje...@phys.ntnu.no  2009-02-27 13:40:56 
EDT ---
Why is --disable-bsdtar used? bsdtar has some nice features.

I can help creating the bsdtar subpackage if you want.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487637] Review Request: rtaudio - Real-time Audio I/O Library

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487637


Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

 CC||mtas...@ioa.s.u-tokyo.ac.jp




--- Comment #1 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2009-02-27 
13:38:49 EDT ---
Some notes:
- When currently upstream only provides static archive and does
  not provide shared library, patching Makefiles on vendor side
  to create share library may cause annnoying problem, e.g.
  https://www.redhat.com/archives/fedora-packaging/2009-February/msg00047.html

  Also there is no guarrantee that the API of the created shared
  library won't change when the major version of the package version
  does not change.

  Current Fedora guidelines provides a way to package static archives
  (when unavoidable) and for this case I think shipping static archive
  instead of patching on Fedora side is much safer:
 
https://fedoraproject.org/wiki/Packaging/Guidelines#Packaging_Static_Libraries

  Note:
  When switching to creating static archive, passing -fPIC is
  still needed if the archive is needed for creating shared libraries
  in other application. 

- Your package does not build on ppc64:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=1205561

  Adding

cp -p /usr/lib/rpm/config.{sub,guess} config/

  at the end of %prep will make the build succeed. ref:
  https://www.redhat.com/archives/fedora-devel-list/2009-February/msg02238.html

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487637] Review Request: rtaudio - Real-time Audio I/O Library

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487637





--- Comment #2 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-02-27 
13:52:37 EDT ---
Thanks

- I will do the ppc64 fix 

- About the static library, shall I just make a package with just the static
library and no dynamic library,
or shall I add a -static subpackage and put the .a file in there?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481516] Review Request: sugar-stopwatch - Simple stopwatch for Sugar

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481516


Steven M. Parrish smparr...@shallowcreek.net changed:

   What|Removed |Added

   Flag||fedora-review+




--- Comment #4 from Steven M. Parrish smparr...@shallowcreek.net  2009-02-27 
13:58:25 EDT ---
Nope just me forgetting to finish it.  Sorry about that.

Package approved

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487617] Review Request: perl-DateTime-Format-ISO8601 - Parses ISO8601 formats

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487617


Chris Weyl cw...@alumni.drew.edu changed:

   What|Removed |Added

   Flag||fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487617] Review Request: perl-DateTime-Format-ISO8601 - Parses ISO8601 formats

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487617





--- Comment #2 from Chris Weyl cw...@alumni.drew.edu  2009-02-27 14:06:21 EDT 
---
New Package CVS Request
===
Package Name: perl-DateTime-Format-ISO8601
Short Description: Parses ISO8601 formats
Owners: cweyl
Branches: F-9 F-10 devel
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487637] Review Request: rtaudio - Real-time Audio I/O Library

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487637





--- Comment #3 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2009-02-27 
14:08:41 EDT ---
(In reply to comment #2)
 - About the static library, shall I just make a package with just the static
 library and no dynamic library,
 or shall I add a -static subpackage and put the .a file in there?

From current guidelines,
- create a package rtaudio-devel (from rtaudio srpm) (for this package,
  rtaudio-devel binary rpm only)
  * with containing static archives, header files and some documents
  * rtaudio-devel _must_ have Provides: rtaudio-staic =
%{version}-%{release}.

And when other packages need librtaudio.a for building, such
packages must have BuildRequires: rtaudio-static, not
BuildRequires: rtaudio-devel so that we can trace what packages
are using static archives for linkage.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481516] Review Request: sugar-stopwatch - Simple stopwatch for Sugar

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481516





--- Comment #5 from Fabian Affolter fab...@bernewireless.net  2009-02-27 
14:22:19 EDT ---
Thanks

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487645] Review Request: mediawiki-wikicalendar - Simple calendar extension for mediawiki

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487645


Christof Damian chris...@damian.net changed:

   What|Removed |Added

   Flag||fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481516] Review Request: sugar-stopwatch - Simple stopwatch for Sugar

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481516


Fabian Affolter fab...@bernewireless.net changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #6 from Fabian Affolter fab...@bernewireless.net  2009-02-27 
14:23:47 EDT ---
New Package CVS Request
===
Package Name:   sugar-stopwatch
Short Description:  Simple stopwatch for Sugar
Owners:  fab
Branches: F-10
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 471915] Review Request: jbossweb2 - JBoss Web Server based on Apache Tomcat

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471915





--- Comment #24 from Andrew Overholt overh...@redhat.com  2009-02-27 14:56:01 
EDT ---
You are completely correct.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487637] Review Request: rtaudio - Real-time Audio I/O Library

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487637





--- Comment #4 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-02-27 
15:10:18 EDT ---
OK. Here are the changes:

Spec URL: http://oget.fedorapeople.org/review/rtaudio.spec
SRPM URL: http://oget.fedorapeople.org/review/rtaudio-4.0.5-2.fc10.src.rpm

It builds fine in all archs in koji:
   http://koji.fedoraproject.org/koji/taskinfo?taskID=1206042

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 475144] Review Request: metalink - CLI Metalink generation tool

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475144





--- Comment #18 from Fedora Update System upda...@fedoraproject.org  
2009-02-27 15:13:09 EDT ---
metalink-0.3.6-2.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/metalink-0.3.6-2.fc9

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 475144] Review Request: metalink - CLI Metalink generation tool

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475144





--- Comment #19 from Fedora Update System upda...@fedoraproject.org  
2009-02-27 15:13:14 EDT ---
metalink-0.3.6-2.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/metalink-0.3.6-2.fc10

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 485159] Review Request: anki - Flashcard program for using space repetition learning

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485159





--- Comment #4 from Christian Krause c...@plauener.de  2009-02-27 15:21:38 
EDT ---
Thank you very much for the review!

(In reply to comment #3)
 The package is internationalized, with .mo files for libanki and libankiqt.
 Unfortunately, they're in a location that %find_lang
 (https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files)
 doesn't know how to find them in
 (%{python_sitelib}/ankiqt/locale/*/LC_MESSAGES). Since you can't use
 %find_lang, you're going to have to tag those files manually, like this:

I've fixed the problem as suggested.

 It is also possible to script a version of find_lang that can find these files
 and tag them properly in a file list to use in %files, but that might be more
 complicated than doing what I've proposed.

Yeah, this makes the spec file a little bit more complicated. I'll try to get
this problem fixed upstream, but for now I think it's ok! ;-)

 rpmlint caught this problem, you should run rpmlint on your packages to look
 for issues like this. :)

rpmlint SPECS/anki.spec RPMS/noarch/anki-0.9.9.6-3.fc10.noarch.rpm
SRPMS/anki-0.9.9.6-3.fc10.src.rpm 
anki.src: W: strange-permission generate-anki-tarball.sh 0755
2 packages and 1 specfiles checked; 0 errors, 1 warnings.

The remaining warning is about the mode of the script to generate the
distributable tarball. Since the file is an executable shell script it may be
ok...

 Show me a new package that has this issue fixed and I'll finish out this
 review.

Great! The new package is uploaded:

Spec URL: http://www-user.tu-chemnitz.de/~tiwi/anki.spec
SRPM URL: http://www-user.tu-chemnitz.de/~tiwi/anki-0.9.9.6-3.fc10.src.rpm

and builds fine in F10 and F11:

https://koji.fedoraproject.org/koji/taskinfo?taskID=1206089
https://koji.fedoraproject.org/koji/taskinfo?taskID=1206084

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 485159] Review Request: anki - Flashcard program for using space repetition learning

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485159


Tom spot Callaway tcall...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-review+




--- Comment #5 from Tom spot Callaway tcall...@redhat.com  2009-02-27 
15:46:58 EDT ---
== Review ==

Good:

- rpmlint checks return:
anki.src: W: strange-permission generate-anki-tarball.sh 0755
Safe to ignore.

- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv3+ and MIT) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- locales okay
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime 
- desktop file okay

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 469291] Review Request: uml_utilities - Utilities for user-mode linux kernel

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469291





--- Comment #14 from Christian Krause c...@plauener.de  2009-02-27 16:04:50 
EDT ---
Thanks for the review!

(In reply to comment #13)
 Please don't do this. Just put that in Version: and use %{version}. It will
 simplify the spec.

Fixed.

 Also, the license tag is wrong. All of the code simply says GPL, so the tag
 should be : License: GPL+

Fixed.

 Also, it looks like the Source0 url is wrong, it should be:
 http://user-mode-linux.sourceforge.net/%{name}_%{version}.tar.bz2

Fixed,
spectool -g SPECS/uml_utilities.spec
works fine now, sha1sum: 4e10de8e0f5bf681fa295572009518b77fd8a1dd

 And... ncurses-devel is a Requires of readline-devel, so you shouldn't need to
 BuildRequires it.

Fixed. Package builds fine locally using mock and for F10 and F11:

https://koji.fedoraproject.org/koji/taskinfo?taskID=1206294
https://koji.fedoraproject.org/koji/taskinfo?taskID=1206307

 Aside from that, everything looks fine. I'll finish the review, but please 
 show
 me a finished package before I can flip the approved flag.

I've uploaded the new packages:

Spec URL:
http://www-user.tu-chemnitz.de/~tiwi/uml_utilities-20070815-4.fc10.src.rpm
SRPM URL: http://www-user.tu-chemnitz.de/~tiwi/uml_utilities.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 469291] Review Request: uml_utilities - Utilities for user-mode linux kernel

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469291


Tom spot Callaway tcall...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #15 from Tom spot Callaway tcall...@redhat.com  2009-02-27 
16:10:10 EDT ---
Looks good, APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 469291] Review Request: uml_utilities - Utilities for user-mode linux kernel

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469291


Paul Wouters p...@xelerance.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #16 from Paul Wouters p...@xelerance.com  2009-02-27 16:14:05 EDT 
---
New Package CVS Request
===
Package Name: uml_utilities
Short Description: Utilities for user-mode linux kernel
Owners: pwouters
Branches: EL-5, F-9, F-10
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487665] Review Request: soud - Tools for hardware related services based on udev events

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487665


Bill Nottingham nott...@redhat.com changed:

   What|Removed |Added

 CC||a...@redhat.com,
   ||dav...@redhat.com,
   ||ka...@redhat.com




--- Comment #6 from Bill Nottingham nott...@redhat.com  2009-02-27 16:25:23 
EDT ---
OK, so looking this over, this doesn't seem right.

1) It implements a critical path in the boot process... in perl.
2) It's needlessly baroque for what it does. You set up a perl daemon to listen
to udev for events, look for events of a certain type, and then run actions.

Why not just write udev rules that run actions on certain events, and cut out
the daemon middleman?

3) It's set to start bluetooth only if it's configured to start. Which means
it's likely to have *already started*, and therefore doesn't decrease the
running daemon footprint at all.

4) It drops stuff into predictable file names in /tmp, which is a security
hole. (Presumably, that's leftover debugging)

CC'ing some other people who may have ideas on how to better implement this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 484485] Review Request: perl-Fedora-App-ReviewTool - Application classes for reviewtool

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484485





--- Comment #10 from Chris Weyl cw...@alumni.drew.edu  2009-02-27 17:15:49 
EDT ---
Spec URL: http://fedorapeople.org/~cweyl/review/perl-Fedora-App-ReviewTool.spec
SRPM URL:
http://fedorapeople.org/~cweyl/review/perl-Fedora-App-ReviewTool-0.05-1.fc10.src.rpm

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1206919

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487639] Review Request: armstrong - Powerful music sequencing library *** RENAMED PACKAGE ***

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487639





--- Comment #2 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-02-27 
17:18:23 EDT ---
Package updated due to a change in the rtaudio package.

Spec URL: http://oget.fedorapeople.org/review/armstrong.spec
SRPM URL: http://oget.fedorapeople.org/review/armstrong-0.2.6-2.fc10.src.rpm

Changelog: 0.2.6-2
- BR: rtaudio-static instead of rtaudio-devel

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478668] Review Request: lxmusic - Lightweight XMMS2 client with simple user interface

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478668


Martin-Gomez Pablo pablo.martin-go...@laposte.net changed:

   What|Removed |Added

   Flag||needinfo?(fed...@christoph-
   ||wickert.de)




--- Comment #10 from Martin-Gomez Pablo pablo.martin-go...@laposte.net  
2009-02-27 17:27:01 EDT ---
Great. But gtk2-devel is really needed as a BuildRequires, if not Mock
doesn't build (tested with a fedora-rawhide).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 484485] Review Request: perl-Fedora-App-ReviewTool - Application classes for reviewtool

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484485





--- Comment #11 from Chris Weyl cw...@alumni.drew.edu  2009-02-27 17:39:04 
EDT ---
(In reply to comment #9)
 scratch the yum update perl* from above, I've done it correctly now. but the
 behaviour is the same
 and it does not matter if I use the correct password or not, I have the exact
 same output...
 [r...@pc64 ~]# reviewtool status
 Retrieving status from bugzilla

This was being caused by a non-authenticated query _not_ returning the email
address...  So the typing/coercion of that attribute was causing that issue.

I've updated to just force a bugzilla login for now; the above packages were
used for submit/update in a mock rawhide chroot and should work fine now.  (Not
sure about F-10, but if it's an issue I'll push out a new Fedora::Bugzilla to
F-10 faster than normal.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 485159] Review Request: anki - Flashcard program for using space repetition learning

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485159


Christian Krause c...@plauener.de changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #6 from Christian Krause c...@plauener.de  2009-02-27 17:40:04 
EDT ---
New Package CVS Request
===
Package Name: anki
Short Description: Flashcard program for using space repetition learning
Owners: chkr
Branches: F-10
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 487808] New: Review Request: perl-HTML-FormFu-Model-DBIC - Integrate HTML::FormFu with DBIx::Class

2009-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-HTML-FormFu-Model-DBIC - Integrate HTML::FormFu 
with DBIx::Class

https://bugzilla.redhat.com/show_bug.cgi?id=487808

   Summary: Review Request: perl-HTML-FormFu-Model-DBIC -
Integrate HTML::FormFu with DBIx::Class
   Product: Fedora
   Version: rawhide
  Platform: All
   URL: http://search.cpan.org/dist/HTML-FormFu-Model-DBIC
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: cw...@alumni.drew.edu
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL:
http://fedorapeople.org/~cweyl/review/perl-HTML-FormFu-Model-DBIC.spec
SRPM URL:
http://fedorapeople.org/~cweyl/review/perl-HTML-FormFu-Model-DBIC-0.03007-1.fc10.src.rpm

Description:
Integrate your HTML::FormFu forms with a DBIx::Class model.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1207046

*rt-0.05

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


  1   2   >