[Bug 484644] Review Request: screenlets - Fully themeable mini-apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484644 --- Comment #24 from Edouard Bourguignon ma...@linuxed.net 2009-12-01 03:30:25 EDT --- Only the weather icons are concerned by the restrictive license? I've just opened a ticket as you suggested https://fedorahosted.org/design-team/ticket/105 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484644] Review Request: screenlets - Fully themeable mini-apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484644 --- Comment #23 from Tom spot Callaway tcall...@redhat.com 2009-11-30 20:05:01 EDT --- Is there any update here? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484644] Review Request: screenlets - Fully themeable mini-apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484644 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added CC||tcall...@redhat.com --- Comment #22 from Tom spot Callaway tcall...@redhat.com 2009-07-06 10:01:49 EDT --- That license is not acceptable for content, even though it claims to give permission to freely distribute the icons, it later restricts bundling of those images with any software product without Stardock's express permission. In addition, the use restrictions here are extremely restrictive. I would strongly suggest that you open a trac ticket with the Fedora Design team, so that they can generate replacement icons for this application that are available under a free license: https://fedorahosted.org/design-team/ Leaving FE-Legal in place until this issue is resolved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484644] Review Request: screenlets - Fully themeable mini-apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484644 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Blocks||182235(FE-Legal) --- Comment #21 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-05-29 13:30:31 EDT --- Umm.. I think the license text src/share/screenlets/ClearWeather/themes/default/weather_icons_readme.txt is very questionable. --- These weather images are (c) 2003 by Stardock Corporation. All rights reserved. Permission: Stardock gives you permission to distribute these images and or icons freely as long as this permission document is included. Allowed Uses: You may use these images with any Stardock related product (such as creating DesktopX objects or ObjectDock or plugins). In addition, Stardock licenses this for use with content that is provided free of charge and is not connected to a commercial software product. You may use these images for skins, themes, and other content for freeware software even if it is competitive in nature with Stardock's offerings as long as the copyright notices are included. You may not, however, bundle these images in any way with any software product without Stardock's express permission. You may use these images in your website or product as long as this permission.txt is linked somewhere along with Stardock's copyright notice with a link to Stardock's homepage: http://www.stardock.com. Designed Use: These weather images are designed to provide the various weather conditions reported by weather services. It was created for use with Stardock DesktopX (http://www.desktopx.net) and Stardock ObjectDock (http://www.objectdock.com) both of which allow users to monitor the weather conditions from their desktop. - Once setting FE-Legal. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484644] Review Request: screenlets - Fully themeable mini-apps
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=484644
--- Comment #20 from Sergio Pascual sergio.pa...@gmail.com 2009-05-27
07:57:59 EDT ---
A few quick comments:
* Please use command names consistently, you have both %{__python} and rm for
example. I recommend using python and rm (in the other hand, you can use
%{__python} and %{__rm}).
* screenlets-manager /dev/null doesn't work. You don't have to redirect
stdout, it goes automatically to .xsession-errors on a graphic sessions.
A simple
Exec=screenlets-manager
in screenlets-manager.desktop does the job.
* You can join all the %{_bindir}/screenlets-whatever in %{_bindir}/*
* The directory %{_datadir}/icons/ for screenlets.svg seems wrong to me. In my
system is the only icon present there. I suggest
/usr/share/icons/hicolor/scalable/apps and add Requires: hicolor-icon-theme
* You must update the icon cache after installing screenlets.svg. See the
details here:
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484644] Review Request: screenlets - Fully themeable mini-apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484644 Sergio Pascual sergio.pa...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||sergio.pa...@gmail.com AssignedTo|nob...@fedoraproject.org|sergio.pa...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484644] Review Request: screenlets - Fully themeable mini-apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484644 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Blocks||496433(RussianFedora) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484644] Review Request: screenlets - Fully themeable mini-apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484644 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added CC||meta...@gmail.com --- Comment #19 from Peter Lemenkov lemen...@gmail.com 2009-05-02 00:45:06 EDT --- *** Bug 429486 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484644] Review Request: screenlets - Fully themeable mini-apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484644 --- Comment #17 from Edouard Bourguignon ma...@linuxed.net 2009-03-27 03:22:31 EDT --- If I remove the quote is not validated by desktop-file-validate anymore... For me it's look better with the quotes. Are you sure it is not valid to use quote when there is a redirection? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484644] Review Request: screenlets - Fully themeable mini-apps
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=484644
--- Comment #18 from Edouard Bourguignon ma...@linuxed.net 2009-03-27
03:25:12 EDT ---
http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s06.html
Arguments may be quoted in whole. If an argument contains a reserved character
the argument must be quoted. [...] Reserved characters are space ( ), tab,
newline, double quote, single quote ('), backslash character (\),
greater-than sign (), less-than sign (), tilde (~), vertical bar (|),
ampersand (), semicolon (;), dollar sign ($), asterisk (*), question
mark (?), hash mark (#), parenthesis (() and ()) and backtick character
(`).
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484644] Review Request: screenlets - Fully themeable mini-apps
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=484644
--- Comment #15 from Guillaume Kulakowski llaum...@gmail.com 2009-03-26
14:13:33 EDT ---
buil...@enterprise ~ rpmlint -vi rpmbuild/**/screenlets*{rpm,spec}
screenlets.noarch: I: checking
screenlets.src: I: checking
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484644] Review Request: screenlets - Fully themeable mini-apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484644 --- Comment #16 from Guillaume Kulakowski llaum...@gmail.com 2009-03-26 14:18:32 EDT --- There is an error in desktopfile : screenlets-manager /dev/null and not : screenlets-manager /dev/null -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484644] Review Request: screenlets - Fully themeable mini-apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484644 --- Comment #14 from manuel wolfshant wo...@nobugconsulting.ro 2009-02-16 14:04:48 EDT --- (In reply to comment #10) I also add some french translation in the desktop file, do I have the right to do that? Yes, adding translations are always welcome (assuming they are correct, of course :) ) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484644] Review Request: screenlets - Fully themeable mini-apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484644 --- Comment #4 from Edouard Bourguignon ma...@linuxed.net 2009-02-15 08:30:22 EDT --- Do you mean screenlets package doesn't need to own the following directories: /usr/lib/python2.5/site-packages/screenlets /usr/share/screenlets /usr/share/screenlets-manager ? Is it ok to have unowned directories? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484644] Review Request: screenlets - Fully themeable mini-apps
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=484644
--- Comment #5 from leigh scott leigh123li...@googlemail.com 2009-02-15
09:29:16 EDT ---
(In reply to comment #4)
Do you mean screenlets package doesn't need to own the following directories:
/usr/lib/python2.5/site-packages/screenlets
/usr/share/screenlets
/usr/share/screenlets-manager
? Is it ok to have unowned directories?
A package should own any directory it creates.
i.e
%files -f %{name}.lang
%defattr(-,root,root,-)
%doc AUTHORS CHANGELOG COPYING DEVELOPERS LICENCE README TODO
%{_bindir}/screenlets
%{_bindir}/screenlets-daemon
%{_bindir}/screenlets-manager
%{_bindir}/screenlets-packager
%{_bindir}/screenletsd
%dir %{python_sitelib}/screenlets
%{python_sitelib}/screenlets/*
%{python_sitelib}/screenlets-%{version}-py2.5.egg-info
%{_datadir}/applications/screenlets-manager.desktop
%{_datadir}/icons/screenlets.svg
%dir %{_datadir}/screenlets-manager
%{_datadir}/screenlets-manager/*
%dir %{_datadir}/screenlets
%{_datadir}/screenlets/*
Also I made a mistake on the desktop-file-install, it should be
desktop-file-install --vendor --delete-original \
--dir $RPM_BUILD_ROOT%{_datadir}/applications \
$RPM_BUILD_ROOT%{_datadir}/applications/%{name}-manager.desktop
I also believe the path in Icon= should be removed along with the .svg
Icon=/usr/share/icons/screenlets.svg
should be
Icon=screenlets
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484644] Review Request: screenlets - Fully themeable mini-apps
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=484644
--- Comment #6 from Edouard Bourguignon ma...@linuxed.net 2009-02-15
09:50:30 EDT ---
Ok, I'm on the way to fix the desktop file.
Sorry to ask again, it's not clear for me, the documentation here
http://fedoraproject.org/wiki/Packaging/UnownedDirectories says:
%{_datadir}/foo/*
This includes everything _in_ foo, but not foo itself. rpm -qlv pkgname
will show a missing drwxr-xr-x entry for foo. Correct would be:
%{_datadir}/foo/
to include the directory _and_ the entire tree below it.
And rpm -qplv screenlets-0.1.2-1.fc10.noarch.rpm already lists this directories
...
drwxr-xr-x2 rootroot0 févr. 15 15:38
/usr/lib/python2.5/site-packages/screenlets
...
drwxr-xr-x2 rootroot0 févr. 15 15:38
/usr/share/screenlets
drwxr-xr-x2 rootroot0 févr. 15 15:38
/usr/share/screenlets-manager
...
What am I missing? Can a directory be in the listing but still be unowned?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484644] Review Request: screenlets - Fully themeable mini-apps
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=484644
--- Comment #7 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-02-15
09:54:58 EDT ---
(In reply to comment #5)
%files -f %{name}.lang
%defattr(-,root,root,-)
%doc AUTHORS CHANGELOG COPYING DEVELOPERS LICENCE README TODO
%{_bindir}/screenlets
%{_bindir}/screenlets-daemon
%{_bindir}/screenlets-manager
%{_bindir}/screenlets-packager
%{_bindir}/screenletsd
%dir %{python_sitelib}/screenlets
%{python_sitelib}/screenlets/*
%{python_sitelib}/screenlets-%{version}-py2.5.egg-info
%{_datadir}/applications/screenlets-manager.desktop
%{_datadir}/icons/screenlets.svg
%dir %{_datadir}/screenlets-manager
%{_datadir}/screenlets-manager/*
%dir %{_datadir}/screenlets
%{_datadir}/screenlets/*
%files
%dir %{_datadir}/screenlets
%{_datadir}/screenlets/*
equals
%{_datadir}/screenlets/
The latter format contains the directory %{_datadir}/screenlets
and all files/directories/etc under %{_datadir}/screenlets.
Also for this package
%files
%dir %{python_sitelib}/screenlets
%{python_sitelib}/screenlets/*
%{python_sitelib}/screenlets-%{version}-py2.5.egg-info
can be unified to
%{python_sitelib}/*
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484644] Review Request: screenlets - Fully themeable mini-apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484644 --- Comment #8 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-02-15 09:59:52 EDT --- (and also note that rawhide uses python 2.6) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484644] Review Request: screenlets - Fully themeable mini-apps
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=484644
--- Comment #9 from leigh scott leigh123li...@googlemail.com 2009-02-15
10:01:35 EDT ---
(In reply to comment #7)
(In reply to comment #5)
%files -f %{name}.lang
%defattr(-,root,root,-)
%doc AUTHORS CHANGELOG COPYING DEVELOPERS LICENCE README TODO
%{_bindir}/screenlets
%{_bindir}/screenlets-daemon
%{_bindir}/screenlets-manager
%{_bindir}/screenlets-packager
%{_bindir}/screenletsd
%dir %{python_sitelib}/screenlets
%{python_sitelib}/screenlets/*
%{python_sitelib}/screenlets-%{version}-py2.5.egg-info
%{_datadir}/applications/screenlets-manager.desktop
%{_datadir}/icons/screenlets.svg
%dir %{_datadir}/screenlets-manager
%{_datadir}/screenlets-manager/*
%dir %{_datadir}/screenlets
%{_datadir}/screenlets/*
%files
%dir %{_datadir}/screenlets
%{_datadir}/screenlets/*
equals
%{_datadir}/screenlets/
The latter format contains the directory %{_datadir}/screenlets
and all files/directories/etc under %{_datadir}/screenlets.
Also for this package
%files
%dir %{python_sitelib}/screenlets
%{python_sitelib}/screenlets/*
%{python_sitelib}/screenlets-%{version}-py2.5.egg-info
can be unified to
%{python_sitelib}/*
Thanks for the info.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484644] Review Request: screenlets - Fully themeable mini-apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484644 --- Comment #10 from Edouard Bourguignon ma...@linuxed.net 2009-02-15 10:06:56 EDT --- So here are the new files. SPEC: http://www.linuxed.net/~madko/fedora/screenlets.spec SRPM: http://www.linuxed.net/~madko/fedora/screenlets-0.1.2-2.fc10.src.rpm RPM: http://www.linuxed.net/~madko/fedora/screenlets-0.1.2-2.fc10.noarch.rpm btw, I use desktop-file-validate instead of desktop-file-install because the desktop file is already installed in the good place. Is it ok? I also add some french translation in the desktop file, do I have the right to do that? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484644] Review Request: screenlets - Fully themeable mini-apps
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=484644
--- Comment #11 from leigh scott leigh123li...@googlemail.com 2009-02-15
10:57:22 EDT ---
(In reply to comment #10)
So here are the new files.
SPEC: http://www.linuxed.net/~madko/fedora/screenlets.spec
SRPM: http://www.linuxed.net/~madko/fedora/screenlets-0.1.2-2.fc10.src.rpm
RPM: http://www.linuxed.net/~madko/fedora/screenlets-0.1.2-2.fc10.noarch.rpm
btw, I use desktop-file-validate instead of desktop-file-install because the
desktop file is already installed in the good place. Is it ok?
I believe it is acceptable to use desktop-file-validate.
I also add some french translation in the desktop file, do I have the right to
do that?
I not sure.
The summary is better, but still needs to be shorter.
[le...@localhost Download]$ rpmlint -vi
'/home/leigh/Download/screenlets-0.1.2-2.fc10.noarch.rpm'
screenlets.noarch: I: checking
screenlets.noarch: E: summary-too-long Screenlets are fully themeable mini-apps
that improve the usability and eye-candy of the modern composited Linux-desktop
The Summary: must not exceed 79 characters.
1 packages and 0 specfiles checked; 1 errors, 0 warnings.
[le...@localhost Download]$ rpmlint -vi
'/home/leigh/Download/screenlets-0.1.2-2.fc10.src.rpm'
screenlets.src: I: checking
screenlets.src: E: summary-too-long Screenlets are fully themeable mini-apps
that improve the usability and eye-candy of the modern composited Linux-desktop
The Summary: must not exceed 79 characters.
1 packages and 0 specfiles checked; 1 errors, 0 warnings.
[le...@localhost Download]$
This bit is wrong
Source0:%{name}-%{version}.tar.bz2
You must use a full URL to the package in the SourceX: line.
i.e
Source0:
http://code.launchpad.net/screenlets/trunk/0.1.2/+download/%{name}-%{version}.tar.bz2
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484644] Review Request: screenlets - Fully themeable mini-apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484644 --- Comment #12 from leigh scott leigh123li...@googlemail.com 2009-02-15 10:58:57 EDT --- https://fedoraproject.org/wiki/Packaging/SourceURL -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484644] Review Request: screenlets - Fully themeable mini-apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484644 --- Comment #13 from Edouard Bourguignon ma...@linuxed.net 2009-02-15 14:16:09 EDT --- Ok, summary has been shorten (again) and source url fixed in this -3 release. Here are the new files. SPEC: http://www.linuxed.net/~madko/fedora/screenlets.spec SRPM: http://www.linuxed.net/~madko/fedora/screenlets-0.1.2-3.fc10.src.rpm RPM: http://www.linuxed.net/~madko/fedora/screenlets-0.1.2-3.fc10.noarch.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484644] Review Request: screenlets - Fully themeable mini-apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484644 --- Comment #2 from leigh scott leigh123li...@googlemail.com 2009-02-14 16:58:41 EDT --- You will also need to add. BuildRequires:desktop-file-utils -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484644] Review Request: screenlets - Fully themeable mini-apps
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=484644
leigh scott leigh123li...@googlemail.com changed:
What|Removed |Added
CC||leigh123li...@googlemail.co
||m
--- Comment #1 from leigh scott leigh123li...@googlemail.com 2009-02-14
16:57:29 EDT ---
1. You need to validate the desktop file.
i.e
desktop-file-install --vendor --delete-original \
--dir $RPM_BUILD_ROOT%{_datadir}/applications \
--add-category X-Fedora \
$RPM_BUILD_ROOT%{_datadir}/applications/%{name}-manager.desktop
http://fedoraproject.org/wiki/Packaging/Guidelines#desktop
2. The summary is very vague and doesn't describe the package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484644] Review Request: screenlets - Fully themeable mini-apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484644 --- Comment #3 from leigh scott leigh123li...@googlemail.com 2009-02-14 17:51:38 EDT --- Doesn't screenlets need to own the directories . /usr/lib/python2.5/site-packages/screenlets /usr/share/screenlets and /usr/share/screenlets-manager http://fedoraproject.org/wiki/Packaging/Guidelines#FileAndDirectoryOwnership -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
