[Bug 532306] Review Request: rubygem-ruby-debug - Faster implementation of the standard Debugging
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532306 --- Comment #10 from Jeroen van Meeuwen kana...@kanarip.com 2010-01-09 05:47:29 EST --- Would it be acceptable to ship these two packages from the same CVS module (and so with one .spec as well)? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 532306] Review Request: rubygem-ruby-debug - Faster implementation of the standard Debugging
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532306 --- Comment #11 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-01-09 06:46:37 EST --- I think 2 gems (-ruby-debug -ruby-debug-base) should be packaged into seperated srpms (and so CVS request should be done seperately). Also I think seperating these 2 gems will make spec file more readable. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 532306] Review Request: rubygem-ruby-debug - Faster implementation of the standard Debugging
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532306 --- Comment #12 from Jeroen van Meeuwen kana...@kanarip.com 2010-01-09 07:06:22 EST --- Fair enough, let's hold off on this one until we have rubygem-ruby-debug-base packaged/reviewed then -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 532306] Review Request: rubygem-ruby-debug - Faster implementation of the standard Debugging
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532306 Bug 532306 depends on bug 533725, which changed state. Bug 533725 Summary: Review Request: rubygem-linecache - Caches (Ruby source) files https://bugzilla.redhat.com/show_bug.cgi?id=533725 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 532306] Review Request: rubygem-ruby-debug - Faster implementation of the standard Debugging
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532306 --- Comment #8 from Jeroen van Meeuwen kana...@kanarip.com 2009-12-20 10:11:18 EDT --- Updated %define - %global New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-ruby-debug.spec New SRPM: http://www.kanarip.com/custom/f12/SRPMS/rubygem-ruby-debug-0.10.3-4.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 532306] Review Request: rubygem-ruby-debug - Faster implementation of the standard Debugging
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532306
--- Comment #9 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-12-20
15:06:52 EDT ---
Created an attachment (id=379509)
-- (https://bugzilla.redhat.com/attachment.cgi?id=379509)
Patch for ruby-debug to use system-wide -base and test fix
Ah...
(In reply to comment #3)
(In reply to comment #2)
(In reply to comment #1)
- Please create one srpm per one gem.
These gems do not distribute very well separately, they have the same
upstream
and one requires the other in a %{version}-%{release} specific manner.
- Ah, I checked two gems and actually dependency is in loop...
Well, I checked these two gems' dependency again and actually
ruby-debug-base does not require ruby-debug
( ruby-debug-base-0.10.3/test/base/base.rb has require 'ruby_debug'
for example, but this is satisfied by ruby_debug.so in ruby-debug-base
(and not by ruby-debug.rb in ruby-debug gem) )
Also rake test under ruby-debug-base succeeds without ruby-debug
gem. So still ruby-debug-base and ruby-debug should be packaged seperately.
(ruby-debug-base does not depend on ruby-debug but ruby-debug does depend
on ruby-debug-base)
For ruby-debug, currently your spec file contains:
-
99 %check
100 pushd %{_builddir}/%{name}-%{version}/%{geminstdir2}
101 rake -f ../ruby-debug-0.10.3/Rakefile test
-
This skips many tests, because ruby-debug Rakefile contains
-
27 CLI_TEST_FILE_LIST = FileList['test/cli/commands/unit/*.rb',
28'test/cli/commands/*_test.rb',
29'test/cli/**/*_test.rb',
30'test/test-*.rb']
61 t.test_files = CLI_TEST_FILE_LIST
--
however many of these files cannot be detected if the working
directory is ./%{geminstdir2}, not ./%{geminstdir}.
rake test for ruby-debug should be done under .%{geminstdir}.
Note that when executing rake test correctly under ./%{geminstdir}
many tests fail and patch is needed (attached). After applying patch:
---
[tasa...@localhost ruby-debug-0.10.3]$ rake test
(in
/home/tasaka1/rpmbuild/Reviewing/rubygem-related/rubygem-ruby-debug/rubygem-ruby-debug-0.10.3-4.fc12.src/TMP2/DEBUGINSTDIR/gems/ruby-debug-0.10.3)
ruby_debug already installed, skipping creating shared library extension
/usr/bin/ruby -Ilib:./ext:./lib
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake/rake_test_loader.rb
test/base/base.rb test/base/binding.rb test/base/catchpoint.rb
Loaded suite /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake/rake_test_loader
Started
.
Finished in 0.003895 seconds.
5 tests, 30 assertions, 0 failures, 0 errors
/usr/bin/ruby -Ilib:./ext:./lib:./cli
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake/rake_test_loader.rb
test/cli/commands/unit/regexp.rb test/cli/commands/catchpoint_test.rb
test/cli/commands/catchpoint_test.rb test/test-edit.rb test/test-info.rb
test/test-source.rb test/test-annotate.rb test/test-ctrl.rb
test/test-list.rb test/test-catch.rb test/test-save.rb
test/test-info-thread.rb test/test-emacs-basic.rb test/test-quit.rb
test/test-init.rb test/test-method.rb test/test-info-var.rb
test/test-output.rb test/test-trace.rb test/test-setshow.rb
test/test-help.rb test/test-hist.rb test/test-raise.rb
test/test-breakpoints.rb test/test-finish.rb test/test-stepping.rb
test/test-frame.rb test/test-condition.rb test/test-enable.rb
test/test-display.rb test/test-dollar-0.rb test/test-break-bad.rb
test/test-pm.rb
Loaded suite /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake/rake_test_loader
Started
.Skipping method sig test
..
Finished in 18.947538 seconds.
35 tests, 46 assertions, 0 failures, 0 errors
---
Currently only the first 5 tests are executed.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 532306] Review Request: rubygem-ruby-debug - Faster implementation of the standard Debugging
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532306 --- Comment #7 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-11-14 13:29:54 EDT --- (Just putting a note that I postpone reviewing this review request until bug 533725 is completed) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 532306] Review Request: rubygem-ruby-debug - Faster implementation of the standard Debugging
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532306
--- Comment #6 from Jeroen van Meeuwen kana...@kanarip.com 2009-11-08
11:36:07 EDT ---
(In reply to comment #5)
Well,
- Please package linecache first.
%check fails without linecache and even without %check ruby-debug-base
actually needs linecache (see ruby-debug-base-0.10.3/lib/ruby-debug-base.rb)
http://koji.fedoraproject.org/koji/taskinfo?taskID=1794237
( Does your srpm actually builds for you? )
It does build on my machine locally but then again I already have a linecache
package; this package is part of a bunch of packages I'm working on. I'll be
submitting rubygem-linecache for review asap, and create a dependency between
the two reviews.
- head command or so is very dangerous when binary files exist.
Actually
---
61 # Fix anything executable that does not have a shebang
62 for file in `find %{buildroot}/%{geminstdir}
%{buildroot}/%{geminstdir2} -type f -perm /a+x`; do
63 [ -z `head -n 1 $file | grep \^#!/\` ] chmod -v 644 $file
64 done
---
changes the permission of ruby_debug.so to 0644 and currently
debuginfo rpm is not correctly created.
This should also filter on -name *.rb, which I fixed.
- Executing %check under %buildroot is wrong for this package
because rake test again tries to create ruby_debug.so under
%buildroot%{geminstdir2}/ext/ because we move this file to
%buildroot%ruby_sitearch
---
853 Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.5gRRsq
860 + rake -f ../ruby-debug-0.10.3/Rakefile test
865 gcc -shared -o ruby_debug.so breakpoint.o ruby_debug.o -L. -L/usr/lib
-L. -rdynamic -Wl,-export-dynamic-lruby -lpthread -lrt -ldl -lcrypt -lm
-lc
---
%check must be done under %_builddir for this package.
Fixed this too.
New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-ruby-debug.spec
New SRPM:
http://www.kanarip.com/custom/f12/SRPMS/rubygem-ruby-debug-0.10.3-3.fc12.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 532306] Review Request: rubygem-ruby-debug - Faster implementation of the standard Debugging
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532306 Jeroen van Meeuwen kana...@kanarip.com changed: What|Removed |Added Depends on||533725 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 532306] Review Request: rubygem-ruby-debug - Faster implementation of the standard Debugging
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532306
--- Comment #5 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-11-07
11:49:20 EDT ---
Well,
- Please package linecache first.
%check fails without linecache and even without %check ruby-debug-base
actually needs linecache (see ruby-debug-base-0.10.3/lib/ruby-debug-base.rb)
http://koji.fedoraproject.org/koji/taskinfo?taskID=1794237
( Does your srpm actually builds for you? )
- head command or so is very dangerous when binary files exist.
Actually
---
61 # Fix anything executable that does not have a shebang
62 for file in `find %{buildroot}/%{geminstdir}
%{buildroot}/%{geminstdir2} -type f -perm /a+x`; do
63 [ -z `head -n 1 $file | grep \^#!/\` ] chmod -v 644 $file
64 done
---
changes the permission of ruby_debug.so to 0644 and currently
debuginfo rpm is not correctly created.
- Executing %check under %buildroot is wrong for this package
because rake test again tries to create ruby_debug.so under
%buildroot%{geminstdir2}/ext/ because we move this file to
%buildroot%ruby_sitearch
---
853 Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.5gRRsq
860 + rake -f ../ruby-debug-0.10.3/Rakefile test
865 gcc -shared -o ruby_debug.so breakpoint.o ruby_debug.o -L. -L/usr/lib
-L. -rdynamic -Wl,-export-dynamic-lruby -lpthread -lrt -ldl -lcrypt -lm
-lc
---
%check must be done under %_builddir for this package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 532306] Review Request: rubygem-ruby-debug - Faster implementation of the standard Debugging
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532306 --- Comment #4 from Jeroen van Meeuwen kana...@kanarip.com 2009-11-04 07:40:05 EDT --- I modified the procedure just a little bit, as I generally want to prevent installing anything in %prep; in this case, it works out just fine (I think). New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-ruby-debug.spec New SRPM: http://www.kanarip.com/custom/f12/SRPMS/rubygem-ruby-debug-0.10.3-2.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 532306] Review Request: rubygem-ruby-debug - Faster implementation of the standard Debugging
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532306
--- Comment #3 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-11-03
11:52:54 EDT ---
(In reply to comment #2)
(In reply to comment #1)
- Please create one srpm per one gem.
These gems do not distribute very well separately, they have the same upstream
and one requires the other in a %{version}-%{release} specific manner.
- Ah, I checked two gems and actually dependency is in loop...
- Also, you must not strip rebuilt binaries and create debuginfo rpm
correctly. Please refer to:
https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Gem_with_extension_libraries_written_in_C
I don't know how to resolve the inclusion of a reference to the buildroot in
the binary blob (I did know how to make it disappear in the included Makefile,
but not the blob):
+ /usr/lib/rpm/check-buildroot
Binary file
/home/jmeeuwen/devel/rpmbuild/BUILDROOT/rubygem-ruby-debug-0.10.3-1.fc12.x86_64/usr/lib64/ruby/site_ruby/1.8/x86_64-linux/ruby_debug.so
matches
Found
'/home/jmeeuwen/devel/rpmbuild/BUILDROOT/rubygem-ruby-debug-0.10.3-1.fc12.x86_64'
in installed files; aborting
error: Bad exit status from /var/tmp/rpm-tmp.eZZmKv (%install)
- The above guideline is actually for resolving this issue.
The reason check-buildroot fails is that gem is installed under
%buildroot directly. Also find-debuginfo rpm expects that
compilation of C codes is done under %_builddir.
Please follow this lines:
---
# First, %prep stage must contain %setup -q -c -T to create the directory
where C libraries are compiled.
# Then at %build stage the Ruby Gem must be installed under the directory
created at %prep stage to get C libraries compiled under there.
---
For example:
http://cvs.fedoraproject.org/viewvc/rpms/rubygem-hpricot/devel/rubygem-hpricot.spec?view=co
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 532306] Review Request: rubygem-ruby-debug - Faster implementation of the standard Debugging
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532306 --- Comment #1 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-11-02 12:45:05 EDT --- - Please create one srpm per one gem. - Also, you must not strip rebuilt binaries and create debuginfo rpm correctly. Please refer to: https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Gem_with_extension_libraries_written_in_C - Also unless unavoided I don't think to add || : for test results. If test fails, you should debug it first. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 532306] Review Request: rubygem-ruby-debug - Faster implementation of the standard Debugging
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532306
--- Comment #2 from Jeroen van Meeuwen kana...@kanarip.com 2009-11-02
13:51:46 EDT ---
(In reply to comment #1)
- Please create one srpm per one gem.
These gems do not distribute very well separately, they have the same upstream
and one requires the other in a %{version}-%{release} specific manner.
- Also, you must not strip rebuilt binaries and create debuginfo rpm
correctly. Please refer to:
https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Gem_with_extension_libraries_written_in_C
I don't know how to resolve the inclusion of a reference to the buildroot in
the binary blob (I did know how to make it disappear in the included Makefile,
but not the blob):
+ /usr/lib/rpm/check-buildroot
Binary file
/home/jmeeuwen/devel/rpmbuild/BUILDROOT/rubygem-ruby-debug-0.10.3-1.fc12.x86_64/usr/lib64/ruby/site_ruby/1.8/x86_64-linux/ruby_debug.so
matches
Found
'/home/jmeeuwen/devel/rpmbuild/BUILDROOT/rubygem-ruby-debug-0.10.3-1.fc12.x86_64'
in installed files; aborting
error: Bad exit status from /var/tmp/rpm-tmp.eZZmKv (%install)
- Also unless unavoided I don't think to add || : for test results.
If test fails, you should debug it first.
I've fiddled around with it a bit and it now seems OK.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
