[Bug 193898] Review Request: Jython - Java source interpreter

2007-05-31 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium
   Priority|normal  |medium

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




--- Additional Comments From [EMAIL PROTECTED]  2007-06-01 01:27 EST ---
This package seems to have been imported and built a while back. 
Closing this review bug now. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2007-02-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2007-02-10 12:27 EST ---
*** Bug 227078 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2007-01-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2007-01-21 21:08 EST ---
(In reply to comment #23)
 Okay, I've (finally!) taken care of the two issues above.  Here's the new spec
 and SRPM:

rpmlint now complains about the explicit libreadline-java dependency, but I
think this must be a bug in rpmlint.  So... APPROVED!  

Be sure to close this bug once you've pushed the package out.  Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2007-01-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898





--- Additional Comments From [EMAIL PROTECTED]  2007-01-11 18:02 EST ---
Okay, I've (finally!) taken care of the two issues above.  Here's the new spec
and SRPM:

http://people.redhat.com/overholt/jython.spec
http://people.redhat.com/overholt/jython-2.2-0.2.a1.src.rpm

Here's a diff from the most recently reviewed spec and the one above:

http://people.redhat.com/overholt/jython.spec.patch

Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2006-12-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898





--- Additional Comments From [EMAIL PROTECTED]  2006-12-20 08:33 EST ---
Thanks Andrew.  Here's the full review.  I only have two comments.  One seems
easy and the other looks like a little more work.  Look for the lines starting
in 'X'.

* package meets and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.
* License text included in package.
* source files match upstream (extracted from upstream cvs so no md5sum 
available.)
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock.

* rpmlint jython-2.2-0.1.a1.fc6.i386.rpm
W: jython invalid-license Modified CNRI Open Source License
We can ignore this.

rpmlint jython-demo-2.2-0.1.a1.fc6.i386.rpm
W: jython-demo invalid-license Modified CNRI Open Source License
E: jython-demo no-jar-manifest /usr/share/jython/Demo/jreload/example.jar
We can ignore these.

rpmlint jython-javadoc-2.2-0.1.a1.fc6.i386.rpm
W: jython-javadoc invalid-license Modified CNRI Open Source License
We can ignore this.

rpmlint jython-2.2-0.1.a1.fc6.src.rpm
W: jython invalid-license Modified CNRI Open Source License
We can ignore this.

X are these final provides and requires are sane?:
jython-2.2-0.1.a1.fc6.i386.rpm
  jython-2.2.jar.so
  jython = 2.2-0.1.a1.fc6
==
  java-gcj-compat = 1.0.31
  jpackage-utils = 0:1.5
  oro
  python = 2.4
  servlet

Don't we need to Require libreadline-java and mysql-connector-java?

* shared libraries are present, but no ldconfig required.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is not present
* scriptlets OK
* code, not content.
X ht2html generated documentation isn't being generated even
  though we require ht2html.
  I think build.xml needs one more if=full-build removed, and
  then these docs should probably go in a documentation package.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app (no .desktop file required).
* not a web app.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2006-12-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898





--- Additional Comments From [EMAIL PROTECTED]  2006-12-19 14:56 EST ---
Newly updated spec and SRPM without jpp:

http://people.redhat.com/overholt/jython.spec
http://people.redhat.com/overholt/jython-2.2-0.a1.1.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2006-12-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898





--- Additional Comments From [EMAIL PROTECTED]  2006-12-19 15:07 EST ---
Newly updated spec and SRPM with correct release:

http://people.redhat.com/overholt/jython.spec
http://people.redhat.com/overholt/jython-2.2-0.1.a1.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2006-12-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898





--- Additional Comments From [EMAIL PROTECTED]  2006-12-04 14:53 EST ---
(In reply to comment #16)
 I've taken this over from Igor.  I made a few changes and updated to 2.2a1. 
 I've also fixed the mock error you were seeing, Anthony, and added a script to
 fetch the tarball and explain how to do it.

Sorry I missed the update on this.  I'm rerunning it in mock and will go through
the formal review assuming there are no problems.

Thanks


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2006-12-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898





--- Additional Comments From [EMAIL PROTECTED]  2006-12-04 15:59 EST ---
Andrew - the package naming goes against current package naming rules...

http://fedoraproject.org/wiki/PackagingDrafts/JavaPackageNaming

I've simply been removing the jpp part from my packages (see itext, for 
instance).


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2006-11-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898





--- Additional Comments From [EMAIL PROTECTED]  2006-11-16 13:30 EST ---
I've taken this over from Igor.  I made a few changes and updated to 2.2a1. 
I've also fixed the mock error you were seeing, Anthony, and added a script to
fetch the tarball and explain how to do it.

http://people.redhat.com/overholt/jython.spec
http://people.redhat.com/overholt/jython-2.2-0.a1.1jpp_1fc.fc7.src.rpm

and the differences between my spec and Igor's latest:

http://people.redhat.com/overholt/jython.spec.diff

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2006-11-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898





--- Additional Comments From [EMAIL PROTECTED]  2006-11-16 23:15 EST ---
Andrew, thanks for taking care of this. Unfortunately I couldn't find the time 
to deal with it lately.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2006-10-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898





--- Additional Comments From [EMAIL PROTECTED]  2006-10-21 14:02 EST ---
Sorry for the long delay.

Where did you get the source tarball from?  If we're not using an upstream
release, then the spec file should explain where the sources are from and how to
get them.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2006-10-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898





--- Additional Comments From [EMAIL PROTECTED]  2006-10-21 14:05 EST ---
Building with 'mock' fails like so...

+ /usr/lib/rpm/check-buildroot
Binary file
/var/tmp/jython-2.2-0.a0.2jpp_5fc.fc6-root-mockbuild/usr/lib/debug/usr/lib/gcj/jython/jreload.so.debug
matches
Found '/var/tmp/jython-2.2-0.a0.2jpp_5fc.fc6-root-mockbuild' in installed files;
aborting
error: Bad exit status from /var/tmp/rpm-tmp.37933 (%install)



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2006-09-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898





--- Additional Comments From [EMAIL PROTECTED]  2006-09-28 19:25 EST ---
Anthony,
Any chance you could take a look at this soon?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2006-09-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898





--- Additional Comments From [EMAIL PROTECTED]  2006-09-22 10:09 EST ---
New files:
http://people.redhat.com/ifoox/extras/jython.spec
http://people.redhat.com/ifoox/extras/jython-2.2-0.a0.2jpp_4fc.src.rpm

I've fixed the problem with the non-executable scripts by bringing back jython's
copy of python2.2 which was carried in the srpm, since it doesn't actually work
when I link it against python 2.4. I think that the no-manifest issue can be
ignored since the example jar works fine anyway. If you think that that the
license issue is OK then I think this is pretty much done.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2006-09-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898





--- Additional Comments From [EMAIL PROTECTED]  2006-09-22 10:29 EST ---
New files:
http://people.redhat.com/ifoox/extras/jython.spec
http://people.redhat.com/ifoox/extras/jython-2.2-0.a0.2jpp_5fc.src.rpm

Minor fix, removing redundant patch.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2006-09-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2006-09-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898





--- Additional Comments From [EMAIL PROTECTED]  2006-09-09 13:33 EST ---
(In reply to comment #5)
 (In reply to comment #4)
   - Change Group to Development/Libraries
  Fixed.
 
 I'm sorry.  This was another mistake of mine.  It should be System
 Environment/Libraries.

Seems like System/Environment/Libraries is less appropriate for jython than
Development/Libraries or even Development/Languages. Why do you say that
System/Environment/Libraries is the correct one?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2006-09-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898





--- Additional Comments From [EMAIL PROTECTED]  2006-09-09 13:39 EST ---
(In reply to comment #6)
 Seems like System/Environment/Libraries is less appropriate for jython than
 Development/Libraries or even Development/Languages. 

Development/Libraries doesn't really apply to Java, since it's for .so files and
other things you would only use at build-time.  I think you're right about
Development/Languages though.  Let's use that one.




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2006-09-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898





--- Additional Comments From [EMAIL PROTECTED]  2006-09-09 14:19 EST ---
(In reply to comment #7)
I think you're right about
 Development/Languages though.  Let's use that one.
OK. 

Another important issue which I'm not sure how to address is the license. The
license file calls it the 'Jython license'
(http://www.jython.org/Project/license.html), but there is not equivalent
appropriate license that rpmlint likes. What do we do in a case like this?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2006-09-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898





--- Additional Comments From [EMAIL PROTECTED]  2006-09-09 14:33 EST ---
New files:
http://people.redhat.com/ifoox/extras/jython-2.2-0.a0.2jpp_3fc.src.rpm
http://people.redhat.com/ifoox/extras/jython.spec

There are currently 3 issues remaining with the package (that I know of)
1. License (comment #8):
W: jython invalid-license Modified CNRI Open Source License

2. Copying files from python:
For some reason the jython buildsystem copies some files from the python
standard library into it's own directory. Since I made it use the system python
instead of the python2.2 that was previously included, we now have duplication.
These are the files that also produce permission errors from rpmlint:
E: jython non-executable-script /usr/share/jython/Lib/uu.py 0644
This is because they are not executable but contain a #!. I'll try to figure out
why jython copies these files and if we can make it use the ones in
%{_libdir}/python2.4/site-packages instead. If not I'll see if I can symlink
them instead of copying.

3. Missing jar manifest in one of the demo jars:
E: jython-demo no-jar-manifest /usr/share/jython/Demo/jreload/example.jar
I'm not sure whether this is an important issue since this is just a demo jar,
which will probably function without the manifest file anyway.

I'll try to resolve issue 2 (and maybe 3) today and tomorrow, but any
suggestions are welcome. But I'm really not sure what to do about issue 1.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2006-09-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898


Bug 193898 depends on bug 193897, which changed state.

Bug 193897 Summary: Review Request: mysql-connector-java - Official JDBC driver 
for MySQL
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193897

   What|Old Value   |New Value

 Resolution||NEXTRELEASE
 Status|ASSIGNED|CLOSED



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2006-09-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898





--- Additional Comments From [EMAIL PROTECTED]  2006-09-08 20:51 EST ---
New files:
http://people.redhat.com/ifoox/extras/jython-2.2-0.a0.2jpp_2fc.src.rpm
http://people.redhat.com/ifoox/extras/jython.spec

(In reply to comment #2)
 Just some quick comments from looking at parts of the spec file..
 
 - Summary is odd: Java source interpreter
Fixed
 - Source lines should be URLs to sources
The source appears to be a CVS snapshot, but I'll check to make sure whether
it's not downloaded.
 - Remove Epoch
Fixed.
 - Change Group to Development/Libraries
Fixed.
 - Make BuildRoot standard 
Fixed.
 - Remove these lines...
 Distribution: JPackage
 Vendor:   JPackage Project
Fixed. 

Also fixed:
- Add dist tag.
- Fix compile line to use the system Python libraries instead of the python2.2
source.
- Remove Source1 (python2.2 library).
- Move buildroot removal from prep to install.
- Use libedit (EditLine) instead of GNU readline.



(In reply to comment #3)
 BTW, I don't think we should be linking libreadline-java with jython since I
 believe the licenses are incompatible.  See this thread for discussion and a
 potential solution:
 http://sourceforge.net/mailarchive/message.php?msg_id=707283

I've built the latest version of libreadline-java against libedit (EditLine)
instead of GNU readline, libedit is LGPL, and is what the poster in the thread
you mention proposes. So this should be fine.  See bug #193896.

There are still many issues to resolve with this package, I will try to resolve
most of them tomorrow. But I have a few questions which hopefully someone can
answer. 

1. rpmlint gives me errors like this when running it on the main rpm:
E: jython non-executable-script /usr/share/jython/Lib/Cookie.py 0644
It doesn't give it for all the .py files in that directory, even though they all
have the same permissions. Should these be 755, or should these files be moved
to /usr/lib instead?

2. What should be the group for jython-demo?
I put it in Development/Documentation along with the manual and javadoc, but I'm
not sure this is right.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2006-09-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898


Bug 193898 depends on bug 193896, which changed state.

Bug 193896 Summary: Review Request: libreadline-java - Java wrapper for the 
GNU-readline library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193896

   What|Old Value   |New Value

 Resolution||RAWHIDE
 Status|ASSIGNED|CLOSED



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2006-09-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898





--- Additional Comments From [EMAIL PROTECTED]  2006-09-08 22:40 EST ---
(In reply to comment #4)
  - Change Group to Development/Libraries
 Fixed.

I'm sorry.  This was another mistake of mine.  It should be System
Environment/Libraries.

 1. rpmlint gives me errors like this when running it on the main rpm:
 E: jython non-executable-script /usr/share/jython/Lib/Cookie.py 0644
 It doesn't give it for all the .py files in that directory, even though they 
 all
 have the same permissions. Should these be 755, or should these files be moved
 to /usr/lib instead?

I think staying in /usr/share is fine.  I don't know why it's complaining.
 
 2. What should be the group for jython-demo?
 I put it in Development/Documentation along with the manual and javadoc, but 
 I'm
 not sure this is right.

Actually, FE has no Development/Documentation group.  It should just be
Documentation.  I can't think of a better place for the demos.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2006-09-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898


Bug 193898 depends on bug 193889, which changed state.

Bug 193889 Summary: Review Request: ht2html - The www.python.org Web site 
generator
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193889

   What|Old Value   |New Value

 Status|ASSIGNED|NEEDINFO_REPORTER
 Status|NEEDINFO_REPORTER   |NEEDINFO
 Resolution||NEXTRELEASE
 Status|NEEDINFO|CLOSED



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2006-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|177841  |
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2006-07-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898





--- Additional Comments From [EMAIL PROTECTED]  2006-07-14 03:01 EST ---
Just some quick comments from looking at parts of the spec file..

- Summary is odd: Java source interpreter
- Source lines should be URLs to sources
- Remove Epoch
- Change Group to Development/Libraries
- Make BuildRoot standard   
- Remove these lines...
Distribution:   JPackage
Vendor: JPackage Project

That's it for now.  Thanks for submitting this.  If nobody picks this up, I'll
do a formal review once the dependencies have been approved.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2006-06-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||177841
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 193898] Review Request: Jython - Java source interpreter

2006-06-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Jython -  Java source interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898


[EMAIL PROTECTED] changed:

   What|Removed |Added

  BugsThisDependsOn||193889, 193896, 193897




--- Additional Comments From [EMAIL PROTECTED]  2006-06-02 15:28 EST ---
Adding bug dependencies for all the packages that Jython depends on:
* mysql-connector-java
* ht2html
* libreadline-java

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review