[Bug 195363] Review Request: esc

2007-06-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esc


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195363


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium
   Priority|normal  |medium
Product|Fedora Core |Fedora




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 195363] Review Request: esc

2006-07-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esc


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195363


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO_REPORTER   |ASSIGNED




--- Additional Comments From [EMAIL PROTECTED]  2006-07-27 13:16 EST ---
Thanks!

The pwd is a mistake.

As for removing the directory,
Xulrunner leaves some stuff behind in the directory that does
not get removed when the RPM is un-installed.

I figured that we would not want to have the directory lying around.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 195363] Review Request: esc

2006-07-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esc


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195363





--- Additional Comments From [EMAIL PROTECTED]  2006-07-27 14:43 EST ---
comps should be group 'gnome-desktop' default.

bob

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 195363] Review Request: esc

2006-07-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esc


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195363





--- Additional Comments From [EMAIL PROTECTED]  2006-07-27 15:03 EST ---
what kind of files?  you can't just remove directories on users systems (what if
they put something in it?).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 195363] Review Request: esc

2006-07-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esc


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195363





--- Additional Comments From [EMAIL PROTECTED]  2006-07-27 17:23 EST ---
Excellent point.

I will remove that entry.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 195363] Review Request: esc

2006-07-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esc


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195363





--- Additional Comments From [EMAIL PROTECTED]  2006-07-27 17:44 EST ---
(In reply to comment #27)
 comps should be group 'gnome-desktop' default.
 
 bob

Added to comps.

Please close when package is built for rawhide.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 195363] Review Request: esc

2006-07-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esc


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195363


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




--- Additional Comments From [EMAIL PROTECTED]  2006-07-27 20:48 EST ---

Successfully built on relevant platforms except ppc64.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 195363] Review Request: esc

2006-07-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esc


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195363





--- Additional Comments From [EMAIL PROTECTED]  2006-07-26 12:48 EST ---
%{?dist} in Core packages now? I had removed them from those I moved from
Extra's as per the package guidelines for CORE

bob

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 195363] Review Request: esc and esc-xulrunner-devel

2006-07-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esc and esc-xulrunner-devel


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195363





--- Additional Comments From [EMAIL PROTECTED]  2006-07-25 22:51 EST ---
It looks like the spec and package moved to 

http://directory.fedora.redhat.com/built/rpm_review/jmagne/

yea? Looking good.  A few things:

- The gtk-update-icon-cache stuff still isn't right.  Have a look at
http://fedoraproject.org/wiki/ScriptletSnippets for the right idiom.

- you don't have to manually run tar for xulrunner, you can specify another
%setup line, although I don't remember the right arguments to give it off hand.

- Also, I don't think you should need %{_buildir} anywhere. rpm normally puts
you in the right directories i think.

- I think if you just put %doc esc/LICENSE in the filelist then it should get
moved to the right place (/usr/share/doc/esc-1.0.0/LICENSE) automatically, but I
could be wrong.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 195363] Review Request: esc

2006-07-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esc


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195363


[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|Review Request: esc and esc-|Review Request: esc
   |xulrunner-devel |




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 195363] Review Request: esc and esc-xulrunner-devel

2006-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esc and esc-xulrunner-devel


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195363





--- Additional Comments From [EMAIL PROTECTED]  2006-07-24 19:09 EST ---
Ray, ping, can you continue this review?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 195363] Review Request: esc and esc-xulrunner-devel

2006-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esc and esc-xulrunner-devel


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195363





--- Additional Comments From [EMAIL PROTECTED]  2006-07-25 01:43 EST ---
So I closed esc in the middle of the operation and it looks like it succeeded
fine.  Maybe the dialog just needs to change state when it's done.

The plugged-in keys list doesn't know my name or the issuer, but i'm guessing
that's a cert server configuration issue.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 195363] Review Request: esc and esc-xulrunner-devel

2006-07-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esc and esc-xulrunner-devel


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195363


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO_REPORTER   |ASSIGNED




--- Additional Comments From [EMAIL PROTECTED]  2006-07-20 21:27 EST ---
Thanks to the suggestions I have updated esc.spec and esc-1.0.0-1.src.rpm.

Now xulrunner gets built as part of the ess build process and the build glitches
reported should be taken care of.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 195363] Review Request: esc and esc-xulrunner-devel

2006-07-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esc and esc-xulrunner-devel


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195363


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|NEEDINFO_REPORTER
OtherBugsDependingO|188265  |188267
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 195363] Review Request: esc and esc-xulrunner-devel

2006-07-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esc and esc-xulrunner-devel


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195363


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|NEEDINFO
   Flag||needinfo?([EMAIL PROTECTED])




--- Additional Comments From [EMAIL PROTECTED]  2006-07-14 10:23 EST ---
So the esc-xulrunner-devel package is sort of weird.

First, we don't normally put -devel in the name of srpms.  -devel is usually
reserved for subpackages.

Also, you install all header files, images, config files, stylesheets, binaries,
etc into %{_libdir}.  Normally we put header files in %{_includedir}, images in
%{_datadir}, binaries in %{_bindir}, etc.

On the other hand, esc-xulrunner-devel is only needed for building esc, yea? not
for running esc?  Why are we installing it as a separate package at all then?
Can we just put the xulrunner tarball as an extra Source: line in the spec file
and get rid of esc-xulrunner-devel entirely?

Also, I tried to build the two packages and ran into problems.  esc looks for
something called nsinstall in wrong place. I had to create a symlink for the
build to finish.

After I got it built, it didn't work with our cert server.  It gave me an error
code 44 or something.  This actually brings up another point.

This tool only works with a closed source certificate server that most in the
fedora community don't have access to.  Maybe it would be better if we put this
in extras instead of core?  What do you think?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 195363] Review Request: esc and esc-xulrunner-devel

2006-07-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esc and esc-xulrunner-devel


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195363


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|ASSIGNED
   Flag|needinfo?([EMAIL PROTECTED])|




--- Additional Comments From [EMAIL PROTECTED]  2006-07-14 13:12 EST ---
Thanks for the comments:

Yes, esc-xulrunner-devel is only needed for esc to build against. Also
ESC privately deploys the xulrunner directory which is output by the xulrunner
build. 

It would be no big deal to simply build xulrunner as part of the ESC build.

As for the nsinstall problem I have not seen that here. Have you any log
snippets of that build failure?





-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 195363] Review Request: esc and esc-xulrunner-devel

2006-07-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esc and esc-xulrunner-devel


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195363





--- Additional Comments From [EMAIL PROTECTED]  2006-07-14 13:26 EST ---
Created an attachment (id=132450)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=132450action=view)
build log of failure

It looks like it's assuming the esc-xulrunner-devel build dir is still around.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 195363] Review Request: esc and esc-xulrunner-devel

2006-07-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esc and esc-xulrunner-devel


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195363





--- Additional Comments From [EMAIL PROTECTED]  2006-07-10 14:09 EST ---
A couple of comments.

We upstream ESC, yes?  Can we make the tarball .tar.bz2 or .tar.gz instead of
.tgz ?  It's more consistent that way.  Also, why don't we ship the shell script
and desktop file in the upstream tarball?

I've noticed in the %install section you are manually copying over files.  Does
the makefile have a working install target?  The usual procedure is

make install DESTDIR=$RPM_BUILD_ROOT

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 195363] Review Request: esc and esc-xulrunner-devel

2006-07-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esc and esc-xulrunner-devel


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195363


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|ASSIGNED
   Flag|needinfo?   |




--- Additional Comments From [EMAIL PROTECTED]  2006-07-05 12:04 EST ---
Last word was there won't be a system xulrunner for fc6/rhel5

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 195363] Review Request: esc and esc-xulrunner-devel

2006-06-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esc and esc-xulrunner-devel


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195363


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |NEEDINFO
   Flag||needinfo?




--- Additional Comments From [EMAIL PROTECTED]  2006-06-30 15:15 EST ---
I'd like to see this use the in distro xulrunner, still trying to get a timeline
on when that will be included in Core.  First glance at the specs look good
though.  Setting to needinfo in xulrunner.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 195363] Review Request: esc and esc-xulrunner-devel

2006-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esc and esc-xulrunner-devel


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195363





--- Additional Comments From [EMAIL PROTECTED]  2006-06-14 17:42 EST ---
We have xulrunner?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 195363] Review Request: esc and esc-xulrunner-devel

2006-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esc and esc-xulrunner-devel


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195363





--- Additional Comments From [EMAIL PROTECTED]  2006-06-14 19:58 EST ---
ESC is a xulrunner application.
If we have a xulrunner an official xulrunner rpm for Fedora that would be
preferable to esc-xulrunner-devel.

Bill do you know if there's a schedule for xulrunner?

Thanks,

bob

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 195363] Review Request: esc and esc-xulrunner-devel

2006-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esc and esc-xulrunner-devel


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195363


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED],
   ||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-06-14 20:49 EST ---
Sometime between now and the final release. :)

Cc'ing caillon, jrb.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review