[Bug 196627] Review Request: perl-SVN-Mirror - Mirror remote repository to local Subversion repository

2008-06-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SVN-Mirror - Mirror remote repository to local 
Subversion repository


https://bugzilla.redhat.com/show_bug.cgi?id=196627


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium
   Priority|normal  |medium
Product|Fedora Extras   |Fedora
Version|devel   |rawhide

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-06-06 14:08 EST ---
Package Change Request
==
Package Name: perl-SVN-Mirror
New Branches: EL-4 EL-5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 196627] Review Request: perl-SVN-Mirror - Mirror remote repository to local Subversion repository

2008-06-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SVN-Mirror - Mirror remote repository to local 
Subversion repository


https://bugzilla.redhat.com/show_bug.cgi?id=196627


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-06-06 15:00 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 196627] Review Request: perl-SVN-Mirror - Mirror remote repository to local Subversion repository

2006-06-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SVN-Mirror - Mirror remote repository to local 
Subversion repository


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196627


Bug 196627 depends on bug 196617, which changed state.

Bug 196617 Summary: Review Request: perl-File-chdir - Perl module for local 
chdir()
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196617

   What|Old Value   |New Value

 Resolution||NEXTRELEASE
 Status|ASSIGNED|CLOSED



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 196627] Review Request: perl-SVN-Mirror - Mirror remote repository to local Subversion repository

2006-06-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SVN-Mirror - Mirror remote repository to local 
Subversion repository


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196627


Bug 196627 depends on bug 196625, which changed state.

Bug 196625 Summary: Review Request: perl-SVN-Simple - a simple interface to  
subversion's editor interface
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196625

   What|Old Value   |New Value

 Resolution||NEXTRELEASE
 Status|ASSIGNED|CLOSED



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 196627] Review Request: perl-SVN-Mirror - Mirror remote repository to local Subversion repository

2006-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SVN-Mirror - Mirror remote repository to local 
Subversion repository


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196627





--- Additional Comments From [EMAIL PROTECTED]  2006-06-28 02:20 EST ---
I fixed the rpmlint warnings.

http://znark.com/fedora/perl-SVN-Mirror.spec
http://znark.com/fedora/perl-SVN-Mirror-0.68-4.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 196627] Review Request: perl-SVN-Mirror - Mirror remote repository to local Subversion repository

2006-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SVN-Mirror - Mirror remote repository to local 
Subversion repository


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196627


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 196627] Review Request: perl-SVN-Mirror - Mirror remote repository to local Subversion repository

2006-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SVN-Mirror - Mirror remote repository to local 
Subversion repository


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196627





--- Additional Comments From [EMAIL PROTECTED]  2006-06-28 15:22 EST ---
For some reason your web server thinks the specfile is text/html, which makes it
tough to read.

This package completely hangs up in mock because it waits for input.  I piped
yes n into the Makefile.PL bit and I get this far:

Cannot reliably compare non-decimal formatted versions.
Please install version.pm or Sort::Versions.
[Core Features]
- SVN::Core ...loaded. (1.3.1 = 1.0.7)
- URI::Escape   ...loaded. (3.28)
- Term::ReadKey ...loaded. (2.30)
- SVN::Simple::Edit ...loaded. (0.27)
- Date::Format  ...loaded. (2.22)
- File::chdir   ...loaded. (0.06)
- Class::Accessor   ...loaded. (0.25)
[VCP support]
- VCP   ...missing. (would need 0.9)
- Data::UUID...missing.
== Auto-install the 2 optional module(s) from CPAN? [y/N] n

The package builds and fails a pile of tests:

Failed Test   Stat Wstat Total Fail  Failed  List of Failed
---
t/2basic.t 255 6528015   26 173.33%  3-15
t/6relay.t 255 65280 9   14 155.56%  3-9
t/7copy.t  255 65280 32  66.67%  3
t/8skipto-torev.t  255 6528058  116 200.00%  1-58
2 tests skipped.
Failed 4/9 test scripts, 55.56% okay. 79/100 subtests failed, 21.00% okay.

which of course fails the build.

At this point I have to wonder whether or not you you actually tested this 
package.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 196627] Review Request: perl-SVN-Mirror - Mirror remote repository to local Subversion repository

2006-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SVN-Mirror - Mirror remote repository to local 
Subversion repository


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196627





--- Additional Comments From [EMAIL PROTECTED]  2006-06-28 17:54 EST ---
I hadn't tried it under mock.  I fixed the autoinstall and input problem by
passing the --skipdeps option to Makefile.PL.  

Spec: http://znark.com/fedora/perl-SVN-Mirror.spec
SRPMS: http://znark.com/fedora/perl-SVN-Mirror-0.68-6.src.rpm

Once that is done, it builds under mock with FC5 and all the tests pass.  Are
you using development?  I don't have rawhide mock available here at work.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 196627] Review Request: perl-SVN-Mirror - Mirror remote repository to local Subversion repository

2006-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SVN-Mirror - Mirror remote repository to local 
Subversion repository


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196627





--- Additional Comments From [EMAIL PROTECTED]  2006-06-28 19:35 EST ---
OK, indeed the test failures are gone under FC5.  Still, this is going to cause
significant trouble going forward.

I will attach a full build log with TEST_VERBOSE=1 and hopefully this will help
you.  It almost looks like the error isn't even in this module.  There are
several of these:

TypeError in method 'svn_ra_reporter2_invoke_set_path', argument 6 of type 'char
const *'

That method string doesn't match anything in the source; it looks like some
issue with some generated bindings.  Perhaps it's a subversion-perl issue?  I
suggest you work with upstream and perhaps ping fedora-perl-list.

I will review this package based on an FC5 build.  The only issue that turns up
is your manual versioned dependency for perl(SVN::Core) which conflicts with one
determined by RPM.  You'll either need to drop the manual dependency or filter
out the one RPM finds.

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* source files match upstream:
   acc9a1b4d3bf3b633892b5fe0c183266  SVN-Mirror-0.68.tar.gz
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (FC5, x86_64). (fails to build on development)
* rpmlint is silent.
X final provides and requires are sane:
   perl(SVN::Mirror) = 0.68
   perl(SVN::Mirror::Git) = 0.62
   perl(SVN::Mirror::Ra) = 0.68
   perl(SVN::Mirror::Ra::MirrorEditor)
   perl(SVN::Mirror::VCP) = 0.50
   perl-SVN-Mirror = 0.68-6.fc5
  =
   /usr/bin/perl
   perl(:MODULE_COMPAT_5.8.8)
   perl(Class::Accessor)
   perl(Date::Format)
   perl(File::Path)
   perl(File::Spec)
   perl(File::Spec::Functions)
   perl(File::Spec::Unix)
   perl(File::chdir)
   perl(Getopt::Long)
   perl(SVN::Client)
   perl(SVN::Core)
X  perl(SVN::Core) = 1.0.7
   perl(SVN::Delta)
   perl(SVN::Fs)
   perl(SVN::Mirror)
   perl(SVN::Mirror::Ra)
   perl(SVN::Ra)
   perl(SVN::Repos)
   perl(SVN::Simple::Edit)
   perl(Sys::Hostname)
   perl(Term::ReadKey)
   perl(Time::HiRes)
   perl(URI)
   perl(URI::Escape)
   perl(base)
   perl(constant)
   perl(strict)
   perl(warnings)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass (on FC5; some tests fail on development)
   All tests successful, 2 tests skipped.
   Files=9, Tests=100, 59 wallclock secs ( 9.33 cusr +  8.14 csys = 17.47 CPU)
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 196627] Review Request: perl-SVN-Mirror - Mirror remote repository to local Subversion repository

2006-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SVN-Mirror - Mirror remote repository to local 
Subversion repository


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196627





--- Additional Comments From [EMAIL PROTECTED]  2006-06-28 19:37 EST ---
Created an attachment (id=131706)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=131706action=view)
Build log from mock on rawhide.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 196627] Review Request: perl-SVN-Mirror - Mirror remote repository to local Subversion repository

2006-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SVN-Mirror - Mirror remote repository to local 
Subversion repository


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196627





--- Additional Comments From [EMAIL PROTECTED]  2006-06-28 20:57 EST ---
There haven't been any changes to subversion package on rawhide that would
explain the problem.  It is the same version and patches.

This one fixes the duplicate dependency.

Spec: http://znark.com/fedora/perl-SVN-Mirror.spec
SRPMS: http://znark.com/fedora/perl-SVN-Mirror-0.68-7.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 196627] Review Request: perl-SVN-Mirror - Mirror remote repository to local Subversion repository

2006-06-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SVN-Mirror - Mirror remote repository to local 
Subversion repository


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196627


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-06-28 21:23 EST ---
Indeed, this version fixes the duplicated dependency issue.

It really does look like the errors come from within the swig-generated bindings
but I can't figure out where.  Rawhide subversion packages are actually behind
the FC5 versions, but I went ahead and build with the old FC5 versions and the
build still went fine.

Anyway, the package is OK and hopefully the rawhide failures will be worked out
in due time. 

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 196627] Review Request: perl-SVN-Mirror - Mirror remote repository to local Subversion repository

2006-06-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SVN-Mirror - Mirror remote repository to local 
Subversion repository


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196627


[EMAIL PROTECTED] changed:

   What|Removed |Added

  BugsThisDependsOn||196617, 196625




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 196627] Review Request: perl-SVN-Mirror - Mirror remote repository to local Subversion repository

2006-06-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SVN-Mirror - Mirror remote repository to local 
Subversion repository


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196627


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||196629
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review