[Bug 196945] Review Request: python-smbpasswd - Python SMB Password Hash Generator Module

2006-07-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-smbpasswd - Python SMB Password Hash Generator 
Module


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196945


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 196945] Review Request: python-smbpasswd - Python SMB Password Hash Generator Module

2006-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-smbpasswd - Python SMB Password Hash Generator 
Module


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196945





--- Additional Comments From [EMAIL PROTECTED]  2006-07-24 11:11 EST ---
Next release:

Spec URL: http://www.herr-schmitt.de/pub/python-smbpasswd/python-smbpasswd.spec
SRPM URL:
http://www.herr-schmitt.de/pub/python-smbpasswd/python-smbpasswd-1.0.1-3.src.rpm



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 196945] Review Request: python-smbpasswd - Python SMB Password Hash Generator Module

2006-07-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-smbpasswd - Python SMB Password Hash Generator 
Module


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196945


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-07-24 11:19 EST ---
Okay, package approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 196945] Review Request: python-smbpasswd - Python SMB Password Hash Generator Module

2006-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-smbpasswd - Python SMB Password Hash Generator 
Module


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196945





--- Additional Comments From [EMAIL PROTECTED]  2006-07-23 13:47 EST ---
Next release:

Spec URL: http://www.herr-schmitt.de/pub/python-smbpasswd/python-smbpasswd.spec
SRPM URL:
http://www.herr-schmitt.de/pub/python-smbpasswd/python-smbpasswd-1.0.1-2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 196945] Review Request: python-smbpasswd - Python SMB Password Hash Generator Module

2006-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-smbpasswd - Python SMB Password Hash Generator 
Module


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196945


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-07-23 14:25 EST ---
Ok, I'll review your package.

MUST items:
 * rpmlint message:
E: python-smbpasswd-debuginfo script-without-shellbang /usr/src/debug/py-
smbpasswd-1.0.1/smbpasswd.c
   - you should change permissions of this file to 644 in %prep section
 * the package is named well
 * spec file is named well
 * License field in package spec file match the actual license (GPL)
 * spec is written in American English and is legible
 * md5sums of source used to build the package and of upstream source are
matching (0eab2c29588e32e77ce6e5d2faea7874)
 * package successfully compile on i386
 * all build dependencies is good listed (mock builds successful)
 * there is no any locales
 * package doesn't contain shared library files
 * there is no duplicate files in %files listing
 * permissions aren't set properly (rpmlint error)
 * package has a good %clean section
 * there is no .la files
 * there is no GUI applications

Thus, everything is good except for bad permissions of smbpasswd.c file.
If you fix it, I'll approve this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review