[Bug 203864] Review Request: tripwire - IDS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tripwire - IDS https://bugzilla.redhat.com/show_bug.cgi?id=203864 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 203864] Review Request: tripwire - IDS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tripwire - IDS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203864 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-12-22 06:07 EST --- Thank you, too. Good work. Remember to close this as RESOLVED NEXTRELEASE when it builds. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 203864] Review Request: tripwire - IDS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tripwire - IDS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203864 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-12-22 10:19 EST --- Build successfully in devel and FC6 branch requested -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 203864] Review Request: tripwire - IDS
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: tripwire - IDS
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203864
--- Additional Comments From [EMAIL PROTECTED] 2006-12-21 17:04 EST ---
Please remove that as well:
# Print getting started help message
if [ $1 -eq 1 ]; then
echo To configure tripwire, read:
%_docdir/%{name}-%{version}/README.Fedora
fi
I am of the opinion that any rpm console output during installation should be an
indication of either an error or a warning and other packagers agree with me.
Otherwise looks fine. It is APPROVED provided the above is done.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 203864] Review Request: tripwire - IDS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tripwire - IDS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203864 --- Additional Comments From [EMAIL PROTECTED] 2006-12-22 00:02 EST --- I've removed all output from %post and imported this package for devel/ and requested a build. You're welcome to check it out and see for yourself, and move this bug to block FE-ACCEPT. Thanks for all your time! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 203864] Review Request: tripwire - IDS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tripwire - IDS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203864 --- Additional Comments From [EMAIL PROTECTED] 2006-12-18 15:37 EST --- *ping* -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 203864] Review Request: tripwire - IDS
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: tripwire - IDS
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203864
--- Additional Comments From [EMAIL PROTECTED] 2006-11-19 15:55 EST ---
Builds fine in devel/x86_64 mock.
Some more issues:
BuildRequires: autoconf seems to be unnecessary. Was there any reason to have
it?
Could you remove that:
# Print getting started help message
if [ $1 -eq 1 ]; then
%{__cat} %_docdir/%{name}-%{version}/README.RPM
fi
from %post and (optionally) rename README.RPM to README.Fedora?
Additionally, you can change %defattr to read:
%defattr(644,root,root,755)
and remove %attr(644,root,root) from some files below.
I'm also unsure if %dir %{_var}/lib/tripwire/report should be readable by
everyone. Or maybe %{_var}/lib/tripwire, too. After all, I think only root will
be using tripwire, as it needs access to all files.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 203864] Review Request: tripwire - IDS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tripwire - IDS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203864 --- Additional Comments From [EMAIL PROTECTED] 2006-11-14 09:58 EST --- I'm here... I've just been putting my time into other FE pursuits. I'll try to address these issues tonight. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 203864] Review Request: tripwire - IDS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tripwire - IDS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203864 --- Additional Comments From [EMAIL PROTECTED] 2006-11-13 15:46 EST --- *ping* -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 203864] Review Request: tripwire - IDS
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: tripwire - IDS
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203864
--- Additional Comments From [EMAIL PROTECTED] 2006-11-01 15:30 EST ---
(?)1. package meets naming and packaging guidelines.
Release:1%{?dist}.4
This should be:
Release:4%{?dist}
2. specfile is properly named, is cleanly written and uses macros consistently.
3. dist tag is present.
4. build root is correct.
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
5. license field matches the actual license.
6. license is open source-compatible (GPL). License text included in package.
7. source files match upstream:
b371f79ac23cacc9ad40b1da76b4a0c4 tripwire-2.4.0.1-src.tar.bz2
8. latest version is being packaged.
9. BuildRequires are proper.
(?)10. package builds in mock ( ).
11. rpmlint is silent.
(?)12. final provides and requires are sane:
config(tripwire) = 2.4.0.1-1.4
tripwire = 2.4.0.1-1.4
=
config(tripwire) = 2.4.0.1-1.4
gawk
grep
gzip
libcrypto.so.6()(64bit)
libgcc_s.so.1()(64bit)
libm.so.6()(64bit)
libstdc++.so.6()(64bit)
sed
tar
What is
Requires: sed grep gzip tar gawk
needed for?
13. no shared libraries are present.
14. package is not relocatable.
15. owns the directories it creates.
16. doesn't own any directories it shouldn't.
17. no duplicates in %files.
(?)18. file permissions are appropriate.
%attr(0755,root,root) %dir %{_sysconfdir}/tripwire
possibly, this should be 0700
19. %clean is present.
20. %check is not present
(?)21. scriptlets are ok
Requires(post): sed
is missing.
Also, don't print anything in %post.
22. code, not content.
23. documentation is small, so no -docs subpackage is necessary.
24. %docs are not necessary for the proper functioning of the package.
25. no headers.
26. no pkgconfig files.
27. no libtool .la droppings.
28. not a GUI app.
29. not a web app.
Please take care of 1, 12, 18 and 21 while I build it in mock.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 203864] Review Request: tripwire - IDS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tripwire - IDS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203864 --- Additional Comments From [EMAIL PROTECTED] 2006-10-19 11:08 EST --- please don't spam the rpm installation with a cat of the README.RPM file. I'd say a note in the %description pointing the user to the /path/to/README.RPM is a fine place for that. At most, _maybe_ a one line echo of the /path/to/README.RPM... and even that doesn't really sit to well with me... IMHO! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 203864] Review Request: tripwire - IDS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tripwire - IDS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203864 --- Additional Comments From [EMAIL PROTECTED] 2006-10-17 17:47 EST --- (In reply to comment #8) [...] I've submitted a bug to upstream asking them to correct the documentation in the next release. In the mean time, is it Fedora's (and thus ours as the packagers) responsibility to fix silly things like forgetting to bump version numbers in your documentation? Obviously some quick command-line perl will do the job nicely in %pre... what is everyone's feeling on the subject? I think a packager is not obliged but he should at least poke the upstream about that. Of course sending upstream a patch is the best solution. Also, I now echo the contents of README.RPM upon package install to let users know about the next step required to initialize their tripwire database. I don't think this is the best idea, but, as long as it's non-interactive, I don't mind. I'll take this review, because I'm interested in keeping this package in Fedora. I still use it on some servers. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 203864] Review Request: tripwire - IDS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tripwire - IDS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203864 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 203864] Review Request: tripwire - IDS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tripwire - IDS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203864 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163776 |163778 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 203864] Review Request: tripwire - IDS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tripwire - IDS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203864 --- Additional Comments From [EMAIL PROTECTED] 2006-08-25 05:10 EST --- Major issue - Tripwire initialisation fails, missing twinstall.sh file: According to /etc/cron.daily/tripwire-check (and quickstart guide) you need to: Run /etc/tripwire/twinstall.sh and/or tripwire --init. - /etc/tripwire/twinstall.sh file does not exist - $ tripwire --init ### Error: File could not be opened. ### Filename: /etc/tripwire/tw.cfg ### No such file or directory ### Configuration file could not be read. ### Exiting... Minor issue - version mismatch documentation: Quickstart Guide /usr/share/doc/tripwire-2.4.0.1/quickstart.txt refers multiple times to Tripwire v2.3. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 203864] Review Request: tripwire - IDS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tripwire - IDS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203864 --- Additional Comments From [EMAIL PROTECTED] 2006-08-25 05:14 EST --- Minor issue - version mismatch documentation: Quickstart Guide /usr/share/doc/tripwire-2.4.0.1/quickstart.txt refers multiple times to Tripwire v2.3. Man pages also refer to Tripwire 2.3.1 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 203864] Review Request: tripwire - IDS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tripwire - IDS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203864 --- Additional Comments From [EMAIL PROTECTED] 2006-08-25 05:40 EST --- (In reply to comment #4) Major issue - Tripwire initialisation fails, missing twinstall.sh file: According to /etc/cron.daily/tripwire-check (and quickstart guide) you need to: Run /etc/tripwire/twinstall.sh and/or tripwire --init. Ok, I missed '/usr/share/doc/tripwire-2.4.0.1/README.RPM' which states you should run /usr/sbin/tripwire-setup-keyfiles after RPM install (in stead of /etc/tripwire/twinstall.sh). Maybe this information should be included in file /etc/cron.daily/tripwire-check as well, because it could lead to confusion with users during initialisation. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 203864] Review Request: tripwire - IDS
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: tripwire - IDS
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203864
--- Additional Comments From [EMAIL PROTECTED] 2006-08-26 01:48 EST ---
Spec URL: http://theholbrooks.org/RPMS/tripwire.spec
SRPM URL: http://theholbrooks.org/RPMS/tripwire-2.4.0.1-1.4.src.rpm
Thanks for the feedback all, I have updated all the external documentation to
reflect version 2.4, but not the internal text files (quickstart.txt) or man
pages. I've submitted a bug to upstream asking them to correct the
documentation in the next release. In the mean time, is it Fedora's (and thus
ours as the packagers) responsibility to fix silly things like forgetting to
bump version numbers in your documentation? Obviously some quick command-line
perl will do the job nicely in %pre... what is everyone's feeling on the
subject?
I have removed the %config flag from the cron script... I'm not entire sure why
it was there to begin with. rpmlint output is now nonexistent :)
Also, I now echo the contents of README.RPM upon package install to let users
know about the next step required to initialize their tripwire database.
I also now include the COMMERCIAL file as a %doc (TRADEMARK was already there)
Kyrian, I would love to have you join this package as a co-maintainer once this
gets approved for FC5/6, especially as an x86_64 sanity check and another pair
of eyes at maintaining this rarely-updated code. Are there any other differences
between this approach and the RPM that you created?
rpmlint is a quick rpm 'sanity check' utility that scans through source as well
as binary RPM files for common mistakes and guideline violations. It is usually
the first tool run by package reviewers to make sure there isn't anything
majorly wrong with a submitted package before diving in and running checks
manually. You can 'yum update rpmlint' to get it, and then run it against any
RPM. The output is usually self-explanatory ('E'rrors and 'W'arnings), and SOME
output can be justified on a per-package basis, but no complaints from rpmlint
is usually desired.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 203864] Review Request: tripwire - IDS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tripwire - IDS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203864 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-08-24 06:23 EST --- Only 1 rpmline error: $ rpmlint tripwire-2.4.0.1-1.fc6.2.i386.rpm E: tripwire executable-marked-as-config-file /etc/cron.daily/tripwire-check -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 203864] Review Request: tripwire - IDS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tripwire - IDS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203864 --- Additional Comments From [EMAIL PROTECTED] 2006-08-24 20:13 EST --- BYI, this also builds fine on x86_64. The compiler warnings are almost exclusively warning: 'class blah' has virtual functions but non-virtual destructor. I don't see anything about incompatible sizes or the like. No %check, though, and I'm not sure how I'd go about doing a quick test. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 203864] Review Request: tripwire - IDS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tripwire - IDS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203864 --- Additional Comments From [EMAIL PROTECTED] 2006-08-24 00:11 EST --- I also requested access to his SVN repository (he houses the code outside of sourceforge), or if there's even anything in there worth having, so we could possibly pacakge newer SVN code without an official release. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
