Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: bison
https://bugzilla.redhat.com/show_bug.cgi?id=225616
[EMAIL PROTECTED] changed:
What|Removed |Added
Severity|normal |medium
Priority|normal |medium
Product|Fedora Extras |Fedora
Version|devel |rawhide
[EMAIL PROTECTED] changed:
What|Removed |Added
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
Status|NEW |ASSIGNED
Flag||fedora-review?
--- Additional Comments From [EMAIL PROTECTED] 2008-02-06 11:48 EST ---
rpmlint on srpm:
bison.src:148: W: macro-in-%changelog defattr
Macros are expanded in %changelog too, which can in unfortunate cases lead
to the package not building at all, or other subtle unexpected conditions that
affect the build. Even when that doesn't happen, the expansion results in
possibly rewriting history on subsequent package revisions and generally
odd entries eg. in source rpms, which is rarely wanted. Avoid use of macros
in %changelog altogether, or use two '%'s to escape them, like '%%foo'.
bison.src: W: summary-ended-with-dot A GNU general-purpose parser generator.
Summary ends with a dot.
Fix.
rpmlint on rpms:
bison.i386: W: devel-file-in-non-devel-package /usr/share/bison/yacc.c
A development file (usually source code) is located in a non-devel
package. If you want to include source code in your package, be sure to
create a development package.
bison.i386: W: devel-file-in-non-devel-package /usr/share/bison/glr.c
A development file (usually source code) is located in a non-devel
package. If you want to include source code in your package, be sure to
create a development package.
bison-devel.i386: W: no-documentation
The package contains no documentation (README, doc, etc).
You have to include documentation files.
bison-runtime.i386: W: no-documentation
The package contains no documentation (README, doc, etc).
You have to include documentation files.
Fix or explain in spec.
Is the .a necessary, and if so, why in -devel, not in -static?
Otherwise, looks great, no other blockers.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
