[Bug 225634] Merge Review: cadaver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: cadaver https://bugzilla.redhat.com/show_bug.cgi?id=225634 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Additional Comments From [EMAIL PROTECTED] 2007-09-25 05:34 EST --- Ah, the Not built thing is a cosmetic configure script bug, I've fixed it upstream. --enable-nls is in fact the default but being explicit here is good since the upstream default has changed over time here. Thanks again for the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225634] Merge Review: cadaver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: cadaver https://bugzilla.redhat.com/show_bug.cgi?id=225634 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2007-09-24 09:52 EST --- Good catch, the %makinstall, I've often missed it in my own spec files :-/ Everything looks good, except maybe the NLS : Passing --enable-nls doesn't change anything, and configure always reports Internationalization: Not built. I'm not sure why since a quick look seems to indicate that the messages about having NLS enabled should lead to Internationalization being enabled. Anyway, this isn't vital, and not review specific, so feel free to have a look and close the bug, but I'll fedora-review + anyway. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225634] Merge Review: cadaver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: cadaver https://bugzilla.redhat.com/show_bug.cgi?id=225634 --- Additional Comments From [EMAIL PROTECTED] 2007-09-13 02:34 EST --- Thanks for the review! - Remove the zero epoch from the neon-devel BR Fixed. - Include a quick comment as to why pie is needed It's not needed, it's a feature, I don't think that explaining what -pie is in every spec file which uses it is really a good idea. - Change %defattr(-,root,root) to the more usual %defattr(-,root,root,-) (pretty useless, though, since the package doesn't include directories) Fixed. - Move the %doc line up so that it isn't in between two normal lines And fixed. In -2. Also fixed the use of %makeinstall, which is now unnecessary in 0.23.0. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225634] Merge Review: cadaver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: cadaver https://bugzilla.redhat.com/show_bug.cgi?id=225634 --- Additional Comments From [EMAIL PROTECTED] 2007-09-12 07:23 EST --- Test build went fine, resulting binary is fine. You could remove the obsolete cadaver-0.22.5.tar.gz.asc from CVS, though. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225634] Merge Review: cadaver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: cadaver https://bugzilla.redhat.com/show_bug.cgi?id=225634 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2007-09-01 14:01 EST --- The current package looks already quite good. A few minor possible spec file changes : - Remove the zero epoch from the neon-devel BR - Include a quick comment as to why pie is needed - Change %defattr(-,root,root) to the more usual %defattr(-,root,root,-) (pretty useless, though, since the package doesn't include directories) - Move the %doc line up so that it isn't in between two normal lines I'll test a build and post the results. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
