[Bug 226333] Merge Review: pygtk2 (stalled)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: pygtk2 (stalled) https://bugzilla.redhat.com/show_bug.cgi?id=226333 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|MODIFIED|ASSIGNED Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2008-02-06 08:20 EST --- I will revies this one -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226333] Merge Review: pygtk2 (stalled)
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: pygtk2 (stalled)
https://bugzilla.redhat.com/show_bug.cgi?id=226333
--- Additional Comments From [EMAIL PROTECTED] 2008-02-06 08:40 EST ---
Source: should be
http://ftp.gnome.org/pub/GNOME/sources/pygtk/2.12/pygtk-%{version}.tar.bz2
to make it easier to see where the upstream source comes from.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226333] Merge Review: pygtk2 (stalled)
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: pygtk2 (stalled)
https://bugzilla.redhat.com/show_bug.cgi?id=226333
--- Additional Comments From [EMAIL PROTECTED] 2008-02-06 09:05 EST ---
MUST:
* Package is matching naming guidelines.
* spec file in named %{name}.spec
* it is legal for Fedora to distribute this
* license field matches the actual license.
* license is open source-compatible have the right good license shortname :
LGPLv2+
* License file must be in %doc (it it exists)
* Spec file is written in American English
* Spec file is legible.
* Sources match upstream.
MD5SUM:
a816346d750d61e3fa67a200e4292694
http://ftp.gnome.org/pub/GNOME/sources/pygtk/2.12/pygtk-2.12.1.tar.bz2
a816346d750d61e3fa67a200e4292694 pygtk-2.12.1.tar.bz2
* summary and description fine
* correct buildroot
* %{?dist} is used
* license text included in package and marked with %doc
* package meets FHS (http://www.pathname.com/fhs/)
* changelog format fine
* Packager/Vendor/Distribution/Copyright tags not used
* Summary tag does not end in a period
* Package compiles and build into RPM's on : i386 etc.
* no Exclude Arch
* BuildRequires for all build requerements (- the ones on the Exception list)
* no locales
* no shared libs
* Package own all created directories.
* No duplicate files in %files
* Every %files section includes a %defattr(...) line
* Package has a %clean with a rm -rf %{buildroot} or $RPM_BUILD_ROOT
* consistently use of macros
* Package contains code or or permissable content.
* Large documentation files goes into -doc subpackage.
* files in %doc dont affect runtime.
* header files goes into -devel subpackage
* no static libs
* package has pkgconfig (.pc) files and has a 'Requires: pkgconfig'
* -devel subpackage has a 'Requires: %{name} = %{version}-%{release}'
* *.la libtool archives are removed in spec (if available)
* not a gui application
* package don't own files and dirs owned by other packages.
* %install starts with an rm -rf %{buildroot}
* rpm package filenames is in valid UTF-8.
* no Rpath
* no config files
* no init scripts
* no %makeinstall used
* no Requires(pre,post)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226333] Merge Review: pygtk2 (stalled)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: pygtk2 (stalled) https://bugzilla.redhat.com/show_bug.cgi?id=226333 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-02-06 09:22 EST --- rpmlint output: $ rpmlint pygtk2-2.12.1-3.fc9.i386.rpm pygtk2.i386: E: wrong-script-interpreter /usr/share/doc/pygtk2-2.12.1/examples/pygtk-demo/pygtk-demo.in @PYTHON@ pygtk2.i386: E: non-executable-script /usr/lib/pygtk/2.0/demos/stock_browser.py 0644 pygtk2.i386: E: non-executable-script /usr/lib/pygtk/2.0/demos/dnd.py 0644 pygtk2.i386: E: non-executable-script /usr/lib/pygtk/2.0/demos/ui_manager.py 0644 pygtk2.i386: E: non-executable-script /usr/lib/pygtk/2.0/demos/statusicon.py 0644 pygtk2.i386: E: non-executable-script /usr/lib/pygtk/2.0/demos/images.py 0644 pygtk2.i386: E: non-executable-script /usr/lib/pygtk/2.0/demos/buttonbox.py 0644 pygtk2.i386: E: non-executable-script /usr/lib/pygtk/2.0/demos/sizegroup.py 0644 pygtk2.i386: E: non-executable-script /usr/lib/pygtk/2.0/demos/hypertext.py 0644 pygtk2.i386: E: non-executable-script /usr/lib/pygtk/2.0/demos/list_store.py 0644 pygtk2.i386: E: non-executable-script /usr/lib/pygtk/2.0/demos/changedisplay.py 0644 pygtk2.i386: E: non-executable-script /usr/lib/pygtk/2.0/demos/textview.py 0644 pygtk2.i386: E: non-executable-script /usr/lib/pygtk/2.0/demos/dialogs.py 0644 pygtk2.i386: E: non-executable-script /usr/lib/pygtk/2.0/demos/menu.py 0644 pygtk2.i386: E: non-executable-script /usr/lib/pygtk/2.0/pygtk-demo.py 0644 pygtk2.i386: E: non-executable-script /usr/lib/pygtk/2.0/demos/tree_store.py 0644 pygtk2.i386: E: non-executable-script /usr/lib/pygtk/2.0/demos/panes.py 0644 pygtk2.i386: E: non-executable-script /usr/lib/pygtk/2.0/demos/expander.py 0644 pygtk2.i386: E: non-executable-script /usr/lib/pygtk/2.0/demos/pixbufs.py 0644 pygtk2.i386: E: non-executable-script /usr/lib/pygtk/2.0/demos/appwindow.py 0644 pygtk2.i386: E: non-executable-script /usr/lib/pygtk/2.0/demos/editable_cells.py 0644 pygtk2.i386: E: non-executable-script /usr/lib/pygtk/2.0/demos/colorsel.py 0644 pygtk2.i386: W: file-not-utf8 /usr/share/doc/pygtk2-2.12.1/NEWS pygtk2.i386: E: non-executable-script /usr/lib/pygtk/2.0/demos/entry_completion.py 0644 pygtk2.i386: E: non-executable-script /usr/lib/pygtk/2.0/demos/treemodel.py 0644 pygtk2.i386: W: doc-file-dependency /usr/share/doc/pygtk2-2.12.1/examples/ide/browse.py /usr/bin/env pygtk2.i386: W: doc-file-dependency /usr/share/doc/pygtk2-2.12.1/examples/ide/gtkcons.py /usr/bin/env pygtk2.i386: W: doc-file-dependency /usr/share/doc/pygtk2-2.12.1/examples/ide/gtkdb.py /usr/bin/env pygtk2.i386: W: doc-file-dependency /usr/share/doc/pygtk2-2.12.1/examples/ide/gtkprof.py /usr/bin/env pygtk2.i386: W: doc-file-dependency /usr/share/doc/pygtk2-2.12.1/examples/ide/pyide.py /usr/bin/env pygtk2.i386: W: doc-file-dependency /usr/share/doc/pygtk2-2.12.1/examples/simple/hello.py /usr/bin/env pygtk2.i386: W: doc-file-dependency /usr/share/doc/pygtk2-2.12.1/examples/simple/scribble.py /usr/bin/env pygtk2.i386: W: doc-file-dependency /usr/share/doc/pygtk2-2.12.1/examples/simple/simple.py /usr/bin/env pygtk2.i386: W: doc-file-dependency /usr/share/doc/pygtk2-2.12.1/examples/simple/tooltip.py /usr/bin/env $ rpmlint pygtk2-devel-2.12.1-3.fc9.i386.rpm pygtk2-devel.i386: W: no-documentation $ rpmlint pygtk2-libglade-2.12.1-3.fc9.i386.rpm pygtk2-libglade.i386: W: no-documentation $ rpmlint pygtk2-doc-2.12.1-3.fc9.i386.rpm $ rpmlint pygtk2-2.12.1-3.fc9.src.rpm nothing dangerous in these messages, i think they can be ignored. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226333] Merge Review: pygtk2 (stalled)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: pygtk2 (stalled) https://bugzilla.redhat.com/show_bug.cgi?id=226333 [EMAIL PROTECTED] changed: What|Removed |Added Version|f7 |7 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Merge Review: pygtk2|Merge Review: pygtk2 ||(stalled) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
