[Bug 226422] Merge Review: slrn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: slrn https://bugzilla.redhat.com/show_bug.cgi?id=226422 --- Additional Comments From [EMAIL PROTECTED] 2008-01-31 06:38 EST --- Source URL fixed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226422] Merge Review: slrn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: slrn https://bugzilla.redhat.com/show_bug.cgi?id=226422 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226422] Merge Review: slrn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: slrn https://bugzilla.redhat.com/show_bug.cgi?id=226422 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-01-31 07:31 EST --- thanks for CVS update. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226422] Merge Review: slrn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: slrn https://bugzilla.redhat.com/show_bug.cgi?id=226422 --- Additional Comments From [EMAIL PROTECTED] 2008-01-30 09:12 EST --- Committed to CVS. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226422] Merge Review: slrn
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: slrn
https://bugzilla.redhat.com/show_bug.cgi?id=226422
--- Additional Comments From [EMAIL PROTECTED] 2008-01-30 23:30 EST ---
Thanks for update.
Now rpmlint only have message
slrn-pull.i386: E: non-standard-dir-perm /var/spool/slrnpull 0775
slrn-pull.i386: E: non-standard-dir-perm /var/spool/slrnpull/out.going 03777
MUST:
Sorry. I missed this = Source URL should be
http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.bz2
Look more on it at http://fedoraproject.org/wiki/Packaging/SourceURL
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226422] Merge Review: slrn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: slrn https://bugzilla.redhat.com/show_bug.cgi?id=226422 --- Additional Comments From [EMAIL PROTECTED] 2008-01-29 07:27 EST --- (In reply to comment #5) Ok, converting the changelog and renaming the logrotate file is easy. Ok. As for the permissions, I'm not really sure. - /var/spool/slrnpull needs to be writable by news group. Good to keep it then. - /usr/bin/slrnpull doesn't seem to need the setgid (it's supposed to be executed under user news). 755 should be enough and it will also allow users to run slrnpull. I leave this upto you. - /var/spool/slrnpull/out.going needs to be writable by users allowed to post articles which is now everyone. The directory needs to have setgid news to allow slrnpull to remove the files. Good to keep it then. When you update CVS, do comment here for review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226422] Merge Review: slrn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: slrn https://bugzilla.redhat.com/show_bug.cgi?id=226422 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|ASSIGNED Flag|needinfo?([EMAIL PROTECTED]| |m) | --- Additional Comments From [EMAIL PROTECTED] 2008-01-28 10:28 EST --- Ok, converting the changelog and renaming the logrotate file is easy. As for the permissions, I'm not really sure. - /var/spool/slrnpull needs to be writable by news group. - /usr/bin/slrnpull doesn't seem to need the setgid (it's supposed to be executed under user news). 755 should be enough and it will also allow users to run slrnpull. - /var/spool/slrnpull/out.going needs to be writable by users allowed to post articles which is now everyone. The directory needs to have setgid news to allow slrnpull to remove the files. Suggestions? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226422] Merge Review: slrn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: slrn https://bugzilla.redhat.com/show_bug.cgi?id=226422 --- Additional Comments From [EMAIL PROTECTED] 2008-01-27 09:32 EST --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226422] Merge Review: slrn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: slrn https://bugzilla.redhat.com/show_bug.cgi?id=226422 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|NEEDINFO Flag||needinfo?([EMAIL PROTECTED] ||m) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226422] Merge Review: slrn
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: slrn
https://bugzilla.redhat.com/show_bug.cgi?id=226422
[EMAIL PROTECTED] changed:
What|Removed |Added
Severity|normal |medium
Priority|normal |medium
Product|Fedora Extras |Fedora
Version|devel |rawhide
[EMAIL PROTECTED] changed:
What|Removed |Added
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
Status|NEW |ASSIGNED
Flag||fedora-review?
--- Additional Comments From [EMAIL PROTECTED] 2008-01-15 07:34 EST ---
1)good to have requires for -pull in following format
- MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}
rest packaging looks ok.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226422] Merge Review: slrn
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: slrn
https://bugzilla.redhat.com/show_bug.cgi?id=226422
--- Additional Comments From [EMAIL PROTECTED] 2008-01-15 11:58 EST ---
Ok, slrn-pull-0.9.8.1pl1-6.20070716cvs.fc9 has %{version}-%{release} in the
requirement.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226422] Merge Review: slrn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: slrn https://bugzilla.redhat.com/show_bug.cgi?id=226422 --- Additional Comments From [EMAIL PROTECTED] 2008-01-15 23:02 EST --- Packaging looks ok now. rpmlint gave me slrn.i386: W: file-not-utf8 /usr/share/doc/slrn-0.9.8.1pl1/changes.txt The character encoding of this file is not UTF-8. Consider converting it in the specfile for example using iconv(1). == This must be fixed. You can do this in next release. slrn-pull.i386: E: non-standard-dir-perm /var/spool/slrnpull 0775 A standard directory should have permission set to 0755. If you get this message, it means that you have wrong directory permissions in some dirs included in your package. slrn-pull.i386: E: incoherent-logrotate-file /etc/logrotate.d/slrnpull Your logrotate file should be named /etc/logrotate.d/package name. slrn-pull.i386: E: setgid-binary /usr/bin/slrnpull news 02750 The file is setgid. Usually this is a packaging bug. If this is a game, then, you should use the proper rpm group, or location. slrn-pull.i386: E: non-standard-executable-perm /usr/bin/slrnpull 02750 A standard executable should have permission set to 0755. If you get this message, it means that you have a wrong executable permissions in some files included in your package. slrn-pull.i386: E: non-standard-executable-perm /usr/bin/slrnpull 02750 A standard executable should have permission set to 0755. If you get this message, it means that you have a wrong executable permissions in some files included in your package. slrn-pull.i386: E: non-standard-dir-perm /var/spool/slrnpull/out.going 03777 A standard directory should have permission set to 0755. If you get this message, it means that you have wrong directory permissions in some dirs included in your package. == are those needed for this package? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
