[Bug 430939] Review Request: desktop-data-model - Engine for communicating with Online Desktop Data Model
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: desktop-data-model - Engine for communicating with Online Desktop Data Model https://bugzilla.redhat.com/show_bug.cgi?id=430939 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 430939] Review Request: desktop-data-model - Engine for communicating with Online Desktop Data Model
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: desktop-data-model - Engine for communicating with Online Desktop Data Model https://bugzilla.redhat.com/show_bug.cgi?id=430939 --- Additional Comments From [EMAIL PROTECTED] 2008-02-25 15:09 EST --- Ok, these fixes are now applied: http://cdn.verbum.org/desktop-data-model.spec http://cdn.verbum.org/desktop-data-model-1.2.0-1.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 430939] Review Request: desktop-data-model - Engine for communicating with Online Desktop Data Model
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: desktop-data-model - Engine for communicating with Online Desktop Data Model https://bugzilla.redhat.com/show_bug.cgi?id=430939 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 430939] Review Request: desktop-data-model - Engine for communicating with Online Desktop Data Model
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: desktop-data-model - Engine for communicating with Online Desktop Data Model https://bugzilla.redhat.com/show_bug.cgi?id=430939 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-02-25 16:27 EST --- New Package CVS Request === Package Name: desktop-data-model Short Description: Engine providing live updates of online data to the desktop Owners: [EMAIL PROTECTED],[EMAIL PROTECTED] Branches: F-8 EL-5 InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 430939] Review Request: desktop-data-model - Engine for communicating with Online Desktop Data Model
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: desktop-data-model - Engine for communicating with Online Desktop Data Model https://bugzilla.redhat.com/show_bug.cgi?id=430939 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-02-25 16:43 EST --- Please use fedora account names in Owners? cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 430939] Review Request: desktop-data-model - Engine for communicating with Online Desktop Data Model
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: desktop-data-model - Engine for communicating with Online Desktop Data Model https://bugzilla.redhat.com/show_bug.cgi?id=430939 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2008-02-13 11:29 EST --- Taking the review -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 430939] Review Request: desktop-data-model - Engine for communicating with Online Desktop Data Model
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: desktop-data-model - Engine for communicating with
Online Desktop Data Model
https://bugzilla.redhat.com/show_bug.cgi?id=430939
--- Additional Comments From [EMAIL PROTECTED] 2008-02-13 12:08 EST ---
rpmlint output was empty.
What I found going through the package review guidelines and reading the
spec file:
* UPSTREAM: license needs to be fixed to LGPL (at least for libddm)
* UPSTREAM: should have a real tagged and released to gnome.org tarball before
this goes into rawhide.
* Group: Applications/Internet. Not an application. Maybe 'System
Environment/Libraries'?
* Summary: and %description need improvement
Suggestion:
Summary: Engine providing live updates of online data to the desktop
%description
desktop-data-model provides an engine and client library that allow
desktop applications to retrieve data from the online.gnome.org server
and elsewhere and get updates when the data changes. This allows
creating applications that provide a live display of information
from the Internet.
* The Requires on GConf for the scriptlets aren't needed.
* The handling of the 'version' file isn't ideal ... the version file is used
to do an auto-restart of the desktop-data-engine when a new version is installed
on the system, so shouldn't be changed until after all the other files are
installed. In mugshot.spec we have:
%post
[...]
echo %{version} %{_datadir}/mugshot/version
%files
%ghost %{_datadir}/mugshot/version
* the -devel package should Requires: pkgconfig for directory ownership.
* The Requires on dbus-devel for the -devel subpackage isn't needed.
* The devel package shjould require the main package
Requires: %{name} = %{version}-%{release}
* The %postun should be changed to '%postun -p /sbin/ldconfig' to avoid an
unnecessary shell invocation (the %post would take the same change, but the
version change above will add a second line to it.)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 430939] Review Request: desktop-data-model - Engine for communicating with Online Desktop Data Model
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: desktop-data-model - Engine for communicating with Online Desktop Data Model https://bugzilla.redhat.com/show_bug.cgi?id=430939 --- Additional Comments From [EMAIL PROTECTED] 2008-02-04 12:36 EST --- Missing a BR, fixed now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 430939] Review Request: desktop-data-model - Engine for communicating with Online Desktop Data Model
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: desktop-data-model - Engine for communicating with Online Desktop Data Model https://bugzilla.redhat.com/show_bug.cgi?id=430939 --- Additional Comments From [EMAIL PROTECTED] 2008-02-02 18:25 EST --- This failed to build in mock (x86_64, rawhide): gcc -o .libs/desktop-data-engine desktop_data_engine-hippo-application-monitor.o desktop_data_engine-hippo-cookies-linux.o desktop_data_engine-hippo-distribution.o desktop_data_engine-hippo-dbus-cookies.o desktop_data_engine-hippo-dbus-helper.o desktop_data_engine-hippo-dbus-im-client.o desktop_data_engine-hippo-dbus-local.o desktop_data_engine-hippo-dbus-model.o desktop_data_engine-hippo-dbus-model-client.o desktop_data_engine-hippo-dbus-pidgin.o desktop_data_engine-hippo-dbus-server.o desktop_data_engine-hippo-dbus-settings.o desktop_data_engine-hippo-dbus-system.o desktop_data_engine-hippo-dbus-web.o desktop_data_engine-hippo-im.o desktop_data_engine-hippo-platform-impl.o desktop_data_engine-main.o desktop_data_engine-json.o -pthread ./.libs/libhippo.a -L/lib64 ./.libs/libengine.a -lpcre -lsqlite3 /builddir/build/BUILD/desktop-data-model-1.2.0/.libs/libddm-1.so -lloudmouth-1 -lidn -ldbus-glib-1 -ldbus-1 -lgnome-desktop-2 -lgnomeui-2 -lSM -lICE -lstartup-notification-1 -lbonoboui-2 -lgnomevfs-2 -lgnomecanvas-2 -lgnome-2 -lpopt -lbonobo-2 -lbonobo-activation -lORBit-2 -lart_lgpl_2 -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -lpangocairo-1.0 -lpango-1.0 -lcairo -lgconf-2 -lgthread-2.0 -lrt -lgmodule-2.0 -ldl -lgobject-2.0 -lglib-2.0 -lresolv desktop_data_engine-hippo-application-monitor.o: In function `poll_for_idleness': hippo-application-monitor.c:(.text+0x727): undefined reference to `XScreenSaverQueryInfo' desktop_data_engine-hippo-application-monitor.o: In function `hippo_application_monitor_add': hippo-application-monitor.c:(.text+0x84f): undefined reference to `XScreenSaverQueryExtension' hippo-application-monitor.c:(.text+0x8b4): undefined reference to `XScreenSaverAllocInfo' collect2: ld returned 1 exit status make[1]: *** [desktop-data-engine] Error 1 make[1]: Leaving directory `/builddir/build/BUILD/desktop-data-model-1.2.0' make: *** [all] Error 2 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 430939] Review Request: desktop-data-model - Engine for communicating with Online Desktop Data Model
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: desktop-data-model - Engine for communicating with Online Desktop Data Model https://bugzilla.redhat.com/show_bug.cgi?id=430939 --- Additional Comments From [EMAIL PROTECTED] 2008-01-30 13:35 EST --- SRPM URL: http://cdn.verbum.org/desktop-data-model-1.2.0-1.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
