[Bug 431534] Review Request: gfeed - RSS feed reader

2008-02-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gfeed - RSS feed reader


https://bugzilla.redhat.com/show_bug.cgi?id=431534


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2008-02-07 04:26 EST ---
Imported and built. Thanks again for review!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431534] Review Request: gfeed - RSS feed reader

2008-02-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gfeed - RSS feed reader


https://bugzilla.redhat.com/show_bug.cgi?id=431534





--- Additional Comments From [EMAIL PROTECTED]  2008-02-06 04:48 EST ---
Fixed
Spec URL: http://kurzawa.nonlogic.org/rpm/gfeed/gfeed.spec
SRPM URL: http://kurzawa.nonlogic.org/rpm/gfeed/gfeed-2.5.0-3.fc8.src.rpm

P.S If you have time could you also review taskcoach (#430541)?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431534] Review Request: gfeed - RSS feed reader

2008-02-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gfeed - RSS feed reader


https://bugzilla.redhat.com/show_bug.cgi?id=431534


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-02-06 05:38 EST ---
Review:
+ package builds in mock (rawhide i386).
koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=398563
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
5301287f336599ab77ccba4875993734  gfeed-2.5.0.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags are honored correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431534] Review Request: gfeed - RSS feed reader

2008-02-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gfeed - RSS feed reader


https://bugzilla.redhat.com/show_bug.cgi?id=431534


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-02-06 05:46 EST ---
New Package CVS Request
===
Package Name: gfeed
Short Description: RSS feed reader
Owners: kurzawa
Branches: F-7 F-8
InitialCC:
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431534] Review Request: gfeed - RSS feed reader

2008-02-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gfeed - RSS feed reader


https://bugzilla.redhat.com/show_bug.cgi?id=431534


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-02-06 12:34 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431534] Review Request: gfeed - RSS feed reader

2008-02-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gfeed - RSS feed reader


https://bugzilla.redhat.com/show_bug.cgi?id=431534





--- Additional Comments From [EMAIL PROTECTED]  2008-02-05 06:32 EST ---

 URL:http://sourceforge.net/projects/%{name} is better

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431534] Review Request: gfeed - RSS feed reader

2008-02-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gfeed - RSS feed reader


https://bugzilla.redhat.com/show_bug.cgi?id=431534





--- Additional Comments From [EMAIL PROTECTED]  2008-02-05 06:38 EST ---
Fixed
Spec URL: http://kurzawa.nonlogic.org/rpm/gfeed/gfeed.spec
SRPM URL: http://kurzawa.nonlogic.org/rpm/gfeed/gfeed-2.5.0-2.fc8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431534] Review Request: gfeed - RSS feed reader

2008-02-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gfeed - RSS feed reader


https://bugzilla.redhat.com/show_bug.cgi?id=431534


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431534] Review Request: gfeed - RSS feed reader

2008-02-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gfeed - RSS feed reader


https://bugzilla.redhat.com/show_bug.cgi?id=431534





--- Additional Comments From [EMAIL PROTECTED]  2008-02-05 07:41 EST ---
Is icon working for you? I installed rpm and when tried to run gfeed I got
options help only.

will review this by tomorrow.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431534] Review Request: gfeed - RSS feed reader

2008-02-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gfeed - RSS feed reader


https://bugzilla.redhat.com/show_bug.cgi?id=431534





--- Additional Comments From [EMAIL PROTECTED]  2008-02-05 09:00 EST ---
Yes icon is working. If you wrote example: gfeed -f http://linux.pl/rss.php;,
new windows will open and icon will show.

Thanks in advance for review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431534] Review Request: gfeed - RSS feed reader

2008-02-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gfeed - RSS feed reader


https://bugzilla.redhat.com/show_bug.cgi?id=431534





--- Additional Comments From [EMAIL PROTECTED]  2008-02-06 00:54 EST ---
SHOULD:
   1)Change %{__install} to install 
   2)Add doc/out/html/*.html and scripts. But to avoid unnecessary installations
of Makefiles in scripts directory, you can add following line to end of %install
section

rm -f scripts/Makefile*

and change %doc to
%doc AUTHORS CHANGELOG COPYING README doc/out/html/*.html scripts




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review