[Bug 454011] Review Request: tcl-snack - Sound toolkit

2008-09-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454011


Mikhail Kalenkov [EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Comment #18 from Mikhail Kalenkov [EMAIL PROTECTED]  2008-09-21 12:48:12 
EDT ---
I didn't find tcl-snack component in Bugzilla. Is it normal?

It seems to me that tcl-snack module doesn't work.

[EMAIL PROTECTED] ~]$ tclsh
% package require snack 2.2
couldn't load file /usr/lib/tcl8.5/snack2.2/libsnack.so:
/usr/lib/tcl8.5/snack2.2/libsnack.so: undefined symbol: _snd_pcm_mmap_hw_ptr
% 

[EMAIL PROTECTED] ~]$ LANG=C; rpm -qi tcl-snack
Name: tcl-snackRelocations: (not relocatable)
Version : 2.2.10Vendor: Fedora Project
Release : 2.fc9 Build Date: Sat Sep 13 06:17:58
2008
Install Date: Sun Sep 21 19:43:22 2008 Build Host:
x86-5.fedora.phx.redhat.com
Group   : System Environment/Libraries   Source RPM:
tcl-snack-2.2.10-2.fc9.src.rpm
Size: 740007   License: GPLv2+
Signature   : DSA/SHA1, Tue Sep 16 00:14:20 2008, Key ID 62aec3dc6df2196f
Packager: Fedora Project
URL : http://www.speech.kth.se/snack/
Summary : Sound toolkit

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454011] Review Request: tcl-snack - Sound toolkit

2008-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454011


Fedora Update System [EMAIL PROTECTED] changed:

   What|Removed |Added

 Resolution|RAWHIDE |NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454011] Review Request: tcl-snack - Sound toolkit

2008-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454011





--- Comment #16 from Fedora Update System [EMAIL PROTECTED]  2008-09-16 
19:24:27 EDT ---
tcl-snack-2.2.10-2.fc8 has been pushed to the Fedora 8 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454011] Review Request: tcl-snack - Sound toolkit

2008-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454011





--- Comment #17 from Fedora Update System [EMAIL PROTECTED]  2008-09-16 
19:30:21 EDT ---
tcl-snack-2.2.10-2.fc9 has been pushed to the Fedora 9 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454011] Review Request: tcl-snack - Sound toolkit

2008-09-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454011





--- Comment #14 from Fedora Update System [EMAIL PROTECTED]  2008-09-13 
09:12:47 EDT ---
tcl-snack-2.2.10-2.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/tcl-snack-2.2.10-2.fc9

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454011] Review Request: tcl-snack - Sound toolkit

2008-09-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454011


Tom spot Callaway [EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




--- Comment #15 from Tom spot Callaway [EMAIL PROTECTED]  2008-09-13 
09:13:33 EDT ---
Built in rawhide too.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454011] Review Request: tcl-snack - Sound toolkit

2008-08-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454011





--- Comment #11 from Marcela Maslanova [EMAIL PROTECTED]  2008-08-05 02:52:05 
EDT ---
- build in koji OK

Everything pass.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454011] Review Request: tcl-snack - Sound toolkit

2008-08-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454011


Marcela Maslanova [EMAIL PROTECTED] changed:

   What|Removed |Added

Customer Facing||---




--- Comment #9 from Marcela Maslanova [EMAIL PROTECTED]  2008-08-04 04:18:44 
EDT ---
I don't know why, but it's still can't be built in koji
http://koji.fedoraproject.org/koji/getfile?taskID=756612name=build.log

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454011] Review Request: tcl-snack - Sound toolkit

2008-08-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454011





--- Comment #10 from Tom spot Callaway [EMAIL PROTECTED]  2008-08-04 
11:32:18 EDT ---
OK, I fixed this by adding: BuildRequires: python-devel

Successful scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=757252

New SRPM:
http://www.auroralinux.org/people/spot/review/new/tcl-snack-2.2.10-2.fc10.src.rpm
New SPEC: http://www.auroralinux.org/people/spot/review/new/tcl-snack.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454011] Review Request: tcl-snack - Sound toolkit

2008-08-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tcl-snack - Sound toolkit


https://bugzilla.redhat.com/show_bug.cgi?id=454011





--- Additional Comments From [EMAIL PROTECTED]  2008-08-01 06:42 EST ---
Looks like someone broke rawhide :(
http://koji.fedoraproject.org/koji/getfile?taskID=752263name=build.log

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454011] Review Request: tcl-snack - Sound toolkit

2008-07-31 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tcl-snack - Sound toolkit


https://bugzilla.redhat.com/show_bug.cgi?id=454011


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-07-31 02:20 EST ---
Ok.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454011] Review Request: tcl-snack - Sound toolkit

2008-07-31 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tcl-snack - Sound toolkit


https://bugzilla.redhat.com/show_bug.cgi?id=454011


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review+  |fedora-review?




--- Additional Comments From [EMAIL PROTECTED]  2008-07-31 10:11 EST ---
Not that I'm complaining here, but could you do a bit more of a review than
Ok. I mean, I'm sure my package is perfect and all... :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454011] Review Request: tcl-snack - Sound toolkit

2008-07-31 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tcl-snack - Sound toolkit


https://bugzilla.redhat.com/show_bug.cgi?id=454011





--- Additional Comments From [EMAIL PROTECTED]  2008-07-31 10:13 EST ---
For example, look at:

http://fedoraproject.org/wiki/TillMaas/ReviewChecklist
or
http://fedoraproject.org/wiki/SpotsReviewCheatSheet

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454011] Review Request: tcl-snack - Sound toolkit

2008-07-31 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tcl-snack - Sound toolkit


https://bugzilla.redhat.com/show_bug.cgi?id=454011





--- Additional Comments From [EMAIL PROTECTED]  2008-07-31 10:38 EST ---
- rpmlint checks return: Nothing - OK

- package meets naming guidelines OK
- package meets packaging guidelines OK
- license (GPLv2+) OK, text in %doc, matches source OK
- spec file legible, in am. english - it looks OK for me ;-)
- source matches upstream - don't match, because mp3 support was cut - OK
- package compiles on devel (x86) - broken koji :(
- no missing BR OK
- no unnecessary BR OK
- no locales OK
- not relocatable OK
- owns all directories that it creates OK
- no duplicate files OK
- permissions ok OK
- %clean ok OK
- macro use consistent OK
- code, not content OK
- no need for -docs - not needed OK
- nothing in %doc affects runtime OK
- no need for .desktop file OK


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454011] Review Request: tcl-snack - Sound toolkit

2008-07-31 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tcl-snack - Sound toolkit


https://bugzilla.redhat.com/show_bug.cgi?id=454011





--- Additional Comments From [EMAIL PROTECTED]  2008-07-31 10:41 EST ---
Hehe, I read and check this list
https://fedoraproject.org/wiki/Packaging/ReviewGuidelines but it's too long to
copy here. 

Now I don't know if I built it on koji or not, so wait till yesterday. Hopefully
it will be working.

btw your package should be perfect you wrote the guidelines ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454011] Review Request: tcl-snack - Sound toolkit

2008-07-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tcl-snack - Sound toolkit


https://bugzilla.redhat.com/show_bug.cgi?id=454011


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED




--- Additional Comments From [EMAIL PROTECTED]  2008-07-30 08:33 EST ---
Mp3 was removed from code, so I'm ok with that.

Licence: if you start changing source files, couldn't be removed BSD.txt file?
Whole source is under GPLv2 anyway.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454011] Review Request: tcl-snack - Sound toolkit

2008-07-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tcl-snack - Sound toolkit


https://bugzilla.redhat.com/show_bug.cgi?id=454011





--- Additional Comments From [EMAIL PROTECTED]  2008-07-30 12:41 EST ---
I always try to keep my modifications to a minimum in such cases. Lots of
packages include extraneous license files (possibly for historical purposes).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454011] Review Request: tcl-snack - Sound toolkit

2008-07-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tcl-snack - Sound toolkit


https://bugzilla.redhat.com/show_bug.cgi?id=454011


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||454022
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review