[Bug 455541] Review Request: dojo - javascript library

2009-08-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=455541


Chris Weyl cw...@alumni.drew.edu changed:

   What|Removed |Added

 CC||cw...@alumni.drew.edu
  Alias||dojo




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 455541] Review Request: dojo - javascript library

2009-03-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=455541


Peter Lemenkov lemen...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|lemen...@gmail.com
   Flag||fedora-review?




--- Comment #6 from Peter Lemenkov lemen...@gmail.com  2009-03-07 10:57:11 
EDT ---
Ok, I'll review it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 455541] Review Request: dojo - javascript library

2009-03-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=455541





--- Comment #7 from Jason Tibbitts ti...@math.uh.edu  2009-03-07 12:24:59 EDT 
---
Originally we were holding off on some of these javascript packages until we
figured out some guidelines for packaging them, but that effort doesn't seem to
be going anywhere at all.  It's a rather difficult issue, honestly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 455541] Review Request: dojo - javascript library

2009-02-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=455541


Peter Lemenkov lemen...@gmail.com changed:

   What|Removed |Added

 CC||lemen...@gmail.com
   Flag|needinfo?   |




--- Comment #4 from Peter Lemenkov lemen...@gmail.com  2009-02-16 13:33:30 
EDT ---
Ping!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 455541] Review Request: dojo - javascript library

2009-02-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=455541





--- Comment #5 from Dave Malcolm dmalc...@redhat.com  2009-02-16 19:21:30 EDT 
---
Oops, sorry, I tried to fix things, then dropped this on the floor.

Updated version uploaded:
Specfile: http://dmalcolm.fedorapeople.org/dojo.spec
SRPMS: http://dmalcolm.fedorapeople.org/dojo-1.1.1-2.src.rpm

This versions appears to have successfully removed the wav files from the built
rpm.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 455541] Review Request: dojo - javascript library

2008-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=455541





--- Comment #3 from Rakesh Pandit [EMAIL PROTECTED]  2008-08-24 02:02:45 EDT 
---
+1 month now, Any updates here?
needinfo ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 455541] Review Request: dojo - javascript library

2008-07-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dojo - javascript library


https://bugzilla.redhat.com/show_bug.cgi?id=455541


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2008-07-20 22:52 EST ---

rpmlint is not clean:

dojo.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 42)
dojo.src: W: invalid-license AFL2.1
---

dojo.noarch: W: file-not-utf8 /usr/share/dojo/dojo/cldr/LICENSE
dojo.noarch: E: non-executable-script
/usr/share/dojo/dojox/storage/buildFlashStorage.sh 0644
dojo.noarch: W: wrong-file-end-of-line-encoding
/usr/share/dojo/dojox/encoding/LICENSE
dojo.noarch: E: zero-length /usr/share/dojo/dojox/rpc/test.txt
dojo.noarch: E: non-executable-script
/usr/share/dojo/dojox/flash/tests/buildFlashTest.sh 0644
dojo.noarch: E: non-executable-script /usr/share/dojo/dojo/tests/io/upload.cgi 
0644
dojo.noarch: E: non-executable-script /usr/share/dojo/util/doh/runner.sh 0644
dojo.noarch: W: invalid-license AFL2.1

---

You are listing these files for both macros, doc and datadir. The text files
should all go under /usr/share/doc aka %doc. 

warning: File listed twice: /usr/share/dojo/dijit/LICENSE
warning: File listed twice: /usr/share/dojo/dojo/LICENSE
warning: File listed twice: /usr/share/dojo/dojo/_firebug/LICENSE
warning: File listed twice: /usr/share/dojo/dojo/cldr/LICENSE
warning: File listed twice: /usr/share/dojo/dojo/cldr/README
warning: File listed twice: /usr/share/dojo/dojo/resources/LICENSE
warning: File listed twice: /usr/share/dojo/dojox/LICENSE
warning: File listed twice: /usr/share/dojo/dojox/_sql/LICENSE
warning: File listed twice: /usr/share/dojo/dojox/encoding/LICENSE
warning: File listed twice: /usr/share/dojo/dojox/encoding/README
warning: File listed twice: /usr/share/dojo/dojox/lang/LICENSE
warning: File listed twice: /usr/share/dojo/dojox/lang/README
warning: File listed twice: /usr/share/dojo/util/doh/LICENSE
warning: File listed twice: /usr/share/dojo/util/doh/README

--

Your spec claims you are deleting the sounds. Yet on my installation of the
package, I see

/usr/share/dojo/util/doh/_sounds/LICENSE
/usr/share/dojo/util/doh/_sounds/doh.wav
/usr/share/dojo/util/doh/_sounds/dohaaa.wav
/usr/share/dojo/util/doh/_sounds/woohoo.wav

You should contact upstream and clarify licensing. 


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 455541] Review Request: dojo - javascript library

2008-07-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dojo - javascript library


https://bugzilla.redhat.com/show_bug.cgi?id=455541





--- Additional Comments From [EMAIL PROTECTED]  2008-07-20 22:59 EST ---

Nothing under util directory seems to have clear licensing at all including the
couple of js files. There is a no license text within that directory either.
Shouldn't all the files independently carry a copyright notice and licensing
information in the header? 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review