[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 --- Comment #27 from Fedora Update System upda...@fedoraproject.org 2009-05-28 04:08:11 EDT --- libgarmin-0-0.6.20090212svn.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|0-0.6.20090212svn.fc9 |0-0.6.20090212svn.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 --- Comment #25 from Fedora Update System upda...@fedoraproject.org 2009-04-27 17:18:28 EDT --- libgarmin-0-0.6.20090212svn.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||0-0.6.20090212svn.fc10 Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|0-0.6.20090212svn.fc10 |0-0.6.20090212svn.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 --- Comment #26 from Fedora Update System upda...@fedoraproject.org 2009-04-27 17:24:25 EDT --- libgarmin-0-0.6.20090212svn.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #23 from Fedora Update System upda...@fedoraproject.org 2009-04-21 20:50:37 EDT --- libgarmin-0-0.6.20090212svn.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update libgarmin'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-3770 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 --- Comment #24 from Fedora Update System upda...@fedoraproject.org 2009-04-21 20:55:08 EDT --- libgarmin-0-0.6.20090212svn.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libgarmin'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-3799 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #19 from Kevin Fenzi ke...@tummy.com 2009-04-17 12:23:57 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 --- Comment #21 from Fedora Update System upda...@fedoraproject.org 2009-04-17 15:43:07 EDT --- libgarmin-0-0.6.20090212svn.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/libgarmin-0-0.6.20090212svn.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 --- Comment #20 from Fedora Update System upda...@fedoraproject.org 2009-04-17 15:43:02 EDT --- libgarmin-0-0.6.20090212svn.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/libgarmin-0-0.6.20090212svn.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 --- Comment #22 from Fedora Update System upda...@fedoraproject.org 2009-04-17 15:43:12 EDT --- libgarmin-0-0.6.20090212svn.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/libgarmin-0-0.6.20090212svn.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #17 from Jason Tibbitts ti...@math.uh.edu 2009-04-16 14:00:45 EDT --- Removing the duplicated documentation caused a no-documentation complaint from rpm on the -devel package, but that's not an issue. Otherwise I think this is fine now. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added Flag||fedora-cvs? --- Comment #18 from Fabian Affolter fab...@bernewireless.net 2009-04-16 18:12:07 EDT --- New Package CVS Request === Package Name: libgarmin Short Description: C library to parse and use Garmin image files Owners: fab Branches: F-9 F-10 F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 --- Comment #16 from Fabian Affolter fab...@bernewireless.net 2009-04-13 18:25:40 EDT --- Thanks. Updated files SPEC: http://fab.fedorapeople.org/packages/SRPMS/libgarmin.spec SRPM: http://fab.fedorapeople.org/packages/SRPMS/libgarmin-0-0.6.20090212svn.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 --- Comment #15 from Michael Schwendt bugs.mich...@gmx.net 2009-04-08 07:58:32 EDT --- Group: Applications/Productivity System Environment/Libraries %configure --enable-static=no Wrong or not recognised option it seems. Library is static-only, and as soon as it would build shared libs, build would fail anyway due to installed files not included in %files. %doc AUTHORS COPYING INSTALL README TODO In case this is the standard INSTALL file, it is irrelevant to RPM package users and typically is not included. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 --- Comment #14 from Fabian Affolter fab...@bernewireless.net 2009-04-08 05:12:00 EDT --- Jason, thanks for your input. I will try to update this package soon. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|ti...@math.uh.edu Flag||fedora-review? --- Comment #13 from Jason Tibbitts ti...@math.uh.edu 2009-03-11 22:01:18 EDT --- Builds fine and rpmlint is silent. Since this package has only static libraries, it's OK that they're in the devel package but you must provide libgarmin-static (and any packages that need to link against the .a need build dependencies on it). Most files don't seem to have a license block; those that do are GPLv2 (only) and the author adds a note at the head of the COPYING file which clarifies v2 only for the rest. The description could use a little cleanup. I would suggest something like: Libgarmin is a library used to parse IMG files from Garmin GPS devices. The COPYING, REAMDE and TODO files are duplicated. You should choose one package to contain them. * source files match upstream (manually compared with checkout). * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. X description could use a bit of grammar work. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint is silent. X final provides and requires: libgarmin-0-0.5.20090212svn.fc11.x86_64.rpm libgarmin = 0-0.5.20090212svn.fc11 libgarmin(x86-64) = 0-0.5.20090212svn.fc11 = (none) libgarmin-devel-0-0.5.20090212svn.fc11.x86_64.rpm pkgconfig(libgarmin) = 0.1 libgarmin-devel = 0-0.5.20090212svn.fc11 libgarmin-devel(x86-64) = 0-0.5.20090212svn.fc11 X needs libgarmin-static = /usr/bin/pkg-config libgarmin = 0-0.5.20090212svn.fc11 pkgconfig * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. X duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * headers are in the -devel package. * pkgconfig files are in the -devel package; pkgconfig dependency is present. X static libraries are in the -devel package, but there is no -static provide. * no libtool .la files. The package review process needs reviewers! If you haven't done any package reviews recently, please consider doing one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added Blocks||485652 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 --- Comment #10 from Fabian Affolter fab...@bernewireless.net 2009-02-12 16:07:54 EDT --- Updated files SPEC: http://fab.fedorapeople.org/packages/SRPMS/libgarmin.spec SRPM: http://fab.fedorapeople.org/packages/SRPMS/garmintools-0.09-2.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 --- Comment #11 from Tom spot Callaway tcall...@redhat.com 2009-02-12 16:13:10 EDT --- Fabian, please keep the spec file name the same as the SRPM name. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 --- Comment #12 from Fabian Affolter fab...@bernewireless.net 2009-02-12 16:55:50 EDT --- Sorry, wrong URL http://fab.fedorapeople.org/packages/SRPMS/libgarmin-0-0.5.20090212svn.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added CC||tcall...@redhat.com Blocks|182235 | --- Comment #9 from Tom spot Callaway tcall...@redhat.com 2009-01-12 15:46:35 EDT --- I can find no patents in a preliminary search that this would violate. While the format is clearly not documented publicly, there is no problem with a reverse engineered implementation, especially since this is being done for the explicit reason of providing interoperability with Linux environments. Lifting FE-Legal. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 Balint Cristian re...@rdsor.ro changed: What|Removed |Added CC||re...@rdsor.ro --- Comment #6 from Balint Cristian re...@rdsor.ro 2009-01-03 12:15:28 EDT --- Folks, - I think this package violates Garmin (TM) proprietary format and their patents.We should be careful by adding such a package to Fedora, Garmin (TM) never released any specifications of their format, everything is a pure reverse engineering. On top of all it contains some patent subjected (not sure which one) which allows very smart routing information store. - Legal folk, can state some points over this package ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 --- Comment #7 from Peter Lemenkov lemen...@gmail.com 2009-01-03 13:03:09 EDT --- I think this package violates Garmin (TM) proprietary format and their patents You're not the Garmin's legal representative to make such statement. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added Blocks||182235 --- Comment #8 from Fabian Affolter fab...@bernewireless.net 2009-01-03 13:44:08 EDT --- Add Legal Blocker. Let's see what's Fedora Legal says. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 --- Comment #5 from Fabian Affolter fab...@bernewireless.net 2008-12-14 15:22:57 EDT --- * Sun Dec 14 2008 Fabian Affolter fab...@bernewireless.net - 0-0.4.20081214svn - Updated from revision 307 to revision 315 SPEC: http://fab.fedorapeople.org/packages/SRPMS/libgarmin.spec SRPM: http://fab.fedorapeople.org/packages/SRPMS/libgarmin-0-0.4.20081214svn.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=468631
--- Comment #4 from Fabian Affolter [EMAIL PROTECTED] 2008-11-10 15:06:28
EDT ---
(In reply to comment #3)
%files
%defattr(-,root,root,-)
%doc AUTHORS COPYING INSTALL README TODO
Absolutely no need to include the same %doc files also in
the -devel pkg.
fixed
%{_bindir}/gar*
%{_datadir}/%{name}/garmintypes.txt
Don't forget the corresponding directory entry!
Add: %dir %{_datadir}/%{name}
fixed
%files devel
%defattr(-,root,root,-)
%doc AUTHORS COPYING INSTALL README TODO
%{_datadir}/%{name}/doc/*
Here either replace your line with
%{_datadir}/%{name}/doc/
to add that directory and its contents recursively, or add:
%dir %{_datadir}/%{name}/doc
to the -devel pkg files section.
fixed
%{_libdir}/pkgconfig/%{name}.pc
You put a file in there, so Requires: pkgconfig.
fixed
SPEC: http://fab.fedorapeople.org/packages/SRPMS/libgarmin.spec
SRPM:
http://fab.fedorapeople.org/packages/SRPMS/libgarmin-0-0.3.20081026svn.fc9.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=468631
--- Comment #3 from Michael Schwendt [EMAIL PROTECTED] 2008-11-09 19:38:20
EDT ---
%files
%defattr(-,root,root,-)
%doc AUTHORS COPYING INSTALL README TODO
Absolutely no need to include the same %doc files also in
the -devel pkg.
%{_bindir}/gar*
%{_datadir}/%{name}/garmintypes.txt
Don't forget the corresponding directory entry!
Add: %dir %{_datadir}/%{name}
%files devel
%defattr(-,root,root,-)
%doc AUTHORS COPYING INSTALL README TODO
%{_datadir}/%{name}/doc/*
Here either replace your line with
%{_datadir}/%{name}/doc/
to add that directory and its contents recursively, or add:
%dir %{_datadir}/%{name}/doc
to the -devel pkg files section.
%{_libdir}/pkgconfig/%{name}.pc
You put a file in there, so Requires: pkgconfig.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 --- Comment #2 from Fabian Affolter [EMAIL PROTECTED] 2008-10-28 20:17:20 EDT --- Thanks Ralf for the comments (In reply to comment #1) Just a couple of remarks: (In reply to comment #0) MUSTFIX - libgarmin.a is missing from *-devel Without, this *-devel rpm is widely useless. fixed - package doesn't support shared libraries = Must add *-static magic to *-devel fixed. I added '--enable-static=no' to %configure - Wrong License: Your spec says: License:GPLv2+ Several files (e.g. libgarmin.h and COPYING) inside of the sources say: GPLv2 *only*. fixed SPEC: http://fab.fedorapeople.org/packages/SRPMS/libgarmin.spec SRPM: http://fab.fedorapeople.org/packages/SRPMS/libgarmin-0-0.2.20081026svn.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 Fabian Affolter [EMAIL PROTECTED] changed: What|Removed |Added Blocks||461849 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 Ralf Corsepius [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #1 from Ralf Corsepius [EMAIL PROTECTED] 2008-10-26 22:17:01 EDT --- Just a couple of remarks: (In reply to comment #0) [EMAIL PROTECTED] i386]$ rpmlint libgarmin* 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Interesting, rpmlint is worse than I had thought:) MUSTFIX - libgarmin.a is missing from *-devel Without, this *-devel rpm is widely useless. - package doesn't support shared libraries = Must add *-static magic to *-devel - Wrong License: Your spec says: License:GPLv2+ Several files (e.g. libgarmin.h and COPYING) inside of the sources say: GPLv2 *only*. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
