[Bug 468797] Review Request: jrosetta - A common base to build a graphical console

2009-05-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468797


Peter Lemenkov lemen...@gmail.com changed:

   What|Removed |Added

 Blocks||496433(RussianFedora)




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468797] Review Request: jrosetta - A common base to build a graphical console

2009-01-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468797


Nicolas Chauvet (kwizart) kwiz...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468797] Review Request: jrosetta - A common base to build a graphical console

2009-01-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468797


Nicolas Chauvet (kwizart) kwiz...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #12 from Nicolas Chauvet (kwizart) kwiz...@gmail.com  2009-01-20 
06:30:50 EDT ---
New Package CVS Request
===
Package Name: jrosetta
Short Description: A common base to build a graphical console
Owners: kwizart
Branches: F-10 EL-5
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468797] Review Request: jrosetta - A common base to build a graphical console

2009-01-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468797


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #13 from Kevin Fenzi ke...@tummy.com  2009-01-20 16:19:32 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468797] Review Request: jrosetta - A common base to build a graphical console

2009-01-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468797


Dominik 'Rathann' Mierzejewski r...@greysector.net changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #11 from Dominik 'Rathann' Mierzejewski r...@greysector.net  
2009-01-19 18:04:43 EDT ---
Very nice, APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468797] Review Request: JRosetta - A common base to build a graphical console

2009-01-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468797





--- Comment #8 from Nicolas Chauvet (kwizart) kwiz...@gmail.com  2009-01-16 
12:15:55 EDT ---
Spec URL: 
http://kwizart.fedorapeople.org/SPECS/jrosetta.spec
SRPM URL: 
http://kwizart.fedorapeople.org/SRPMS/jrosetta-1.0.1-1.fc8.kwizart.src.rpm
Description: A common base to build a graphical console

I'm reverting back to jrosetta as package named as the .jar files are named
jrosetta*.jar anyway.
Im' not bumping the release since they were not a package named jrosetta 1.0.2
previously.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468797] Review Request: JRosetta - A common base to build a graphical console

2009-01-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468797





--- Comment #9 from Dominik 'Rathann' Mierzejewski r...@greysector.net  
2009-01-16 16:05:16 EDT ---
(In reply to comment #8)
 Spec URL: 
 http://kwizart.fedorapeople.org/SPECS/jrosetta.spec

Specfile says 1.0.2, but...

 SRPM URL: 
 http://kwizart.fedorapeople.org/SRPMS/jrosetta-1.0.1-1.fc8.kwizart.src.rpm

this is 1.0.1.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468797] Review Request: jrosetta - A common base to build a graphical console

2009-01-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468797


Nicolas Chauvet (kwizart) kwiz...@gmail.com changed:

   What|Removed |Added

Summary|Review Request: JRosetta -  |Review Request: jrosetta -
   |A common base to build a|A common base to build a
   |graphical console   |graphical console




--- Comment #10 from Nicolas Chauvet (kwizart) kwiz...@gmail.com  2009-01-16 
18:02:10 EDT ---
SRPM URL: 
http://kwizart.fedorapeople.org/SRPMS/jrosetta-1.0.2-1.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468797] Review Request: JRosetta - A common base to build a graphical console

2009-01-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468797


Nicolas Chauvet (kwizart) kwiz...@gmail.com changed:

   What|Removed |Added

Summary|Review Request: jrosetta -  |Review Request: JRosetta -
   |JRosetta provides a common  |A common base to build a
   |base for graphical  |graphical console
   |component   |




--- Comment #4 from Nicolas Chauvet (kwizart) kwiz...@gmail.com  2009-01-14 
05:11:38 EDT ---
Spec URL: 
http://kwizart.fedorapeople.org/SPECS/JRosetta.spec
SRPM URL: 
http://kwizart.fedorapeople.org/SRPMS/JRosetta-1.0.2-1.fc10.src.rpm
Description: A common base to build a graphical console

Changelog
- Fix License (GPLv2 only) (was confirmed by phone call with upstream, the
shortname license can be seen in the MANIFEST of the jar files.)
- Fix Summary
- Update to 1.0.2 - previous patch merged upstream
- Rename to JRosetta

Koji scratch build for Rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1051591

rpmlint is quiet on local build from F-10

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468797] Review Request: JRosetta - A common base to build a graphical console

2009-01-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468797





--- Comment #5 from Nicolas Chauvet (kwizart) kwiz...@gmail.com  2009-01-14 
10:19:06 EDT ---
@Haley
---
%setup -qc
[...snip]
pushd .
[...snip]
popd

#The zip file is a bit messy. 
#We reshuffle the top level dir
mv %{name}-%{version}-GPL/* .
mv %{name}-%{version}-GPL/.[A-z]* .
---
This is weird to fix problem you have introduced with not using the correct
%setup macro:
%setup -q -n %{name}-%{version}-GPL

Along with your debuginfo tweak in the scilab package (that, again, isn't
needed), You seem to have a strange buildsys. At this time, I don't know if you
got inattentive or your buildsys is buggy. The result is that I cannot trust
any packages that comes from your side.
I hope you can solve this, because we really need hands for scilab and
others...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468797] Review Request: JRosetta - A common base to build a graphical console

2009-01-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468797





--- Comment #6 from D Haley my...@yahoo.com  2009-01-14 18:21:14 EDT ---
Nicholas, If you have specific problems with my packages, I would be most
apprreciative if you could please comment on them one by one and where
appropriate.

My packages are subject to review and can be rejected as required. Personal
attacks are unprofessional, and finally it is not up to you to decide whether
to accept packages or not. My personal policy is that others are allowed to
modify my work, if I fail to do so in a timely fashion.]

A bug report forum is not a place to conduct such aggressive behaviour. If you
dont like it, please say so in a review, or contact me personally.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468797] Review Request: JRosetta - A common base to build a graphical console

2009-01-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468797





--- Comment #7 from Dominik 'Rathann' Mierzejewski r...@greysector.net  
2009-01-14 19:27:36 EDT ---
(In reply to comment #4)
 Spec URL: 
 http://kwizart.fedorapeople.org/SPECS/JRosetta.spec
 SRPM URL: 
 http://kwizart.fedorapeople.org/SRPMS/JRosetta-1.0.2-1.fc10.src.rpm
 Description: A common base to build a graphical console
 
 Changelog
 - Fix License (GPLv2 only) (was confirmed by phone call with upstream, the
 shortname license can be seen in the MANIFEST of the jar files.)
 - Fix Summary
 - Update to 1.0.2 - previous patch merged upstream
 - Rename to JRosetta

Full review:

rpmlint clean:
$ rpmlint /var/lib/mock/fedora-rawhide-i386/result
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

Naming:
Please rename it back to jrosetta. There is no good reason to have mixed-case
name. In fact, no java package present in Fedora has mixed-case name.

Pre-built binaries:
The 1.0.2 source tarball contains pre-built binaries in build/*, please remove
them in %prep and ask upstream to provide a source-only tarball, if possible.
1.0.1 was shipped without those binaries and the tarball was half the size.

Source MD5 matches upstream:
ef0f9208202762c93c8c415d8472aa76  jrosetta-1.0.2-GPL.zip
ef0f9208202762c93c8c415d8472aa76  JRosetta-1.0.2-GPL.zip

Other than that, it seems fine.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review