[Bug 468823] Review Request: hanazono-fonts - Japanese Mincho-typeface TrueType font

2008-11-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468823





--- Comment #20 from Jens Petersen [EMAIL PROTECTED]  2008-11-24 18:16:28 EDT 
---
Probably be good to add i18n-team too to initialcc next time.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468823] Review Request: hanazono-fonts - Japanese Mincho-typeface TrueType font

2008-11-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468823


Kevin Fenzi [EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Flag|fedora-cvs? |fedora-cvs+




--- Comment #18 from Kevin Fenzi [EMAIL PROTECTED]  2008-11-16 15:16:01 EDT 
---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468823] Review Request: hanazono-fonts - Japanese Mincho-typeface TrueType font

2008-11-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468823


Akira TAGOH [EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Comment #19 from Akira TAGOH [EMAIL PROTECTED]  2008-11-16 23:18:05 EDT 
---
Thanks. built and updated comps and wiki as well.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468823] Review Request: hanazono-fonts - Japanese Mincho-typeface TrueType font

2008-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468823


Nicolas Mailhot [EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
   Flag|fedora-review?  |fedora-review+




--- Comment #16 from Nicolas Mailhot [EMAIL PROTECTED]  2008-11-14 04:42:11 
EDT ---
This one looks good, thank you for your persistence. You can now continue the
font package integration process, starting here:
http://fedoraproject.org/wiki/Font_package_lifecycle#3.a
Please do not forget the comps and wiki parts.

Reassigning the bug to you since my part is done.

APPROVED

PS Do not forget to subscribe to the low-traffic fedora-fonts-list, since
Fedora 11 packaging changes are being discussed there right now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468823] Review Request: hanazono-fonts - Japanese Mincho-typeface TrueType font

2008-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468823


Akira TAGOH [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #17 from Akira TAGOH [EMAIL PROTECTED]  2008-11-14 05:37:26 EDT 
---
Thanks for the review, Nicolas.

New Package CVS Request
===
Package Name: hanazono-fonts
Short Description: Japanese Mincho-typeface TrueType font
Owners: tagoh
Branches: devel F-10 F-9 F-8
InitialCC: fonts-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468823] Review Request: hanazono-fonts - Japanese Mincho-typeface TrueType font

2008-11-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468823





--- Comment #14 from Nicolas Mailhot [EMAIL PROTECTED]  2008-11-13 17:01:21 
EDT ---
(22:32:08) nim-nim: tagoh3: your first fontconfig rule for hanazo is now fine
(22:32:20) nim-nim: tagoh3: but the second one is still reversed
(22:32:26) nim-nim: tagoh3: you need
(22:32:32) nim-nim:   alias
(22:32:32) nim-nim: family[fontname]/family
(22:32:32) nim-nim: default
(22:32:32) nim-nim:   family[genericname]/family
(22:32:32) nim-nim: /default
(22:32:32) nim-nim:   /alias
(22:32:59) nim-nim: with   [fontname]=HanaMin
(22:33:16) nim-nim: and [genericname]=serif

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468823] Review Request: hanazono-fonts - Japanese Mincho-typeface TrueType font

2008-11-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468823





--- Comment #15 from Akira TAGOH [EMAIL PROTECTED]  2008-11-13 21:01:19 EDT 
---
Doh! I should have a look carefully more.. Thanks for catching this up!

Hopefully this would be a final review for hanazono-fonts.

Spec URL: http://tagoh.fedorapeople.org/hanazono-fonts/hanazono-fonts.spec
SRPM URL:
http://tagoh.fedorapeople.org/hanazono-fonts/hanazono-fonts-20081012-5.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468823] Review Request: hanazono-fonts - Japanese Mincho-typeface TrueType font

2008-11-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468823





--- Comment #11 from Akira TAGOH [EMAIL PROTECTED]  2008-11-12 03:03:13 EDT 
---
(In reply to comment #10)
 Are there so many japanese locales out there you can not use the full ja-FOO
 code? Because this test will trigger on any locale that contains ja (for
 example javanese, if fontconfig ever moves to iso639-2 or iso15924)

No. maybe better testing jp or do you prefer ja-jp (or ja_jp? dunno) rather
than that?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468823] Review Request: hanazono-fonts - Japanese Mincho-typeface TrueType font

2008-11-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468823





--- Comment #12 from Nicolas Mailhot [EMAIL PROTECTED]  2008-11-12 04:19:01 
EDT ---
If there is only one japanese locale by all means just test on ja-jp (without
the contains bit). IIRC that was the locale format that worked for the Chinese
people.

However, as always with fontconfig, it's a good idea to test before pushing the
rules on users.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468823] Review Request: hanazono-fonts - Japanese Mincho-typeface TrueType font

2008-11-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468823





--- Comment #13 from Akira TAGOH [EMAIL PROTECTED]  2008-11-12 20:08:32 EDT 
---
Sure. Updated.

Spec URL: http://tagoh.fedorapeople.org/hanazono-fonts/hanazono-fonts.spec
SRPM URL:
http://tagoh.fedorapeople.org/hanazono-fonts/hanazono-fonts-20081012-4.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468823] Review Request: hanazono-fonts - Japanese Mincho-typeface TrueType font

2008-11-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468823





--- Comment #9 from Akira TAGOH [EMAIL PROTECTED]  2008-11-11 22:47:04 EDT ---
Sorry, my bad. it works after changing:

test name=lang
  stringja/string
/test

to:

test name=lang compare=contains
  stringja/string
/test

Spec URL: http://tagoh.fedorapeople.org/hanazono-fonts/hanazono-fonts.spec
SRPM URL:
http://tagoh.fedorapeople.org/hanazono-fonts/hanazono-fonts-20081012-3.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468823] Review Request: hanazono-fonts - Japanese Mincho-typeface TrueType font

2008-11-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468823





--- Comment #10 from Nicolas Mailhot [EMAIL PROTECTED]  2008-11-12 02:13:19 
EDT ---
(In reply to comment #9)
 Sorry, my bad. it works after changing:
 
 test name=lang
   stringja/string
 /test
 
 to:
 
 test name=lang compare=contains
   stringja/string
 /test

Oh, right. didn't catch it sorry.

Are there so many japanese locales out there you can not use the full ja-FOO
code? Because this test will trigger on any locale that contains ja (for
example javanese, if fontconfig ever moves to iso639-2 or iso15924)

(don't know if this is a big risk, I think this was a long-term fontconfig
plan, Behdad would know)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468823] Review Request: hanazono-fonts - Japanese Mincho-typeface TrueType font

2008-11-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468823


Nicolas Mailhot [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||needinfo?([EMAIL PROTECTED])




--- Comment #6 from Nicolas Mailhot [EMAIL PROTECTED]  2008-11-10 03:20:43 
EDT ---
(In reply to comment #5)
 (In reply to comment #3)

 I've already asked on fedora-legal-list, and just followed him to describe
 License tag -
 https://www.redhat.com/archives/fedora-legal-list/2008-October/msg00022.html

If you could convince spot to publish this on his licenses approved for fonts
use wiki page, that would make it easier for the next reviewers. Anyway

  2. please follow the font packaging process outlined on 
  http://fedoraproject.org/wiki/Font_package_lifecycle
  and in particular create a wiki page that describes your font and can be
  referenced in release notes
 
 Just created: https://fedoraproject.org/wiki/Hanazono_font

Nice. You just need to remove the : before Category to activate them (fixed, I
must rework the template help, everyone makes the same mistake)

  3. your fontconfig priority (59) is a little low, our guidelines states CJK
  fonts should be in the 65-69 range
  http://fedoraproject.org/wiki/Fontconfig_packaging_tips#Simple_priority_lists
  
  4. your fontconfig rule is a bit more convoluted than what we usually do. It
  probably works but please get Behdad to review it (and ok it there).
 
 I'd like to push this font prior to sazanami-mincho.ttf which we defaults for
 Serif for Japanese, because the quality is better than it. I'm not sure what's
 the right thing to do that for fontconfig config. that would be appreciated if
 someone could helps me.

Ultimately, Behdad is the best judge of us all on fontconfig stuff.

  5. please also alias the font the other way, so fontconfig knows it should 
  use
  serif fonts to complete HanaMin
  http://fedoraproject.org/wiki/Fontconfig_packaging_tips#Generic_names
 
 Fixed in the updated package.

Nope, the rule I referenced would have been

alias
  familyHanaMin/family
  default
familyserif/family
  /default
/alias

The rule you added is equivalent to the one you already had, without the ja
test.

The fun thing is that your original rule needs to be placed after 
conf.d/65-nonlatin.conf to work, and your second rule needs to be placed
before, so you can't use both in the same file :p

Thus I'd advise to
1. keep your original rule
2. add the one I just wrote
3. use 66 as fontconfig prio
4. test test test

  7. you can drop the -f argument to fc-cache for releases ≥ Fedora 9
 
 Can you update the template page as well to see what's the expected thing
 hereafter?

It's documented in the comments nobody seems to read :) I'll drop it as soon as
Fedora 8 in un-supported.

 Spec URL: http://tagoh.fedorapeople.org/hanazono-fonts/hanazono-fonts.spec
 SRPM URL:
 http://tagoh.fedorapeople.org/hanazono-fonts/hanazono-fonts-20081012-2.fc9.src.rpm

Appart from the fontconfig bit, you're almost there

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468823] Review Request: hanazono-fonts - Japanese Mincho-typeface TrueType font

2008-11-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468823





--- Comment #8 from Nicolas Mailhot [EMAIL PROTECTED]  2008-11-10 07:16:30 
EDT ---
(In reply to comment #7)

  Thus I'd advise to
  1. keep your original rule
  2. add the one I just wrote
  3. use 66 as fontconfig prio
  4. test test test
 
 Hmm, that seems not working. Sazanami Mincho is still used for Serif somehow.

Then does it work with 65? I thought I understood how fontconfig worked, but
maybe I'm just another confused user

 I meant in template file :) Though it may be not worth taking an effort for 
 you
 because it's going to be EOL'd soon.

I'm rewriting all the templates anyway because of the number of multi-font
packages we've had to process lately

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468823] Review Request: hanazono-fonts - Japanese Mincho-typeface TrueType font

2008-11-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468823


Akira TAGOH [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|needinfo?([EMAIL PROTECTED]) |




--- Comment #7 from Akira TAGOH [EMAIL PROTECTED]  2008-11-10 06:52:37 EDT ---
(In reply to comment #6)
 Nope, the rule I referenced would have been
 
 alias
   familyHanaMin/family
   default
 familyserif/family
   /default
 /alias
 
 The rule you added is equivalent to the one you already had, without the ja
 test.

Doh, just referred the wrong thing.. :(

 The fun thing is that your original rule needs to be placed after 
 conf.d/65-nonlatin.conf to work, and your second rule needs to be placed
 before, so you can't use both in the same file :p

Ah, ok.

 Thus I'd advise to
 1. keep your original rule
 2. add the one I just wrote
 3. use 66 as fontconfig prio
 4. test test test

Hmm, that seems not working. Sazanami Mincho is still used for Serif somehow.

 
   7. you can drop the -f argument to fc-cache for releases ≥ Fedora 9
  
  Can you update the template page as well to see what's the expected thing
  hereafter?
 
 It's documented in the comments nobody seems to read :) I'll drop it as soon 
 as
 Fedora 8 in un-supported.

I meant in template file :) Though it may be not worth taking an effort for you
because it's going to be EOL'd soon. BTW just noticed that I can't see any
annotations on the template page. I had to do the view source to see. dunno if
it's a problem on my browser, or mediawiki's bug.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468823] Review Request: hanazono-fonts - Japanese Mincho-typeface TrueType font

2008-11-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468823


Nicolas Mailhot [EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468823] Review Request: hanazono-fonts - Japanese Mincho-typeface TrueType font

2008-11-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468823


Mamoru Tasaka [EMAIL PROTECTED] changed:

   What|Removed |Added

 CC|[EMAIL PROTECTED] |




--- Comment #4 from Mamoru Tasaka [EMAIL PROTECTED]  2008-11-09 21:39:05 EDT 
---
(In reply to comment #3)
 Since nobody bites, I'll take this. First review pass
 
 1. you're packaging a font with a new license. While at first view it seems 
 ok,
 you still need spot to approve it and put it on
 http://fedoraproject.org/wiki/Legal_considerations_for_fonts

See this
https://www.redhat.com/archives/fedora-legal-list/2008-October/msg00022.html

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468823] Review Request: hanazono-fonts - Japanese Mincho-typeface TrueType font

2008-11-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468823


Akira TAGOH [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|needinfo?([EMAIL PROTECTED]) |




--- Comment #5 from Akira TAGOH [EMAIL PROTECTED]  2008-11-10 00:12:08 EDT ---
Thank you for taking a review for this package.

(In reply to comment #3)
 1. you're packaging a font with a new license. While at first view it seems 
 ok,
 you still need spot to approve it and put it on
 http://fedoraproject.org/wiki/Legal_considerations_for_fonts

I've already asked on fedora-legal-list, and just followed him to describe
License tag -
https://www.redhat.com/archives/fedora-legal-list/2008-October/msg00022.html

 2. please follow the font packaging process outlined on 
 http://fedoraproject.org/wiki/Font_package_lifecycle
 and in particular create a wiki page that describes your font and can be
 referenced in release notes

Just created: https://fedoraproject.org/wiki/Hanazono_font

 3. your fontconfig priority (59) is a little low, our guidelines states CJK
 fonts should be in the 65-69 range
 http://fedoraproject.org/wiki/Fontconfig_packaging_tips#Simple_priority_lists
 
 4. your fontconfig rule is a bit more convoluted than what we usually do. It
 probably works but please get Behdad to review it (and ok it there).

I'd like to push this font prior to sazanami-mincho.ttf which we defaults for
Serif for Japanese, because the quality is better than it. I'm not sure what's
the right thing to do that for fontconfig config. that would be appreciated if
someone could helps me.

 5. please also alias the font the other way, so fontconfig knows it should use
 serif fonts to complete HanaMin
 http://fedoraproject.org/wiki/Fontconfig_packaging_tips#Generic_names

Fixed in the updated package.

 6. please send your fontconfig file to hanazano upstream so it's included in
 their next release once you're happy with it

Sure.

 7. you can drop the -f argument to fc-cache for releases ≥ Fedora 9

Can you update the template page as well to see what's the expected thing
hereafter?

 8. please use the defattr suggested by guidelines %defattr(644,root,root,755)

Sorry, missed one. fixed.

 9. it's a little easier to review a package when the fields are in the same
 order as in rpmdevtool's  spectemplate-fonts.spec (cosmetic, you can ignore 
 it,
 just take it into account for your next font package)

Oh, wasn't aware of that. improved a bit in:

Spec URL: http://tagoh.fedorapeople.org/hanazono-fonts/hanazono-fonts.spec
SRPM URL:
http://tagoh.fedorapeople.org/hanazono-fonts/hanazono-fonts-20081012-2.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468823] Review Request: hanazono-fonts - Japanese Mincho-typeface TrueType font

2008-11-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468823


Nicolas Mailhot [EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED],
   ||[EMAIL PROTECTED]
   Flag||needinfo?([EMAIL PROTECTED])




--- Comment #3 from Nicolas Mailhot [EMAIL PROTECTED]  2008-11-09 16:56:39 
EDT ---
Since nobody bites, I'll take this. First review pass

1. you're packaging a font with a new license. While at first view it seems ok,
you still need spot to approve it and put it on
http://fedoraproject.org/wiki/Legal_considerations_for_fonts

2. please follow the font packaging process outlined on 
http://fedoraproject.org/wiki/Font_package_lifecycle
and in particular create a wiki page that describes your font and can be
referenced in release notes

(a wiki page template is available there
http://fedoraproject.org/wiki/Font_description_template )

3. your fontconfig priority (59) is a little low, our guidelines states CJK
fonts should be in the 65-69 range
http://fedoraproject.org/wiki/Fontconfig_packaging_tips#Simple_priority_lists

Of course Behdad has the last say on this, so if you convince him to ok it I'll
let this pass.

4. your fontconfig rule is a bit more convoluted than what we usually do. It
probably works but please get Behdad to review it (and ok it there).

5. please also alias the font the other way, so fontconfig knows it should use
serif fonts to complete HanaMin
http://fedoraproject.org/wiki/Fontconfig_packaging_tips#Generic_names

6. please send your fontconfig file to hanazano upstream so it's included in
their next release once you're happy with it

7. you can drop the -f argument to fc-cache for releases ≥ Fedora 9

8. please use the defattr suggested by guidelines %defattr(644,root,root,755)

9. it's a little easier to review a package when the fields are in the same
order as in rpmdevtool's  spectemplate-fonts.spec (cosmetic, you can ignore it,
just take it into account for your next font package)

All in all this was a pleasant spec file to review and I'll have no problem
approving it once those little problems are taken care of

→ NEEDINFO in the meanwhile

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468823] Review Request: hanazono-fonts - Japanese Mincho-typeface TrueType font

2008-11-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468823





--- Comment #1 from Jens Petersen [EMAIL PROTECTED]  2008-11-05 01:26:17 EDT 
---
Tested this the other day: rpmlint is clean, but I can't get the font to render
default for ja on the desktop when I remove other Japanese fonts.  (Tagoh
mentioned some update to the font .conf file is needed.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468823] Review Request: hanazono-fonts - Japanese Mincho-typeface TrueType font

2008-11-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468823





--- Comment #2 from Akira TAGOH [EMAIL PROTECTED]  2008-11-05 02:16:07 EDT ---
I don't know how you tested it though, this is a Mincho typeface, which is
similar to serif. so usually you don't see that on the desktop by default so
that most applications defaults sans-serif or monospace.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468823] Review Request: hanazono-fonts - Japanese Mincho-typeface TrueType font

2008-10-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468823


Akira TAGOH [EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]
   ||at.com,
   ||[EMAIL PROTECTED]




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review