[Bug 473205] Review Request: gPlanarity - puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473205 Jussi Lehtola jussi.leht...@iki.fi changed: What|Removed |Added CC||jussi.leht...@iki.fi Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473205] Review Request: gPlanarity - puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473205 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Status|NEW |CLOSED Resolution||NOTABUG Flag|needinfo?(a...@antistof.dk) | --- Comment #13 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-02-19 10:57:34 EDT --- Now closing. If someone wants to import this package, please file a new review request and mark this bug as a duplicate of the new one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473205] Review Request: gPlanarity - puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473205 --- Comment #12 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-01-30 10:29:29 EDT --- I will close this this bug as NOTABUG if no response from the reporter is received within ONE WEEK. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473205] Review Request: gPlanarity - puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473205 --- Comment #11 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-01-17 11:14:54 EDT --- ping again? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473205] Review Request: gPlanarity - puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473205 Itamar Reis Peixoto ita...@ispbrasil.com.br changed: What|Removed |Added CC||ita...@ispbrasil.com.br Alias||gPlanarity -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473205] Review Request: gPlanarity - puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473205 --- Comment #10 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-01-06 12:00:42 EDT --- ping again? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473205] Review Request: gPlanarity - puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473205 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Flag||needinfo?(a...@antistof.dk) --- Comment #9 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2008-12-22 12:50:59 EDT --- Adam, would you address the issue commented by wolfy? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473205] Review Request: gPlanarity - puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473205 --- Comment #8 from manuel wolfshant [EMAIL PROTECTED] 2008-12-01 08:38:10 EDT --- Unfortunately the build logs show one big problem: your spec does not enforce usage of Fedora's mandatory compiler flags, but uses make target CFLAGS='-O2 -ffast-math `pkg-config --static --cflags gtk+-2.0 = 2.7.2 cairo = 1.0.0 freetype2` ' instead. See https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags for details -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473205] Review Request: gPlanarity - puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473205 --- Comment #7 from Adam Tulinius [EMAIL PROTECTED] 2008-11-30 18:14:32 EDT --- - Version-scheme has been adjusted to match the kismet-example on https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages , more or less. - vendor=fedora has been removed from the install-desktop-file call. spec: http://adamt.fedorapeople.org/pkg/gplanarity/gplanarity.spec srpm: http://adamt.fedorapeople.org/pkg/gplanarity/gplanarity-0-0.1.20081130svn11946.fc10.src.rpm koji-run: http://koji.fedoraproject.org/koji/taskinfo?taskID=964888 I also ditched most of the changelog-entries, because it seemed silly :-) - Adam -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473205] Review Request: gPlanarity - puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473205 --- Comment #6 from manuel wolfshant [EMAIL PROTECTED] 2008-11-29 09:38:38 EDT --- Since the package uses a snapshot version of the sources, please read https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages and adjust the value from the version field accordingly. Please also ditch vendor=fedora from the desktop-install line, it has been deprecated -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473205] Review Request: gPlanarity - puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473205 Fabian Affolter [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #3 from Fabian Affolter [EMAIL PROTECTED] 2008-11-27 10:45:05 EDT --- Just some another comment on your spec file. - License is GPLv2+. Take a look at the haeders of the source: or (at your option) any later version -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473205] Review Request: gPlanarity - puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473205 --- Comment #4 from Adam Tulinius [EMAIL PROTECTED] 2008-11-27 10:51:32 EDT --- Thank you for the comments. Most is fixed as i write, except for the application-icon being slightly weird. New spec- and srpms will be added when i figure that out. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473205] Review Request: gPlanarity - puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473205 --- Comment #5 from Adam Tulinius [EMAIL PROTECTED] 2008-11-27 12:11:51 EDT --- Now i got everything working, i think. I still haven't added Require, because i'm not sure it's really needed. I tried poking around in a few other packages, which didn't put any X-stuff in there either. RPM should pick up X as a requirement, due to the build-req on some x-stuff, i think. (?) SPEC: http://antistof.dk/pub/fedora/2/gplanarity.spec SRPM: http://antistof.dk/pub/fedora/2/gplanarity-svn11496-2.fc10.src.rpm Koji-run: https://koji.fedoraproject.org/koji/taskinfo?taskID=953888 #Brennan: co-maintaining the package with you would be nice. Feedback much appreciated. - Adam -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473205] Review Request: gPlanarity - puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473205 --- Comment #1 from Adam Tulinius [EMAIL PROTECTED] 2008-11-26 21:05:05 EDT --- The package has also been through koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=953888 -Adam -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473205] Review Request: gPlanarity - puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473205 Adam Tulinius [EMAIL PROTECTED] changed: What|Removed |Added Blocks||177841 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473205] Review Request: gPlanarity - puzzle game
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=473205
--- Comment #2 from Brennan Ashton [EMAIL PROTECTED] 2008-11-27 02:23:39 EDT
---
A few things that need to be fixed:
* This is a GUI app so:
https://fedoraproject.org/wiki/PackagingGuidelines#Desktop_files
* You need to have the requires in there, wont run with out the X stuff
* Your build root looks odd should be:
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* Just remove #%%configure
And remember to put a change log entry and +1 the release when you submit the
new spec and SRPM
Also if you want I can co-maintain this when you get it approved. Glad I was
able to help you though this one, the first always seems to take forever to
write.
You will still need to wait for a sponsor to come by and do the full review for
you. In the meantime you will need to package at least one more package and do
a review or two, they will not just sponsor you for one package. Feel free to
pull something off the wish list
https://fedoraproject.org/wiki/PackageMaintainers/WishList if you do not have
anything in mind.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
