[Bug 475000] Review Request: cmconvert - CacheMate import file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475000 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added Status|ON_QA |CLOSED Resolution||NEXTRELEASE --- Comment #18 from Fabian Affolter fab...@bernewireless.net 2009-03-19 09:37:24 EDT --- bodhi - 2009-02-16 15:13:22 This update has been pushed to stable -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475000] Review Request: cmconvert - CacheMate import file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475000 --- Comment #19 from Fabian Affolter fab...@bernewireless.net 2009-03-19 09:40:09 EDT --- Thorsten, thanks for the links. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475000] Review Request: cmconvert - CacheMate import file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475000 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #17 from Fedora Update System upda...@fedoraproject.org 2009-01-29 18:05:37 EDT --- cmconvert-1.9.5-5.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update cmconvert'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-1134 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475000] Review Request: cmconvert - CacheMate import file converter
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=475000
Thorsten Leemhuis fed...@leemhuis.info changed:
What|Removed |Added
CC||fed...@leemhuis.info
--- Comment #16 from Thorsten Leemhuis fed...@leemhuis.info 2009-01-27
10:02:05 EDT ---
Fabian,
(In reply to comment #5)
- Use make install DESTDIR=%{buildroot} INSTALL=install -p to preserve the
timestamps instead of make install DESTDIR=%{buildroot}
And specific reasons for that? It's likely unneeded.
This topic recently was discussed on
https://bugzilla.rpmfusion.org/show_bug.cgi?id=195#c9 and
http://lists.rpmfusion.org/pipermail/rpmfusion-developers/2009-January/003546.html
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475000] Review Request: cmconvert - CacheMate import file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475000 --- Comment #12 from Patrick C. F. Ernzer p...@redhat.com 2009-01-26 06:58:23 EDT --- you are right, libexpat gets picked up automatically. fixed, will request CVS in next comment. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475000] Review Request: cmconvert - CacheMate import file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475000 Patrick C. F. Ernzer p...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #13 from Patrick C. F. Ernzer p...@redhat.com 2009-01-26 07:02:33 EDT --- New Package CVS Request === Package Name: cmconvert Short Description: CacheMate import file converter Owners: pcfe Branches: F-10 InitialCC: fab -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475000] Review Request: cmconvert - CacheMate import file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475000 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added Blocks|177841 | --- Comment #14 from Fabian Affolter fab...@bernewireless.net 2009-01-26 07:24:50 EDT --- 'FE-NEEDSPONSOR' removed, you are a member of the packager group. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475000] Review Request: cmconvert - CacheMate import file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475000 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #15 from Kevin Fenzi ke...@tummy.com 2009-01-26 17:18:31 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475000] Review Request: cmconvert - CacheMate import file converter
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=475000
Fabian Affolter fab...@bernewireless.net changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #11 from Fabian Affolter fab...@bernewireless.net 2009-01-24
13:31:16 EDT ---
Package Review
==
Package:
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on: F10/i386
[x] Rpmlint output:
Source RPM:
[...@laptop24 SRPMS]$ rpmlint cmconvert-1.9.5-4.fc10.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Binary RPM(s):
[...@laptop24 i386]$ rpmlint cmconvert*
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
[x] Package is not relocatable.
[x] Buildroot is correct
master : %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XX)
spec file: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XX)
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type: GPLv2+
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
Upstream source: 66db83f66ee4eada22e8b4322acb6aa1
Build source:66db83f66ee4eada22e8b4322acb6aa1
[x] Package is not known to require ExcludeArch.
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly. %find_lang used for locales.
[x] %{optflags} or RPM_OPT_FLAGS are honoured.
[-] ldconfig called in %post and %postun if required.
[x] %install starts with rm -rf %{buildroot} or $RPM_BUILD_ROOT.
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not own files or directories owned by other packages.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly. %defattr(-,root,root,-) is in every
%files section.
[x] Package uses nothing in %doc for runtime.
[x] Package has a %clean section, which contains rm -rf %{buildroot} or
$RPM_BUILD_ROOT.
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[-] Header files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Package does not contain any libtool archives (.la).
[x] -debuginfo subpackage is present and looks complete.
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
=== SUGGESTED ITEMS ===
[x] Timestamps preserved with cp and install.
[x] Uses parallel make (%{?_smp_mflags})
[x] Latest version is packaged.
[-] Package does not include license text files separate from upstream.
[-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: F10/i386
[x] Package should compile and build into binary rpms on all supported
architectures.
Tested: http://koji.fedoraproject.org/koji/taskinfo?taskID=1079811
[x] Package functions as described.
[-] Scriptlets must be sane, if used.
[-] The placement of pkgconfig(.pc) files is correct.
[-] File based requires are sane.
[x] Changelog in allowed format
=== ISSUES ===
'Requires: expat' is not necessary, for me it looks like that rpm pick this
automatically.
After fixing the issue, I see no further blocker, package APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
[Bug 475000] Review Request: cmconvert - CacheMate import file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475000 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|fab...@bernewireless.net Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475000] Review Request: cmconvert - CacheMate import file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475000 --- Comment #10 from Patrick C. F. Ernzer p...@redhat.com 2009-01-16 23:48:23 EDT --- Fabian, (In reply to comment #7) Any progress with the seeking of a sponsor? I have CVS commit rights now. Is 1.9.5-4 good (I will request a CVS module to be created if yes) or does it need more polishing? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475000] Review Request: cmconvert - CacheMate import file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475000 --- Comment #9 from Patrick C. F. Ernzer p...@redhat.com 2009-01-12 10:05:49 EDT --- (In reply to comment #7) Any progress with the seeking of a sponsor? I have been sponsored through another package but am drowning in work things (the usual heap after being 2 weeks on vacation), I hope to get this (and jpilot-backup) pushed in the next 2 weeks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475000] Review Request: cmconvert - CacheMate import file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475000 --- Comment #7 from Fabian Affolter fab...@bernewireless.net 2009-01-09 06:24:55 EDT --- Any progress with the seeking of a sponsor? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475000] Review Request: cmconvert - CacheMate import file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475000 --- Comment #8 from Fabian Affolter fab...@bernewireless.net 2009-01-09 06:27:09 EDT --- https://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475000] Review Request: cmconvert - CacheMate import file converter
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=475000
--- Comment #6 from Patrick C. F. Ernzer p...@redhat.com 2008-12-31 09:45:56
EDT ---
(In reply to comment #5)
rpmlint output
apologies for forgetting to run that. It now reports 0 errors, 0 warnings after
the changes below.
cmconvert.src:38: E: files-attr-not-set
[...]
fixed.
- Is 'mkdir -p -m 0755 %{buildroot}/usr' really needed?
You're right. It is not needed. Removed.
- Use make install DESTDIR=%{buildroot} INSTALL=install -p to preserve the
timestamps instead of make install DESTDIR=%{buildroot}
done
- There is no need to pack the file 'INSTALL' because it contains only generic
information which are not useful when installed from RPM
agreed, removed.
cmconvert-1.9.5-4.fc10.src.rpm and revised spec file uploaded.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475000] Review Request: cmconvert - CacheMate import file converter
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=475000
--- Comment #5 from Fabian Affolter fab...@bernewireless.net 2008-12-20
12:23:23 EDT ---
rpmlint output
[...@laptop024 SRPMS]$ rpmlint cmconvert-1.9.5-3.fc10.src.rpm
cmconvert.src:38: E: files-attr-not-set
1 packages and 0 specfiles checked; 1 errors, 0 warnings.
- Is 'mkdir -p -m 0755 %{buildroot}/usr' really needed?
- Use make install DESTDIR=%{buildroot} INSTALL=install -p to preserve the
timestamps instead of make install DESTDIR=%{buildroot}
- There is no need to pack the file 'INSTALL' because it contains only generic
information which are not useful when installed from RPM
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475000] Review Request: cmconvert - CacheMate import file converter
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=475000
--- Comment #4 from Patrick C. F. Ernzer [EMAIL PROTECTED] 2008-12-10
18:29:17 EDT ---
(In reply to comment #2)
- 'Source0: %{name}-%{version}.tar.gz' should point to the upstream, when
possible.
fixed
- Don't mix $RPM_BUILD_ROOT and %{buildroot}
fixed
(In reply to comment #3)
Link to the comments : https://bugzilla.redhat.com/show_bug.cgi?id=474768
- Release now includes %{dist}
- Added %{?_smp_mflags} to make in the %build section
- BuildRoot fixed
- %defattr fixed
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475000] Review Request: cmconvert - CacheMate import file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475000 --- Comment #3 from Fabian Affolter [EMAIL PROTECTED] 2008-12-08 09:30:18 EDT --- Link to the comments : https://bugzilla.redhat.com/show_bug.cgi?id=474768 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475000] Review Request: cmconvert - CacheMate import file converter
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=475000
Fabian Affolter [EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Comment #2 from Fabian Affolter [EMAIL PROTECTED] 2008-12-08 09:29:21
EDT ---
My comments for this spec file are very similar to the comments in #474768 .
- 'Source0: %{name}-%{version}.tar.gz' should point to the upstream, when
possible.
https://fedoraproject.org/wiki/Packaging/SourceURL
- Don't mix $RPM_BUILD_ROOT and %{buildroot}
https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475000] Review Request: cmconvert - CacheMate import file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475000 Patrick C. F. Ernzer [EMAIL PROTECTED] changed: What|Removed |Added Summary|Review Request: main |Review Request: cmconvert - |package name here - short |CacheMate import file |summary here |converter -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475000] Review Request: cmconvert - CacheMate import file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475000 Jason Tibbitts [EMAIL PROTECTED] changed: What|Removed |Added Blocks||177841 --- Comment #1 from Jason Tibbitts [EMAIL PROTECTED] 2008-12-06 19:13:08 EDT --- You do not seem to be in the packager group, so I'm indicating that you need a sponsor. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
