[Bug 476360] Review Request: rubygem-tlsmail - This library enables pop or smtp via ssl/tls
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476360 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #14 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-01-25 02:57:10 EDT --- Closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476360] Review Request: rubygem-tlsmail - This library enables pop or smtp via ssl/tls
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=476360
Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #10 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-01-16
12:01:33 EDT ---
It seems you reversed the following?
(In reply to comment #2)
For 0.0.1-1:
* Documents
- README.txt should be marked as %doc.
What I mean is that %files should be
%dir %{geminstdir}
%doc %{geminstdir}/[A-Z]*
%{geminstdir}/*/
or so.
Other things are okay.
-
This package (rubygem-tlsmail) is APPROVED by mtasaka
-
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476360] Review Request: rubygem-tlsmail - This library enables pop or smtp via ssl/tls
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=476360
--- Comment #11 from Darryl L. Pierce dpie...@redhat.com 2009-01-16 13:04:12
EDT ---
(In reply to comment #10)
It seems you reversed the following?
(In reply to comment #2)
For 0.0.1-1:
* Documents
- README.txt should be marked as %doc.
What I mean is that %files should be
%dir %{geminstdir}
%doc %{geminstdir}/[A-Z]*
%{geminstdir}/*/
or so.
Other things are okay.
-
This package (rubygem-tlsmail) is APPROVED by mtasaka
-
Thanks. I've changed the RPM per your final suggestions. Thank you, and I'll
begin your review tomorro.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476360] Review Request: rubygem-tlsmail - This library enables pop or smtp via ssl/tls
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476360 Darryl L. Pierce dpie...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #12 from Darryl L. Pierce dpie...@redhat.com 2009-01-16 13:07:33 EDT --- New Package CVS Request === Package Name: rubygem-tlsmail Short Description: This library enables pop or smtp via ssl/tls Owners: mcpierce Branches: F-9 F-10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476360] Review Request: rubygem-tlsmail - This library enables pop or smtp via ssl/tls
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476360 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #13 from Kevin Fenzi ke...@tummy.com 2009-01-16 22:18:34 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476360] Review Request: rubygem-tlsmail - This library enables pop or smtp via ssl/tls
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476360 --- Comment #7 from Darryl L. Pierce dpie...@redhat.com 2009-01-15 10:05:46 EDT --- (In reply to comment #6) Well, there are still many files in binary rpm which have CRLF line terminators as $ rpm -ql rubygem-tlsmail | xargs file | grep CRLF shows (although rpmlint does not seem to be able to detect these) Here's an update with those CRLF issues fixed: Spec URL: http://mcpierce.fedorapeople.org/rpms/rubygem-tlsmail.spec SRPM URL: http://mcpierce.fedorapeople.org/rpms/rubygem-tlsmail-0.0.1-3.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476360] Review Request: rubygem-tlsmail - This library enables pop or smtp via ssl/tls
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=476360
--- Comment #8 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-01-15
12:33:10 EDT ---
Well, sorry for not pointing out before, however:
- now you defined %gemdocsdir, it is better that you use this macro
also on %files
- Also you use %{gemdir}/gems/%{gemname}-%{version}/ in %files, while
%{geminstdir} is also used in %files.
- Now build.log warns about:
---
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/tlsmail-0.0.1/README.txt
---
- In %changelog, please use %% instead of single % (i.e. %%doc, for
example) to aviod macros from being expanded.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476360] Review Request: rubygem-tlsmail - This library enables pop or smtp via ssl/tls
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=476360
--- Comment #9 from Darryl L. Pierce dpie...@redhat.com 2009-01-15 15:09:41
EDT ---
(In reply to comment #8)
Well, sorry for not pointing out before, however:
- now you defined %gemdocsdir, it is better that you use this macro
also on %files
- Also you use %{gemdir}/gems/%{gemname}-%{version}/ in %files, while
%{geminstdir} is also used in %files.
- Now build.log warns about:
---
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/tlsmail-0.0.1/README.txt
---
- In %changelog, please use %% instead of single % (i.e. %%doc, for
example) to aviod macros from being expanded.
The above points have been fixed:
SPEC URL: http://mcpierce.fedorapeople.org/rpms/rubygem-tlsmail.spec
SRPM URL:
http://mcpierce.fedorapeople.org/rpms/rubygem-tlsmail-0.0.1-4.fc10.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476360] Review Request: rubygem-tlsmail - This library enables pop or smtp via ssl/tls
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476360 --- Comment #6 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-01-06 11:33:39 EDT --- Well, there are still many files in binary rpm which have CRLF line terminators as $ rpm -ql rubygem-tlsmail | xargs file | grep CRLF shows (although rpmlint does not seem to be able to detect these) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476360] Review Request: rubygem-tlsmail - This library enables pop or smtp via ssl/tls
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476360 --- Comment #5 from Darryl L. Pierce dpie...@redhat.com 2009-01-05 11:21:45 EDT --- Updated with requested changes: Spec URL: http://mcpierce.fedorapeople.org/rpms/rubygem-tlsmail.spec SRPM URL: http://mcpierce.fedorapeople.org/rpms/rubygem-tlsmail-0.0.1-2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476360] Review Request: rubygem-tlsmail - This library enables pop or smtp via ssl/tls
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476360 --- Comment #4 from Darryl L. Pierce dpie...@redhat.com 2009-01-05 11:00:37 EDT --- (In reply to comment #2) * Possibly duplicate/conflicting files with system ones - This rpm contains net/pop.rb, net/smtp.rb. These are already included in ruby-libs rpm (however the files in ruby-libs seems older than those in this rpm). Can these files safely installed in parallel? That is the point of this gem - it's providing alternatives to those classes in Ruby. But it only overrides them if you explicitly require the tlsmail gem in your code. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476360] Review Request: rubygem-tlsmail - This library enables pop or smtp via ssl/tls
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476360 --- Comment #2 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2008-12-26 09:55:11 EDT --- For 0.0.1-1: * Documents - Would you check if Rakefile or Manifest.txt really needed? - README.txt should be marked as %doc. * Possibly duplicate/conflicting files with system ones - This rpm contains net/pop.rb, net/smtp.rb. These are already included in ruby-libs rpm (however the files in ruby-libs seems older than those in this rpm). Can these files safely installed in parallel? * CRLF line terminators - Some ruby scripts in this rpm have CRLF line terminators (although my rpmlint could not detect them...) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476360] Review Request: rubygem-tlsmail - This library enables pop or smtp via ssl/tls
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476360 --- Comment #3 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2008-12-26 10:02:13 EDT --- Oops.. * ruby abi requirement - Also ruby(abi) requirement is needed. https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476360] Review Request: rubygem-tlsmail - This library enables pop or smtp via ssl/tls
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476360 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp Flag||fedora-review? --- Comment #1 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2008-12-26 02:56:22 EDT --- I will review this. Instead I would appreciate it if you would review my review request for rubygem-nokogiri (bug 477883) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
