[Bug 476374] Review Request: OASA - python library for manipulation of chemical formats
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=476374
--- Comment #8 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2008-12-16
10:11:58 EDT ---
It seems that only fixing %files will be okay.
To Henrique:
Just replacing egg-info entry with
%{python_sitelib}/oasa-%{version}-py*.egg-info
or so will make build succeed.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476374] Review Request: OASA - python library for manipulation of chemical formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476374 --- Comment #7 from Henrique LonelySpooky Junior henrique...@gmail.com 2008-12-16 06:23:17 EDT --- No, Mamoru, I haven't applied yet. I'm doing it right now. Coult you explain, me the problem with %files and how I fix it? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476374] Review Request: OASA - python library for manipulation of chemical formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476374 Jesse Keating jkeat...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Jesse Keating jkeat...@redhat.com 2008-12-15 20:22:52 EDT --- Looks good now, approving. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476374] Review Request: OASA - python library for manipulation of chemical formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476374 --- Comment #5 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2008-12-16 01:05:50 EDT --- At least this won't build on dist-f11 because F-11 uses python 2.6. I will do further check if needed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476374] Review Request: OASA - python library for manipulation of chemical formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476374 --- Comment #6 from Jesse Keating jkeat...@redhat.com 2008-12-16 02:31:56 EDT --- Actually I did the test build in a chroot of rawhide (f11). Ahh, it looks like when you changed the package name, you didn't adjust the %files section since the python module name did not change: /builddir/build/BUILDROOT/python-oasa-0.12.5-1.fc11.i386/usr/lib/python2.6/site-packages/oasa-0.12.5-py2.5.egg-info That should be a simple fix. Unfortunately I just noticed that Henrique is in need of a sponsor. Henrique, have you applied for packager membership yet? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476374] Review Request: OASA - python library for manipulation of chemical formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476374 Jesse Keating jkeat...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||jkeat...@redhat.com AssignedTo|nob...@fedoraproject.org|jkeat...@redhat.com Flag||fedora-review? --- Comment #1 from Jesse Keating jkeat...@redhat.com 2008-12-13 16:08:01 EDT --- Taking review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476374] Review Request: OASA - python library for manipulation of chemical formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476374 Jesse Keating jkeat...@redhat.com changed: What|Removed |Added Flag||needinfo?(henrique...@gmail ||.com) --- Comment #2 from Jesse Keating jkeat...@redhat.com 2008-12-13 16:20:42 EDT --- * Python defines correct * Name not correct. This is a python module, and should be named python-oasa. http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Addon_Packages_.28python_modules.29 * Licensing not correct. Header files have 'or any later version' in them, therefore license should be GPLV2+ oasa/elements.py - No license header oasa/subsearch_data.py - No license header oasa/tests.py - No license header oasa/graph/multi_thread.py - No license header * Summary could drop the OASA is a * URL is OK * Source matches upstream * Buildroot fine * Requires on python is redundant, don't put that in. * Description is OKish. * Consistent macro usage * Correct cleaning at %install * Good %clean section * defatters in %files * %files is a bit broad. I'd rather see something more like http://fedoraproject.org/wiki/Packaging/Python#Byte_Compiled_Files * changelog should have a revision listed. * rpmlint output: oasa.noarch: W: no-documentation oasa.noarch: E: description-line-too-long OASA is a free python library for manipulating and analyzing chemical structures. oasa.noarch: W: incoherent-version-in-changelog 0.12.5 ['0.12.5-1.fc11', '0.12.5-1'] oasa.src: W: mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line 3) ** SUMMARY ** Fix license, report unlicensed files to upstream Fix name Fix summary Fix Requires Potentially fix %files Fix rpmlint output -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476374] Review Request: OASA - python library for manipulation of chemical formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476374 Henrique LonelySpooky Junior henrique...@gmail.com changed: What|Removed |Added Flag|needinfo?(henrique...@gmail | |.com) | --- Comment #3 from Henrique LonelySpooky Junior henrique...@gmail.com 2008-12-13 18:08:42 EDT --- Hello, Jesse, thanks for reviewing the package. * Fix license, report unlicensed files to upstream - DONE and I already warned Beda about the files without license. * Fix name - DONE * Fix summary - DONE * Fix Requires - DONE * Potentially fix %files - I still have little experience in packaging, I hope I have done correctly this time. * Fix rpmlint output - rpmlint is no longer showing any errors. SPEC - http://lspooky.fedorapeople.org/oasa/0.12.5/python-oasa.spec SRPM - http://lspooky.fedorapeople.org/oasa/0.12.5/python-oasa-0.12.5-1.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476374] Review Request: OASA - python library for manipulation of chemical formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476374 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added CC||mtas...@ioa.s.u-tokyo.ac.jp Blocks||177841, 452413 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
