[Bug 479978] Review Request: libnewmat - Newmat C++ matrix library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479978 Denis Arnaud denis.arnaud_fed...@m4x.org changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479978] Review Request: libnewmat - Newmat C++ matrix library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=479978
--- Comment #6 from Denis Arnaud denis.arnaud_fed...@m4x.org 2009-06-13
11:39:01 EDT ---
Note that I am not a sponsor. However, I have quickly reviewed your package
(https://fedoraproject.org/wiki/Packaging/ReviewGuidelines) and fixed the
warnings of rpmlint. The corresponding new specification file and source RPM
are to be found here:
-
Spec URL: http://denisarnaud.fedorapeople.org/newmat/11/1/newmat.spec
SRPM URL:
http://denisarnaud.fedorapeople.org/newmat/11/1/newmat-11-1.fc10.src.rpm
-
and it builds nicely on all architectures:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1409984
So, following are a few points, in no particular order, that I have fixed in my
version of the specification file (and with the patch):
0. I have renamed the package from 'libnewmat' into 'newmat', as it matches
upstream naming (http://www.robertnz.net/ftp/newmat11.tar.gz). See
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#General_Naming for
further details.
1. License. Please have a look at
https://fedoraproject.org/wiki/Packaging/LicensingGuidelines and
http://fedoraproject.org/wiki/Licensing#SoftwareLicenses . For instance,
Public Use does not exist. In my version of the spec file, I have used
Public Domain, which is acceptable for Fedora. However, it would be better to
contact upstream (robert at statsresearch.co.nz), in order to clarify the
license issue and potentially explicitly add a license file, if so intended.
2. Use of the exit() function in the upstream code (myexcept.cpp). 'rpmlint
-i' states:
newmat.x86_64: W: shared-lib-calls-exit /usr/lib64/libnewmat.so.11.1
e...@glibc_2.2.5
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the
situation.
I have thus written a patch
(http://denisarnaud.fedorapeople.org/newmat/11/1/newmat-11-fix-exit-issue.patch)
fixing that issue. That patch should be submitted/proposed upstream (as I have
just coded a work-around, which upstream may not find appropriate).
3. Dynamic library. Usually, the library is set to be executable when
installed:
install -p -D -m 0755 lib/lib%{name}.so
%{buildroot}%{_libdir}/lib%{name}.so.%{version}
where %{version} is the full version (e.g., '11.1')
--
If you agree with the above, and you contact upstream for the corresponding
issues (license, exit() function), and if upstream is fine with the license
(Public Domain), I shall approve that package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479978] Review Request: libnewmat - Newmat C++ matrix library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479978 --- Comment #5 from Pascal pascal...@parois.net 2009-02-06 16:09:26 EDT --- I corrected the soname name New srpm: http://fedora.debroglie.net/SRPMS/10/libnewmat-10D-2.fc10.debroglie.src.rpm New spec: http://svn.debroglie.net/specs/trunk/libnewmat.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479978] Review Request: libnewmat - Newmat C++ matrix library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479978 --- Comment #3 from Michael Schwendt bugs.mich...@gmx.net 2009-01-27 09:04:13 EDT --- -shared -Wl,-soname,libnewmat.so.10.4 ln -s libnewmat.so.10.4 libnewmat.so.10 Are you sure you didn't want the soname to be libnewmat.so.10? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479978] Review Request: libnewmat - Newmat C++ matrix library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479978 --- Comment #4 from Pascal pascal...@parois.net 2009-01-27 09:35:05 EDT --- You are right, it's a mistake. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479978] Review Request: libnewmat - Newmat C++ matrix library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479978 manuel wolfshant wo...@nobugconsulting.ro changed: What|Removed |Added Alias||libnewmat -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479978] Review Request: libnewmat - Newmat C++ matrix library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479978 manuel wolfshant wo...@nobugconsulting.ro changed: What|Removed |Added Blocks||482757 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479978] Review Request: libnewmat - Newmat C++ matrix library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479978 --- Comment #1 from Pascal pascal...@parois.net 2009-01-23 06:26:25 EDT --- Sorry guys, I broke my webserver, files are no longer available at the moment. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479978] Review Request: libnewmat - Newmat C++ matrix library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479978 --- Comment #2 from Pascal pascal...@parois.net 2009-01-23 12:35:25 EDT --- Fixed, file are available again. This library is going to be used by the next package I am going to submit. I am waiting for a new release upstream to submit it (http://vincefn.net/Fox/). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479978] Review Request: libnewmat - Newmat C++ matrix library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479978 manuel wolfshant wo...@nobugconsulting.ro changed: What|Removed |Added Blocks||177841 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
