[Bug 480037] Review Request: cups-pk-helper - PolicyKit support for system-config-printer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480037 Matthias Clasen mcla...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480037] Review Request: cups-pk-helper - PolicyKit support for system-config-printer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480037 --- Comment #10 from Marek Kašík mka...@redhat.com 2009-01-20 08:49:59 EDT --- Hi, I committed this package to CVS and I built it. Marek -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480037] Review Request: cups-pk-helper - PolicyKit support for system-config-printer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480037 Marek Kašík mka...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Marek Kašík mka...@redhat.com 2009-01-19 05:59:57 EDT --- New Package CVS Request === Package Name: cups-pk-helper Short Description: A helper that makes system-config-printer use PolicyKit Owners: mkasik Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480037] Review Request: cups-pk-helper - PolicyKit support for system-config-printer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480037 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Status|NEW |ASSIGNED Flag|fedora-cvs? |fedora-cvs+ --- Comment #9 from Kevin Fenzi ke...@tummy.com 2009-01-19 17:56:15 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480037] Review Request: cups-pk-helper - PolicyKit support for system-config-printer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480037 --- Comment #6 from Marek Kašík mka...@redhat.com 2009-01-15 09:11:45 EDT --- Hi, thank you for comments. I modified the package according to your comments and I uploaded it to the same location (the same addresses). Original versions are stored in http://mkasik.fedorapeople.org/old/;. Regards Marek P.S.: I had to modify also the scp-policykit.patch patch in http://mkasik.fedorapeople.org/system-config-printer-1.1.1-3.*.src.rpm. I forget to remove one line from the patch. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480037] Review Request: cups-pk-helper - PolicyKit support for system-config-printer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480037 Matthias Clasen mcla...@redhat.com changed: What|Removed |Added Flag||fedora-review+ --- Comment #7 from Matthias Clasen mcla...@redhat.com 2009-01-15 09:39:13 EDT --- Looks fine now. Approved -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480037] Review Request: cups-pk-helper - PolicyKit support for system-config-printer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480037 Marek Kašík mka...@redhat.com changed: What|Removed |Added CC||mcla...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480037] Review Request: cups-pk-helper - PolicyKit support for system-config-printer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480037 Matthias Clasen mcla...@redhat.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|mcla...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480037] Review Request: cups-pk-helper - PolicyKit support for system-config-printer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480037 --- Comment #1 from Matthias Clasen mcla...@redhat.com 2009-01-14 12:40:27 EDT --- Builds fine in mock. rpmlint says: cups-pk-helper.i386: W: no-documentation cups-pk-helper.i386: W: non-conffile-in-etc /etc/dbus-1/system.d/org.opensuse.CupsPkHelper.Mechanism.conf cups-pk-helper.i386: E: description-line-too-long cups-pk-helper is an application, which helps system-config-printer to use PolicyKit infrastructure The warnings are ignorable, the line-too-long error should be fixed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480037] Review Request: cups-pk-helper - PolicyKit support for system-config-printer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480037 --- Comment #2 from Matthias Clasen mcla...@redhat.com 2009-01-14 12:45:19 EDT --- Here are my proposals for Summary / Description: Summary: A helper that makes system-config-printer use PolicyKit %description cups-pk-helper is an application which makes cups configuration interfaces available under control of PolicyKit. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480037] Review Request: cups-pk-helper - PolicyKit support for system-config-printer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480037 --- Comment #3 from Jochen Schmitt joc...@herr-schmitt.de 2009-01-14 13:26:21 EDT --- Good + Package naming fits with naming guidelines + Basename of SPEC file matches with package name + License tag contains valid license + License GPLv2 is a valid OSS license + Local build works fine + Could download tar ball with spectool + Tar ball in source rpm matches with upstream (md5sum: db1c91dcb3c9f7ef3270fe29c25178a4) + Consistently use of rpm macros + Buildroot will be clean on begin of %install and %clean + Local build works fine + Rpmlint doens't complaints debuginfo rpm + Local install works fine + Local uninstall wworks fine + Package contains no subpcakges + Build works fine on koji + Pakcage contains no files belong to others + Files Permissions looks right + Package contains valid %changelog stanza Bad: - Rpmlint complaints source rpm: cups-pk-helper.src: E: description-line-too-long cups-pk-helper is an application, which helps system-config-printer to use PolicyKit infrastructure - Rpmlint complaints binary rpm: cups-pk-helper.x86_64: W: no-documentation cups-pk-helper.x86_64: W: non-conffile-in-etc /etc/dbus-1/system.d/org.opensuse.CupsPkHelper.Mechanism.conf cups-pk-helper.x86_64: E: description-line-too-long cups-pk-helper is an application, which helps system-config-printer to use PolicyKit infrastructure - License tag should be GPLv2+, because the copyright notes in the source files aloow use of later versions of the GPL. - Verbatin copy of the license text is not included in the rpm, but available in the original source tree. - %doc stanza contains no files question: * Can I run a test without a printer. Is there a text plan for this package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480037] Review Request: cups-pk-helper - PolicyKit support for system-config-printer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480037 --- Comment #4 from Matthias Clasen mcla...@redhat.com 2009-01-14 14:09:19 EDT --- Formal review: rpmlint: see above package name: ok spec file name: ok packaging guidelines: - Looks to me like the dbus-glib and PolicyKit requires are redundant, since they are already pulled in by library dependencies - should include AUTHORS and NEWS as %doc license: ok license field: should be GPLv2+ (note the +), since the source files say or any later version license file: must be included spec file language: ok spec file legible: ok upstream sources: ok buildable: ok excludearch: ok build deps: ok locale handling: ok shared libraries: ok relocatable: not applicable directory ownership: ok duplicate files: ok permissions: ok %clean: ok macro use: ok permissible content: ok large docs: ok %doc content: ok header files: ok static libs: ok pkgconfig files: ok shared libs: ok devel package: not applicable libtool archives: ok desktop files: not applicable file ownership: ok %install: ok utf8 filenames: ok summary: - fix summary/description - fix license tag - include license file - remove redundant requires - include %doc files -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480037] Review Request: cups-pk-helper - PolicyKit support for system-config-printer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480037 --- Comment #5 from Matthias Clasen mcla...@redhat.com 2009-01-14 14:26:37 EDT --- Jochen, testing this requires a patched system-config-printer that we don't have yet. See https://fedoraproject.org/wiki/Features/CupsPolicyKitIntegration -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
