[Bug 480886] Review Request: tse3 - MIDI Sequencer Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480886
Michael Schwendt bugs.mich...@gmx.net changed:
What|Removed |Added
CC||bugs.mich...@gmx.net
--- Comment #10 from Michael Schwendt bugs.mich...@gmx.net 2009-01-27
08:26:42 EDT ---
Requires: %{name} == %{version}-%{release}
Does that work?
%install
make install DESTDIR=%{buildroot} INSTALL=install -p \
rm -rf %{buildroot} is missing as the first cmd in %install section.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480886] Review Request: tse3 - MIDI Sequencer Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480886
--- Comment #11 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-01-27
09:00:38 EDT ---
(In reply to comment #10)
Requires: %{name} == %{version}-%{release}
Does that work?
Yes (at least on F-9/10/11)
%install
make install DESTDIR=%{buildroot} INSTALL=install -p \
rm -rf %{buildroot} is missing as the first cmd in %install section.
Sorry for not pointing this out...
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480886] Review Request: tse3 - MIDI Sequencer Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480886 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #12 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-01-27 12:07:05 EDT --- Closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480886] Review Request: tse3 - MIDI Sequencer Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480886
--- Comment #13 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-01-27
13:05:41 EDT ---
(In reply to comment #11)
(In reply to comment #10)
%install
make install DESTDIR=%{buildroot} INSTALL=install -p \
rm -rf %{buildroot} is missing as the first cmd in %install section.
Sorry for not pointing this out...
No problem. I missed this as much as you did. But this is weird because rpmlint
normally warns us if one of the rm -rf %{buildroot} is missing (one in
%install, one in %clean). Maybe we hit an rpmlint bug.
I'm revoking my requests for pushing to F-9 and F-10 update-testing and
rebuilding.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480886] Review Request: tse3 - MIDI Sequencer Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480886 --- Comment #5 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-01-26 12:27:05 EDT --- Please provide srpm, not binary rpm :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480886] Review Request: tse3 - MIDI Sequencer Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480886 --- Comment #6 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-01-26 12:40:55 EDT --- Uh oh. Sorry, my bad! I uploaded the appropriate SRPM file to the same place. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480886] Review Request: tse3 - MIDI Sequencer Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480886 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp Flag||fedora-review+ --- Comment #7 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-01-26 13:10:35 EDT --- Okay, good. - This package (tse3) is APPROVED by mtasaka - -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480886] Review Request: tse3 - MIDI Sequencer Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480886 Orcan 'oget' Ogetbil oget.fed...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-01-26 13:19:05 EDT --- Great. Thanks! New Package CVS Request === Package Name: tse3 Short Description: MIDI Sequencer Engine Owners: oget Branches: F-9 F-10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480886] Review Request: tse3 - MIDI Sequencer Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480886 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #9 from Kevin Fenzi ke...@tummy.com 2009-01-26 17:20:27 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480886] Review Request: tse3 - MIDI Sequencer Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480886
--- Comment #1 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-01-25
14:46:43 EDT ---
Created an attachment (id=329952)
-- (https://bugzilla.redhat.com/attachment.cgi?id=329952)
some trial patch
For 0.3.1-1:
* About Patch2:
- Well, google shows that awe_voice.h was removed from
kernel headers at 2.6.21 or so (i.e. around Fedora 7)
I don't think it is preferrable to re-introduce macros
which was defined in the header file which is no longer
supported. I guess kernel supports AWE32 in other way
or kernel does not support AWE32 completely any more.
Are macros related to awe_voice.h really needed even
now?
(removing all awe32 related parts like attached does not help ?
I just tried to remove all awe_voice.h related parts
and did not any functionality check as I don't know
how to use this software...)
* Timestamps
- Please consider to use
---
make install DESTDIR=%{buildroot} INSTALL=install -p
---
to keep timestamps on installed files.
* Directory structure about document files
- For HTML files in devel package, I suggest that a subdirectory
should be created under %_defaultdocdir/%name-devel-%version
(named as HTML, for example) and all HTML files should be
moved into the directory.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480886] Review Request: tse3 - MIDI Sequencer Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480886 --- Comment #2 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-01-25 15:12:41 EDT --- Thank you. (In reply to comment #1) * About Patch2: - Well, google shows that awe_voice.h was removed from kernel headers at 2.6.21 or so (i.e. around Fedora 7) I don't think it is preferrable to re-introduce macros which was defined in the header file which is no longer supported. I guess kernel supports AWE32 in other way or kernel does not support AWE32 completely any more. Are macros related to awe_voice.h really needed even now? (removing all awe32 related parts like attached does not help ? I just tried to remove all awe_voice.h related parts and did not any functionality check as I don't know how to use this software...) Thanks for the patch. It seems like you are right. But now I am thinking of dropping the OSS support from tse3 altogether. I see other applications/libraries in Fedora built with --without-oss flag. - It will save us some dependencies, - I am not sure how functional the library will be after this patch, and - OSS is deprecated, so we won't loose much. Does that sound OK? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480886] Review Request: tse3 - MIDI Sequencer Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480886 --- Comment #3 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-01-25 15:26:53 EDT --- I think removing OSS support should be okay on Fedora. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480886] Review Request: tse3 - MIDI Sequencer Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480886 --- Comment #4 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-01-25 15:52:47 EDT --- Update: Spec URL: http://oget.fedorapeople.org/review/tse3.spec SRPM URL: http://oget.fedorapeople.org/review/tse3-0.3.1-2.fc10.src.rpm Changelog: - Move the HTML documentation into an HTML subdirectory - Use INSTALL=install -p - Drop the oss support, and the related patch -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480886] Review Request: tse3 - MIDI Sequencer Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480886 Orcan 'oget' Ogetbil oget.fed...@gmail.com changed: What|Removed |Added Blocks||480887 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
