[Bug 481004] Review Request: pg_top - top for postgresql
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481004 Itamar Reis Peixoto ita...@ispbrasil.com.br changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #9 from Itamar Reis Peixoto ita...@ispbrasil.com.br 2009-09-25 13:37:21 EDT --- last time (redir), the cvs admin forget EL-4 asking both, EL-4 and EL-5 for pg_top Package Change Request == Package Name: pg_top New Branches: EL-4 EL-5 Owners: itamarjp -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481004] Review Request: pg_top - top for postgresql
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481004 --- Comment #11 from Kevin Fenzi ke...@tummy.com 2009-09-25 13:48:51 EDT --- Sorry about that on redir, should be fixed now. I didn't 'forget' it, it was a typo. ;( cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481004] Review Request: pg_top - top for postgresql
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481004 --- Comment #10 from Itamar Reis Peixoto ita...@ispbrasil.com.br 2009-09-25 13:48:02 EDT --- last time (redir), the cvs admin forget EL-4 asking both, EL-4 and EL-5 for pg_top Package Change Request == Package Name: pg_top New Branches: EL-4 EL-5 Owners: itamarjp atorkhov -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481004] Review Request: pg_top - top for postgresql
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481004 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481004] Review Request: pg_top - top for postgresql
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481004 --- Comment #12 from Itamar Reis Peixoto ita...@ispbrasil.com.br 2009-09-25 13:50:09 EDT --- thanks, -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481004] Review Request: pg_top - top for postgresql
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481004 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||3.6.2-3.fc10 Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481004] Review Request: pg_top - top for postgresql
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481004 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2009-03-05 11:28:27 EDT --- pg_top-3.6.2-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481004] Review Request: pg_top - top for postgresql
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481004 --- Comment #7 from Tom spot Callaway tcall...@redhat.com 2009-03-04 17:29:49 EDT --- Please go ahead and push this into stable. No one is going to test a brand new package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481004] Review Request: pg_top - top for postgresql
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481004 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2009-01-26 20:52:20 EDT --- pg_top-3.6.2-3.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pg_top'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-1006 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481004] Review Request: pg_top - top for postgresql
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481004 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #5 from Kevin Fenzi ke...@tummy.com 2009-01-23 18:33:47 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481004] Review Request: pg_top - top for postgresql
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481004 Itamar Reis Peixoto ita...@ispbrasil.com.br changed: What|Removed |Added Alias||pg_top -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481004] Review Request: pg_top - top for postgresql
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481004
Tom spot Callaway tcall...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||tcall...@redhat.com
AssignedTo|nob...@fedoraproject.org|tcall...@redhat.com
Flag||fedora-review?
--- Comment #1 from Tom spot Callaway tcall...@redhat.com 2009-01-21
14:12:59 EDT ---
Review
===
Good:
- rpmlint checks return nothing
- package meets naming guidelines
- package meets packaging guidelines
- license (BSD) OK, matches source
- spec file legible, in am. english
- source matches upstream (338bc398ace91a05af769f6b555cce89ba997fbe)
- package compiles on devel (x86_64)
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- %clean ok
- macro use consistent
- code, not content
- no need for .desktop file
Bad:
* Package is not using %{optflags} during compilation.
* There is no packaged documentation aside from the manpage
* The license text is not packaged as %doc
* %defattr(-,root,root) is used instead of %defattr(-,root,root,-)
* Patch1 is completely pointless.
* Missing BuildRequires: elfutils-libelf-devel
Please fix these issues and show a new SRPM.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481004] Review Request: pg_top - top for postgresql
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481004 --- Comment #2 from Itamar Reis Peixoto ita...@ispbrasil.com.br 2009-01-21 15:26:06 EDT --- done. http://ispbrasil.com.br/pg_top/pg_top.spec http://ispbrasil.com.br/pg_top/pg_top-3.6.2-3.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481004] Review Request: pg_top - top for postgresql
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481004 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Tom spot Callaway tcall...@redhat.com 2009-01-21 15:52:21 EDT --- Looks good, approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481004] Review Request: pg_top - top for postgresql
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481004 Itamar Reis Peixoto ita...@ispbrasil.com.br changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Itamar Reis Peixoto ita...@ispbrasil.com.br 2009-01-21 16:00:26 EDT --- New Package CVS Request === Package Name: pg_top Short Description: pg_top is 'top' for PostgreSQL processes Owners: itamarjp Branches: F-10 F-9 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
