[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||1.41-13.fc10 Resolution|RAWHIDE |NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 --- Comment #36 from Fedora Update System upda...@fedoraproject.org 2009-03-18 15:06:26 EDT --- pdftk-1.41-13.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 --- Comment #34 from Jochen Schmitt joc...@herr-schmitt.de 2009-03-15 15:50:20 EDT --- @Orcan, thank you for your help. Unfortunately, bodhi let not allow me to mark the pacage as stable, if the update was pushed by a comaintainer. So it may be nice, if you can take over this task. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 --- Comment #35 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-03-16 01:13:09 EDT --- I just pushed itext to stable. We (you or me) should be able to push pdftk to stable as soon as it is in the testing repo. It should be in there in a day or two. Do you want me to revoke my testing request? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 --- Comment #32 from Fedora Update System upda...@fedoraproject.org 2009-03-14 11:57:33 EDT --- pdftk-1.41-13.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/pdftk-1.41-13.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 Orcan 'oget' Ogetbil oget.fed...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #33 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-03-14 11:59:40 EDT --- I built pdftk for devel and for F-10-testing. Closing the bug. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #31 from Kevin Fenzi ke...@tummy.com 2009-03-12 22:45:12 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 Jochen Schmitt joc...@herr-schmitt.de changed: What|Removed |Added Flag||fedora_requires_release_not ||e? --- Comment #29 from Jochen Schmitt joc...@herr-schmitt.de 2009-03-11 12:15:50 EDT --- New Package CVS Request === Package Name: pdftk Short Description: the PDF Toolkit Owners: s4504kr, oget Branches: F-10 InitialCC: Attention: This is the resurrection of a retiered package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 Orcan 'oget' Ogetbil oget.fed...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #30 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-03-11 14:16:44 EDT --- I'm setting the fedora-cvs flag to ?. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 --- Comment #24 from Jochen Schmitt joc...@herr-schmitt.de 2009-03-10 12:34:27 EDT --- Because iText-2.1.5 was released, I have updated the iText package and the pdftk package for this new release. New release: Spec URL: http://www.herr-schmitt.de/pub/pdftk/pdftk.spec SRPM URL: http://www.herr-schmitt.de/pub/pdftk/pdftk-1.41-13.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 Orcan 'oget' Ogetbil oget.fed...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|oget.fed...@gmail.com Flag||fedora-review+ --- Comment #25 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-03-10 17:00:44 EDT --- Since we got no objections, I'm approving the package. We should keep an eye on that gcc bug Andrew submitted. Jochen, do we want pdftk on F-9 or F-10? How shall we handle this? This package (pdftk) is APPROVED by oget -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 --- Comment #26 from Jochen Schmitt joc...@herr-schmitt.de 2009-03-10 17:05:29 EDT --- I want to try getting pdftk into F-10 and F-9 if possible. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 --- Comment #27 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-03-10 17:18:22 EDT --- I am fine with F-10. Do you want to update itext yourself or should I do it? Meanwhile for F-9, it is a little bit of a problem. itext (and many of its dependencies) is not available on that branch. You can take over the F-9 branch if you want. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 --- Comment #28 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-03-10 23:52:45 EDT --- I just did the itext update on F-10 and submitted it to testing. You'll need to file a ticket to releng to tag it in the buildroot for building pdftk. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 --- Comment #21 from Tom Davidson t...@mit.edu 2009-03-06 11:46:05 EDT --- Sorry, wrong URL there, I meant that I was able to install the F11 itext binary package on F10: ftp://fr.rpmfind.net/linux/fedora/development/i386/os/Packages/itext-2.1.4-5.fc11.i586.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 --- Comment #22 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-03-06 20:24:19 EDT --- Tom, can you test and see if pdftk works the way you want it? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 --- Comment #23 from Tom Davidson t...@mit.edu 2009-03-06 21:38:55 EDT --- Yes, after rebuilding it myself as described above, i.e.: $ wget ftp://fr.rpmfind.net/linux/fedora/development/i386/os/Packages/itext-2.1.4-5.fc11.i586.rpm $ wget http://www.herr-schmitt.de/pub/pdftk/pdftk-1.41-12.fc11.src.rpm $ sudo yum install java-1.6.0-openjdk-devel $ sudo yum localinstall itext-2.1.4-5.fc11.i586.rpm --nogpgcheck $ rpmbuild --rebuild pdftk-1.41-12.fc11.src.rpm $ sudo yum localinstall ~/rpmbuild/RPMS/i386/pdftk-1.41-12.fc10.i386.rpm ...I can merge pdfs using pdftk. I Haven't really stress-tested it, but so far no problems. (In particular pdftk has better handling of colorspaces than pdfmerge, which seems to just call ghostscript) Thanks! Tom -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 --- Comment #12 from Andrew Haley a...@redhat.com 2009-03-05 04:58:37 EDT --- I created a new bugzilla entry for the gcc bug mentioned above. It's http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39380 We should be able to get a patched gcc fairly soon. In the meantime we'll have to build the C++ components of pdftk with -O0. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 --- Comment #13 from Jochen Schmitt joc...@herr-schmitt.de 2009-03-05 13:50:33 EDT --- New release: Spec URL: http://www.herr-schmitt.de/pub/pdftk/pdftk.spec SRPM URL: http://www.herr-schmitt.de/pub/pdftk/pdftk-1.41-10.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=485641
--- Comment #14 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-03-05
14:10:17 EDT ---
Great, there is one thing we missed: We need to replace both
/usr/share/java
%{_datadir}/java
with the system macro
%{_javadir}
Other than this, I confirm that our pdftk does the basic tasks. But we removed
some of its code (they are marked in pdftk-use-internal-itext.patch as //
Absent from itext-2.1.4 ). What kind of regressions does this removal bring?
Jochen, did you run any tests on our version of pdftk?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=485641
--- Comment #15 from Jochen Schmitt joc...@herr-schmitt.de 2009-03-05
14:44:44 EDT ---
New release:
Spec URL: http://www.herr-schmitt.de/pub/pdftk/pdftk.spec
SRPM URL: http://www.herr-schmitt.de/pub/pdftk/pdftk-1.41-10.fc11.src.rpm
I have done the %{_javadir] stuff. In addtional I have done some basic testing
without issues. Unfortunately, I didn't have a password protected pdf file for
some special tests.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 --- Comment #16 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-03-05 15:09:13 EDT --- Thanks. But -O0 is not being passed to the compiler. Can you fix this? Andrew, shall we approve this package now, or shall we wait for the gcc bug to be fixed. What do you think? For the missing features, I would say, let's see if there are any complaints from users. If no one is using these features, we do not need to re-introduce them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 --- Comment #17 from Jochen Schmitt joc...@herr-schmitt.de 2009-03-05 15:38:10 EDT --- New release: Spec URL: http://www.herr-schmitt.de/pub/pdftk/pdftk.spec SRPM URL: http://www.herr-schmitt.de/pub/pdftk/pdftk-1.41-12.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 Tom Davidson t...@mit.edu changed: What|Removed |Added CC||t...@mit.edu --- Comment #18 from Tom Davidson t...@mit.edu 2009-03-05 19:34:50 EDT --- Hello, Somewhere in this thread, Jochen switched from building for fc10 to fc11 (at least according to the filename). When I try to 'rpmbuild --rebuild' the latest src.rpm on my F10 system, I get an error telling me that my java-devel needs to be 1:1.6.0. The previous src.rpm versions are no longer available, so I can't attest that this used to work. Was this change intentional? Will the package be released for F10 after review? Thanks much! Tom -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 --- Comment #10 from Andrew Haley a...@redhat.com 2009-03-04 04:49:05 EDT --- OK, I'm on it. In the meantime, is there any plan to patch itext to provide the entry points used by pdftk? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 --- Comment #11 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-03-04 10:57:04 EDT --- There is a question rather than a plan for now: Do we really need to? I can do basic operations with pdftk. It just works. I don't know what that code that we removed does. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=485641
--- Comment #9 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-03-03
22:52:31 EDT ---
* We still have the rpmlint:
pdftk.src: W: mixed-use-of-spaces-and-tabs (spaces: line 27, tab: line 1)
* To fix the dependency you can add this to the end of the %install section:
-
# Fix the weird dependency, e.g.
# /usr/lib64/gcj/itext/itext-x.y.z.jar.so()(64bit) to
# /usr/lib64/gcj/itext/itext-x.y.z.jar.so
%define _use_internal_dependency_generator 0
cat \EOF %{name}.req
#!%{_buildshell}
grep -v %{_docdir} - | %{__find_requires} $* \
| sed 's...@\(itext-[0-9.]*\.jar\.so\)\(()(64bit)\)\...@\1@'
EOF
%define __find_requires %{_builddir}/%{name}-%{version}/%{name}.req
chmod +x %{__find_requires}
-
Note that you will need to remove
Requires: %{_libdir}/gcj/itext/itext-2.1.4.jar.so
now. Also not that this won't break anything in 32bit systems. I am rebuilding
itext with proper provides now.
* Unfortunately, we have a bigger issue. pdftk fails to compile with gcc44:
-
/usr/lib/gcc/x86_64-redhat-linux/4.4.0/../../../../include/c++/4.4.0/ostream:514:
instantiated from 'std::basic_ostreamchar, _Traits
std::operator(std::basic_ostreamchar, _Traits, const char*) [with _Traits
= std::char_traitschar]'
pdftk.cc:119: instantiated from here
/usr/lib/gcc/x86_64-redhat-linux/4.4.0/../../../../include/c++/4.4.0/bits/ostream_insert.h:107:
error: mixing C++ and Java catches in a single translation unit
-
I don't know (yet) how to solve this. Andrew?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 --- Comment #8 from Jochen Schmitt joc...@herr-schmitt.de 2009-03-02 12:21:47 EDT --- New release: Spec URL: http://www.herr-schmitt.de/pub/pdftk/pdftk.spec SRPM URL: http://www.herr-schmitt.de/pub/pdftk/pdftk-1.41-9.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 --- Comment #6 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-02-28 17:47:58 EDT --- As noted, in the devel ML: http://osdir.com/ml/fedora-devel-list/2009-02/msg01692.html it is pdftk that has the wrong Requires. 'The dependency should either be: itext-2.1.4.jar.so()(64bit) or then for the actual file: /usr/lib64/gcj/itext/itext-2.1.4.jar.so' Right now the dependency is /usr/lib64/gcj/itext/itext-2.1.4.jar.so()(64bit) which is meaningless. So shall we work around the automatic dependency generation of pdftk? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 --- Comment #7 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-02-28 17:51:51 EDT --- Well, since both solutions (1- adding the meaningless Provides on itext and 2- hacking the dependencies of pdftk) are both workarounds and not actual solutions, I'm leaving it to Jochen to decide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 --- Comment #4 from Jochen Schmitt joc...@herr-schmitt.de 2009-02-19 14:12:30 EDT --- New Release: Spec URL: http://www.herr-schmitt.de/pub/pdftk/pdftk.spec SRPM URL: http://www.herr-schmitt.de/pub/pdftk/pdftk-1.41-7.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=485641
--- Comment #5 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-02-19
16:09:49 EDT ---
Finally, we can review this package :)
Here are my notes:
* rpmlint says
pdftk.src: W: mixed-use-of-spaces-and-tabs (spaces: line 30, tab: line 1)
pdftk.src: W: patch-not-applied Patch0: pdftk-1.41-rpmopt.patch
pdftk.src: W: patch-not-applied Patch1: pdftk-1.41-system-libgcj.patch
pdftk.src: W: patch-not-applied Patch2: pdftk-1.41-gcjh.patch
- We can get rid of those patches that are commented out. We will not need
them anymore.
- The mixed spaces/tabs is easy to fix.
* The package needs
BuildRequires: java-devel = 1:1.6.0
otherwise, it will not build with mock.
* rm -rf java_libs/gnu_local java_libs/java_local java_libs/gnu
can be replaced with just
rm -rf java_libs
* The guidelines say: If (and only if) the source package includes the text of
the license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
So I think, we should remove Source1.
* %defattr(-,root,root,-) is preferred.
* There is a convenient %{_javadir} macro. You can replace the instances of
/usr/share/java
%{_datadir}/java
with
%{_javadir}
Sorry, this one is my bad. I should have told you this properly before.
* Parallel make must be supported whenever possible. If it is not supported,
this should be noted in the SPEC file as a comment.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 Andrew Haley a...@redhat.com changed: What|Removed |Added CC||a...@redhat.com --- Comment #2 from Andrew Haley a...@redhat.com 2009-02-16 04:35:14 EDT --- Yes, this must be caused by automatic dependency generation in RPM. I suppose the best thing usually is to tell the truth: pdftk needs the library and itext provides it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 --- Comment #3 from Andrew Haley a...@redhat.com 2009-02-16 07:33:43 EDT --- Thinking about this some more, simply exporting itext-2.1.4.jar.so is probably wrong. When itext gets rebuilt, we need to rebuild pdftk as well. So I think we're going to need a versioned symlink: itext-2.1.4.jar.so - itext-2.1.4-1.fc10.jar.so and export the full version rather than itext-2.1.4.jar.so. We don't know for certain that any minor change to itext will require pdftk to be recompiled. but it might. so it's safer to insist on an exact build match. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485641] Review Request: pdftk - The PDF Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485641 Orcan 'oget' Ogetbil oget.fed...@gmail.com changed: What|Removed |Added CC||oget.fed...@gmail.com --- Comment #1 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-02-16 02:40:24 EDT --- I think that we will need to hack either the provides list of itext, or the requires list of pdftk. I'm not sure which one is the best solution. Let's consult to fedora-java people. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
