[Bug 486977] Review Request: gnu-free-fonts

2009-03-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486977


Jon Ciesla l...@jcomserv.net changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #20 from Jon Ciesla l...@jcomserv.net  2009-03-24 08:27:59 EDT ---
Awesome, thanks for you review and font education.  Orion, I'll take over the
new package.  You want co-maintainership?


New Package CVS Request
===
Package Name: gnu-free-fonts
Short Description: Free UCS Outline Fonts
Owners: limb
Branches: 
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486977] Review Request: gnu-free-fonts

2009-03-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486977





--- Comment #21 from Orion Poplawski or...@cora.nwra.com  2009-03-24 09:31:05 
EDT ---
(In reply to comment #20)
 Awesome, thanks for you review and font education.  Orion, I'll take over the
 new package.  You want co-maintainership?

Works for me.

New Package CVS Request

==
Package Name: gnu-free-fonts
Short Description: Free UCS Outline Fonts
Owners: limb orion
Branches: 
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486977] Review Request: gnu-free-fonts

2009-03-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486977


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #22 from Kevin Fenzi ke...@tummy.com  2009-03-24 13:34:21 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486977] Review Request: gnu-free-fonts

2009-03-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486977


Jon Ciesla l...@jcomserv.net changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




--- Comment #23 from Jon Ciesla l...@jcomserv.net  2009-03-24 14:30:52 EDT ---
Imported and built.  Bugs for known dependant packages updated.  freefont EOL
ticket updated.

Thanks all!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486977] Review Request: gnu-free-fonts

2009-03-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486977


Jon Ciesla l...@jcomserv.net changed:

   What|Removed |Added

   Flag|needinfo?(l...@jcomserv.net |
   |)   |




--- Comment #17 from Jon Ciesla l...@jcomserv.net  2009-03-23 11:34:08 EDT ---
SPEC: http://zanoni.jcomserv.net/fedora/gnu-free-fonts/gnu-free-fonts.spec
SRPM:
http://zanoni.jcomserv.net/fedora/gnu-free-fonts/gnu-free-fonts-20090104-10.fc10.src.rpm
 

Fixed, and I moved closer to the template.  I agree that this is getting old,
but I'm learning font packaging as I go.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486977] Review Request: gnu-free-fonts

2009-03-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486977


Nicolas Mailhot nicolas.mail...@laposte.net changed:

   What|Removed |Added

 AssignedTo|nicolas.mail...@laposte.net |l...@jcomserv.net
   Flag|fedora-review?  |fedora-review+




--- Comment #18 from Nicolas Mailhot nicolas.mail...@laposte.net  2009-03-23 
17:58:38 EDT ---
Ok, this one looks good. Can't test it fully because of bug #491764 but it
passes my other tests

♼♼♼ APPROVED ♼♼♼

Please make sure the other steps in
http://fedoraproject.org/wiki/Upgrade_paths_%E2%80%94_renaming_or_splitting_packages#Source_package_naming_changes

are taken care of. Also I think you deserve at least co-maintainership of the
new package. Congratulations

This is about the worst-case font packaging scenario you can get in Fedora so
if you don't forget what you've learnt here you should be able to package about
any font now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486977] Review Request: gnu-free-fonts

2009-03-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486977





--- Comment #19 from Orion Poplawski or...@cora.nwra.com  2009-03-23 18:03:52 
EDT ---
Oh, I'd love to give this package up to whoever wants it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486977] Review Request: gnu-free-fonts

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486977


Nicolas Mailhot nicolas.mail...@laposte.net changed:

   What|Removed |Added

   Flag||needinfo?(l...@jcomserv.net
   ||)




--- Comment #16 from Nicolas Mailhot nicolas.mail...@laposte.net  2009-03-21 
05:50:58 EDT ---
And now you have another kind of dangling symlink

/etc/fonts/conf.d/60-gnu-free-mono.conf -
/usr/share/fontconfig/conf.avail/gnu-free-mono.conf

Would it be so hard to just use the pattern documented in the official spec
templates instead of exploring every possible broken alternative? This is
getting really old.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486977] Review Request: gnu-free-fonts

2009-03-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486977





--- Comment #15 from Jon Ciesla l...@jcomserv.net  2009-03-20 09:08:39 EDT ---
I feel your pain. :)

SPEC: http://zanoni.jcomserv.net/fedora/gnu-free-fonts/gnu-free-fonts.spec
SRPM:
http://zanoni.jcomserv.net/fedora/gnu-free-fonts/gnu-free-fonts-20090104-9.fc10.src.rpm
 

Fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486977] Review Request: gnu-free-fonts

2009-03-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486977


Nicolas Mailhot nicolas.mail...@laposte.net changed:

   What|Removed |Added

   Flag||needinfo?(l...@jcomserv.net
   ||)




--- Comment #12 from Nicolas Mailhot nicolas.mail...@laposte.net  2009-03-19 
14:31:17 EDT ---
Ok, you're producing the right package names at last

But you compat package is still requiring package names that do not match what
you build

And if you look in /usr/share/fontconfig/conf.avail/ you'll see the files you
pack do not match what other packages do.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486977] Review Request: gnu-free-fonts

2009-03-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486977


Jon Ciesla l...@jcomserv.net changed:

   What|Removed |Added

   Flag|needinfo?(l...@jcomserv.net |
   |)   |




--- Comment #13 from Jon Ciesla l...@jcomserv.net  2009-03-19 15:08:04 EDT ---
facepalm  I fixed the Requires.  I see nothing in /u/s/fc/conf.avail, do you
mean /etc/fonts/conf.avail?  If so, my files resemble those, but are not so
complex.  They're a straight filling in of a template.  If they need
enhancement or alteration, I'm not sure where to go next with them, as I have
only a vague idea what these files do, and not much idea *how*.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486977] Review Request: gnu-free-fonts

2009-03-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486977





--- Comment #14 from Nicolas Mailhot nicolas.mail...@laposte.net  2009-03-19 
16:36:24 EDT ---
Sorry, I was not clear. -ENOSLEEP

Your spec produces dangling symlinks that won't work, such as

/etc/fonts/conf.d/60-gnu-free-sans.conf -
/usr/share/fontconfig/conf.avail/gnu-free-sans

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486977] Review Request: gnu-free-fonts

2009-03-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486977


Jon Ciesla l...@jcomserv.net changed:

   What|Removed |Added

   Flag|needinfo?(l...@jcomserv.net |
   |)   |




--- Comment #10 from Jon Ciesla l...@jcomserv.net  2009-03-18 09:17:53 EDT ---
Fixed 1, 2, 3, and 4.

SPEC: http://zanoni.jcomserv.net/fedora/gnu-free-fonts/gnu-free-fonts.spec
SRPM:
http://zanoni.jcomserv.net/fedora/gnu-free-fonts/gnu-free-fonts-20090104-8.fc10.src.rpm
 

Re the symlinks, why do we use absolute and not relative symlinks in font
pacakges?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486977] Review Request: gnu-free-fonts

2009-03-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486977





--- Comment #11 from Nicolas Mailhot nicolas.mail...@laposte.net  2009-03-18 
09:34:32 EDT ---
(In reply to comment #10)

 Re the symlinks, why do we use absolute and not relative symlinks in font
 pacakges?  

Because it's simpler and FPC already decided the rpmlint warning about absolute
symlinks was trashable. But they're ok not requiring our rpmlint packager to
remove it and having people waste their time in reviews over it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486977] Review Request: gnu-free-fonts

2009-03-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486977


Nicolas Mailhot nicolas.mail...@laposte.net changed:

   What|Removed |Added

   Flag||needinfo?(l...@jcomserv.net
   ||)




--- Comment #9 from Nicolas Mailhot nicolas.mail...@laposte.net  2009-03-14 
14:52:33 EDT ---
Another pass:

1. you're not defining fontname as intended by the template and as a result you
have weird package names such as gnu-free-fonts-mono-fonts instead of a nice
gnu-free-mono-fonts
fontname shoud not have the same value as name or we would not bother with it

2. your fontconfig symlinks are broken
lrw-r--r--1 rootroot   52 mars 14 19:35
/etc/fonts/conf.d/60-gnu-free-fonts-mono.conf -
/usr/share/fontconfig/conf.avail/gnu-free-fonts-m
ono
-rw-r--r--1 rootroot  334 mars  5 21:46
/usr/share/fontconfig/conf.avail/60-gnu-free-fonts-mono.conf

It would probably simpler if you just used the symlinking logic proposed by the
template

3. Your compat package
Requires:  gnu-free-fonts-freemono-fonts = %{version}-%{release}
Requires:  gnu-free-fonts-freesans-fonts = %{version}-%{release}
Requires:  gnu-free-fonts-freeserif-fonts = %{version}-%{release}
But your srpm generates subpackages named differently, so it won't work

4. rpmlint points some minor problems
W: spelling-error-in-description compatability compatibility
E: description-line-too-long This package only exists to help transition pre
20090104-4 freefotn users to the new\
W: summary-not-capitalized freefont compatibility package

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486977] Review Request: gnu-free-fonts

2009-03-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486977





--- Comment #8 from Jon Ciesla l...@jcomserv.net  2009-03-09 09:41:31 EDT ---
Fixed.

SPEC: http://zanoni.jcomserv.net/fedora/gnu-free-fonts/gnu-free-fonts.spec
SRPM:
http://zanoni.jcomserv.net/fedora/gnu-free-fonts/gnu-free-fonts-20090104-7.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486977] Review Request: gnu-free-fonts

2009-03-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486977


Jon Ciesla l...@jcomserv.net changed:

   What|Removed |Added

 Blocks||479238




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486977] Review Request: gnu-free-fonts

2009-03-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486977


Jon Ciesla l...@jcomserv.net changed:

   What|Removed |Added

   Flag|needinfo?(l...@jcomserv.net |
   |)   |




--- Comment #2 from Jon Ciesla l...@jcomserv.net  2009-03-05 11:55:23 EDT ---
Corrected all but 9.  Can't test if 9 is needed in rawhide as mock builds are
failing at the yum step with 404s, even with a fresh root cache.  Probably a
temporary issue.

rel-eng ticket: https://fedorahosted.org/fedora-infrastructure/ticket/1225

Otherwise I *think * I hit all your points.

SPEC: http://zanoni.jcomserv.net/fedora/gnu-free-fonts/gnu-free-fonts.spec
SRPM:
http://zanoni.jcomserv.net/fedora/gnu-free-fonts/gnu-free-fonts-20090104-4.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486977] Review Request: gnu-free-fonts

2009-03-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486977





--- Comment #3 from Jon Ciesla l...@jcomserv.net  2009-03-05 13:45:44 EDT ---
Sorted out mock.  Yup, it needs -lang=ff.

SPEC: http://zanoni.jcomserv.net/fedora/gnu-free-fonts/gnu-free-fonts.spec
SRPM:
http://zanoni.jcomserv.net/fedora/gnu-free-fonts/gnu-free-fonts-20090104-5.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486977] Review Request: gnu-free-fonts

2009-03-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486977





--- Comment #4 from Nicolas Mailhot nicolas.mail...@laposte.net  2009-03-05 
15:13:58 EDT ---
We're getting there :)

1. you still have at least one %define in common_desc (probably did not notice
it because you've reordered the template)

2.you still have a needless group declaration in your common package

3. you should simplify your subpackage names (for example use
%{fontname}-mono-fonts instead of %{fontname}-freemono-fonts). Repeating the
project name does not really help users.

4. you need to drop
Requires:  gnu-free-fonts-freemono-fonts = %{version}-%{release}
Requires:  gnu-free-fonts-freesans-fonts = %{version}-%{release}
Requires:  gnu-free-fonts-freeserif-fonts = %{version}-%{release}

Obsoletes: freefont  20090104-2

from your main package

5. you probably don't need to obsolete package names that were never pushed to
user systems, this obsolete data will never be used

6. you don't need
%dir %{_fontdir}
in your common package

7. you can unroll the for loop, but if you do so make sure you don't reference
the for variable anymore

8. your fontconfig rule filenames need to start with a number to work (in your
case 60 is probably fine, see
/usr/share/fontconfig/templates/fontconfig-priorities.txt)

9. your fontconfig rules won't work if you just put the font name everywhere
blindly. See /usr/share/fontconfig/templates/fontconfig-generics.txt and 
/usr/share/fontconfig/templates/basic-font-template.txt

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486977] Review Request: gnu-free-fonts

2009-03-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486977





--- Comment #5 from Jon Ciesla l...@jcomserv.net  2009-03-05 15:53:44 EDT ---
Better?

SPEC: http://zanoni.jcomserv.net/fedora/gnu-free-fonts/gnu-free-fonts.spec
SRPM:
http://zanoni.jcomserv.net/fedora/gnu-free-fonts/gnu-free-fonts-20090104-6.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486977] Review Request: gnu-free-fonts

2009-03-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486977





--- Comment #6 from Jens Petersen peter...@redhat.com  2009-03-05 19:12:09 
EDT ---
*** Bug 479238 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486977] Review Request: gnu-free-fonts

2009-03-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486977


Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

 CC||peter...@redhat.com




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486977] Review Request: gnu-free-fonts

2009-03-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486977


Nicolas Mailhot nicolas.mail...@laposte.net changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||fedora-fonts-bugs-l...@redh
   ||at.com
 Depends on||212079
 AssignedTo|nob...@fedoraproject.org|nicolas.mail...@laposte.net
   Flag||fedora-review?,
   ||needinfo?(l...@jcomserv.net
   ||)




--- Comment #1 from Nicolas Mailhot nicolas.mail...@laposte.net  2009-03-02 
17:18:04 EDT ---
Thank you very much for working on this. Here is a first review pass:

1. FPC and FESCO have decided %global was preferred over %define. The changes
are in fontpackages 1.20, please apply them
http://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define

2. Please try to keep the same declaration order as the templates, that makes
diffing  reviewing easier

3. Please do not make a metapackage of the main package, if you need a
metapackage for upgrade paths create a -compat subpackage that we'll be able to
kill at F12 time

http://fedoraproject.org/wiki/Upgrade_paths_%E2%80%94_renaming_or_splitting_packages#Can.27t_I_use_my_old_package_name_instead_of_a_-compat_subpackage.3F

vera, mgopen, dejavu, liberation, etc all use this proven pattern

4. you can probably drop the
Obsoletes: freefont-ttf  %{version}-%{release}
freefont has been named freefont in Fedora for quite a long time

5. In rawhide you can drop the
Group:User Interface/X
declarations in subpackages

6. use the
%package -n %{fontname}-FAMILY-fonts
%description -n %{fontname}-FAMILY-fonts
%_font_pkg -n FAMILY -f %{fontconf}-FAMILY.conf NAME*.ttf

which is documented in the templates if you want stuff to actually work

7. put doc in the common package, that's one of its main uses

8. BuildRequire fontforge

9. You'll likely hit
http://www.redhat.com/archives/fedora-fonts-list/2009-February/msg00076.html
too

10. Please add fontconfig rules to each font subpackages. In your case that's
probably just taking the
/usr/share/fontconfig/templates/basic-font-template.conf
template and filling in font names

11. Please also make sure you've not forgotten a step in
http://fedoraproject.org/wiki/Upgrade_paths_%E2%80%94_renaming_or_splitting_packages#Source_package_naming_changes

That's all I see right now, I may have missed something else, multi-font
packages can be trickier than mono-font ones. But first fix this please

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review