[Bug 504477] Review Request: rubygem-launchy - Helper class for cross-platform launching of applications
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=504477
--- Comment #6 from Michal Fojtik mfoj...@redhat.com 2010-01-08 10:26:41 EDT
---
# MUST: rpmlint must be run on every package. The output should be posted in
the review.
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
# MUST: The package must be named according to the Package Naming Guidelines .
OK
# MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
OK
# MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
OK
# MUST: The spec file must be written in American English.
OK
# MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
http://gems.rubyforge.org/gems
# MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present.
OK
# MUST: Header files must be in a -devel package.
There is no headers.
# MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
OK
# MUST: All filenames in rpm packages must be valid UTF-8.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504477] Review Request: rubygem-launchy - Helper class for cross-platform launching of applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504477 --- Comment #7 from Michal Fojtik mfoj...@redhat.com 2010-01-08 10:36:32 EDT --- Fixed revision number: SPEC: http://mifo.sk/rubygem-launchy.spec SRPM: http://mifo.sk/rubygem-launchy-0.3.5-1.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504477] Review Request: rubygem-launchy - Helper class for cross-platform launching of applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504477 Michal Fojtik mfoj...@redhat.com changed: What|Removed |Added CC||mfoj...@redhat.com --- Comment #4 from Michal Fojtik mfoj...@redhat.com 2010-01-07 08:58:16 EDT --- SPEC: http://mifo.sk/rubygem-launchy.spec SRPM: http://mifo.sk/rubygem-launchy-0.3.5-4.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504477] Review Request: rubygem-launchy - Helper class for cross-platform launching of applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504477 --- Comment #5 from Lubomir Rintel lkund...@v3.sk 2010-01-07 09:34:59 EDT --- For the sake of review, I agree with all Michal's changes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504477] Review Request: rubygem-launchy - Helper class for cross-platform launching of applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504477 Michal Ingeli m...@v3.sk changed: What|Removed |Added Status|NEW |ASSIGNED CC||m...@v3.sk AssignedTo|nob...@fedoraproject.org|m...@v3.sk Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504477] Review Request: rubygem-launchy - Helper class for cross-platform launching of applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504477 --- Comment #3 from Michal Ingeli m...@v3.sk 2009-07-16 11:45:46 EDT --- * builds in mock * rpmlint silent * source matches upstream * naming OK * clean spec file, american english * naming OK * file list, doc list OK * provides/requires OK - fix license, should be BSD [1] Note that provided spec file and srpm spec file differs. [1] http://copiousfreetime.rubyforge.org/launchy/LICENSE.html -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504477] Review Request: rubygem-launchy - Helper class for cross-platform launching of applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504477 Bug 504477 depends on bug 504480, which changed state. Bug 504480 Summary: Review Request: rubygem-configuration - Pure Ruby scoped configuration files https://bugzilla.redhat.com/show_bug.cgi?id=504480 What|Old Value |New Value Status|NEW |ASSIGNED Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504477] Review Request: rubygem-launchy - Helper class for cross-platform launching of applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504477 --- Comment #2 from Lubomir Rintel lkund...@v3.sk 2009-06-27 02:30:12 EDT --- SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-launchy.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-launchy-0.3.3-3.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504477] Review Request: rubygem-launchy - Helper class for cross-platform launching of applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504477 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Blocks||504472 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504477] Review Request: rubygem-launchy - Helper class for cross-platform launching of applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504477 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Depends on||504480 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504477] Review Request: rubygem-launchy - Helper class for cross-platform launching of applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504477 --- Comment #1 from Lubomir Rintel lkund...@v3.sk 2009-06-08 07:44:46 EDT --- Attempted to incorporate comments from here: https://bugzilla.redhat.com/show_bug.cgi?id=504469#c1 SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-launchy.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-launchy-0.3.3-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
