[Bug 526876] Review Request: php-pecl-gmagick - Provides a wrapper to the GraphicsMagick library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526876 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2009-12-01 13:26:24 EDT --- php-pecl-gmagick-1.0.2b1-3.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 526876] Review Request: php-pecl-gmagick - Provides a wrapper to the GraphicsMagick library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526876 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||1.0.2b1-3.el5 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 526876] Review Request: php-pecl-gmagick - Provides a wrapper to the GraphicsMagick library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526876 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2009-11-25 10:27:12 EDT --- php-pecl-gmagick-1.0.2b1-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 526876] Review Request: php-pecl-gmagick - Provides a wrapper to the GraphicsMagick library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526876 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2009-11-05 16:28:08 EDT --- php-pecl-gmagick-1.0.2b1-3.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update php-pecl-gmagick'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0795 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 526876] Review Request: php-pecl-gmagick - Provides a wrapper to the GraphicsMagick library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526876 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2009-11-04 06:39:05 EDT --- php-pecl-gmagick-1.0.2b1-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/php-pecl-gmagick-1.0.2b1-3.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 526876] Review Request: php-pecl-gmagick - Provides a wrapper to the GraphicsMagick library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526876 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2009-11-04 06:46:53 EDT --- php-pecl-gmagick-1.0.2b1-3.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/php-pecl-gmagick-1.0.2b1-3.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 526876] Review Request: php-pecl-gmagick - Provides a wrapper to the GraphicsMagick library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526876
--- Comment #5 from Andrew Colin Kissa and...@topdog.za.net 2009-11-03
05:08:06 EDT ---
OK: rpmlint must be run on every package
rpmlint rpmbuild/SRPMS/php-pecl-gmagick-1.0.2b1-2.fc11.src.rpm
rpmbuild/RPMS/i586/php-pecl-gmagick-1.0.2b1-2.fc11.i586.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
OK: The package must be named according to the Package Naming Guidelines
OK: The spec file name must match the base package
OK: The package must meet the Packaging Guidelines
OK: The package must be licensed with a Fedora approved license
OK: The License field in the package spec file must match the actual license
OK: License text included
OK: The spec file must be written in American English
FIX: The spec file for the package MUST be legible
OK: The sources used to build the package must match the upstream source
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture
N\A: ExcludeArch
OK: All build dependencies must be listed in BuildRequires
N\A: The spec file MUST handle locales properly
N\A: Must call ldconfig in %post and %postun
N\A: If the package is designed to be relocatable
OK: A package must own all directories that it creates
OK: A Fedora package must not list a file more than once
OK: Permissions on files must be set properly
OK: Each package must have a %clean section
FIX: Each package must consistently use macros
OK: The package must contain code, or permissable content
N\A: Large documentation files must go in a -doc subpackage
OK: If a package includes something as %doc, it must not affect the runtime of
the application
N\A: Header files must be in a -devel package
N\A: Static libraries must be in a -static package
N\A: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
N\A: Library files that end in .so (without suffix) must go in a -devel package
N\A: In the vast majority of cases, devel packages must require the base
package
OK: Packages must NOT contain any .la libtool archives
N\A: Packages containing GUI applications must include a %{name}.desktop file
OK: Packages must not own files or directories already owned by other packages
OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
OK: All filenames in rpm packages must be valid UTF-8
Issues to fix.
* Consistent use of macros
- if using the %{__make} style macros then you need to be consistent, i.e use
%{__install}, %{__rm}, %{__chmod} etc
* Make the spec more eligible by formatting it correctly, at the moment the
directives at the top are not aligned.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 526876] Review Request: php-pecl-gmagick - Provides a wrapper to the GraphicsMagick library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526876
--- Comment #6 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info
2009-11-03 05:29:30 EDT ---
(In reply to comment #5)
* Consistent use of macros
- if using the %{__make} style macros then you need to be consistent, i.e use
%{__install}, %{__rm}, %{__chmod} etc
%{__make} replaced to plain make.
Additionally %{?_smp_mflags} added.
* Make the spec more eligible by formatting it correctly, at the moment the
directives at the top are not aligned.
Top directives are ALIGNED with tabs by width 5 spaces. Please read my first
post.
http://hubbitus.net.ru/rpm/Fedora11/php-pecl-gmagick/php-pecl-gmagick-1.0.2b1-3.fc11.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 526876] Review Request: php-pecl-gmagick - Provides a wrapper to the GraphicsMagick library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526876
Andrew Colin Kissa and...@topdog.za.net changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #7 from Andrew Colin Kissa and...@topdog.za.net 2009-11-03
05:38:43 EDT ---
The %{__make} install needs to be fixed as well, you can do that before
requesting CVS
---
This package (php-pecl-gmagick) is APPROVED by topdog
---
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 526876] Review Request: php-pecl-gmagick - Provides a wrapper to the GraphicsMagick library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526876
--- Comment #8 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info
2009-11-03 06:03:49 EDT ---
(In reply to comment #7)
The %{__make} install needs to be fixed as well, you can do that before
requesting CVS
Upss, sorry. Thanks, I'll fix it.
---
This package (php-pecl-gmagick) is APPROVED by topdog
---
Thank you for review.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 526876] Review Request: php-pecl-gmagick - Provides a wrapper to the GraphicsMagick library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526876 Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 2009-11-03 09:56:00 EDT --- New Package CVS Request === Package Name: php-pecl-gmagick Short Description: Provides a wrapper to the GraphicsMagick library Owners: hubbitus Branches: F-10 F-11 F-12 EL-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 526876] Review Request: php-pecl-gmagick - Provides a wrapper to the GraphicsMagick library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526876 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #10 from Kevin Fenzi ke...@tummy.com 2009-11-03 14:11:08 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 526876] Review Request: php-pecl-gmagick - Provides a wrapper to the GraphicsMagick library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526876 Andrew Colin Kissa and...@topdog.za.net changed: What|Removed |Added CC||and...@topdog.za.net AssignedTo|nob...@fedoraproject.org|and...@topdog.za.net Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 526876] Review Request: php-pecl-gmagick - Provides a wrapper to the GraphicsMagick library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526876 --- Comment #4 from Andrew Colin Kissa and...@topdog.za.net 2009-11-02 01:51:29 EDT --- I will do a full review of this later today. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 526876] Review Request: php-pecl-gmagick - Provides a wrapper to the GraphicsMagick library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526876 Andrew Colin Kissa and...@topdog.za.net changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 526876] Review Request: php-pecl-gmagick - Provides a wrapper to the GraphicsMagick library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526876 --- Comment #3 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 2009-10-11 16:44:26 EDT --- Author include license by my request and update tarball. http://hubbitus.net.ru/rpm/Fedora11/php-pecl-gmagick/php-pecl-gmagick-1.0.2b1-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 526876] Review Request: php-pecl-gmagick - Provides a wrapper to the GraphicsMagick library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526876 Thomas Janssen thom...@fedoraproject.org changed: What|Removed |Added CC||thom...@fedoraproject.org --- Comment #1 from Thomas Janssen thom...@fedoraproject.org 2009-10-04 09:28:35 EDT --- MUST: rpmlint must be run on every package. The output should be posted in the review. [tho...@tusdell ~]$ rpmlint srpm-review-test/php-pecl-gmagick.spec srpm-review-test/php-pecl-gmagick.spec: E: specfile-error sh: php-config: command not found srpm-review-test/php-pecl-gmagick.spec: E: specfile-error error: Macro %php_extdir has empty body 0 packages and 1 specfiles checked; 2 errors, 0 warnings. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 526876] Review Request: php-pecl-gmagick - Provides a wrapper to the GraphicsMagick library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526876 --- Comment #2 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 2009-10-04 11:56:01 EDT --- (In reply to comment #1) sh: php-config: command not found You simply does not have php-devel installed. If you install this package erro must be gone. php-devel listed as BR, so nothing error there. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
