[Bug 531379] Review Request: apache-commons-jexl - Java Expression Language (JEXL)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531379 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #8 from Alexander Kurtakov akurt...@redhat.com 2010-01-09 12:29:08 EST --- Looks good. This package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531379] Review Request: apache-commons-jexl - Java Expression Language (JEXL)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531379 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|akurt...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531379] Review Request: apache-commons-jexl - Java Expression Language (JEXL)
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=531379
--- Comment #5 from Alexander Kurtakov akurt...@redhat.com 2010-01-09
05:46:42 EST ---
Rpmlint warnings:
* apache-commons-jexl.spec:59: W: non-standard-group Development Documentation
FIXIT Documentation only should be ok
* apache-commons-jexl.spec:141: W: libdir-macro-in-noarch-package (main
package) %attr(-,root,root) %{_libdir}/gcj/%{name}
FIXIT There is no usage of the gcj_support nowadays and most of the java
packagers are actively dropping it from their spec files. Please keep it if you
have some strong usage for it otherwise it's just cluttering the spec and
making the package needlessly arch specific. Also if you decide to keep it
please mark the javadoc subpackage as noarch.
* apache-commons-jexl.i686: W: non-conffile-in-etc
/etc/maven/fragments/apache-commons-jexl
This is ok. Maven is working in a strange way so we have to live with it.
Review:
OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption..
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK: The spec file must be written in American English.
OK: The spec file for the package MUST be legible.
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL.
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
OK: All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory.
OK: A Fedora package must not list a file more than once in the spec file's
%files listings.
OK: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
OK: Each package must have a %clean section, which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
OK: Each package must consistently use macros.
OK: The package must contain code, or permissable content.
OK: Large documentation files must go in a -doc subpackage. Javadoc in this
case.
OK: If a package includes something as %doc, it must not affect the runtime of
the application. To summarize: If it is in %doc, the program must run properly
if it is not present.
OK: Packages must not own files or directories already owned by other packages.
OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
OK: All filenames in rpm packages must be valid UTF-8.
Package looks good. Please take care for the items marked with FIXIT
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531379] Review Request: apache-commons-jexl - Java Expression Language (JEXL)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531379 --- Comment #6 from Alexander Kurtakov akurt...@redhat.com 2010-01-09 06:01:00 EST --- One more thing you need to add the following lines in your %prep section: sed -i s|source1.2/source|source1.3/source|g pom.xml sed -i s|target1.2/target|target1.3/target |g pom.xml This is needed because maven in rawhide no longer accepts source 1.2. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531379] Review Request: apache-commons-jexl - Java Expression Language (JEXL)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531379 --- Comment #7 from Orion Poplawski or...@cora.nwra.com 2010-01-09 12:10:24 EST --- * Sat Jan 9 2010 Orion Poplawski or...@cora.nwra.com - 1.1-3 - Drop gcj support - Fix javadoc group - Bump java levels in pom.xml http://www.cora.nwra.com/~orion/fedora/apache-commons-jexl-1.1-3.fc12.src.rpm http://www.cora.nwra.com/~orion/fedora/apache-commons-jexl.spec http://koji.fedoraproject.org/koji/taskinfo?taskID=1911407 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531379] Review Request: apache-commons-jexl - Java Expression Language (JEXL)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531379 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Summary|Review Request: |Review Request: |commons-jexl - Java |apache-commons-jexl - Java |Expression Language (JEXL) |Expression Language (JEXL) --- Comment #4 from Orion Poplawski or...@cora.nwra.com 2010-01-07 16:08:15 EDT --- http://www.cora.nwra.com/~orion/fedora/apache-commons-jexl-1.1-2.fc12.src.rpm http://www.cora.nwra.com/~orion/fedora/apache-commons-jexl.spec * Thu Jan 7 2010 Orion Poplawski or...@cora.nwra.com - 1.1-2 - Rename to apache-commons-jexl -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
