[Bug 542210] Review Request: python-execnet - Elastic Python Deployment

2010-01-08 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542210





--- Comment #5 from Thomas Moschny thomas.mosc...@gmx.de  2010-01-08 05:25:31 
EDT ---
Spec URL: http://thm.fedorapeople.org/python-execnet/python-execnet.spec
SRPM URL:
http://thm.fedorapeople.org/python-execnet/python-execnet-1.0.2-2.fc12.src.rpm

%changelog
* Thu Jan  7 2010 Thomas Moschny thomas.mosc...@gmx.de - 1.0.2-2
- Skip tests that need network access.

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1908811


(In reply to comment #4)
 [-] Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1907032 
 
raise child_exception
 E   OSError: [Errno 13] Permission denied
 /usr/lib/python2.6/subprocess.py:1126: OSError
 [...]
 May you have a look why it failed ?

That was a test failing while trying to connect to localhost via ssh, which
can't work on koji. It is skipped now.

 [-] Log file had lot of warnings, which may be of some interest:
 
 Log warnings:warning: Could not canonicalize hostname:
 x86-01.phx2.fedoraproject.org

That's quite normal, all builds show this for srpm generation.

 Log warnings:/builddir/build/BUILD/execnet-1.0.2/doc/implnotes.txt:4:
 (WARNING/2) Literal block expected; none found.
 Log warnings:preparing documents...
 /builddir/build/BUILD/execnet-1.0.2/doc/example/test_ssh_fileserver.txt::
 WARNING: document isn't included in any toctree
 Log warnings:build succeeded, 3 warnings.

These warnings are emitted while building the documentation. Will ask upstream
about them.

 Log warnings:warning: no previously-included files found matching '*.orig'
 Log warnings:warning: no previously-included files found matching '*.rej'
 Log warnings:warning: no previously-included files matching '*.pyc' found 
 under
 directory 'execnet'
 Log warnings:warning: no previously-included files matching '*$py.class' found
 under directory 'execnet'
 Log warnings:warning: no previously-included files matching '*.pyc' found 
 under
 directory 'testing'
 Log warnings:warning: no previously-included files matching '*$py.class' found
 under directory 'testing'

Completely harmless. The manifest file excludes some files that are not present
in the tarball, but might be in a developer's home.

 May you check what they mean and can they be ignored. Looks like.
 
 Once this is done I will do a detailed review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 542210] Review Request: python-execnet - Elastic Python Deployment

2010-01-08 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542210


Rakesh Pandit rpan...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #6 from Rakesh Pandit rpan...@redhat.com  2010-01-08 08:46:28 EDT 
---
[x] - Ok, [-] Needs input, [na] - Not Applicable

[-]/usr/share/doc/python-execnet-1.0.2/html/.buildinfo remove this file.
[x] Builds fine
[x] name seems fine
[x] spec name fine
[x] rpmlint fine, few messages can be safly ignored
[x] version, release, summary, License, BRs seem to be fine
[x] source ok md5 b3a42aec448ede3ba573cb6c6d00a20b
[x] test check ok
[x] egg generated
[x] py(oc) files
[x] successfully builds
[x] uft-8 file names
[x] american english and legible
[x] description and summary ok
[x] no gui, no libs, 
[x] works fine

Just remove the file .buildinfo .

APPROVED

Thanks,

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 542210] Review Request: python-execnet - Elastic Python Deployment

2010-01-08 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542210


Thomas Moschny thomas.mosc...@gmx.de changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #7 from Thomas Moschny thomas.mosc...@gmx.de  2010-01-08 09:19:51 
EDT ---
Thanks for the review!


New Package CVS Request
===
Package Name: python-execnet
Short Description: Elastic Python Deployment
Owners: thm
Branches: F-12
InitialCC: none

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 542210] Review Request: python-execnet - Elastic Python Deployment

2010-01-08 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542210

Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+

--- Comment #8 from Kevin Fenzi ke...@tummy.com 2010-01-08 23:50:23 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 542210] Review Request: python-execnet - Elastic Python Deployment

2010-01-07 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542210


Rakesh Pandit rpan...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 542210] Review Request: python-execnet - Elastic Python Deployment

2010-01-07 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542210


Rakesh Pandit rpan...@redhat.com changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|rpan...@redhat.com
   Flag||fedora-review?




--- Comment #4 from Rakesh Pandit rpan...@redhat.com  2010-01-07 06:43:57 EDT 
---
[-] Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1907032 

   raise child_exception
E   OSError: [Errno 13] Permission denied
/usr/lib/python2.6/subprocess.py:1126: OSError
 skipped test summary _
/builddir/build/BUILD/execnet-1.0.2/conftest.py:93: [8] Skipped: 'no jython
found'
/builddir/build/BUILD/execnet-1.0.2/conftest.py:93: [8] Skipped: 'no python2.5
found'
/builddir/build/BUILD/execnet-1.0.2/testing/test_serializer.py:20: [30]
Skipped: can't find a 'python3' executable
/usr/lib/python2.6/site-packages/py/impl/test/config.py:201: [55] Skipped: no
'gspecs' value found
/builddir/build/BUILD/execnet-1.0.2/conftest.py:93: [8] Skipped: 'no python3.1
found'
/builddir/build/BUILD/execnet-1.0.2/testing/test_termination.py:46: [1]
Skipped: need 'ps' command to externally check process status
/builddir/build/BUILD/execnet-1.0.2/conftest.py:93: [8] Skipped: 'no python2.7
found'
/builddir/build/BUILD/execnet-1.0.2/testing/test_xspec.py:99: [1] Skipped:
'cpython2.5 not found'
/builddir/build/BUILD/execnet-1.0.2/conftest.py:93: [8] Skipped: 'no pypy-c
found'
/builddir/build/BUILD/execnet-1.0.2/conftest.py:93: [8] Skipped: 'no python2.4
found'
= 1 tests deselected by '-test_info' ==
== 1 failed, 187 passed, 135 skipped, 1 deselected in 13.10 seconds ===
error: Bad exit status from /var/tmp/rpm-tmp.rZDWyL (%check)
Bad exit status from /var/tmp/rpm-tmp.rZDWyL (%check)
RPM build errors:
Child returncode was: 1
EXCEPTION: Command failed. See logs for output.
 # ['bash', '--login', '-c', 'rpmbuild -bb --target noarch --nodeps
builddir/build/SPECS/python-execnet.spec']
Traceback (most recent call last):
  File /usr/lib/python2.4/site-packages/mock/trace_decorator.py, line 70, in
trace
result = func(*args, **kw)
  File /usr/lib/python2.4/site-packages/mock/util.py, line 324, in do
raise mock.exception.Error, (Command failed. See logs for output.\n # %s
% (command,), child.returncode)
Error: Command failed. See logs for output.
 # ['bash', '--login', '-c', 'rpmbuild -bb --target noarch --nodeps
builddir/build/SPECS/python-execnet.spec']
LEAVE do -- EXCEPTION RAISED

May you have a look why it failed ?

[-] Log file had lot of warnings, which may be of some interest:

Log warnings:warning: Could not canonicalize hostname:
x86-01.phx2.fedoraproject.org
Log warnings:/builddir/build/BUILD/execnet-1.0.2/doc/implnotes.txt:4:
(WARNING/2) Literal block expected; none found.
Log warnings:preparing documents...
/builddir/build/BUILD/execnet-1.0.2/doc/example/test_ssh_fileserver.txt::
WARNING: document isn't included in any toctree
Log warnings:build succeeded, 3 warnings.
Log warnings:warning: no previously-included files found matching '*.orig'
Log warnings:warning: no previously-included files found matching '*.rej'
Log warnings:warning: no previously-included files matching '*.pyc' found under
directory 'execnet'
Log warnings:warning: no previously-included files matching '*$py.class' found
under directory 'execnet'
Log warnings:warning: no previously-included files matching '*.pyc' found under
directory 'testing'
Log warnings:warning: no previously-included files matching '*$py.class' found
under directory 'testing'

May you check what they mean and can they be ignored. Looks like.

Once this is done I will do a detailed review.

Thanks,

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 542210] Review Request: python-execnet - Elastic Python Deployment

2009-12-29 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542210





--- Comment #3 from Thomas Moschny thomas.mosc...@gmx.de  2009-12-29 15:35:47 
EDT ---
Updated to 1.0.2:

Spec URL: http://thm.fedorapeople.org/python-execnet/python-execnet.spec
SRPM URL:
http://thm.fedorapeople.org/python-execnet/python-execnet-1.0.2-1.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 542210] Review Request: python-execnet - Elastic Python Deployment

2009-12-06 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542210





--- Comment #2 from Thomas Moschny thomas.mosc...@gmx.de  2009-12-06 12:20:52 
EDT ---
Thanks for the comments, I updated the package. Imho there's no need for a -doc
subpackage, but HTML docs are included now.

Spec URL: http://thm.fedorapeople.org/python-execnet/python-execnet.spec
SRPM URL:
http://thm.fedorapeople.org/python-execnet/python-execnet-1.0.1-1.fc12.src.rpm

%changelog
* Sat Dec  5 2009 Thomas Moschny thomas.mosc...@gmx.de - 1.0.1-1
- Update to 1.0.1.
- Build and include HTML documentation.
- Be a bit more explicit in the %%files section.

A scratch build is here:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1852677

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 542210] Review Request: python-execnet - Elastic Python Deployment

2009-12-05 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542210


Thomas Spura toms...@fedoraproject.org changed:

   What|Removed |Added

 CC||toms...@fedoraproject.org




--- Comment #1 from Thomas Spura toms...@fedoraproject.org  2009-12-05 
09:02:34 EDT ---
The README.txt included in %doc says:

See doc/ for more info, examples and contact info.

So why don't you do a -doc subpackage and include doc/ there?

Being more explicit in %files, like %{python_sitelib}/%{srcname}* would be
great, too.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review