[Bug 548324] Review Request: gitolite - Highly flexible server for git directory version tracker
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=548324
--- Comment #9 from Lubomir Rintel lkund...@v3.sk 2010-01-08 03:38:20 EDT ---
Hi Gerd,
(In reply to comment #7)
The name of the patch is changed, but not the name of the source-file.
I suggest to extend the two lines in the spec-file from
# $ make ed2bf5.tar
Source0:ed2bf5.tar
to
# $ make ed2bf5.tar
# $ mv ed2bf5.tar gitolite-%{version}.tar
# $ gzip -9 gitolite-%{version}.tar
Source0:%{name}-%{version}.tar.gz
Umm, that was an upstream decision (the file name), we don't usually rename
upstream tarballs and I'm reluctant to do so.
(In reply to comment #8)
I tried gitolite from the git. The command to clone the testing repository
works
with:
$ git clone gitolite:testing.git
but using the username and hostname
$ git clone user@host.domain:testing.git again2
gives out the following error:
Initialized empty Git repository in /home/gz016/gitolite/testing/again2/.git/
fatal: 'testing.git': unable to chdir or not a git archive
fatal: The remote end hung up unexpectedly
[gz...@hilton testing]$
The user above is always gitolite. Gitolite doesn't use UNIX
users/permissions to implement access control, it implements its own and
determines the user name from the key used.
Therefore, after initial checkout of gitolite-admin, add your key there, push
back and you should be able to access the repositories.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 548324] Review Request: gitolite - Highly flexible server for git directory version tracker
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=548324
--- Comment #10 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-01-08
04:20:50 EDT ---
(In reply to comment #9)
(In reply to comment #7)
I suggest to extend the two lines in the spec-file from
# $ make ed2bf5.tar
Source0:ed2bf5.tar
to
# $ make ed2bf5.tar
# $ mv ed2bf5.tar gitolite-%{version}.tar
# $ gzip -9 gitolite-%{version}.tar
Source0:%{name}-%{version}.tar.gz
Umm, that was an upstream decision (the file name), we don't usually rename
upstream tarballs and I'm reluctant to do so.
Fedora already has guidelines for creating source tarball
based on the upstream VCS:
https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control
i.e. tarball name must begin with %{name}- in this case, and the tarball
should contain the information about version, revision, etc in
its name.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 548324] Review Request: gitolite - Highly flexible server for git directory version tracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=548324 --- Comment #11 from Lubomir Rintel lkund...@v3.sk 2010-01-08 05:02:51 EDT --- (In reply to comment #10) Fedora already has guidelines for creating source tarball based on the upstream VCS: https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control Thank you, I did not know. I will fix this up upon next package spin (when the full review is done). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 548324] Review Request: gitolite - Highly flexible server for git directory version tracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=548324 Gerd Pokorra g...@zimt.uni-siegen.de changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|g...@zimt.uni-siegen.de --- Comment #12 from Gerd Pokorra g...@zimt.uni-siegen.de 2010-01-08 12:13:30 EDT --- Hi Lubomir, I got the gitolite package configured and cloned a repository from /var/lib/gitolite/repositories. Your instructions in comment #6 was very helpful. I think you should add this in a README file to the package. So other users can start quickly and find the basics to work with the gitolite package. My suggestion is to call the file README.Fedora or README.RPM or CONFIG.Fedora or only README and to add it to your patch (diff -u /dev/null README.Fedora gitolite-0.95-conf.patch) or try to get it in the upstream. If this is done und the source file name is changed for me the RPM for the nice software looks okay. If then not anyone have other comments in the next five days I would like to set the status from the review to done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 548324] Review Request: gitolite - Highly flexible server for git directory version tracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=548324 --- Comment #13 from Lubomir Rintel lkund...@v3.sk 2010-01-08 13:48:19 EDT --- (In reply to comment #12) I got the gitolite package configured and cloned a repository from /var/lib/gitolite/repositories. Your instructions in comment #6 was very helpful. I think you should add this in a README file to the package. So other users can start quickly and find the basics to work with the gitolite package. My suggestion is to call the file README.Fedora or README.RPM or CONFIG.Fedora or only README and to add it to your patch (diff -u /dev/null README.Fedora gitolite-0.95-conf.patch) or try to get it in the upstream. While upstream had really weird deployment process of the thing, I intended not to break the existing documentation when adapting the package to RPM packaging. Is there anything that was unclear, wrong or missing from upstream documentation? In that case we should probably fix it up instead. On the other hand if your idea is just to add a few lines of quick start info, I won't mind adding it. If this is done und the source file name is changed for me the RPM for the nice software looks okay. If then not anyone have other comments in the next five days I would like to set the status from the review to done. This is your review, therefore approval relies upon your findings. If anyone else finds a problem, he's free to open bugs, or commit into the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 548324] Review Request: gitolite - Highly flexible server for git directory version tracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=548324 --- Comment #6 from Lubomir Rintel lkund...@v3.sk 2010-01-07 11:09:28 EDT --- (In reply to comment #5) Here are some annotationes: - Please use the package name as a prefix for the patch/source to avoid conflicts with other packages in the SOURCES directory Done. - the patch needs a comment wrt to the upstream status, i.e. was it sent to upstream or is it upstreamable? Done. (In reply to comment #4) Hi Lubomir, after a short second look I saw that gitolite works without a daemon, so my question for a init-script is nonsense. Would you short discribe me what I have to do to get a testing repository after I have installed the package. Note that the installation and configuration is a bit weird. There are two ways to install gitolite, traditional and easy (remote). Both were adjusted to work with this package. You'll do an easy install like this: Create ~gitolite/.ssh/authorized-keys and add your key there $ gl-easy-install gitolite localhost $LOGNAME The other way to do that would be to su to gitolite user, run gl-install, follow the instructions and then manually populate the gitolite-admin.git repository (and recompile the configuration, as you'd be instructed). New package: SPEC: http://v3.sk/~lkundrak/SPECS/gitolite.spec SRPM: http://v3.sk/~lkundrak/SRPMS/gitolite-0.95-2.20091216git.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 548324] Review Request: gitolite - Highly flexible server for git directory version tracker
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=548324
--- Comment #7 from Gerd Pokorra g...@zimt.uni-siegen.de 2010-01-07 23:06:14
EDT ---
The name of the patch is changed, but not the name of the source-file.
I suggest to extend the two lines in the spec-file from
# $ make ed2bf5.tar
Source0:ed2bf5.tar
to
# $ make ed2bf5.tar
# $ mv ed2bf5.tar gitolite-%{version}.tar
# $ gzip -9 gitolite-%{version}.tar
Source0:%{name}-%{version}.tar.gz
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 548324] Review Request: gitolite - Highly flexible server for git directory version tracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=548324 --- Comment #8 from Gerd Pokorra g...@zimt.uni-siegen.de 2010-01-07 23:41:27 EDT --- I tried gitolite from the git. The command to clone the testing repository works with: $ git clone gitolite:testing.git but using the username and hostname $ git clone user@host.domain:testing.git again2 gives out the following error: Initialized empty Git repository in /home/gz016/gitolite/testing/again2/.git/ fatal: 'testing.git': unable to chdir or not a git archive fatal: The remote end hung up unexpectedly [gz...@hilton testing]$ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 548324] Review Request: gitolite - Highly flexible server for git directory version tracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=548324 --- Comment #5 from Till Maas opensou...@till.name 2010-01-06 09:18:37 EDT --- Here are some annotationes: - Please use the package name as a prefix for the patch/source to avoid conflicts with other packages in the SOURCES directory - the patch needs a comment wrt to the upstream status, i.e. was it sent to upstream or is it upstreamable? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 548324] Review Request: gitolite - Highly flexible server for git directory version tracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=548324 --- Comment #4 from Gerd Pokorra g...@zimt.uni-siegen.de 2009-12-29 12:00:25 EDT --- Hi Lubomir, after a short second look I saw that gitolite works without a daemon, so my question for a init-script is nonsense. Would you short discribe me what I have to do to get a testing repository after I have installed the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 548324] Review Request: gitolite - Highly flexible server for git directory version tracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=548324 --- Comment #3 from Gerd Pokorra g...@zimt.uni-siegen.de 2009-12-28 06:55:18 EDT --- This is a suggestion. A user gitolite will be added by installing the package but will not deleted when the package will be erased. Other packages like mysql-server also do not deleted the user they add so this is only a suggestion: Some lines like this may be added in spec-file: Requires(postun): shadow-utils ... %postun userdel gitolite What about a start-script /etc/init.d/gitolite, so that gitolite will be in the list of the commnad output from chkconfig --list. It would be nice if the server could be started with a simple command by using a default local configuration. I am sorry for having no time to have a closer look to this package at the moment. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 548324] Review Request: gitolite - Highly flexible server for git directory version tracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=548324 Gerd Pokorra g...@zimt.uni-siegen.de changed: What|Removed |Added CC||g...@zimt.uni-siegen.de Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 548324] Review Request: gitolite - Highly flexible server for git directory version tracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=548324 --- Comment #1 from Lubomir Rintel lkund...@v3.sk 2009-12-17 01:10:31 EDT --- RPMlint only complains about gitolite:gitolite not being standard uid:git; which is ok since we create the user. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 548324] Review Request: gitolite - Highly flexible server for git directory version tracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=548324 --- Comment #2 from Lubomir Rintel lkund...@v3.sk 2009-12-17 01:15:29 EDT --- Whoops, here's the correct scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1876573 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
